Consolidate error handling in tegra_i2c_xfer_msg() into a common code
path in order to make code cleaner.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git
Drop '_timeout' postfix from the wait/poll completion function names in
order to make the names shorter, making code cleaner a tad.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 33 +++--
1 file changed, 15
The code related to packet header setting up is a bit messy and makes
tegra_i2c_xfer_msg() more difficult to read than it could be. Let's
factor the packet header setup from tegra_i2c_xfer_msg() into separate
function in order to make code easier to read and follow.
Reviewed-by: Michał Mirosław
Use proper spelling of "NVIDIA" and don't designate driver as Tegra2-only
since newer SoC generations are supported as well.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Improve coding style of the tegra_i2c_wait_for_config_load() function by
removing need to wrap code in order make it more readable and to adhere to
the common kernel coding style.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 34
The driver's code is inconsistent in regards to the error values checking.
The correct way should be to check both positive and negative values.
This patch cleans up the error-checks in the code. Note that the
pm_runtime_get_sync() could return positive value on success, hence only
relevant parts
Factor out hardware initialization into a separate function from the probe
function. The only place where runtime PM needs to be resumed during probe
is the place of hardware initialization, hence it makes sense to factor
out it in order to have a bit cleaner error handling in tegra_i2c_probe().
Rename "ret" variables to "err" in order to make code a bit more
expressive, emphasizing that the returned value is an error code.
Rename variable "reg" to "val" in order to better reflect the actual
usage of the variable in the code and to make naming consistent with
the rest of the code.
Use
On 9/7/20 2:15 PM, Matthew Wilcox wrote:
> On Mon, Aug 31, 2020 at 12:08:10PM -0600, Jens Axboe wrote:
>> We have a set of flags that are shared between the two and inherired
>> in kiocb_set_rw_flags(), but we check and set these individually.
>> Reorder the IOCB flags so that the bottom part of
Technically the tegra_i2c_flush_fifos() may fail and transfer should be
aborted in this case, but this shouldn't ever happen in practice unless
there is a bug somewhere in the driver. Let's add the error check just
for completeness.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
Reorder definition of variables in the code to have them sorted by length
and grouped logically, also replace "unsigned long" with "u32". Do this in
order to make code easier to read.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 100 +++--
1
Make all comments to be consistent in regards to capitalization and
punctuation, correct spelling and grammar errors, improve wording.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 88 ++
1 file changed, 47 insertions(+), 41 deletions(-)
Reorder location of functions in the code in order to have definition
of functions closer to the place of the invocation. This change makes
easier to navigate around the code and removes the need to have a
prototype for tegra_i2c_init().
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry
The pm_runtime_get_sync() always bumps refcount regardless of whether it
succeeds or fails. Hence driver is responsible for restoring of the RPM
refcounting. This patch adds missing RPM puts which restore refcounting
in a case of pm_runtime_get_sync() error.
Suggested-by: Andy Shevchenko
This patch unifies style of all messages in the driver by starting them
with a lowercase letter and using consistent capitalization and wording
for all messages.
Reviewed-by: Michał Mirosław
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 37
Some places in the code are missing newlines or have unnecessary
whitespaces and newlines. This creates inconsistency of the code and
hurts readability. This patch removes the unnecessary and adds necessary
whitespaces / newlines, clears indentation of the code.
Reviewed-by: Michał Mirosław
The tegra_i2c_flush_fifos() shouldn't sleep in atomic transfer and jiffies
are not updating if interrupts are disabled. Let's switch to use iopoll
API helpers for register-polling. The iopoll API provides helpers for both
atomic and non-atomic cases.
Note that this patch doesn't fix any known
The tegra_i2c_issue_bus_clear() may fail and in this case BUS_CLR_DONE
stays unmasked. Hence let's mask it for consistency. This patch doesn't
fix any known problems.
Signed-off-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Hi all,
After merging the v4l-dvb tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/media/test-drivers/vivid/vivid-core.c: In function
'vivid_create_devnodes':
drivers/media/test-drivers/vivid/vivid-core.c:1318:11: warning: unused variable
'i'
--
Hallo,
Ich bin William Yun aus Hongkong. Ich habe ein Geschäft für Sie im Wert
von 24,5 Mio. USD für Sie. Bei Interesse antworten Sie bitte für weitere
Details. williamyun...@gmail.com
Grüße,
William Yun
Geschäftsführer,
& Leiter Personal Banking,
Hang Seng Bank,
Hongkong.
E-Mail:
Hi Masahiro,
On Tue, 8 Sep 2020 09:44:39 +0900 Masahiro Yamada wrote:
>
> As 0-day bot detected, the following commit
> in my kbuild tree turned out to be problematic.
>
> commit 8d77c9acc14a49e4175d7e0d3ce1e256cd31c5a5 (origin/kbuild, kbuild)
> Author: Masahiro Yamada
> Date: Fri Sep 4
Hi Joe,
I love your patch! Yet something to improve:
[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on pm/linux-next linus/master v5.9-rc4 next-20200903]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And
Dear sir/madam,
We offer loan @ low interest rate, Do you need a loan if yes, kindly open our
company website Via email subject to apply.
1944 Madison Avenue, Memphis,
TN 38104, USA
Hi all,
Today's linux-next merge of the vfs tree got a conflict in:
arch/s390/include/asm/checksum.h
between commit:
98ad45fb58c1 ("s390/checksum: coding style changes")
from the s390 tree and commit:
6e41c585e38f ("unify generic instances of csum_partial_copy_nocheck()")
from the vfs
Hi.
cy_huang 於 2020年9月1日 週二 上午10:40寫道:
>
> From: ChiYuan Huang
>
> Add a devicetree binding documentation for the MT6360 Type-C driver.
>
> Signed-off-by: ChiYuan Huang
> ---
> .../bindings/usb/mediatek,mt6360-tcpc.yaml | 95
> ++
> 1 file changed, 95
Hi all,
Today's linux-next merge of the vfs tree got a conflict in:
arch/m68k/Kconfig
between commit:
dc072012bc94 ("m68k: Sort selects in main Kconfig")
Cc: Geert Uytterhoeven
from the m68k tree and commit:
0d4ca5778ffd ("uaccess: add infrastructure for kernel builds with set_fs()")
Hi,
On 09/07/20 at 09:47pm, Chen Zhou wrote:
> CONFIG_PHYSICAL_ALIGN can be selected from 2M to 16M and default
> value is 2M, so move CRASH_ALIGN to 2M, with smaller value reservation
> can have more chance to succeed.
Seems still some misunderstanding about the change :( I'm sorry if I
did
Hi Thierry,
Thanks for review.
On 8/31/20 8:37 PM, Thierry Reding wrote:
> On Mon, Aug 31, 2020 at 12:40:39PM +0800, JC Kuo wrote:
>> This commit implements Tegra210 XUSB PADCTL wake and sleepwalk
>> routines. Sleepwalk logic is in PMC (always-on) hardware block.
>> PMC driver provides managed
+cc linux-pci as I forgot.
On 2020/9/7 19:06, Yicong Yang wrote:
> Previously we use bit field for block_cfg_access and
> msi_enabled/msix_enabled, which is non-atomic and they may race
> each other as they share the same memory region. A race condition
> is met between driver bind vs FLR
+cc linux-pci as I forgot to
On 2020/9/7 19:16, Yicong Yang wrote:
> Previosly we use pci_probe_reset_function() to probe whehter a function
> can be reset and use __pci_reset_function_locked() to perform a function
> reset. These two functions have lots of common lines.
>
> Factor the two
On 2020/09/08 6:56, Chun-Kuang Hu wrote:
Hi Yu Kuai:
Yu Kuai 於 2020年9月5日 週六 下午4:31寫道:
if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
This patch looks
Hi Stephen,
As 0-day bot detected, the following commit
in my kbuild tree turned out to be problematic.
commit 8d77c9acc14a49e4175d7e0d3ce1e256cd31c5a5 (origin/kbuild, kbuild)
Author: Masahiro Yamada
Date: Fri Sep 4 22:31:21 2020 +0900
kbuild: preprocess module linker script
Could
Hi, all
This patch should be backported to 5.4.
Huacai
On Tue, Aug 25, 2020 at 6:03 PM Takashi Iwai wrote:
>
> On Tue, 25 Aug 2020 11:39:48 +0200,
> Tiezhu Yang wrote:
> >
> > This reverts commit 61eee4a7fc40 ("ALSA: hda: Add support for Loongson
> > 7A1000 controller") to fix the following
On Mon, Sep 07, 2020 at 06:25:37PM +0200, Markus Boehme wrote:
> We have observed hosts with misbehaving BMCs that receive a Get Channel
> Info command but don't respond. This leads to an indefinite wait in the
> ipmi_msghandler's __scan_channels function, showing up as hung task
> messages for
On 9/8/2020 01:15, Sasha Levin wrote:
On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote:
// snip
When testing the FN980 with kernel 4.14, I noticed that the qmi device
was not there. Checking the git log, I see that this patch was never
applied. The patch applies fine, so I
On Tue, Sep 08, 2020 at 01:51:19AM +0200, Karol Herbst wrote:
> oh, I somehow missed that "disp ctor failed" message. I think that
> might explain why things are a bit hanging. From the top of my head I
> am not sure if that's something known or something new. But just in
> case I CCed Lyude and
Ah, I figured out why the dma stopped working. In s5pv210-aries.dtsi the dma's
for i2s0
are overriden to use pdma0 instead of pdma1. That also needs changing for this
to
work properly.
Thanks,
Jonathan
On 2020-09-07 5:17 p.m., Jonathan Bakker wrote:
> Initial testing on both an i9000 and an
Initial testing on both an i9000 and an SGH-T959P are showing that the audio has
stopped working with this. I'm not 100% convinced as I've had DMA issues in the
past. However trying to play something just results in a hang after 1.5s while
it works just fine without this patch.
Thanks,
Jonathan
When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy,
the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be
freed in the caller function.
Fix this by calling wlc_phy_detach_lcnphy in the error handler of
wlc_phy_txpwr_srom_read_lcnphy before returning.
On Mon, Sep 07, 2020 at 06:25:36PM +0200, Markus Boehme wrote:
> We have observed hosts with misbehaving BMCs that receive a Get Device
> GUID command but don't respond. This leads to an indefinite wait in the
> ipmi_msghandler's __get_guid function, showing up as hung task messages
> for
Thank you for your comment!
On Mon, Sep 7, 2020 at 2:41 AM Willem de Bruijn
wrote:
>
> On Sun, Sep 6, 2020 at 5:18 AM Xie He wrote:
> >
> > This comment is outdated and no longer reflects the actual implementation
> > of af_packet.c.
>
> If it was previously true, can you point to a commit that
Hi,
after 4 RFC versions I am now sending these patches for real.
The code applies on net-next.
Changes since RFC v4:
- added device-tree binding documentation
- the OF code now checks for linux,default-hw-mode property so that
default HW mode can be set in device tree (like
Many an ethernet PHY supports various HW control modes for LEDs
connected directly to the PHY chip.
This patch adds code for registering such LEDs when described in device
tree and also adds a new private LED trigger called phydev-hw-mode.
When this trigger is enabled for a LED, the various HW
On Mon, Sep 07, 2020 at 06:25:35PM +0200, Markus Boehme wrote:
> When failing to send a command we don't expect a response. Clear the
> `null_user_handler` like is done in the success path.
This is correct. I guess, from the next two patches, I know how you
found this.
I can incude this, but I
This patch adds support for controlling the LEDs connected to several
families of Marvell PHYs via the PHY HW LED trigger API. These families
are: 88E1112, 88E1121R, 88E1240, 88E1340S, 88E1510 and 88E1545. More can
be added.
This patch does not yet add support for compound LED modes. This could
Document binding for LEDs connected to and controlled by ethernet PHY
chips.
Signed-off-by: Marek Behún
Cc: Rob Herring
---
.../devicetree/bindings/net/ethernet-phy.yaml | 31 +++
1 file changed, 31 insertions(+)
diff --git
Hi Krzysztof,
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The S3C RTC requires 32768 Hz clock as input which is provided by PMIC.
> However there is no such clock provider but rather a regulator driver
> which registers the clock as a regulator. This is an old driver which
> will not
Sadly, this is causing issues for me. The machine driver is no longer probing
correctly
on the Galaxy S.
The failing call in sound/soc/samsung/aries_wm8994.c is
/* Set CPU of_node for BT DAI */
aries_dai[2].cpus->of_node = of_parse_phandle(cpu,
On Mon, Sep 7, 2020 at 10:58 PM Marc MERLIN wrote:
>
> On Mon, Sep 07, 2020 at 09:14:03PM +0200, Karol Herbst wrote:
> > > - changes in the nouveau driver. Mika told me the PCIe regression
> > > "pcieport :00:01.0: PME: Spurious native interrupt!" is supposed
> > > to be fixed in 5.8, but
Hi all,
After merging the char-misc.current tree, today's linux-next build
(x86_64 allmodconfig) produced this warning:
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from lib/dynamic_debug.c:16:
lib/dynamic_debug.c: In function
On Sat, 5 Sep 2020 at 06:28, Lyude Paul wrote:
>
> Not entirely sure why this never came up when I originally tested this
> (maybe some BIOSes already have this setup?) but the ->caps_init vfunc
> appears to cause the display engine to throw an exception on driver
> init, at least on my ThinkPad
Works for me on the Galaxy S.
Tested-by: Jonathan Bakker
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The device tree schema expects SPI controller to be named "spi",
> otherwise dtbs_check complain with a warning like:
>
> spi-gpio-0: $nodename:0: 'spi-gpio-0'
Hi all,
Building Linus' tree, today's linux-next build (x86_64 allmodconfig)
produced these warnings:
arch/x86/kernel/cpu/mce/core.o: warning: objtool: mce_panic()+0x2a3:
unreachable instruction
net/core/skbuff.o: warning: objtool: skb_push.cold()+0x1b: unreachable
instruction
Hi again.
On Mon, 2020-09-07 at 15:23 -0700, Eric Biggers wrote:
> On Fri, Sep 04, 2020 at 09:38:23PM -0700, Joe Perches wrote:
> > > > diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c
> > > > index 9212325763b0..c82cc3907e43 100644
> > > > --- a/fs/crypto/crypto.c
> > > > +++
Hi Joe,
I love your patch! Yet something to improve:
[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on pm/linux-next linus/master v5.9-rc4 next-20200903]
[cannot apply to linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And
On Tue, 2020-09-08 at 05:24 +0800, kernel test robot wrote:
> Hi Joe,
Hi robot.
> I love your patch! Yet something to improve:
Nothing really to improve as these are dependent
on a previous patch that this robot did not apply.
Hi Yu Kuai:
Yu Kuai 於 2020年9月5日 週六 下午4:31寫道:
>
> if of_find_device_by_node() succeed, mtk_ddp_comp_init() doesn't have
> a corresponding put_device(). Thus add put_device() to fix the exception
> handling for this function implementation.
>
This patch looks good to me, but I find another thing
kernel test robot reported build errors (undefined references)
that didn't make much sense. After reproducing them, there is also
a Kconfig warning that is the root cause of the build errors, so
fix that Kconfig problem.
Fixes this Kconfig warning:
WARNING: unmet direct dependencies detected for
On Mon, Sep 07, 2020 at 03:40:08PM -0700, Randy Dunlap wrote:
> Hi lkp, (or is it ktr?)
>
> This is sort of a shame-on-you post. As a robot, I hope that you
> don't have any hard feelings about it. :)
Hi Randy, thanks for the input, below warning is helpful to identify
issues, we will add this
Hello,
syzbot found the following issue on:
HEAD commit:f4d51dff Linux 5.9-rc4
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=13686dcd90
kernel config: https://syzkaller.appspot.com/x/.config?x=8f5c353182ed6199
dashboard link:
--
Hallo, ich habe ein Geschäft von 24,5 Mio. USD, das ich mit Ihnen teilen
kann. Wenn Sie interessiert sind? Bitte schreibe zurück und ich werde
dir mehr Details geben.
Grüße,
William.
Audio still works for me on the Galaxy S.
Tested-by: Jonathan Bakker
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The 'audio-subsystem' node is an artificial creation, not representing
> real hardware. The hardware is described by its nodes - AUDSS clock
> controller
Hi lkp, (or is it ktr?)
This is sort of a shame-on-you post. As a robot, I hope that you
don't have any hard feelings about it. :)
On 9/6/20 9:17 AM, kernel test robot wrote:
> Hi Michal,
>
> FYI, the error/warning still remains.
>
> tree:
On Mon, 7 Sep 2020 11:39:05 +0200
Pierre Morel wrote:
> Hi all,
>
> The goal of the series is to give a chance to the architecture
> to validate VIRTIO device features.
Michael, is this going in via your tree?
On Mon, 7 Sep 2020 11:39:07 +0200
Pierre Morel wrote:
> If protected virtualization is active on s390, VIRTIO has only retricted
> access to the guest memory.
> Define CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS and export
> arch_has_restricted_virtio_memory_access to advertize VIRTIO if
On Mon, Sep 7, 2020 at 5:39 PM Lakshmi Ramasubramanian
wrote:
>
> Critical data structures of security modules are currently not measured.
> Therefore an attestation service, for instance, would not be able to
> attest whether the security modules are always operating with the policies
> and
On Mon, 2020-09-07 at 10:59 -0400, st...@rowland.harvard.edu wrote:
> On Mon, Sep 07, 2020 at 01:50:10AM +, Hamish Martin wrote:
> > Hi Alan,
> >
> > Thanks for your quick feedback. My replies are inline below.
> >
> > On Fri, 2020-09-04 at 11:45 -0400, Alan Stern wrote:
> > > On Fri, Sep
On Mon, Sep 07, 2020 at 02:10:26PM -0700, Jakub Kicinski wrote:
On Mon, 7 Sep 2020 12:31:40 -0400 Sasha Levin wrote:
[ Upstream commit 9f13457377907fa253aef560e1a37e1ca4197f9b ]
@@ -2024,10 +2033,14 @@ static int do_reset(struct ibmvnic_adapter *adapter,
} else {
On Fri, Sep 04, 2020 at 09:38:23PM -0700, Joe Perches wrote:
> > > diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c
> > > index 9212325763b0..c82cc3907e43 100644
> > > --- a/fs/crypto/crypto.c
> > > +++ b/fs/crypto/crypto.c
> > > @@ -329,25 +329,27 @@ int fscrypt_initialize(unsigned int
On Mon, 7 Sep 2020 11:39:06 +0200
Pierre Morel wrote:
> An architecture may restrict host access to guest memory,
> e.g. IBM s390 Secure Execution or AMD SEV.
>
> Provide a new Kconfig entry the architecture can select,
> CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, when it provides
> the
Hi, Fabien:
Fabien Parent 於 2020年9月8日 週二 上午12:05寫道:
>
> Hi Chun-Kuang,
>
> > Why don't you add compatible of "mediatek,mt8167-mmsys"?
>
> I forgot to remove 'mmsys' from the commit message. I decided to add
> the documentation as part of the series that add support for MT8167 to
>
On 9/7/20 12:05 AM, Mike Rapoport wrote:
> Hi Randy,
>
> On Sun, Sep 06, 2020 at 12:33:08PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap
>>
>> Fix build errors in Microblaze when CONFIG_MEMORY_ISOLATION is not
>> set/enabled by adding stubs for 3 missing functions.
>
> I've tried to follow
Currently it is not possible to use more than 255 multicast interfaces
for IPv4 due to the format of the igmpmsg header which only has 8 bits
available for the VIF ID. There is space available in the igmpmsg
header to store the full VIF ID in the form of an unused byte following
the VIF ID field.
Use the unused3 byte in struct igmpmsg to hold the high 8 bits of the
VIF ID.
If using more than 255 IPv4 multicast interfaces it is necessary to have
access to a VIF ID for cache reports that is wider than 8 bits, the VIF
ID present in the igmpmsg reports sent to mroute_sk was only 8 bits wide
On Fri, 4 Sep 2020 21:08:37 +0800 Wang Hai wrote:
> rxrpc_min_rtt_wlen is never used after it was introduced.
> So better to remove it.
>
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
Applied.
Insert the multicast route table ID as a Netlink attribute to Netlink
cache report notifications.
When multiple route tables are in use it is necessary to have a way to
determine which route table a given cache report belongs to when
receiving the cache report.
Signed-off-by: Paul Davey
---
Insert the full 16 bit VIF ID into ipmr Netlink cache reports.
The VIF_ID attribute has 32 bits of space so can store the full VIF ID
extracted from the high and low byte fields in the igmpmsg.
Signed-off-by: Paul Davey
---
net/ipv4/ipmr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Works for me on the Galaxy S.
Tested-by: Jonathan Bakker
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The Power Management Unit (PMU) is a separate device which has little
> common with clock controller. Moving it to one level up (from clock
> controller child to
From: Andrea Parri (Microsoft) Sent: Monday, September
7, 2020 9:19 AM
>
> From: Andres Beltran
>
> Currently, pointers to guest memory are passed to Hyper-V as
> transaction IDs in netvsc. In the face of errors or malicious
> behavior in Hyper-V, netvsc should not expose or trust the
From: Andrea Parri (Microsoft) Sent: Monday, September
7, 2020 9:19 AM
>
> From: Andres Beltran
>
> Currently, pointers to guest memory are passed to Hyper-V as
> transaction IDs in storvsc. In the face of errors or malicious
> behavior in Hyper-V, storvsc should not expose or trust the
From: Andrea Parri (Microsoft) Sent: Monday, September
7, 2020 9:19 AM
>
> From: Andres Beltran
>
> Currently, VMbus drivers use pointers into guest memory as request IDs
> for interactions with Hyper-V. To be more robust in the face of errors
> or malicious behavior from a compromised
Works for me on the Galaxy S.
Tested-by: Jonathan Bakker
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> The fixed clocks are kept under dedicated 'external-clocks' node, thus a
> fake 'reg' was added. This is not correct with dtschema as fixed-clock
> binding does not
DMA still works for me on the Galaxy S.
Tested-by: Jonathan Bakker
Thanks,
Jonathan
On 2020-09-07 9:11 a.m., Krzysztof Kozlowski wrote:
> There is no need to keep DMA controller nodes under AMBA bus node.
> Remove the "amba" node to fix dtschema warnings like:
>
> amba: $nodename:0: 'amba'
Looking at this again, it appears that there is actually control for
it at offset 0x6818 of pmu_syscon (0xe0108000) [1]. However, it defaults to
enabled so it's not required for proper use of the block. Whether it should
be present in the schema/DTS is up to you.
Thanks,
Jonathan
[1]
Add the core support for the board management controller found on the
SMARC-sAL28 board.
Also add a virtual symbol which pulls in the simple-mfd-i2c driver and
provide a common symbol on which the subdevice drivers can depend on.
At the moment, this controller is used on the Kontron SMARC-sAL28
Add the board management controller node.
Signed-off-by: Michael Walle
---
Changes since v8:
- none
Changes since v7:
- none
Changes since v6:
- renamed "sl28cpld-r1" to "sl28cpld"
- moved "reg" and "compatible" properties to the top of a node
Changes since v5:
- none
Changes since v4:
The Kontron sl28cpld is a board management chip providing gpio, pwm, fan
monitoring and an interrupt controller. For now this controller is used on
the Kontron SMARC-sAL28 board. But because of its flexible nature, it
might also be used on other boards in the future. The individual blocks
(like
Add support for the hardware monitoring controller of the sl28cpld board
management controller. This driver is part of a multi-function device.
Signed-off-by: Michael Walle
Acked-by: Guenter Roeck
Reviewed-by: Andy Shevchenko
---
Changes since v8:
- none
Changes since v7:
- added "depends
Add support for the interrupt controller inside the sl28 CPLD management
controller.
The interrupt controller can handle at most 8 interrupts and is really
simplistic and consists only of an interrupt mask and an interrupt
pending register.
Signed-off-by: Michael Walle
Acked-by: Marc Zyngier
Add support for the PWM controller of the sl28cpld board management
controller. This is part of a multi-function device driver.
The controller has one PWM channel and can just generate four distinct
frequencies.
Signed-off-by: Michael Walle
Acked-by: Thierry Reding
---
Changes since v8:
-
Enable the kernel modules for the board management controller "sl28cpld"
which is used on the SMARC-sAL28 board.
Signed-off-by: Michael Walle
---
Changes since v8:
- none
Changes since v7:
- added new virtual symbol CONFIG_MFD_SL28CPLD
Changes since v6:
- none
Changes since v5:
- new
Now that we have support for GPIO lines of the SMARC connector, map the
sleep, power and lid switch signals to the corresponding keys using the
gpio-keys and gpio-keys-polled drivers. The power and sleep signals have
dedicated interrupts, thus we use these ones. The lid switch is just
mapped to a
Add support for the GPIO controller of the sl28 board management
controller. This driver is part of a multi-function device.
A controller has 8 lines. There are three different flavors:
full-featured GPIO with interrupt support, input-only and output-only.
Signed-off-by: Michael Walle
Now that we have support for GPIO lines of the SMARC connector, enable
LED support on the KBox A-230-LS. There are two LEDs without fixed
functions, one is yellow and one is green. Unfortunately, it is just one
multi-color LED, thus while it is possible to enable both at the same
time it is hard
Commit
0c2a3913d6f5 ("x86/fpu: Parse clearcpuid= as early XSAVE argument")
changed clearcpuid parsing from __setup() to cmdline_find_option().
While the __setup() function would have been called for each clearcpuid=
parameter on the command line, cmdline_find_option() will only return
the last
Add a pwm-fan mapped to the PWM channel 0 which is connected to the
fan connector of the carrier.
Signed-off-by: Michael Walle
---
Changes since v8:
- none
Changes since v7:
- none
Changes since v6:
- none
Changes since v5:
- none
Changes since v4:
- none
Changes since v3:
- see cover
Critical data structures of security modules are currently not measured.
Therefore an attestation service, for instance, would not be able to
attest whether the security modules are always operating with the policies
and configuration that the system administrator had setup. The policies
and
Hello,
syzbot found the following issue on:
HEAD commit:c70672d8 Merge tag 's390-5.9-5' of git://git.kernel.org/pu..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=163f0c3190
kernel config: https://syzkaller.appspot.com/x/.config?x=bd46548257448703
Add support for the watchdog of the sl28cpld board management
controller. This is part of a multi-function device driver.
Signed-off-by: Michael Walle
Acked-by: Guenter Roeck
---
Changes since v8:
- none
Changes since v7:
- added "depends on MFD_SL28CPLD || COMPILE_TEST"
Changes since v6:
There are I2C devices which contain several different functions but
doesn't require any special access functions. For these kind of drivers
an I2C regmap should be enough.
Create an I2C driver which creates an I2C regmap and enumerates its
children. If a device wants to use this as its MFD core
101 - 200 of 1482 matches
Mail list logo