Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Stephen Rothwell
Hi Kees, On Sun, 4 Oct 2020 01:27:01 -0700 Kees Cook wrote: > > I assume CONFIG_CONSTRUCTORS is enabled for your build (it should be for yes, indeed. > allmodconfig). Does this patch fix it? (I'm kind of blindly guessing > based on my understanding of where this could be coming from...) > >

Re: [PATCH] arch: x86: power: cpu: init %gs before __restore_processor_state (clang)

2020-10-04 Thread Pavel Machek
Hi! > > > > > I believe the kernel makes a questionable assumption on how clang > > > > > uses registers (gs will not be used if stack protection is disabled). > > > > > Both kernel and clang behaves unfortunate here. > > > > > > > > If the kernel is at fault here and this same thing happens with

Re: [ANNOUNCE] Reiser5: Selective File Migration - User Interface

2020-10-04 Thread Pavel Machek
Hi! > > In particular, using this functionality, user is able to push out > > "hot" files on any high-performance device (e.g. proxy device) and pin > > them there. What permissions are normally required for file migration? > > COMMENT. After ioctl successful completion the file is not

Re: [PATCH v2] i2c: pxa: move to generic GPIO recovery

2020-10-04 Thread Codrin.Ciubotariu
On 04.10.2020 12:24, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Sun, Oct 04, 2020 at 12:16:56PM +0300, Codrin Ciubotariu wrote: >> Starting with >> commit 75820314de26 ("i2c: core: add generic I2C

Re: [PATCH v9 11/13] arm64: dts: freescale: sl28: enable LED support

2020-10-04 Thread Pavel Machek
On Mon 2020-09-07 23:38:00, Michael Walle wrote: > Now that we have support for GPIO lines of the SMARC connector, enable > LED support on the KBox A-230-LS. There are two LEDs without fixed > functions, one is yellow and one is green. Unfortunately, it is just one > multi-color LED, thus while it

Re: [PATCH net-next v1 2/3] net: phy: add API for LEDs controlled by ethernet PHY chips

2020-10-04 Thread Pavel Machek
Hi! > Many an ethernet PHY supports various HW control modes for LEDs > connected directly to the PHY chip. > > This patch adds code for registering such LEDs when described in device > tree and also adds a new private LED trigger called phydev-hw-mode. > When this trigger is enabled for a LED,

[PATCH] USB: serial: option: Add Telit FT980-KS composition

2020-10-04 Thread Leonid Bloch
This commit adds the following Telit FT980-KS composition: 0x1054: rndis, diag, adb, nmea, modem, modem, aux AT commands can be sent to /dev/ttyUSB5. Signed-off-by: Leonid Bloch --- The full composition is not tested, and it is the default one according to Telit support. What is tested, is

[PATCH] ASoC: mchp-spdifrx: convert to devm_platform_get_and_ioremap_resource

2020-10-04 Thread Codrin Ciubotariu
Use the helper function that wraps the calls to platform_get_resource() and devm_ioremap_resource() together. Signed-off-by: Codrin Ciubotariu --- sound/soc/atmel/mchp-spdifrx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/atmel/mchp-spdifrx.c

Re: [PATCH] can: raw: add missing error queue support

2020-10-04 Thread Marc Kleine-Budde
On 9/26/20 6:24 PM, Vincent Mailhol wrote: > Error queue are not yet implemented in CAN-raw sockets. > > The problem: a userland call to recvmsg(soc, msg, MSG_ERRQUEUE) on a > CAN-raw socket would unqueue messages from the normal queue without > any kind of error or warning. As such, it prevented

Re: [PATCH v2] i2c: pxa: move to generic GPIO recovery

2020-10-04 Thread Russell King - ARM Linux admin
On Sun, Oct 04, 2020 at 12:16:56PM +0300, Codrin Ciubotariu wrote: > Starting with > commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") > GPIO bus recovery is supported by the I2C core, so we can remove the > driver implementation and use that one instead. > > Signed-off-by: Codrin

[PATCH v2] i2c: pxa: move to generic GPIO recovery

2020-10-04 Thread Codrin Ciubotariu
Starting with commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") GPIO bus recovery is supported by the I2C core, so we can remove the driver implementation and use that one instead. Signed-off-by: Codrin Ciubotariu --- This patch is not tested. Changes in v2: - readded the

[PATCH 1/2] regulator: qcom_smd: add pm8953 regulators

2020-10-04 Thread Vladimir Lypak
The PM8953 is commonly used on board with MSM8953 SoCs or its variants: APQ8053, SDM(SDA)450 and SDM(SDA)632. It provides 7 SMPS and 23 LDO regulators. Signed-off-by: Vladimir Lypak --- drivers/regulator/qcom_smd-regulator.c | 54 ++ 1 file changed, 54 insertions(+)

[PATCH 2/2] dt-bindings: regulator: document pm8950 and pm8953 smd regulators

2020-10-04 Thread Vladimir Lypak
Add list of regulators available on PM8953 and PM8950 PMICs. Also document compatible for PM8953. Signed-off-by: Vladimir Lypak --- .../bindings/regulator/qcom,smd-rpm-regulator.yaml | 5 + 1 file changed, 5 insertions(+) diff --git

Re: BUG: unable to handle kernel paging request in tcf_action_dump_terse

2020-10-04 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:2172e358 Add linux-next specific files for 20201002 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=12ba75ff90 kernel config:

Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller

2020-10-04 Thread Alexandre Belloni
On 04/10/2020 03:43:23+0200, Jonathan Neuschäfer wrote: > > > +static int ntxec_set_time(struct device *dev, struct rtc_time *tm) > > > +{ > > > + struct ntxec_rtc *rtc = dev_get_drvdata(dev); > > > + int res = 0; > > > + > > > + res = regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_YEAR, > > >

[PATCH] soc: qcom: socinfo: add soc ids for msm8953 variants

2020-10-04 Thread Vladimir Lypak
Add SoC IDs for MSM8953, APQ8053, SDM(SDA)450, SDM(SDA)632. Signed-off-by: Vladimir Lypak --- drivers/soc/qcom/socinfo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index b44ede48decc..d21530d24253 100644 ---

[PATCH 2/2] dt-bindings: pinctrl: qcom: add msm8953 pinctrl bindings

2020-10-04 Thread Vladimir Lypak
Add device tree bindings documentation for Qualcomm MSM8953 pinctrl driver. Signed-off-by: Vladimir Lypak --- .../pinctrl/qcom,msm8953-pinctrl.yaml | 160 ++ 1 file changed, 160 insertions(+) create mode 100644

[PATCH 1/2] pinctrl: qcom: add pinctrl driver for msm8953

2020-10-04 Thread Vladimir Lypak
Add inititial pinctrl driver for MSM8953 platform. Compatible SoCs are: MSM8953, APQ8053, SDM(SDA)450, SDM(SDA)632. Based off CAF implementation. Signed-off-by: Prasad Sodagudi Signed-off-by: Vladimir Lypak --- drivers/pinctrl/qcom/Kconfig | 10 + drivers/pinctrl/qcom/Makefile

Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Kees Cook
On Sun, Oct 04, 2020 at 10:24:37AM +1100, Stephen Rothwell wrote: > Hi Kees, > > On Sat, 3 Oct 2020 14:54:46 -0700 Kees Cook wrote: > > > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the tip tree, today's linux-next build (x86_64

Re: [PATCH v2 8/8] selftests/vm: hmm-tests: remove the libhugetlbfs dependency

2020-10-04 Thread John Hubbard
On 10/4/20 12:55 AM, Lukas Bulwahn wrote: On Tue, 29 Sep 2020, John Hubbard wrote: ... John, your change makes: tools/testing/selftests$ make clean fail with: make[1]: Entering directory

[PATCH] scripts: kernel-doc: allow passing desired Sphinx C domain dialect

2020-10-04 Thread Mauro Carvalho Chehab
When kernel-doc is called via kerneldoc.py, there's no need to auto-detect the Sphinx version, as the Sphinx module already knows it. So, add an optional parameter to allow changing the Sphinx dialect. As kernel-doc can also be manually called, keep the auto-detection logic if the parameter was

Re: [PATCH v2 8/8] selftests/vm: hmm-tests: remove the libhugetlbfs dependency

2020-10-04 Thread Lukas Bulwahn
On Tue, 29 Sep 2020, John Hubbard wrote: > HMM selftests are incredibly useful, but they are only effective if > people actually build and run them. All the other tests in selftests/vm > can be built with very standard, always-available libraries: libpthread, > librt. The hmm-tests.c program,

Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Kees Cook
On Sun, Oct 04, 2020 at 10:24:37AM +1100, Stephen Rothwell wrote: > On Sat, 3 Oct 2020 14:54:46 -0700 Kees Cook wrote: > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > > produced this

Re: [PATCH RFC 2/2] kbuild: use interpreters to invoke scripts

2020-10-04 Thread Nathan Chancellor
On Sat, Oct 03, 2020 at 08:51:23PM +0530, Ujjwal Kumar wrote: > We cannot rely on execute bits to be set on files in the repository. > The build script should use the explicit interpreter when invoking any > script from the repository. > > Link: >

Re: [PATCH RFC 1/2] kconfig: use interpreters to invoke scripts

2020-10-04 Thread Nathan Chancellor
On Sat, Oct 03, 2020 at 08:50:10PM +0530, Ujjwal Kumar wrote: > We cannot rely on execute bits to be set on files in the repository. > The build script should use the explicit interpreter when invoking any > script from the repository. > > Link: >

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-04 Thread Avri Altman
> + /* > +* DeepSleep requires the Immediate flag. DeepSleep state is actually > +* entered when the link state goes to Hibern8. > +*/ > + if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE) > + cmd[1] = 1; Shouldn't it be bit1, i.e. cmd[1] = 2 ? >

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 6:04 PM, Jakub Kicinski wrote: External email: Use caution opening links or attachments On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote: enum devlink_attr { /* don't change the order or add anything between, this is ABI! */ DEVLINK_ATTR_UNSPEC, @@ -507,6 +524,7 @@

Re: [PATCH 4/4] ubsan: Disable UBSAN_TRAP for all*config

2020-10-04 Thread Nathan Chancellor
On Fri, Oct 02, 2020 at 03:15:27PM -0700, Kees Cook wrote: > Doing all*config builds attempts build as much as possible. UBSAN_TRAP > effectively short-circuits lib/usban.c, so it should be disabled for > COMPILE_TEST so that the lib/ubsan.c code gets built. > > Signed-off-by: Kees Cook

Re: [PATCH 3/4] ubsan: Force -Wno-maybe-uninitialized only for GCC

2020-10-04 Thread Nathan Chancellor
On Fri, Oct 02, 2020 at 03:15:26PM -0700, Kees Cook wrote: > Clang handles 'maybe-uninitialized' better in the face of using UBSAN, > so do not make this universally disabled for UBSAN builds. > > Signed-off-by: Kees Cook Well this patch is not strictly necessary because Clang does not support

Re: [PATCH net-next 16/16] devlink: Add Documentation/networking/devlink/devlink-reload.rst

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 12:14 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:19PM CEST, mo...@mellanox.com wrote: Add devlink reload rst documentation file. Update index file to include it. Signed-off-by: Moshe Shemesh --- RFCv5 -> v1: - Rename reload_action_limit_level to reload_limit RFCv4 ->

Re: [PATCH v2] net: hso: do not call unregister if not registered

2020-10-04 Thread Greg KH
On Sat, Oct 03, 2020 at 05:00:42PM -0700, David Miller wrote: > From: Greg KH > Date: Fri, 2 Oct 2020 13:43:23 +0200 > > > @@ -2366,7 +2366,8 @@ static void hso_free_net_device(struct hso_device > > *hso_dev, bool bailout) > > > > remove_net_device(hso_net->parent); > > > > - if

Re: [PATCH 2/4] ubsan: Disable object-size sanitizer under GCC

2020-10-04 Thread Nathan Chancellor
On Fri, Oct 02, 2020 at 03:15:25PM -0700, Kees Cook wrote: > GCC's -fsanitize=object-size (as part of CONFIG_UBSAN_MISC) greatly > increases stack utilization. Do not allow this under GCC. > > Suggested-by: Linus Torvalds > Signed-off-by: Kees Cook > Link: >

Re: [PATCH net-next 05/16] devlink: Add remote reload stats

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 12:05 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:08PM CEST, mo...@mellanox.com wrote: Add remote reload stats to hold the history of actions performed due devlink reload commands initiated by remote host. For example, in case firmware activation with reset finished

Re: [PATCH 1/4] ubsan: Move cc-option tests into Kconfig

2020-10-04 Thread Nathan Chancellor
On Fri, Oct 02, 2020 at 03:15:24PM -0700, Kees Cook wrote: > Instead of doing if/endif blocks with cc-option calls in the UBSAN > Makefile, move all the tests into Kconfig and use the Makefile to > collect the results. > > Suggested-by: Linus Torvalds > Signed-off-by: Kees Cook > Link: >

Re: [PATCH net-next 04/16] devlink: Add reload stats

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 12:00 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:07PM CEST, mo...@mellanox.com wrote: Add reload stats to hold the history per reload action type and limit. For example, the number of times fw_activate has been performed on this device since the driver module was added or

Re: [PATCH RFC 1/2] kconfig: use interpreters to invoke scripts

2020-10-04 Thread Lukas Bulwahn
On Sat, 3 Oct 2020, Ujjwal Kumar wrote: > We cannot rely on execute bits to be set on files in the repository. > The build script should use the explicit interpreter when invoking any > script from the repository. > > Link: >

Re: [PATCH RFC 0/2] use interpreters to invoke scripts

2020-10-04 Thread Lukas Bulwahn
On Sat, 3 Oct 2020, Ujjwal Kumar wrote: > This patch series aims at removing the dependency on execute > bit of the scripts in the kbuild system. > Ujjwal, your setup to send out the patch series created three unrelated emails rather than the default way, i.e., to have one cover letter and

[PATCH] drm/amdgpu: remove unintended executable mode

2020-10-04 Thread Lukas Bulwahn
Besides the intended change, commit 3437f5f6c979 ("drm/amdgpu: add gfx support for van gogh (v2)") also set the source files gfx_v10_0.c to be executable, i.e., changed from old mode 644 to new mode 755. Set to the usual mode for source and headers files. No functional change. Signed-off-by:

Re: [PATCH net-next 02/16] devlink: Add reload action option to devlink reload command

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 10:52 AM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:05PM CEST, mo...@mellanox.com wrote: [...] +static int +devlink_nl_reload_actions_performed_snd(struct devlink *devlink, + unsigned long actions_performed, +

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 10:51 AM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:06PM CEST, mo...@mellanox.com wrote: [...] enum devlink_attr { /* don't change the order or add anything between, this is ABI! */ DEVLINK_ATTR_UNSPEC, @@ -507,6 +524,7 @@ enum devlink_attr {

[PATCH] hwmon: fix ptr_ret.cocci warnings

2020-10-04 Thread kernel test robot
From: kernel test robot drivers/hwmon/amd_energy.c:302:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 911766432fd2 ("hwmon: (amd_energy) Improve the accumulation logic") CC: Naveen

Re: [RFC PATCH v1 25/26] docs: reporting-bugs: explain things could be easier

2020-10-04 Thread Thorsten Leemhuis
Am 04.10.20 um 06:03 schrieb Randy Dunlap: > On 10/1/20 1:50 AM, Thorsten Leemhuis wrote: >> +Compared with other Free/Libre & Open Source Software it's hard to reporting >to report Fixed, thx! Ciao, Thorsten

Re: [RFC PATCH v1 24/26] docs: reporting-bugs: explain why users might get neither reply nor fix

2020-10-04 Thread Thorsten Leemhuis
Many thx for you comments. Consider all the obvious spelling and grammatical mistakes you pointed out fixed, I won't mention all of them in this reply to keep things easier to follow. Am 04.10.20 um 06:03 schrieb Randy Dunlap: > On 10/1/20 1:50 AM, Thorsten Leemhuis wrote: >> +selling new

Re: [RFC PATCH v1 20/26] docs: reporting-bugs: instructions for handling regressions

2020-10-04 Thread Thorsten Leemhuis
Many thx for you comments, all suggestions implemented. Ciao, Thorsten

Re: [PATCH net-next 02/16] devlink: Add reload action option to devlink reload command

2020-10-04 Thread Moshe Shemesh
On 10/2/2020 6:19 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:05PM CEST, mo...@mellanox.com wrote: [...] diff --git a/include/net/devlink.h b/include/net/devlink.h index 1c286e9a3590..ddba63bce7ad 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -1077,10 +1077,11 @@

[PATCH] staging: r8188eu: remove unnecessary type casts (struct wlan_bssid_ex *)

2020-10-04 Thread Ivan Safonov
Reduce line length, simplify refactoring. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_ap.c | 10 +- drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ++-- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c

<    1   2   3   4