Re: [PATCH v6 13/25] kbuild: lto: merge module sections

2020-10-14 Thread Kees Cook
On Mon, Oct 12, 2020 at 05:31:51PM -0700, Sami Tolvanen wrote: > LLD always splits sections with LTO, which increases module sizes. This > change adds linker script rules to merge the split sections in the final > module. > > Suggested-by: Nick Desaulniers > Signed-off-by: Sami Tolvanen >

Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps

2020-10-14 Thread Kees Cook
On Mon, Oct 12, 2020 at 05:32:00PM -0700, Sami Tolvanen wrote: > Running objtool --vmlinux --duplicate on vmlinux.o produces a few > warnings about indirect jumps with retpoline: > > vmlinux.o: warning: objtool: wakeup_long64()+0x61: indirect jump > found in RETPOLINE build > ... > > This

Re: linux-next: build failure after merge of the vfio tree

2020-10-14 Thread Alex Williamson
On Thu, 15 Oct 2020 11:59:03 +1100 Stephen Rothwell wrote: > Hi Alex, > > On Tue, 13 Oct 2020 13:20:16 -0600 Alex Williamson > wrote: > > > > Thanks, Stephen. Diana has posted a 32bit build fix which I've merged, > > maybe that was the error. Also Diana's series in my branch is currently >

RE: [PATCH 09/13] remoteproc: Add return value to function rproc_shutdown()

2020-10-14 Thread Peng Fan
> Subject: [PATCH 09/13] remoteproc: Add return value to function > rproc_shutdown() > > Add a return value to function rproc_shutdown() in order to properly deal with > error conditions that may occur. > > Signed-off-by: Mathieu Poirier > --- > drivers/remoteproc/remoteproc_core.c | 13

Re: [PATCH] lib: kunit: add test_min_heap test conversion to KUnit

2020-10-14 Thread Vitor Massaru Iha
Hi Ian, On Wed, Jul 29, 2020 at 7:57 PM Ian Rogers wrote: > > On Wed, Jul 29, 2020 at 1:11 PM Vitor Massaru Iha wrote: > > > > This adds the conversion of the runtime tests of test_min_heap, > > from `lib/test_min_heap.c` to KUnit tests. > > > > Please apply this commit first

Re: [PATCH v6 07/25] treewide: remove DISABLE_LTO

2020-10-14 Thread Kees Cook
On Mon, Oct 12, 2020 at 05:31:45PM -0700, Sami Tolvanen wrote: > This change removes all instances of DISABLE_LTO from > Makefiles, as they are currently unused, and the preferred > method of disabling LTO is to filter out the flags instead. > > Suggested-by: Kees Cook > Signed-off-by: Sami

Re: [PATCH v2 3/3] soc: qcom: geni: Optimize/comment select fifo/dma mode

2020-10-14 Thread Stephen Boyd
Quoting Douglas Anderson (2020-10-13 14:25:30) > The functions geni_se_select_fifo_mode() and > geni_se_select_fifo_mode() are a little funny. They read/write a > bunch of memory mapped registers even if they don't change or aren't > relevant for the current protocol. Let's make them a little

Re: [tip: locking/core] lockdep: Fix lockdep recursion

2020-10-14 Thread Peter Zijlstra
On Wed, Oct 14, 2020 at 03:11:52PM -0700, Paul E. McKenney wrote: > On Wed, Oct 14, 2020 at 11:53:19PM +0200, Peter Zijlstra wrote: > > On Wed, Oct 14, 2020 at 11:34:05AM -0700, Paul E. McKenney wrote: > > > commit 7deaa04b02298001426730ed0e6214ac20d1a1c1 > > > Author: Paul E. McKenney > > >

RE: [PATCH 08/13] remoteproc: Rename function rproc_actuate()

2020-10-14 Thread Peng Fan
> Subject: [PATCH 08/13] remoteproc: Rename function rproc_actuate() > > Align what was done for rproc_detach() by renaming function rproc_actuate(). > That way it is easier to figure out the opposite of each functions. > > Signed-off-by: Mathieu Poirier > --- >

[PATCH v2] lib: kunit: add test_min_heap test conversion to KUnit

2020-10-14 Thread Vitor Massaru Iha
This adds the conversion of the runtime tests of test_min_heap, from `lib/test_min_heap.c` to KUnit tests. Signed-off-by: Vitor Massaru Iha --- v2: * min_heap test now runs when enabling full test coverage (KUNIT_ALL_TESTS). --- lib/Kconfig.debug | 29 --

Re: [PATCH v3 7/9] KVM: VMX: Add guest physical address check in EPT violation and misconfig

2020-10-14 Thread Jim Mattson
On Fri, Oct 9, 2020 at 9:17 AM Jim Mattson wrote: > > On Fri, Jul 10, 2020 at 8:48 AM Mohammed Gamal wrote: > > > > Check guest physical address against it's maximum physical memory. If > > the guest's physical address exceeds the maximum (i.e. has reserved bits > > set), inject a guest page

Re: [PATCH v2] MIPS: DEC: Restore bootmem reservation for firmware working memory area

2020-10-14 Thread Serge Semin
Maciej, Regardless of a comment below feel free to add: Reviewed-by: Serge Semin On Wed, Oct 14, 2020 at 10:34:56PM +0100, Maciej W. Rozycki wrote: > Fix a crash on DEC platforms starting with: > > VFS: Mounted root (nfs filesystem) on device 0:11. > Freeing unused PROM memory: 124k freed >

Re: [PATCH v7 2/2] soc: mediatek: add mt6779 devapc driver

2020-10-14 Thread Neal Liu
On Thu, 2020-10-08 at 10:35 +0800, Neal Liu wrote: > On Wed, 2020-10-07 at 12:44 +0200, Matthias Brugger wrote: > > > > On 27/08/2020 05:06, Neal Liu wrote: [...] > > > +static int devapc_sync_vio_dbg(struct mtk_devapc_context *ctx) > > > +{ > > > + void __iomem *pd_vio_shift_sta_reg; > > > +

[PATCH 2/2] HID: i2c-hid: Add the ability to control a reset GPIO

2020-10-14 Thread Douglas Anderson
Apparently some devices connected via i2c-hid have timing requirements around when a reset GPIO should be asserted to them. The diagram I have seen, which I believe is from a Goodix device, looked like this: +-- | AVDD +

[PATCH 1/2] dt-bindings: HID: i2c-hid: Add the ability to control a reset GPIO

2020-10-14 Thread Douglas Anderson
Apparently some devices connected via i2c-hid have timing requirements around when a reset GPIO should be asserted to them. The diagram I have seen, which I believe is from a Goodix device, looked like this: +-- | AVDD +

Re: [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-14 Thread Joel Stanley
On Wed, 14 Oct 2020 at 13:32, Dylan Hung wrote: > > > The new HW arbitration feature on Aspeed ast2600 will cause MAC TX to > > > hang when handling scatter-gather DMA. Disable the problematic > > > feature by setting MAC register 0x58 bit28 and bit27. > > > > Hi Dylan, > > > > What are the

Re: [PATCH 1/2] mm/mprotect: Call arch_validate_prot under mmap_lock and with length

2020-10-14 Thread Jann Horn
On Wed, Oct 14, 2020 at 11:24 PM Khalid Aziz wrote: [...] > current code? What FreeBSD does seems like a reasonable thing to do. Any > way first thing to do is to update sparc to use arch_validate_flags() > and update sparc_validate_prot() to not peek into vma without lock. I > can do that unless

Re: Use after free in bcm2835_spi_remove()

2020-10-14 Thread Florian Fainelli
On 10/14/20 1:25 PM, Mark Brown wrote: > On Wed, Oct 14, 2020 at 10:40:35PM +0300, Vladimir Oltean wrote: >> On Wed, Oct 14, 2020 at 04:09:12PM +0200, Lukas Wunner wrote: > >>> Apparently the problem is that spi_unregister_controller() drops the >>> last ref on the controller, causing it to be

[RESEND PATCH v2] lib: kunit: add test_min_heap test conversion to KUnit

2020-10-14 Thread Vitor Massaru Iha
This adds the conversion of the runtime tests of test_min_heap, from `lib/test_min_heap.c` to KUnit tests. Signed-off-by: Vitor Massaru Iha --- v2: * change Kconfig entries to be more adherent to KUnit documentation, min_heap test runs when enabling full test coverage

Re: [PATCH v3 2/3] clk: qcom: lpass-sc7180: Disentangle the two clock devices

2020-10-14 Thread Doug Anderson
Hi, On Wed, Oct 14, 2020 at 3:10 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-10-14 14:05:22) > > diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c > > b/drivers/clk/qcom/lpasscorecc-sc7180.c > > index abcf36006926..48d370e2108e 100644 > > ---

Re: [PATCH 00/35] Enhance memory utilization with DMEMFS

2020-10-14 Thread Dan Williams
On Mon, Oct 12, 2020 at 4:00 AM Joao Martins wrote: [..] > On 10/10/20 9:15 AM, yulei zhang wrote: > > On Fri, Oct 9, 2020 at 7:53 PM Joao Martins > > wrote: > >> On 10/9/20 12:39 PM, yulei zhang wrote: > >>> Joao, thanks a lot for the feedback. One more thing needs to mention > >>> is that

Re: [PATCH 0/5] gpio: uapi: documentation improvements

2020-10-14 Thread Kent Gibson
On Wed, Oct 14, 2020 at 08:14:20PM +0300, Andy Shevchenko wrote: > On Tue, Oct 13, 2020 at 7:34 PM Kent Gibson wrote: > > On Tue, Oct 13, 2020 at 03:21:47PM +0200, Linus Walleij wrote: > > > On Thu, Oct 8, 2020 at 5:46 PM Bartosz Golaszewski > > > wrote: > > ... > > > > I am waiting for Kent

[PATCH v3 2/3] clk: qcom: lpass-sc7180: Disentangle the two clock devices

2020-10-14 Thread Douglas Anderson
The sc7180 lpass clock driver manages two different devices. These two devices were tangled together, using one probe and a lookup to figure out the real probe. I think it's cleaner to really separate the probe for these two devices since they're really different things, just both managed by the

Re: [PATCH v2] clk: qcom: lpasscc: Re-configure the PLL in case lost

2020-10-14 Thread Doug Anderson
Hi, On Wed, Oct 14, 2020 at 10:06 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-10-14 08:58:24) > > diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c > > b/drivers/clk/qcom/lpasscorecc-sc7180.c > > index 228d08f5d26f..ee23eb5b9bf2 100644 > > ---

Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path()

2020-10-14 Thread Josef Bacik
On 10/14/20 4:45 PM, Andrii Nakryiko wrote: Fix data race in prepend_path() with re-reading mnt->mnt_ns twice without holding the lock. is_mounted() does check for NULL, but is_anon_ns(mnt->mnt_ns) might re-read the pointer again which could be NULL already, if in between reads one of

[PATCH v3 3/3] clk: qcom: lpasscc-sc7180: Re-configure the PLL in case lost

2020-10-14 Thread Douglas Anderson
From: Taniya Das In the case where the PLL configuration is lost, then the pm runtime resume will reconfigure before usage. Fixes: edab812d802d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180") Signed-off-by: Taniya Das Signed-off-by: Douglas Anderson --- Changes in

[PATCH v3 1/3] clk: qcom: lpasscc-sc7810: Use devm in probe

2020-10-14 Thread Douglas Anderson
Let's convert the lpass clock control driver to use devm. This is a few more lines of code, but it will be useful in a later patch which disentangles the two devices handled by this driver. Signed-off-by: Douglas Anderson --- Changes in v3: - ("clk: qcom: lpasscc-sc7810: Use devm in probe")

Re: [PATCH v6 2/2] PCI/ERR: Split the fatal and non-fatal error recovery handling

2020-10-14 Thread Ethan Zhao
On Thu, Oct 15, 2020 at 1:06 AM Kuppuswamy, Sathyanarayanan wrote: > > > > On 10/14/20 8:07 AM, Ethan Zhao wrote: > > On Wed, Oct 14, 2020 at 5:00 PM Kuppuswamy Sathyanarayanan > > wrote: > >> > >> Commit bdb5ac85777d ("PCI/ERR: Handle fatal error recovery") > >> merged fatal and non-fatal error

Re: [PATCH v3 00/11] Introduce Simple atomic counters

2020-10-14 Thread Kees Cook
On Wed, Oct 14, 2020 at 11:17:20AM +0200, Peter Zijlstra wrote: > On Tue, Oct 13, 2020 at 08:12:20PM -0600, Shuah Khan wrote: > > > They don't add any new behavior, As Kees mentioned they do give us a > > way to clearly differentiate atomic usages that can wrap. > > No it doesn't! atomic_t can

Re: [PATCH v2] clk: qcom: lpasscc: Re-configure the PLL in case lost

2020-10-14 Thread Doug Anderson
Hi, On Wed, Oct 14, 2020 at 10:21 AM Taniya Das wrote: > > Thanks Doug for the patch. > > On 10/14/2020 9:28 PM, Douglas Anderson wrote: > > From: Taniya Das > > > > In the case where the PLL configuration is lost, then the pm runtime > > resume will reconfigure before usage. > > > > Fixes:

Re: linux-next: manual merge of the tip tree with the kbuild tree

2020-10-14 Thread Stephen Rothwell
Hi all, On Fri, 25 Sep 2020 15:25:45 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the tip tree got a conflict in: > > arch/arm/Makefile > > between commit: > > 596b0474d3d9 ("kbuild: preprocess module linker script") > > from the kbuild tree and commit: > >

Re: [PATCH 8/8] iommu/arm-smmu-qcom: Add stream_mapping_reset detail to QCOM SMMUv2

2020-10-14 Thread Bjorn Andersson
On Sat 26 Sep 08:00 CDT 2020, khol...@gmail.com wrote: > From: AngeloGioacchino Del Regno > > On some Qualcomm SoCs with certain hypervisor configurations, > some context banks are hyp-protected and cannot be disabled, > nor the relative S2CRs can be set as bypass, or a hyp-fault > will be

Re: [PATCH v2] thunderbolt: Add the missed ida_simple_remove() in ring_request_msix()

2020-10-14 Thread Jing Xiangfeng
On 2020/10/14 16:48, Andy Shevchenko wrote: On Wed, Oct 14, 2020 at 09:46:04AM +0800, Jing Xiangfeng wrote: ring_request_msix() misses to call ida_simple_remove() in an error path. Add a label 'err_ida_remove' and jump to it. ... @@ -406,11 +406,22 @@ static int ring_request_msix(struct

Re: [PATCH 5/8] x86/clear_page: add clear_page_uncached()

2020-10-14 Thread Andy Lutomirski
> On Oct 14, 2020, at 12:58 PM, Borislav Petkov wrote: > > On Wed, Oct 14, 2020 at 08:45:37AM -0700, Andy Lutomirski wrote: >>> On Wed, Oct 14, 2020 at 1:33 AM Ankur Arora >>> wrote: >>> >>> Define clear_page_uncached() as an alternative_call() to clear_page_nt() >>> if the CPU sets

[PATCH v3] nvmet: fix uninitialized work for zero kato

2020-10-14 Thread zhenwei pi
Hit a warning: WARNING: CPU: 1 PID: 241 at kernel/workqueue.c:1627 __queue_delayed_work+0x6d/0x90 with trace: mod_delayed_work_on+0x59/0x90 nvmet_update_cc+0xee/0x100 [nvmet] nvmet_execute_prop_set+0x72/0x80 [nvmet] nvmet_tcp_try_recv_pdu+0x2f7/0x770 [nvmet_tcp]

RE: [PATCH 07/13] remoteproc: Introduce function rproc_detach()

2020-10-14 Thread Peng Fan
> Subject: [PATCH 07/13] remoteproc: Introduce function rproc_detach() > > Introduce function rproc_detach() to enable the remoteproc core to release > the resources associated with a remote processor without stopping its > operation. > > Signed-off-by: Mathieu Poirier > --- >

RE: [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue

2020-10-14 Thread Dylan Hung
> -Original Message- > From: Joel Stanley [mailto:j...@jms.id.au] > Sent: Thursday, October 15, 2020 6:31 AM > To: Dylan Hung > Cc: David S . Miller ; Jakub Kicinski > ; net...@vger.kernel.org; Linux Kernel Mailing List > ; Po-Yu Chuang ; > linux-aspeed ; OpenBMC Maillist > ; BMC-SW >

Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps

2020-10-14 Thread Jann Horn
+objtool folks On Tue, Oct 13, 2020 at 2:35 AM Sami Tolvanen wrote: > Running objtool --vmlinux --duplicate on vmlinux.o produces a few > warnings about indirect jumps with retpoline: > > vmlinux.o: warning: objtool: wakeup_long64()+0x61: indirect jump > found in RETPOLINE build > ... > >

[PATCH v2] lib: kunit: add list_sort test conversion to KUnit

2020-10-14 Thread Vitor Massaru Iha
This adds the conversion of the runtime tests of test_list_sort, from `lib/test_list_sort.c` to KUnit tests. Signed-off-by: Vitor Massaru Iha --- v2: * fix KUNIT_TEST sufix; * make kconfig help more concise; * remove obsolete commit comments; * change Kconfig entries to be more adherent

Re: [PATCH v2 2/4] time: make getboottime64 aware of time namespace

2020-10-14 Thread J. Bruce Fields
On Mon, Oct 12, 2020 at 05:13:08PM -0400, J. Bruce Fields wrote: > On Fri, Oct 09, 2020 at 10:08:15PM +0200, Thomas Gleixner wrote: > > In fact the whole thing can be simplified. You can just use time in > > nanoseconds retrieved via ktime_get_coarse_boottime() which does not > > read the

Re: [GIT PULL] printk for 5.10 (includes lockless ringbuffer)

2020-10-14 Thread John Ogness
On 2020-10-14, Geert Uytterhoeven wrote: >> - Fully lockless ringbuffer implementation, including the support for >> continuous lines. It will allow to store and read messages in any >> situation wihtout the risk of deadlocks and without the need >> of temporary per-CPU buffers. > >

[Regression 5.9][Bisected 1df2bdba528b] Wifi GTK rekeying fails: Sending of EAPol packages broken

2020-10-14 Thread Thomas Deutschmann
Hi, after upgrading to linux-5.9.0 I noticed that my wifi got disassociated every 10 minutes when access point triggered rekeying for GTK. This happened with iwd but not with wpa_supplicant. iwd was logging wlan0: disassociated from aa:bb:cc:dd:ap:01 (Reason: 2=PREV_AUTH_NOT_VALID) wlan0:

Re: [PATCH] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-14 Thread Russell King - ARM Linux admin
On Wed, Oct 14, 2020 at 04:39:47PM +0200, Lukasz Stelmach wrote: > It was <2020-10-14 śro 14:32>, when Russell King - ARM Linux admin wrote: > > In any case, the mii.c code does fill in the advertising mask even > > when autoneg is disabled, because, rightly or wrongly, the advertising > > mask

[PATCH v2 2/3] tools: gpio: add support for reporting realtime event clock to lsgpio

2020-10-14 Thread Kent Gibson
Add support for reporting if a line is configured to report realtime timestamps in events. Signed-off-by: Kent Gibson --- tools/gpio/lsgpio.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/gpio/lsgpio.c b/tools/gpio/lsgpio.c index 5a05a454d0c9..c61d061247e1 100644 ---

Re: linux-next: build warning after merge of the tip tree

2020-10-14 Thread Kees Cook
On Thu, Oct 15, 2020 at 09:25:26AM +1100, Stephen Rothwell wrote: > Hi Kees, > > On Sun, 4 Oct 2020 19:44:52 -0700 Kees Cook wrote: > > > > On Sun, Oct 04, 2020 at 09:00:18PM +1100, Stephen Rothwell wrote: > > > Hi Kees, > > > > > > On Sun, 4 Oct 2020 01:27:01 -0700 Kees Cook > > > wrote: >

[PATCH v7 0/6] Add support for length of each segment in the segcblist

2020-10-14 Thread Joel Fernandes (Google)
This is required for several usecases identified. One of them being tracing how the segmented callback list changes. Tracing this has identified issues in RCU code in the past. >From Paul: Another use case is of course more accurately determining whether a given CPU's large pile of callbacks can

[PATCH v7 2/6] rcu/segcblist: Add counters to segcblist datastructure

2020-10-14 Thread Joel Fernandes (Google)
Add counting of segment lengths of segmented callback list. This will be useful for a number of things such as knowing how big the ready-to-execute segment have gotten. The immediate benefit is ability to trace how the callbacks in the segmented callback list change. Also this patch remove hacks

Re: [PATCH v2 20/20] ppc: propagate the calling conventions change down to csum_partial_copy_generic()

2020-10-14 Thread Al Viro
On Wed, Oct 14, 2020 at 03:51:00PM -0700, Linus Torvalds wrote: > On Wed, Oct 14, 2020 at 3:27 PM Jason A. Donenfeld wrote: > > > > This patch is causing crashes in WireGuard's CI over at > > https://www.wireguard.com/build-status/ . Apparently sending a simple > > network packet winds up

[PATCH v7 1/6] rcu/tree: Make rcu_do_batch count how many callbacks were executed

2020-10-14 Thread Joel Fernandes (Google)
Currently, rcu_do_batch() depends on the unsegmented callback list's len field to know how many CBs are executed. This fields counts down from 0 as CBs are dequeued. It is possible that all CBs could not be run because of reaching limits in which case the remaining unexecuted callbacks are

Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path()

2020-10-14 Thread Linus Torvalds
On Wed, Oct 14, 2020 at 4:09 PM Al Viro wrote: > > If you've already grabbed it, I'll just push a followup cleanup. Already grabbed (along with the ppc32 csum fix). Your suggested helper function cleanup sounds good. Linus

[PATCH v7 4/6] rcu/segcblist: Remove useless rcupdate.h include

2020-10-14 Thread Joel Fernandes (Google)
Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/rcu_segcblist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c index 2dccbd29cd3a..271d5d9d7f60 100644 --- a/kernel/rcu/rcu_segcblist.c +++ b/kernel/rcu/rcu_segcblist.c @@ -10,7

[PATCH v2 0/3] gpiolib: cdev: allow edge event timestamps to be configured as REALTIME

2020-10-14 Thread Kent Gibson
This patch set adds the option to select CLOCK_REALTIME as the source clock for line events. The first patch is the core of the change, while the remaining two update the GPIO tools to make use of the new option. Changes for v2: - change line_event_timestamp() return to u64 to avoid clipping to

[PATCH v7 6/6] rcu/segcblist: Add additional comments to explain smp_mb()

2020-10-14 Thread Joel Fernandes (Google)
Memory barriers are needed when updating the full length of the segcblist, however it is not fully clearly why one is needed before and after. This patch therefore adds additional comments to the function header to explain it. Signed-off-by: Joel Fernandes (Google) ---

[PATCH v7 3/6] rcu/trace: Add tracing for how segcb list changes

2020-10-14 Thread Joel Fernandes (Google)
Track how the segcb list changes before/after acceleration, during queuing and during dequeuing. This has proved useful to discover an optimization to avoid unwanted GP requests when there are no callbacks accelerated. The overhead is minimal as each segment's length is now stored in the

RE: [PATCH 06/13] remoteproc: Introduce function __rproc_detach()

2020-10-14 Thread Peng Fan
> Subject: [PATCH 06/13] remoteproc: Introduce function __rproc_detach() > > Introduce function __rproc_detach() to perform the same kind of operation as > rproc_stop(), but instead of switching off the remote processor using > rproc->ops->stop(), it uses > rproc->ops->detach(). That way it is

Re: linux-next: build warning after merge of the tip tree

2020-10-14 Thread Stephen Rothwell
Hi Kees, On Wed, 14 Oct 2020 16:10:05 -0700 Kees Cook wrote: > > I've pinged the thread of the patch (from Oct 4th) that fixes this. > Hopefully that or this email will float to the top for an x86 > maintainer. :) If it doesn't get picked up soon, I can try sending this > direct to Linus,

[PATCH v2 1/3] gpiolib: cdev: allow edge event timestamps to be configured as REALTIME

2020-10-14 Thread Kent Gibson
Using CLOCK_REALTIME as the source for event timestamps is crucial for some specific applications, particularly those requiring timetamps relative to a PTP clock, so provide an option to switch the event timestamp source from the default CLOCK_MONOTONIC to CLOCK_REALTIME. Note that CLOCK_REALTIME

[PATCH v2 3/3] tools: gpio: add option to report wall-clock time to gpio-event-mon

2020-10-14 Thread Kent Gibson
Add support for selecting the realtime clock for events. Signed-off-by: Kent Gibson --- tools/gpio/gpio-event-mon.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c index 90c3155f05b1..cacd66ad7926 100644 ---

[PATCH v7 5/6] rcu/tree: Remove redundant smp_mb() in rcu_do_batch

2020-10-14 Thread Joel Fernandes (Google)
This memory barrier is not needed as rcu_segcblist_add_len() already includes a memory barrier. Signed-off-by: Joel Fernandes (Google) --- kernel/rcu/tree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 346a05506935..6c6d3c7036e6 100644 ---

Re: [PATCH v5 1/5] counter: Internalize sysfs interface code

2020-10-14 Thread David Lechner
On 9/26/20 9:18 PM, William Breathitt Gray wrote: +static ssize_t counter_comp_u8_store(struct device *dev, +struct device_attribute *attr, +const char *buf, size_t len) +{ + const struct counter_attribute *const a =

[PATCH] fs: clean up is_mounted() check with extra helper

2020-10-14 Thread Andrii Nakryiko
Add is_real_ns() helper validating that mount namespace is a valid one. Use that from is_mounted() and clean up prepare_path() that open-coded similar check. Suggested-by: Alexander Viro Signed-off-by: Andrii Nakryiko --- fs/d_path.c | 3 +-- fs/mount.h | 9 +++-- 2 files changed, 8

RE: [PATCH 05/13] remoteproc: Add new detach() remoteproc operation

2020-10-14 Thread Peng Fan
> Subject: [PATCH 05/13] remoteproc: Add new detach() remoteproc operation > > Add an new detach() operation in order to support scenarios where the > remoteproc core is going away but the remote processor is kept operating. > This could be the case when the system is rebooted or when the

Re: [PATCH v6 2/4] rcu/segcblist: Add counters to segcblist datastructure

2020-10-14 Thread joel
On Tue, Oct 13, 2020 at 01:20:08AM +0200, Frederic Weisbecker wrote: > On Wed, Sep 23, 2020 at 11:22:09AM -0400, Joel Fernandes (Google) wrote: > > +/* Return number of callbacks in a segment of the segmented callback list. > > */ > > +static void rcu_segcblist_add_seglen(struct rcu_segcblist

Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path()

2020-10-14 Thread Al Viro
On Wed, Oct 14, 2020 at 01:45:28PM -0700, Andrii Nakryiko wrote: > Fix data race in prepend_path() with re-reading mnt->mnt_ns twice without > holding the lock. is_mounted() does check for NULL, but > is_anon_ns(mnt->mnt_ns) > might re-read the pointer again which could be NULL already, if in

Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path()

2020-10-14 Thread Al Viro
On Wed, Oct 14, 2020 at 02:49:18PM -0700, Linus Torvalds wrote: > On Wed, Oct 14, 2020 at 2:40 PM Andrii Nakryiko wrote: > > > > Fix data race in prepend_path() with re-reading mnt->mnt_ns twice without > > holding the lock. is_mounted() does check for NULL, but > > is_anon_ns(mnt->mnt_ns) > >

Re: [PATCH] firmware: imx: always export scu symbols

2020-10-14 Thread Liu Ying
Hi Joakim, On Wed, 2020-10-14 at 16:57 +0800, Joakim Zhang wrote: > From: Liu Ying > > Always export scu symbols for both SCU SoCs and non-SCU SoCs to avoid > build error. s/scu/SCU/ > > Signed-off-by: Liu Ying > Signed-off-by: Peng Fan > Signed-off-by: Joakim Zhang > --- >

[Linux-kernel-mentees] [PATCH] net: rose: Fix Null pointer dereference in rose_send_frame()

2020-10-14 Thread Anmol Karn
In rose_send_frame(), when comparing two ax.25 addresses, it assigns rose_call to either global ROSE callsign or default port, but when the former block triggers and rose_call is assigned by (ax25_address *)neigh->dev->dev_addr, a NULL pointer is dereferenced by 'neigh' when dereferencing

Re: [PATCH v2] vmlinux.lds.h: Keep .ctors.* with .ctors

2020-10-14 Thread Kees Cook
On Sun, Oct 04, 2020 at 07:57:20PM -0700, Kees Cook wrote: > Under some circumstances, the compiler generates .ctors.* sections. This > is seen doing a cross compile of x86_64 from a powerpc64el host: > > x86_64-linux-gnu-ld: warning: orphan section `.ctors.65435' from >

Re: [PATCH v3 2/3] clk: qcom: lpass-sc7180: Disentangle the two clock devices

2020-10-14 Thread Doug Anderson
Hi, On Wed, Oct 14, 2020 at 4:00 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-10-14 15:28:58) > > Hi, > > > > On Wed, Oct 14, 2020 at 3:10 PM Stephen Boyd wrote: > > > > > > Quoting Douglas Anderson (2020-10-14 14:05:22) > > > > diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c > >

Re: [PATCH v2] MIPS: DEC: Restore bootmem reservation for firmware working memory area

2020-10-14 Thread Serge Semin
On Thu, Oct 15, 2020 at 01:03:10AM +0100, Maciej W. Rozycki wrote: > On Thu, 15 Oct 2020, Serge Semin wrote: > > > > Table 2-2 REX Memory Regions > > > - > > > StartingEnding > > > Region Address

Re: [PATCH] powerpc32: don't adjust unmoved stack pointer in csum_partial_copy_generic() epilogue

2020-10-14 Thread Linus Torvalds
Thanks - applied and pushed out. Linus

RE: [PATCH 04/13] remoteproc: Properly represent the attached state

2020-10-14 Thread Peng Fan
> Subject: [PATCH 04/13] remoteproc: Properly represent the attached state > > There is a need to know when a remote processor has been attached to > rather than booted by the remoteproc core. In order to avoid manipulating > two variables, i.e rproc::autonomous and rproc::state, get rid of the

RE: [PATCH 03/13] remoteproc: Add new RPROC_ATTACHED state

2020-10-14 Thread Peng Fan
> Subject: [PATCH 03/13] remoteproc: Add new RPROC_ATTACHED state > > Add a new RPROC_ATTACHED state to take into account scenarios where the > remoteproc core needs to attach to a remote processor that is booted by > another entity. > > Signed-off-by: Mathieu Poirier > --- >

[PATCH v4 1/3] clk: qcom: lpasscc-sc7810: Use devm in probe

2020-10-14 Thread Douglas Anderson
Let's convert the lpass clock control driver to use devm. This is a few more lines of code, but it will be useful in a later patch which disentangles the two devices handled by this driver. Signed-off-by: Douglas Anderson --- Changes in v4: - Fixed typo lapss => lpass - Moved

[PATCH v4 2/3] clk: qcom: lpass-sc7180: Disentangle the two clock devices

2020-10-14 Thread Douglas Anderson
The sc7180 lpass clock driver manages two different devices. These two devices were tangled together, using one probe and a lookup to figure out the real probe. I think it's cleaner to really separate the probe for these two devices since they're really different things, just both managed by the

RE: [PATCH 02/13] remoteproc: Remove useless check in rproc_del()

2020-10-14 Thread Peng Fan
> Subject: [PATCH 02/13] remoteproc: Remove useless check in rproc_del() > > Whether started at probe() time or thereafter from the command line, a > remote processor needs to be shutdown before the final cleanup phases can > happen. Otherwise the system may be left in an unpredictable state

[PATCH v4 3/3] clk: qcom: lpasscc-sc7180: Re-configure the PLL in case lost

2020-10-14 Thread Douglas Anderson
From: Taniya Das In the case where the PLL configuration is lost, then the pm runtime resume will reconfigure before usage. Fixes: edab812d802d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180") Signed-off-by: Taniya Das Signed-off-by: Douglas Anderson --- Changes in

Re: [PATCH v3 2/3] clk: qcom: lpass-sc7180: Disentangle the two clock devices

2020-10-14 Thread Doug Anderson
Hi, On Wed, Oct 14, 2020 at 4:33 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-10-14 16:07:52) > > Hi, > > > > On Wed, Oct 14, 2020 at 4:00 PM Stephen Boyd wrote: > > > > > > Quoting Doug Anderson (2020-10-14 15:28:58) > > > > Hi, > > > > > > > > On Wed, Oct 14, 2020 at 3:10 PM Stephen

Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path()

2020-10-14 Thread Linus Torvalds
On Wed, Oct 14, 2020 at 2:40 PM Andrii Nakryiko wrote: > > Fix data race in prepend_path() with re-reading mnt->mnt_ns twice without > holding the lock. is_mounted() does check for NULL, but > is_anon_ns(mnt->mnt_ns) > might re-read the pointer again which could be NULL already, if in between >

Re: [PATCH v3 3/3] clk: qcom: lpasscc-sc7180: Re-configure the PLL in case lost

2020-10-14 Thread Doug Anderson
Hi, On Wed, Oct 14, 2020 at 4:39 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-10-14 14:05:23) > > diff --git a/drivers/clk/qcom/lpasscorecc-sc7180.c > > b/drivers/clk/qcom/lpasscorecc-sc7180.c > > index 48d370e2108e..e12d4c2b1b70 100644 > > ---

Re: [PATCH v2 14/17] resource: Move devmem revoke code to resource framework

2020-10-14 Thread Jason Gunthorpe
On Fri, Oct 09, 2020 at 11:28:54AM -0700, Dan Williams wrote: > On Fri, Oct 9, 2020 at 7:32 AM Jason Gunthorpe wrote: > > > > On Fri, Oct 09, 2020 at 04:24:45PM +0200, Daniel Vetter wrote: > > > On Fri, Oct 9, 2020 at 2:31 PM Jason Gunthorpe wrote: > > > > > > > > On Fri, Oct 09, 2020 at

Re: [PATCH v6 16/25] init: lto: fix PREL32 relocations

2020-10-14 Thread Jann Horn
On Tue, Oct 13, 2020 at 2:34 AM Sami Tolvanen wrote: > With LTO, the compiler can rename static functions to avoid global > naming collisions. As initcall functions are typically static, > renaming can break references to them in inline assembly. This > change adds a global stub with a stable

Re: [PATCH -next] Revert "powerpc/pci: unmap legacy INTx interrupts when a PHB is removed"

2020-10-14 Thread Oliver O'Halloran
On Thu, Oct 15, 2020 at 5:28 AM Qian Cai wrote: > > This reverts commit 3a3181e16fbde752007759f8759d25e0ff1fc425 which > causes memory corruptions on POWER9 NV. I was going to post this along with a fix for Cedric's original bug, but I can do that separately so: Acked-by: Oliver O'Halloran

Re: [tip: locking/core] lockdep: Fix lockdep recursion

2020-10-14 Thread Peter Zijlstra
On Wed, Oct 14, 2020 at 11:34:05AM -0700, Paul E. McKenney wrote: > commit 7deaa04b02298001426730ed0e6214ac20d1a1c1 > Author: Paul E. McKenney > Date: Tue Oct 13 12:39:23 2020 -0700 > > rcu: Prevent lockdep-RCU splats on lock acquisition/release > > The rcu_cpu_starting() and

RE: [PATCH 01/13] remoteproc: Re-check state in rproc_shutdown()

2020-10-14 Thread Peng Fan
> Subject: [PATCH 01/13] remoteproc: Re-check state in rproc_shutdown() > > The state of the remote processor may have changed between the time a call > to rproc_shutdown() was made and the time it is executed. To avoid moving > forward with an operation that may have been cancelled, recheck

Re: [PATCH] sched/cputime: correct account of irqtime

2020-10-14 Thread Pingfan Liu
On Wed, Oct 14, 2020 at 9:02 PM Peter Zijlstra wrote: > > On Mon, Oct 12, 2020 at 09:50:44PM +0800, Pingfan Liu wrote: > > __do_softirq() may be interrupted by hardware interrupts. In this case, > > irqtime_account_irq() will account the time slice as CPUTIME_SOFTIRQ by > > mistake. > > > > By

Re: [PATCH v2 24/24] counters: docs: add a missing include

2020-10-14 Thread Shuah Khan
On 10/13/20 6:14 AM, Mauro Carvalho Chehab wrote: Changeset 37a0dbf631f6 ("counters: Introduce counter_atomic* counters") Is causing two new warnings: .../Documentation/core-api/counters.rst:8: WARNING: Undefined substitution referenced: "copy".

Re: [GIT PULL v2] objtool changes for v5.10

2020-10-14 Thread Stephen Rothwell
Hi Ingo, On Tue, 13 Oct 2020 12:38:31 +0200 Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > This seems to be missing > > > > > > https://lore.kernel.org/lkml/patch-1.thread-251403.git-2514037e9477.your-ad-here.call-01602244460-ext-7088@work.hours/ > > > > > > or did that get sent in a

Re: [PATCH v5 1/5] arm64: Add framework to turn IPI as NMI

2020-10-14 Thread Masayoshi Mizuma
On Wed, Oct 14, 2020 at 04:42:07PM +0530, Sumit Garg wrote: > Introduce framework to turn an IPI as NMI using pseudo NMIs. In case a > particular platform doesn't support pseudo NMIs, then request IPI as a > regular IRQ. > > The main motivation for this feature is to have an IPI that can be >

Re: [PATCH v6 17/25] PCI: Fix PREL32 relocations for LTO

2020-10-14 Thread Kees Cook
On Mon, Oct 12, 2020 at 05:31:55PM -0700, Sami Tolvanen wrote: > With Clang's Link Time Optimization (LTO), the compiler can rename > static functions to avoid global naming collisions. As PCI fixup > functions are typically static, renaming can break references > to them in inline assembly. This

Re: [RFC PATCH 1/4] Add a RPMSG driver for the APU in the mt8183

2020-10-14 Thread Mathieu Poirier
Hi Alexandre, On Wed, Sep 30, 2020 at 01:53:47PM +0200, Alexandre Bailon wrote: > This adds a driver to communicate with the APU available > in the mt8183. The driver is generic and could be used for other APU. > It mostly provides a userspace interface to send messages and > and share big

Re: [PATCH v5 2/5] irqchip/gic-v3: Enable support for SGIs to act as NMIs

2020-10-14 Thread Masayoshi Mizuma
On Wed, Oct 14, 2020 at 04:42:08PM +0530, Sumit Garg wrote: > Add support to handle SGIs as regular NMIs. As SGIs or IPIs defaults to a > special flow handler: handle_percpu_devid_fasteoi_ipi(), so skip NMI > handler update in case of SGIs. > > Also, enable NMI support prior to gic_smp_init() as

Re: [PATCH v6 3/4] rcu/trace: Add tracing for how segcb list changes

2020-10-14 Thread joel
On Wed, Oct 14, 2020 at 08:52:17PM +0530, Neeraj Upadhyay wrote: > > > On 9/23/2020 8:52 PM, Joel Fernandes (Google) wrote: > > Track how the segcb list changes before/after acceleration, during > > queuing and during dequeuing. > > > > This has proved useful to discover an optimization to

Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path()

2020-10-14 Thread Andrii Nakryiko
On Wed, Oct 14, 2020 at 4:08 PM Al Viro wrote: > > On Wed, Oct 14, 2020 at 01:45:28PM -0700, Andrii Nakryiko wrote: > > Fix data race in prepend_path() with re-reading mnt->mnt_ns twice without > > holding the lock. is_mounted() does check for NULL, but > > is_anon_ns(mnt->mnt_ns) > > might

Re: [PATCH v2 1/7] staging: qlge: replace ql_* with qlge_* to avoid namespace clashes with other qlogic drivers

2020-10-14 Thread Benjamin Poirier
On 2020-10-14 18:43 +0800, Coiby Xu wrote: > To avoid namespace clashes with other qlogic drivers and also for the > sake of naming consistency, use the "qlge_" prefix as suggested in > drivers/staging/qlge/TODO. > > Suggested-by: Benjamin Poirier > Signed-off-by: Coiby Xu > --- >

Re: [PATCH v6 14/25] kbuild: lto: remove duplicate dependencies from .mod files

2020-10-14 Thread Kees Cook
On Mon, Oct 12, 2020 at 05:31:52PM -0700, Sami Tolvanen wrote: > With LTO, llvm-nm prints out symbols for each archive member > separately, which results in a lot of duplicate dependencies in the > .mod file when CONFIG_TRIM_UNUSED_SYMS is enabled. When a module > consists of several compilation

Re: [PATCH] drm/amdgpu: add missing newline at eof

2020-10-14 Thread Alex Deucher
On Wed, Oct 14, 2020 at 5:18 PM wrote: > > From: Tom Rix > > Representative checkpatch.pl warning > > WARNING: adding a line without newline at end of file > 30: FILE: drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.h:30: > +#endif > > Signed-off-by: Tom Rix Applied. Thanks! Alex > --- >

Re: [PATCH v3 01/11] counters: Introduce counter_atomic* counters

2020-10-14 Thread Shuah Khan
On 10/13/20 5:27 AM, Mauro Carvalho Chehab wrote: Em Fri, 9 Oct 2020 09:55:56 -0600 Shuah Khan escreveu: Introduce Simple atomic counters. There are a number of atomic_t usages in the kernel where atomic_t api is used strictly for counting and not for managing object lifetime. In some

[PATCH v3 1/2] mmap locking API: Order lock of nascent mm outside lock of live mm

2020-10-14 Thread Jann Horn
Until now, the mmap lock of the nascent mm was ordered inside the mmap lock of the old mm (in dup_mmap() and in UML's activate_mm()). A following patch will change the exec path to very broadly lock the nascent mm, but fine-grained locking should still work at the same time for the old mm. In

Re: [PATCH] compiler.h: Fix barrier_data() on clang

2020-10-14 Thread Nick Desaulniers
On Wed, Oct 14, 2020 at 2:26 PM Arvind Sankar wrote: > > Commit > 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually > exclusive") > > neglected to copy barrier_data() from compiler-gcc.h into > compiler-clang.h. The definition in compiler-gcc.h was really to work > around

<    1   2   3   4   5   6   7   8   9   10   >