Re: [PATCH -next] ulp/ipoib/ipoib_multicast: convert comma to semicolon

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:42:18PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Can you please do it in

Re: [PATCH] power: supply: PCHG: Peripheral device charger

2020-12-14 Thread Lee Jones
On Mon, 14 Dec 2020, Daisuke Nojiri wrote: > This patch adds a driver for PCHG (Peripheral CHarGer). PCHG is a > framework managing power supplies for peripheral devices. > > This driver creates a sysfs node for each peripheral charge port: > > /sys/class/power_supply/PCHGn > > where is

Re: [PATCH -next] infiniband: core: Delete useless kfree code

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:46:55PM +0800, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun > --- > drivers/infiniband/core/cma_configfs.c | 1 - > 1 file changed, 1 deletion(-) The best thing will be to delete

Re: [PATCH] drm/hisilicon: Fix rmmod hibmc_drm failed

2020-12-14 Thread Thomas Zimmermann
Hi Tian Am 15.12.20 um 04:01 schrieb Tian Tao: drm_irq_uninstall should be called before pci_disable_msi, if use devm_drm_irq_install to register the interrupt, the system will call pci_disable_msi first and then call drm_irq_uninstall, which will result in the following callstack. kernel

Re: [PATCH v4 2/3] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2020-12-14 Thread Lee Jones
On Mon, 14 Dec 2020, Daniel Thompson wrote: > On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > Hi, > > > > Daniel Thompson 於 2020年12月14日 週一 下午5:59寫道: > > > > > > Hi CY > > > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > From: ChiYuan Huang > > > > >

Re: [PATCH 00/10] workqueue: break affinity initiatively

2020-12-14 Thread Peter Zijlstra
On Tue, Dec 15, 2020 at 01:44:53PM +0800, Lai Jiangshan wrote: > I don't know how the scheduler distinguishes all these > different cases under the "new assumption". The special case is: (p->flags & PF_KTHREAD) && p->nr_cpus_allowed == 1

答复: [PATCH] irqchip/gic-v3: Check SRE bit for GICv2 legacy support

2020-12-14 Thread wanghuiqiang
Sorry response late. Hi Shameer & Ard, Could you let me know which firmware you are using? If the difference is Madt table vGIC your pointed , they are the same. We changed the vGIC memory base address at very early design stage. Thanks! -邮件原件- 发件人: Shameerali Kolothum Thodi 发送时间:

Re: linux-next: build warning after merge of the net-next tree

2020-12-14 Thread Ioana Ciornei
On Tue, Dec 15, 2020 at 07:01:25AM +1100, Stephen Rothwell wrote: > Hi all, > > On Thu, 26 Nov 2020 17:40:57 +1100 Stephen Rothwell > wrote: > > > > After merging the net-next tree, today's linux-next build (htmldocs) > > produced this warning: > > > > include/linux/phy.h:869: warning:

Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer

2020-12-14 Thread Hannes Reinecke
On 12/15/20 7:51 AM, Bob Liu wrote: Hi Folks, On 12/12/20 12:56 AM, Hannes Reinecke wrote: On 12/11/20 5:33 PM, Jens Axboe wrote: On 12/11/20 9:30 AM, Mike Snitzer wrote: While I still think there needs to be a proper _upstream_ consumer of blk_interposer as a condition of it going in.. I'll

[PATCH v4 12/13] iommu/amd: Introduce iommu_v1_map_page and iommu_v1_unmap_page

2020-12-14 Thread Suravee Suthikulpanit
These implement map and unmap for AMD IOMMU v1 pagetable, which will be used by the IO pagetable framework. Also clean up unused extern function declarations. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 13 - drivers/iommu/amd/io_pgtable.c | 25

Re: [PATCH] proc: Escape more characters in /proc/mounts output

2020-12-14 Thread Siddhesh Poyarekar
On 12/15/20 11:40 AM, Al Viro wrote: On Tue, Dec 15, 2020 at 09:54:54AM +0530, Siddhesh Poyarekar wrote: + get_user(byte, (const char __user *)data); + + return byte ? strndup_user(data, PATH_MAX) : NULL; } No. Not to mention anything else, you * fetch the same data

[PATCH v4 11/13] iommu/amd: Introduce iommu_v1_iova_to_phys

2020-12-14 Thread Suravee Suthikulpanit
This implements iova_to_phys for AMD IOMMU v1 pagetable, which will be used by the IO page table framework. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/io_pgtable.c | 22 ++ drivers/iommu/amd/iommu.c | 16 +--- 2 files changed, 23

[PATCH v4 04/13] iommu/amd: Convert to using amd_io_pgtable

2020-12-14 Thread Suravee Suthikulpanit
Make use of the new struct amd_io_pgtable in preparation to remove the struct domain_pgtable. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 1 + drivers/iommu/amd/iommu.c | 25 ++--- 2 files changed, 11 insertions(+), 15 deletions(-) diff

[PATCH v4 02/13] iommu/amd: Prepare for generic IO page table framework

2020-12-14 Thread Suravee Suthikulpanit
Add initial hook up code to implement generic IO page table framework. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/Kconfig | 1 + drivers/iommu/amd/Makefile | 2 +- drivers/iommu/amd/amd_iommu_types.h | 35 ++ drivers/iommu/amd/io_pgtable.c |

[PATCH v4 10/13] iommu/amd: Refactor fetch_pte to use struct amd_io_pgtable

2020-12-14 Thread Suravee Suthikulpanit
To simplify the fetch_pte function. There is no functional change. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 2 +- drivers/iommu/amd/io_pgtable.c | 13 +++-- drivers/iommu/amd/iommu.c | 4 +++- 3 files changed, 11 insertions(+), 8 deletions(-)

[PATCH v4 08/13] iommu/amd: Remove amd_iommu_domain_get_pgtable

2020-12-14 Thread Suravee Suthikulpanit
Since the IO page table root and mode parameters have been moved into the struct amd_io_pg, the function is no longer needed. Therefore, remove it along with the struct domain_pgtable. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 4 ++--

[PATCH v4 06/13] iommu/amd: Move IO page table related functions

2020-12-14 Thread Suravee Suthikulpanit
Preparing to migrate to use IO page table framework. There is no functional change. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 18 ++ drivers/iommu/amd/io_pgtable.c | 473 drivers/iommu/amd/iommu.c | 476

[PATCH v4 13/13] iommu/amd: Adopt IO page table framework for AMD IOMMU v1 page table

2020-12-14 Thread Suravee Suthikulpanit
Switch to using IO page table framework for AMD IOMMU v1 page table. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 1 + drivers/iommu/amd/init.c | 2 ++ drivers/iommu/amd/iommu.c | 48 ++- 3 files changed, 39 insertions(+),

[PATCH v4 07/13] iommu/amd: Restructure code for freeing page table

2020-12-14 Thread Suravee Suthikulpanit
By consolidate logic into v1_free_pgtable helper function, which is called from IO page table framework. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 1 - drivers/iommu/amd/io_pgtable.c | 41 -- drivers/iommu/amd/iommu.c | 21

[PATCH v4 03/13] iommu/amd: Move pt_root to struct amd_io_pgtable

2020-12-14 Thread Suravee Suthikulpanit
To better organize the data structure since it contains IO page table related information. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 2 +- drivers/iommu/amd/amd_iommu_types.h | 2 +- drivers/iommu/amd/iommu.c | 2 +- 3 files changed, 3

[PATCH v4 05/13] iommu/amd: Declare functions as extern

2020-12-14 Thread Suravee Suthikulpanit
And move declaration to header file so that they can be included across multiple files. There is no functional change. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 3 +++ drivers/iommu/amd/iommu.c | 39 +-- 2 files changed, 22

[PATCH v4 09/13] iommu/amd: Rename variables to be consistent with struct io_pgtable_ops

2020-12-14 Thread Suravee Suthikulpanit
There is no functional change. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/io_pgtable.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c index

[PATCH v4 01/13] iommu/amd: Re-define amd_iommu_domain_encode_pgtable as inline

2020-12-14 Thread Suravee Suthikulpanit
Move the function to header file to allow inclusion in other files. Signed-off-by: Suravee Suthikulpanit --- drivers/iommu/amd/amd_iommu.h | 13 + drivers/iommu/amd/iommu.c | 10 -- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git

[PATCH v4 00/13] iommu/amd: Add Generic IO Page Table Framework Support

2020-12-14 Thread Suravee Suthikulpanit
The framework allows callable implementation of IO page table. This allows AMD IOMMU driver to switch between different types of AMD IOMMU page tables (e.g. v1 vs. v2). This series refactors the current implementation of AMD IOMMU v1 page table to adopt the framework. There should be no

Re: [PATCH -next v2] net/mlx5_core: remove unused including

2020-12-14 Thread Saeed Mahameed
On Wed, 2020-12-09 at 15:01 +0800, Zou Wei wrote: > Remove including that don't need it. > > Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name") > Signed-off-by: Zou Wei > --- Applied to net-next-mlx5. Thanks!

Re: xen/evtchn: Interrupt for port 34, but apparently not enabled; per-user 00000000a86a4c1b on 5.10

2020-12-14 Thread Jürgen Groß
On 14.12.20 22:25, Julien Grall wrote: Hi Juergen, When testing Linux 5.10 dom0, I could reliably hit the following warning with using event 2L ABI: [  589.591737] Interrupt for port 34, but apparently not enabled; per-user a86a4c1b [  589.593259] WARNING: CPU: 0 PID: at

Re: [PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

2020-12-14 Thread Saeed Mahameed
On Tue, 2020-12-08 at 16:25 -0800, David Miller wrote: > From: Zheng Yongjun > Date: Tue, 8 Dec 2020 21:56:25 +0800 > > > Simplify the return expression. > > > > Signed-off-by: Zheng Yongjun > > Applied. > Hey Dave, it's great to have you back! I still don't see this patch in net-next, i

[rcu:dev.2020.12.13a] BUILD SUCCESS 42cc5a26ab93636323fea8cfadb28dec6fcc38b8

2020-12-14 Thread kernel test robot
-20201214 i386 randconfig-a004-20201214 i386 randconfig-a003-20201214 i386 randconfig-a002-20201214 i386 randconfig-a006-20201214 i386 randconfig-a005-20201214 i386 randconfig-a001-20201213 i386

[PATCH v5] Serial: silabs si4455 serial driver

2020-12-14 Thread József Horváth
This is a serial port driver for Silicon Labs Si4455 Sub-GHz transciver. The goal of this driver is to removing wires between central(linux) device and remote serial devices/sensors, but keeping the original user software. It represents regular serial interface for the user space. Datasheet:

Re: [PATCH 2/2] mm: rename memmap_init() and memmap_init_zone()

2020-12-14 Thread Baoquan He
On 12/14/20 at 11:00am, David Hildenbrand wrote: > On 13.12.20 16:09, Baoquan He wrote: > > The current memmap_init_zone() only handles memory region inside one zone. > > Actually memmap_init() does the memmap init of one zone. So rename both of > > them accordingly. > > > > And also rename the

Re: [PATCH v4 1/2] dt-bindings: pci: Retrain Link to work around Gen2 training defect.

2020-12-14 Thread Kishon Vijay Abraham I
Hi, On 14/12/20 8:35 pm, Rob Herring wrote: > On Sun, Dec 13, 2020 at 10:21 PM Kishon Vijay Abraham I wrote: >> >> Hi Nadeem, >> >> On 12/12/20 12:37 pm, Athani Nadeem Ladkhan wrote: >>> Hi Rob / Kishon, >>> -Original Message- From: Rob Herring Sent: Friday, December 11,

[PATCH v2] x86/mtrr: Correct the returned MTRR type of mtrr_type_lookup.

2020-12-14 Thread Ying-Tsun Huang
In mtrr_type_lookup, if the input memory address region is not in the MTRR, over 4GB, and not over the top of memory, write-back attribute is returned. These condition checks are for ensuring the input memory address region is mapped to the physical memory actually. However, if the end address is

Re: [PATCH] [v2] tty: Protect disc_data in n_tty_close and n_tty_flush_buffer

2020-12-14 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

[PATCH v5] PCI: cadence: Retrain Link to work around Gen2 training defect.

2020-12-14 Thread Kishon Vijay Abraham I
From: Nadeem Athani Cadence controller will not initiate autonomous speed change if strapped as Gen2. The Retrain Link bit is set as quirk to enable this speed change. Signed-off-by: Nadeem Athani [kis...@ti.com: Enable the workaround for TI's J721E SoC] Signed-off-by: Kishon Vijay Abraham I

Re: Lockdep warning on io_file_data_ref_zero() with 5.10-rc5

2020-12-14 Thread Xiaoguang Wang
hi, On 11/28/20 5:13 PM, Pavel Begunkov wrote: On 28/11/2020 23:59, Nadav Amit wrote: Hello Pavel, I got the following lockdep splat while rebasing my work on 5.10-rc5 on the kernel (based on 5.10-rc5+). I did not actually confirm that the problem is triggered without my changes, as my

[RESEND PATCH v3 2/2] usb: dwc3: Add driver for Xilinx platforms

2020-12-14 Thread Manish Narani
Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers. This driver is also used to choose between PIPE clock coming from SerDes and the Suspend Clock. Before the controller is out of reset, the clock selection

Re: [PATCH 1/2] usb: cdnsp: Fixes for sparse warnings

2020-12-14 Thread Peter Chen
On 20-12-15 06:14:07, Pawel Laszczak wrote: > >On 20-12-15 05:27:38, Pawel Laszczak wrote: > >> > > >> > > >> >On 20-12-14 13:03:44, Pawel Laszczak wrote: > >> >> Patch fixes all sparse warnings in cdsnp driver. > >> >> > >> >> It fixes the following warnings: > >> >> cdnsp-ring.c:1441: warning:

[RESEND PATCH v3 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller

2020-12-14 Thread Manish Narani
Add documentation for Versal DWC3 controller. Add required property 'reg' for the same. Also add optional properties for snps,dwc3. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../devicetree/bindings/usb/dwc3-xilinx.txt | 17 +++-- 1 file changed, 15

[RESEND PATCH v3 0/2] Add a separate DWC3 OF driver for Xilinx platforms

2020-12-14 Thread Manish Narani
This patch series documents the Xilinx Versal DWC3 controller. This also adds a new Xilinx specific driver for adding new features in the future. Changes in v2: - Addressed review comments from v1 - merged normal and runtime suspend resume functions as they are same

[PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove unused NCI prop commands

2020-12-14 Thread Bongsu Jeon
From: Bongsu Jeon Remove the unused NCI prop commands that s3fwrn5 driver doesn't use. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/nci.c | 25 - drivers/nfc/s3fwrn5/nci.h | 22 -- 2 files changed, 47 deletions(-) diff --git

[PATCH v2 net-next 1/2] nfc: s3fwrn5: Remove the delay for NFC sleep

2020-12-14 Thread Bongsu Jeon
From: Bongsu Jeon Remove the delay for NFC sleep because the delay is only needed to guarantee that the NFC is awake. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/phy_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/phy_common.c

[PATCH v2 net-next 0/2] nfc: s3fwrn5: Refactor the s3fwrn5 module

2020-12-14 Thread Bongsu Jeon
From: Bongsu Jeon Refactor the s3fwrn5 module. 1/2 is to remove the unneeded delay for NFC sleep. 2/2 is to remove the unused NCI prop commands. ChangeLog: v2: - Update the commit messages. Bongsu Jeon (2): nfc: s3fwrn5: Remove the delay for NFC sleep nfc: s3fwrn5: Remove unused NCI

Re: linux-next: manual merge of the amdgpu tree with the pci tree

2020-12-14 Thread Kuppuswamy, Sathyanarayanan
On 12/14/20 3:37 PM, Bjorn Helgaas wrote: On Mon, Dec 14, 2020 at 06:18:54PM -0500, Alex Deucher wrote: On Mon, Dec 14, 2020 at 6:16 PM Bjorn Helgaas wrote: On Tue, Dec 15, 2020 at 07:34:31AM +1100, Stephen Rothwell wrote: Hi all, On Tue, 8 Dec 2020 13:56:20 +1100 Stephen Rothwell

RE: [EXT] Re: [PATCH 1/2] mmc: Support kmsg dumper based on pstore/blk

2020-12-14 Thread Bhaskara Budiredla
>-Original Message- >From: Ulf Hansson >Sent: Friday, December 11, 2020 5:02 PM >To: Bhaskara Budiredla >Cc: Kees Cook ; Colin Cross >; Tony Luck ; Sunil Kovvuri >Goutham ; linux-...@vger.kernel.org; Linux >Kernel Mailing List ; Christoph Hellwig > >Subject: [EXT] Re: [PATCH 1/2] mmc:

Re: [PATCH 0/3] block: blk_interposer - Block Layer Interposer

2020-12-14 Thread Bob Liu
Hi Folks, On 12/12/20 12:56 AM, Hannes Reinecke wrote: > On 12/11/20 5:33 PM, Jens Axboe wrote: >> On 12/11/20 9:30 AM, Mike Snitzer wrote: >>> While I still think there needs to be a proper _upstream_ consumer of >>> blk_interposer as a condition of it going in.. I'll let others make the >>>

Re: [PATCH 5.4 00/36] 5.4.84-rc1 review

2020-12-14 Thread Naresh Kamboju
On Mon, 14 Dec 2020 at 22:57, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.4.84 release. > There are 36 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

[PATCH] sched: don't check rq after newidle_balance return positive

2020-12-14 Thread chenxg1x
From: Chen Xiaoguang In pick_next_task_fair, if CPU is going to idle newidle_balance is called first trying to pull some tasks. When newidle_balance returns positive which means it does pulls tasks or some tasks enqueued then there is no need to check sched_fair_runnable again. Signed-off-by:

[QUESTION] Dying cgroups in subsystem cpu, pids and named hierarchy systemd

2020-12-14 Thread chenzhou
Hi all, When i do some tests with kernel-4.19.x,i found some dying cgroups. There are dying cgroup in subsystem cpu/cpuacct, memory, pids and named hierarchy systemd. The root cause of dying cgroups in memory subsystem is that some charged pages aren't gone. I don't figure out why there are

[PATCH] udlfb: Fix memory leak in dlfb_usb_probe

2020-12-14 Thread qiang . zhang
From: Zqiang The dlfb_alloc_urb_list function is called in dlfb_usb_probe function, after that if an error occurs, the dlfb_free_urb_list function need to be called. BUG: memory leak unreferenced object 0x88810adde100 (size 32): comm "kworker/1:0", pid 17, jiffies 4294947788 (age 19.520s)

Re: [PATCH v1] serial: 8250_fintek: Print Fintek chip name

2020-12-14 Thread Jiri Slaby
On 15. 12. 20, 1:29, Ji-Ze Hong (Peter Hong) wrote: Hi, Greg Kroah-Hartman 於 2020/12/14 下午 09:42 寫道:   pdata->pid = chip; + +    pr_info("%s%s%s Fintek %s\n", +    uart->port.dev ? dev_name(uart->port.dev) : "", +    uart->port.dev ? ": " : "", +    uart->port.name, +   

Re: [PATCH] Input: raydium_ts_i2c: Do not send zero length

2020-12-14 Thread Dmitry Torokhov
On Tue, Dec 15, 2020 at 02:07:00PM +0800, Jeffrey Lin wrote: > Yes, it is. Great! > > Dmitry Torokhov 於 2020年12月15日 週二 下午1:48寫道: > > > Hi Jeffrey, > > > > On Tue, Dec 15, 2020 at 11:21:06AM +0800, jeffrey.lin wrote: > > > Add default write command package to prevent i2c quirk error of zero >

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 09:37:34PM -0800, Joe Perches wrote: > On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote: > > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > > > I prefer revisions to single patches (as opposed to large patch series) > > > in the same thread. > > > >

RE: [PATCH 1/2] usb: cdnsp: Fixes for sparse warnings

2020-12-14 Thread Pawel Laszczak
>>On 20-12-15 05:27:38, Pawel Laszczak wrote: >>> > >>> > >>> >On 20-12-14 13:03:44, Pawel Laszczak wrote: >>> >> Patch fixes all sparse warnings in cdsnp driver. >>> >> >>> >> It fixes the following warnings: >>> >> cdnsp-ring.c:1441: warning: incorrect type in assignment >>> >>

Re: [PATCH] x86/mtrr: Correct the returned MTRR type of mtrr_type_lookup.

2020-12-14 Thread Huang, Ying-Tsun
On Fri, 11 Dec 2020, Borislav Petkov wrote: > [CAUTION: External Email] > > On Mon, Dec 07, 2020 at 02:12:26PM +0800, Ying-Tsun Huang wrote: > > In mtrr_type_lookup, if the input memory address region is not in the > > MTRR, over 4GB, and not over the top of memory, write-back attribute > >

Re: [PATCH v4 3/3] scsi: ufs: Revert "Make sure clk scaling happens only when HBA is runtime ACTIVE"

2020-12-14 Thread Stanley Chu
On Sun, 2020-12-13 at 08:31 -0800, Can Guo wrote: > Commit 73cc291c27024 ("Make sure clk scaling happens only when HBA is > runtime ACTIVE") is no longer needed since commit f7a42540928a8 ("scsi: > ufs: Protect some contexts from unexpected clock scaling") is a more > mature fix to protect UFS LLD

RE: [PATCH 1/2] usb: cdnsp: Fixes for sparse warnings

2020-12-14 Thread Pawel Laszczak
>On 20-12-15 05:27:38, Pawel Laszczak wrote: >> > >> > >> >On 20-12-14 13:03:44, Pawel Laszczak wrote: >> >> Patch fixes all sparse warnings in cdsnp driver. >> >> >> >> It fixes the following warnings: >> >> cdnsp-ring.c:1441: warning: incorrect type in assignment >> >> cdnsp-ring.c:1444:

Re: [PATCH] proc: Escape more characters in /proc/mounts output

2020-12-14 Thread Al Viro
On Tue, Dec 15, 2020 at 09:54:54AM +0530, Siddhesh Poyarekar wrote: > + get_user(byte, (const char __user *)data); > + > + return byte ? strndup_user(data, PATH_MAX) : NULL; > } No. Not to mention anything else, you * fetch the same data twice * fail to check the

Re: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline'

2020-12-14 Thread Guo Ren
Hi Arnd, On Mon, Dec 14, 2020 at 9:15 PM Arnd Bergmann wrote: > > On Sat, Dec 12, 2020 at 9:01 PM Thomas Gleixner wrote: > > > > On Sat, Dec 12 2020 at 13:26, Marco Elver wrote: > > > On Thu, Mar 07, 2019 at 10:14AM +0100, Arnd Bergmann wrote: > > >> -static void __init

Re: [PATCH 1/2] usb: cdnsp: Fixes for sparse warnings

2020-12-14 Thread Peter Chen
On 20-12-15 05:27:38, Pawel Laszczak wrote: > > > > > >On 20-12-14 13:03:44, Pawel Laszczak wrote: > >> Patch fixes all sparse warnings in cdsnp driver. > >> > >> It fixes the following warnings: > >> cdnsp-ring.c:1441: warning: incorrect type in assignment > >> cdnsp-ring.c:1444: warning:

Re: [PATCH] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2020-12-14 Thread Jarkko Sakkinen
On Tue, Dec 15, 2020 at 07:56:01AM +0200, Jarkko Sakkinen wrote: > On Mon, Dec 14, 2020 at 11:01:32AM -0800, Sean Christopherson wrote: > > On Fri, Dec 11, 2020, Jarkko Sakkinen wrote: > > > Each sgx_mmun_notifier_release() starts a grace period, which means that > > > > Should be

Re: [PATCH] usb: cdns3: Adds missing __iomem markers

2020-12-14 Thread Peter Chen
WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000sdata=ZVS4723WbEO03hbsLXJ%2B%2FmB5EZElulY7lAsMEMatiko%3Dreserved=0 > git fetch --no-tags linux-review > Pawel-Laszczak/usb-cdns3-Adds-missing-__iomem-markers/20201214-205353 > git checkout 315bfcf1e0604d

Re: [PATCH v4 2/3] scsi: ufs: Clean up ufshcd_exit_clk_scaling/gating()

2020-12-14 Thread Stanley Chu
On Sun, 2020-12-13 at 08:31 -0800, Can Guo wrote: > ufshcd_hba_exit() is always called after ufshcd_exit_clk_scaling() and > ufshcd_exit_clk_gating(), so move ufshcd_exit_clk_scaling/gating() to > ufshcd_hba_exit(). > > Signed-off-by: Can Guo Reviewed-by: Stanley Chu

Re: [PATCH] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

2020-12-14 Thread Jarkko Sakkinen
On Mon, Dec 14, 2020 at 11:01:32AM -0800, Sean Christopherson wrote: > On Fri, Dec 11, 2020, Jarkko Sakkinen wrote: > > Each sgx_mmun_notifier_release() starts a grace period, which means that > > Should be sgx_mmu_notifier_release(), here and in the comment. Thanks. > > one extra

Re: [PATCH] Input: raydium_ts_i2c: Do not send zero length

2020-12-14 Thread Dmitry Torokhov
Hi Jeffrey, On Tue, Dec 15, 2020 at 11:21:06AM +0800, jeffrey.lin wrote: > Add default write command package to prevent i2c quirk error of zero > data length as Raydium touch firmware update is executed. > > Signed-off-by: jeffrey.lin > BUG=b:174207906 > TEST=Successfully tested update Raydium

[PATCH v4 0/3] add custom hinge sensor support

2020-12-14 Thread Ye Xiang
Here we register one iio device with three channels which present angle for hinge, keyboard and screen. This driver works on devices with Intel integrated sensor hub, where hinge sensor is presented using a custom sensor usage id. Here the angle is presented in degrees, which is converted to

Re: [PATCH 00/10] workqueue: break affinity initiatively

2020-12-14 Thread Lai Jiangshan
On Tue, Dec 15, 2020 at 1:36 AM Peter Zijlstra wrote: > > On Mon, Dec 14, 2020 at 11:54:47PM +0800, Lai Jiangshan wrote: > > From: Lai Jiangshan > > > > 06249738a41a ("workqueue: Manually break affinity on hotplug") > > said that scheduler will not force break affinity for us. > > > > But

[PATCH v4 3/3] iio:Documentation: Add documentation for hinge sensor channels

2020-12-14 Thread Ye Xiang
Add channel description for hinge sensor, including channel label attribute and raw data description. Signed-off-by: Ye Xiang --- Documentation/ABI/testing/sysfs-bus-iio | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-iio

[PATCH v4 2/3] iio: hid-sensors: Add hinge sensor driver

2020-12-14 Thread Ye Xiang
The Hinge sensor is a common custom sensor on laptops. It calculates the angle between the lid (screen) and the base (keyboard). In addition, it also exposes screen and the keyboard angles with respect to the ground. Applications can easily get laptop's status in space through this sensor, in

[PATCH v4 1/3] HID: hid-sensor-custom: Add custom sensor iio support

2020-12-14 Thread Ye Xiang
Currently custom sensors properties are not decoded and it is up to user space to interpret. Some manufacturers already standardized the meaning of some custom sensors. They can be presented as a proper IIO sensor. We can identify these sensors based on manufacturer and serial number property in

Re: [PATCH v4 1/3] scsi: ufs: Protect some contexts from unexpected clock scaling

2020-12-14 Thread Stanley Chu
Hi Can, On Sun, 2020-12-13 at 08:31 -0800, Can Guo wrote: > In contexts like suspend, shutdown and error handling, we need to suspend > devfreq to make sure these contexts won't be disturbed by clock scaling. > However, suspending devfreq is not enough since users can still trigger a > clock

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Joe Perches
On Tue, 2020-12-15 at 07:18 +0200, Leon Romanovsky wrote: > On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > > I prefer revisions to single patches (as opposed to large patch series) > > in the same thread. > > It depends which side you are in that game. From the reviewer point of >

Re: [LKP] Re: [sched/hotplug] 2558aacff8: will-it-scale.per_thread_ops -1.6% regression

2020-12-14 Thread Xing Zhengjun
On 12/11/2020 12:14 AM, Peter Zijlstra wrote: On Thu, Dec 10, 2020 at 04:18:59PM +0800, kernel test robot wrote: FYI, we noticed a -1.6% regression of will-it-scale.per_thread_ops due to commit: commit: 2558aacff8586699bcd248b406febb28b0a25de2 ("sched/hotplug: Ensure only per-cpu kthreads

[PATCH V3 3/3] arm64: topology: Make AMUs work with modular cpufreq drivers

2020-12-14 Thread Viresh Kumar
The AMU counters won't get used today if the cpufreq driver is built as a module as the amu core requires everything to be ready by late init. Fix that properly by registering for cpufreq policy notifier. Note that the amu core don't have any cpufreq dependency after the first time

[PATCH V3 2/3] arm64: topology: Reorder init_amu_fie() a bit

2020-12-14 Thread Viresh Kumar
This patch does a couple of optimizations in init_amu_fie(), like early exits from paths where we don't need to continue any further, avoid the enable/disable dance, moving the calls to topology_scale_freq_invariant() just when we need them, instead of at the top of the routine, and avoiding

Re: [PATCH v41 00/24] Intel SGX foundations

2020-12-14 Thread Hui, Chunyang
On Fri, Nov 13, 2020 at 12:01:11AM +0200, Jarkko Sakkinen wrote: > Overview > > > Intel(R) SGX is new hardware functionality that can be used by > applications to populate protected regions of user code and data called > enclaves. Once activated, the new hardware protects enclave code

[PATCH V3 1/3] arm64: topology: Avoid the have_policy check

2020-12-14 Thread Viresh Kumar
Every time I have stumbled upon this routine, I get confused with the way 'have_policy' is used and I have to dig in to understand why is it so. Here is an attempt to make it easier to understand, and hopefully it is an improvement. The 'have_policy' check was just an optimization to avoid

Re: [PATCH v41 00/24] Intel SGX foundations

2020-12-14 Thread Hui, Chunyang
On Fri, Nov 13, 2020 at 12:01:11AM +0200, Jarkko Sakkinen wrote: > Overview > > > Intel(R) SGX is new hardware functionality that can be used by > applications to populate protected regions of user code and data called > enclaves. Once activated, the new hardware protects enclave code

!!! Ask Details For Relief

2020-12-14 Thread United Nations Covid-19 Relief Unit
You has been chosen via E-mail for the United Nations Covid-19 Relief F und, for more details reply to sangior...@aclipisa.it Best regards, Dr. Susan Marshal

RE: [PATCH 1/2] usb: cdnsp: Fixes for sparse warnings

2020-12-14 Thread Pawel Laszczak
> > >On 20-12-14 13:03:44, Pawel Laszczak wrote: >> Patch fixes all sparse warnings in cdsnp driver. >> >> It fixes the following warnings: >> cdnsp-ring.c:1441: warning: incorrect type in assignment >> cdnsp-ring.c:1444: warning: restricted __le32 degrades to integer >> cdnsp-ring.c:2200:

Re: [PATCH -next] usb: phy: convert comma to semicolon

2020-12-14 Thread Peter Chen
On 20-12-11 16:54:28, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Reviewed-by: Peter Chen Peter > --- > drivers/usb/phy/phy-isp1301-omap.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [PATCH rdma-rc 0/5] Fixes to v5.10

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 03:27:22PM -0400, Jason Gunthorpe wrote: > On Sun, Dec 13, 2020 at 03:29:35PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > This is another series with various fixes that can easily go to -next too. > > > > Thanks > > > > Leon Romanovsky (1):

Re: [PATCH v3 4/6] mm: honor PF_MEMALLOC_PIN for all movable pages

2020-12-14 Thread Pavel Tatashin
On Mon, Dec 14, 2020 at 9:17 AM Michal Hocko wrote: > > On Fri 11-12-20 15:21:38, Pavel Tatashin wrote: > [...] > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index c2dea9ad0e98..4d8e7f801c66 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -3802,16 +3802,12 @@

Re: [PATCH] kvm: don't lose the higher 32 bits of tlbs_dirty

2020-12-14 Thread Lai Jiangshan
On Tue, Dec 15, 2020 at 1:20 AM Sean Christopherson wrote: > > On Sun, Dec 13, 2020, Lai Jiangshan wrote: > > From: Lai Jiangshan > > > > In kvm_mmu_notifier_invalidate_range_start(), tlbs_dirty is used as: > > need_tlb_flush |= kvm->tlbs_dirty; > > with need_tlb_flush's type being int and

Re: [PATCH v4 2/3] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2020-12-14 Thread 黃啟原
> On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > From: ChiYuan Huang > > > > Adds DT binding document for Richtek RT4831 backlight. > > > > Signed-off-by: ChiYuan Huang > > --- > > since v3 > > - Move inlcude/dt-bindings/leds/rt4831-backlight.h from v3 mfd > > binding patch

Re: [PATCH v4 2/3] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2020-12-14 Thread 黃啟原
On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > Hi, > > Daniel Thompson 於 2020年12月14日 週一 > 下午5:59寫道: > > > > > > Hi CY > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > > > From: ChiYuan Huang > > > > > > Adds DT binding document for Richtek RT4831

Re: [PATCH v2] net/mlx4: Use true,false for bool variable

2020-12-14 Thread Leon Romanovsky
On Mon, Dec 14, 2020 at 11:15:01AM -0800, Joe Perches wrote: > On Mon, 2020-12-14 at 11:03 -0800, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 13:16:08 +0200 Leon Romanovsky wrote: > > > On Mon, Dec 14, 2020 at 11:30:08AM +0100, Vasyl Gomonovych wrote: > > > > It is fix for semantic patch warning

Re: [PATCH v3 3/6] mm: apply per-task gfp constraints in fast path

2020-12-14 Thread Pavel Tatashin
> Ack to this. Thank you. > > But I do not really understand this. All allocation contexts should have > a proper gfp mask so why do we have to call current_gfp_context here? > In fact moving the current_gfp_context in the allocator path should have > made all this games unnecessary. Memcg

Re: [PATCH v4 2/3] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2020-12-14 Thread ChiYuan Huang
cy_huang(黃啟原) 於 2020年12月15日 週二 下午1:08寫道: > > On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > > > > Hi, > > > > Daniel Thompson 於 2020年12月14日 週一 > > 下午5:59寫道: > > > > > > > > > Hi CY > > > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > > > > > > From:

Re: [PATCH v2 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2020-12-14 Thread Xu Yilun
On Mon, Dec 14, 2020 at 08:43:31PM -0800, Tom Rix wrote: > > On 12/14/20 6:22 PM, Xu Yilun wrote: > > On Mon, Dec 14, 2020 at 02:14:56PM -0800, Tom Rix wrote: > >> On 12/13/20 7:36 PM, Xu Yilun wrote: > >>> This patch adds description for UIO support for dfl devices on DFL > >>> bus. > >>> > >>>

[PATCH] MIPS: No need to check CPU 0 in cps_cpu_disable()

2020-12-14 Thread Tiezhu Yang
After commit 9cce844abf07 ("MIPS: CPU#0 is not hotpluggable"), c->hotpluggable is 0 for CPU 0 and it will not generate a control file in sysfs for this CPU: [root@linux loongson]# cat /sys/devices/system/cpu/cpu0/online cat: /sys/devices/system/cpu/cpu0/online: No such file or directory

Re: [PATCH 1/2] usb: cdnsp: Fixes for sparse warnings

2020-12-14 Thread Peter Chen
On 20-12-14 13:03:44, Pawel Laszczak wrote: > Patch fixes all sparse warnings in cdsnp driver. > > It fixes the following warnings: > cdnsp-ring.c:1441: warning: incorrect type in assignment > cdnsp-ring.c:1444: warning: restricted __le32 degrades to integer > cdnsp-ring.c:2200: warning: dubious:

Re: linux-next: manual merge of the parisc-hd tree with the asm-generic tree

2020-12-14 Thread Stephen Rothwell
Hi Helge, On Tue, 15 Dec 2020 05:45:49 +0100 Helge Deller wrote: > > I dropped the patch from the parisc-hd tree for now - > it needs more work and will not be part of the next merge window. Thanks for letting me know. -- Cheers, Stephen Rothwell pgpNgyoZ38GwF.pgp Description: OpenPGP

Re: [PATCH net-next] seg6: fix the max number of supported SRv6 behavior attributes

2020-12-14 Thread Jakub Kicinski
On Sat, 12 Dec 2020 02:00:05 +0100 Andrea Mayer wrote: > The set of required attributes for a given SRv6 behavior is identified > using a bitmap stored in an unsigned long, since the initial design of > SRv6 networking in Linux. Recently the same approach has been used for > identifying the

Re: [PATCH] drivers: core: Detach device from power domain on shutdown

2020-12-14 Thread Furquan Shaikh
On Tue, Dec 1, 2020 at 1:30 PM Furquan Shaikh wrote: > > When the system is powered off or rebooted, devices are not detached > from their PM domain. This results in ACPI PM not being invoked and > hence PowerResouce _OFF method not being invoked for any of the > devices. Because the ACPI power

Re: [GIT PULL] keys: Collected minor fixes and cleanups

2020-12-14 Thread Jarkko Sakkinen
On Mon, Dec 14, 2020 at 12:49:27PM -0800, Linus Torvalds wrote: > The pain just isn't worth it, but more importantly, you simply need to > get your workflow in order, and not send me completely untested > garbage that hasn't even been compiled. I have now more bandwidth. It was mostly eaten by

Re: [PATCH V2 2/2] arm64: topology: Reorder init_amu_fie() a bit

2020-12-14 Thread Viresh Kumar
On 14-12-20, 14:00, Ionela Voinescu wrote: > I think there could be a potential problem here (it would be unlikely > but why not fix it :) ). It was in the code before your changes. > > When we enable amu_fie_key here, topology_scale_freq_tick() could be > called for AMU CPUs, which will compute

Re: linux-next: manual merge of the parisc-hd tree with the asm-generic tree

2020-12-14 Thread Helge Deller
On 12/14/20 8:48 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 2 Nov 2020 12:38:41 +1100 Stephen Rothwell > wrote: >> >> Today's linux-next merge of the parisc-hd tree got a conflict in: >> >> arch/parisc/kernel/time.c >> >> between commit: >> >> 686092e7daaa ("parisc: use

RE: [PATCH v3 5/6] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2020-12-14 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Tuesday, December 8, 2020 11:08 PM > > An erroneous or malicious host could send multiple rescind messages for > a same channel. In vmbus_onoffer_rescind(), the guest maps the channel > ID to obtain a pointer to the channel object and it eventually releases

Re: [PATCH v2 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2020-12-14 Thread Tom Rix
On 12/14/20 6:22 PM, Xu Yilun wrote: > On Mon, Dec 14, 2020 at 02:14:56PM -0800, Tom Rix wrote: >> On 12/13/20 7:36 PM, Xu Yilun wrote: >>> This patch adds description for UIO support for dfl devices on DFL >>> bus. >>> >>> Signed-off-by: Xu Yilun >>> --- >>> v2: no doc in v1, add it for v2.

Re: BUG: soft lockup in mac80211_hwsim_beacon

2020-12-14 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:2c85ebc5 Linux 5.10 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148fcc1350 kernel config: https://syzkaller.appspot.com/x/.config?x=8aff533d6c635e6 dashboard link:

  1   2   3   4   5   6   7   8   9   10   >