Re: Registering IRQ for MT7530 internal PHYs

2020-12-30 Thread Florian Fainelli
On 12/30/2020 1:12 AM, Heiner Kallweit wrote: > On 30.12.2020 10:07, DENG Qingfang wrote: >> Hi Heiner, >> Thanks for your reply. >> >> On Wed, Dec 30, 2020 at 3:39 PM Heiner Kallweit wrote: >>> I don't think that's the best option. >> >> I'm well aware of that. >> >>> You may want to add a

Re: [PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Russell King - ARM Linux admin
On Wed, Dec 30, 2020 at 04:47:54PM +0100, Pali Rohár wrote: > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM. > > Such combination of bits is meaningless so assume that LOS signal is not > implemented.

Re: [PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-30 Thread Russell King - ARM Linux admin
On Wed, Dec 30, 2020 at 04:47:53PM +0100, Pali Rohár wrote: > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set SFF phys_id > in their EEPROM. Kernel SFP subsystem currently does not allow to use > modules detected as SFF. > > This change extends check for SFP modules so also those

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Russell King - ARM Linux admin
On Wed, Dec 30, 2020 at 04:47:52PM +0100, Pali Rohár wrote: > Workaround for GPON SFP modules based on VSOL V2801F brand was added in > commit 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 > v2.0 workaround"). But it works only for ids explicitly added to the list. > As there

Re: [RFC PATCH v2 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2020-12-30 Thread Lars-Peter Clausen
On 12/30/20 2:41 PM, Jonathan Cameron wrote: On Thu, 24 Dec 2020 03:19:21 + Jyoti Bhayana wrote: + /* +* The seconds field in the sensor interval in SCMI is 16 bits long +* Therefore seconds = 1/Hz <= 0x. As floating point calculations are +*

Re: [PATCH v2 2/2] KVM: SVM: Add support for Virtual SPEC_CTRL

2020-12-30 Thread Sean Christopherson
On Wed, Dec 30, 2020, Borislav Petkov wrote: > On Tue, Dec 22, 2020 at 04:31:55PM -0600, Babu Moger wrote: > > @@ -2549,7 +2559,10 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, struct > > msr_data *msr_info) > > !guest_cpuid_has(vcpu, X86_FEATURE_AMD_SSBD)) > >

Re: [PATCH] hwmon: fix sbtsi_temp Documenation kernel-doc warning

2020-12-30 Thread Guenter Roeck
On Mon, Dec 28, 2020 at 07:54:28PM -0800, Randy Dunlap wrote: > Fix Documentation/hwmon/ kernel-doc warning in 5.11-rc1: > > lnx-511-rc1/Documentation/hwmon/sbtsi_temp.rst:4: WARNING: Title underline > too short. > > Kernel driver sbtsi_temp > == > > Fixes: 6ec3fcf556fe

[RFC V2] block: reject I/O for same fd if block size changed

2020-12-30 Thread Minwoo Im
Let's say, for example of NVMe device, Format command to change out LBA format to another logical block size and BLKRRPART to re-read partition information with a same file descriptor like: fd = open("/dev/nvme0n1", O_RDONLY); nvme_format(fd, ...); if (ioctl(fd,

[PATCH] ARM: avoid cpuidle link warning

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Since commit 83109d5d5fba ("x86/build: Warn on orphan section placement"), we get a warning for objects in orphan sections. The cpuidle implementation for OMAP causes this when CONFIG_CPU_IDLE is disabled: arm-linux-gnueabi-ld: warning: orphan section

[PATCH 4/4] ARM: dts: qcom: msm8974-klte: Mark essential regulators

2020-12-30 Thread Iskren Chernev
s1 and l12 regulators are used for the memory and cache on the Samsung S5 (klte). If they are turned off the phone shuts down. So mark them as always-on to prevent that from happening. Signed-off-by: Iskren Chernev --- arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 2 ++ 1 file changed, 2

[PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

2020-12-30 Thread Iskren Chernev
From: Samuel Pascua Add initial support for the display found on the Samsung Galaxy 5 (klte) phone. This is based on work from Jonathan Marek & Brian Masney. Please note that this patch depends on dt-binding patch in [1] [1] https://lkml.org/lkml/2020/12/30/293 Signed-off-by: Samuel Pascua

[PATCH 2/4] ARM: dts: qcom: msm8974-klte: add support for GPU

2020-12-30 Thread Iskren Chernev
From: Samuel Pascua Signed-off-by: Samuel Pascua --- arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts index 97352de913142..1d5e8abdbda79

[PATCH] clk: imx: fix Kconfig warning for i.MX SCU clk

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann A previous patch introduced a harmless randconfig warning: WARNING: unmet direct dependencies detected for MXC_CLK_SCU Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y] Selected by [m]: - CLK_IMX8QXP [=m] && COMMON_CLK [=y] &&

[PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2020-12-30 Thread Iskren Chernev
From: Brian Masney Add support for the a3xx GPU Signed-off-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 45 + 1 file changed, 45 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index

[PATCH 4/4] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

2020-12-30 Thread Pali Rohár
SFP GPON module Ubiquiti U-Fiber Instant has in its EEPROM stored nonsense information. It claims that support all transceiver types including 10G Ethernet which is not truth. So clear all claimed modes and set only one mode which module supports: 1000baseX_Full. This change finally allows to

[PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Building ubsan kernels even for compile-testing introduced these warnings in my randconfig environment: crypto/blake2b_generic.c:98:13: error: stack frame size of 9636 bytes in function 'blake2b_compress' [-Werror,-Wframe-larger-than=] static void blake2b_compress(struct

[PATCH 3/4] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set

2020-12-30 Thread Pali Rohár
Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM. Such combination of bits is meaningless so assume that LOS signal is not implemented. This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber

[PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2020-12-30 Thread Pali Rohár
Workaround for GPON SFP modules based on VSOL V2801F brand was added in commit 0d035bed2a4a ("net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround"). But it works only for ids explicitly added to the list. As there are more rebraded VSOL V2801F modules and OEM vendors are putting into

[PATCH 2/4] net: sfp: allow to use also SFP modules which are detected as SFF

2020-12-30 Thread Pali Rohár
Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set SFF phys_id in their EEPROM. Kernel SFP subsystem currently does not allow to use modules detected as SFF. This change extends check for SFP modules so also those with SFF phys_id are allowed. With this change also GPON SFP module

[PATCH 0/4] net: sfp: add support for GPON RTL8672/RTL9601C and Ubiquiti U-Fiber

2020-12-30 Thread Pali Rohár
This patch series add generic workaround for reading EEPROM content from broken GPON SFP modules based on Realtek RTL8672/RTL9601C chips and add another workarounds for GPON SFP module Ubiquiti U-Fiber Instant. GPON SFP modules based on Realtek RTL8672/RTL9601C chips do not have a real EEPROM but

[PATCH] pinctrl: nomadik: remove an unused variable

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann A recent patch added a local variable twice: drivers/pinctrl/nomadik/pinctrl-nomadik.c:953:8: error: unused variable 'wake' [-Werror,-Wunused-variable] Remove the unused outer declaration Fixes: f3925032d7fd ("pinctrl: nomadik: Use irq_has_action()") Signed-off-by: Arnd

[PATCH] genirq: Export irq_check_status_bit

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Changing some inline functions to use the new irq_check_status_bit function out of line breaks calling them from loadable modules: ERROR: modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined! Export the function to make it work again. One can debate over

Re: [PATCH 2/6] mm/mremap: For MREMAP_DONTUNMAP check security_vm_enough_memory_mm()

2020-12-30 Thread Brian Geffon
Ah, you're right. This individual patch looks good to me. Brian On Mon, Dec 28, 2020 at 11:12 AM Dmitry Safonov wrote: > > On 12/28/20 6:21 PM, Brian Geffon wrote: > > This looks good to me with a small comment. > > > >> if (do_munmap(mm, old_addr, old_len, uf_unmap) < 0) { > >>

[PATCH] ASoC: fsl: fix -Wmaybe-uninitialized warning

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Clang points out a code path that returns an undefined value in an error case: sound/soc/fsl/imx-hdmi.c:165:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsom etimes-uninitialized] if ((hdmi_out && hdmi_in) || (!hdmi_out &&

[PATCH] arm64/smp: Remove unused 'irq' variable

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann The only use of this variable was removed in a recent patch: arch/arm64/kernel/smp.c:810:16: error: unused variable 'irq' [-Werror,-Wunused-variable] unsigned int irq = irq_desc_get_irq(ipi_desc[i]); Fixes: 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu()

Re: sound

2020-12-30 Thread Christian Labisch
Thank you Greg, I am running Fedora 33 with kernel 5.9.16, which works correctly. All stable 5.10 versions up to 5.10.3 are having the sound issue. Once 5.10.4 will be available on koji I'm gonna test if it works. Thanks again ! Regards, Christian On Wed, 2020-12-30 at 16:36 +0100, Greg KH

[PATCH] ASoC: mediatek: add MTK_PMIC_WRAP dependency

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Randconfig builds often show harmless warnings like WARNING: unmet direct dependencies detected for SND_SOC_MT6359 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && MTK_PMIC_WRAP [=n] Selected by [y]: - SND_SOC_MT8192_MT6359_RT1015_RT5682 [=y] && SOUND

Re: [PATCH] iio: adc: stm32-dfsdm: Remove redundant null check before clk_disable_unprepare

2020-12-30 Thread Jonathan Cameron
On Fri, 18 Dec 2020 09:41:45 + Xu Wang wrote: > ecause clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. Please resend, making sure to cc linux-...@vger.kernel.org Thanks, Jonathan > > Signed-off-by: Xu Wang > --- >

[PATCH] i3c/master/mipi-i3c-hci: re-fix __maybe_unused attribute

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann clang warns because the added __maybe_unused attribute is in the wrong place: drivers/i3c/master/mipi-i3c-hci/core.c:780:21: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] static const struct __maybe_unused of_device_id

[PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann clang cannt evaluate this function argument at compile time when the function is not inlined, which leads to a link time failure: ld.lld: error: undefined symbol: __compiletime_assert_414 >>> referenced by mremap.c >>> mremap.o:(get_extent) in archive

[PATCH] i915: fix shift warning

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Randconfig builds on 32-bit machines show lots of warnings for the i915 driver for incorrect bit masks like: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2584:9: error: shift count >= width of type [-Werror,-Wshift-count-overflow] return

[PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

2020-12-30 Thread Daniel Lezcano
32 bits architectures do not support u64 division, so the macro DIV_ROUND_CLOSEST is not adequate as the compiler will replace the call to an unexisting function for the platform, leading to an unresolved symbols. Fix this by using the compatible macros: DIV64_U64_ROUND_CLOSEST and

Re: sound

2020-12-30 Thread Greg KH
On Wed, Dec 30, 2020 at 04:26:00PM +0100, Christian Labisch wrote: > Hello ! > > I could need your help ... I have tested the new kernel 5.10.3 and sound > doesn't work with this > version. > Seems the new Intel audio drivers are the main reason. What can be done ? Do > you have any ideas ? >

Re: [PATCH] nvme: hwmon: fix crash on device teardown

2020-12-30 Thread Daniel Wagner
On Wed, Dec 30, 2020 at 04:16:53PM +0100, Daniel Wagner wrote: > I've attached the hwmon to the nvme object, which fixes the obvious > problem. But I still don't see any 'DEVRES REM' message. This would > indicate the nvme object never really goes away... more debugging... Stupid me, the nvme

Re: [PATCH v7 5/5] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8

2020-12-30 Thread Jonathan Cameron
On Fri, 25 Dec 2020 19:15:38 -0500 William Breathitt Gray wrote: > The LSI/CSI LS7266R1 chip provides programmable output via the FLG pins. > When interrupts are enabled on the ACCES 104-QUAD-8, they occur whenever > FLG1 is active. Four functions are available for the FLG1 signal: Carry, >

[PATCH 1/2] drm/msm: Call msm_init_vram before binding the gpu

2020-12-30 Thread Iskren Chernev
From: Craig Tatlor vram.size is needed when binding a gpu without an iommu and is defined in msm_init_vram(), so run that before binding it. Signed-off-by: Craig Tatlor --- drivers/gpu/drm/msm/msm_drv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2020-12-30 Thread Qais Yousef
On 12/30/20 14:28, Jiri Olsa wrote: > On Wed, Dec 30, 2020 at 02:28:02PM +0100, Jiri Olsa wrote: > > On Wed, Dec 30, 2020 at 10:03:37AM +0100, Jiri Olsa wrote: > > > On Tue, Dec 29, 2020 at 11:28:35PM +, Qais Yousef wrote: > > > > Hi Jiri > > > > > > > > On 12/29/20 18:34, Jiri Olsa wrote: >

[PATCH 2/2] drm/msm: Add modparam to allow vram carveout

2020-12-30 Thread Iskren Chernev
Using the GPU with a VRAM Carveout is a security vulnerability. Nevertheless it is sometimes required, especially when no IOMMU implementation is available for a certain platform. Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 6 --

sound

2020-12-30 Thread Christian Labisch
Hello ! I could need your help ... I have tested the new kernel 5.10.3 and sound doesn't work with this version. Seems the new Intel audio drivers are the main reason. What can be done ? Do you have any ideas ? Intel Catpt driver support is new ... This deprecates the previous Haswell SoC

Re: Registering IRQ for MT7530 internal PHYs

2020-12-30 Thread Andrew Lunn
On Wed, Dec 30, 2020 at 09:42:09AM +, Marc Zyngier wrote: > > +static irqreturn_t > > +mt7530_irq(int irq, void *data) > > +{ > > + struct mt7530_priv *priv = data; > > + bool handled = false; > > + int phy; > > + u32 val; > > + > > + val = mt7530_read(priv, MT7530_SYS_INT_STS); > >

[PATCH 2/2] drm/panel: simple: add samsung,s6e3fa2 panel

2020-12-30 Thread Iskren Chernev
From: Samuel Pascua This panel is used on the Samsung Galaxy S5 (klte). Signed-off-by: Samuel Pascua --- drivers/gpu/drm/panel/panel-simple.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

[PATCH] ARM: imx: fix imx8m dependencies

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann Selecting ARM_GIC_V3 on non-CP15 processors leads to build failures like arch/arm/include/asm/arch_gicv3.h: In function 'write_ICC_AP1R3_EL1': arch/arm/include/asm/arch_gicv3.h:36:40: error: 'c12' undeclared (first use in this function) 36 | #define __ICC_AP1Rx(x)

[PATCH 1/2] dt-bindings: panel-simple: add samsung,s6e3fa2 panel

2020-12-30 Thread Iskren Chernev
Add samsung,s6e3fa2 in the allowed simple-panel compat strings. Signed-off-by: Iskren Chernev --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml

Re: [PATCH] nvme: hwmon: fix crash on device teardown

2020-12-30 Thread Daniel Wagner
On Wed, Dec 30, 2020 at 03:38:05PM +0100, Daniel Wagner wrote: > I've enabled CONFIG_DEVRES_DEBUG and see only 'DEVRES ADD' message. If I > read it correctly the problem is that the resource is attached to the ctl > devm object and not for the nvme devm object. I've attached the hwmon to the nvme

Re: Registering IRQ for MT7530 internal PHYs

2020-12-30 Thread Andrew Lunn
> 2. Allocated ds->slave_mii_bus before calling ds->ops->setup, because > we cannot call dsa_slave_mii_bus_init which is private. > > Any better ideas? Do what mv88e6xxx does, allocate the MDIO bus inside the switch driver. Andrew

Re: Registering IRQ for MT7530 internal PHYs

2020-12-30 Thread Andrew Lunn
> > +static void mt7530_irq_bus_lock(struct irq_data *d) > > +{ > > + struct mt7530_priv *priv = irq_data_get_irq_chip_data(d); > > + > > + mutex_lock(>reg_mutex); > > Are you always guaranteed to be in a thread context? I guess that > is the case, given that you request a threaded interrupt,

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2020-12-30 Thread Jiri Olsa
On Wed, Dec 30, 2020 at 11:19:36AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 30, 2020 at 02:28:52PM +0100, Jiri Olsa escreveu: > > On Wed, Dec 30, 2020 at 02:28:02PM +0100, Jiri Olsa wrote: > > > On Wed, Dec 30, 2020 at 10:03:37AM +0100, Jiri Olsa wrote: > > > > On Tue, Dec 29, 2020 at

Re: [PATCH v7 3/5] counter: Add character device interface

2020-12-30 Thread Jonathan Cameron
On Fri, 25 Dec 2020 19:15:36 -0500 William Breathitt Gray wrote: > This patch introduces a character device interface for the Counter > subsystem. Device data is exposed through standard character device read > operations. Device data is gathered when a Counter event is pushed by > the

[PATCH] mt76: fix enum conversion warning

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann A recent patch changed some enum values, but not the type declaration for the assignment: drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:238:9: error: implicit conversion from enumeration type 'enum mt76_mcuq_id' to different enumeration type 'enum mt76_txq_id'

[PATCH] rtc: rx6110: fix build against modular I2C

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann With CONFIG_I2C=m, the #ifdef section is disabled, as shown by this warning: drivers/rtc/rtc-rx6110.c:314:12: error: unused function 'rx6110_probe' [-Werror,-Wunused-function] Change the driver to use IS_ENABLED() instead, which works for both module and built-in

[PATCH 2/2] spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery

2020-12-30 Thread Lad Prabhakar
Use __maybe_unused for the suspend()/resume() hooks and get rid of the CONFIG_PM_SLEEP ifdefery to improve the code. Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar --- drivers/spi/spi-rpc-if.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git

[PATCH 0/2] spi: rpc-if: Trivial fixes

2020-12-30 Thread Lad Prabhakar
Hi All, These patches are trivial fixes for rpc-if SPI driver. Cheers, Prabhakar Lad Prabhakar (2): spi: rpc-if: Avoid use of C++ style comments spi: rpc-if: Remove CONFIG_PM_SLEEP ifdefery drivers/spi/spi-rpc-if.c | 25 ++--- 1 file changed, 10 insertions(+), 15

[PATCH 1/2] spi: rpc-if: Avoid use of C++ style comments

2020-12-30 Thread Lad Prabhakar
Replace C++ style comment with C style. Signed-off-by: Lad Prabhakar --- drivers/spi/spi-rpc-if.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-rpc-if.c b/drivers/spi/spi-rpc-if.c index 3579675485a5..bf64da322e67 100644 ---

[PATCH] jffs2: fix use after free in jffs2_sum_write_data()

2020-12-30 Thread trix
From: Tom Rix clang static analysis reports this problem fs/jffs2/summary.c:794:31: warning: Use of memory after it is freed c->summary->sum_list_head = temp->u.next; ^~~~ In jffs2_sum_write_data(), in a loop summary data is

Re: [PATCH v2 23/48] soc/tegra: pmc: Pulse resets after removing power clamp

2020-12-30 Thread Dmitry Osipenko
17.12.2020 21:06, Dmitry Osipenko пишет: > The GR3D1 hardware unit needs to pulse hardware reset after removing power > clamp, otherwise reset won't be deasserted. Hence give reset a pulse after > removing the clamp. This stayed unnoticed previously because power > management wasn't supported by

[PATCH] regulator: qcom-rpmh: add QCOM_COMMAND_DB dependency

2020-12-30 Thread Arnd Bergmann
From: Arnd Bergmann A built-in regulator driver cannot link against a modular cmd_db driver: qcom-rpmh-regulator.c:(.text+0x174): undefined reference to `cmd_db_read_addr' There is already a dependency for RPMh, so add another one of this type for cmd_db. Fixes: 34c5aa2666db ("regulator:

Re: [PATCH AUTOSEL 5.10 20/31] um: allocate a guard page to helper threads

2020-12-30 Thread Johannes Berg
On Wed, 2020-12-30 at 08:03 -0500, Sasha Levin wrote: > > We've been running into stack overflows in helper threads > corrupting memory For the record, that was mostly referring to "while development", so while this change makes a few things a bit safer, I don't think there's all that much point

Re: [PATCH v7 4/5] docs: counter: Document character device interface

2020-12-30 Thread Jonathan Cameron
On Fri, 25 Dec 2020 19:15:37 -0500 William Breathitt Gray wrote: > This patch adds high-level documentation about the Counter subsystem > character device interface. > > Signed-off-by: William Breathitt Gray > --- > Documentation/ABI/testing/sysfs-bus-counter | 9 + >

Re: [PATCH v7 2/5] docs: counter: Update to reflect sysfs internalization

2020-12-30 Thread Jonathan Cameron
On Fri, 25 Dec 2020 19:15:35 -0500 William Breathitt Gray wrote: > The Counter subsystem architecture and driver implementations have > changed in order to handle Counter sysfs interactions in a more > consistent way. This patch updates the Generic Counter interface > documentation to reflect

[PATCH] riscv: mm: abort uaccess retries upon fatal signal

2020-12-30 Thread guoren
From: Guo Ren Pick up the patch from the 'Link' made by Mark Rutland. Keep the same with x86, arm, arm64, arc, sh, power. Link: https://lore.kernel.org/linux-arm-kernel/1499782763-31418-1-git-send-email-mark.rutl...@arm.com/ Signed-off-by: Guo Ren Cc: Mark Rutland Cc: Pekka Enberg Cc:

ERROR: modpost: ".idr_find" undefined!

2020-12-30 Thread kernel test robot
Hi Miao-chen, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 139711f033f636cc78b6aaf7363252241b9698ef commit: bd2fbc6cb815b5171facb42526f6db206d920e13 Bluetooth: Add handler of MGMT_OP_REMOVE_ADV_MONITOR date:

Re: [PATCH] nvme: hwmon: fix crash on device teardown

2020-12-30 Thread Daniel Wagner
On Fri, Dec 11, 2020 at 03:12:53PM +0100, Hannes Reinecke wrote: > So why do we have to deallocate the hwmon attributes? > And why on reset? And who's re-creating them after reset, seeing that > 'initialized' should be true? nvmet: adding nsid 1 to subsystem blktests-subsystem-1 nvmet: creating

Re: [PATCH v7 1/5] counter: Internalize sysfs interface code

2020-12-30 Thread Jonathan Cameron
On Fri, 25 Dec 2020 19:15:34 -0500 William Breathitt Gray wrote: > This is a reimplementation of the Generic Counter driver interface. > There are no modifications to the Counter subsystem userspace interface, > so existing userspace applications should continue to run seamlessly. Hi William

[PATCH v1] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2020-12-30 Thread wangyingjie55
From: Yingjie Wang In rvu_mbox_handler_cgx_mac_addr_get() and rvu_mbox_handler_cgx_mac_addr_set(), the msg is expected only from PFs that are mapped to CGX LMACs. It should be checked before mapping, so we add the is_cgx_config_permitted() in the functions. Signed-off-by: Yingjie Wang ---

[PATCH] smp: Fix the description for raw_smp_processor_id()

2020-12-30 Thread Qiujun Huang
s/raw_processor_id/raw_smp_processor_id/ Signed-off-by: Qiujun Huang --- include/linux/smp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/smp.h b/include/linux/smp.h index 70c6f6284dcf..081a9d98e1e3 100644 --- a/include/linux/smp.h +++ b/include/linux/smp.h

Re: [PATCH 1/2] mm: page_counter: relayout structure to reduce false sharing

2020-12-30 Thread Feng Tang
On Tue, Dec 29, 2020 at 08:56:42AM -0800, Roman Gushchin wrote: > On Tue, Dec 29, 2020 at 10:35:13PM +0800, Feng Tang wrote: > > When checking a memory cgroup related performance regression [1], > > from the perf c2c profiling data, we found high false sharing for > > accessing 'usage' and

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2020-12-30 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 30, 2020 at 02:28:52PM +0100, Jiri Olsa escreveu: > On Wed, Dec 30, 2020 at 02:28:02PM +0100, Jiri Olsa wrote: > > On Wed, Dec 30, 2020 at 10:03:37AM +0100, Jiri Olsa wrote: > > > On Tue, Dec 29, 2020 at 11:28:35PM +, Qais Yousef wrote: > > > > Hi Jiri > > > > > > > > On 12/29/20

Re: [PATCH AUTOSEL 5.10 01/31] ARM: 9014/2: Replace string mem* functions for KASan

2020-12-30 Thread Ahmad Fatoum
Hello Sasha, On 30.12.20 14:02, Sasha Levin wrote: > From: Linus Walleij > > [ Upstream commit d6d51a96c7d63b7450860a3037f2d62388286a52 ] > > Functions like memset()/memmove()/memcpy() do a lot of memory > accesses. > > If a bad pointer is passed to one of these functions it is important > to

[PATCH v2] trace: Remove get/put_cpu() from function_trace_init

2020-12-30 Thread Qiujun Huang
Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before tracer->init()"), get/put_cpu() are not needed anymore. We can use raw_smp_processor_id() instead. Signed-off-by: Qiujun Huang --- v2: Use raw_smp_processor_id() instead of smp_processor_id() ---

Re: [RFC] block: reject I/O in BLKRRPART if block size changed

2020-12-30 Thread Minwoo Im
On 20-12-27 03:02:32, Minwoo Im wrote: > Background: > Let's say we have 2 LBA format for 4096B and 512B LBA size for a > NVMe namespace. Assume that current LBA format is 4096B and in case > we convert namespace to 512B and 4096B back again: > > nvme format /dev/nvme0n1 --lbaf=1 --force #

Re: [PATCH v2 11/48] opp: Add dev_pm_opp_find_level_ceil()

2020-12-30 Thread Dmitry Osipenko
30.12.2020 07:46, Viresh Kumar пишет: > On 28-12-20, 17:03, Dmitry Osipenko wrote: >> 28.12.2020 09:22, Viresh Kumar пишет: >>> On 24-12-20, 16:00, Dmitry Osipenko wrote: In a device driver I want to set PD to the lowest performance state by removing the performance vote when

Re: [PATCH v3] tty: resolve loopback wait problem for aging serial port

2020-12-30 Thread Greg KH
On Wed, Dec 30, 2020 at 09:45:29PM +0800, zhangqiumi...@huawei.com wrote: > From: Qiumiao Zhang > > Because serial port is low-speed device, serial port writing will be suspended > when the buffer of driver layer is full due to serial port aging. What do you mean here exactly? What is "serial

Re: [PATCH 4.19 154/346] crypto: omap-aes - Fix PM disable depth imbalance in omap_aes_probe

2020-12-30 Thread Greg Kroah-Hartman
On Wed, Dec 30, 2020 at 02:16:35PM +0100, Pavel Machek wrote: > Hi! > > > From: Zhang Qilong > > > > [ Upstream commit ff8107200367f4abe0e5bce66a245e8d0f2d229e ] > > > > The pm_runtime_enable will increase power disable depth. > > Thus a pairing decrement is needed on the error handling > >

Re: [PATCH RESEND v2 1/2] dt-bindings: spi: Realtek RTL838x/RTL839x SPI controller

2020-12-30 Thread Mark Brown
On Wed, Dec 30, 2020 at 12:19:03AM +0100, Bert Vermeulen wrote: > +properties: > + compatible: > +const: realtek,spi It is possibled Realtek might make other SPI controllers, there should be some more specific name such as a compatible for each SoC that the controller appears in or an IP

Re: [PATCH] ibmvnic: fix: NULL pointer dereference.

2020-12-30 Thread Michal Suchánek
On Wed, Dec 30, 2020 at 03:23:14PM +0800, YANG LI wrote: > The error is due to dereference a null pointer in function > reset_one_sub_crq_queue(): > > if (!scrq) { > netdev_dbg(adapter->netdev, >"Invalid scrq reset. irq (%d) or msgs(%p).\n", > scrq->irq,

Re: [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time

2020-12-30 Thread Mark Brown
On Wed, Dec 30, 2020 at 10:24:20AM +0800, Xu Yilun wrote: > On Tue, Dec 29, 2020 at 01:13:08PM +, Mark Brown wrote: > > Does this still apply with current code? There have been some fixes in > > this area which I think should ensure that we don't turn the speed down > > to 0 if the

[BUG] checkpatch: non-standard types cannot be declared after '}'

2020-12-30 Thread Jan Schlien
Hi, I found some odd behavior of checkpatch.pl, which I'm currently using for own projects outside the kernel, but I verified that kernel patches can be affected as well. Reproducer code (file test.c): -->8-- void subfunc(void) { } FILE *g; int main(void) { return 0; }

Re: [PATCH v3 2/2] nvmem: core: skip nodes with compatibles other than "nvmem-cell"

2020-12-30 Thread Kamel Bouhara
Hi Ahmad, On 4/28/20 1:18 PM, Ahmad Fatoum wrote: The nvmem cell binding used to apply to all objects which match "^.*@[0-9a-f]+$", without taking a compatible into account, which precluded extension of EEPROMs by child nodes other than nvmem. A previous commit changed the binding, so that

Re: [RFC PATCH v2 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2020-12-30 Thread Jonathan Cameron
On Thu, 24 Dec 2020 03:19:21 + Jyoti Bhayana wrote: > This change provides ARM SCMI Protocol based IIO device. > This driver provides support for Accelerometer and Gyroscope using > new SCMI Sensor Protocol defined by the upcoming SCMIv3.0 > ARM specification > > Signed-off-by: Jyoti

Re: [PATCH] mm/page_alloc: remove the static for local variable node_order

2020-12-30 Thread Muchun Song
On Wed, Dec 30, 2020 at 8:45 PM Matthew Wilcox wrote: > > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > > local variable node_order do not need the static here. > > It bloody well does. It can be up to 2^10 entries on x86 (and larger > on others) That's 4kB which you've now moved

Re: [PATCH v3] regmap: debugfs: Fix a memory leak when calling regmap_attach_dev

2020-12-30 Thread Mark Brown
On Wed, Dec 30, 2020 at 10:14:22AM +, Wang, Xiaolei wrote: > Hi Markus > > Thank you very much, very good suggestion, do I need to re-send a patch to > fix this problem, or modify the previous patch and send it again? Please feel free to ignore Markus. signature.asc Description: PGP

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-30 Thread Mark Brown
On Tue, Dec 29, 2020 at 04:33:09PM +0100, Hans de Goede wrote: > On 12/29/20 4:08 PM, Mark Brown wrote: > > No, that's not the case. extcon is a port of an Android custom API that > > looks very similar to what ended up in mainline, it was also a > > combination of sysfs and uevents but a bit

Re: [PATCH] trace: Remove get/put_cpu() from function_trace_init

2020-12-30 Thread Qiujun Huang
Sorry, please ignore the patch [trace] 2158a32526: BUG:using_smp_processor_id()in_preemptible Thanks On Fri, Dec 25, 2020 at 10:24 PM Qiujun Huang wrote: > > Since commit b6f11df26fdc ("trace: Call tracing_reset_online_cpus before > tracer->init()"), get/put_cpu() are not needed anymore. > We

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2020-12-30 Thread Jiri Olsa
On Wed, Dec 30, 2020 at 02:28:02PM +0100, Jiri Olsa wrote: > On Wed, Dec 30, 2020 at 10:03:37AM +0100, Jiri Olsa wrote: > > On Tue, Dec 29, 2020 at 11:28:35PM +, Qais Yousef wrote: > > > Hi Jiri > > > > > > On 12/29/20 18:34, Jiri Olsa wrote: > > > > On Tue, Dec 29, 2020 at 03:13:52PM +,

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2020-12-30 Thread Jiri Olsa
On Wed, Dec 30, 2020 at 10:03:37AM +0100, Jiri Olsa wrote: > On Tue, Dec 29, 2020 at 11:28:35PM +, Qais Yousef wrote: > > Hi Jiri > > > > On 12/29/20 18:34, Jiri Olsa wrote: > > > On Tue, Dec 29, 2020 at 03:13:52PM +, Qais Yousef wrote: > > > > Hi > > > > > > > > When I enable

Re: [PATCH 1/3] thermal: ti-soc-thermal: Fix stuck sensor with continuous mode for 4430

2020-12-30 Thread H. Nikolaus Schaller
Hi Adam and Tony, > Am 30.12.2020 um 13:55 schrieb Adam Ford : > > On Wed, Dec 30, 2020 at 2:43 AM Tony Lindgren wrote: >> >> At least for 4430, trying to use the single conversion mode eventually >> hangs the thermal sensor. This can be quite easily seen with errors: >> >> thermal

Re: [PATCH] nvme: hwmon: fix crash on device teardown

2020-12-30 Thread Daniel Wagner
Hi Chaitanya, On Thu, Dec 10, 2020 at 04:35:14AM +, Chaitanya Kulkarni wrote: > Enzo, > On 12/9/20 13:39, Enzo Matsumiya wrote: > > Fix a possible NULL pointer dereference when trying to read > > hwmon sysfs entries associated to NVMe-oF devices that were > > hot-removed or disconnected. > >

Re: [PATCH] mm/page_alloc: remove the static for local variable node_order

2020-12-30 Thread Hui Su
Hi, Matthew: On Wed, Dec 30, 2020 at 12:42:33PM +, Matthew Wilcox wrote: > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > > local variable node_order do not need the static here. > > It bloody well does. It can be up to 2^10 entries on x86 (and larger > on others) That's 4kB

Re: [PATCH 4.19 154/346] crypto: omap-aes - Fix PM disable depth imbalance in omap_aes_probe

2020-12-30 Thread Pavel Machek
Hi! > From: Zhang Qilong > > [ Upstream commit ff8107200367f4abe0e5bce66a245e8d0f2d229e ] > > The pm_runtime_enable will increase power disable depth. > Thus a pairing decrement is needed on the error handling > path to keep it balanced according to context. Oops, this is complex. First,

Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona

2020-12-30 Thread Mark Brown
On Tue, Dec 29, 2020 at 04:51:57PM +, Richard Fitzgerald wrote: > On 29/12/2020 15:40, Hans de Goede wrote: > > I guess we should move it out of drivers/extcon then though. > > I suggest using: sound/soc/cirrus/arizona-jack-detect.c > > Note that sound/soc/cirrus is a new dir here. Would that

Re: [PATCH] regmap: irq: do not allow setting irq bits during ack

2020-12-30 Thread Mark Brown
On Tue, Dec 29, 2020 at 08:23:00AM -0800, Tim Harvey wrote: > On Tue, Dec 29, 2020 at 5:06 AM Mark Brown wrote: > > I can't understand what this commit message is trying to say, sorry. > > Which bits are you talking about when you say "if bits are set"? Isn't > > acknowleding the interrupt

[PATCH AUTOSEL 5.10 25/31] s390: always clear kernel stack backchain before calling functions

2020-12-30 Thread Sasha Levin
From: Heiko Carstens [ Upstream commit 9365965db0c7ca7fc81eee27c21d8522d7102c32 ] Clear the kernel stack backchain before potentially calling the lockdep trace_hardirqs_off/on functions. Without this walking the kernel backchain, e.g. during a panic, might stop too early. Signed-off-by: Heiko

[PATCH AUTOSEL 5.4 05/17] rtc: pl031: fix resource leak in pl031_probe

2020-12-30 Thread Sasha Levin
From: Zheng Liang [ Upstream commit 1eab0fea2514b269e384c117f5b5772b882761f0 ] When devm_rtc_allocate_device is failed in pl031_probe, it should release mem regions with device. Reported-by: Hulk Robot Signed-off-by: Zheng Liang Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij

[PATCH AUTOSEL 5.10 21/31] NFSv4.2: Don't error when exiting early on a READ_PLUS buffer overflow

2020-12-30 Thread Sasha Levin
From: Trond Myklebust [ Upstream commit 503b934a752f7e789a5f33217520e0a79f3096ac ] Expanding the READ_PLUS extents can cause the read buffer to overflow. If it does, then don't error, but just exit early. Signed-off-by: Trond Myklebust Signed-off-by: Sasha Levin --- fs/nfs/nfs42xdr.c | 36

[PATCH AUTOSEL 5.10 09/31] NFSv4: Fix a pNFS layout related use-after-free race when freeing the inode

2020-12-30 Thread Sasha Levin
From: Trond Myklebust [ Upstream commit b6d49ecd1081740b6e632366428b960461f8158b ] When returning the layout in nfs4_evict_inode(), we need to ensure that the layout is actually done being freed before we can proceed to free the inode itself. Signed-off-by: Trond Myklebust Signed-off-by:

[PATCH AUTOSEL 5.10 11/31] f2fs: avoid race condition for shrinker count

2020-12-30 Thread Sasha Levin
From: Jaegeuk Kim [ Upstream commit a95ba66ac1457b76fe472c8e092ab1006271f16c ] Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in wrong do_shinker work. Let's avoid to return insane overflowed value by adding single tracking value. Reported-by: Light Hsieh Reviewed-by:

[PATCH AUTOSEL 5.4 06/17] powerpc: sysdev: add missing iounmap() on error in mpic_msgr_probe()

2020-12-30 Thread Sasha Levin
From: Qinglang Miao [ Upstream commit ffa1797040c5da391859a9556be7b735acbe1242 ] I noticed that iounmap() of msgr_block_addr before return from mpic_msgr_probe() in the error handling case is missing. So use devm_ioremap() instead of just ioremap() when remapping the message register block, so

[PATCH AUTOSEL 5.10 19/31] um: ubd: Submit all data segments atomically

2020-12-30 Thread Sasha Levin
From: Gabriel Krisman Bertazi [ Upstream commit fc6b6a872dcd48c6f39c7975836d75113db67d37 ] Internally, UBD treats each physical IO segment as a separate command to be submitted in the execution pipe. If the pipe returns a transient error after a few segments have already been written, UBD will

[PATCH AUTOSEL 5.4 07/17] i3c master: fix missing destroy_workqueue() on error in i3c_master_register

2020-12-30 Thread Sasha Levin
From: Qinglang Miao [ Upstream commit 59165d16c699182b86b5c65181013f1fd88feb62 ] Add the missing destroy_workqueue() before return from i3c_master_register in the error handling case. Signed-off-by: Qinglang Miao Signed-off-by: Boris Brezillon Link:

[PATCH AUTOSEL 5.10 20/31] um: allocate a guard page to helper threads

2020-12-30 Thread Sasha Levin
From: Johannes Berg [ Upstream commit ef4459a6da0955b533ebfc97a7d756ac090f50c9 ] We've been running into stack overflows in helper threads corrupting memory (e.g. because somebody put printf() or os_info() there), so to avoid those causing hard-to-debug issues later on, allocate a guard page

<    1   2   3   4   5   >