Re: [PATCH] x86: Treat R_386_PLT32 as R_386_PC32

2021-01-06 Thread Nathan Chancellor
On Wed, Jan 06, 2021 at 04:17:39PM -0800, Fangrui Song wrote: > This is similar to commit b21ebf2fb4cde1618915a97cc773e287ff49173e "x86: > Treat R_X86_64_PLT32 as R_X86_64_PC32", but for i386. As far as Linux > kernel is concerned, R_386_PLT32 can be treated the same as R_386_PC32. > >

Re: [PATCH] Input: cros_ec_keyb: Add support for a front proximity switch

2021-01-06 Thread Dmitry Torokhov
Hi Doug, Stephen, On Wed, Jan 06, 2021 at 05:16:10PM -0800, Doug Anderson wrote: > Hi, > > On Fri, Dec 4, 2020 at 4:48 PM Stephen Boyd wrote: > > > > Some cros ECs support a front proximity MKBP event via > > 'EC_MKBP_FRONT_PROXIMITY'. Map this to the 'SW_FRONT_PROXIMITY' input > > event code

[PATCH] net/bluetooth: WARNING: adv_channel_map_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE

2021-01-06 Thread Jiapeng Zhong
adv_channel_map_fops is used in the debug file, we use DEFINE_DEBUGFS_ATTRIBUTE replaces DEFINE_SIMPLE_ATTRIBUTE, more clear and intuitive. Signed-off-by: Jiapeng Zhong Reported-by: Abaci --- net/bluetooth/hci_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v3 0/9] Add support for Microsoft Surface System Aggregator Module

2021-01-06 Thread Maximilian Luz
On 1/7/21 12:40 AM, Hans de Goede wrote: Hi, On 12/21/20 7:39 PM, Maximilian Luz wrote: Hello, Here is version three of the Surface System Aggregator Module (SAM/SSAM) driver series, adding initial support for the embedded controller on 5th and later generation Microsoft Surface devices.

Re: [PATCH] ARC: unbork 5.11 bootup: fix snafu in _TIF_NOTIFY_SIGNAL handling

2021-01-06 Thread Jens Axboe
On 1/6/21 5:12 PM, Vineet Gupta wrote: > Linux 5.11.rcX was failing to boot on ARC HSDK board. Turns out we have > a couple of issues, this being the first one, and I'm to blame as I > didn't pay attention during review. > > TIF_NOTIFY_SIGNAL support requires checking multiple TIF_* bits in >

Re: [BUG] from x86: Support kmap_local() forced debugging

2021-01-06 Thread Willem de Bruijn
On Wed, Jan 6, 2021 at 8:49 PM Jakub Kicinski wrote: > > On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote: > > I wonder whether there is other code that "knows" about kmap() only > > affecting PageHighmem() pages thing that is no longer true. > > > > Looking at some other code,

Re: [PATCH v13 2/4] fs: add LSM-supporting anon-inode interface

2021-01-06 Thread Paul Moore
On Wed, Nov 11, 2020 at 8:54 PM Lokesh Gidra wrote: > From: Daniel Colascione > > This change adds a new function, anon_inode_getfd_secure, that creates > anonymous-node file with individual non-S_PRIVATE inode to which security > modules can apply policy. Existing callers continue using the

RE: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Tian, Kevin
> From: Leon Romanovsky > Sent: Thursday, January 7, 2021 12:02 AM > > On Wed, Jan 06, 2021 at 11:23:39AM -0400, Jason Gunthorpe wrote: > > On Wed, Jan 06, 2021 at 12:40:17PM +0200, Leon Romanovsky wrote: > > > > > I asked what will you do when QEMU will gain needed functionality? > > > Will you

Re: [RFC PATCH v2 1/1] platform-msi: Add platform check for subdevice irq domain

2021-01-06 Thread Lu Baolu
On 1/7/21 12:01 AM, Leon Romanovsky wrote: On Wed, Jan 06, 2021 at 11:23:39AM -0400, Jason Gunthorpe wrote: On Wed, Jan 06, 2021 at 12:40:17PM +0200, Leon Romanovsky wrote: I asked what will you do when QEMU will gain needed functionality? Will you remove QEMU from this list? If yes, how such

Re: [PATCH v2 1/3] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-06 Thread Andrew Lunn
> + /* hwmon interface needs to access 16bit registers in atomic way to > + * guarantee coherency of the diagnostic monitoring data. If it is not > + * possible to guarantee coherency because EEPROM is broken in such way > + * that does not support atomic 16bit read operation

[PATCH 1/1] sched/fair:Avoid unnecessary assignment to cfs_rq->on_list

2021-01-06 Thread qianjun . kernel
From: jun qian Obviously, cfs_rq->on_list is already equal to 1 when cfs_rq->on_list is assigned a value of 1, so an else branch is needed to avoid unnecessary assignment operations. Signed-off-by: jun qian --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH 0/6] hugetlbfs: support free page reporting

2021-01-06 Thread Liang Li
On Wed, Jan 6, 2021 at 5:41 PM David Hildenbrand wrote: > > On 06.01.21 04:46, Liang Li wrote: > > A typical usage of hugetlbfs it's to reserve amount of memory > > during the kernel booting stage, and the reserved pages are > > unlikely to return to the buddy system. When application need > >

Re: [BUG] from x86: Support kmap_local() forced debugging

2021-01-06 Thread Jakub Kicinski
On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote: > I wonder whether there is other code that "knows" about kmap() only > affecting PageHighmem() pages thing that is no longer true. > > Looking at some other code, skb_gro_reset_offset() looks suspiciously > like it also thinks highmem pages

Re: [BUG] from x86: Support kmap_local() forced debugging

2021-01-06 Thread Steven Rostedt
On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote: > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -366,7 +366,7 @@ static inline void skb_frag_size_sub(skb_frag_t *frag, > int delta) > static inline bool skb_frag_must_loop(struct page *p) > { > #if

[PATCH v3] Drivers: hv: vmbus: Add /sys/bus/vmbus/hibernation

2021-01-06 Thread Dexuan Cui
When a Linux VM runs on Hyper-V, if the host toolstack doesn't support hibernation for the VM (this happens on old Hyper-V hosts like Windows Server 2016, or new Hyper-V hosts if the admin or user doesn't declare the hibernation intent for the VM), the VM is discouraged from trying hibernation

Re: [PATCH v2 1/9] KVM: x86: Add AMD SEV specific Hypercall3

2021-01-06 Thread Ashish Kalra
Hello Steve, My thoughts here ... On Wed, Jan 06, 2021 at 05:01:33PM -0800, Steve Rutherford wrote: > Avoiding an rbtree for such a small (but unstable) list seems correct. > I agree. > For the unencrypted region list strategy, the only questions that I > have are fairly secondary. > - How

Re: [PATCH] x86: Treat R_386_PLT32 as R_386_PC32

2021-01-06 Thread Nick Desaulniers
On Wed, Jan 6, 2021 at 4:17 PM Fangrui Song wrote: > > This is similar to commit b21ebf2fb4cde1618915a97cc773e287ff49173e "x86: > Treat R_X86_64_PLT32 as R_X86_64_PC32", but for i386. As far as Linux nit: the format for referring to in tree sha's: commit b21ebf2fb4cd ("x86: Treat

arch/mips/bmips/dma.c:43:12: warning: no previous prototype for function 'phys_to_dma'

2021-01-06 Thread kernel test robot
Hi Christoph, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 commit: 5ceda74093a5c1c3f42a02b894df031f3bbc9af1 dma-direct: rename and cleanup __phys_to_dma date: 4 months

Re: [PATCH v2 6/6] iommu: Delete iommu_dev_has_feature()

2021-01-06 Thread Lu Baolu
On 1/6/21 9:35 PM, John Garry wrote: Function iommu_dev_has_feature() has never been referenced in the tree, and there does not appear to be anything coming soon to use it, so delete it. It will be used by the device driver which want to support the aux- domain capability, for example, below

Re: [PATCH] of: property: Add device link support for interrupts

2021-01-06 Thread Saravana Kannan
On Wed, Jan 6, 2021 at 10:52 AM Saravana Kannan wrote: > > On Sat, Jan 2, 2021 at 3:37 AM Marc Zyngier wrote: > > > > On Thu, 31 Dec 2020 21:12:40 +, > > Rob Herring wrote: > > > > > > On Mon, Dec 21, 2020 at 09:30:45AM +, Marc Zyngier wrote: > > > > On 2020-12-18 21:07, Saravana Kannan

RE: [PATCH -next] scsi: ufs: fix all Kconfig help text indentation

2021-01-06 Thread Alim Akhtar
Hello Randy, > -Original Message- > From: Randy Dunlap > Sent: 07 January 2021 02:26 > To: linux-kernel@vger.kernel.org > Cc: Randy Dunlap ; Alim Akhtar > ; Avri Altman ; linux- > s...@vger.kernel.org; James E.J. Bottomley ; Martin K. > Petersen > Subject: [PATCH -next] scsi: ufs: fix

Re: [PATCH 00/10] Remove support for TX49xx

2021-01-06 Thread Atsushi Nemoto
On Wed, 6 Jan 2021 21:41:24 +0100, Geert Uytterhoeven wrote: >> > Is that sufficient to keep it? >> >> for me it is. But now we probaly need some reverts then... > > Indeed. Fortunately not all of it, as some removals were TX4938-only. These patches should not break RBTX4927: net: tc35815:

Re: [PATCH RFC net-next] net: hns3: debugfs add dump tm info of nodes, priority and qset

2021-01-06 Thread huangguangbin (A)
ping On 2020/12/31 17:03, Guangbin Huang wrote: To increase methods to dump more tm info, adds three debugfs commands to dump tm info of nodes, priority and qset. And a new tm file of debugfs is created for only dumping tm info. Unlike previous debugfs commands, to dump each tm information,

Re: [BUG] from x86: Support kmap_local() forced debugging

2021-01-06 Thread Steven Rostedt
On Wed, 6 Jan 2021 17:03:48 -0800 Linus Torvalds wrote: > (although I wonder how/why the heck you've enabled > CC_OPTIMIZE_FOR_SIZE=y, which is what causes "memcpy()" to be done as > that "rep movsb". I thought we disabled it because it's so bad on most > cpus). Why? Because to test x86_32, I

Re: [PATCH] Input: cros_ec_keyb: Add support for a front proximity switch

2021-01-06 Thread Doug Anderson
Hi, On Fri, Dec 4, 2020 at 4:48 PM Stephen Boyd wrote: > > Some cros ECs support a front proximity MKBP event via > 'EC_MKBP_FRONT_PROXIMITY'. Map this to the 'SW_FRONT_PROXIMITY' input > event code so it can be reported up to userspace. > > Cc: Dmitry Torokhov > Cc: Benson Leung > Cc: Guenter

Re: [BUG] from x86: Support kmap_local() forced debugging

2021-01-06 Thread Linus Torvalds
On Wed, Jan 6, 2021 at 3:01 PM Steven Rostedt wrote: > > I triggered the following crash on x86_32 by simply doing a: > > (ssh'ing into the box) > > # head -100 /tmp/output-file > > Where the /tmp/output-file was the output of a trace-cmd report. > Even after rebooting and not running the

Re: [PATCH v2 1/9] KVM: x86: Add AMD SEV specific Hypercall3

2021-01-06 Thread Steve Rutherford
Avoiding an rbtree for such a small (but unstable) list seems correct. For the unencrypted region list strategy, the only questions that I have are fairly secondary. - How should the kernel upper bound the size of the list in the face of malicious guests, but still support large guests?

[PATCH net v2] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-06 Thread Dongseok Yi
skbs in fraglist could be shared by a BPF filter loaded at TC. It triggers skb_ensure_writable -> pskb_expand_head -> skb_clone_fraglist -> skb_get on each skb in the fraglist. While tcpdump, sk_receive_queue of PF_PACKET has the original fraglist. But the same fraglist is queued to PF_INET (or

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Thu, Jan 07, 2021 at 12:26:19AM +, Luck, Tony wrote: > > Please see below for an updated patch. > > Yes. That worked: > > [ 78.946069] mce: mce_timed_out: MCE holdout CPUs (may include false > positives): 24-47,120-143 > [ 78.946151] mce: mce_timed_out: MCE holdout CPUs (may include

Re: linux-next: build warning after merge of the vfs tree

2021-01-06 Thread Al Viro
On Thu, Jan 07, 2021 at 10:15:44AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from fs/erofs/xattr.h:10, > from fs/erofs/namei.c:7: > fs/erofs/namei.c: In

Re: linux-next: build warning after merge of the vfs tree

2021-01-06 Thread Gao Xiang
Hi Al, On Thu, Jan 07, 2021 at 10:15:44AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from fs/erofs/xattr.h:10, > from fs/erofs/namei.c:7: >

Re: [PATCH v3 0/4] gpio: visconti: Add Toshiba Visconti GPIO support

2021-01-06 Thread Nobuhiro Iwamatsu
Hi Bartosz, On Wed, Jan 06, 2021 at 11:33:49AM +0100, Bartosz Golaszewski wrote: > On Tue, Dec 1, 2020 at 10:16 AM Nobuhiro Iwamatsu > wrote: > > > > Hi, > > > > This series is the GPIO driver for Toshiba's ARM SoC, Visconti[0]. > > This provides DT binding documentation, device driver,

Re: [PATCH net-next] net: sysctl: cleanup net_sysctl_init()

2021-01-06 Thread Jakub Kicinski
On Wed, 06 Jan 2021 20:40:28 + Alexander Lobakin wrote: > 'net_header' is not used outside of this function, so can be moved > from BSS onto the stack. > Declarations of one-element arrays are discouraged, and there's no > need to store 'empty' in BSS. Simply allocate it from heap at init.

Re: [PATCH 4/4] x86: don't build CONFIG_X86_32 as -ffreestanding

2021-01-06 Thread Fangrui Song
On 2020-08-17, Nick Desaulniers wrote: -ffreestanding typically inhibits "libcall optimizations" where calls to certain library functions can be replaced by the compiler in certain cases to calls to other library functions that may be more efficient. This can be problematic for embedded targets

RE: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Luck, Tony
> Please see below for an updated patch. Yes. That worked: [ 78.946069] mce: mce_timed_out: MCE holdout CPUs (may include false positives): 24-47,120-143 [ 78.946151] mce: mce_timed_out: MCE holdout CPUs (may include false positives): 24-47,120-143 [ 78.946153] Kernel panic - not

Re: [PATCH] arch: x86: platform: retire arch/x86/platform/goldfish

2021-01-06 Thread Roman Kiryanov
+Thoman, +Ingo, +Borislav On Mon, Dec 14, 2020 at 1:20 PM Roman Kiryanov wrote: > > On Mon, Nov 16, 2020 at 6:55 PM wrote: > > > > From: Roman Kiryanov > > > > The Android Studio Emulator (aka goldfish) does not > > use arch/x86/platform/goldfish since 5.4 kernel. > > > > Signed-off-by: Roman

Re: [PATCH] net: dsa: fix led_classdev build errors

2021-01-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 5 Jan 2021 18:18:15 -0800 you wrote: > Fix build errors when LEDS_CLASS=m and NET_DSA_HIRSCHMANN_HELLCREEK=y. > This limits the latter to =m when LEDS_CLASS=m. > > microblaze-linux-ld:

Re: [PATCH] ptp: ptp_ines: prevent build when HAS_IOMEM is not set

2021-01-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 5 Jan 2021 20:25:31 -0800 you wrote: > ptp_ines.c uses devm_platform_ioremap_resource(), which is only > built/available when CONFIG_HAS_IOMEM is enabled. > CONFIG_HAS_IOMEM is not enabled for arch/s390/, so builds on

[PATCH v3 2/2] KVM: x86/mmu: Clarify TDP MMU page list invariants

2021-01-06 Thread Ben Gardon
The tdp_mmu_roots and tdp_mmu_pages in struct kvm_arch should only contain pages with tdp_mmu_page set to true. tdp_mmu_pages should not contain any pages with a non-zero root_count and tdp_mmu_roots should only contain pages with a positive root_count, unless a thread holds the MMU lock and is in

[PATCH v3 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Ben Gardon
Many TDP MMU functions which need to perform some action on all TDP MMU roots hold a reference on that root so that they can safely drop the MMU lock in order to yield to other threads. However, when releasing the reference on the root, there is a bug: the root will not be freed even if its

Re: [PATCH v4 2/9] arm64: perf: Enable pmu counter direct access for perf event on armv8

2021-01-06 Thread Rob Herring
On Wed, Dec 02, 2020 at 07:57:47AM -0700, Rob Herring wrote: > On Fri, Nov 20, 2020 at 02:03:45PM -0600, Rob Herring wrote: > > On Thu, Nov 19, 2020 at 07:15:15PM +, Will Deacon wrote: > > > On Fri, Nov 13, 2020 at 06:06:33PM +, Mark Rutland wrote: > > > > On Thu, Oct 01, 2020 at

arch/mips/bmips/dma.c:55:13: warning: no previous prototype for function 'dma_to_phys'

2021-01-06 Thread kernel test robot
Hi Christoph, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 commit: 7bc5c428a660d4d1bc95ba54bf4cb6bccf8c3029 dma-direct: remove __dma_to_phys date: 4 months ago config:

Re: [v3 PATCH 08/11] mm: vmscan: use per memcg nr_deferred of shrinker

2021-01-06 Thread Roman Gushchin
On Tue, Jan 05, 2021 at 02:58:14PM -0800, Yang Shi wrote: > Use per memcg's nr_deferred for memcg aware shrinkers. The shrinker's > nr_deferred > will be used in the following cases: > 1. Non memcg aware shrinkers > 2. !CONFIG_MEMCG It's better to depend on CONFIG_MEMCG_KMEM rather than

[PATCH] x86: Treat R_386_PLT32 as R_386_PC32

2021-01-06 Thread Fangrui Song
This is similar to commit b21ebf2fb4cde1618915a97cc773e287ff49173e "x86: Treat R_X86_64_PLT32 as R_X86_64_PC32", but for i386. As far as Linux kernel is concerned, R_386_PLT32 can be treated the same as R_386_PC32. R_386_PC32/R_X86_64_PC32 are PC-relative relocation types with the requirement

Re: [v3 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code

2021-01-06 Thread Roman Gushchin
On Tue, Jan 05, 2021 at 02:58:08PM -0800, Yang Shi wrote: > The shrinker map management is not really memcg specific, it's just allocation In the current form it doesn't look so, especially because each name has a memcg_ prefix and each function takes a memcg argument. It begs for some

[PATCH] ARC: unbork 5.11 bootup: fix snafu in _TIF_NOTIFY_SIGNAL handling

2021-01-06 Thread Vineet Gupta
Linux 5.11.rcX was failing to boot on ARC HSDK board. Turns out we have a couple of issues, this being the first one, and I'm to blame as I didn't pay attention during review. TIF_NOTIFY_SIGNAL support requires checking multiple TIF_* bits in kernel return code path. Old code only needed to check

Re: [PATCH] mm/uaccess: Use 'unsigned long' to placate UBSAN warnings, again

2021-01-06 Thread Randy Dunlap
On 1/6/21 3:37 PM, Kees Cook wrote: > On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote: >> On Tue, Dec 22, 2020 at 11:04:54PM -0600, Josh Poimboeuf wrote: >>> GCC 7 has a known bug where UBSAN ignores '-fwrapv' and generates false >>> signed-overflow-UB warnings. The type mismatch

Re: [PATCH v2 0/5] Introduce PRU remoteproc consumer API

2021-01-06 Thread Suman Anna
Hi Mathieu, On 1/6/21 5:27 PM, Mathieu Poirier wrote: > On Wed, Dec 16, 2020 at 05:52:34PM +0100, Grzegorz Jaszczyk wrote: >> Hi All, >> >> The Programmable Real-Time Unit and Industrial Communication Subsystem >> (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit >> RISC cores

RE: [PATCH 2/3] hv_netvsc: Wait for completion on request NVSP_MSG4_TYPE_SWITCH_DATA_PATH

2021-01-06 Thread Long Li
; wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000s > data=uge6PX2NyAe%2BjRtvgOhR5xzN2ltBctZXeZwn0hoYco0%3Dreser > ved=0 > git fetch --no-tags linux-review Long-Li/hv_netvsc-Check-VF-datapath- > when-sending-traffic-to-VF/20210106-092237 > git checkout 8

Re: [RFC PATCH kernel] block: initialize block_device::bd_bdi for bdev_cache

2021-01-06 Thread Alexey Kardashevskiy
On 06/01/2021 21:41, Jan Kara wrote: On Wed 06-01-21 20:29:00, Alexey Kardashevskiy wrote: This is a workaround to fix a null derefence crash: [cb01f840] cb01f880 (unreliable) [cb01f880] c0769a3c bdev_evict_inode+0x21c/0x370 [cb01f8c0]

Re: [PATCH 5.10 00/40] 5.10.3-rc1 review

2021-01-06 Thread Jeffrin Jose T
On Wed, 2021-01-06 at 20:49 +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 07, 2021 at 01:08:01AM +0530, Jeffrin Jose T wrote: > > On Mon, 2021-01-04 at 07:21 +0100, Greg Kroah-Hartman wrote: > > > On Sun, Jan 03, 2021 at 06:37:51PM +0530, Jeffrin Jose T wrote: > > > > On Mon, 2020-12-28 at 12:41

Re: [PATCH 5/6] KVM: nSVM: always leave the nested state first on KVM_SET_NESTED_STATE

2021-01-06 Thread Maxim Levitsky
On Wed, 2021-01-06 at 09:39 -0800, Sean Christopherson wrote: > On Wed, Jan 06, 2021, Maxim Levitsky wrote: > > This should prevent bad things from happening if the user calls the > > KVM_SET_NESTED_STATE twice. > > This doesn't exactly inspire confidence, nor does it provide much help to >

Re: [PATCH] mm: vmscan: support complete shrinker reclaim

2021-01-06 Thread Andrew Morton
(cc's added) On Tue, 5 Jan 2021 16:43:38 -0800 Sudarshan Rajagopalan wrote: > Ensure that shrinkers are given the option to completely drop > their caches even when their caches are smaller than the batch size. > This change helps improve memory headroom by ensuring that under > significant

Re: [PATCH 4/6] KVM: nSVM: correctly restore nested_run_pending on migration

2021-01-06 Thread Maxim Levitsky
On Wed, 2021-01-06 at 09:27 -0800, Sean Christopherson wrote: > On Wed, Jan 06, 2021, Maxim Levitsky wrote: > > The code to store it on the migration exists, but no code was restoring it. > > > > Signed-off-by: Maxim Levitsky > > --- > > arch/x86/kvm/svm/nested.c | 4 > > 1 file changed, 4

Re: [PATCH v8 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings

2021-01-06 Thread Rob Herring
On Wed, Jan 6, 2021 at 2:25 AM EastL wrote: > > On Sun, 2021-01-03 at 09:58 -0700, Rob Herring wrote: > > On Wed, Dec 23, 2020 at 05:30:44PM +0800, EastL Lee wrote: > > > Document the devicetree bindings for MediaTek Command-Queue DMA controller > > > which could be found on MT6779 SoC or other

drivers/watchdog/m54xx_wdt.c:104:37: sparse: sparse: incorrect type in argument 1 (different address spaces)

2021-01-06 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 commit: e5fc436f06eef54ef512ea55a9db8eb9f2e76959 sparse: use static inline for __chk_{user,io}_ptr() date: 4 months ago config: m68k-randconfig-s032-20210107

Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

2021-01-06 Thread Kees Cook
subject typo: "sysclt" -> "sysctl" On Thu, Dec 24, 2020 at 03:42:56PM +0800, Xiaoming Ni wrote: > The process_sysctl_arg() does not check whether val is empty before > invoking strlen(val). If the command line parameter () is incorrectly > configured and val is empty, oops is triggered. > >

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-01-06 Thread Hans de Goede
Hi Perry, On 12/28/20 2:28 PM, Perry Yuan wrote: > From: Perry Yuan > > add support for dell privacy driver for the dell units equipped > hardware privacy design, which protect users privacy > of audio and camera from hardware level. once the audio or camera > privacy mode enabled, any

Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity

2021-01-06 Thread Andrii Nakryiko
On Wed, Jan 6, 2021 at 3:27 AM Qais Yousef wrote: > > On 01/05/21 08:44, Alexei Starovoitov wrote: > > > Any pointer to an example test I could base this on? > > > > selftests/bpf/ > > I was hoping for something more elaborate. I thought there's something already > there that do some verification

Re: [PATCH v3 0/9] Add support for Microsoft Surface System Aggregator Module

2021-01-06 Thread Hans de Goede
Hi, On 12/21/20 7:39 PM, Maximilian Luz wrote: > Hello, > > Here is version three of the Surface System Aggregator Module (SAM/SSAM) > driver series, adding initial support for the embedded controller on 5th > and later generation Microsoft Surface devices. Initial support includes > the ACPI

Re: [PATCH v4 sl-b 0/6] Export return addresses etc. for better diagnostics

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 01:48:43PM -0800, Andrew Morton wrote: > On Tue, 5 Jan 2021 17:16:03 -0800 "Paul E. McKenney" > wrote: > > > This is v4 of the series the improves diagnostics by providing access > > to additional information including the return addresses, slab names, > > offsets, and

Re: [PATCH 3/3] soc: qcom: mdt_loader: Read hash from firmware blob

2021-01-06 Thread kernel test robot
Hi Siddharth, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc2 next-20210104] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-06 Thread Arnd Bergmann
On Thu, Jan 7, 2021 at 12:17 AM Kees Cook wrote: > > On Wed, Jan 06, 2021 at 11:12:18PM +0100, Arnd Bergmann wrote: > > On Wed, Jan 6, 2021 at 10:57 PM Kees Cook wrote: > > > On Wed, Dec 30, 2020 at 04:47:35PM +0100, Arnd Bergmann wrote: > > > > diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan

Re: [PATCH] mm/uaccess: Use 'unsigned long' to placate UBSAN warnings, again

2021-01-06 Thread Kees Cook
On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote: > On Tue, Dec 22, 2020 at 11:04:54PM -0600, Josh Poimboeuf wrote: > > GCC 7 has a known bug where UBSAN ignores '-fwrapv' and generates false > > signed-overflow-UB warnings. The type mismatch between 'i' and > > 'nr_segs' in

Re: [PATCH] sysctl: use min() helper for namecmp()

2021-01-06 Thread Kees Cook
On Mon, Jan 04, 2021 at 05:32:21PM +0900, Masahiro Yamada wrote: > Make it slightly readable by using min(). > > Signed-off-by: Masahiro Yamada Acked-by: Kees Cook -- Kees Cook

ARC no console output (was Re: [PATCH 1/2] init/console: Use ttynull as a fallback when there is no console)

2021-01-06 Thread Vineet Gupta
+CC Buildroot folks Hi Petr, On 11/11/20 5:54 AM, Petr Mladek wrote: stdin, stdout, and stderr standard I/O stream are created for the init process. They are not available when there is no console registered for /dev/console. It might lead to a crash when the init process tries to use them,

Re: [PATCH v2 16/17] driver core: Refactor fw_devlink feature

2021-01-06 Thread Saravana Kannan
On Tue, Jan 5, 2021 at 1:04 PM Michael Walle wrote: > > Am 2021-01-05 20:00, schrieb Saravana Kannan: > > On Mon, Dec 28, 2020 at 7:35 PM Michael Walle wrote: > >> > >> > The current implementation of fw_devlink is very inefficient because it > >> > tries to get away without creating fwnode

Re: [PATCH bpf] bpftool: fix compilation failure for net.o with older glibc

2021-01-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 6 Jan 2021 15:59:06 + you wrote: > For older glibc ~2.17, #include'ing both linux/if.h and net/if.h > fails due to complaints about redefinition of interface flags: > > CC net.o > In file included from

[PATCH] arm64: dts: qcom: sc7180: Add "dp_hot_plug_det" pinconf for trogdor

2021-01-06 Thread Douglas Anderson
We have an external pull on this line, so disable the internal pull. Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi

Re: [PATCH v2 0/5] Introduce PRU remoteproc consumer API

2021-01-06 Thread Mathieu Poirier
On Wed, Dec 16, 2020 at 05:52:34PM +0100, Grzegorz Jaszczyk wrote: > Hi All, > > The Programmable Real-Time Unit and Industrial Communication Subsystem > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > RISC cores (Programmable Real-Time Units, or PRUs) for program

[PATCH v1] driver core: Fix device link device name collision

2021-01-06 Thread Saravana Kannan
The device link device's name was of the form: -- This can cause name collision as reported here [1] as device names are not globally unique. Since device names have to be unique within the bus/class, add the bus/class name as a prefix to the device names used to construct the device link device

Re: [PATCH v2 mips-next 2/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-06 Thread Kees Cook
On Wed, Jan 06, 2021 at 10:36:38PM +, Alexander Lobakin wrote: > From: Kees Cook > Date: Wed, 6 Jan 2021 14:07:07 -0800 > > > On Wed, Jan 06, 2021 at 08:08:19PM +, Alexander Lobakin wrote: > >> Discard GNU attributes at link time as kernel doesn't use it at all. > >> Solves a dozen of

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 02:49:18PM -0800, Luck, Tony wrote: > On Wed, Jan 06, 2021 at 11:17:08AM -0800, Paul E. McKenney wrote: > > On Wed, Jan 06, 2021 at 06:39:30PM +, Luck, Tony wrote: > > > > The "Timeout: Not all CPUs entered broadcast exception handler" message > > > > will appear from

[PATCH v3] x86/Hyper-V: Support for free page reporting

2021-01-06 Thread Sunil Muthuswamy
Linux has support for free page reporting now (36e66c554b5c) for virtualized environment. On Hyper-V when virtually backed VMs are configured, Hyper-V will advertise cold memory discard capability, when supported. This patch adds the support to hook into the free page reporting infrastructure and

Re: linux-next: build warning after merge of the origin tree

2021-01-06 Thread Stephen Rothwell
Hi Johannes, On Wed, 06 Jan 2021 23:46:45 +0100 Johannes Berg wrote: > > > > Right, thanks. I believe I also fixed it in the patch I sent a few days > > > ago that fixed the other documentation warning related to SAR that you > > > reported. > > > > I don't think so :-( I did a htmldocs

Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

2021-01-06 Thread Jakub Kicinski
On Tue, 5 Jan 2021 22:49:17 -0800 wangyingji...@126.com wrote: > From: Yingjie Wang > > In rvu_mbox_handler_cgx_mac_addr_get() > and rvu_mbox_handler_cgx_mac_addr_set(), > the msg is expected only from PFs that are mapped to CGX LMACs. > It should be checked before mapping, > so we add the

[PATCH v2 5/5] soc / drm: mediatek: Move mtk mutex driver to soc folder

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu mtk mutex is used by DRM and MDP driver, and its function is SoC-specific, so move it to soc folder. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 3 +-- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-

[PATCH v2 4/5] drm/mediatek: Automatically search unclaimed mtk mutex in mtk_mutex_get()

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu Moving mutex resource management from client driver to mutex driver could prevent client drivers negotiating for resource management. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_mutex.c|

[PATCH v2 2/5] drm/mediatek: Rename file mtk_drm_ddp to mtk_mutex

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu After mmsys routing function is moved out of mtk_drm_ddp.c, mtk_drm_ddp.c has only mtk mutex function, so rename it to match the function in it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/Makefile | 4 ++--

[PATCH v2 3/5] drm/mediatek: Change disp/ddp term to mutex in mtk mutex driver

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu mtk mutex is used by both drm and mdp driver, so change disp/ddp term to mutex to show that it's a common driver for drm and mdp. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 30 +-- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2

[PATCH v2 1/5] drm/mediatek: Remove redundant file including

2021-01-06 Thread Chun-Kuang Hu
From: CK Hu Those file includings are useless, so remove them. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 2 -- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 -- 2 files changed, 4 deletions(-) diff --git

[PATCH v2 0/5] Share mtk mutex driver for both DRM and MDP

2021-01-06 Thread Chun-Kuang Hu
mtk mutex is a driver used by DRM and MDP [1], so this series move mtk mutex driver from DRM folder to soc folder, so it could be used by DRM and MDP. Changes in v2: 1. Rebase onto mediatek-drm-next [2]. 2. Export symbol for mtk-mutex API. [1] https://patchwork.kernel.org/patch/11140751/ [2]

Re: [PATCH] ubsan: disable unsigned-integer-overflow sanitizer with clang

2021-01-06 Thread Kees Cook
On Wed, Jan 06, 2021 at 11:12:18PM +0100, Arnd Bergmann wrote: > On Wed, Jan 6, 2021 at 10:57 PM Kees Cook wrote: > > On Wed, Dec 30, 2020 at 04:47:35PM +0100, Arnd Bergmann wrote: > > > diff --git a/lib/Kconfig.ubsan b/lib/Kconfig.ubsan > > > index 8b635fd75fe4..e23873282ba7 100644 > > > ---

linux-next: build warning after merge of the vfs tree

2021-01-06 Thread Stephen Rothwell
Hi all, After merging the vfs tree, today's linux-next build (x86_64 allmodconfig) produced this warning: In file included from fs/erofs/xattr.h:10, from fs/erofs/namei.c:7: fs/erofs/namei.c: In function 'erofs_lookup': fs/erofs/internal.h:23:21: warning: format '%s' expects

Re: commit ("1e860048c53ee gcc-plugins: simplify GCC plugin-dev capability test")

2021-01-06 Thread Kees Cook
On Wed, Jan 06, 2021 at 08:44:58AM -0600, Dinh Nguyen wrote: > Hi Masahiro, > > With v5.11-rc1 and commit("1e860048c53ee gcc-plugins: simplify GCC > plugin-dev capability test"), I get this error for my arm socfpga_defconfig > build. I have been building the kernel the same way for many years

Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver

2021-01-06 Thread Bjorn Helgaas
On Wed, Jan 06, 2021 at 02:57:19PM -0500, Jim Quinlan wrote: > On Wed, Jan 6, 2021 at 2:42 PM Jim Quinlan wrote: > > > > -- Forwarded message - > > From: Bjorn Helgaas > > Date: Wed, Jan 6, 2021 at 2:19 PM > > Subject: Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC

Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...

2021-01-06 Thread Kees Cook
On Sat, 26 Dec 2020 13:21:58 -0500, Valdis Klētnieks wrote: > Fedora Rawhide has started including gcc 11,and the g++ compiler > throws a wobbly when it hits scripts/gcc-plugins: > > HOSTCXX scripts/gcc-plugins/latent_entropy_plugin.so > In file included from /usr/include/c++/11/type_traits:35,

Re: [PATCH v2 1/9] KVM: x86: Add AMD SEV specific Hypercall3

2021-01-06 Thread Ashish Kalra
On Fri, Dec 18, 2020 at 07:56:41PM +, Dr. David Alan Gilbert wrote: > * Kalra, Ashish (ashish.ka...@amd.com) wrote: > > Hello Dave, > > > > On Dec 18, 2020, at 1:40 PM, Dr. David Alan Gilbert > > wrote: > > > > * Ashish Kalra (ashish.ka...@amd.com) wrote: > > On Fri, Dec 11, 2020 at

RE: [EXTERNAL] Re: [PATCH v2] x86/Hyper-V: Support for free page reporting

2021-01-06 Thread Sunil Muthuswamy
> > +// Bit mask of the extended capability to query: see HV_EXT_CAPABILITY_xxx > > Please don't use '//' comments in Linux (here and below) Will fix in v3. > > + /* > > +* Repurpose the input page arg to accept output from Hyper-V for > > +* now because this is the only call that

Re: [PATCH] Adds a new ioctl32 syscall for backwards compatibility layers

2021-01-06 Thread Amanieu d'Antras
I encountered a similar problem when writing the Tango binary translator (https://www.amanieusystems.com/). Tango allows AArch32 programs to run on AArch64 CPUs that don't support AArch32 (e.g. ThunderX). The technology has been licensed to several customers who are primarily using it to run

Re: [f2fs-dev] [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-06 Thread Jaegeuk Kim
On 01/06, Jaegeuk Kim wrote: > Hi Chao, > > With a quick test, this patch causes down_write failure resulting in blocking > process. I didn't dig in the bug so, please check the code again. :P nvm. I can see it works now. > > On 12/30, Chao Yu wrote: > > ThreadA

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Luck, Tony
On Wed, Jan 06, 2021 at 11:17:08AM -0800, Paul E. McKenney wrote: > On Wed, Jan 06, 2021 at 06:39:30PM +, Luck, Tony wrote: > > > The "Timeout: Not all CPUs entered broadcast exception handler" message > > > will appear from time to time given enough systems, but this message does > > > not

Re: linux-next: build warning after merge of the origin tree

2021-01-06 Thread Johannes Berg
Hi Stephen, > > Right, thanks. I believe I also fixed it in the patch I sent a few days > > ago that fixed the other documentation warning related to SAR that you > > reported. > > I don't think so :-( I did a htmldocs build with your patch ([PATCH > v2] cfg80211/mac80211: fix kernel-doc for

Re: linux-next: build warning after merge of the origin tree

2021-01-06 Thread Stephen Rothwell
Hi Johannes, On Wed, 06 Jan 2021 23:23:42 +0100 Johannes Berg wrote: > > On Thu, 2021-01-07 at 09:05 +1100, Stephen Rothwell wrote: > > Hi all, > > > > Building Linus' tree, today's linux-next build (htmldocs) produced > > this warning: > > > > include/net/mac80211.h:4200: warning: Function

Re: [PATCH v2 mips-next 2/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-06 Thread Fāng-ruì Sòng
On Wed, Jan 6, 2021 at 2:07 PM Kees Cook wrote: > > On Wed, Jan 06, 2021 at 08:08:19PM +, Alexander Lobakin wrote: > > Discard GNU attributes at link time as kernel doesn't use it at all. > > Solves a dozen of the following ld warnings (one per every file): > > > > mips-alpine-linux-musl-ld:

[PATCH v2] x86: fix enqcmds() sparse warning

2021-01-06 Thread Dave Jiang
Add missing __iomem annotation to address sparse warning. Caller is expected to pass an __iomem annotated pointer to this function. The current usages send a 64bytes command descriptor to an MMIO location (portal) on a device for consumption. Also, from the comment in movdir64b(), which also

[PATCH v2] x86: fix movdir64b() sparse warning

2021-01-06 Thread Dave Jiang
Add missing __iomem annotation to address sparse warning. Caller is expected to pass an __iomem annotated pointer to this function. The current usages send a 64bytes command descriptor to an MMIO location (portal) on a device for consumption. When future usages for MOVDIR64B instruction show up in

Re: [PATCH v2 mips-next 2/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-06 Thread Alexander Lobakin
From: Kees Cook Date: Wed, 6 Jan 2021 14:07:07 -0800 > On Wed, Jan 06, 2021 at 08:08:19PM +, Alexander Lobakin wrote: >> Discard GNU attributes at link time as kernel doesn't use it at all. >> Solves a dozen of the following ld warnings (one per every file): >> >> mips-alpine-linux-musl-ld:

Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues

2021-01-06 Thread Russell King - ARM Linux admin
On Wed, Jan 06, 2021 at 05:20:34PM +, Will Deacon wrote: > With that, I see the following after ten seconds or so: > > EXT4-fs error (device sda2): ext4_lookup:1707: inode #674497: comm md5sum: > iget: checksum invalid > > Russell, Mark -- does this recipe explode reliably for you too?

Re: [PATCH v2] f2fs: fix to keep isolation of atomic write

2021-01-06 Thread Jaegeuk Kim
Hi Chao, With a quick test, this patch causes down_write failure resulting in blocking process. I didn't dig in the bug so, please check the code again. :P On 12/30, Chao Yu wrote: > ThreadA ThreadB > - f2fs_ioc_start_atomic_write > - write > -

<    1   2   3   4   5   6   7   8   9   10   >