Re: [PATCH 2/2] security.capability: fix conversions on getxattr

2021-01-29 Thread Eric W. Biederman
"Serge E. Hallyn" writes: > On Thu, Jan 28, 2021 at 08:44:26PM +0100, Miklos Szeredi wrote: >> On Thu, Jan 28, 2021 at 6:09 PM Serge E. Hallyn wrote: >> > >> > On Tue, Jan 19, 2021 at 07:34:49PM -0600, Eric W. Biederman wrote: >> > > Miklos Szeredi writes: >> > > >> > > > if

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-29 Thread Sven Van Asbroeck
On Fri, Jan 29, 2021 at 6:08 PM Willem de Bruijn wrote: > > Okay. I found it a bit hard to parse how much true code change was > mixed in with just reindenting existing code. If a lot, then no need > to split of the code refactor. Thank you. The code is quite hard to review in patch format.

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-29 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 6:03 PM Sven Van Asbroeck wrote: > > Hoi Willem, thanks a lot for reviewing this patch, much appreciated !! > > On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn > wrote: > > > > > +static struct sk_buff * > > > +lan743x_rx_trim_skb(struct sk_buff *skb, int frame_length) >

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-29 Thread Sven Van Asbroeck
Hoi Willem, thanks a lot for reviewing this patch, much appreciated !! On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn wrote: > > > +static struct sk_buff * > > +lan743x_rx_trim_skb(struct sk_buff *skb, int frame_length) > > +{ > > + if (skb_linearize(skb)) { > > Is this needed? That will

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

2021-01-29 Thread Jarkko Sakkinen
On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > Hi Jarkko, Guenter > > Yes, here are the logs when failure occurs - > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > Look for a phrase "TPM returned invalid status" > > Guenter - good suggestion

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

2021-01-29 Thread Jarkko Sakkinen
On Sat, Jan 30, 2021 at 12:59:09AM +0200, Jarkko Sakkinen wrote: > On Tue, Jan 26, 2021 at 04:46:07PM +0100, Łukasz Majczak wrote: > > Hi Jarkko, Guenter > > > > Yes, here are the logs when failure occurs - > > https://gist.github.com/semihalf-majczak-lukasz/1575461f585f1e7fb1e9366b8eceaab9 > >

[GIT PULL] Devicetree fixes for 5.11, take 2

2021-01-29 Thread Rob Herring
Linus, Please pull some more DT fixes for 5.11. Rob The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git

Re: [RFC PATCH v1 1/4] vfio/type1: Add a bitmap to track IOPF mapped pages

2021-01-29 Thread Alex Williamson
On Mon, 25 Jan 2021 17:03:59 +0800 Shenming Lu wrote: > When IOPF enabled, the pages are pinned and mapped on demand, we add > a bitmap to track them. > > Signed-off-by: Shenming Lu > --- > drivers/vfio/vfio_iommu_type1.c | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [PATCH 2/2] security.capability: fix conversions on getxattr

2021-01-29 Thread Eric W. Biederman
"Serge E. Hallyn" writes: > On Thu, Jan 28, 2021 at 02:19:13PM -0600, Eric W. Biederman wrote: >> "Serge E. Hallyn" writes: >> >> > On Tue, Jan 19, 2021 at 07:34:49PM -0600, Eric W. Biederman wrote: >> >> Miklos Szeredi writes: >> >> >> >> > If a capability is stored on disk in v2 format

Re: [RFC PATCH v1 0/4] vfio: Add IOPF support for VFIO passthrough

2021-01-29 Thread Alex Williamson
On Mon, 25 Jan 2021 17:03:58 +0800 Shenming Lu wrote: > Hi, > > The static pinning and mapping problem in VFIO and possible solutions > have been discussed a lot [1, 2]. One of the solutions is to add I/O > page fault support for VFIO devices. Different from those relatively > complicated

Re: [PATCH] x86/fault: Send SIGBUS to user process always for hwpoison page access.

2021-01-29 Thread Luck, Tony
Thanks for the explanation and test code. I think I see better what is going on here. [I took your idea for using madvise(...MADV_HWPOISON) and added a new "-S" option to my einj_mem_uc test program to use madvise instead of ACPI/EINJ for injections. Update pushed here:

Re: [PATCH RFC 00/30] userfaultfd-wp: Support shmem and hugetlbfs

2021-01-29 Thread Peter Xu
On Fri, Jan 15, 2021 at 12:08:37PM -0500, Peter Xu wrote: > This is a RFC series to support userfaultfd upon shmem and hugetlbfs. > > PS. Note that there's a known issue [0] with tlb against uffd-wp/soft-dirty in > general and Nadav is working on it. It may or may not directly affect >

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-29 Thread Jyoti Bhayana
Hi Peter, I have modified the comments in v4 of that patch. Regarding your suggestion of this driver handling a greater value range by adjusting the scale accordingly, it would also require the driver to change the sensor readings as well based on the updated scale and the accuracy of the sensor

Re: [PATCH] tpm_tis: Add missing start/stop_tpm_chip calls

2021-01-29 Thread Jarkko Sakkinen
On Mon, Jan 25, 2021 at 09:18:46AM -0800, Guenter Roeck wrote: > Hi Lukasz, > > On Sat, Jan 23, 2021 at 02:42:47AM +0100, Lukasz Majczak wrote: > > There is a missing call to start_tpm_chip before the call to > > the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current > > approach

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-01-29 Thread Sven Van Asbroeck
Hi Andrew, thank you so much for looking at this patch ! On Fri, Jan 29, 2021 at 3:36 PM Andrew Lunn wrote: > > So this patch appears to contain two different changes > 1) You only allocate a receive buffer as big as the MTU plus overheads > 2) You change the cache operations to operate on the

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Fangrui Song
On 2021-01-29, Nick Desaulniers wrote: DWARF v5 is the latest standard of the DWARF debug info format. Feature detection of DWARF5 is onerous, especially given that we've removed $(AS), so we must query $(CC) for DWARF5 assembler directive support. The DWARF version of a binary can be

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-01-29 Thread Sven Van Asbroeck
On Fri, Jan 29, 2021 at 5:01 PM Jakub Kicinski wrote: > > You may need to rebase to see this: > > drivers/net/ethernet/microchip/lan743x_main.c:2123:41: warning: restricted > __le32 degrades to integer Good catch. The problem goes away with the next commit in the set. This is probably because I

Re: [PATCH] lib: crc8: Pointer to data block should be const

2021-01-29 Thread Randy Dunlap
On 1/29/21 8:41 AM, Richard Fitzgerald wrote: > crc8() does not change the data passed to it, so the pointer argument > should be declared const. This avoids callers that receive const data > having to cast it to a non-const pointer to call crc8(). > > Signed-off-by: Richard Fitzgerald > --- >

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-29 Thread Jyoti Bhayana
Hi Christian, I have addressed your feedback in v4 of the patch. Please find below the answers to some of your questions: >The initial sensor_config ORed here is NOT initialized nor zeroed. There is no need to initialize as it is already initialized to 0 when defined. > being not so

[PATCHv2] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem

2021-01-29 Thread Pavel Machek
Motorola is using a custom TS 27.010 based multiplexer protocol for various devices on the modem. These devices can be accessed on dedicated channels using Linux kernel serdev-ngsm driver. For the GNSS on these devices, we need to kick the GNSS device at a desired rate. Otherwise the GNSS device

Re: [PATCH v2] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set

2021-01-29 Thread Randy Dunlap
On 1/29/21 2:06 PM, Scott Branden wrote: > Correct compile issue if CONFIG_TTY is not set by > only adding ttyVK devices if CONFIG_TTY is set. > > Reported-by: Randy Dunlap > Signed-off-by: Scott Branden > > --- > Changes since v1: > Add function stubs rather than compiling out code > --- >

Re: [RFC PATCH v1 3/4] vfio: Try to enable IOPF for VFIO devices

2021-01-29 Thread Alex Williamson
On Mon, 25 Jan 2021 17:04:01 +0800 Shenming Lu wrote: > If IOMMU_DEV_FEAT_IOPF is set for the VFIO device, which means that > the delivering of page faults of this device from the IOMMU is enabled, > we register the VFIO page fault handler to complete the whole faulting > path (HW+SW). And add a

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:31 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > > > > > On Fri, Jan 29, 2021 at 11:09 PM

Re: [PATCH v6 1/2] Kbuild: make DWARF version a choice

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:41 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 04:32:32PM -0500, Arvind Sankar wrote: > > Given what Jakub is saying, i.e. it was previously impossible to get > > dwarf2 with gcc, and you get dwarf4 whether or not DEBUG_INFO_DWARF4 was > > It isn't impossible to

Re: [PATCH v2 3/5] pcie-qcom: provide a way to power up qca6390 chip on RB5 platform

2021-01-29 Thread Bjorn Helgaas
On Sat, Jan 30, 2021 at 01:19:10AM +0300, Dmitry Baryshkov wrote: > On Sat, 30 Jan 2021 at 00:50, Bjorn Helgaas wrote: > > On Fri, Jan 29, 2021 at 06:45:21AM +0300, Dmitry Baryshkov wrote: > > > On 28/01/2021 22:26, Rob Herring wrote: > > > > On Thu, Jan 28, 2021 at 11:52 AM Dmitry Baryshkov > >

Re: [NEEDS-REVIEW] [PATCH v18 05/25] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states

2021-01-29 Thread Yu, Yu-cheng
On 1/29/2021 1:00 PM, Dave Hansen wrote: On 1/27/21 1:25 PM, Yu-cheng Yu wrote: @@ -135,6 +135,8 @@ enum xfeature { #define XFEATURE_MASK_PT (1 << XFEATURE_PT_UNIMPLEMENTED_SO_FAR) #define XFEATURE_MASK_PKRU(1 << XFEATURE_PKRU) #define XFEATURE_MASK_PASID

Re: [PATCH] gnss: motmdm: Add support for Motorola Mapphone MDM6600 modem

2021-01-29 Thread Pavel Machek
Hi! > > Motorola is using a custom TS 27.010 based serial port line discipline > > s/serial port line discipline/multiplexer protocol/ > > diff --git a/drivers/gnss/Kconfig b/drivers/gnss/Kconfig > > index bd12e3d57baa..a7c449d8428c 100644 > > --- a/drivers/gnss/Kconfig > > +++

Re: [PATCH RFC 21/30] hugetlb: Pass vma into huge_pte_alloc()

2021-01-29 Thread Peter Xu
On Thu, Jan 28, 2021 at 02:59:13PM -0800, Axel Rasmussen wrote: > > +pte_t *huge_pte_alloc(struct mm_struct *mm, structt vm_area_struct *vma, > > This was pointed out to me just after I sent v3 of my series today > (which includes this patch): > > Typo, s/structt/struct/. Thanks Axel - fixed

Re: [PATCH v4 12/17] remoteproc: Introduce function rproc_detach()

2021-01-29 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 09:50:31AM +0100, Arnaud POULIQUEN wrote: > > > On 12/18/20 6:32 PM, Mathieu Poirier wrote: > > Introduce function rproc_detach() to enable the remoteproc > > core to release the resources associated with a remote processor > > without stopping its operation. > > > >

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 2:23 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 1:20

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:11 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote: > > > Wasn't that fixed in GAS? > > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195 > > > > $ make LLVM=1 -j72 defconfig > > $ ./scripts/config -e DEBUG_INFO -e

Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro

2021-01-29 Thread Yury Norov
On Fri, Jan 29, 2021 at 1:11 PM Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 10:49 PM Yury Norov wrote: > > > > Many algorithms become simplier if they are passed with relatively small > > simpler > > > input values. One example is bitmap operations when the whole bitmap fits > > into one

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:21 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > > > > > On Fri, Jan 29, 2021 at 10:13 PM

Re: [PATCH] kernel: trace: preemptirq_delay_test: add cpu affinity

2021-01-29 Thread Steven Rostedt
Joel, Can you ack this patch? -- Steve On Thu, 28 Jan 2021 09:35:13 +0800 Song Chen wrote: > The kernel thread executing test can run on any cpu, which might be > different cpu latency tracer is running on, as a result, the > big latency caused by preemptirq delay test can't be detected. >

[RFC PATCH v4 0/1] Adding support for IIO SCMI based sensors

2021-01-29 Thread Jyoti Bhayana
Hi, This series adds support for ARM SCMI Protocol based IIO Device. This driver provides support for Accelerometer and Gyroscope sensor using SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification, which is available at https://developer.arm.com/documentation/den0056/c/ This

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 2:11 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 10:09 PM

Re: [PATCH v2 3/5] pcie-qcom: provide a way to power up qca6390 chip on RB5 platform

2021-01-29 Thread Dmitry Baryshkov
On Sat, 30 Jan 2021 at 00:50, Bjorn Helgaas wrote: > > On Fri, Jan 29, 2021 at 06:45:21AM +0300, Dmitry Baryshkov wrote: > > On 28/01/2021 22:26, Rob Herring wrote: > > > On Thu, Jan 28, 2021 at 11:52 AM Dmitry Baryshkov > > > wrote: > > > > > > > > Some Qualcomm platforms require to power up an

[RFC PATCH v4 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-01-29 Thread Jyoti Bhayana
This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification Signed-off-by: Jyoti Bhayana --- MAINTAINERS| 6 +

Re: [PATCH v4 11/17] remoteproc: Introduce function __rproc_detach()

2021-01-29 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 09:46:58AM +0100, Arnaud POULIQUEN wrote: > > > On 12/18/20 6:32 PM, Mathieu Poirier wrote: > > Introduce function __rproc_detach() to perform the same kind of > > operation as rproc_stop(), but instead of switching off the > > remote processor using rproc->ops->stop(),

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Sven Van Asbroeck
Hi Clemens, On Fri, Jan 29, 2021 at 4:24 PM Sven Van Asbroeck wrote: > > LEN_ON = 409, LED_OFF = 1228 and > LED_ON = 419, LED_OFF = 1238 > produce the same result. you can't see the difference between the two > when scoping the channel. there are probably more ways to do this, > some might

Re: [PATCH] openrisc: use device tree to determine present cpus

2021-01-29 Thread Stafford Horne
On Fri, Jan 29, 2021 at 07:29:31PM +0100, Jan Henrik Weinstock wrote: > This patch proposes to use the device tree to determine the present cpus > instead of assuming all CONFIG_NRCPUS are actually present in the system. > > Signed-off-by: Jan Henrik Weinstock > --- > arch/openrisc/kernel/smp.c

Re: [GIT PULL] arm64 fixes for 5.11-rc6

2021-01-29 Thread pr-tracker-bot
The pull request you sent on Fri, 29 Jan 2021 19:03:24 +: > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0e9bcda5d286f4a26a5407bb38f55c55b453ecfb Thank you! -- Deet-doot-dot, I am a

Re: [git pull] IOMMU Fixes for Linux v5.11-rc5

2021-01-29 Thread pr-tracker-bot
The pull request you sent on Fri, 29 Jan 2021 17:41:29 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git > tags/iommu-fixes-v5.11-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8ef24c2011b77bd6344d16630d3cd95d63de63f8 Thank you! --

Re: [GIT PULL][Resend] ACPI fixes for v5.11-rc6

2021-01-29 Thread pr-tracker-bot
The pull request you sent on Fri, 29 Jan 2021 19:11:17 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git > acpi-5.11-rc6 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/016decc0d836b746faac03de5e1ac976c53a3958 Thank you! -- Deet-doot-dot, I

Re: [git pull] drm fixes for 5.11-rc6

2021-01-29 Thread pr-tracker-bot
The pull request you sent on Fri, 29 Jan 2021 13:46:34 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-01-29 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6305d15e013a70a7f1c4ee65d3e035cd705e3517 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] Power management fixes for v5.11-rc6

2021-01-29 Thread pr-tracker-bot
The pull request you sent on Fri, 29 Jan 2021 17:26:04 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git pm-5.11-rc6 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/32b0c410cda19df9f0e88edcae126d0a660cf8b9 Thank you! -- Deet-doot-dot, I am a

Re: ARM: dts: mmp devicetree updates

2021-01-29 Thread Lubomir Rintel
On Fri, Jan 22, 2021 at 03:09:14PM +0100, Arnd Bergmann wrote: > On Thu, Jan 21, 2021 at 4:41 AM Lubomir Rintel wrote: > > > > Hi, > > > > chained to this message is a handful of patches related to MMP device > > trees and bindings. Please take a look and consider queueing them for > > for 5.12.

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-29 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 2:56 PM Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > Multi-buffer packets enable us to use rx ring buffers smaller than > the mtu. This will allow us to change the mtu on-the-fly, without > having to stop the network interface in order to re-size the rx > ring

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 11:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 12:55

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 02:05:59PM -0800, Nick Desaulniers wrote: > Ah, I see. Then I should update the script I add > (scripts/test_dwarf5_support.sh) to feature detect that bug, since > it's the latest of the bunch. Also, should update my comment to note > that this requires binutils greater

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:20 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 9:48 PM

Re: [GIT PULL] arm64 fixes for 5.11-rc6

2021-01-29 Thread Linus Torvalds
On Fri, Jan 29, 2021 at 11:03 AM Catalin Marinas wrote: > > arm64 fixes: > > - Fix the virt_addr_valid() returning true for < PAGE_OFFSET addresses. That's a really odd fix. It went from an incorrect bitwise operation (masking) to an _odd_ bitwise operation (xor). Yes, PAGE_OFFSET has the bit

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:52 PM Fangrui Song wrote: > > On 2021-01-29, Nick Desaulniers wrote: > >diff --git a/include/asm-generic/vmlinux.lds.h > >b/include/asm-generic/vmlinux.lds.h > >index 34b7e0d2346c..f8d5455cd87f 100644 > >--- a/include/asm-generic/vmlinux.lds.h > >+++

[PATCH v2] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set

2021-01-29 Thread Scott Branden
Correct compile issue if CONFIG_TTY is not set by only adding ttyVK devices if CONFIG_TTY is set. Reported-by: Randy Dunlap Signed-off-by: Scott Branden --- Changes since v1: Add function stubs rather than compiling out code --- drivers/misc/bcm-vk/Makefile | 4 ++--

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:11 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote: > > > Wasn't that fixed in GAS? > > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195 > > > > $ make LLVM=1 -j72 defconfig > > $ ./scripts/config -e DEBUG_INFO -e

Re: [PATCH net-next v1 1/6] lan743x: boost performance on cpu archs w/o dma cache snooping

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 14:52:35 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > The buffers in the lan743x driver's receive ring are always 9K, > even when the largest packet that can be received (the mtu) is > much smaller. This performs particularly badly on cpu archs > without dma

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 1:18 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: On 1/29/21 12:18 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: The code does not care about the size of data -- All it does is that if MSG_OOB is set it will

Re: Issues with "PCI/LINK: Report degraded links via link bandwidth notification"

2021-01-29 Thread Bjorn Helgaas
On Thu, Jan 28, 2021 at 06:07:36PM -0600, Alex G. wrote: > On 1/28/21 5:51 PM, Sinan Kaya wrote: > > On 1/28/2021 6:39 PM, Bjorn Helgaas wrote: > > > AFAICT, this thread petered out with no resolution. > > > > > > If the bandwidth change notifications are important to somebody, > > > please speak

[PATCH v3] Bluetooth: Skip eSCO 2M params when not supported

2021-01-29 Thread Yu Liu
If a peer device doesn't support eSCO 2M we should skip the params that use it when setting up sync connection since they will always fail. Signed-off-by: Yu Liu Reviewed-by: Abhishek Pandit-Subedi --- Changes in v3: - Use pkt_type instead of adding new field Changes in v2: - Fix title

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Fangrui Song
On 2021-01-29, Nick Desaulniers wrote: DWARF v5 is the latest standard of the DWARF debug info format. Feature detection of DWARF5 is onerous, especially given that we've removed $(AS), so we must query $(CC) for DWARF5 assembler directive support. The DWARF version of a binary can be

Re: [PATCH v2 3/5] pcie-qcom: provide a way to power up qca6390 chip on RB5 platform

2021-01-29 Thread Bjorn Helgaas
On Fri, Jan 29, 2021 at 06:45:21AM +0300, Dmitry Baryshkov wrote: > On 28/01/2021 22:26, Rob Herring wrote: > > On Thu, Jan 28, 2021 at 11:52 AM Dmitry Baryshkov > > wrote: > > > > > > Some Qualcomm platforms require to power up an external device before > > > probing the PCI bus. E.g. on RB5

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-29 Thread Nick Desaulniers
On Thu, Jan 28, 2021 at 11:43 PM Sedat Dilek wrote: > > Some comments: > > [ hash mismatches ] > > Observed identical warnings when doing a rebuild with GAS or Clang-IAS. > > [ Importance of LLVM_IAS=1 working ] > > Clang-LTO and Clang-CFI depend both on LLVM_IAS=1 (see for example > "kbuild: add

Re: [PATCH v2 4/8] KVM: arm64: Generate hyp relocation data

2021-01-29 Thread Guenter Roeck
nvhe.o make-arm64 -j arch/arm64/kvm/hyp/nvhe/kvm_nvhe.o where make-arm64 is: make -j32 ARCH=arm64 CROSS_COMPILE=aarch64-linux- $* --- # bad: [b01f250d83f6c3af5c77699dd14e7b48ee0b5383] Add linux-next specific files for 20210129 # good: [6ee1d745b7c9fd573fba142a2e

Re: [PATCH v6 1/2] Kbuild: make DWARF version a choice

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 04:32:32PM -0500, Arvind Sankar wrote: > Given what Jakub is saying, i.e. it was previously impossible to get > dwarf2 with gcc, and you get dwarf4 whether or not DEBUG_INFO_DWARF4 was It isn't impossible to get it, -gdwarf-2 works, it is just not a very good choice (at

Re: [PATCH v4 05/17] remoteproc: Add new get_loaded_rsc_table() remoteproc operation

2021-01-29 Thread Mathieu Poirier
On Wed, Jan 27, 2021 at 09:44:28AM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > Come back on you series... > > On 12/18/20 6:32 PM, Mathieu Poirier wrote: > > Add an new get_loaded_rsc_table() operation in order to support > > scenarios where the remoteproc core has booted a remote processor

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Matthew Wilcox
On Fri, Jan 29, 2021 at 01:18:20PM -0800, Jakub Kicinski wrote: > On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: > > On 1/29/21 12:18 PM, Jakub Kicinski wrote: > > > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > > >> The code does not care about the size of data -- All it does is

Re: [PATCH v6 1/2] Kbuild: make DWARF version a choice

2021-01-29 Thread Arvind Sankar
On Fri, Jan 29, 2021 at 12:57:20PM -0800, Nick Desaulniers wrote: > On Fri, Jan 29, 2021 at 12:19 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 12:17 PM Jakub Jelinek wrote: > > > > > > On Fri, Jan 29, 2021 at 11:43:17AM -0800, Nick Desaulniers wrote: > > > > Modifies

Re: [PATCH 04/13] module: use RCU to synchronize find_module

2021-01-29 Thread Thiago Jung Bauermann
Christoph Hellwig writes: > On Thu, Jan 28, 2021 at 05:50:56PM -0300, Thiago Jung Bauermann wrote: >> > struct module *find_module(const char *name) >> > { >> > - module_assert_mutex(); >> >> Does it make sense to replace the assert above with the warn below >> (untested)? >> >>

Re: [RFC 0/3] kunit vs structleak

2021-01-29 Thread Brendan Higgins
On Wed, Jan 27, 2021 at 12:15 PM Kees Cook wrote: > > On Mon, Jan 25, 2021 at 01:45:25PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > I ran into a couple of problems with kunit tests taking too much stack > > space, sometimes dangerously so. These the the three instances that > >

Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro

2021-01-29 Thread Yury Norov
On Fri, Jan 29, 2021 at 1:11 PM Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 10:49 PM Yury Norov wrote: > > > > Many algorithms become simplier if they are passed with relatively small > > simpler > > > input values. One example is bitmap operations when the whole bitmap fits > > into one

Re: [PATCH] vmlinux.lds.h: Define SANTIZER_DISCARDS with CONFIG_GCOV_KERNEL=y

2021-01-29 Thread Fangrui Song
On 2021-01-29, Nick Desaulniers wrote: On Fri, Jan 29, 2021 at 12:11 PM Nathan Chancellor wrote: clang produces .eh_frame sections when CONFIG_GCOV_KERNEL is enabled, even when -fno-asynchronous-unwind-tables is in KBUILD_CFLAGS: $ make CC=clang vmlinux ... ld: warning: orphan section

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

2021-01-29 Thread Steven Rostedt
On Fri, 29 Jan 2021 14:01:03 -0500 Steven Rostedt wrote: > On Fri, 29 Jan 2021 18:59:43 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 29, 2021 at 09:45:48AM -0800, Alexei Starovoitov wrote: > > > Same things apply to bpf side. We can statically prove safety for > > > ftrace and kprobe

Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro

2021-01-29 Thread Joe Perches
On Fri, 2021-01-29 at 23:10 +0200, Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 10:49 PM Yury Norov wrote: [] > > @@ -37,7 +37,7 @@ > >  #define GENMASK(h, l) \ > > (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) > > > > -#define BITS_FIRST(nr) GENMASK(nr), 0) > > +#define

Re: [PATCH v5 2/7] pwm: pca9685: Support hardware readout

2021-01-29 Thread Sven Van Asbroeck
Hi Clemens, On Fri, Jan 29, 2021 at 3:37 PM Clemens Gruber wrote: > > Is the driver really responsible for bootloaders that program the chip > with invalid values? No, but it's responsible for correcting invalid values. Otherwise the driver doesn't work. > The chip comes out of PoR with sane

Re: [PATCH v9 1/7] ACPI: scan: Obtain device's desired enumeration power state

2021-01-29 Thread Sakari Ailus
On Fri, Jan 29, 2021 at 05:57:17PM +0100, Rafael J. Wysocki wrote: > On Fri, Jan 29, 2021 at 5:45 PM Sakari Ailus > wrote: > > > > Hi Rafael, > > > > Thanks for the comments. > > > > On Fri, Jan 29, 2021 at 03:07:57PM +0100, Rafael J. Wysocki wrote: > > > On Fri, Jan 29, 2021 at 12:27 AM Sakari

Re: 5.9.11 still hanging 2mn at each boot and looping on nvidia-gpu 0000:01:00.3: PME# enabled (Quadro RTX 4000 Mobile)

2021-01-29 Thread Bjorn Helgaas
On Thu, Jan 28, 2021 at 04:56:26PM -0800, Marc MERLIN wrote: > On Wed, Jan 27, 2021 at 03:33:00PM -0600, Bjorn Helgaas wrote: > > Hi Marc, I appreciate your persistence on this. I am frankly > > surprised that you've put up with this so long. > > Well, been using linux for 27 years, but also

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 10:13 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at 12:41

Re: [PATCH v6 3/3] arm64: defconfig: Enable PF8x00 as builtin

2021-01-29 Thread Krzysztof Kozlowski
On Thu, Jan 28, 2021 at 08:35:54PM +0100, Adrien Grassein wrote: > This driver is mandatory for the nitrogen8m mini board > when booting from the sdcard slot. > > Signed-off-by: Adrien Grassein > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Krzysztof

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: > On 1/29/21 12:18 PM, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > >> The code does not care about the size of data -- All it does is that if > >> MSG_OOB is set it will deliver the signal to the peer

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-29 Thread Shuah Khan
On 1/29/21 10:08 AM, Tetsuo Handa wrote: On 2021/01/30 1:05, Shuah Khan wrote: Since "general protection fault in tomoyo_socket_sendmsg_permission" is caused by unexpectedly resetting ud->tcp_socket to NULL without waiting for tx thread to terminate, tracing the ordering of events is worth

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 10:09 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > > wrote: > > > > > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at

Re: [PATCH v18 02/25] x86/cet/shstk: Add Kconfig option for user-mode control-flow protection

2021-01-29 Thread Yu, Yu-cheng
On 1/29/2021 12:46 PM, Borislav Petkov wrote: On Fri, Jan 29, 2021 at 12:33:43PM -0800, Dave Hansen wrote: In that case is there any reason to keep the "depends on CPU_SUP_INTEL"? Probably not. I haven't heard of the AMD implementation being somehow different from Intel's. Ok, I will

Re: [PATCH 0/6] lib/find_bit: fast path for small bitmaps

2021-01-29 Thread Andy Shevchenko
On Fri, Jan 29, 2021 at 10:54 PM Yury Norov wrote: > On Fri, Jan 29, 2021 at 12:45 PM Yury Norov wrote: > > > > Bitmap operations are much simpler and faster in case of small bitmaps, > > whicn > > fit into a single word. In linux/bitmap.h we have a machinery that allows > > compiler to replace

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 01:05:56PM -0800, Nick Desaulniers wrote: > > Wasn't that fixed in GAS? > > https://sourceware.org/bugzilla/show_bug.cgi?id=27195 > > $ make LLVM=1 -j72 defconfig > $ ./scripts/config -e DEBUG_INFO -e DEBUG_INFO_DWARF5 > $ make LLVM=1 -j72 > ... > /tmp/init-d50d89.s:

Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro

2021-01-29 Thread Andy Shevchenko
On Fri, Jan 29, 2021 at 10:49 PM Yury Norov wrote: > > Many algorithms become simplier if they are passed with relatively small simpler > input values. One example is bitmap operations when the whole bitmap fits > into one word. To implement such simplifications, linux/bitmap.h declares >

Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

2021-01-29 Thread Hans de Goede
Hi, On 1/29/21 9:28 PM, Linus Torvalds wrote: > On Fri, Jan 29, 2021 at 12:02 PM Linus Torvalds > wrote: >> >> It's fairly easy to work around in this in the tty layer by just >> avoiding that function entirely, so I'll cook up a patch to do that. >> But I'm adding the appropriate people to the

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 12:55 PM Sedat Dilek wrote: > > On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers > wrote: > > > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > > > wrote: > > > > > > > > diff --git a/Makefile

Re: [PATCH RESEND] ata: ahci_brcm: Add back regulators management

2021-01-29 Thread Jens Axboe
On 1/29/21 11:28 AM, Florian Fainelli wrote: > While reworking the resources management and departing from using > ahci_platform_enable_resources() which did not allow a proper step > separation like we need, we unfortunately lost the ability to control > AHCI regulators. This broke some Broadcom

Re: [PATCH] Documentation/llvm: Add a section about supported architectures

2021-01-29 Thread Masahiro Yamada
On Sat, Jan 30, 2021 at 5:31 AM Nathan Chancellor wrote: > > On Wed, Jan 13, 2021 at 05:34:47PM -0700, Nathan Chancellor wrote: > > The most common question around building the Linux kernel with clang is > > "does it work?" and the answer has always been "it depends on your > > architecture,

Re: kprobes broken since 0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")

2021-01-29 Thread Alexei Starovoitov
On Fri, Jan 29, 2021 at 02:01:03PM -0500, Steven Rostedt wrote: > On Fri, 29 Jan 2021 18:59:43 +0100 > Peter Zijlstra wrote: > > > On Fri, Jan 29, 2021 at 09:45:48AM -0800, Alexei Starovoitov wrote: > > > Same things apply to bpf side. We can statically prove safety for > > > ftrace and kprobe

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 12:57 PM Jakub Jelinek wrote: > > On Fri, Jan 29, 2021 at 12:48:11PM -0800, Nick Desaulniers wrote: > > > Should this be...? > > > > > > KBUILD_AFLAGS += -Wa,-gdwarf-5 > > > > No; under the set of conditions Clang is compiling .c to .S with DWARF > > v5 assembler

Re: [RFC][PATCH 07/13] mm/migrate: make migrate_pages() return nr_succeeded

2021-01-29 Thread Yang Shi
On Mon, Jan 25, 2021 at 4:41 PM Dave Hansen wrote: > > > From: Yang Shi > > The migrate_pages() returns the number of pages that were not migrated, > or an error code. When returning an error code, there is no way to know > how many pages were migrated or not migrated. > > In the following

Re: [NEEDS-REVIEW] [PATCH v18 05/25] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states

2021-01-29 Thread Dave Hansen
On 1/27/21 1:25 PM, Yu-cheng Yu wrote: > @@ -135,6 +135,8 @@ enum xfeature { > #define XFEATURE_MASK_PT (1 << XFEATURE_PT_UNIMPLEMENTED_SO_FAR) > #define XFEATURE_MASK_PKRU (1 << XFEATURE_PKRU) > #define XFEATURE_MASK_PASID (1 << XFEATURE_PASID) > +#define

Re: [RFC][PATCH 06/13] mm/migrate: update migration order during on hotplug events

2021-01-29 Thread Yang Shi
On Mon, Jan 25, 2021 at 4:41 PM Dave Hansen wrote: > > > From: Dave Hansen > > Reclaim-based migration is attempting to optimize data placement in > memory based on the system topology. If the system changes, so must > the migration ordering. > > The implementation here is pretty simple and

Re: [PATCH v6 1/2] Kbuild: make DWARF version a choice

2021-01-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 12:19 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:17 PM Jakub Jelinek wrote: > > > > On Fri, Jan 29, 2021 at 11:43:17AM -0800, Nick Desaulniers wrote: > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > > > explicit

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Jakub Jelinek
On Fri, Jan 29, 2021 at 12:48:11PM -0800, Nick Desaulniers wrote: > > Should this be...? > > > > KBUILD_AFLAGS += -Wa,-gdwarf-5 > > No; under the set of conditions Clang is compiling .c to .S with DWARF > v5 assembler directives. GAS will choke unless told -gdwarf-5 via > -Wa,-gdwarf-5 for .c

Re: [PATCH v2 3/3] f2fs: Add metadata encryption support

2021-01-29 Thread Eric Biggers
On Thu, Dec 17, 2020 at 03:04:35PM +, Satya Tangirala wrote: > Wire up metadata encryption support with the fscrypt metadata crypt > additions. Note that this feature relies on the blk-crypto framework > for encryption, and thus requires either hardware inline encryption > support or the

Re: [PATCH v6 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Sedat Dilek
On Fri, Jan 29, 2021 at 9:48 PM Nick Desaulniers wrote: > > On Fri, Jan 29, 2021 at 12:41 PM Sedat Dilek wrote: > > > > On Fri, Jan 29, 2021 at 8:43 PM Nick Desaulniers > > wrote: > > > > > > diff --git a/Makefile b/Makefile > > > index 20141cd9319e..bed8b3b180b8 100644 > > > --- a/Makefile > >

Re: [PATCH] drm/i915: Remove unreachable code

2021-01-29 Thread Chris Wilson
Quoting Vinicius Tinti (2021-01-29 18:15:19) > By enabling -Wunreachable-code-aggressive on Clang the following code > paths are unreachable. That code exists as commentary and, especially for sdvo, library functions that we may need in future. The ivb-gt1 case => as we now set the gt level for

Re: [PATCH 0/6] lib/find_bit: fast path for small bitmaps

2021-01-29 Thread Yury Norov
On Fri, Jan 29, 2021 at 12:45 PM Yury Norov wrote: > > Bitmap operations are much simpler and faster in case of small bitmaps, whicn > fit into a single word. In linux/bitmap.h we have a machinery that allows > compiler to replace actual function call with a few instructions if bitmaps > passed

<    1   2   3   4   5   6   >