[RFC PATCH v4 19/19] dyndbg: RFC add linker rules to module.lds.h

2021-03-16 Thread Jim Cromie
Copy the DYNAMIC_DEBUG_DATA macro, that works in vmlinux.lds.h, into module.lds.h This does not work here The point of the KEEPS is to pack section pairs into consecutive memory, a property we need in order to drop the _ddebug.site pointer. The problem (ISTM) is that for linking vmlinux, the dat

[RFC PATCH v4 16/19] dyndbg: prevent build bugs via -DNO_DYNAMIC_DEBUG_TABLE

2021-03-16 Thread Jim Cromie
The next patch adds DEFINE_DYNAMIC_DEBUG_TABLE(), which breaks some subtrees with special compile constraints (efi etc). Avoid this by adding a define to suppress the *remote declaration* done by DEFINE_DYNAMIC_DEBUG_TABLE(), automatically, on behalf of all possible users of pr_debug. Signed-off-

[RFC PATCH v4 18/19] dyndbg: shuffle ddebug_table fields

2021-03-16 Thread Jim Cromie
In preparation to unionize structs _ddebug & ddebug_table, shuffle fields in latter so they match the layout of the former. This MAY simplify initialization of the header field, in particular by preserving *sites. It also sets up a later conversion to a flex-array ddebugs[]. This step is mostly

[RFC PATCH v4 05/19] dyndbg: hoist ->site out of ddebug_match_site

2021-03-16 Thread Jim Cromie
A coming change adds _get/_put abstraction on the site pointer, to allow managing site info more flexibly. The get/put pattern is best done at a single lexical scope, where its more obviously correct, so hoist the ->site ref out of ddebug_match_site, and pass it in instead. no functional changes

[RFC PATCH v4 06/19] dyndbg: accept null site in ddebug_change

2021-03-16 Thread Jim Cromie
fix a debug-print that includes site info, by adding an alternate debug message that does not. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c

[RFC PATCH v4 08/19] dyndbg: accept null site in ddebug_proc_show

2021-03-16 Thread Jim Cromie
Accept a ddebug record with a null site pointer, and write abbreviated output for that record that doesn't include site info (but does include line-number, since that can be used in >control queries). Also add a 2nd header line with a template for the new output. Signed-off-by: Jim Cromie --- li

[RFC PATCH v4 15/19] dyndbg: add _index to struct _ddebug

2021-03-16 Thread Jim Cromie
We currently use dp->site to map: &__dyndbg[N] -> &__dyndbg_sites[N]. We want to drop site, new _ddebug._index provides the N. The mapping is done in ddebug_site_get(): For builtin modules, a _ddebug *ptr is between __start___dyndbg and __stop___dyndbg, and we can use &__start___dyndbg_sites[N] d

[RFC PATCH v4 17/19] dyndbg: RFC - DECLARE/DEFINE_DYNAMIC_DEBUG_TABLE

2021-03-16 Thread Jim Cromie
V4-proto - now currently diet-3i Simplify: .gnu.linkonce._mod_.dyndbg -> .gnu.linkonce.dyndbg ie drop _mod_ This puts a single header record at front of the vectors, solving 2 problems (discussed below) simultaneously: - header in front, allowing flex-array rep of layout. - single header, not pe

[RFC PATCH v4 14/19] dyndbg: add ddebug_site(_get|_put) abstraction

2021-03-16 Thread Jim Cromie
Replace direct ->site refs with _get(),_put() internal API. Right now, _get() just returns ->site and _put() does nothing. Later we can replace that implementation with one using ->module_index to fetch then forget site data dynamically. Several approaches are possible: A: !site -> fill from ba

[RFC PATCH v4 13/19] dyndbg+module: expose ddebug_sites to modules

2021-03-16 Thread Jim Cromie
In order to drop the pointer connecting _ddebug's to _ddebug_sites, we need to elevate the latter; we need to track it in (internal) ddebug_tables, and set it in ddebug_add_module. That last part exposes it by interface to module.c, so we add a field to load_info, and adjust load_module to initial

[RFC PATCH v4 12/19] dyndbg: allow deleting site info via control interface

2021-03-16 Thread Jim Cromie
Allow users & subsystems to selectively delete callsite info for pr-debug callsites. Hopefully, this can lead to actual recovery of memory. DRM is a potential user which would drop the sites: - has distinct categories for logging, and can map them over to a format prefix, like: "drm:core:", "d

[RFC PATCH v4 11/19] dyndbg: refactor ddebug_alter_site out of ddebug_change

2021-03-16 Thread Jim Cromie
Move the JUMP_LABEL/static-key code to a separate function. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 2d011ac3308d..6fbd9099

[RFC PATCH v4 09/19] dyndbg: optimize ddebug_emit_prefix

2021-03-16 Thread Jim Cromie
Add early return if no callsite info is specified in site-flags. This avoids fetching site info that isn't going to be printed. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 9 + lib/dynamic_debug.c | 3 +++ 2 files changed, 12 insertions(+) diff --git a/includ

[RFC PATCH v4 10/19] dyndbg: avoid calling dyndbg_emit_prefix when it has no work

2021-03-16 Thread Jim Cromie
Wrap function in a static-inline one, which checks flags to avoid calling the function unnecessarily. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index af9cf97f869b..2d011a

[PATCH 11/11] i2c: imx-lpi2c: add edma mode support

2021-03-16 Thread Clark Wang
Add eDMA receive and send mode support. Support to read and write data larger than 256 bytes in one frame. Signed-off-by: Clark Wang Reviewed-by: Li Jun --- drivers/i2c/busses/i2c-imx-lpi2c.c | 291 - 1 file changed, 289 insertions(+), 2 deletions(-) diff --git a/dr

[RFC PATCH v4 07/19] dyndbg: accept null site in dynamic_emit_prefix

2021-03-16 Thread Jim Cromie
2 prints use site->member, protect them with if site. no functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 151e55ab6bb5..0c535f3c2ba9 100644

[PATCH 10/11] i2c: imx-lpi2c: fix type char overflow issue when calculating the clock cycle

2021-03-16 Thread Clark Wang
Claim clkhi and clklo as integer type to avoid possible calculation errors caused by data overflow. Reviewed-by: Fugang Duan Signed-off-by: Clark Wang --- drivers/i2c/busses/i2c-imx-lpi2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.

[RFC PATCH v4 04/19] dyndbg: accept null site in ddebug_match_site

2021-03-16 Thread Jim Cromie
basically, reorder the elements to minimize data fetches. 1- move format and line-number check code to the top of the function, since they don't use/check site info. 2- test site pointer: If its null, we return early, skipping 3: If the query tests against missing site info, fail the

[RFC PATCH v4 02/19] dyndbg: __init iterate over __dyndbg & __dyndbg_site in parallel

2021-03-16 Thread Jim Cromie
In dynamic_debug_init(), rework for-loop; add 2nd 'site' var, and iterate over both __dyndbg* sections in parallel. Replace uses of iter->site with the new 'site' iter, add a BUG_ON to enforce the invariant given by HEAD~1's DECLARE_DYNAMIC_DEBUG_METADATA base->site initialization. 0- declare the

[RFC PATCH v4 03/19] dyndbg: refactor part of ddebug_change to ddebug_match_site

2021-03-16 Thread Jim Cromie
Move all the site-match logic into a separate function, reindent the code, and replace the continues with return falses. No functional changes. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 75 ++--- 1 file changed, 43 insertions(+), 32 deletions(-)

[PATCH 09/11] i2c: imx-lpi2c: fix i2c timing issue

2021-03-16 Thread Clark Wang
The clkhi and clklo ratio was not very precise before that can make the time of START/STOP/HIGH LEVEL out of specification. Therefore, the calculation of these times has been modified in this patch. At the same time, the mode rate definition of i2c is corrected. Reviewed-by: Fugang Duan Signed-o

[RFC PATCH v4 00/19] dynamic debug diet plan

2021-03-16 Thread Jim Cromie
v4 fixes 'series grooming errors', Reported-by: kernel test robot CONFIG_DYNAMIC_DEBUG creates a struct _ddebug (56 bytes) for each callsite, which includes 3 pointers to: module, filename, function. These are repetetive, and compressible, this patch series goes about doing that, it: - splits st

[RFC PATCH v4 01/19] dyndbg: split struct _ddebug, move display fields to new _ddebug_site

2021-03-16 Thread Jim Cromie
struct _ddebug has 2 flavors of fields: essential and optional. Split the 3 optional fields: module, function, file into a new struct _ddebug_site, and add pointer to it from _ddebug. These fields are optional in that they are primarily used to generate the optional "module:func:line" log prefix.

[PATCH 08/11] i2c: imx-lpi2c: add bus recovery feature

2021-03-16 Thread Clark Wang
Add bus recovery feature for LPI2C. Need add gpio pinctrl, scl-gpios and sda-gpios configuration in dts. Signed-off-by: Clark Wang --- drivers/i2c/busses/i2c-imx-lpi2c.c | 83 ++ 1 file changed, 83 insertions(+) diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/driv

[PATCH 07/11] i2c: imx-lpi2c: increase PM timeout to avoid operate clk frequently

2021-03-16 Thread Clark Wang
Switching the clock frequently will affect the data transmission efficiency, and prolong the timeout to reduce autosuspend times for lpi2c. Acked-by: Fugang Duan Signed-off-by: Clark Wang --- drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH 04/11] i2c: imx-lpi2c: manage irq resource request/release in runtime pm

2021-03-16 Thread Clark Wang
From: Fugang Duan Manage irq resource request/release in runtime pm to save irq domain's power. Signed-off-by: Frank Li Signed-off-by: Fugang Duan Reviewed-by: Frank Li --- drivers/i2c/busses/i2c-imx-lpi2c.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-)

[PATCH 06/11] i2c: imx-lpi2c: improve i2c driver probe priority

2021-03-16 Thread Clark Wang
From: Gao Pan use subsys_initcall for i2c driver to improve i2c driver probe priority Signed-off-by: Gao Pan --- drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-

[PATCH 05/11] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work

2021-03-16 Thread Clark Wang
From: Gao Pan add debug message when i2c peripheral clk rate is 0, then directly return -EINVAL. Signed-off-by: Gao Pan Reviewed-by: Andy Duan --- drivers/i2c/busses/i2c-imx-lpi2c.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b

[PATCH 02/11] i2c: imx-lpi2c: add runtime pm support

2021-03-16 Thread Clark Wang
From: Fugang Duan - Add runtime pm support to dynamicly manage the clock. - Put the suspend to suspend_noirq. - Call .pm_runtime_force_suspend() to force runtime pm suspended in .suspend_noirq(). Signed-off-by: Fugang Duan Signed-off-by: Gao Pan Reviewed-by: Anson Huang --- drivers/i2c/bus

[PATCH 01/11] i2c: imx-lpi2c: directly retrun ISR when detect a NACK

2021-03-16 Thread Clark Wang
From: Gao Pan A NACK flag in ISR means i2c bus error. In such codition, there is no need to do read/write operation. It's better to return ISR directly and then stop i2c transfer. Signed-off-by: Gao Pan Signed-off-by: Clark Wang --- drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++- 1 file

[PATCH 03/11] i2c: imx-lpi2c: add ipg clk for lpi2c driver

2021-03-16 Thread Clark Wang
The lpi2c IP needs two clks: ipg clk and per clk. The old lpi2c driver missed ipg clk. This patch adds ipg clk for lpi2c driver. Signed-off-by: Gao Pan Signed-off-by: Clark Wang Acked-by: Fugang Duan --- drivers/i2c/busses/i2c-imx-lpi2c.c | 28 +--- 1 file changed, 21 i

[PATCH 00/11] i2c: imx-lpi2c: New features and bug fixes

2021-03-16 Thread Clark Wang
Hi, Here are some patches to add some new features and bug fixes/improvements. Each patch of these 11 patches is made on the basis of the previous patches. New features: - add bus recovery support - add edma mode support - add runtime pm support Improvements: - increase PM timeout to avoid o

[PATCH 2/2] Fix spelling typo

2021-03-16 Thread qiumibaozi_1
From: ganjisheng Signed-off-by: ganjisheng --- drivers/mfd/88pm800.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index c7f9649..4ffd9d2 100644 --- a/drivers/mfd/88pm800.c +++ b/drivers/mfd/88pm800.c @@ -285,10 +285,10 @@

[PATCH v4 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller

2021-03-16 Thread Manish Narani
Add documentation for Versal DWC3 controller. Add required property 'reg' for the same. Also add optional properties for snps,dwc3. Signed-off-by: Manish Narani Reviewed-by: Rob Herring --- .../devicetree/bindings/usb/dwc3-xilinx.txt| 28 -- 1 file changed, 26 insert

Re: [PATCH] staging: comedi: das800: fix request_irq() warn

2021-03-16 Thread Dan Carpenter
On Wed, Mar 17, 2021 at 01:55:40AM -0400, Tong Zhang wrote: > Thanks for pointing that out. > Yes you are right there is a mistake. > I am a human. Human make mistakes. Therefore I make mistakes. > Yep. We all make mistakes. One thing to do is if you make a mistake then check to see if anyone e

[PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-16 Thread Manish Narani
Add a new driver for supporting Xilinx platforms. This driver is used for some sequence of operations required for Xilinx USB controllers. This driver is also used to choose between PIPE clock coming from SerDes and the Suspend Clock. Before the controller is out of reset, the clock selection shoul

[PATCH v4 0/2] Add a separate DWC3 OF driver for Xilinx platforms

2021-03-16 Thread Manish Narani
This patch series documents the Xilinx Versal DWC3 controller. This also adds a new Xilinx specific driver for adding new features in the future. Changes in v2: - Addressed review comments from v1 - merged normal and runtime suspend resume functions as they are same

Re: [PATCH v2 1/2] media: staging/intel-ipu3: Fix memory leak in imu_fmt

2021-03-16 Thread Bingbu Cao
On 3/17/21 1:50 AM, Ricardo Ribalda wrote: > Hi Bingbu > > Thanks for your review > > On Tue, Mar 16, 2021 at 12:29 PM Bingbu Cao > wrote: >> >> Hi, Ricardo >> >> Thanks for your patch. >> It looks fine for me, do you mind squash 2 patchsets into 1 commit? > > Are you sure? There are two dif

Re: [PATCH 2/2] erofs: use sync decompression for atomic contexts only

2021-03-16 Thread Chao Yu
On 2021/3/17 11:54, Huang Jianan via Linux-erofs wrote: Sync decompression was introduced to get rid of additional kworker scheduling overhead. But there is no such overhead in non-atomic contexts. Therefore, it should be better to turn off sync decompression to avoid the current thread waiting i

Re: [question] Panic in dax_writeback_one

2021-03-16 Thread chenjun (AM)
Thanks for the advices. I will check out that. 在 2021/3/17 12:55, Dan Williams 写道: > On Tue, Mar 16, 2021 at 8:00 PM chenjun (AM) wrote: >> >> 在 2021/3/12 1:25, Dan Williams 写道: >>> On Thu, Mar 11, 2021 at 4:20 AM Matthew Wilcox wrote: On Thu, Mar 11, 2021 at 07:48:25AM +, chenjun

[PATCH] sched: replace if (cond) BUG() with BUG_ON()

2021-03-16 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./arch/powerpc/platforms/cell/spufs/sched.c:908:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- arch/powerpc/platforms/cell/spufs/sched.c | 3 +-- 1 file changed, 1 insertion(+),

Re: [PATCH 1/2] erofs: use workqueue decompression for atomic contexts only

2021-03-16 Thread Chao Yu
On 2021/3/17 11:54, Huang Jianan via Linux-erofs wrote: z_erofs_decompressqueue_endio may not be executed in the atomic context, for example, when dm-verity is turned on. In this scenario, data can be decompressed directly to get rid of additional kworker scheduling overhead. Signed-off-by: Huan

Re: [PATCH v15 0/4] Adding the Sparx5 Serdes driver

2021-03-16 Thread Vinod Koul
On 18-02-21, 17:14, Steen Hegelund wrote: > Adding the Sparx5 Serdes driver > > This series of patches provides the serdes driver for the Microchip Sparx5 > ethernet switch. > > The serdes driver supports the 10G and 25G serdes instances available in the > Sparx5. > > The Sparx5 serdes support s

[rcu:rcu/next] BUILD REGRESSION 9035ae87fcb36d2a7c8872e1cc0a46c0c5b619a8

2021-03-16 Thread kernel test robot
arning ids grouped by kconfigs: gcc_recent_errors |-- i386-randconfig-m021-20210316 | |-- ERROR:rcu_read_lock_longwait-kernel-rcu-rcutorture.ko-undefined | |-- ERROR:rcu_read_lock_longwait_held-kernel-rcu-rcutorture.ko-undefined | `-- ERROR:rcu_read_unlock_longwait-kernel-rcu-rcutorture.ko-unde

Re: [PATCH 13/13] MAINTAINERS: Add entry for the bitmap API

2021-03-16 Thread Lukas Bulwahn
On Wed, Mar 17, 2021 at 5:57 AM Joe Perches wrote: > > On Tue, 2021-03-16 at 21:47 -0700, Yury Norov wrote: > > [CC Andy Whitcroft, Joe Perches, Dwaipayan Ray, Lukas Bulwahn] > > > > On Tue, Mar 16, 2021 at 01:45:51PM +0200, Andy Shevchenko wrote: > > > On Mon, Mar 15, 2021 at 06:54:24PM -0700, Yu

Re: [PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-16 Thread Vinod Koul
On 16-03-21, 19:14, Seiya Wang wrote: > This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC > Platform. Applied, thanks -- ~Vinod

Re: [PATCH] btrfs: Use immediate assignment when referencing cc-option

2021-03-16 Thread Nikolay Borisov
On 17.03.21 г. 0:46 ч., Victor Erminpour wrote: > Calling cc-option will use KBUILD_CFLAGS, which when lazy setting > subdir-ccflags-y produces the following build error: > > scripts/Makefile.lib:10: *** Recursive variable `KBUILD_CFLAGS' \ > references itself (eventually). Stop. > > Us

Re: [PATCH 07/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-16 Thread Vinod Koul
On 16-03-21, 19:14, Seiya Wang wrote: > This commit adds dt-binding documentation of T-Phy for Mediatek MT8195 SoC > Platform. Applied, thanks -- ~Vinod

[PATCH V3 1/2] dt-bindings: iio: st,st-sensors add IIS2MDC.

2021-03-16 Thread LI Qingwu
Add support for ST magnetometer IIS2MDC, an I2C/SPI interface 3-axis magnetometer sensor. The patch was tested on the instrument with IIS2MDC via I2C interface. Acked-by: Rob Herring Signed-off-by: LI Qingwu --- Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 + 1 file changed, 1 i

[PATCH V3 2/2] iio:magnetometer: Add Support for ST IIS2MDC

2021-03-16 Thread LI Qingwu
Add support for ST magnetometer IIS2MDC, an I2C/SPI interface 3-axis magnetometer. The patch was tested on the instrument with IIS2MDC via I2C interface. Signed-off-by: LI Qingwu --- drivers/iio/magnetometer/st_magn.h | 1 + drivers/iio/magnetometer/st_magn_core.c | 1 + drivers/iio/magneto

[PATCH V3 0/2] Add support for ST magnetometer IIS2MDC

2021-03-16 Thread LI Qingwu
Changes in V3: Reword the commit message, add "Acked-by: Rob Herring" LI Qingwu (2): dt-bindings: iio: st,st-sensors add IIS2MDC. iio:magnetometer: Add Support for ST IIS2MDC Documentation/devicetree/bindings/iio/st,st-sensors.yaml | 1 + drivers/iio/magnetometer/st_magn.h

Re: [PATCH v3] phy: qcom-qmp: add hbr3_hbr2 voltage and premphasis swing table

2021-03-16 Thread Vinod Koul
On 16-03-21, 10:12, Kuogee Hsieh wrote: > Add hbr3_hbr2 voltage and premphasis swing table to support > HBR3 link rate. > > Changes in V2: > -- replaced upper case with lower case at hbr3_hbr2 table > > Changes in v3: > -- replace space with tab at hbr3_hbr2 table This should be after the --- li

Re: [net PATCH 4/9] octeontx2-af: Remove TOS field from MKEX TX

2021-03-16 Thread sundeep subbaraya
Hi Jakub, On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski wrote: > > On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote: > > From: Subbaraya Sundeep > > > > TOS overlaps with DMAC field in mcam search key and hence installing > > rules for TX side are failing. Hence remove TOS field from

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-16 Thread Adrian Hunter
On 16/03/21 10:35 pm, Asutosh Das (asd) wrote: > On 3/16/2021 12:48 AM, Adrian Hunter wrote: >> On 16/03/21 12:22 am, Asutosh Das (asd) wrote: >>> On 3/14/2021 1:11 AM, Adrian Hunter wrote: On 10/03/21 5:04 am, Asutosh Das (asd) wrote: > On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote: >>

Re: [PATCH 0/3] AM64: Add SERDES DT bindings

2021-03-16 Thread Vinod Koul
On 10-03-21, 16:57, Kishon Vijay Abraham I wrote: > Patch series adds device tree bindings to support SERDES in AM64 > platform. > > This is split from [1] since this binding is also required for AM64 > USB DT patches to be merged. > > Vinod, > > Once the 1st patch of the series is reviewed by R

[PATCH] attr: replace if (cond) BUG() with BUG_ON()

2021-03-16 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./fs/attr.c:349:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/attr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/attr.c b/fs/attr.c index 87ef39

[PATCH] mwifiex: Remove unneeded variable: "ret"

2021-03-16 Thread zuoqilin1
From: zuoqilin Remove unneeded variable: "ret" Signed-off-by: zuoqilin --- drivers/net/wireless/marvell/mwifiex/scan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c index c2a685f.

Re: [PATCH] MIPS: fix memory reservation for non-usermem setups

2021-03-16 Thread Mike Rapoport
Hi Ilya, On Tue, Mar 16, 2021 at 10:10:09PM -0700, Ilya Lipnitskiy wrote: > Hi Thomas, > > On Fri, Mar 12, 2021 at 7:19 AM Thomas Bogendoerfer > wrote: > > > > On Sun, Mar 07, 2021 at 11:40:30AM -0800, Ilya Lipnitskiy wrote: > > > From: Tobias Wolf > > > > > > Commit 67a3ba25aa95 ("MIPS: Fix in

[PATCH v13 13/14] mm/vmalloc: Hugepage vmalloc mappings

2021-03-16 Thread Nicholas Piggin
Support huge page vmalloc mappings. Config option HAVE_ARCH_HUGE_VMALLOC enables support on architectures that define HAVE_ARCH_HUGE_VMAP and supports PMD sized vmap mappings. vmalloc will attempt to allocate PMD-sized pages if allocating PMD size or larger, and fall back to small pages if that wa

[PATCH v13 14/14] powerpc/64s/radix: Enable huge vmalloc mappings

2021-03-16 Thread Nicholas Piggin
This reduces TLB misses by nearly 30x on a `git diff` workload on a 2-node POWER9 (59,800 -> 2,100) and reduces CPU cycles by 0.54%, due to vfs hashes being allocated with 2MB pages. Cc: linuxppc-...@lists.ozlabs.org Acked-by: Michael Ellerman Signed-off-by: Nicholas Piggin --- .../admin-guide/

[PATCH v13 10/14] mm/vmalloc: provide fallback arch huge vmap support functions

2021-03-16 Thread Nicholas Piggin
If an architecture doesn't support a particular page table level as a huge vmap page size then allow it to skip defining the support query function. Suggested-by: Christoph Hellwig Signed-off-by: Nicholas Piggin --- arch/arm64/include/asm/vmalloc.h | 7 +++ arch/powerpc/include/asm/vmall

[PATCH v13 12/14] mm/vmalloc: add vmap_range_noflush variant

2021-03-16 Thread Nicholas Piggin
As a side-effect, the order of flush_cache_vmap() and arch_sync_kernel_mappings() calls are switched, but that now matches the other callers in this file. Reviewed-by: Christoph Hellwig Signed-off-by: Nicholas Piggin --- mm/vmalloc.c | 16 +--- 1 file changed, 13 insertions(+), 3 de

[PATCH v13 11/14] mm: Move vmap_range from mm/ioremap.c to mm/vmalloc.c

2021-03-16 Thread Nicholas Piggin
This is a generic kernel virtual memory mapper, not specific to ioremap. Code is unchanged other than making vmap_range non-static. Reviewed-by: Christoph Hellwig Signed-off-by: Nicholas Piggin --- include/linux/vmalloc.h | 3 + mm/ioremap.c| 203 -

[PATCH v13 06/14] mm: HUGE_VMAP arch support cleanup

2021-03-16 Thread Nicholas Piggin
This changes the awkward approach where architectures provide init functions to determine which levels they can provide large mappings for, to one where the arch is queried for each call. This removes code and indirection, and allows constant-folding of dead code for unsupported levels. This also

[PATCH v13 07/14] powerpc: inline huge vmap supported functions

2021-03-16 Thread Nicholas Piggin
This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: linuxppc-...@lists.ozlabs.org Acked-by: Michael Ellerman Signed-off-by: Nicholas Piggin --- arch/powerpc/include/asm/vmalloc.h | 19 ---

[PATCH v13 09/14] x86: inline huge vmap supported functions

2021-03-16 Thread Nicholas Piggin
This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: "H. Peter Anvin" Signed-off-by: Nicholas Piggin --- arch/x86/include/asm/vmallo

[PATCH v13 04/14] mm/vmalloc: rename vmap_*_range vmap_pages_*_range

2021-03-16 Thread Nicholas Piggin
The vmalloc mapper operates on a struct page * array rather than a linear physical address, re-name it to make this distinction clear. Reviewed-by: Miaohe Lin Reviewed-by: Christoph Hellwig Signed-off-by: Nicholas Piggin --- mm/vmalloc.c | 16 1 file changed, 8 insertions(+),

[PATCH v13 08/14] arm64: inline huge vmap supported functions

2021-03-16 Thread Nicholas Piggin
This allows unsupported levels to be constant folded away, and so p4d_free_pud_page can be removed because it's no longer linked to. Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Acked-by: Catalin Marinas Signed-off-by: Nicholas Piggin --- arch/arm64/include/asm

[PATCH v13 05/14] mm/ioremap: rename ioremap_*_range to vmap_*_range

2021-03-16 Thread Nicholas Piggin
This will be used as a generic kernel virtual mapping function, so re-name it in preparation. Reviewed-by: Miaohe Lin Reviewed-by: Christoph Hellwig Signed-off-by: Nicholas Piggin --- mm/ioremap.c | 64 +++- 1 file changed, 33 insertions(+), 31 d

[PATCH v13 03/14] mm: apply_to_pte_range warn and fail if a large pte is encountered

2021-03-16 Thread Nicholas Piggin
apply_to_pte_range might mistake a large pte for bad, or treat it as a page table, resulting in a crash or corruption. Add a test to warn and return error if large entries are found. Reviewed-by: Miaohe Lin Reviewed-by: Christoph Hellwig Signed-off-by: Nicholas Piggin --- mm/memory.c | 66

[PATCH v13 02/14] mm/vmalloc: fix HUGE_VMAP regression by enabling huge pages in vmalloc_to_page

2021-03-16 Thread Nicholas Piggin
vmalloc_to_page returns NULL for addresses mapped by larger pages[*]. Whether or not a vmap is huge depends on the architecture details, alignments, boot options, etc., which the caller can not be expected to know. Therefore HUGE_VMAP is a regression for vmalloc_to_page. This change teaches vmallo

[PATCH v13 01/14] ARM: mm: add missing pud_page define to 2-level page tables

2021-03-16 Thread Nicholas Piggin
ARM uses its own PMD folding scheme which is missing pud_page which should just pass through to pmd_page. Move this from the 3-level page table to common header. Cc: Russell King Cc: Ding Tianhong Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Nicholas Piggin --- arch/arm/include/asm/

[PATCH v13 00/14] huge vmalloc mappings

2021-03-16 Thread Nicholas Piggin
Important compound page fix thanks to Ding Tianhong. Thanks, Nick Since v12: - Use compound pages so it works with remap_vmalloc_range [noticed by Ding] - Fix debug_vm_pgtable.c compile error. Since v11: - ARM compile fix (patch 1) - debug_vm_pgtable compile fix Since v10: - Fixed code style,

{standard input}:3096: Error: operands mismatch -- statement `andl %a1,%d1' ignored

2021-03-16 Thread kernel test robot
Hi Brendan, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1df27313f50a57497c1faeb6a6ae4ca939c85a7d commit: 981f94c3e92146705baf97fb417a5ed1ab1a79a5 bpf: Add bitwise atomic instructions date: 9 weeks ago config:

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-16 Thread Tetsuo Handa
Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. > - Fix attach_store() to check usbip_event_happened() before > waking up threads. No, this helps nothing. > diff --git a/drivers/usb/usbip/vhci_sysfs.c b/driv

RE: [PATCH] exfat: improve write performance when dirsync enabled

2021-03-16 Thread Sungjong Seo
> Degradation of write speed caused by frequent disk access for cluster > bitmap update on every cluster allocation could be improved by selective > syncing bitmap buffer. Change to flush bitmap buffer only for the > directory related operations. > > Signed-off-by: Hyeongseok Kim Looks good. Tha

[PATCH] mwifiex: Remove redundant assignment

2021-03-16 Thread zuoqilin1
From: zuoqilin There is no need to define the err variable, and then assign -EINVAL, we can directly return -EINVAL. Signed-off-by: zuoqilin --- drivers/net/wireless/marvell/mwifiex/ie.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/marvell/mwif

Re: [PATCH] iio:imu:mpu6050: Modify matricies to matrices

2021-03-16 Thread Guoqing Chi
On Tue, 16 Mar 2021 22:04:33 -0700 Randy Dunlap wrote: > On 3/16/21 7:41 PM, Guoqing chi wrote: > > From: Guoqing Chi > > > > The complex number of "matrix" is "matrices". > > (I would say that the plural of matrix is matrices.) Yes??your suggest is better. I will resent patch V2 for this.

Re: [PATCH v2 4/5] mtd: spi-nor: Move Software Write Protection logic out of the core

2021-03-16 Thread Tudor.Ambarus
On 3/15/21 8:23 AM, Vignesh Raghavendra wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 3/9/21 12:58 PM, tudor.amba...@microchip.com wrote: >> On 3/8/21 7:28 PM, Vignesh Raghavendra wrote: >>> EXTERNAL EMAIL: Do not click links or open

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-16 Thread Arjun Roy
On Tue, Mar 16, 2021 at 3:27 AM Johannes Weiner wrote: > > Hello, > > On Mon, Mar 15, 2021 at 09:16:45PM -0700, Arjun Roy wrote: > > From: Arjun Roy > > > > TCP zerocopy receive is used by high performance network applications > > to further scale. For RX zerocopy, the memory containing the netwo

Re: RFC: MEDIA: Driver for ON Semi AR0521 camera sensor

2021-03-16 Thread Krzysztof Hałasa
Laurent Pinchart writes: >> Is there a reliable way to include national unicode characters in the >> kernel sources? > > It depends where. In comments it shouldn't be a problem. In C code, I > don't think the compiler will be too happy. I meant in comments, sure. And in stuff like MODULE_AUTHOR.

Re: [PATCH v6 4/8] dt-bindings: regulator: Add document for MT6359 regulator

2021-03-16 Thread Hsin-hsiung Wang
Hi, Rob I am very grateful for the reviewing which addressed my yaml errors. I will check my codebase first and fix the error in the next patch. Thanks. On Tue, 2021-03-16 at 15:28 -0600, Rob Herring wrote: > On Tue, Mar 16, 2021 at 01:35:53AM +0800, Hsin-Hsiung Wang wrote: > > add dt-binding doc

[PATCH] MIPS: ralink: mt7621: add memory detection support

2021-03-16 Thread Ilya Lipnitskiy
From: Chuanhong Guo mt7621 has the following memory map: 0x0-0x1c00: lower 448m memory 0x1c00-0x200: peripheral registers 0x2000-0x240: higher 64m memory detect_memory_region in arch/mips/kernel/setup.c only adds the first memory region and isn't suitable for 512m memory dete

Re: [PATCH v2] mm: Move mem_init_print_info() into mm_init()

2021-03-16 Thread Kefeng Wang
On 2021/3/17 13:48, Christophe Leroy wrote: Le 17/03/2021 à 02:52, Kefeng Wang a écrit : mem_init_print_info() is called in mem_init() on each architecture, and pass NULL argument, so using void argument and move it into mm_init(). Acked-by: Dave Hansen Signed-off-by: Kefeng Wang --- v2

RE: [PATCH v3] ASoC: amd: add support for rt5682 codec in machine driver

2021-03-16 Thread Shuming [范書銘]
> On 3/16/21 8:37 AM, Mukunda,Vijendar wrote: > > > > > > On 15/03/21 9:30 pm, Pierre-Louis Bossart wrote: > >> > >>> +static int rt5682_clk_enable(struct snd_pcm_substream *substream) { > >>> +    int ret; > >>> +    struct snd_soc_pcm_runtime *rtd = > >>> +asoc_substream_to_rtd(substream); > >>>

Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings

2021-03-16 Thread Kishon Vijay Abraham I
On 17/03/21 1:19 am, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple of cases, fixing t

[PATCH] virtio_net: replace if (cond) BUG() with BUG_ON()

2021-03-16 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/net/virtio_net.c:1551:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/virtio_net.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/

Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings

2021-03-16 Thread Greg Kroah-Hartman
On Tue, Mar 16, 2021 at 01:49:18PM -0600, Rob Herring wrote: > Adding checks for undocumented compatible strings reveals a bunch of > warnings in the DT binding examples. Fix the cases which are typos, just > a mismatch between the schema and the example, or aren't documented at all. > In a couple

Re: (subset) [PATCH v2 0/5] mtd: spi-nor: Cleanup patches

2021-03-16 Thread Tudor Ambarus
On Sat, 6 Mar 2021 11:49:57 +0200, Tudor Ambarus wrote: > Various cleanup patches done while reviewing contributions. > > Tudor Ambarus (5): > mtd: spi-nor: core: Advance erase after the erase cmd has been > completed > mtd: spi-nor: core: Add vdbg msg for spi_nor_erase_multi_sectors() >

Re: [PATCH] dt-bindings: Drop type references on common properties

2021-03-16 Thread Greg Kroah-Hartman
On Tue, Mar 16, 2021 at 01:48:58PM -0600, Rob Herring wrote: > Users of common properties shouldn't have a type definition as the > common schemas already have one. Drop all the unnecessary type > references in the tree. > > A meta-schema update to catch these is pending. > > Cc: Nicolas Saenz Ju

Re: [PATCH] mtd: spi-nor: Update comment about the default flash parameters

2021-03-16 Thread Tudor Ambarus
On Mon, 15 Mar 2021 07:56:34 +0200, Tudor Ambarus wrote: > s/legacy/default. spi_nor_info_init_params initializes some default > flash parameters and settings that can be overwritten when parsing > SFDP, or by fixup hooks. There's nothing legacy about them, they are > just some default settings, if

Re: [PATCH v2] scsi: dt-bindings: ufs: Add sm8250, sm8350 compatible strings

2021-03-16 Thread Vinod Koul
Hello Martin, On 16-03-21, 21:21, Martin K. Petersen wrote: > > Vinod, > > >> Document "qcom,sm8250-ufshc" and "qcom,sm8350-ufshc" compatible string. > >> Use of "qcom,sm8250-ufshc" is already present upstream, so add misiing > >> documentation. "qcom,sm8350-ufshc" is for UFS HC found in SM8350

[syzbot] KMSAN: uninit-value in iptable_mangle_hook (5)

2021-03-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:29ad81a1 arch/x86: add missing include to sparsemem.h git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=179b38f6d0 kernel config: https://syzkaller.appspot.com/x/.co

Re: [PATCH v2] mm: Move mem_init_print_info() into mm_init()

2021-03-16 Thread Christophe Leroy
Le 17/03/2021 à 02:52, Kefeng Wang a écrit : mem_init_print_info() is called in mem_init() on each architecture, and pass NULL argument, so using void argument and move it into mm_init(). Acked-by: Dave Hansen Signed-off-by: Kefeng Wang --- v2: - Cleanup 'str' line suggested by Christophe a

RE: Re: [PATCH v5 05/10] scsi: ufshpb: Region inactivation in host mode

2021-03-16 Thread Daejun Park
>> >> --- >> >> drivers/scsi/ufs/ufshpb.c | 14 ++ >> >> drivers/scsi/ufs/ufshpb.h | 1 + >> >> 2 files changed, 15 insertions(+) >> >> >> >> diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c >> >> index 6f4fd22eaf2f..0744feb4d484 100644 >>

[PATCH] KVM: arm: memcg awareness

2021-03-16 Thread Wanpeng Li
From: Wanpeng Li KVM allocations in the arm kvm code which are tied to the life of the VM process should be charged to the VM process's cgroup. This will help the memcg controler to do the right decisions. Signed-off-by: Wanpeng Li --- arch/arm64/kvm/arm.c | 5 +++-- arch/arm64

Re: A problem of Intel IOMMU hardware ?

2021-03-16 Thread Nadav Amit
> On Mar 16, 2021, at 8:16 PM, Longpeng (Mike, Cloud Infrastructure Service > Product Dept.) wrote: > > Hi guys, > > We find the Intel iommu cache (i.e. iotlb) maybe works wrong in a special > situation, it would cause DMA fails or get wrong data. > > The reproducer (based on Alex's vfio tes

Re: [net PATCH 3/9] octeontx2-af: Do not allocate memory for devlink private

2021-03-16 Thread sundeep subbaraya
On Wed, Mar 17, 2021 at 1:57 AM Jakub Kicinski wrote: > > On Tue, 16 Mar 2021 23:33:40 +0530 sundeep subbaraya wrote: > > On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski wrote: > > > > > > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote: > > > > From: Subbaraya Sundeep > > > > > > > >

Re: [PATCH 04/13] lib: introduce BITS_{FIRST,LAST} macro

2021-03-16 Thread Yury Norov
On Tue, Mar 16, 2021 at 01:42:45PM +0200, Andy Shevchenko wrote: > On Tue, Mar 16, 2021 at 09:35:35AM +0100, Rasmus Villemoes wrote: > > On 16/03/2021 02.54, Yury Norov wrote: > > > BITMAP_{LAST,FIRST}_WORD_MASK() in linux/bitmap.h duplicates the > > > functionality of GENMASK(). The scope of BITMA

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-16 Thread Jyoti Bhayana
Hi Christian, Thanks for the detailed explanation. Sounds good to me. Thanks, Jyoti On Tue, Mar 16, 2021 at 3:22 PM Cristian Marussi wrote: > > Hi Jyoti, > > On Tue, Mar 16, 2021 at 10:51:48AM -0700, Jyoti Bhayana wrote: > > Hi Christian, > > > > Thanks for porting this driver to the new interf

  1   2   3   4   5   6   7   8   9   10   >