Re: [PATCH] scsi: libsas: Reset num_scatter if libata mark qc as NODATA

2021-03-18 Thread John Garry
On 18/03/2021 00:24, Jolly Shah wrote: Hi John, Thanks for the review. On Wed, Mar 17, 2021 at 4:44 AM John Garry wrote: On 16/03/2021 19:39, Jolly Shah wrote: When the cache_type for the scsi device is changed, the scsi layer issues a MODE_SELECT command. The caching mode details are comm

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Dmitry Osipenko
18.03.2021 18:23, Krzysztof Kozlowski пишет: ... >> +mc->debugfs.root = debugfs_create_dir("mc", NULL); >> +if (!mc->debugfs.root) >> +dev_err(&pdev->dev, "failed to create debugfs directory\n"); > > It's error pointer, not null, but anyway there is no need for handling > debug

Re: [PATCH v4 1/3] bus: mhi: core: Introduce internal register poll helper function

2021-03-18 Thread Jeffrey Hugo
On 3/17/2021 3:26 PM, Bhaumik Bhatt wrote: On 2021-03-11 11:59 AM, Jeffrey Hugo wrote: On 3/11/2021 1:00 AM, Loic Poulain wrote: Hi Bhaumik, On Thu, 11 Mar 2021 at 00:31, Bhaumik Bhatt wrote: Introduce helper function to allow MHI core driver to poll for a value in a register field. This h

Re: [PATCH 2/2] arm64: stacktrace: Add skip when task == current

2021-03-18 Thread Catalin Marinas
On Wed, Mar 17, 2021 at 07:34:16PM +, Mark Rutland wrote: > On Wed, Mar 17, 2021 at 06:36:36PM +, Catalin Marinas wrote: > > On Wed, Mar 17, 2021 at 02:20:50PM +, Chen Jun wrote: > > > On ARM64, cat /sys/kernel/debug/page_owner, all pages return the same > > > stack: > > > stack_trace_

Re: [PATCH] mm/page_alloc: try oom if reclaim is unable to make forward progress

2021-03-18 Thread Michal Hocko
On Mon 15-03-21 16:58:37, Aaron Tomlin wrote: > In the situation where direct reclaim is required to make progress for > compaction but no_progress_loops is already over the limit of > MAX_RECLAIM_RETRIES consider invoking the oom killer. What is the problem you are trying to fix? > > Signed-off

Hello linux-kernel@vger.kernel.org

2021-03-18 Thread Dr Chris Hobson
Greetings: linux-kernel@vger.kernel.org I have a business transaction that I will like to discuss with you. Please reply me immediately via my Email: chrishobson...@gmail.com Best regards, Dr Chris Hobson Credit Suisse Bank London.

[PATCH][next] octeontx2-af: Remove redundant initialization of pointer pfvf

2021-03-18 Thread Colin King
From: Colin Ian King The pointer pfvf is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Fixes: 56bcef528bd8 ("octeontx2-af: Use npc_install_flow API for pr

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-18 Thread Hans de Goede
Hi, On 3/12/21 9:11 AM, YingChieh Ho wrote: > From: "Andrea.Ho" > > Advantech sw_button is a ACPI event trigger button. > > With this driver, we can report KEY_EVENT on the > Advantech Tabletop Network Appliances products and it has been > tested in FWA1112VC. > > Add the software define butto

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-18 Thread Alessio Balsini
On Tue, Mar 16, 2021 at 07:53:06PM +0100, Arnd Bergmann wrote: > On Mon, Jan 25, 2021 at 4:48 PM Alessio Balsini wrote: > > > > With a 64-bit kernel build the FUSE device cannot handle ioctl requests > > coming from 32-bit user space. > > This is due to the ioctl command translation that generates

Re: [PATCH 3/3] static_call: Fix static_call_update() sanity check

2021-03-18 Thread Josh Poimboeuf
On Thu, Mar 18, 2021 at 12:31:59PM +0100, Peter Zijlstra wrote: > if (!kernel_text_address((unsigned long)site_addr)) { > - WARN_ONCE(1, "can't patch static call site at > %pS", > + /* > + *

Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap()

2021-03-18 Thread Borislav Petkov
On Thu, Mar 18, 2021 at 08:59:28AM -0700, Yu, Yu-cheng wrote: > Right, do_mmap_pgoff() was removed by commit 45e55300f114. This patch does > not add back the wrapper. Instead, add vm_flags to do_mmap(). Please advice > if I misunderstand the question. I'm just wondering why you even need to ment

Re: [PATCH 2/2] iommu/iova: Improve restart logic

2021-03-18 Thread John Garry
Well yeah, in your particular case you're allocating from a heavily over-contended address space, so much of the time it is genuinely full. Plus you're primarily churning one or two sizes of IOVA, so there's a high chance that you will either allocate immediately from the cached node (after a

Re: [PATCH 05/10] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

2021-03-18 Thread Alessandrelli, Daniele
On Thu, 2021-03-18 at 12:44 +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for > struct ocs_hcu_dma_list. Prototype was for struct ocs_hcu_dma_entry instead > drivers/crypto/keembay/ocs-hcu.c:127:

Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources

2021-03-18 Thread Giovanni Cabiddu
On Thu, Mar 18, 2021 at 03:53:03PM +, Giovanni Cabiddu wrote: > On Fri, Mar 12, 2021 at 11:22:02AM -0500, Tong Zhang wrote: > > adf_vf_isr_resource_alloc() is not unwinding correctly when error > > happens and it trys to release uninitialized resources. Typo: perhaps 'tr

[GIT PULL] iomap: fixes for 5.12-rc4

2021-03-18 Thread Darrick J. Wong
Hi Linus, Please pull this single fix to the iomap code for 5.12-rc4, which fixes some drama when someone gives us a {de,ma}liciously fragmented swap file. The branch merges cleanly with upstream as of a few minutes ago and has been soaking in for-next for a week without complaints. Please let m

Re: [PATCH 2/3] KVM: x86: guest debug: don't inject interrupts while single stepping

2021-03-18 Thread Jan Kiszka
[only saw this now, or delivery to me was delayed - anyway] On 16.03.21 19:02, Maxim Levitsky wrote: > On Tue, 2021-03-16 at 18:01 +0100, Jan Kiszka wrote: >> On 16.03.21 17:50, Sean Christopherson wrote: >>> On Tue, Mar 16, 2021, Maxim Levitsky wrote: On Tue, 2021-03-16 at 16:31 +0100, Jan K

Re: [PATCH net-next v2 2/4] net: ipa: use upper_32_bits()

2021-03-18 Thread Florian Fainelli
On 3/18/2021 6:51 AM, Alex Elder wrote: > Use upper_32_bits() to extract the high-order 32 bits of a DMA > address. This avoids doing a 32-position shift on a DMA address > if it happens not to be 64 bits wide. > > Suggested-by: Florian Fainelli > Signed-off-by: Alex Elder > --- > v2: - Swit

Re: [PATCH v3 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

2021-03-18 Thread Giovanni Cabiddu
On Fri, Mar 12, 2021 at 11:22:03AM -0500, Tong Zhang wrote: > ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown() > before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the > vf2pf_lock is initialized in adf_dev_init(), which can fail and when it > fail, the vf2pf_

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Florian Fainelli
On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > On 18.03.2021 10:09, Wong Vee Khee wrote: >> When using Clause-22 to probe for PHY devices such as the Marvell >> 88E2110, PHY ID with value 0 is read from the MII PHYID registers >> which caused the PHY framework failed to attach the Marvell PHY >>

[PATCH net-next] net: cdc_ncm: drop redundant driver-data assignment

2021-03-18 Thread Johan Hovold
The driver data for the data interface has already been set by usb_driver_claim_interface() so drop the subsequent redundant assignment. Note that this also avoids setting the driver data three times in case of a combined interface. Signed-off-by: Johan Hovold --- drivers/net/usb/cdc_ncm.c | 1

[PATCH][next] mm/vmalloc: fix read of uninitialized pointer area

2021-03-18 Thread Colin King
From: Colin Ian King There is a corner case where the sanity check of variable size fails and branches to label fail and shift can be less than PAGE_SHIFT causing area to never be assigned. This was picked up by static analysis as follows: 1. var_decl: Declaring variable area without initial

Re: [PATCH v10 0/3] Charge loop device i/o to issuing cgroup

2021-03-18 Thread Jens Axboe
On 3/18/21 9:53 AM, Shakeel Butt wrote: > On Wed, Mar 17, 2021 at 3:30 PM Jens Axboe wrote: >> >> On 3/16/21 9:36 AM, Dan Schatzberg wrote: >>> No major changes, just rebasing and resubmitting >> >> Applied for 5.13, thanks. >> > > I have requested a couple of changes in the patch series. Can thi

Re: [RFC PATCH 5/7] iommu/amd: Add support for Guest IO protection

2021-03-18 Thread Joerg Roedel
On Fri, Mar 12, 2021 at 03:04:09AM -0600, Suravee Suthikulpanit wrote: > @@ -519,6 +521,7 @@ struct protection_domain { > spinlock_t lock;/* mostly used to lock the page table*/ > u16 id; /* the domain id written to the device table */ > int glx;

Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap()

2021-03-18 Thread Yu, Yu-cheng
On 3/18/2021 4:42 AM, Borislav Petkov wrote: On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote: There was no more caller passing vm_flags to do_mmap(), and vm_flags was removed from the function's input by: commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pg

Re: [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot"

2021-03-18 Thread Rafael J. Wysocki
On 3/18/2021 6:42 AM, Kai-Heng Feng wrote: On Thu, Mar 18, 2021 at 1:25 AM Josef Bacik wrote: [snipped] "shutdown now" works fine with and without your patch. Thanks, Rafael, Please revert the patch while we are working on it. Done, thanks! Josef, Can you please test the following patch:

[PATCH] audit: log nftables configuration change events once per table

2021-03-18 Thread Richard Guy Briggs
Reduce logging of nftables events to a level similar to iptables. Restore the table field to list the table, adding the generation. Indicate the op as the most significant operation in the event. A couple of sample events: type=PROCTITLE msg=audit(2021-03-18 09:30:49.801:143) : proctitle=/usr/b

[PATCH net] net: cdc-phonet: fix data-interface release on probe failure

2021-03-18 Thread Johan Hovold
Set the disconnected flag before releasing the data interface in case netdev registration fails to avoid having the disconnect callback try to deregister the never registered netdev (and trigger a WARN_ON()). Fixes: 87cf65601e17 ("USB host CDC Phonet network interface driver") Signed-off-by: Johan

Re: [PATCH 08/10] MIPS: disable CONFIG_IDE in malta*_defconfig

2021-03-18 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:04AM +0100, Christoph Hellwig wrote: > arch/mips/configs/malta_kvm_guest_defconfig | 3 --- that file is gone in mips-next. I could take all MIPS patches into mips-next, if you want... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not neces

Re: [PATCH bpf-next v2] bpf: Simplify expression for identify bpf mem type

2021-03-18 Thread Daniel Borkmann
On 3/18/21 7:36 AM, Jianlin Lv wrote: Added BPF_LD_ST_SIZE_MASK macro as mask of size modifier that help to reduce the evaluation of expressions in if statements, and remove BPF_SIZE_MASK in netronome driver. Signed-off-by: Jianlin Lv --- v2: Move the bpf_LD_ST_SIZE_MASK macro definition to inc

[PATCH] workqueue/tracing: Copy workqueue name to buffer in trace event

2021-03-18 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The trace event "workqueue_queue_work" references an unsafe string in dereferencing the name of the workqueue. As the name is allocated, it could later be freed, and the pointer to that string could stay on the tracing buffer. If the trace buffer is read after the

[PATCH] Input: ims-pcu - drop redundant driver-data assignment

2021-03-18 Thread Johan Hovold
The driver data for the data interface has already been set by usb_driver_claim_interface() so drop the subsequent redundant assignment. Signed-off-by: Johan Hovold --- drivers/input/misc/ims-pcu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/mi

Re: [syzbot] BUG: unable to handle kernel access to user memory in sock_ioctl

2021-03-18 Thread Dmitry Vyukov
On Thu, Mar 18, 2021 at 4:35 PM Ben Dooks wrote: > > On 18/03/2021 15:18, Dmitry Vyukov wrote: > > On Mon, Mar 15, 2021 at 3:41 PM Ben Dooks wrote: > >> > >> On 15/03/2021 11:52, Dmitry Vyukov wrote: > >>> On Mon, Mar 15, 2021 at 12:30 PM Ben Dooks > >>> wrote: > > On 14/03/2021 11:03

[PATCH 2/2] USB: core: rename usb_driver_claim_interface() data parameter

2021-03-18 Thread Johan Hovold
It's been almost twenty years since the interface "private data" pointer was removed in favour of using the driver-data pointer of struct device. Let's rename the driver-data parameter of usb_driver_claim_interface() so that it better reflects how it's used. Signed-off-by: Johan Hovold --- driv

[PATCH 1/2] USB: core: drop outdated interface-binding comment

2021-03-18 Thread Johan Hovold
It's been almost twenty years since USB drivers returned a data pointer from their probe routines in order to bind to an interface. Time to update the documentation for usb_driver_claim_interface(). Signed-off-by: Johan Hovold --- drivers/usb/core/driver.c | 4 1 file changed, 4 deletions(

Re: [PATCH v10 0/3] Charge loop device i/o to issuing cgroup

2021-03-18 Thread Shakeel Butt
On Wed, Mar 17, 2021 at 3:30 PM Jens Axboe wrote: > > On 3/16/21 9:36 AM, Dan Schatzberg wrote: > > No major changes, just rebasing and resubmitting > > Applied for 5.13, thanks. > I have requested a couple of changes in the patch series. Can this applied series still be changed or new patches ar

Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources

2021-03-18 Thread Giovanni Cabiddu
On Fri, Mar 12, 2021 at 11:22:02AM -0500, Tong Zhang wrote: > adf_vf_isr_resource_alloc() is not unwinding correctly when error > happens and it trys to release uninitialized resources. > To fix this, only release initialized resources. > > [1.792845] Trying to free already-free IRQ 11 > [

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Connor Kuehl
On 3/18/21 10:17 AM, Miklos Szeredi wrote: I removed the conditional compilation and renamed the limit. Also made virtio_fs_get_tree() bail out if it hit the WARN_ON(). Updated patch below. Thanks, Miklos. I think it looks better with those changes. The virtio_ring patch in this series shou

[PATCH 1/7] USB: cdc-acm: fix double free on probe failure

2021-03-18 Thread Johan Hovold
If tty-device registration fails the driver copy of any Country Selection functional descriptor would end up being freed twice; first explicitly in the error path and then again in the tty-port destructor. Drop the first erroneous free that was left when fixing a tty-port resource leak. Fixes: ca

[PATCH 7/7] USB: cdc-acm: always claim data interface

2021-03-18 Thread Johan Hovold
Make sure to always claim the data interface and bail out if it's already bound to another driver or isn't authorised. Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/c

[PATCH 6/7] USB: cdc-acm: use negation for NULL checks

2021-03-18 Thread Johan Hovold
Use negation consistently throughout the driver for NULL checks. Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index e3c45f5880fc..6991ffd66c5d 100644 -

[PATCH 3/7] USB: cdc-acm: drop redundant driver-data assignment

2021-03-18 Thread Johan Hovold
The interface driver data has already been set by usb_driver_claim_interface() so drop the redundant subsequent assignment. Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c ind

[PATCH 2/7] USB: cdc-acm: fix use-after-free after probe failure

2021-03-18 Thread Johan Hovold
If tty-device registration fails the driver would fail to release the data interface. When the device is later disconnected, the disconnect callback would still be called for the data interface and would go about releasing already freed resources. Fixes: c93d81955005 ("usb: cdc-acm: fix error hand

[PATCH 5/7] USB: cdc-acm: clean up probe error labels

2021-03-18 Thread Johan Hovold
Name the probe error labels after what they do rather than using sequence numbers which is harder to review and maintain (e.g. may require renaming unrelated labels when a label is added or removed). Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 35 ++-

[PATCH 4/7] USB: cdc-acm: drop redundant driver-data reset

2021-03-18 Thread Johan Hovold
There's no need to clear the interface driver data on failed probe (and driver core will clear it anyway). Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 36dd1e05e455..

[PATCH 0/7] USB: cdc-acm: probe fixes

2021-03-18 Thread Johan Hovold
This series fixes a couple of bugs in the probe errors paths and does some clean up in preparation for adding the missing error handling when claiming the data interface. The first two should probably go into 5.12-rc, while the rest could be held off for 5.13 if preferred. Johan Johan Hovold (7

Re: [PATCH v2] seq_file: Unconditionally use vmalloc for buffer

2021-03-18 Thread Kees Cook
On Thu, Mar 18, 2021 at 09:07:45AM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 17, 2021 at 02:30:47PM -0700, Kees Cook wrote: > > On Wed, Mar 17, 2021 at 04:38:57PM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Mar 17, 2021 at 04:20:52PM +0100, Michal Hocko wrote: > > > > On Wed 17-03-21 15:56:

Re: [PATCH 3/3] KVM: SVM: allow to intercept all exceptions for debug

2021-03-18 Thread Joerg Roedel
On Thu, Mar 18, 2021 at 11:24:25AM +0200, Maxim Levitsky wrote: > But again this is a debug feature, and it is intended to allow the user > to shoot himself in the foot. And one can't debug SEV-ES guests with it, so what is the point of enabling it for them too? Regards, Joerg

Re: [RFC PATCH 7/7] iommu/amd: Add support for using AMD IOMMU v2 page table for DMA-API

2021-03-18 Thread Joerg Roedel
On Fri, Mar 12, 2021 at 03:04:11AM -0600, Suravee Suthikulpanit wrote: > Introduce init function for setting up DMA domain for DMA-API with > the IOMMU v2 page table. > > Signed-off-by: Suravee Suthikulpanit > --- > drivers/iommu/amd/iommu.c | 21 + > 1 file changed, 21 inser

Re: [PATCH 1/1] ACPI: fix acpi table use after free

2021-03-18 Thread Rafael J. Wysocki
On Wed, Mar 17, 2021 at 11:28 PM George Kennedy wrote: > > > > On 3/17/2021 4:14 PM, Rafael J. Wysocki wrote: > > On Monday, March 15, 2021 5:19:29 PM CET Rafael J. Wysocki wrote: > >> On Sun, Mar 14, 2021 at 8:00 PM Mike Rapoport wrote: > >>> On Thu, Mar 11, 2021 at 04:36:31PM +0100, Rafael J. W

RE: [PATCH v2 3/4] fs: unicode: Use strscpy() instead of strncpy()

2021-03-18 Thread David Laight
From: Shreeya Patel > Sent: 18 March 2021 14:13 > > On 18/03/21 7:03 pm, Shreeya Patel wrote: > > Following warning was reported by Kernel Test Robot. > > > > In function 'utf8_parse_version', > > inlined from 'utf8_load' at fs/unicode/utf8mod.c:195:7: > >>> fs/unicode/utf8mod.c:175:2: warning: 's

Re: [PATCH v2 1/2] kvm/kvm_util: add _vm_ioctl

2021-03-18 Thread Paolo Bonzini
On 18/03/21 16:16, Emanuele Giuseppe Esposito wrote: As in kvm_ioctl and _kvm_ioctl, add the respective _vm_ioctl for vm_ioctl. _vm_ioctl invokes an ioctl using the vm fd, leaving the caller to test the result. Slightly better subject: "selftests/kvm: add _vm_ioctl". Queued both, but next tim

Re: [PATCH v2 1/1] PCI: pciehp: Skip DLLSC handling if DPC is triggered

2021-03-18 Thread Sinan Kaya
On 3/17/2021 4:02 PM, Kuppuswamy, Sathyanarayanan wrote: > My point is, there is no race in OS handlers (pciehp_ist() vs > pcie_do_recovery()) >  However, Sinan wrote in >> 2018 that one of the issues with hotplug versus DPC is that pciehp >> may turn off slot power and thereby foil DPC recovery. 

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Paolo Bonzini
On 18/03/21 15:56, Emanuele Giuseppe Esposito wrote: Test the KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSR_INDEX_LIST ioctls. Signed-off-by: Emanuele Giuseppe Esposito Looks good, thanks. I queued it with a little extra code to verify KVM_GET_MSR_INDEX_LIST in the case that does not retur

Re: [syzbot] BUG: unable to handle kernel access to user memory in sock_ioctl

2021-03-18 Thread Ben Dooks
On 18/03/2021 15:18, Dmitry Vyukov wrote: On Mon, Mar 15, 2021 at 3:41 PM Ben Dooks wrote: On 15/03/2021 11:52, Dmitry Vyukov wrote: On Mon, Mar 15, 2021 at 12:30 PM Ben Dooks wrote: On 14/03/2021 11:03, Dmitry Vyukov wrote: On Sun, Mar 14, 2021 at 11:01 AM Dmitry Vyukov wrote: On Wed,

Re: [PATCH] fs/exec: fix typos and sentence disorder

2021-03-18 Thread Christian Brauner
On Thu, Mar 18, 2021 at 11:31:45PM +0800, Xiaofeng Cao wrote: > change 'backwords' to 'backwards' > change 'and argument' to 'an argument' > change 'visibile' to 'visible' > change 'wont't' to 'won't' > reorganize sentence > > Signed-off-by: Xiaofeng Cao > --- Reviewed-by: Christian Brauner

Re: [RFC PATCH 6/7] iommu/amd: Introduce amd_iommu_pgtable command-line option

2021-03-18 Thread Joerg Roedel
On Fri, Mar 12, 2021 at 03:04:10AM -0600, Suravee Suthikulpanit wrote: > To allow specification whether to use v1 or v2 IOMMU pagetable for > DMA remapping when calling kernel DMA-API. > > Signed-off-by: Suravee Suthikulpanit > --- > Documentation/admin-guide/kernel-parameters.txt | 6 ++ >

[PATCH] fs/exec: fix typos and sentence disorder

2021-03-18 Thread Xiaofeng Cao
change 'backwords' to 'backwards' change 'and argument' to 'an argument' change 'visibile' to 'visible' change 'wont't' to 'won't' reorganize sentence Signed-off-by: Xiaofeng Cao --- fs/exec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/exec.c b/fs/exec.

Re: [RFC PATCH 4/7] iommu/amd: Initial support for AMD IOMMU v2 page table

2021-03-18 Thread Joerg Roedel
Hi Suravee, On Fri, Mar 12, 2021 at 03:04:08AM -0600, Suravee Suthikulpanit wrote: > @@ -503,6 +504,7 @@ struct amd_io_pgtable { > int mode; > u64 *root; > atomic64_t pt_root;/* pgtable root and pgtable mode */ > + stru

[PATCH 14/15] staging: rtl8723bs: remove unnecessary logging in os_dep/os_intfs.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 977: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:977: + DBG_871X("===> %s.\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1030: FILE: drivers

[PATCH 12/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 239: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:239: + /* DBG_8192C("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 569: FILE: drivers/s

[PATCH 13/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_linux.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1207: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1207: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1507: FILE: drivers/staging/

[PATCH 15/15] staging: rtl8723bs: remove unnecessary logging in os_dep/wifi_regd.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 153: FILE: drivers/staging/rtl8723bs/os_dep/wifi_regd.c:153: + DBG_8192C("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2 -- 1 file cha

[PATCH 08/15] staging: rtl8723bs: remove unnecessary logging in hal/odm.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1109: FILE: drivers/staging/rtl8723bs/hal/odm.c:1109: + /* printk("==> %s\n", __func__); */ Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/hal/odm.c | 2 -- 1 file changed, 2 d

[PATCH 11/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_hal_init.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1685: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1685: +/* DBG_8192C("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1722: FILE: drivers/s

[PATCH 07/15] staging: rtl8723bs: remove unnecessary logging in hal/hal_com_phycfg.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 201: FILE: drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:201: + /* DBG_871X("===>%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 265: FILE: drivers/s

[PATCH 10/15] staging: rtl8723bs: remove unnecessary logging in hal/rtl8723b_cmd.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 129: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c:129: + /* DBG_871X("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 222: FILE: drivers/staging

[PATCH 09/15] staging: rtl8723bs: remove unnecessary logging in hal/odm_debug.h

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 134: FILE: drivers/staging/rtl8723bs/hal/odm_debug.h:134: +#define ODM_dbg_enter() { DbgPrint("==> %s\n", __func__); } -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 135: FILE:

[PATCH 05/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_wlan_util.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1140: FILE: drivers/staging/rtl8723bs/core/rtw_wlan_util.c:1140: + DBG_871X("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 -- 1 fil

[PATCH 06/15] staging: rtl8723bs: remove unnecessary logging in hal/HalBtcOutSrc.h

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 126: FILE: drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h:126: + DbgPrint("%s(): ", __func__);\ and remove the whole unused containing macro BTC_PRINT_F Signed-off-by: Fabio Aiuto

[PATCH 03/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 987: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:987: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1115: FILE: drivers/staging/rtl

[PATCH 04/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_pwrctrl.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 185: FILE: drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:185: + DBG_871X("==>%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 606: FILE: drivers/st

[PATCH 02/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1134: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:1134: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1223: FILE: drivers/stagi

[PATCH 01/15] staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 66: FILE: drivers/staging/rtl8723bs/core/rtw_ap.c:66: + /* DBG_871X("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 559: FILE: drivers/staging/rtl872

RE: [PATCH v2] usb: typec: tcpm: Invoke power_supply_changed for tcpm-source-psy-

2021-03-18 Thread Adam Thomson
On 17 March 2021 18:13, Badhri Jagan Sridharan wrote: > tcpm-source-psy- does not invoke power_supply_changed API when > one of the published power supply properties is changed. > power_supply_changed needs to be called to notify > userspace clients(uevents) and kernel clients. > > Fixes: f2a8aa0

[PATCH 00/15] remove unnecessary logging

2021-03-18 Thread Fabio Aiuto
remove unnsecessary loggings warned by checkpatch Fabio Aiuto (15): staging: rtl8723bs: remove unnecessary logging in core/rtw_ap.c staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme.c staging: rtl8723bs: remove unnecessary logging in core/rtw_mlme_ext.c staging: rtl8723bs: re

Re: [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit

2021-03-18 Thread Arnd Bergmann
On Thu, Mar 18, 2021 at 4:00 PM Laurent Pinchart wrote: > On Thu, Mar 18, 2021 at 02:43:18PM +0100, Arnd Bergmann wrote: > > v4l2_event vs. v4l2_event32 vs. v4l2_event_time32 vs. > v4l2_event32_time32 is a bit confusing. Do I understand correctly that > the code below runs for the non-compat path,

Re: [PATCH v4 4/5] mm: memcontrol: use obj_cgroup APIs to charge kmem pages

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 07:06:57PM +0800, Muchun Song wrote: > Since Roman series "The new cgroup slab memory controller" applied. All > slab objects are charged via the new APIs of obj_cgroup. The new APIs > introduce a struct obj_cgroup to charge slab objects. It prevents > long-living objects fr

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Krzysztof Kozlowski
On 18/03/2021 12:55, Dmitry Osipenko wrote: > Add debug statistics collection support. The statistics is available > via debugfs in '/sys/kernel/debug/mc/stats', it shows percent of memory > controller utilization for each memory client. This information is > intended to help with debugging of memo

Re: [PATCH 1/1] ACPI: fix acpi table use after free

2021-03-18 Thread Rafael J. Wysocki
On Thu, Mar 18, 2021 at 11:50 AM Rafael J. Wysocki wrote: > > On Thu, Mar 18, 2021 at 8:25 AM Mike Rapoport wrote: > > > > On Wed, Mar 17, 2021 at 09:14:37PM +0100, Rafael J. Wysocki wrote: > > > On Monday, March 15, 2021 5:19:29 PM CET Rafael J. Wysocki wrote: > > > > On Sun, Mar 14, 2021 at 8:0

Re: [syzbot] BUG: unable to handle kernel access to user memory in sock_ioctl

2021-03-18 Thread Dmitry Vyukov
On Mon, Mar 15, 2021 at 3:41 PM Ben Dooks wrote: > > On 15/03/2021 11:52, Dmitry Vyukov wrote: > > On Mon, Mar 15, 2021 at 12:30 PM Ben Dooks > > wrote: > >> > >> On 14/03/2021 11:03, Dmitry Vyukov wrote: > >>> On Sun, Mar 14, 2021 at 11:01 AM Dmitry Vyukov wrote: > > On Wed, Mar 10, 2021 a

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Miklos Szeredi
On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > If an incoming FUSE request can't fit on the virtqueue, the request is > placed onto a workqueue so a worker can try to resubmit it later where > there will (hopefully) be space for it next time. > > This is fine for requests that are

Re: [PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Vladimir Oltean
On Thu, Mar 18, 2021 at 03:54:00PM +0100, Heiner Kallweit wrote: > On 18.03.2021 15:23, Michael Walle wrote: > > at803x_aneg_done() is pretty much dead code since the patch series > > "net: phy: improve and simplify phylib state machine" [1]. Remove it. > > > > Well, it's not dead, it's resting .

[PATCH v2 2/2] selftests/kvm: add set_boot_cpu_id test

2021-03-18 Thread Emanuele Giuseppe Esposito
Test for the KVM_SET_BOOT_CPU_ID ioctl. Check that it correctly allows to change the BSP vcpu. v1 -> v2: - remove unnecessary printf - move stage for loop inside run_vcpu - test EBUSY when calling KVM_SET_BOOT_CPU_ID after vcpu creation and execution - introduce _vm_ioctl Signed-off-by: Emanuel

[PATCH v2 1/2] kvm/kvm_util: add _vm_ioctl

2021-03-18 Thread Emanuele Giuseppe Esposito
As in kvm_ioctl and _kvm_ioctl, add the respective _vm_ioctl for vm_ioctl. _vm_ioctl invokes an ioctl using the vm fd, leaving the caller to test the result. Signed-off-by: Emanuele Giuseppe Esposito --- tools/testing/selftests/kvm/include/kvm_util.h | 1 + tools/testing/selftests/kvm/lib/kvm_u

[PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

2021-03-18 Thread Colin King
From: Colin Ian King The 3rd argument to alloc_workqueue should be the max_active count, however currently it is the lo->lo_number that is intended for the loop%d number. Fix this by adding in the missing max_active count. Addresses-Coverity: ("Missing argument to printf") Fixes: 08ad7f822739 ("

Re: [PATCH v5 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-18 Thread Kishon Vijay Abraham I
Hi, On 10/03/21 9:49 pm, Aswath Govindraju wrote: > The following speed modes are now supported in J7200 SoC, > - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. > - UHS-I speed modes in MMCSD1 subsystem [1]. > > Add support for UHS-I modes by adding voltage regulator device

Re: [RESEND PATCH v2] perf stat: improve readability of shadow stats

2021-03-18 Thread Changbin Du
On Tue, Mar 16, 2021 at 02:53:41PM +0100, Jiri Olsa wrote: > On Mon, Mar 15, 2021 at 10:30:47PM +0800, Changbin Du wrote: > > SNIP > > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > > index 6ccf21a72f06..3f800e71126f 100644 > > --- a/tools/perf/util/stat-shadow.c >

Re: [PATCH v4 3/5] mm: memcontrol: change ug->dummy_page only if memcg changed

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 07:06:56PM +0800, Muchun Song wrote: > Just like assignment to ug->memcg, we only need to update ug->dummy_page > if memcg changed. So move it to there. This is a very small optimization. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 08:59:44AM -0400, Phil Auld wrote: > I admit to not having followed all the history of this patch set. That > said, when I see the above I just think your quota is too low for your > workload. This. > The burst (mis?)feature seems to be a way to bypass the quota. And it >

[syzbot] KASAN: use-after-free Read in kill_pending_fw_fallback_reqs

2021-03-18 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6417f031 module: remove never implemented MODULE_SUPPORTED.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16293a7cd0 kernel config: https://syzkaller.appspot.com/x/.config?x=ab2c8a4eaedddecd das

Re: [PATCH v4 2/5] mm: memcontrol: directly access page->memcg_data in mm/page_alloc.c

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 07:06:55PM +0800, Muchun Song wrote: > The page_memcg() is not suitable for use by page_expected_state() and > page_bad_reason(). Because it can BUG_ON() for the slab pages when > CONFIG_DEBUG_VM is enabled. As neither lru, nor kmem, nor slab page > should have anything left

Re: [RFC PATCH v2 1/8] arm64: Implement stack trace termination record

2021-03-18 Thread Mark Brown
On Mon, Mar 15, 2021 at 11:57:53AM -0500, madve...@linux.microsoft.com wrote: > In summary, task pt_regs->stackframe is where a successful stack trace ends. > .if \el == 0 > - mov x29, xzr > + stp xzr, xzr, [sp, #S_STACKFRAME] > .else > stp x29, x22

Re: [PATCH 2/2] media: v4l2-core: explicitly clear ioctl input data

2021-03-18 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Thu, Mar 18, 2021 at 02:43:19PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > As seen from a recent syzbot bug report, mistakes in the compat ioctl > implementation can lead to uninitialized kernel stack data getting used > as input for driver ioctl

Re: [PATCH] memcg: set page->private before calling swap_readpage

2021-03-18 Thread Michal Hocko
On Thu 18-03-21 11:02:17, Johannes Weiner wrote: > On Thu, Mar 18, 2021 at 03:01:25PM +0100, Michal Hocko wrote: > > On Wed 17-03-21 18:59:59, Shakeel Butt wrote: > > > The function swap_readpage() (and other functions it call) extracts swap > > > entry from page->private. However for SWP_SYNCHRONO

Re: [PATCH v2 2/2] mm/memcg: set memcg when split page

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 03:05:00PM +0100, Michal Hocko wrote: > On Thu 11-03-21 12:37:20, Hugh Dickins wrote: > > On Thu, 11 Mar 2021, Michal Hocko wrote: > > > On Thu 11-03-21 10:21:39, Johannes Weiner wrote: > > > > On Thu, Mar 11, 2021 at 09:37:02AM +0100, Michal Hocko wrote: > > > > > Johannes,

Re: [PATCH v3 0/6] Some cleanups for huge_memory

2021-03-18 Thread Peter Xu
On Thu, Mar 18, 2021 at 08:27:16AM -0400, Miaohe Lin wrote: > Hi all, > This series contains cleanups to rework some function logics to make it > more readable, use helper function and so on. More details can be found > in the respective changelogs. Thanks! > > v2->v3: > use ALIGN/ALIGN_DOWN too a

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 09:26:58AM +0800, changhuaixin wrote: > > On Mar 17, 2021, at 4:06 PM, Peter Zijlstra wrote: > > So what is the typical avg,stdev,max and mode for the workloads where you > > find > > you need this? > > > > I would really like to put a limit on the burst. IMO a workload

Re: [PATCH] memcg: set page->private before calling swap_readpage

2021-03-18 Thread Johannes Weiner
On Wed, Mar 17, 2021 at 06:59:59PM -0700, Shakeel Butt wrote: > The function swap_readpage() (and other functions it call) extracts swap > entry from page->private. However for SWP_SYNCHRONOUS_IO, the kernel > skips the swapcache and thus we need to manually set the page->private > with the swap en

Re: [PATCH v2 2/2] mm/memcg: set memcg when split page

2021-03-18 Thread Matthew Wilcox
On Thu, Mar 18, 2021 at 03:05:00PM +0100, Michal Hocko wrote: > On Thu 11-03-21 12:37:20, Hugh Dickins wrote: > > On Thu, 11 Mar 2021, Michal Hocko wrote: > > > On Thu 11-03-21 10:21:39, Johannes Weiner wrote: > > > > On Thu, Mar 11, 2021 at 09:37:02AM +0100, Michal Hocko wrote: > > > > > Johannes,

Re: [PATCH] memcg: set page->private before calling swap_readpage

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 03:01:25PM +0100, Michal Hocko wrote: > On Wed 17-03-21 18:59:59, Shakeel Butt wrote: > > The function swap_readpage() (and other functions it call) extracts swap > > entry from page->private. However for SWP_SYNCHRONOUS_IO, the kernel > > skips the swapcache and thus we nee

<    4   5   6   7   8   9   10   11   12   13   >