Re: [PATCH v3 net-next 00/12] Better support for sandwiched LAGs with bridge and DSA

2021-03-22 Thread Nikolay Aleksandrov
On 21/03/2021 00:34, Vladimir Oltean wrote: > From: Vladimir Oltean > > The objective of this series is to make LAG uppers on top of switchdev > ports work regardless of which order we link interfaces to their masters > (first make the port join the LAG, then the LAG join the bridge, or the >

Re: [Linux-stm32] [PATCH v10 18/33] counter: Return error code on invalid modes

2021-03-22 Thread Fabrice Gasnier
On 3/19/21 12:00 PM, William Breathitt Gray wrote: > Only a select set of modes (function, action, etc.) are valid for a > given device configuration. This patch ensures that invalid modes result > in a return -EINVAL. Such a situation should never occur in reality, but > it's good to define a

Re: [PATCH] target: pscsi: avoid Wempty-body warning

2021-03-22 Thread Willy Tarreau
On Mon, Mar 22, 2021 at 05:18:23PM +0100, Arnd Bergmann wrote: > I agree that this instance of the warning is particularly stupid, but the > I'd like to leave the warning option there and eventually enable it by > default because it tends to find other more interesting cases, and this > one is

Re: [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add pompom rev3

2021-03-22 Thread Matthias Kaehlcke
On Fri, Mar 19, 2021 at 08:12:40AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Mar 15, 2021 at 6:15 PM Matthias Kaehlcke wrote: > > > > The only kernel visible change with respect to rev2 is that pompom > > rev3 changed the charger thermistor from a 47k to a 100k NTC to use > > a thermistor

Re: [PATCHv2 00/38] Convert power-supply DT bindings to YAML

2021-03-22 Thread Rob Herring
On Wed, Mar 17, 2021 at 7:49 AM Sebastian Reichel wrote: > > Hi, > > I keep getting patches for existing drivers, that modify DT behaviour > without updating the binding file. Let's move everything to DT schema > files, so that this can easily be cached automatically by dtbs_check. > > After this

Re: [Linux-stm32] [PATCH v10 17/33] counter: stm32-timer-cnt: Add const qualifier for actions_list array

2021-03-22 Thread Fabrice Gasnier
On 3/19/21 12:00 PM, William Breathitt Gray wrote: > The struct counter_synapse actions_list member expects a const enum > counter_synapse_action array. This patch adds the const qualifier to the > stm32_synapse_actions to match actions_list. > > Cc: Fabrice Gasnier > Cc: Benjamin Gaignard >

Re: [kbuild-all] Re: include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(st

2021-03-22 Thread Oliver Hartkopp
Hi Rong, On 22.03.21 09:52, Rong Chen wrote: On 3/21/21 10:19 PM, Oliver Hartkopp wrote: Two reminders in two days? ;-) Did you check my answer here? https://lore.kernel.org/lkml/afffeb73-ba4c-ca2c-75d0-9e7899e5c...@hartkopp.net/ And did you try the partly revert? Hi Oliver, Sorry for

Re: [Linux-stm32] [PATCH v10 16/33] counter: stm32-lptimer-cnt: Add const qualifier for actions_list array

2021-03-22 Thread Fabrice Gasnier
On 3/19/21 12:00 PM, William Breathitt Gray wrote: > The struct counter_synapse actions_list member expects a const enum > counter_synapse_action array. This patch adds the const qualifier to the > stm32_lptim_cnt_synapse_actions to match actions_list. > > Cc: Fabrice Gasnier > Signed-off-by:

Re: [Linux-stm32] [PATCH v10 11/33] counter: stm32-timer-cnt: Add const qualifier for functions_list array

2021-03-22 Thread Fabrice Gasnier
On 3/19/21 12:00 PM, William Breathitt Gray wrote: > The struct counter_count functions_list member expects a const enum > counter_count_function array. This patch adds the const qualifier to the > stm32_count_functions to match functions_list. > > Cc: Fabrice Gasnier > Cc: Benjamin Gaignard >

Re: [Linux-stm32] [PATCH v10 10/33] counter: stm32-lptimer-cnt: Add const qualifier for functions_list array

2021-03-22 Thread Fabrice Gasnier
On 3/19/21 12:00 PM, William Breathitt Gray wrote: > The struct counter_count functions_list member expects a const enum > counter_count_function array. This patch adds the const qualifier to the > stm32_lptim_cnt_functions to match functions_list. > > Cc: Fabrice Gasnier > Signed-off-by:

[PATCH] atomisp: remove a now unused var

2021-03-22 Thread Mauro Carvalho Chehab
A previous cleanup patch removed the usage of the ret var. So, drop it. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/atomisp-lm3554.c

Re: [PATCH] dax: avoid -Wempty-body warnings

2021-03-22 Thread Dan Williams
On Mon, Mar 22, 2021 at 4:45 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc warns about an empty body in an else statement: > > drivers/dax/bus.c: In function 'do_id_store': > drivers/dax/bus.c:94:48: error: suggest braces around empty body in an 'else' > statement [-Werror=empty-body]

Re: [RFC PATCH v2 net-next 09/16] net: dsa: replay port and local fdb entries when joining the bridge

2021-03-22 Thread Vladimir Oltean
On Mon, Mar 22, 2021 at 04:44:41PM +0100, Tobias Waldekranz wrote: > I do not know if it is a problem or not, more of an observation: This is > not guaranteed to be an exact replay of the events that the bridge port > (i.e. bond0 or whatever) has received since, in fdb_insert, we exit > early when

Re: [PATCH V2] kernel: debug: Ordinary typo fixes in the file gdbstub.c

2021-03-22 Thread Daniel Thompson
On Wed, Mar 17, 2021 at 04:16:58PM +0530, Bhaskar Chowdhury wrote: > s/overwitten/overwritten/ > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury Applied, Thanks! Daniel. > --- > Changes from V1: > As Daniel pointed out, I was misdoing a check,so corrected > >

Re: [PATCH] target: pscsi: avoid Wempty-body warning

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 4:53 PM Willy Tarreau wrote: > On Mon, Mar 22, 2021 at 03:47:35PM +, Christoph Hellwig wrote: > > On Mon, Mar 22, 2021 at 12:44:34PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Building with 'make W=1' shows a harmless warning for pscsi: > > > >

Re: [PATCH 2/2] signal: don't allow STOP on PF_IO_WORKER threads

2021-03-22 Thread Oleg Nesterov
On 03/20, Eric W. Biederman wrote: > > But please tell me why is it not the right thing to have the io_uring > helper threads stop? Why is it ok for that process to go on consuming > cpu resources in a non-stoppable way. Yes, I have the same question ;) Oleg.

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-22 Thread Daniel Thompson
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > Signed-off-by: Konrad Dybcio Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible

2021-03-22 Thread Daniel Thompson
On Sun, Feb 28, 2021 at 01:41:04PM +0100, Konrad Dybcio wrote: > Document the newly added PMI8994 compatible. > > Signed-off-by: Konrad Dybcio (For Lee) Acked-by: Daniel Thompson Daniel. > --- > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + > 1 file changed, 1

[PATCH RESEND] arm64: dts: qcom: Add support for OnePlus 5/5T

2021-03-22 Thread Jami Kettunen
Add device trees for OnePlus 5 (cheeseburger) and 5T (dumpling) MSM8998 SoC smartphones with initial support included for: - UFS internal storage - USB peripheral mode - Display - Touch - Bluetooth - Hall effect sensor - Power and volume buttons - Capacitive keypad button backlight (on

RE: [PATCH 3/5] cifsd: add file operations

2021-03-22 Thread Schaufler, Casey
> -Original Message- > From: Namjae Jeon > Sent: Sunday, March 21, 2021 10:14 PM > To: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > c...@vger.kernel.org > Cc: linux-cifsd-de...@lists.sourceforge.net; smfre...@gmail.com; > senozhat...@chromium.org;

Re: [PATCH 2/2] signal: don't allow STOP on PF_IO_WORKER threads

2021-03-22 Thread Oleg Nesterov
On 03/20, Jens Axboe wrote: > > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -2349,6 +2349,10 @@ static bool do_signal_stop(int signr) > > t = current; > while_each_thread(current, t) { > + /* don't STOP PF_IO_WORKER threads */ > +

Re: [PATCH v5] kdb: Simplify kdb commands registration

2021-03-22 Thread Daniel Thompson
On Wed, Feb 24, 2021 at 12:38:27PM +0530, Sumit Garg wrote: > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg Applied, thanks! > --- > > Changes in v5: > - Introduce new method: kdb_register_table() to

[PATCH v2] infiniband: Fix a use after free in isert_connect_request

2021-03-22 Thread Lv Yunlong
The device is got by isert_device_get() with refcount is 1, and is assigned to isert_conn by isert_conn->device = device. When isert_create_qp() failed, device will be freed with isert_device_put(). Later, the device is used in isert_free_login_buf(isert_conn) by the isert_conn->device->ib_device

[PATCH resend] jfs: fix use-after-free in lbmIODone

2021-03-22 Thread Anirudh Rayabharam
Fix use-after-free by waiting for ongoing IO to complete before freeing lbufs in lbmLogShutdown. Add a counter in struct jfs_log to keep track of the number of in-flight IO operations and a wait queue to wait on for the IO operations to complete. Reported-by:

Re: [PATCH v1 3/3] kernel/resource: remove first_lvl / siblings_only logic

2021-03-22 Thread Dan Williams
On Mon, Mar 22, 2021 at 9:03 AM David Hildenbrand wrote: > > All IORESOURCE_SYSTEM_RAM and IORESOURCE_MEM now properly consider the > whole resource tree, not just the first level. Let's drop the unused > first_lvl / siblings_only logic. > > All functions properly search the whole tree, so remove

Re: [PATCH v3 1/1] ACPI: scan: Use unique number for instance_no

2021-03-22 Thread Andy Shevchenko
On Mon, Mar 22, 2021 at 5:42 PM Rafael J. Wysocki wrote: > On Mon, Mar 22, 2021 at 4:02 PM Andy Shevchenko > wrote: > > On Mon, Mar 22, 2021 at 4:57 PM Rafael J. Wysocki wrote: > > > On Fri, Mar 19, 2021 at 8:21 PM Andy Shevchenko > > > wrote: > > > > > > > > The decrementation of

Re: [PATCH v1 1/3] kernel/resource: make walk_system_ram_res() find all busy IORESOURCE_SYSTEM_RAM resources

2021-03-22 Thread Dan Williams
On Mon, Mar 22, 2021 at 9:02 AM David Hildenbrand wrote: > > It used to be true that we can have busy system RAM only on the first level > in the resourc tree. However, this is no longer holds for driver-managed > system RAM (i.e., added via dax/kmem and virtio-mem), which gets added on > lower

Re: [PATCH 05/11] staging: rtl8723bs: remove argument in recv_indicatepkts_pkt_loss_cnt

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:43PM +0100, Fabio Aiuto wrote: > remove debug_priv argument so function prototype can be > easily moved away > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_recv.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > >

Re: [PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources

2021-03-22 Thread Dan Williams
On Mon, Mar 22, 2021 at 9:02 AM David Hildenbrand wrote: > > It used to be true that we can have system RAM only on the first level > in the resourc tree. However, this is no longer holds for driver-managed > system RAM (i.e., dax/kmem and virtio-mem). > > The function walk_mem_res() only

Re: [PATCH 04/11] staging: rtl8723bs: moved function prototypes out of core/rtw_recv.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:42PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 1190: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:1190: > +signed int validate_recv_mgnt_frame(struct adapter *padapter, union > recv_frame

Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig

2021-03-22 Thread John Paul Adrian Glaubitz
On 3/22/21 4:15 PM, Russell King - ARM Linux admin wrote: > I'm quite surprised that the CY82C693 even works on Alpha - I've > asked for a lspci for that last week but nothing has yet been > forthcoming from whoever responded to your patch for Alpha - so I > can't compare what I'm seeing with

Re: [PATCH 03/11] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:41PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40: > +u8 rtw_do_join(struct adapter *padapter); > > WARNING: externs should be

[ANNOUNCE] 4.14.226-rt109

2021-03-22 Thread Clark Williams
Hello RT-list! I'm pleased to announce the 4.14.226-rt109 stable release. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.14-rt Head SHA1: 1c0dfa8fb024ce1b6725636c1462bef2406b860c Or to build 4.14.226-rt109

Re: [PATCH] target: pscsi: avoid Wempty-body warning

2021-03-22 Thread Matthew Wilcox
On Mon, Mar 22, 2021 at 12:44:34PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1' shows a harmless warning for pscsi: > > drivers/target/target_core_pscsi.c: In function 'pscsi_complete_cmd': > drivers/target/target_core_pscsi.c:624:33: error: suggest braces

Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > +bool > > moved two function prototypes in include/rtw_efuse.h > > Signed-off-by:

Re: [RFC PATCH v2 net-next 14/16] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge

2021-03-22 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > DSA has gained the recent ability to deal gracefully with upper > interfaces it cannot offload, such as the bridge, bonding or team > drivers. When such uppers exist, the ports are still in standalone mode > as far as

Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks

2021-03-22 Thread Oleg Nesterov
On 03/20, Jens Axboe wrote: > > Hi, > > Been trying to ensure that we do the right thing wrt signals and > PF_IO_WORKER threads OMG. Am I understand correctly? create_io_thread() can create a sub- thread of userspace process which acts as a kernel thread? Looks like this is the recent feature I

Re: [PATCH 11/11] staging: rtl8723bs: remove unnecessary extern in os_dep/sdio_intf.c

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 03:31:49PM +0100, Fabio Aiuto wrote: > remove unnecessary extern. > > The function is defined static in os_dep/os_intfs.c and used only once > in the same file > > remove also a blank line That needs to go to a separate patch :(

Re: [PATCH] Bluetooth: Remove trailing semicolon in macros

2021-03-22 Thread Marcel Holtmann
Hi Meng, > 1. remove trailing semicolon in macros; > 2. fix some coding style. > > Signed-off-by: Meng Yu > --- > net/bluetooth/smp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) the patch doesn’t apply to bluetooth-next, please re-base and send again. Regards Marcel

[PATCH 02/11] x86: tboot: avoid Wstringop-overread-warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about using string operations on pointers that are defined at compile time as offsets from a NULL pointer. Unfortunately that also happens on the result of fix_to_virt(), which is a compile-time constant for a constantn input: arch/x86/kernel/tboot.c: In

Re: [PATCH] Bluetooth: hci_qca: Mundane typo fix

2021-03-22 Thread Marcel Holtmann
Hi Bhaskar, > s/packat/packet/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/bluetooth/hci_qca.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel

[PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns that intel_dp_check_mst_status() has a local array of fourteen bytes and passes the last four bytes into a function that expects a six-byte array: drivers/gpu/drm/i915/display/intel_dp.c: In function ‘intel_dp_check_mst_status’:

Re: [PATCH V4 06/10] x86/fault: Adjust WARN_ON for PKey fault

2021-03-22 Thread Sean Christopherson
On Sun, Mar 21, 2021, ira.we...@intel.com wrote: > From: Ira Weiny > > PKey faults may now happen on kernel mappings if the feature is enabled. > Remove the warning in the fault path if PKS is enabled. When/why can they happen? I read through all the changelogs, as well as the cover letters

[PATCH 09/11] scsi: lpfc: fix gcc -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about an strnlen with a length larger than the size of the passed buffer: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_nvme_info_show': drivers/scsi/lpfc/lpfc_attr.c:518:25: error: 'strnlen' specified bound 4095 exceeds source size 24

[PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about what appears to be an out-of-range array access: In function ‘snb_wm_latency_quirk’, inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3108:3: drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’ reading 16

Re: [PATCH] staging: rtl8723bs: Mundane typo fixes

2021-03-22 Thread Greg KH
On Mon, Mar 22, 2021 at 12:58:08PM +0530, Bhaskar Chowdhury wrote: > > s/stoping/stooping/ Huh? Are you _sure_ that is the correct replacement? Last I looked it wasn't... greg k-h

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Ard Biesheuvel
On Mon, 22 Mar 2021 at 16:57, Ard Biesheuvel wrote: > > On Mon, 22 Mar 2021 at 14:26, Will Deacon wrote: > > > > On Fri, 19 Mar 2021 18:41:06 +, Mark Rutland wrote: > > > We recently converted arm64 to use arch_stack_walk() in commit: > > > > > > 5fc57df2f6fd ("arm64: stacktrace: Convert

[PATCH 03/11] security: commoncap: fix -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 introdces a harmless warning for cap_inode_getsecurity: security/commoncap.c: In function ‘cap_inode_getsecurity’: security/commoncap.c:440:33: error: ‘memcpy’ reading 16 bytes from a region of size 0 [-Werror=stringop-overread] 440 |

[PATCH 08/11] atmel: avoid gcc -Wstringop-overflow warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 notices that the fields as defined in the ass_req_format structure do not match the actual use of that structure: cc1: error: writing 4 bytes into a region of size between 18446744073709551613 and 2 [-Werror=stringop-overflow=]

[PATCH 05/11] qnx: avoid -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns that the size of the link name is longer than the di_fname field: fs/qnx4/dir.c: In function ‘qnx4_readdir’: fs/qnx4/dir.c:51:32: error: ‘strnlen’ specified bound 48 exceeds source size 16 [-Werror=stringop-overread] 51 | size =

[PATCH 04/11] ath11: Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 with the kernel address sanitizer prints a warning for this driver: In function 'ath11k_peer_assoc_h_vht', inlined from 'ath11k_peer_assoc_prepare' at drivers/net/wireless/ath/ath11k/mac.c:1632:2: drivers/net/wireless/ath/ath11k/mac.c:1164:13: error:

[PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann When cgroups are enabled, but every single subsystem is turned off, CGROUP_SUBSYS_COUNT is zero, and the cgrp->subsys[] array has no members. gcc-11 points out that this leads to an invalid access in any function that might access this array: kernel/cgroup/cgroup.c: In

[PATCH 07/11] ARM: sharpsl_param: work around -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc warns that accessing a pointer based on a numeric constant may be an offset into a NULL pointer, and would therefore has zero accessible bytes: arch/arm/common/sharpsl_param.c: In function ‘sharpsl_save_param’: arch/arm/common/sharpsl_param.c:43:9: error: ‘memcpy’

[PATCH 00/11] treewide: address gcc-11 -Wstringop-overread warnings

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann The coming gcc release introduces a new warning for string operations reading beyond the end of a fixed-length object. After testing randconfig kernels for a while, think I have patches for any such warnings that came up on x86, arm and arm64. Most of these warnings are

[PATCH 01/11] x86: compressed: avoid gcc-11 -Wstringop-overread warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc gets confused by the comparison of a pointer to an integer listeral, with the assumption that this is an offset from a NULL pointer and that dereferencing it is invalid: In file included from arch/x86/boot/compressed/misc.c:18: In function ‘parse_elf’, inlined from

[PATCH v1 3/3] kernel/resource: remove first_lvl / siblings_only logic

2021-03-22 Thread David Hildenbrand
All IORESOURCE_SYSTEM_RAM and IORESOURCE_MEM now properly consider the whole resource tree, not just the first level. Let's drop the unused first_lvl / siblings_only logic. All functions properly search the whole tree, so remove documentation that indicates that some functions behave differently.

[PATCH v1 1/3] kernel/resource: make walk_system_ram_res() find all busy IORESOURCE_SYSTEM_RAM resources

2021-03-22 Thread David Hildenbrand
It used to be true that we can have busy system RAM only on the first level in the resourc tree. However, this is no longer holds for driver-managed system RAM (i.e., added via dax/kmem and virtio-mem), which gets added on lower levels. We have two users of walk_system_ram_res(), which currently

[PATCH v1 2/3] kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM resources

2021-03-22 Thread David Hildenbrand
It used to be true that we can have system RAM only on the first level in the resourc tree. However, this is no longer holds for driver-managed system RAM (i.e., dax/kmem and virtio-mem). The function walk_mem_res() only consideres the first level and is used in

[PATCH v1 0/3] kernel/resource: make walk_system_ram_res() and walk_mem_res() search the whole tree

2021-03-22 Thread David Hildenbrand
be updated to consider this memory in the kexec_load() case when processing /proc/iomem. Against next-20210322. David Hildenbrand (3): kernel/resource: make walk_system_ram_res() find all busy IORESOURCE_SYSTEM_RAM resources kernel/resource: make walk_mem_res() find all busy IORESOURCE_MEM

Re: [PATCH v3 net-next 07/12] net: dsa: sync ageing time when joining the bridge

2021-03-22 Thread Florian Fainelli
On 3/20/2021 3:34 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is only emitted from: > > sysfs/ioctl/netlink > -> br_set_ageing_time >-> __set_ageing_time > > therefore not at bridge port creation time, so: > (a) drivers had

Re: [PATCH] Bluetooth: verify AMP hci_chan before amp_destroy

2021-03-22 Thread Marcel Holtmann
Hi Archie, > hci_chan can be created in 2 places: hci_loglink_complete_evt() if > it is an AMP hci_chan, or l2cap_conn_add() otherwise. In theory, > Only AMP hci_chan should be removed by a call to > hci_disconn_loglink_complete_evt(). However, the controller might mess > up, call that function,

Re: [PATCH] Bluetooth: Set CONF_NOT_COMPLETE as l2cap_chan default

2021-03-22 Thread Marcel Holtmann
Hi Archie, > Currently l2cap_chan_set_defaults() reset chan->conf_state to zero. > However, there is a flag CONF_NOT_COMPLETE which is set when > creating the l2cap_chan. It is suggested that the flag should be > cleared when l2cap_chan is ready, but when l2cap_chan_set_defaults() > is called,

RE: [EXT] Re: [V2 net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-22 Thread Stefan Chulski
> > 2. CM3 code has very small footprint requirement, we cannot > > implement the complete Serdes and PHY infrastructure that kernel > > provides as part of CM3 application. Therefore I would like to > > continue relying on kernel configuration for that. > > How can that work? How does Linux

Re: [RFC PATCH v2 net-next 15/16] net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag_join

2021-03-22 Thread Tobias Waldekranz
On Fri, Mar 19, 2021 at 01:18, Vladimir Oltean wrote: > From: Vladimir Oltean > > The DSA core has a layered structure, and even though we end up > returning 0 (success) to user space when setting a bonding/team upper > that can't be offloaded, some parts of the framework actually need to > know

Re: [PATCH] arm64: stacktrace: don't trace arch_stack_walk()

2021-03-22 Thread Ard Biesheuvel
On Mon, 22 Mar 2021 at 14:26, Will Deacon wrote: > > On Fri, 19 Mar 2021 18:41:06 +, Mark Rutland wrote: > > We recently converted arm64 to use arch_stack_walk() in commit: > > > > 5fc57df2f6fd ("arm64: stacktrace: Convert to ARCH_STACKWALK") > > > > The core stacktrace code expects that

Re: [RFC PATCH v2 net-next 08/16] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-22 Thread Florian Fainelli
On 3/20/2021 2:53 AM, Vladimir Oltean wrote: > On Fri, Mar 19, 2021 at 03:20:38PM -0700, Florian Fainelli wrote: >> >> >> On 3/18/2021 4:18 PM, Vladimir Oltean wrote: >>> From: Vladimir Oltean >>> >>> I have udhcpcd in my system and this is configured to bring interfaces >>> up as soon as they

Re: [EXT] [PATCH] linux/qed: Mundane spelling fixes throughout the file

2021-03-22 Thread Igor Russkikh
> s/unrequired/"not required"/ > s/consme/consume/ .two different places > s/accros/across/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Igor Russkikh Thanks Igor

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

2021-03-22 Thread Daniel Lezcano
On 04/03/2021 08:37, Tony Lindgren wrote: > There is a timer wrap issue on dra7 for the ARM architected timer. > In a typical clock configuration the timer fails to wrap after 388 days. > > To work around the issue, we need to use timer-ti-dm timers instead. > > Let's prepare for adding support

Re: [PATCH] target: pscsi: avoid Wempty-body warning

2021-03-22 Thread Willy Tarreau
On Mon, Mar 22, 2021 at 03:47:35PM +, Christoph Hellwig wrote: > On Mon, Mar 22, 2021 at 12:44:34PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Building with 'make W=1' shows a harmless warning for pscsi: > > > > drivers/target/target_core_pscsi.c: In function

Re: [PATCH 2/2] mm: memcontrol: deprecate swapaccounting=0 mode

2021-03-22 Thread Johannes Weiner
On Fri, Mar 19, 2021 at 05:37:05PM -0700, Hugh Dickins wrote: > On Fri, 19 Mar 2021, Johannes Weiner wrote: > > > The swapaccounting= commandline option already does very little > > today. To close a trivial containment failure case, the swap ownership > > tracking part of the swap controller has

[PATCH v2 5/8] USB: cdc-acm: clean up probe error labels

2021-03-22 Thread Johan Hovold
Name the probe error labels after what they do rather than using sequence numbers which is harder to review and maintain (e.g. may require renaming unrelated labels when a label is added or removed). Acked-by: Oliver Neukum Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 35

[PATCH v2 6/8] USB: cdc-acm: use negation for NULL checks

2021-03-22 Thread Johan Hovold
Use negation consistently throughout the driver for NULL checks. Acked-by: Oliver Neukum Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index

[PATCH v2 7/8] USB: cdc-acm: always claim data interface

2021-03-22 Thread Johan Hovold
Make sure to always claim the data interface and bail out if binding fails. Note that the driver had a check to verify that the data interface was not already bound to a driver but would not detect other failures (e.g. if the interface was not authorised). Signed-off-by: Johan Hovold ---

[PATCH v2 3/8] USB: cdc-acm: drop redundant driver-data assignment

2021-03-22 Thread Johan Hovold
The interface driver data has already been set by usb_driver_claim_interface() so drop the redundant subsequent assignment. Acked-by: Oliver Neukum Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c

[PATCH v2 8/8] USB: cdc-acm: do not log successful probe on later errors

2021-03-22 Thread Johan Hovold
Do not log the successful-probe message until the tty device has been registered. Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index

[PATCH v2 4/8] USB: cdc-acm: drop redundant driver-data reset

2021-03-22 Thread Johan Hovold
There's no need to clear the interface driver data on failed probe (and driver core will clear it anyway). Acked-by: Oliver Neukum Signed-off-by: Johan Hovold --- drivers/usb/class/cdc-acm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/class/cdc-acm.c

Re: [PATCH] Bluetooth: check for zapped sk before connecting

2021-03-22 Thread Marcel Holtmann
Hi Archie, > There is a possibility of receiving a zapped sock on > l2cap_sock_connect(). This could lead to interesting crashes, one > such case is tearing down an already tore l2cap_sock as is happened > with this call trace: > > __dump_stack lib/dump_stack.c:15 [inline] >

[PATCH v2 2/8] USB: cdc-acm: fix use-after-free after probe failure

2021-03-22 Thread Johan Hovold
If tty-device registration fails the driver would fail to release the data interface. When the device is later disconnected, the disconnect callback would still be called for the data interface and would go about releasing already freed resources. Fixes: c93d81955005 ("usb: cdc-acm: fix error

[PATCH v2 0/8] USB: cdc-acm: probe fixes

2021-03-22 Thread Johan Hovold
This series fixes a couple of bugs in the probe errors paths and does some clean up in preparation for adding the missing error handling when claiming the data interface. The first two should probably go into 5.12-rc, while the rest could be held off for 5.13 if preferred. Johan Changes in v2

[PATCH v2 1/8] USB: cdc-acm: fix double free on probe failure

2021-03-22 Thread Johan Hovold
If tty-device registration fails the driver copy of any Country Selection functional descriptor would end up being freed twice; first explicitly in the error path and then again in the tty-port destructor. Drop the first erroneous free that was left when fixing a tty-port resource leak. Fixes:

Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-22 Thread Pierre-Louis Bossart
As you suggested,I should add the alignment change in another patch. But if i keep the old alignment, the code will be very odd. Seems like that I have to change the below code to new alignment in this patch. if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) &&    

Re: [RFC PATCH v2 net-next 15/16] net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag_join

2021-03-22 Thread Florian Fainelli
On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The DSA core has a layered structure, and even though we end up > returning 0 (success) to user space when setting a bonding/team upper > that can't be offloaded, some parts of the framework actually need to > know that

[RESEND PATCH v10 4/7] fpga: sec-mgr: expose sec-mgr update errors

2021-03-22 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an update/error sysfs node that can be read for error information when a secure update fails. Signed-off-by: Russ Weight Reviewed-by: Tom Rix --- v10: - Rebased to 5.12-rc2 next - Updated Date and KernelVersion in ABI documentation

[RESEND PATCH v10 5/7] fpga: sec-mgr: expose sec-mgr update size

2021-03-22 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an update/remaining_size sysfs node that can be read to determine how much data remains to be transferred to the secure update engine. This file can be used to monitor progress during the "writing" phase of an update. Signed-off-by: Russ

[RESEND PATCH v10 7/7] fpga: sec-mgr: expose hardware error info

2021-03-22 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an optional update/hw_errinfo sysfs node that can be used to retrieve 64 bits of device specific error information following a secure update failure. The underlying driver must provide a get_hw_errinfo() callback function to enable this

[RESEND PATCH v10 3/7] fpga: sec-mgr: expose sec-mgr update status

2021-03-22 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an update/status sysfs node that can be polled and read to monitor the progress of an ongoing secure update. Sysfs_notify() is used to signal transitions between different phases of the update process. Signed-off-by: Russ Weight

[RESEND PATCH v10 6/7] fpga: sec-mgr: enable cancel of secure update

2021-03-22 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an update/cancel sysfs file that can be written to request that an update be canceled. The write may return EBUSY if the update has progressed to the point that it cannot be canceled by software or ENODEV if there is no update in progress.

[RESEND PATCH v10 2/7] fpga: sec-mgr: enable secure updates

2021-03-22 Thread Russ Weight
Extend the FPGA Security Manager class driver to include an update/filename sysfs node that can be used to initiate a secure update. The filename of a secure update file (BMC image, FPGA image, Root Entry Hash image, or Code Signing Key cancellation image) can be written to this sysfs entry to

[RESEND PATCH v10 1/7] fpga: sec-mgr: fpga security manager class driver

2021-03-22 Thread Russ Weight
Create the FPGA Security Manager class driver. The security manager provides interfaces to manage secure updates for the FPGA and BMC images that are stored in FLASH. The driver can also be used to update root entry hashes and to cancel code signing keys. The image type is encoded in the image

[RESEND PATCH v10 0/7] FPGA Security Manager Class Driver

2021-03-22 Thread Russ Weight
The FPGA Security Manager class driver provides a common API for user-space tools to manage updates for secure FPGA devices. Device drivers that instantiate the FPGA Security Manager class driver will interact with a HW secure update engine in order to transfer new FPGA and BMC images to FLASH so

Re: Re: Re: [PATCH] infiniband: Fix a use after free in isert_connect_request

2021-03-22 Thread lyl2019
> -原始邮件- > 发件人: "Leon Romanovsky" > 发送时间: 2021-03-22 23:31:08 (星期一) > 收件人: lyl2...@mail.ustc.edu.cn > 抄送: s...@grimberg.me, dledf...@redhat.com, j...@ziepe.ca, > linux-r...@vger.kernel.org, target-de...@vger.kernel.org, > linux-kernel@vger.kernel.org > 主题: Re: Re: [PATCH] infiniband:

Re: [PATCH] target: pscsi: avoid Wempty-body warning

2021-03-22 Thread Christoph Hellwig
On Mon, Mar 22, 2021 at 12:44:34PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with 'make W=1' shows a harmless warning for pscsi: > > drivers/target/target_core_pscsi.c: In function 'pscsi_complete_cmd': > drivers/target/target_core_pscsi.c:624:33: error: suggest braces

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-22 Thread Stefan Hajnoczi
On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > If an incoming FUSE request can't fit on the virtqueue, the request is > placed onto a workqueue so a worker can try to resubmit it later where > there will (hopefully) be space for it next time. > > This is fine for requests that

Re: [PATCH 1/2] mtd: spi-nor: sfdp: save a copy of the SFDP data

2021-03-22 Thread Michael Walle
Am 2021-03-22 16:32, schrieb Michael Walle: + + sfdp->num_dwords = DIV_ROUND_UP(sfdp_size, sizeof(*sfdp->dwords)); The SFDP spec says that Parameter Table Pointer should be DWORD aligned and Parameter Table length is specified in number of DWORDs. So, sfdp_size should always be a

Re: [PATCH tip/core/rcu 2/3] rcu: Provide polling interfaces for Tiny RCU grace periods

2021-03-22 Thread Paul E. McKenney
On Sun, Mar 21, 2021 at 11:28:55PM +0100, Frederic Weisbecker wrote: > On Wed, Mar 03, 2021 at 04:26:31PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a non-blocking polling interface for RCU grace > > periods, so this commit supplies

Re: [RFC PATCH v2 net-next 09/16] net: dsa: replay port and local fdb entries when joining the bridge

2021-03-22 Thread Tobias Waldekranz
On Fri, Mar 19, 2021 at 01:18, Vladimir Oltean wrote: > From: Vladimir Oltean > > When a DSA port joins a LAG that already had an FDB entry pointing to it: > > ip link set bond0 master br0 > bridge fdb add dev bond0 00:01:02:03:04:05 master static > ip link set swp0 master bond0 > > the DSA port

Re: [PATCH v6 5/5] mm,page_alloc: Drop unnecessary checks from pfn_range_valid_contig

2021-03-22 Thread Michal Hocko
On Fri 19-03-21 14:20:04, Oscar Salvador wrote: > pfn_range_valid_contig() bails out when it finds an in-use page or a > hugetlb page, among other things. > We can drop the in-use page check since __alloc_contig_pages can migrate > away those pages, and the hugetlb page check can go too since >

Re: arm64 syzbot instances

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 2:53 PM Peter Maydell wrote: > On Sun, 21 Mar 2021 at 19:00, Arnd Bergmann wrote: > > On Sat, Mar 20, 2021 at 9:43 PM Peter Maydell > > wrote: > > > On Fri, 12 Mar 2021 at 09:16, Arnd Bergmann wrote: > > > > So it's probably qemu that triggers the 'synchronous external

Re: [PATCH v3 0/2] AM64: Add support for GPIO

2021-03-22 Thread Nishanth Menon
On Fri, 19 Mar 2021 10:49:48 +0530, Aswath Govindraju wrote: > The following series of patches adds support for gpio on AM642 evm/sk. > > GPIO test logs, > AM642-evm: https://pastebin.ubuntu.com/p/PCGmY34spb/ > AM642-sk: https://pastebin.ubuntu.com/p/nrxzyQTKkX/ > > Changes since v2: > -

[PATCH 1/2] ima: don't access a file's integrity status before an IMA policy is loaded

2021-03-22 Thread Mimi Zohar
Only after an IMA policy is loaded, check, save, or update the cached file's integrity status. Signed-off-by: Mimi Zohar --- security/integrity/ima/ima_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index

<    4   5   6   7   8   9   10   11   12   13   >