[PATCH] vfio: fix virtio-pci dependency

2024-01-08 Thread Arnd Bergmann
From: Arnd Bergmann The new vfio-virtio driver already has a dependency on VIRTIO_PCI_ADMIN_LEGACY, but that is a bool symbol and allows vfio-virtio to be built-in even if virtio-pci itself is a loadable module. This leads to a link failure: aarch64-linux-ld: drivers/vfio/pci/virtio/main.o: in

Re: [PATCH 5/5] LoongArch: Add pv ipi support on LoongArch system

2024-01-08 Thread kernel test robot
Hi Bibo, kernel test robot noticed the following build warnings: [auto build test WARNING on 610a9b8f49fbcf1100716370d3b5f6f884a2835a] url: https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-KVM-Add-hypercall-instruction-emulation-support/20240103-151946 base:

Re: linux-next: Tree for Jan 8 (drivers/vfio/pci/virtio/main.o)

2024-01-08 Thread Randy Dunlap
On 1/7/24 21:09, Stephen Rothwell wrote: > Hi all, > > News: the merge window has opened, so please do not add any material > intended for v6.9 to your linux-next included branches until asfter > v6.8-rc1 has been released. > > Changes since 20240105: > on powerpc 64-bit: when

Re: REGRESSION: lockdep warning triggered by 15b9ce7ecd: virtio_balloon: stay awake while adjusting balloon

2024-01-08 Thread David Stevens
On Tue, Jan 9, 2024 at 6:50 AM Theodore Ts'o wrote: > > Hi, while doing final testing before sending a pull request, I merged > in linux-next, and commit 5b9ce7ecd7: virtio_balloon: stay awake while > adjusting balloon seems to be causing a lockdep warning (see attached) > when running

Re: [PATCH v6 01/12] cgroup/misc: Add per resource callbacks for CSS events

2024-01-08 Thread Haitao Huang
On Wed, 15 Nov 2023 14:25:59 -0600, Jarkko Sakkinen wrote: On Mon Oct 30, 2023 at 8:20 PM EET, Haitao Huang wrote: From: Kristen Carlson Accardi The misc cgroup controller (subsystem) currently does not perform resource type specific action for Cgroups Subsystem State (CSS) events: the

Re: possible deadlock in __perf_install_in_context

2024-01-08 Thread Steven Rostedt
This is related to perf not tracing. -- Steve On Tue, 09 Jan 2024 08:34:15 +0800 "Ubisectech Sirius" wrote: > Dear concerned. > Greetings! > We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. > Recently, our team has discovered a issue in Linux kernel

Re: [PATCH RFT] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam

2024-01-08 Thread Dmitry Baryshkov
On Mon, 8 Jan 2024 at 16:23, Luca Weiss wrote: > > On Mon Jan 8, 2024 at 3:18 PM CET, Konrad Dybcio wrote: > > On 8.01.2024 14:49, Luca Weiss wrote: > > > When num-channels and qcom,num-ees is not provided in devicetree, the > > > driver will try to read these values from the registers during

Re: [PATCH] tracing user_events: Simplify user_event_parse_field() parsing

2024-01-08 Thread Steven Rostedt
On Mon, 8 Jan 2024 17:13:12 -0500 Steven Rostedt wrote: > On Mon, 8 Jan 2024 21:47:44 + > Beau Belgrave wrote: > > > > - len = str_has_prefix(field, "__rel_loc "); > > > - if (len) > > > - goto skip_next; > > > + if (!(len = str_has_prefix(field, "__data_loc unsigned ")) && > > > +

Re: [PATCH] tracing user_events: Simplify user_event_parse_field() parsing

2024-01-08 Thread Steven Rostedt
On Mon, 8 Jan 2024 21:47:44 + Beau Belgrave wrote: > > - len = str_has_prefix(field, "__rel_loc "); > > - if (len) > > - goto skip_next; > > + if (!(len = str_has_prefix(field, "__data_loc unsigned ")) && > > + !(len = str_has_prefix(field, "__data_loc ")) && > > +

REGRESSION: lockdep warning triggered by 15b9ce7ecd: virtio_balloon: stay awake while adjusting balloon

2024-01-08 Thread Theodore Ts'o
Hi, while doing final testing before sending a pull request, I merged in linux-next, and commit 5b9ce7ecd7: virtio_balloon: stay awake while adjusting balloon seems to be causing a lockdep warning (see attached) when running gce-xfstests on a Google Compute Engine e2 VM. I was not able to trigger

Re: [PATCH] tracing user_events: Simplify user_event_parse_field() parsing

2024-01-08 Thread Beau Belgrave
On Mon, Jan 08, 2024 at 01:37:23PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Instead of having a bunch of if statements with: > >len = str_has_prefix(field, "__data_loc unsigned "); >if (len) >goto skip_next; > >len =

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2024-01-08 Thread Christophe JAILLET
Le 08/01/2024 à 14:10, Mikhail Golubev-Ciuchea a écrit : From: Harald Mommer - CAN Control - "ip link set up can0" starts the virtual CAN controller, - "ip link set up can0" stops the virtual CAN controller - CAN RX Receive CAN frames. CAN frames can be standard or extended,

[PATCH] tracing user_events: Simplify user_event_parse_field() parsing

2024-01-08 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Instead of having a bunch of if statements with: len = str_has_prefix(field, "__data_loc unsigned "); if (len) goto skip_next; len = str_has_prefix(field, "__data_loc "); if (len) goto skip_next;

Re: [PATCH v8 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-08 Thread Mathieu Poirier
On Thu, 4 Jan 2024 at 09:14, Tanmay Shah wrote: > > > On 1/3/24 12:17 PM, Mathieu Poirier wrote: > > On Fri, Dec 15, 2023 at 03:57:25PM -0800, Tanmay Shah wrote: > > > ZynqMP TCM information is fixed in driver. Now ZynqMP TCM information > > > > s/"is fixed in driver"/"was fixed in driver" > > >

Re: [PATCH net-next 2/6] page_frag: unify gfp bits for order 3 page allocation

2024-01-08 Thread Alexander Duyck
On Mon, Jan 8, 2024 at 12:25 AM Yunsheng Lin wrote: > > On 2024/1/5 23:35, Alexander H Duyck wrote: > > On Wed, 2024-01-03 at 17:56 +0800, Yunsheng Lin wrote: > >> Currently there seems to be three page frag implementions > >> which all try to allocate order 3 page, if that fails, it > >> then

Re: [PATCH v2] virtiofs: use GFP_NOFS when enqueuing request through kworker

2024-01-08 Thread Benjamin Coddington
On 5 Jan 2024, at 5:53, Hou Tao wrote: > From: Hou Tao > > When invoking virtio_fs_enqueue_req() through kworker, both the > allocation of the sg array and the bounce buffer still use GFP_ATOMIC. > Considering the size of both the sg array and the bounce buffer may be > greater than PAGE_SIZE,

Re: [PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

2024-01-08 Thread Alexander Duyck
On Mon, Jan 8, 2024 at 1:06 AM Yunsheng Lin wrote: > > On 2024/1/6 0:06, Alexander H Duyck wrote: > >> > >> static void handle_tx_copy(struct vhost_net *net, struct socket *sock) > >> @@ -1353,8 +1318,7 @@ static int vhost_net_open(struct inode *inode, > >> struct file *f) > >>

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-08 Thread Steven Rostedt
On Mon, 8 Jan 2024 12:32:46 +0100 Christian Brauner wrote: > On Sun, Jan 07, 2024 at 01:32:28PM -0500, Steven Rostedt wrote: > > On Sun, 7 Jan 2024 13:29:12 -0500 > > Steven Rostedt wrote: > > > > > > > > > > IOW, the inode_permission() in lookup_one_len() that eventfs does is > > > >

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-08 Thread Steven Rostedt
On Mon, 8 Jan 2024 12:04:54 +0100 Christian Brauner wrote: > > > IOW, the inode_permission() in lookup_one_len() that eventfs does is > > > redundant and just wrong. > > > > I don't think so. > > I'm very well aware that the dentries and inode aren't created during > mkdir but the

Re: [PATCH] tracing histograms: Simplify parse_actions() function

2024-01-08 Thread Steven Rostedt
On Mon, 8 Jan 2024 10:32:14 +0200 Andy Shevchenko wrote: > On Mon, Jan 8, 2024 at 3:31 AM Steven Rostedt wrote: > > > > From: "Steven Rostedt (Google)" > > > > The parse_actions() function uses 'len = str_has_prefix()' to test which > > action is in the string being parsed. But then it goes

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-08 Thread Mark Rutland
On Mon, Jan 08, 2024 at 02:21:03PM +, Mark Rutland wrote: > On Mon, Jan 08, 2024 at 12:25:55PM +, Mark Rutland wrote: > > We also have HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, but since the return address > > is > > not on the stack at the point function-entry is intercepted we use the FP as > >

Re: [PATCH RFT] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam

2024-01-08 Thread Luca Weiss
On Mon Jan 8, 2024 at 3:18 PM CET, Konrad Dybcio wrote: > On 8.01.2024 14:49, Luca Weiss wrote: > > When num-channels and qcom,num-ees is not provided in devicetree, the > > driver will try to read these values from the registers during probe but > > this fails if the interconnect is not on and

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-08 Thread Mark Rutland
On Mon, Jan 08, 2024 at 12:25:55PM +, Mark Rutland wrote: > We also have HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, but since the return address is > not on the stack at the point function-entry is intercepted we use the FP as > the retp value -- in the absence of tail calls this will be different

Re: [PATCH RFT] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam

2024-01-08 Thread Konrad Dybcio
On 8.01.2024 14:49, Luca Weiss wrote: > When num-channels and qcom,num-ees is not provided in devicetree, the > driver will try to read these values from the registers during probe but > this fails if the interconnect is not on and then crashes the system. > > So we can provide these properties

[PATCH RFT] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam

2024-01-08 Thread Luca Weiss
/* FIXME: dependency BAM DMA is disabled */ - status = "disabled"; }; ipa: ipa@1e4 { --- base-commit: 0dd3ee31125508cd67f7e7172247f05b7fd1753a change-id: 20240108-sm8350-qce-6ada49f90657 Best regards, -- Luca Weiss

Re: [PATCH v9] bus: mhi: host: Add tracing support

2024-01-08 Thread Krishna Chaitanya Chundru
Hi Steven, Even though I added your reviewed-by tag, I incorporated changes mentioned in the previous patch. Can you please review it once. Thanks & Regards, Krishna Chaitanya. On 1/5/2024 5:53 PM, Krishna chaitanya chundru wrote: This change adds ftrace support for following functions

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2024-01-08 Thread Tobias Huschle
On Thu, Dec 14, 2023 at 02:14:59AM -0500, Michael S. Tsirkin wrote: > > Peter, would appreciate feedback on this. When is cond_resched() > insufficient to give up the CPU? Should > Documentation/kernel-hacking/hacking.rst > be updated to require schedule() instead? > Happy new year everybody!

[PATCH v5] can: virtio: Initial virtio CAN driver.

2024-01-08 Thread Mikhail Golubev-Ciuchea
From: Harald Mommer - CAN Control - "ip link set up can0" starts the virtual CAN controller, - "ip link set up can0" stops the virtual CAN controller - CAN RX Receive CAN frames. CAN frames can be standard or extended, classic or CAN FD. Classic CAN RTR frames are supported. - CAN TX

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-08 Thread Mark Rutland
Hi, There's a bit more of an info-dump below; I'll go try to dump the fgraph shadow stack so that we can analyse this in more detail. On Mon, Jan 08, 2024 at 10:14:36AM +0900, Masami Hiramatsu wrote: > On Fri, 5 Jan 2024 17:09:10 + > Mark Rutland wrote: > > > On Mon, Dec 18, 2023 at

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-08 Thread Christian Brauner
On Sun, Jan 07, 2024 at 01:32:28PM -0500, Steven Rostedt wrote: > On Sun, 7 Jan 2024 13:29:12 -0500 > Steven Rostedt wrote: > > > > > > > IOW, the inode_permission() in lookup_one_len() that eventfs does is > > > redundant and just wrong. > > > > I don't think so. > > Just to make it clear.

Re: [PATCH] tracefs/eventfs: Use root and instance inodes as default ownership

2024-01-08 Thread Christian Brauner
> > * Tracefs supports the creation of instances from userspace via mkdir. > > For example, > > > > mkdir /sys/kernel/tracing/instances/foo > > > > And here the idmapping is relevant so we need to make the helpers > > aware of the idmapping. > > > > I just went and plumbed this

Re: [PATCH net-next 4/6] vhost/net: remove vhost_net_page_frag_refill()

2024-01-08 Thread Yunsheng Lin
On 2024/1/6 0:06, Alexander H Duyck wrote: >> >> static void handle_tx_copy(struct vhost_net *net, struct socket *sock) >> @@ -1353,8 +1318,7 @@ static int vhost_net_open(struct inode *inode, struct >> file *f) >> vqs[VHOST_NET_VQ_RX]); >> >> f->private_data = n; >>

Re: [PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-08 Thread Daniel Baluta
On Fri, Jan 5, 2024 at 6:02 PM Ulf Hansson wrote: > > Updates in v2: > - Ccing Daniel Baluta and Iuliana Prodan the NXP remoteproc patches to > requests help with testing. > - Fixed NULL pointer bug in patch1, pointed out by Nikunj. > - Added some

Re: [PATCH] tracing histograms: Simplify parse_actions() function

2024-01-08 Thread Andy Shevchenko
On Mon, Jan 8, 2024 at 3:31 AM Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > The parse_actions() function uses 'len = str_has_prefix()' to test which > action is in the string being parsed. But then it goes and repeats the > logic for each different action. This logic can be

Re: [PATCH net-next 2/6] page_frag: unify gfp bits for order 3 page allocation

2024-01-08 Thread Yunsheng Lin
On 2024/1/5 23:35, Alexander H Duyck wrote: > On Wed, 2024-01-03 at 17:56 +0800, Yunsheng Lin wrote: >> Currently there seems to be three page frag implementions >> which all try to allocate order 3 page, if that fails, it >> then fail back to allocate order 0 page, and each of them >> all allow