[PATCH v6 13/13] tracing: Add last boot delta offset for stack traces

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The addresses of a stack trace event are relative to the kallsyms. As that can change between boots, when printing the stack trace from a buffer that was from the last boot, it needs all the addresses to be added to the "text_delta" that gives the delta between

[PATCH v6 12/13] tracing: Update function tracing output for previous boot buffer

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" For a persistent ring buffer that is saved across boots, if function tracing was performed in the previous boot, it only saves the address of the functions and uses "%pS" to print their names. But the current boot, those functions may be in different locations.

[PATCH v6 11/13] tracing: Handle old buffer mappings for event strings and functions

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Use the saved text_delta and data_delta of a persistent memory mapped ring buffer that was saved from a previous boot, and use the delta in the trace event print output so that strings and functions show up normally. That is, for an event like trace_kmalloc()

[PATCH v6 10/13] tracing/ring-buffer: Add last_boot_info file to boot instance

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" If an instance is mapped to memory on boot up, create a new file called "last_boot_info" that will hold information that can be used to properly parse the raw data in the ring buffer. It will export the delta of the addresses for text and data from what it was

[PATCH v6 08/13] tracing: Add option to use memmapped memory for trace boot instance

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Add an option to the trace_instance kernel command line parameter that allows it to use the reserved memory from memmap boot parameter. memmap=12M$0x28450 trace_instance=boot_mapped@0x28450:12M The above will reserves 12 megs at the physical address

[PATCH v6 09/13] ring-buffer: Save text and data locations in mapped meta data

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" When a ring buffer is mapped to a specific address, save the address of a text function and some data. This will be used to determine the delta between the last boot and the current boot for pointers to functions as well as to data. Signed-off-by: Steven Rostedt

[PATCH v6 06/13] ring-buffer: Add test if range of boot buffer is valid

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Add a test against the ring buffer memory range to see if it has valid data. The ring_buffer_meta structure is given a new field called "first_buffer" which holds the address of the first sub-buffer. This is used to both determine if the other fields are valid as

[PATCH v6 07/13] ring-buffer: Validate boot range memory events

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Make sure all the events in each of the sub-buffers that were mapped in a memory region are valid. This moves the code that walks the buffers for time-stamp validation out of the CONFIG_RING_BUFFER_VALIDATE_TIME_DELTAS ifdef block and is used to validate the

[PATCH v6 05/13] ring-buffer: Add output of ring buffer meta page

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Add a buffer_meta per-cpu file for the trace instance that is mapped to boot memory. This shows the current meta-data and can be used by user space tools to record off the current mappings to help reconstruct the ring buffer after a reboot. It does not expose any

[PATCH v6 03/13] ring-buffer: Add ring_buffer_meta data

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Populate the ring_buffer_meta array. It holds the pointer to the head_buffer (next to read), the commit_buffer (next to write) the size of the sub-buffers, number of sub-buffers and an array that keeps track of the order of the sub-buffers. This information will

[PATCH v6 04/13] tracing: Implement creating an instance based on a given memory region

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Allow for creating a new instance by passing in an address and size to map the ring buffer for the instance to. This will allow features like a pstore memory mapped region to be used for an tracing instance ring buffer that can be retrieved from one boot to the

[PATCH v6 02/13] ring-buffer: Add ring_buffer_alloc_range()

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" In preparation to allowing the trace ring buffer to be allocated in a range of memory that is persistent across reboots, add ring_buffer_alloc_range(). It takes a contiguous range of memory and will split it up evenly for the per CPU ring buffers. If there's not

[PATCH v6 01/13] ring-buffer: Allow mapped field to be set without mapping

2024-06-12 Thread Steven Rostedt
From: "Steven Rostedt (Google)" In preparation for having the ring buffer mapped to a dedicated location, which will have the same restrictions as user space memory mapped buffers, allow it to use the "mapped" field of the ring_buffer_per_cpu structure without having the user space meta page

[PATCH v6 00/13] tracing: Persistent traces across a reboot or crash

2024-06-12 Thread Steven Rostedt
This is a way to map a ring buffer instance across reboots. The requirement is that you have a memory region that is not erased. I tested this on a Debian VM running on qemu on a Debian server, and even tested it on a baremetal box running Fedora. I was surprised that it worked on the baremetal

Re: [PATCH] nvdimm: make nd_class constant

2024-06-12 Thread Ira Weiny
Greg Kroah-Hartman wrote: > On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote: > > Greg Kroah-Hartman wrote: > > > Now that the driver core allows for struct class to be in read-only > > > memory, we should make all 'class' structures declared at build time > > > placing them into

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-06-12 Thread Sean Christopherson
On Wed, Jun 12, 2024, Sean Christopherson wrote: > On Fri, Apr 19, 2024, Will Deacon wrote: > > On Thu, Apr 18, 2024 at 12:53:26PM -0700, Sean Christopherson wrote: > > > On Thu, Apr 18, 2024, Will Deacon wrote: > > > > > I assume the idea would be to let arch code do single-page > > > > >

Re: [PATCH 05/14] tracefs: replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-12 Thread Steven Rostedt
On Wed, 12 Jun 2024 16:09:40 +0200 "Jason A. Donenfeld" wrote: > > > > I think "Depends-on" is the way to go, as it is *not* a stable thing, and > > what is in stable rules is only about stable patches. > > How does "Depends-on" not spiral out of control? There's a *lot* of > "Depends-on"

[PATCH bpf-next v5 06/12] bpf: Make bpf_session_cookie() kfunc return long *

2024-06-12 Thread Daniel Xu
We will soon be generating kfunc prototypes from BTF. As part of that, we need to align the manual signatures in bpf_kfuncs.h with the actual kfunc definitions. There is currently a conflicting signature for bpf_session_cookie() w.r.t. return type. The original intent was to return long * and not

Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During Shutdown/Reboot

2024-06-12 Thread Steven Rostedt
On Wed, 12 Jun 2024 15:36:22 +0200 "Linux regression tracking (Thorsten Leemhuis)" wrote: > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily accessible to everyone. > > Ilkka or Steven, what happened to this? This thread looks stalled. I >

Re: [f2fs-dev] [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-06-12 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Steven Rostedt (Google) : On Thu, 16 May 2024 13:34:54 -0400 you wrote: > From: "Steven Rostedt (Google)" > > [ >This is a treewide change. I will likely re-create this patch again in >the second week of the merge window of

Re: [PATCH v3 01/34] ftrace: Unpoison ftrace_regs in ftrace_ops_list_func()

2024-06-12 Thread Ilya Leoshkevich
On Tue, 2024-01-02 at 10:17 -0500, Steven Rostedt wrote: > On Thu, 14 Dec 2023 00:24:21 +0100 > Ilya Leoshkevich wrote: > > > Architectures use assembly code to initialize ftrace_regs and call > > ftrace_ops_list_func(). Therefore, from the KMSAN's point of view, > > ftrace_regs is poisoned on

Re: [PATCH] nvdimm: make nd_class constant

2024-06-12 Thread Dan Williams
Greg Kroah-Hartman wrote: > On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote: > > Greg Kroah-Hartman wrote: > > > Now that the driver core allows for struct class to be in read-only > > > memory, we should make all 'class' structures declared at build time > > > placing them into

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-06-12 Thread Sean Christopherson
On Fri, Apr 19, 2024, Will Deacon wrote: > On Thu, Apr 18, 2024 at 12:53:26PM -0700, Sean Christopherson wrote: > > On Thu, Apr 18, 2024, Will Deacon wrote: > > > > I assume the idea would be to let arch code do single-page > > > > invalidations of > > > > stage-2 entries for each gfn? > > > > >

Re: [PATCH v2 1/2] rust: add static_key_false

2024-06-12 Thread Conor Dooley
On Mon, Jun 10, 2024 at 02:01:04PM +, Alice Ryhl wrote: > Add just enough support for static key so that we can use it from > tracepoints. Tracepoints rely on `static_key_false` even though it is > deprecated, so we add the same functionality to Rust. > > It is not possible to use the

Re: [PATCH v5 0/2] misc: fastrpc: FastRPC reserved memory assignment for SDM845 SLPI

2024-06-12 Thread Srinivas Kandagatla
On Fri, 24 May 2024 18:14:01 +0200, Dylan Van Assche wrote: > * About * > > The Qualcomm SDM845 SoC has a separate SLPI (Sensor Low Power Island) > DSP for sensors connected to the SoC which is responsible for exposing > sensors to userspace, power saving, and other features. > While sensors

[PATCH 5/5] rtla: Documentation: Add --disable-idle-states

2024-06-12 Thread tglozar
From: Tomas Glozar Add --disable-idle-states to manpage and mention libcpupower dependency in README.txt. Signed-off-by: Tomas Glozar --- Documentation/tools/rtla/common_timerlat_options.rst | 6 ++ tools/tracing/rtla/README.txt| 4 2 files changed, 10

[PATCH 4/5] rtla/timerlat: Add --disable-idle-states for hist

2024-06-12 Thread tglozar
From: Tomas Glozar Support disabling idle states also for timerlat-hist. Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/timerlat_hist.c | 35 +- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/tools/tracing/rtla/src/timerlat_hist.c

[PATCH 3/5] rtla/timerlat: Add --disable-idle-states for top

2024-06-12 Thread tglozar
From: Tomas Glozar Add option to disable idle states on CPUs where timerlat is running for the duration of the workload. Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/timerlat_top.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git

[PATCH 2/5] rtla/utils: Add idle state disabling via libcpupower

2024-06-12 Thread tglozar
From: Tomas Glozar Add functions to utils.c to disable idle states through functions of libcpupower. This will serve as the basis for disabling idle states per cpu when running timerlat. Signed-off-by: Tomas Glozar --- tools/tracing/rtla/src/utils.c | 133 +

[PATCH 1/5] rtla: Add dependency on libcpupower

2024-06-12 Thread tglozar
From: Tomas Glozar Add a test for libcpupower into feature tests and use it to add a dependency on libcpupower to rtla. Signed-off-by: Tomas Glozar --- tools/build/Makefile.feature | 1 + tools/build/feature/Makefile | 4 tools/build/feature/test-libcpupower.c | 8

[PATCH 0/5] rtla: Support idle state disabling via libcpupower in timerlat

2024-06-12 Thread tglozar
From: Tomas Glozar rtla-timerlat allows reducing latency on wake up from idle by setting /dev/cpu_dma_latency during the timerlat measurement. This has an effect on the idle states of all CPUs, including those which are not used by timerlat. Add option --disable-idle-states that disables all

Re: [PATCH v5 01/13] ring-buffer: Allow mapped field to be set without mapping

2024-06-12 Thread Steven Rostedt
On Tue, 11 Jun 2024 22:16:43 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > In preparation for having the ring buffer mapped to a dedicated location, > which will have the same restrictions as user space memory mapped buffers, > allow it to use the "mapped" field of the

Re: [PATCH] rtla/osnoise: Better report when histogram is empty

2024-06-12 Thread John Kacur
On Wed, 12 Jun 2024, Luis Claudio R. Goncalves wrote: > When osnoise hist does not observe any samples above the threshold, > no entries are recorded and the final report shows empty entries > for the usual statistics (count, min, max, avg): > > [~]# osnoise hist -d 5s -T 500 > # RTLA

Re: [PATCH 05/14] tracefs: replace call_rcu by kfree_rcu for simple kmem_cache_free callback

2024-06-12 Thread Jason A. Donenfeld
On Tue, Jun 11, 2024 at 10:14:58AM -0400, Steven Rostedt wrote: > On Tue, 11 Jun 2024 10:42:28 +0200 > Vlastimil Babka wrote: > > > AFAICS that documented way is for a different situation? I assume you mean > > this part: > > > > * Specify any additional patch prerequisites for cherry picking::

Re: [PATCH 1/1] s390/virtio_ccw: fix config change notifications

2024-06-12 Thread Thomas Huth
On 11/06/2024 23.47, Halil Pasic wrote: Commit e3e9bda38e6d ("s390/virtio_ccw: use DMA handle from DMA API") broke configuration change notifications for virtio-ccw by putting the DMA address of *indicatorp directly into ccw->cda disregarding the fact that if !!(vcdev->is_thinint) then the

Re: Bug in Kernel 6.8.x, 6.9.x Causing Trace/Panic During Shutdown/Reboot

2024-06-12 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. Ilkka or Steven, what happened to this? This thread looks stalled. I also was unsuccessful when looking for other threads related to this report or the culprit. Did it fall

Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-12 Thread Aleksandr Mishin
On 11.06.2024 19:45, Mathieu Poirier wrote: On Mon, Jun 10, 2024 at 08:36:19PM +0300, Fedor Pchelkin wrote: On Mon, 10. Jun 10:47, Mathieu Poirier wrote: On Thu, Jun 06, 2024 at 10:52:04AM +0300, Aleksandr Mishin wrote: In imx_rproc_addr_init() "nph = of_count_phandle_with_args()" just

[PATCH] remoteproc: imx_rproc: Fix refcount mistake in imx_rproc_addr_init

2024-06-12 Thread Aleksandr Mishin
In imx_rproc_addr_init() strcmp() is performed over the node after the of_node_put() is performed over it. Fix this error by moving of_node_put() calls. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 5e4c1243071d ("remoteproc: imx_rproc: support remote cores booted

[PATCH] rtla/osnoise: Better report when histogram is empty

2024-06-12 Thread Luis Claudio R. Goncalves
When osnoise hist does not observe any samples above the threshold, no entries are recorded and the final report shows empty entries for the usual statistics (count, min, max, avg): [~]# osnoise hist -d 5s -T 500 # RTLA osnoise histogram # Time unit is microseconds (us) #

Re: [PATCH] nvdimm: make nd_class constant

2024-06-12 Thread Greg Kroah-Hartman
On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote: > Greg Kroah-Hartman wrote: > > Now that the driver core allows for struct class to be in read-only > > memory, we should make all 'class' structures declared at build time > > placing them into read-only memory, instead of having to be

Re: [PATCH V2 2/2] soc: qcom: smp2p: Introduce tracepoint support

2024-06-12 Thread Deepak Kumar Singh
On 6/12/2024 4:35 AM, Chris Lew wrote: On 6/11/2024 5:33 AM, Sudeepgoud Patil wrote: This commit introduces tracepoint support for smp2p, enabling logging of communication between local and remote processors. The tracepoints include information about the remote processor ID, remote

Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-12 Thread Fedor Pchelkin
On Tue, 11. Jun 10:45, Mathieu Poirier wrote: > On Mon, Jun 10, 2024 at 08:36:19PM +0300, Fedor Pchelkin wrote: > > Btw, there is a "rsc-table" node->name check in the the end of the loop > > body. It was added recently with commit 5e4c1243071d ("remoteproc: > > imx_rproc: support remote cores

Re: [PATCH v4 net-next 1/7] net: add rx_sk to trace_kfree_skb

2024-06-12 Thread Jesper Dangaard Brouer
On 11/06/2024 22.11, Yan Zhai wrote: skb does not include enough information to find out receiving sockets/services and netns/containers on packet drops. In theory skb->dev tells about netns, but it can get cleared/reused, e.g. by TCP stack for OOO packet lookup. Similarly, skb->sk often

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Jiri Pirko
Wed, Jun 12, 2024 at 09:15:44AM CEST, m...@redhat.com wrote: >On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: >> Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: >> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: >> >> Add new UAPI to support the mac address from vdpa

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: > Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: > >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: > >> Add new UAPI to support the mac address from vdpa tool > >> Function vdpa_nl_cmd_dev_config_set_doit() will get the

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Michael S. Tsirkin
On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > Add new UAPI to support the mac address from vdpa tool The patch does not do what commit log says. Instead there's an internal API to set mac and a UAPI to write into config space. > Function vdpa_nl_cmd_dev_config_set_doit() will get

Re: [PATCHv8 bpf-next 0/9] uprobe: uretprobe speed up

2024-06-12 Thread Andrii Nakryiko
On Tue, Jun 11, 2024 at 3:52 PM Masami Hiramatsu wrote: > > On Tue, 11 Jun 2024 13:21:49 +0200 > Jiri Olsa wrote: > > > hi, > > as part of the effort on speeding up the uprobes [0] coming with > > return uprobe optimization by using syscall instead of the trap > > on the uretprobe trampoline. >

[PATCH V2] net: qrtr: ns: Ignore ENODEV failures in ns

2024-06-12 Thread Sarannya S
From: Chris Lew Ignore the ENODEV failures returned by kernel_sendmsg(). These errors indicate that either the local port has been closed or the remote has gone down. Neither of these scenarios are fatal and will eventually be handled through packets that are later queued on the control port.

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Jiri Pirko
Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: >> Add new UAPI to support the mac address from vdpa tool >> Function vdpa_nl_cmd_dev_config_set_doit() will get the >> MAC address from the vdpa tool and then set it to the device. >>