Re: [PATCH] vhost/vsock: always initialize seqpacket_allow

2024-06-26 Thread 박정준
nice patch > 2024. 5. 16. 오전 12:05, Michael S. Tsirkin 작성: > > There are two issues around seqpacket_allow: > 1. seqpacket_allow is not initialized when socket is > created. Thus if features are never set, it will be > read uninitialized. > 2. if VIRTIO_VSOCK_F_SEQPACKET is set and then cle

Re: [PATCH] remoteproc: mediatek: Increase MT8188 SCP core0 DRAM size

2024-06-26 Thread 陳建豪
Hi Mathieu, Sorry for the late response. On Mon, 2024-06-10 at 10:34 -0600, Mathieu Poirier wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Thu, Jun 06, 2024 at 01:00:11PM +0200, AngeloGioacchino Del Regn

Re: [PATCH] tools/testing/radix-tree/idr-test: add missing MODULE_DESCRIPTION define

2024-06-26 Thread Liam R. Howlett
mar Reviewed-by: Liam R. Howlett > --- > > This patch is based on next-20240626 > > tools/testing/radix-tree/idr-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/radix-tree/idr-test.c > b/tools/testing/radix-tree/idr-test.c > index ca24f6

[PATCH] tools/testing/radix-tree/idr-test: add missing MODULE_DESCRIPTION define

2024-06-26 Thread Sidhartha Kumar
("KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko") Signed-off-by: Sidhartha Kumar --- This patch is based on next-20240626 tools/testing/radix-tree/idr-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/radix-tree/idr-test.c b/tools/testing/radi

Re: [PATCH 2/3] arm64: dts: qcom: msm8916-lg-m216: Add initial device tree

2024-06-26 Thread Konrad Dybcio
On 23.06.2024 11:26 AM, Nikita Travkin wrote: > From: Cristian Cozzolino > > This commit adds initial support for the LG K10 smartphone. > > Support for the following features is included: > > - Serial > - Keys > - Battery and charger > - Accelerometer, magnetometer > - Touchscreen > - Sound an

Re: [PATCH 2/2] remoteproc: qcom: select AUXILIARY_BUS

2024-06-26 Thread Chris Lew
On 6/26/2024 12:12 PM, Dmitry Baryshkov wrote: The QCOM_PD_MAPPER implementation made Qualcomm remoteproc drivers use auxiliary bus for the pd-mapper subdevice. Add necessary dependency. Reported-by: Mark Brown Fixes: 5b9f51b200dc ("remoteproc: qcom: enable in-kernel PD mapper") Signed-off-b

Re: [PATCH 1/2] soc: qcom: add missing pd-mapper dependencies

2024-06-26 Thread Chris Lew
On 6/26/2024 12:12 PM, Dmitry Baryshkov wrote: The pd-mapper driver uses auxiliary bus and Qualcomm PDR message format data. Add missing dependencies to the driver's Kconfig entry. Reported-by: Mark Brown Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation") Signed-off-by: Dmitry B

Re: [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock

2024-06-26 Thread Dmitry Baryshkov
On Tue, Jun 25, 2024 at 11:03:30AM GMT, Gokul Sriram P wrote: > > On 6/22/2024 2:38 AM, Dmitry Baryshkov wrote: > > On Fri, Jun 21, 2024 at 05:16:52PM GMT, Gokul Sriram Palanisamy wrote: > > > PRNG clock is needed by the secure PIL, support for the same > > > is added in subsequent patches. > > Wh

[PATCH v2] remoteproc: k3-dsp: Fix log levels where appropriate

2024-06-26 Thread Garrett Giordano
Driver was logging information as errors. Changed dev_err to dev_dbg where appropriate. Signed-off-by: Garrett Giordano --- -v2 - Change from dev_info to dev_dbg - Drop k3-r5 PATCH --- drivers/remoteproc/ti_k3_dsp_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] remoteproc: qcom: select AUXILIARY_BUS

2024-06-26 Thread Dmitry Baryshkov
The QCOM_PD_MAPPER implementation made Qualcomm remoteproc drivers use auxiliary bus for the pd-mapper subdevice. Add necessary dependency. Reported-by: Mark Brown Fixes: 5b9f51b200dc ("remoteproc: qcom: enable in-kernel PD mapper") Signed-off-by: Dmitry Baryshkov --- drivers/remoteproc/Kconfig

[PATCH 1/2] soc: qcom: add missing pd-mapper dependencies

2024-06-26 Thread Dmitry Baryshkov
The pd-mapper driver uses auxiliary bus and Qualcomm PDR message format data. Add missing dependencies to the driver's Kconfig entry. Reported-by: Mark Brown Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation") Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/Kconfig | 2 ++ 1 fi

[PATCH 0/2] qcom: fix missing dependencies for the QCOM_PD_MAPPER

2024-06-26 Thread Dmitry Baryshkov
drivers/remoteproc/Kconfig | 1 + drivers/soc/qcom/Kconfig | 2 ++ 2 files changed, 3 insertions(+) --- base-commit: b07e1e375f6389b6715b9aca590da17039bcd447 change-id: 20240626-qcom-pd-mapper-fix-deps-1cf064ee4715 Best regards, -- Dmitry Baryshkov

Re: [PATCH 2/2] remoteproc: k3-r5: Fix log levels where appropriate

2024-06-26 Thread Wadim Egorov
Hi Garrett, Am 26.06.24 um 18:22 schrieb Garrett Giordano: Driver was logging information as debug. Changed dev_dbg to dev_info where appropriate. Signed-off-by: Garrett Giordano --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH v3 2/2] rust: add tracepoint support

2024-06-26 Thread Steven Rostedt
On Wed, 26 Jun 2024 10:48:23 +0200 Alice Ryhl wrote: > > > > Because your hooks/rust_binder.h and events/rust_binder.h use the same > > TRACE_SYSTEM name? Could you try something like: > > > > #define TRACE_SYSTEM rust_binder_hook > > > > in your hooks/rust_binder.h? > > I was able to

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-06-26 Thread Borislav Petkov
On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote: > > > > Why are you clearing it if you're overwriting it immediately? > > > Since its a local variable, wanted to ensure that the memory is zeroed out to > prevent > any issues with the %s specifier, used later on. What issues? > W

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-06-26 Thread Borislav Petkov
On Wed, Jun 26, 2024 at 12:24:20PM -0500, Naik, Avadhut wrote: > > > On 6/26/2024 06:10, Borislav Petkov wrote: > > On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: > >> AMD's Scalable MCA systems viz. Genoa will include two new registers: > > > > "viz."? > > > Right. Will mention

Re: [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-26 Thread Borislav Petkov
On Wed, Jun 26, 2024 at 05:11:29PM +, Luck, Tony wrote: > > Tony, any comments? You ok with this, would that fit any Intel-specific > > vendor > > fields too or do you need some additional Intel-specific changes? > > It looks easy enough to add any Intel specific bits to the union later. > >

[PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-06-26 Thread Naik, Avadhut
On 6/26/2024 07:04, Borislav Petkov wrote: > On Tue, Jun 25, 2024 at 02:56:24PM -0500, Avadhut Naik wrote: >> From: Yazen Ghannam >> >> A new "FRU Text in MCA" feature is defined where the Field Replaceable >> Unit (FRU) Text for a device is represented by a string in the new >> MCA_SYND1 and M

Re: [PATCH 3/3] arm64: dts: qcom: msm8916-lg-c50: add initial dts for LG Leon LTE

2024-06-26 Thread Konrad Dybcio
On 23.06.2024 11:26 AM, Nikita Travkin wrote: > From: Anton Bambura > > Add initial device-tree for LG Leon LTE (lg-c50), currently supported > features: > - eMMC; > - MicroSD; > - usb in peripheral mode; > - WiFi/BT; > - vibration; > - keys. > > Signed-off-by: Anton Bambura > Signed-off-by: Ni

Re: [PATCH v2 3/4] x86/mce/apei: Handle variable register array size

2024-06-26 Thread Naik, Avadhut
On 6/26/2024 06:57, Borislav Petkov wrote: > On Tue, Jun 25, 2024 at 02:56:23PM -0500, Avadhut Naik wrote: >> From: Yazen Ghannam >> >> ACPI Boot Error Record Table (BERT) is being used by the kernel to >> report errors that occurred in a previous boot. On some modern AMD >> systems, these very

[PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-06-26 Thread Naik, Avadhut
On 6/26/2024 06:10, Borislav Petkov wrote: > On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: >> AMD's Scalable MCA systems viz. Genoa will include two new registers: > > "viz."? > Right. Will mention Zen4 instead of Genoa. > Not a lot of people outside of AMD know what Genoa is.

RE: [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-26 Thread Luck, Tony
> Tony, any comments? You ok with this, would that fit any Intel-specific vendor > fields too or do you need some additional Intel-specific changes? It looks easy enough to add any Intel specific bits to the union later. Is there anyway that the trace event could be "smarter" about what vendor s

Re: [PATCH v7 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-06-26 Thread Mark Brown
On Fri, May 31, 2024 at 07:34:58PM +0200, Karel Balej wrote: > Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Reviewed-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH] vDPA: add missing MODULE_DESCRIPTION() macros

2024-06-26 Thread Jeff Johnson
On 6/11/2024 12:22 PM, Jeff Johnson wrote: > With ARCH=x86, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/vdpa/vdpa.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/vdpa/ifcvf/ifcvf.o > > Add the missing invocations of the MODUL

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-26 Thread Richard Cochran
On Tue, Jun 25, 2024 at 11:34:24PM +0200, Thomas Gleixner wrote: > There is effort underway to expose PTP clocks to user space via > VDSO. That sounds interesting. Has anything been posted? Thanks, Richard

[PATCH 1/2] remoteproc: k3-dsp: Fix log levels where appropriate

2024-06-26 Thread Garrett Giordano
Driver was logging information as errors. Changed dev_err to dev_info where appropriate. Signed-off-by: Garrett Giordano --- drivers/remoteproc/ti_k3_dsp_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remotepr

[PATCH 2/2] remoteproc: k3-r5: Fix log levels where appropriate

2024-06-26 Thread Garrett Giordano
Driver was logging information as debug. Changed dev_dbg to dev_info where appropriate. Signed-off-by: Garrett Giordano --- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/

Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-26 Thread Konrad Dybcio
On 24.06.2024 1:21 PM, Naina Mehta wrote: > > > On 6/18/2024 7:08 PM, Konrad Dybcio wrote: >> >> >> On 6/18/24 15:13, Naina Mehta wrote: >>> Rename qdss@8880 memory region as qlink_logging memory region >>> and add qdss_mem memory region at address of 0x8850. >>> Split mpss_dsmharq_mem re

Re: [PATCH v2 00/13] OMAP mailbox FIFO removal

2024-06-26 Thread Andrew Davis
On 6/26/24 9:39 AM, Dominic Rath wrote: On 13.06.2024 14:22, Andrew Davis wrote: We looked into this some time ago, and noticed that the IRQ approach caused problems in the virtio/rpmsg code. I'd like to understand if your change was for the same reason, or something else we missed before.

Re: [PATCH v2 00/13] OMAP mailbox FIFO removal

2024-06-26 Thread Dominic Rath
On 13.06.2024 14:22, Andrew Davis wrote: We looked into this some time ago, and noticed that the IRQ approach caused problems in the virtio/rpmsg code. I'd like to understand if your change was for the same reason, or something else we missed before. It is most likely the same reason. Seems

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-06-26 Thread Steven Rostedt
On Wed, 26 Jun 2024 21:31:57 +0900 Masami Hiramatsu (Google) wrote: > On Thu, 20 Jun 2024 16:19:03 + > Takaya Saeki wrote: > > > To allow precise tracking of page caches accessed, add new tracepoints > > that trigger when a process actually accesses them. > > > > The ureadahead program use

Re: [PATCH 0/3] Introduce msm8916 based LG devices

2024-06-26 Thread Rob Herring (Arm)
On Sun, 23 Jun 2024 14:26:29 +0500, Nikita Travkin wrote: > This series introduces two msm8916-based LG devices: > > - LG Leon LTE (c50) > - LG LG K10 (m216) > > The devices only have basic support for now. > > Signed-off-by: Nikita Travkin > --- > Anton Bambura (1): > arm64: dts: qcom:

Re: [PATCH -fixes] riscv: patch: Flush the icache right after patching to avoid illegal insns

2024-06-26 Thread Conor Dooley
On Mon, Jun 24, 2024 at 10:21:41AM +0200, Alexandre Ghiti wrote: > We cannot delay the icache flush after patching some functions as we may > have patched a function that will get called before the icache flush. > > The only way to completely avoid such scenario is by flushing the icache > as soon

Re: [PATCH v2] filemap: add trace events for get_pages, map_pages, and fault

2024-06-26 Thread Google
On Thu, 20 Jun 2024 16:19:03 + Takaya Saeki wrote: > To allow precise tracking of page caches accessed, add new tracepoints > that trigger when a process actually accesses them. > > The ureadahead program used by ChromeOS traces the disk access of > programs as they start up at boot up. It u

[PATCH net-next v3 3/3] test/vsock: add ioctl unsent bytes test

2024-06-26 Thread Luigi Leonardi via B4 Relay
From: Luigi Leonardi Introduce two tests, one for SOCK_STREAM and one for SOCK_SEQPACKET, which checks after a packet is delivered, that the number of unsent bytes is zero, using ioctl SIOCOUTQ. Signed-off-by: Luigi Leonardi --- tools/testing/vsock/util.c | 6 +-- tools/testing/vsock/u

[PATCH net-next v3 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports

2024-06-26 Thread Luigi Leonardi via B4 Relay
From: Luigi Leonardi Introduce support for stream_bytes_unsent and seqpacket_bytes_unsent ioctl for virtio_transport, vhost_vsock and vsock_loopback. For all transports the unsent bytes counter is incremented in virtio_transport_get_credit. In the virtio_transport (G2H) the counter is decrement

[PATCH net-next v3 1/3] vsock: add support for SIOCOUTQ ioctl for all vsock socket types.

2024-06-26 Thread Luigi Leonardi via B4 Relay
From: Luigi Leonardi Add support for ioctl(s) for SOCK_STREAM SOCK_SEQPACKET and SOCK_DGRAM in AF_VSOCK. The only ioctl available is SIOCOUTQ/TIOCOUTQ, which returns the number of unsent bytes in the socket. This information is transport-specific and is delegated to them using a callback. Sugges

[PATCH net-next v3 0/3] ioctl support for AF_VSOCK and virtio-based transports

2024-06-26 Thread Luigi Leonardi via B4 Relay
| 3 ++ tools/testing/vsock/vsock_test.c| 85 + 10 files changed, 206 insertions(+), 8 deletions(-) --- base-commit: 50b70845fc5c22cf7e7d25b57d57b3dca1725aa5 change-id: 20240626-ioctl_next-fbbcdd596063 Best regards, -- Luigi Leonardi

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-06-26 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 02:56:24PM -0500, Avadhut Naik wrote: > From: Yazen Ghannam > > A new "FRU Text in MCA" feature is defined where the Field Replaceable > Unit (FRU) Text for a device is represented by a string in the new > MCA_SYND1 and MCA_SYND2 registers. This feature is supported per MC

Re: [PATCH v2 3/4] x86/mce/apei: Handle variable register array size

2024-06-26 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 02:56:23PM -0500, Avadhut Naik wrote: > From: Yazen Ghannam > > ACPI Boot Error Record Table (BERT) is being used by the kernel to > report errors that occurred in a previous boot. On some modern AMD > systems, these very errors within the BERT are reported through the > x

Re: [PATCH] ipvs: Avoid unnecessary calls to skb_is_gso_sctp

2024-06-26 Thread Pablo Neira Ayuso
Hi, I have placed this patch in the nf-next tree to be included in the next pull request. Thanks.

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-06-26 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: > AMD's Scalable MCA systems viz. Genoa will include two new registers: "viz."? Not a lot of people outside of AMD know what Genoa is. Zen4 is probably a lot more widespread. > MCA_SYND1 and MCA_SYND2. > > These registers will includ

Re: [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-26 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 02:56:21PM -0500, Avadhut Naik wrote: > Currently, exporting new additional machine check error information > involves adding new fields for the same at the end of the struct mce. > This additional information can then be consumed through mcelog or > tracepoint. > > However

[PATCH vhost v2 24/24] vdpa/mlx5: Don't enable non-active VQs in .set_vq_ready()

2024-06-26 Thread Dragos Tatulea
VQ indices in the range [cur_num_qps, max_vqs) represent queues that have not yet been activated. .set_vq_ready should not activate these VQs. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++ 1 file changed, 3 insert

[PATCH vhost v2 23/24] vdpa/mlx5: Don't reset VQs more than necessary

2024-06-26 Thread Dragos Tatulea
The vdpa device can be reset many times in sequence without any significant state changes in between. Previously this was not a problem: VQs were torn down only on first reset. But after VQ pre-creation was introduced, each reset will delete and re-create the hardware VQs and their associated resou

[PATCH vhost v2 22/24] vdpa/mlx5: Re-create HW VQs under certain conditions

2024-06-26 Thread Dragos Tatulea
There are a few conditions under which the hardware VQs need a full teardown and setup: - VQ size changed to something else than default value. Hardware VQ size modification is not supported. - User turns off certain device features: mergeable buffers, checksum virtio 1.0 compliance. In these

[PATCH vhost v2 21/24] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-06-26 Thread Dragos Tatulea
Currently, hardware VQs are created right when the vdpa device gets into DRIVER_OK state. That is easier because most of the VQ state is known by then. This patch switches to creating all VQs and their associated resources at device creation time. The motivation is to reduce the vdpa device live m

[PATCH vhost v2 20/24] vdpa/mlx5: Use suspend/resume during VQP change

2024-06-26 Thread Dragos Tatulea
Resume a VQ if it is already created when the number of VQ pairs increases. This is done in preparation for VQ pre-creation which is coming in a later patch. It is necessary because calling setup_vq() on an already created VQ will return early and will not enable the queue. For symmetry, suspend a

[PATCH vhost v2 19/24] vdpa/mlx5: Forward error in suspend/resume device

2024-06-26 Thread Dragos Tatulea
Start using the suspend/resume_vq() error return codes previously added. Reviewed-by: Cosmin Ratiu Reviewed-by: Zhu Yanjun Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/mlx5/net/

[PATCH vhost v2 18/24] vdpa/mlx5: Consolidate all VQ modify to Ready to use resume_vq()

2024-06-26 Thread Dragos Tatulea
There are a few more places modifying the VQ to Ready directly. Let's consolidate them into resume_vq(). The redundant warnings for resume_vq() errors can also be dropped. There is one special case that needs to be handled for virtio-vdpa: the initialized flag must be set to true earlier in setup

[PATCH vhost v2 17/24] vdpa/mlx5: Add error code for suspend/resume VQ

2024-06-26 Thread Dragos Tatulea
Instead of blindly calling suspend/resume_vqs(), make then return error codes. To keep compatibility, keep suspending or resuming VQs on error and return the last error code. The assumption here is that the error code would be the same. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-o

[PATCH vhost v2 16/24] vdpa/mlx5: Accept Init -> Ready VQ transition in resume_vq()

2024-06-26 Thread Dragos Tatulea
Until now resume_vq() was used only for the suspend/resume scenario. This change also allows calling resume_vq() to bring it from Init to Ready state (VQ initialization). Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 24 ++--

[PATCH vhost v2 15/24] vdpa/mlx5: Allow creation of blank VQs

2024-06-26 Thread Dragos Tatulea
Based on the filled flag, create VQs that are filled or blank. Blank VQs will be filled in later through VQ modify. Downstream patches will make use of this to pre-create blank VQs at vdpa device creation. Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu --- drivers/vdpa/mlx5/net/mlx5_v

[PATCH vhost v2 14/24] vdpa/mlx5: Set mkey modified flags on all VQs

2024-06-26 Thread Dragos Tatulea
Otherwise, when virtqueues are moved from INIT to READY the latest mkey will not be set appropriately. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH vhost v2 13/24] vdpa/mlx5: Start off rqt_size with max VQPs

2024-06-26 Thread Dragos Tatulea
Currently rqt_size is initialized during device flag configuration. That's because it is the earliest moment when device knows if MQ (multi queue) is on or off. Shift this configuration earlier to device creation time. This implies that non-MQ devices will have a larger RQT size. But the configura

[PATCH vhost v2 12/24] vdpa/mlx5: Set an initial size on the VQ

2024-06-26 Thread Dragos Tatulea
The virtqueue size is a pre-requisite for setting up any virtqueue resources. For the upcoming optimization of creating virtqueues at device add, the virtqueue size has to be configured. The queue size check in setup_vq() will always be false. So remove it. Signed-off-by: Dragos Tatulea Reviewed

[PATCH vhost v2 11/24] vdpa/mlx5: Add support for modifying the VQ features field

2024-06-26 Thread Dragos Tatulea
This is done in preparation for the pre-creation of hardware virtqueues at device add time. Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 12 +++- include/linux/mlx5/mlx5_ifc_vdpa.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(

[PATCH vhost v2 10/24] vdpa/mlx5: Add support for modifying the virtio_version VQ field

2024-06-26 Thread Dragos Tatulea
This is done in preparation for the pre-creation of hardware virtqueues at device add time. Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 16 include/linux/mlx5/mlx5_ifc_vdpa.h | 1 + 2 files changed, 17 insertions(+) diff --

[PATCH vhost v2 08/24] vdpa/mlx5: Clear and reinitialize software VQ data on reset

2024-06-26 Thread Dragos Tatulea
The hardware VQ configuration is mirrored by data in struct mlx5_vdpa_virtqueue . Instead of clearing just a few fields at reset, fully clear the struct and initialize with the appropriate default values. As clear_vqs_ready() is used only during reset, get rid of it. Reviewed-by: Cosmin Ratiu Ac

[PATCH vhost v2 09/24] vdpa/mlx5: Rename init_mvqs

2024-06-26 Thread Dragos Tatulea
Function is used to set default values, so name it accordingly. Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index de013b5a

[PATCH vhost v2 07/24] vdpa/mlx5: Initialize and reset device with one queue pair

2024-06-26 Thread Dragos Tatulea
The virtio spec says that a vdpa device should start off with one queue pair. The driver is already compliant. This patch moves the initialization to device add and reset times. This is done in preparation for the pre-creation of hardware virtqueues at device add time. Signed-off-by: Dragos Tatul

[PATCH vhost v2 06/24] vdpa/mlx5: Remove duplicate suspend code

2024-06-26 Thread Dragos Tatulea
Use the dedicated suspend_vqs() function instead. Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa

[PATCH vhost v2 05/24] vdpa/mlx5: Iterate over active VQs during suspend/resume

2024-06-26 Thread Dragos Tatulea
No need to iterate over max number of VQs. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/ml

[PATCH vhost v2 04/24] vdpa/mlx5: Drop redundant check in teardown_virtqueues()

2024-06-26 Thread Dragos Tatulea
The check is done inside teardown_vq(). Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5

[PATCH vhost v2 03/24] vdpa/mlx5: Drop redundant code

2024-06-26 Thread Dragos Tatulea
Originally, the second loop initialized the CVQ. But (acde3929492b ("vdpa/mlx5: Use consistent RQT size") initialized all the queues in the first loop, so the second iteration in init_mvqs() is never called because the first one will iterate up to max_vqs. Reviewed-by: Cosmin Ratiu Acked-by: Euge

[PATCH vhost v2 02/24] vdpa/mlx5: Make setup/teardown_vq_resources() symmetrical

2024-06-26 Thread Dragos Tatulea
... by changing the setup_vq_resources() parameter type. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by: Dragos Tatulea --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/dri

[PATCH vhost v2 01/24] vdpa/mlx5: Clarify meaning thorough function rename

2024-06-26 Thread Dragos Tatulea
setup_driver()/teardown_driver() are a bit vague. These functions are used for virtqueue resources. Same for alloc_resources()/teardown_resources(): they represent fixed resources that are meant to exist during the device lifetime. Reviewed-by: Cosmin Ratiu Acked-by: Eugenio Pérez Signed-off-by

[PATCH vhost v2 00/24] vdpa/mlx5: Pre-create HW VQs to reduce LM downtime

2024-06-26 Thread Dragos Tatulea
According to the measurements for vDPA Live Migration downtime [0], one large source of downtime is the creation of hardware VQs and their associated resources on the devices on the destination VM. Previous series ([1], [2]) addressed the source part of the Live Migration downtime. This series add

Re: [PATCH vhost 18/23] vdpa/mlx5: Forward error in suspend/resume device

2024-06-26 Thread Dragos Tatulea
On Sun, 2024-06-23 at 19:19 +0800, Zhu Yanjun wrote: > 在 2024/6/17 23:07, Dragos Tatulea 写道: > > Start using the suspend/resume_vq() error return codes previously added. > > > > Signed-off-by: Dragos Tatulea > > Reviewed-by: Cosmin Ratiu > > --- > > drivers/vdpa/mlx5/net/mlx5_vnet.c | 12 +

Re: [PATCH vhost 20/23] vdpa/mlx5: Pre-create hardware VQs at vdpa .dev_add time

2024-06-26 Thread Dragos Tatulea
On Wed, 2024-06-19 at 17:54 +0200, Eugenio Perez Martin wrote: > On Mon, Jun 17, 2024 at 5:09 PM Dragos Tatulea wrote: > > > > Currently, hardware VQs are created right when the vdpa device gets into > > DRIVER_OK state. That is easier because most of the VQ state is known by > > then. > > > > T

Re: [PATCH v3 2/2] rust: add tracepoint support

2024-06-26 Thread Alice Ryhl
On Tue, Jun 25, 2024 at 8:11 PM Boqun Feng wrote: > > On Fri, Jun 21, 2024 at 02:52:10PM +0200, Alice Ryhl wrote: > [...] > > > > Hmm, I tried using the support where I have both events and hooks: > > > > #define CREATE_TRACE_POINTS > > #define CREATE_RUST_TRACE_POINTS > > #include > > #include

Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support

2024-06-26 Thread David Woodhouse
On Tue, 2024-06-25 at 15:22 -0700, John Stultz wrote: > On Tue, Jun 25, 2024 at 2:48 PM David Woodhouse wrote: > > On Tue, 2024-06-25 at 23:34 +0200, Thomas Gleixner wrote: > > > On Tue, Jun 25 2024 at 20:01, David Woodhouse wrote: > > > > From: David Woodhouse > > > > > > > > The vmclock "devic

Re: [PATCH V2 3/3] virtio-net: synchronize operstate with admin state on up/down

2024-06-26 Thread Michael S. Tsirkin
On Wed, Jun 26, 2024 at 09:58:32AM +0800, Jason Wang wrote: > On Tue, Jun 25, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 25, 2024 at 04:11:05PM +0800, Jason Wang wrote: > > > On Tue, Jun 25, 2024 at 3:57 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jun 25, 2024 a