[PATCH] [v2] netfilter: ipset: fix a missing check of nla_parse

2019-01-05 Thread Aditya Pakki
When nla_parse fails, we should not use the results (the first argument). The fix checks if it fails, and if so, returns its error code upstream. Signed-off-by: Aditya Pakki --- net/netfilter/ipset/ip_set_core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/net

[PATCH] Staging: rts5208: Fix error handling on rtsx_send_cmd

2019-01-05 Thread Aditya Pakki
In sd_execute_write_data, the rtsx_send_cmd could fail with ETIMEDOUT or EIO. The fix adds a check to handle these failures. Signed-off-by: Aditya Pakki --- drivers/staging/rts5208/sd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.c b

[PATCH] ASoC: rt5663: Fix error handling of device_property_read_u32_array

2019-01-05 Thread Aditya Pakki
In rt5663_parse_dp, the function device_property_read_u32_array() can return an error. This fix adds a check to the latter as well as to the callsite of rt5663_parse_dp in rt5663_i2c_probe. Signed-off-by: Aditya Pakki --- sound/soc/codecs/rt5663.c | 9 ++--- 1 file changed, 6 insertions

[PATCH] dmaengine: qcom_hidma: Check for driver register failure

2018-12-28 Thread Aditya Pakki
While initializing the driver, the function platform_driver_register can fail and return an error. Consistent with other invocations, this patch returns the error upstream. Signed-off-by: Aditya Pakki --- drivers/dma/qcom/hidma_mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH] mfd: sm501: Check for driver register failure

2018-12-28 Thread Aditya Pakki
While initializing the driver, the function platform_driver_register can fail and return an error. Consistent with other invocations, this patch returns the error upstream. Signed-off-by: Aditya Pakki --- drivers/mfd/sm501.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH] bluetooth: hci_intel: Check for driver register failure

2018-12-28 Thread Aditya Pakki
While initializing the driver, the function platform_driver_register can fail and return an error. Consistent with other invocations, this patch returns the error upstream. Signed-off-by: Aditya Pakki --- drivers/bluetooth/hci_intel.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion

[PATCH] bluetooth: hci_bcm: Check for driver_register failure

2018-12-28 Thread Aditya Pakki
While initializing the driver, the function platform_driver_register can fail and return an error. Consistent with other invocations, this patch returns the error upstream. Signed-off-by: Aditya Pakki --- drivers/bluetooth/hci_bcm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH] dmaengine: stm32-mdma: Add a check on read_u32_array

2018-12-28 Thread Aditya Pakki
In stm32_mdma_probe, after reading the property "st,ahb-addr-masks", the second call is not checked for failure. This time of check to time of use case of "count" error is sent upstream. Signed-off-by: Aditya Pakki --- drivers/dma/stm32-mdma.c | 4 +++- 1 file changed

[PATCH] media: gspca: mt9m111: Check write_bridge for timeout

2018-12-28 Thread Aditya Pakki
In mt9m111_probe, m5602_write_bridge can timeout and return a negative error value. The fix checks for this error and passes it upstream. Signed-off-by: Aditya Pakki --- drivers/media/usb/gspca/m5602/m5602_mt9m111.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH] media: gspca: Check the return value of write_bridge for timeout

2018-12-28 Thread Aditya Pakki
In po1030_probe(), m5602_write_bridge() can timeout and return an error value. The fix checks for the return value and propagates upstream consistent with other usb drivers. Signed-off-by: Aditya Pakki --- drivers/media/usb/gspca/m5602/m5602_po1030.c | 8 ++-- 1 file changed, 6 insertions

[PATCH] rtc: rv8803: Check return value of rv8803_write_reg

2018-12-27 Thread Aditya Pakki
In rv8803_handle_irq, rv8803_write_reg can return a failed return value when attempting to write to the bus. The fix checks the output and throws a dev_warn notifying of the failure. Signed-off-by: Aditya Pakki --- drivers/rtc/rtc-rv8803.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH] iio: adc: xilinx: check return value of xadc_write_adc_reg

2018-12-27 Thread Aditya Pakki
In function xadc_probe, xadc_write_adc_reg can return an error value when write fails. The fix checks for the return value consistent with other invocations of the latter function. Signed-off-by: Aditya Pakki --- drivers/iio/adc/xilinx-xadc-core.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH] staging: rts5208: Add a check for ms_read_extra_data

2018-12-27 Thread Aditya Pakki
In ms_copy_page, the function ms_read_extra_data may fail for many reasons. The fix adds a check similar to other invocation to return error upstream. Signed-off-by: Aditya Pakki --- drivers/staging/rts5208/ms.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH] media: dvb: Add check on sp8870_readreg

2018-12-27 Thread Aditya Pakki
In sp8870_set_frontend_parameters, the function sp8870_readreg may return an error when i2c_transfer fails. The fix checks for this error and returns upstream consistent with other invocations. Signed-off-by: Aditya Pakki --- drivers/media/dvb-frontends/sp8870.c | 4 +++- 1 file changed, 3

[PATCH] media: dvb: add return value check on Write16

2018-12-27 Thread Aditya Pakki
Write16 can return an error code -1 when the i2c_write fails. The fix checks for these failures and returns the error upstream Signed-off-by: Aditya Pakki --- drivers/media/dvb-frontends/drxd_hard.c | 30 - 1 file changed, 19 insertions(+), 11 deletions(-) diff --git

[PATCH] mm: compaction.c: Propagate return value upstream

2018-12-26 Thread Aditya Pakki
In sysctl_extfrag_handler(), proc_dointvec_minmax() can return an error. The fix propagates the error upstream in case of failure. Signed-off-by: Aditya Pakki --- mm/compaction.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index

[PATCH] mm: compaction.c: Propagate return value upstream

2018-12-26 Thread Aditya Pakki
In sysctl_extfrag_handler(), proc_dointvec_minmax() can return an error. The fix propagates the error upstream in case of failure. Signed-off-by: Aditya Pakki --- mm/compaction.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index

[PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message

2018-12-26 Thread Aditya Pakki
In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return an error value. The fix returns the error from the latter function upstream. Signed-off-by: Aditya Pakki --- drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH] hmm: Warn on devres_release failure

2018-12-26 Thread Aditya Pakki
devres_release can return -ENOENT if the device is not freed. The fix throws a warning consistent with other invocations. Signed-off-by: Aditya Pakki --- mm/hmm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/hmm.c b/mm/hmm.c index 90c34f3d1243..b06e3f092fbf

[PATCH] net: phy: phy: check return value of bus write

2018-12-26 Thread Aditya Pakki
phy_mii_ioctl() could fail when writing to the bus via mdiobus_write(). The fix adds a check and returns an error in case of failure. Signed-off-by: Aditya Pakki --- drivers/net/phy/phy.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers

[PATCH] net:phy: Add a return value check on bus write

2018-12-26 Thread Aditya Pakki
xgmiitorgmii_read_status() could fail when writing to the bus via mdiobus_write(). The fix adds a check and returns an error in case of failure. Signed-off-by: Aditya Pakki --- drivers/net/phy/xilinx_gmii2rgmii.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH] char: hw_random: Fix missing check during driver release

2018-12-26 Thread Aditya Pakki
devres_release can return -ENOENT if the device is not freed. The fix throws a warning consistent with other invocations. Signed-off-by: Aditya Pakki --- drivers/char/hw_random/core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/core.c b

[PATCH] platform: x86: Add check for led_classdev_register

2018-12-24 Thread Aditya Pakki
In function alienware_zone_init, the function led_classdev_register can return an error on failure. The fix checks the error and frees the allocated resources. Signed-off-by: Aditya Pakki --- drivers/platform/x86/alienware-wmi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion

[PATCH] hid: Add checks to fix of_led_classdev_register

2018-12-24 Thread Aditya Pakki
In lenovo_probe_tpkbd(), the function of_led_classdev_register() could return an error value that is unchecked. The fix adds these checks. Signed-off-by: Aditya Pakki --- drivers/hid/hid-lenovo.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid

[PATCH] net: chelsio: Add a missing check on cudg_get_buffer

2018-12-24 Thread Aditya Pakki
cudbg_collect_hw_sched() could fail when the function cudg_get_buffer() returns an error. The fix adds a check to the latter function returning error on failure Signed-off-by: Aditya Pakki --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH] clk: Fix a missing check on regmap_bulk_read

2018-12-24 Thread Aditya Pakki
Currently, vc5_pll_recalc_rate() may produce incorrect output when regmap_bulk_read() fails. The fix checks the return value of the latter function and returns 0 in case of failure. Signed-off-by: Aditya Pakki --- drivers/clk/clk-versaclock5.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH] input/touchscreen: Fix a missing check on regmap_bulk_read

2018-12-24 Thread Aditya Pakki
regmap_bulk_read() can return a non zero value on failure. The fix checks if the function call succeeded before calling mod_timer. Signed-off-by: Aditya Pakki --- drivers/input/touchscreen/ad7879.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/input

[PATCH] infiniband/qedr: Potential null ptr dereference of qp

2018-12-24 Thread Aditya Pakki
idr_find() may fail and return a NULL pointer. The fix checks the return value of the function and returns an error in case of NULL. Signed-off-by: Aditya Pakki --- drivers/infiniband/hw/qedr/qedr_iw_cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/qedr

[PATCH] batman-adv/main: Fix check on return value of rtnl_link_register

2018-12-24 Thread Aditya Pakki
rtnl_link_register() may fail and can impact registering the device. The fix checks the return value and pushes the error upstream. Signed-off-by: Aditya Pakki --- net/batman-adv/main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/main.c b/net/batman

[PATCH] dma/mv_xor: Fix a missing check in mv_xor_channel_add

2018-12-24 Thread Aditya Pakki
dma_async_device_register() may fail and return an error. The capabilities checked in mv_xor_channel_add() are not complete. The fix handles the error by freeing the resources. Signed-off-by: Aditya Pakki --- drivers/dma/mv_xor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH] misc/ics932s401: Add a missing check to i2c_smbus_read_word_data

2018-12-24 Thread Aditya Pakki
ics932s401_update_device may fail reading in i2c_smbus_read_word_data due to error in i2c_smbus_xfer. The fix checks the status and defaults the register to 0. Signed-off-by: Aditya Pakki --- drivers/misc/ics932s401.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/misc/ics932s401

[PATCH] slimbus: Add a check on the return value of platform_device_add

2018-12-24 Thread Aditya Pakki
In of_qcom_slim_ngd_register, the function platform_device_add() may fail. The fix returns the error value upstream in case of failure. Signed-off-by: Aditya Pakki --- drivers/slimbus/qcom-ngd-ctrl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/slimbus/qcom

[PATCH] x86/intel-mid: Add pr_warn when platform_device_add() fails

2018-12-24 Thread Aditya Pakki
platform_device_add() may fail in intel_scu_devices_create and sfi_handle_ipc_dev. The fix checks for the return value in these cases and displays the failed device. Signed-off-by: Aditya Pakki --- arch/x86/platform/intel-mid/sfi.c | 16 1 file changed, 12 insertions(+), 4

[PATCH] ipv6/route: Add a missing check on proc_dointvec

2018-12-24 Thread Aditya Pakki
While flushing the cache via ipv6_sysctl_rtcache_flush(), the call to proc_dointvec() may fail. The fix adds a check that returns the error, on failure. Signed-off-by: Aditya Pakki --- net/ipv6/route.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/ipv6/route.c b

[PATCH] rts5208: Add a check on the status of ms_send_cmd

2018-12-24 Thread Aditya Pakki
In mspro_stop_seq_mode(), ms_send_cmd() may fail. The patch attempts to detect a failure before flushing the registers via rtsx_write_register. Signed-off-by: Aditya Pakki --- drivers/staging/rts5208/ms.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] media/lgdt3306a: Add a missing return value check.

2018-12-24 Thread Aditya Pakki
In lgdt3306a.c, lgdt3306a_read_signal_strength() can fail while reading the registers via lgdt3306a_read_reg(). The function can return an error from i2c_transfer(). The fix checks the return value for this failure. Signed-off-by: Aditya Pakki --- drivers/media/dvb-frontends/lgdt3306a.c | 5

[PATCH] net/net_namespace: Check the return value of register_pernet_subsys()

2018-12-23 Thread Aditya Pakki
In net_ns_init(), register_pernet_subsys() could fail while registering network namespace subsystems. The fix checks the return value and sends a panic() on failure. Signed-off-by: Aditya Pakki --- net/core/net_namespace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH] net/netlink_compat: Fix a missing check of nla_parse_nested

2018-12-23 Thread Aditya Pakki
In tipc_nl_compat_sk_dump(), if nla_parse_nested() fails, it could return an error. To be consistent with other invocations of the function call, on error, the fix passes the return value upstream. Signed-off-by: Aditya Pakki --- net/tipc/netlink_compat.c | 7 +-- 1 file changed, 5

[PATCH] rtl8723bs/ioctl_linux: Add a security check to copy_from_user()

2018-12-23 Thread Aditya Pakki
Currently, the return value of copy_from_user is not checked. extra is assigned to u32wps_start irrespective of these failures. Signed-off-by: Aditya Pakki --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers

<    1   2