Re: [PATCH] fault_inject: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021年2月1日(月) 16:43 Jiapeng Chong : > > Fix the following coccicheck warning: > > ./lib/fault-inject.c:187:0-23: WARNING: fops_stacktrace_depth should be > defined with DEFINE_DEBUGFS_ATTRIBUTE. > > ./lib/fault-inject.c:169:0-23: WARNING: fops_ul should be defined with > DEFINE_DEBUGFS_ATTRIBUTE. >

Re: [RFC PATCH v2 2/2] docs: add fail_lsm_hooks info to fault-injection.rst

2020年10月26日(月) 21:52 Aleksandr Nogikh : > > From: Aleksandr Nogikh > > Describe fail_lsm_hooks fault injection capability. > > Signed-off-by: Aleksandr Nogikh > --- > v2: > - Added this commit. > --- > Documentation/fault-injection/fault-injection.rst | 6 ++ > 1 file changed, 6 insertions(+

Re: [PATCH] fault-injection: handle EI_ETYPE_TRUE

Hi Andrew, Please consider taking this patch in the -mm tree. This patch looks good to me. Reviewed-by: Akinobu Mita 2020年10月13日(火) 18:31 Barnabás Pőcze : > > Hi, > > I had some difficulty finding who should receive this patch, and I am not > sure I got it right. Could someone

Re: [PATCH v2 0/3] add fault injection to user memory access

Andrew, Could you take a look at this series, and consider taking in -mm tree? 2020年9月1日(火) 0:49 Alexander Potapenko : > > > This series looks good to me. > > Great! > > Which tree do fault injection patches normally go to? > > > Reviewed-by: Akinobu Mita > > Reviewed-by: Alexander Potapenko

Re: [PATCH v2 0/3] add fault injection to user memory access

sercopy > functions. The second changes usercopy functions to use this new failure > capability (copy_from_user, ...). The third patch adds > get/put/clear_user failures to x86. This series looks good to me. Reviewed-by: Akinobu Mita

[PATCH -next 1/2] leds: add /sys/devices/virtual/led-trigger/

trigger device. The name of the sub-directory matches the LED trigger name. We can find all available LED triggers by listing this directory contents. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita ---

[PATCH -next 2/2] leds: add /sys/class/leds//current-trigger

Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita --- Documentation/ABI/testing/sysfs-class-led | 13 +++ drivers/leds/led-class.c | 10 drivers/leds/led-triggers.c | 38 +++ drivers/leds/leds.h

[PATCH -next 0/2] leds: add substitutes for /sys/class/leds//trigger

r file" rule of sysfs. This series was previously developed as a part of the series "leds: fix /sys/class/leds//trigger and add new api" [1]. Now this version only contains the new api part. [1] https://lore.kernel.org/r/1567946472-10075-1-git-send-email-akinobu.m...@gmail.com Akin

[PATCH v3 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

zewski Cc: Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita --- drivers/leds/led-class.c| 8 ++-- drivers/leds/led-triggers.c | 90 ++--- drivers/leds/leds.h | 6 +++ include/linux/leds.h| 5 --- 4 files changed, 78 inserti

[PATCH v3 0/1] leds: fix /sys/class/leds//trigger

to a certain amount of changes * v2 - Update commit message - Drop patches for new api Akinobu Mita (1): leds: remove PAGE_SIZE limit of /sys/class/leds//trigger drivers/leds/led-class.c| 8 ++-- drivers/leds/led-triggers.c | 90 ++--- drivers/leds

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019年9月28日(土) 2:46 Greg Kroah-Hartman : > > On Sat, Sep 28, 2019 at 01:47:21AM +0900, Akinobu Mita wrote: > > 2019年9月27日(金) 15:39 Greg Kroah-Hartman : > > > > > > On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote: > > > > Reading /sys/cla

Re: [PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019年9月27日(金) 15:39 Greg Kroah-Hartman : > > On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote: > > Reading /sys/class/leds//trigger returns all available LED triggers. > > However, the size of this file is limited to PAGE_SIZE because of the > > limita

Re: [PATCH] rtc: r7301: Use devm_platform_ioremap_resource() in rtc7301_rtc_probe()

2019年9月21日(土) 20:49 Markus Elfring : > > From: Markus Elfring > Date: Sat, 21 Sep 2019 13:43:07 +0200 > > Simplify this function implementation by using a known wrapper function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elf

[PATCH v2 1/1] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

zewski Cc: Pavel Machek Cc: Dan Murphy Acked-by: Pavel Machek Signed-off-by: Akinobu Mita --- drivers/leds/led-class.c| 8 ++-- drivers/leds/led-triggers.c | 90 ++--- drivers/leds/leds.h | 6 +++ include/linux/leds.h| 5 --- 4 files c

[PATCH v2 0/1] leds: fix /sys/class/leds//trigger

e per file" rule of sysfs. This second version dropped it because there have been a number of problems and it turns out that the new api should be submitted separately. * v2 - Update commit message - Drop patches for new api Akinobu Mita (1): leds: remove PAGE_SIZE limit of /sys/class/led

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019年9月13日(金) 2:15 Jacek Anaszewski : > > Hi Akinobu, > > Please bump patch version each time you send an update > of the patch with the same subject. Oops, should I resend with the correct subject?

[PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

zewski Cc: Pavel Machek Cc: Dan Murphy Acked-by: Pavel Machek Signed-off-by: Akinobu Mita --- drivers/leds/led-class.c| 8 ++-- drivers/leds/led-triggers.c | 90 ++--- drivers/leds/leds.h | 6 +++ include/linux/leds.h| 5 --- 4 files c

[PATCH] leds: fix /sys/class/leds//trigger

dropped it because there have been a number of problems and it turns out that the new api should be submitted separately. * v2 - Update commit message - Drop patches for new api Akinobu Mita (1): leds: remove PAGE_SIZE limit of /sys/class/leds//trigger drivers/leds/led-class.c| 8 ++-- dr

Re: [PATCH 1/5] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019年9月12日(木) 0:36 Greg Kroah-Hartman : > > On Thu, Sep 12, 2019 at 12:25:28AM +0900, Akinobu Mita wrote: > > 2019年9月8日(日) 22:10 Greg Kroah-Hartman : > > > > > > On Sun, Sep 08, 2019 at 09:41:08PM +0900, Akinobu Mita wrote: > > > > Reading /sys/cla

Re: [PATCH 1/5] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019年9月8日(日) 22:10 Greg Kroah-Hartman : > > On Sun, Sep 08, 2019 at 09:41:08PM +0900, Akinobu Mita wrote: > > Reading /sys/class/leds//trigger returns all available LED triggers. > > However, the size of this file is limited to PAGE_SIZE because of the > > limita

[PATCH 5/5] leds: add /sys/class/leds//current-trigger

#x27; only shows the current trigger name. This new file follows the "one value per file" rule of sysfs. We can use the /sys/class/triggers directory to get the list of available LED triggers. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Jacek Anaszewski Cc: Pavel Machek

[PATCH 4/5] leds: add /sys/class/triggers/ that contains trigger sub-directories

ry matches the LED trigger name. Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita --- Documentation/ABI/testing/sysfs-class-led | 9 + drivers/leds/led-class.c

[PATCH 2/5] leds: make sure leds_class is initialized before triggers are registered

ael J. Wysocki" Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita --- drivers/leds/led-class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index 8b5a1d1..7d85181 100644 --- a/driver

[PATCH 0/5] leds: fix /sys/class/leds//trigger and add new api

follows the "one value per file" rule of sysfs. Akinobu Mita (5): leds: remove PAGE_SIZE limit of /sys/class/leds//trigger leds: make sure leds_class is initialized before triggers are registered driver core: class: add function to create /sys/class//foo directory leds

[PATCH 3/5] driver core: class: add function to create /sys/class//foo directory

zewski Cc: Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita --- drivers/base/class.c | 7 +++ include/linux/device.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/drivers/base/class.c b/drivers/base/class.c index d8a6a58..f4c53e7 100644 --- a/drivers/base/class.c +++ b/dr

[PATCH 1/5] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

ned-off-by: Akinobu Mita --- drivers/leds/led-class.c| 8 ++-- drivers/leds/led-triggers.c | 90 ++--- drivers/leds/leds.h | 6 +++ include/linux/leds.h| 5 --- 4 files changed, 79 insertions(+), 30 deletions(-) diff --git a/driver

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019年9月3日(火) 23:07 Greg KH : > > On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote: > > 2019年9月3日(火) 4:08 Greg KH : > > > > > > On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote: > > > > On 9/2/19 8:12 PM, Greg KH wrote: > >

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

gt; Thank you for the patch. > > >> > > >> I have one nit below but in general it looks good to me. > > >> I've tested it with 2000 mtd triggers (~14kB file size) > > >> and it worked flawlessly. > > >> > > >> S

[PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

available LED triggers and which trigger is currently activated. This converts /sys/class/leds//trigger to bin attribute and removes the PAGE_SIZE limitation. Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Dan Murphy Signed-off-by: Akinobu Mita --- drivers/leds/led-class.c| 8 ++--- drivers/leds

[PATCH 2/2] devcoredump: fix typo in comment

s/dev_coredumpmsg/dev_coredumpsg/ Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Reviewed-by: Chaitanya Kulkarni Signed-off-by: Akinobu Mita --- drivers/base/devcoredump.c | 2 +- 1 file

[PATCH 1/2] devcoredump: use memory_read_from_buffer

Use memory_read_from_buffer() to simplify devcd_readv(). Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Reviewed-by: Chaitanya Kulkarni Reviewed-by: Johannes Berg Signed-off-by: Akinobu

[PATCH 0/2] devcoredump: cleanup and typo fix

These two patches are cleanup and typo fix for device coredump subsystem, and these were originally a part of nvme device coredump series. However the series requires an overhaul because it makes nvme-pci driver compilcated, so these two independent patches are extracted from the series. Akinobu

Re: [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set

AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C) > + default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || > REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C) > select IRQ_DOMAIN if REGMAP_IRQ > bool Looks good. Reviewed-by: Aki

Re: [PATCH] fault-inject: clean up debugfs file creation logic

> > Also fix up the error check for debugfs_create_dir() which was not > returning NULL for an error, but rather a error pointer. > > Cc: Akinobu Mita > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Looks good. Reviewed-by: Akinobu Mita

Re: [PATCH] mm/failslab: By default, do not fail allocations with direct reclaim only

page_alloc: rename __GFP_WAIT to __GFP_RECLAIM") > Signed-off-by: Nicolas Boichat Good catch. Reviewed-by: Akinobu Mita > --- > mm/failslab.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/failslab.c b/mm/failslab.c > index

[PATCH v4 0/7] nvme-pci: support device coredump

og if available - Make coredump procedure into two phases (before resetting controller and after resetting as soon as admin queue is available). Akinobu Mita (7): devcoredump: use memory_read_from_buffer devcoredump: fix typo in comment devcoredump: allow to create several coredump files

[PATCH v4 2/7] devcoredump: fix typo in comment

s/dev_coredumpmsg/dev_coredumpsg/ Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Reviewed-by: Chaitanya Kulkarni Signed-off-by: Akinobu Mita --- * v4 - Add Reviewed-by tag drivers/base

[PATCH v4 3/7] devcoredump: allow to create several coredump files in one device

to create several device coredump files in one crashed device. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Signed-off-by: Akinobu Mita --- * v4 - No change since v2 drivers/base

[PATCH v4 5/7] nvme-pci: add device coredump infrastructure

c: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Signed-off-by: Akinobu Mita --- * v4 - Move nvme_get_telemetry_log() to nvme core module. - Use bio_vec instead of sg_table to store telemetry log page - Make nvme_coredump_logs() return error if the device didn't produce

[PATCH v4 6/7] nvme-pci: trigger device coredump on command timeout

/debug/fail_io_timeout/times # echo 1 > /sys/block/nvme0n1/io-timeout-fail # dd if=/dev/nvme0n1 of=/dev/null Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Signed-off-by: Akinobu Mita

[PATCH v4 7/7] nvme-pci: enable to trigger device coredump by hand

This provides a way to trigger the nvme device coredump by writing anything to /sys/devices/.../coredump attribute. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Signed-off-by: Akinobu Mita

[PATCH v4 1/7] devcoredump: use memory_read_from_buffer

Use memory_read_from_buffer() to simplify devcd_readv(). Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Cc: Chaitanya Kulkarni Reviewed-by: Chaitanya Kulkarni Reviewed-by: Johannes Berg Signed-off-by: Akinobu

[PATCH v4 4/7] nvme: add basic facilities to get telemetry log page

: Chaitanya Kulkarni Signed-off-by: Akinobu Mita --- * v4 - Add nvme_get_telemetry_log() to nvme core module. - Copy struct nvme_telemetry_log_page_hdr from the latest nvme-cli drivers/nvme/host/core.c | 59 drivers/nvme/host/nvme.h | 3 +++ include

Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

2019年5月14日(火) 0:23 Chaitanya Kulkarni : > > On 05/13/2019 12:46 AM, Minwoo Im wrote: > >> +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void > >> *buf, > >> + size_t bytes, loff_t offset) > >> +{ > >> +loff_t pos = 0; > >> +u32 chunk_

Re: [PATCH v3 4/7] nvme: add basic facility to get telemetry log page

2019年5月14日(火) 0:34 Chaitanya Kulkarni : > > On 05/12/2019 08:55 AM, Akinobu Mita wrote: > > This adds the required definisions to get telemetry log page. > s/definisions/definitions/ OK. > > diff --git a/include/linux/nvme.h b/include/linux/nvme.h > > index c40720

Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

2019年5月13日(月) 23:03 Christoph Hellwig : > > Usage of a scatterlist here is rather bogus as we never use > it for dma mapping. Why can't you store the various pages in a > large bio_vec and then just issue that to the device in one > get log page command? (or at least a few if MDTS kicks in?) OK.

Re: [PATCH v3 5/7] nvme-pci: add device coredump infrastructure

2019年5月13日(月) 22:55 Keith Busch : > > On Sun, May 12, 2019 at 08:54:15AM -0700, Akinobu Mita wrote: > > +static void nvme_coredump_logs(struct nvme_dev *dev) > > +{ > > + struct dev_coredumpm_bulk_data *bulk_data; > > + > > + if (!

Re: [PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

2019年5月13日(月) 16:41 Minwoo Im : > > > -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev); > > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev > > *dev); > > +static void nvme_coredump_init

[PATCH v3 3/7] devcoredump: allow to create several coredump files in one device

to create several device coredump files in one crashed device. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Signed-off-by: Akinobu Mita --- * v3 - No change since v2 drivers/base/devcoredump.c | 155

[PATCH v3 2/7] devcoredump: fix typo in comment

s/dev_coredumpmsg/dev_coredumpsg/ Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Signed-off-by: Akinobu Mita --- * v3 - No change since v2 drivers/base/devcoredump.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 6/7] nvme-pci: trigger device coredump on command timeout

/debug/fail_io_timeout/times # echo 1 > /sys/block/nvme0n1/io-timeout-fail # dd if=/dev/nvme0n1 of=/dev/null Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Signed-off-by: Akinobu Mita --- * v3 - Don

[PATCH v3 7/7] nvme-pci: enable to trigger device coredump by hand

This provides a way to trigger the nvme device coredump by writing anything to /sys/devices/.../coredump attribute. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Signed-off-by: Akinobu Mita --- * v3 - Extracted

[PATCH v3 5/7] nvme-pci: add device coredump infrastructure

c: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Signed-off-by: Akinobu Mita --- * v3 - Fix typo s/machanism/mechanism/ in commit log - Fix max transfer size calculation for get log page - Add function comments - Extract 'enable to trigger device coredump by hand' patch drivers/nvme/h

[PATCH v3 4/7] nvme: add basic facility to get telemetry log page

Signed-off-by: Akinobu Mita --- * v3 - Merge 'add telemetry log page definisions' patch and 'add facility to check log page attributes' patch - Copy struct nvme_telemetry_log_page_hdr from the latest nvme-cli - Add BUILD_BUG_ON for the size of struct nvme_telemetry_log_page_hdr

[PATCH v3 0/7] nvme-pci: support device coredump

re resetting controller and after resetting as soon as admin queue is available). Akinobu Mita (7): devcoredump: use memory_read_from_buffer devcoredump: fix typo in comment devcoredump: allow to create several coredump files in one device nvme: add basic facility to get telem

[PATCH v3 1/7] devcoredump: use memory_read_from_buffer

Use memory_read_from_buffer() to simplify devcd_readv(). Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Cc: Kenneth Heitke Reviewed-by: Johannes Berg Signed-off-by: Akinobu Mita --- * v3 - No change since v2 drivers/base

Re: [PATCH v2 6/7] nvme-pci: add device coredump support

2019年5月8日(水) 9:25 Minwoo Im : > > > This is a bit of a mine field. The shutdown_lock is held when reclaiming > > requests that didn't see a response. If you're holding it here and your > > telemetry log page times out, we're going to deadlock. And since the > > controller is probably in a buggered

Re: [PATCH v2 6/7] nvme-pci: add device coredump support

2019年5月8日(水) 6:28 Keith Busch : > > On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote: > > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > > + > > > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void > > > *buf, > >

Re: [PATCH v2 4/7] nvme.h: add telemetry log page definisions

2019年5月8日(水) 2:53 Heitke, Kenneth : > > > > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > Copy telemetry log page definisions from nvme-cli. > > > > Cc: Johannes Berg > > Cc: Keith Busch > > Cc: Jens Axboe > > Cc: Christoph Hellwig > > C

Re: [PATCH v2 4/7] nvme.h: add telemetry log page definisions

2019年5月8日(水) 2:28 Heitke, Kenneth : > > > > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > Copy telemetry log page definisions from nvme-cli. > > > > Cc: Johannes Berg > > Cc: Keith Busch > > Cc: Jens Axboe > > Cc: Christoph Hellwig > > C

Re: [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device

2019年5月8日(水) 2:35 Heitke, Kenneth : > > > > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > @@ -292,6 +309,12 @@ void dev_coredumpm(struct device *dev, struct module > > *owner, > > if (device_add(&devcd->devcd_dev)) > > goto put_

[PATCH v2 2/7] devcoredump: fix typo in comment

s/dev_coredumpmsg/dev_coredumpsg/ Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Signed-off-by: Akinobu Mita --- * v2 - New patch in this version. drivers/base/devcoredump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 0/7] nvme-pci: support device coredump

Save telemetry controller-initiated log if available - Make coredump procedure into two phases (before resetting controller and after resetting as soon as admin queue is available). Akinobu Mita (7): devcoredump: use memory_read_from_buffer devcoredump: fix typo in comment devcoredump: allow to

[PATCH v2 1/7] devcoredump: use memory_read_from_buffer

Use memory_read_from_buffer() to simplify devcd_readv(). Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Reviewed-by: Johannes Berg Signed-off-by: Akinobu Mita --- * v2 - Add Reviewed-by tag. drivers/base/devcoredump.c | 11

[PATCH v2 3/7] devcoredump: allow to create several coredump files in one device

to create several device coredump files in one crashed device. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Signed-off-by: Akinobu Mita --- * v2 - Remove unneeded braces. - Allocate device_entry followed by an array of devcd_file

[PATCH v2 5/7] nvme: add facility to check log page attributes

This provides a facility to check whether the controller supports the telemetry log pages and log page offset field for the Get Log Page command. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Signed-off-by: Akinobu Mita --- * v2

[PATCH v2 4/7] nvme.h: add telemetry log page definisions

Copy telemetry log page definisions from nvme-cli. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Signed-off-by: Akinobu Mita --- * v2 - New patch in this version. include/linux/nvme.h | 23 +++ 1 file changed

[PATCH v2 7/7] nvme-pci: trigger device coredump on command timeout

/debug/fail_io_timeout/times # echo 1 > /sys/block/nvme0n1/io-timeout-fail # dd if=/dev/nvme0n1 of=/dev/null Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Signed-off-by: Akinobu Mita --- - Make coredump procedure into two phase

[PATCH v2 6/7] nvme-pci: add device coredump support

evice coredump doesn't provide it, the userspace programs need to know which driver provides what coredump file. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Cc: Minwoo Im Signed-off-by: Akinobu Mita --- * v2 - Exclude the doorbell registers fr

Re: [PATCH 0/4] nvme-pci: support device coredump

2019年5月4日(土) 18:40 Minwoo Im : > > Hi Akinobu, > > On 5/4/19 1:20 PM, Akinobu Mita wrote: > > 2019年5月3日(金) 21:20 Christoph Hellwig : > >> > >> On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote: > >>> Could you actually explain how t

Re: [PATCH 3/4] nvme-pci: add device coredump support

2019年5月4日(土) 19:04 Minwoo Im : > > Hi, Akinobu, > > Regardless to reply of the cover, few nits here. > > On 5/2/19 5:59 PM, Akinobu Mita wrote: > > + > > +static const struct nvme_reg nvme_regs[] = { > > + { NVME_REG_CAP, "cap", 64

Re: [PATCH 0/4] nvme-pci: support device coredump

2019年5月3日(金) 21:20 Christoph Hellwig : > > On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote: > > Could you actually explain how the rest is useful? I personally have > > never encountered an issue where knowing these values would have helped: > > every device timeout always needed device

Re: [PATCH 2/4] devcoredump: allow to create several coredump files in one device

2019年5月2日(木) 21:47 Johannes Berg : > > On Thu, 2019-05-02 at 17:59 +0900, Akinobu Mita wrote: > > > > static void devcd_del(struct work_struct *wk) > > { > > struct devcd_entry *devcd; > > + int i; > > > > devcd =

Re: [PATCH 0/4] nvme-pci: support device coredump

2019年5月2日(木) 22:03 Keith Busch : > > On Thu, May 02, 2019 at 05:59:17PM +0900, Akinobu Mita wrote: > > This enables to capture snapshot of controller information via device > > coredump machanism, and it helps diagnose and debug issues. > > > > The nvme devic

[PATCH 4/4] nvme-pci: trigger device coredump before resetting controller

This enables the nvme driver to trigger a device coredump before resetting the controller caused by I/O timeout. The device coredump helps diagnose and debug issues. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off-by: Akinobu Mita

[PATCH 1/4] devcoredump: use memory_read_from_buffer

Use memory_read_from_buffer() to simplify devcd_readv(). Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off-by: Akinobu Mita --- drivers/base/devcoredump.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a

[PATCH 3/4] nvme-pci: add device coredump support

submission queue - cq: I/O completion queue Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off-by: Akinobu Mita --- drivers/nvme/host/Kconfig | 1 + drivers/nvme/host/pci.c | 221 ++ 2 files changed

[PATCH 2/4] devcoredump: allow to create several coredump files in one device

to create several device coredump files in one crashed device. Cc: Johannes Berg Cc: Keith Busch Cc: Jens Axboe Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off-by: Akinobu Mita --- drivers/base/devcoredump.c | 162 ++-- include/linux/devcoredump.h

[PATCH 0/4] nvme-pci: support device coredump

drivers to create several device coredump files in one crashed device. Akinobu Mita (4): devcoredump: use memory_read_from_buffer devcoredump: allow to create several coredump files in one device nvme-pci: add device coredump support nvme-pci: trigger device coredump before resetting controller

[PATCH] docs: fix typo in table describing 4.16 development cycle

Fix s/4.17/4.16/ typo. Fixes: 8962e40c1993 ("docs: update kernel versions and dates in tables") Cc: Tim Bird Cc: Jonathan Corbet Signed-off-by: Akinobu Mita --- Documentation/process/2.Process.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation

Re: Nokia N900: v4.16-rc4: oops in iio when grepping sysfs

2018-03-10 8:01 GMT+09:00 Pavel Machek : > Hi! > >> > Hmm. Looks like there's a lot of fun to be had with sysfs. >> > >> > >> > pavel@n900:~$ uname -a >> > Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8 19:53:30 CET >> > 2018 armv7l GNU/Linux >> > >> > [ 306.402496] bq2415x: command Tim

Re: [PATCH bpf-next v5 5/5] error-injection: Support fault injection framework

2018-01-13 2:56 GMT+09:00 Masami Hiramatsu : > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Here is the result of test script described in > Documentation/fault-injection/fault-injectio

Re: [PATCH bpf-next v4 5/5] error-injection: Support fault injection framework

2018-01-12 1:15 GMT+09:00 Masami Hiramatsu : > On Thu, 11 Jan 2018 23:44:57 +0900 > Akinobu Mita wrote: > >> 2018-01-11 9:51 GMT+09:00 Masami Hiramatsu : >> > Support in-kernel fault-injection framework via debugfs. >> > This allows you to inject a conditional

Re: [PATCH bpf-next v4 5/5] error-injection: Support fault injection framework

2018-01-11 9:51 GMT+09:00 Masami Hiramatsu : > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Here is the result of test script described in > Documentation/fault-injection/fault-injectio

Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection

e if the problem you reported is identical to the commit. > References: commit e41d58185f14 ("fault-inject: support systematic fault > injection") > Signed-off-by: Bart Van Assche > Cc: Dmitry Vyukov > Cc: Akinobu Mita > Cc: Michal Hocko > Cc: Andrew Morton >

[PATCH] fault-inject: fix wrong should_fail() decision in task context

us correct behaviour. Fixes: 1203c8e6fb0a ("fault-inject: simplify access check for fail-nth") Cc: Dmitry Vyukov Cc: Lu Fengqi Reported-by: Lu Fengqi Signed-off-by: Akinobu Mita --- lib/fault-inject.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/fault-

Re: [PATCH -mm] fault-inject: avoid unwanted data race to task->fail_nth

2017-08-02 0:54 GMT+09:00 Akinobu Mita : > 2017-08-01 22:45 GMT+09:00 Dmitry Vyukov : >> On Tue, Aug 1, 2017 at 3:09 PM, Lu Fengqi wrote: >>> On Fri, Jul 14, 2017 at 01:14:52AM +0900, Akinobu Mita wrote: >>>>The fault-inject-make-fail-nth-read-write-interface-s

Re: [PATCH -mm] fault-inject: avoid unwanted data race to task->fail_nth

2017-08-01 22:45 GMT+09:00 Dmitry Vyukov : > On Tue, Aug 1, 2017 at 3:09 PM, Lu Fengqi wrote: >> On Fri, Jul 14, 2017 at 01:14:52AM +0900, Akinobu Mita wrote: >>>The fault-inject-make-fail-nth-read-write-interface-symmetric.patch in >>>-mm tree allows users to set tas

Re: [PATCH -mm 3/5] fault-inject: make fail-nth read/write interface symmetric

2017-07-13 5:49 GMT+09:00 Andrew Morton : > On Fri, 7 Apr 2017 22:37:01 +0200 Dmitry Vyukov wrote: > >> On Thu, Apr 6, 2017 at 4:55 PM, Akinobu Mita wrote: >> > The read interface for fail-nth looks a bit odd. Read from this file >> > returns "N...&quo

[PATCH -mm] fault-inject: avoid unwanted data race to task->fail_nth

by: Dmitry Vyukov Signed-off-by: Akinobu Mita --- fs/proc/base.c | 5 +++-- lib/fault-inject.c | 7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index ecc8a25..719c2e9 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1370,7 +1370,7

[PATCH -mm] fault-inject: don't convert unsigned type value as signed int

This fixes fault-inject-simplify-access-check-for-fail-nth.patch in -mm tree which by mistake partially reverts the change by fault-inject- parse-as-natural-1-based-value-for-fail-nth-write-interface.patch. Cc: Dmitry Vyukov Reported-by: Dmitry Vyukov Signed-off-by: Akinobu Mita --- fs/proc

Re: [PATCH v2] fault-inject: support systematic fault injection

2017-04-09 2:40 GMT+09:00 Dmitry Vyukov : > On Fri, Apr 7, 2017 at 6:47 PM, Akinobu Mita wrote: >> 2017-04-07 3:33 GMT+09:00 Michal Hocko : >>> [Let's add linux-api - please always cc this list when adding/modifying >>> user visible interfaces] >>> &g

Re: [PATCH -mm 4/5] fault-inject: simplify access check for fail-nth

2017-04-08 5:45 GMT+09:00 Dmitry Vyukov : > On Thu, Apr 6, 2017 at 4:56 PM, Akinobu Mita wrote: >> The fail-nth file is created with 0666 and the access is permitted if >> and only if the task is current. >> >> This file is owned by the currnet user. So we can creat

Re: [PATCH v2] fault-inject: support systematic fault injection

t;stress testing better be done from an unprivileged user. >>Similarly, this would require opening the debugfs files to the >>unprivileged user, as he would need to reopen at least times file >>(not possible to pre-open before dropping privs). >> >> Th

[PATCH -mm 5/5] fault-inject: add /proc//fail-nth

fail-nth interface is only created in /proc/self/task//. This change also adds it in /proc//. This makes shell based tool a bit simpler. $ bash -c "builtin echo 100 > /proc/self/fail-nth && exec ls /" Cc: Dmitry Vyukov Signed-off-by: Akinobu Mita --- Document

[PATCH -mm 1/5] fault-inject: automatically detect the number base for fail-nth write interface

Automatically detect the number base to use when writing to fail-nth file instead of always parsing as a decimal number. Cc: Dmitry Vyukov Signed-off-by: Akinobu Mita --- fs/proc/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index

[PATCH -mm 4/5] fault-inject: simplify access check for fail-nth

try Vyukov Signed-off-by: Akinobu Mita --- fs/proc/base.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 9d14215..14e7b73 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1366,16 +1366,16 @@ static ssiz

[PATCH -mm 2/5] fault-inject: parse as natural 1-based value for fail-nth write interface

The value written to fail-nth file is parsed as 0-based. Parsing as one-based is more natural to understand and it enables to cancel the previous setup by simply writing '0'. This change also convert task->fail_nth from signed to unsigned int. Cc: Dmitry Vyukov Signed-off-by:

[PATCH -mm 3/5] fault-inject: make fail-nth read/write interface symmetric

th is reset to zero. Just returning task->fail_nth value is more natural to understand. Cc: Dmitry Vyukov Signed-off-by: Akinobu Mita --- Documentation/fault-injection/fault-injection.txt | 13 +++-- fs/proc/base.c| 14 ++ 2 files

[PATCH -mm 0/5] fault-inject: improve fail-nth interface

This series tries to improve fail-nth interface which was added to -mm tree recently. Akinobu Mita (5): fault-inject: automatically detect the number base for fail-nth write interface fault-inject: parse as natural 1-based value for fail-nth write interface fault-inject: make fail

  1   2   3   4   5   6   7   >