[PATCH] media: dt-bindings: media: Fixup Allwinner A10 CSI binding

2019-10-03 Thread Amit Kucheria
'dt_binding_check' failed make[1]: *** [dt_binding_check] Error 2 Fixes: c5e8f4ccd7750 ("media: dt-bindings: media: Add Allwinner A10 CSI binding") Signed-off-by: Amit Kucheria --- .../devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 7/9] arm64: dts: qcom: msm8998: Add PSCI cpuidle low power states

2019-09-30 Thread Amit Kucheria
Tue, May 21, 2019 at 3:38 AM Amit Kucheria > wrote: > > > > Add device bindings for cpuidle states for cpu devices. > > > > Cc: Marc Gonzalez > > Signed-off-by: Amit Kucheria > > Acked-by: Daniel Lezcano > > --- > > arch/arm64/boot/dts/q

Re: [PATCH v6 4/7] arm64: dts: meson: g12: Add minimal thermal zone

2019-09-30 Thread Amit Kucheria
On Sat, Sep 28, 2019 at 12:14 AM Guillaume La Roque wrote: > > Add minimal thermal zone for two temperature sensor > One is located close to the DDR and the other one is > located close to the PLLs (between the CPU and GPU) > > Acked-by: Martin Blumenstingl > Tested-by: Christian Hewitt >

Re: [PATCH v6 3/7] arm64: dts: amlogic: g12: add temperature sensor

2019-09-30 Thread Amit Kucheria
On Sat, Sep 28, 2019 at 12:14 AM Guillaume La Roque wrote: > > Add cpu and ddr temperature sensors for G12 Socs > > Reviewed-by: Martin Blumenstingl > Tested-by: Christian Hewitt > Tested-by: Kevin Hilman > Signed-off-by: Guillaume La Roque Reviewed-by: Amit Kucheria

Re: [PATCH v6 2/7] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-09-30 Thread Amit Kucheria
Tested-by: Kevin Hilman > Signed-off-by: Guillaume La Roque Reviewed-by: Amit Kucheria > --- > drivers/thermal/Kconfig | 11 + > drivers/thermal/Makefile | 1 + > drivers/thermal/amlogic_thermal.c | 333 ++ > 3 files changed, 345

Re: [PATCH v6 1/7] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal

2019-09-30 Thread Amit Kucheria
Hilman > Signed-off-by: Guillaume La Roque Reviewed-by: Amit Kucheria > --- > .../bindings/thermal/amlogic,thermal.yaml | 54 +++ > 1 file changed, 54 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml &g

Re: [PATCH v6 1/7] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal

2019-09-30 Thread Amit Kucheria
On Sat, Sep 28, 2019 at 12:14 AM Guillaume La Roque wrote: > > Adding the devicetree binding documentation for the Amlogic temperature > sensor found in the Amlogic Meson G12A and G12B SoCs. > > Reviewed-by: Rob Herring > Tested-by: Christian Hewitt > Tested-by: Kevin Hilman > Signed-off-by:

Re: [PATCH] thermal: st: Use devm_platform_ioremap_resource() in st_mmap_regmap_init()

2019-09-25 Thread Amit Kucheria
gned-off-by: Markus Elfring Reviewed-by: Amit Kucheria > --- > drivers/thermal/st/st_thermal_memmap.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/thermal/st/st_thermal_memmap.c > b/drivers/thermal/st/st_thermal_memmap.c > index a

Re: [PATCH v4 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
On Fri, Sep 20, 2019 at 3:09 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-09-20 15:07:25) > > On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd wrote: > > > > > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > > > Register upper-lower interr

Re: [PATCH v4 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
On Fri, Sep 20, 2019 at 3:07 PM Amit Kucheria wrote: > > On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd wrote: > > > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > > Register upper-lower interrupts for each of the two tsens controllers. > > >

Re: [PATCH v4 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
On Fri, Sep 20, 2019 at 3:02 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-09-20 14:52:24) > > Register upper-lower interrupts for each of the two tsens controllers. > > > > Signed-off-by: Amit Kucheria > > --- > > arch/a

[PATCH v4 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors

2019-09-20 Thread Amit Kucheria
msm8916 uses sensors 0, 1, 2, 4 and 5. Sensor 3 is NOT used. Fixup the device tree so that the correct sensor ID is used and as a result we can actually check the temperature for the cpu2_3 sensor. Signed-off-by: Amit Kucheria Reviewed-by: Daniel Lezcano Reviewed-by: Stephen Boyd --- arch

[PATCH v4 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema

2019-09-20 Thread Amit Kucheria
Older IP only supports the 'uplow' interrupt, but newer IP supports 'uplow' and 'critical' interrupts. Document interrupt support in the tsens driver by converting over to a YAML schema. Suggested-by: Stephen Boyd Signed-off-by: Amit Kucheria --- .../bindings/thermal/qcom-tsens.txt

[PATCH v4 04/15] drivers: thermal: tsens: Add debugfs support

2019-09-20 Thread Amit Kucheria
404000 Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- drivers/thermal/qcom/tsens-common.c | 83 + drivers/thermal/qcom/tsens.c| 2 + drivers/thermal/qcom/tsens.h| 6 +++ 3 files changed, 91 insertions(+) diff --git a/drivers/thermal

[PATCH v4 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements

2019-09-20 Thread Amit Kucheria
Printing the function name when enabling debugging makes logs easier to read. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens-common.c | 8 drivers/thermal/qcom/tsens.c| 6 +++--- 2 files changed, 7 insertions

[PATCH v4 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor

2019-09-20 Thread Amit Kucheria
-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens-8960.c | 4 ++-- drivers/thermal/qcom/tsens-common.c | 16 +--- drivers/thermal/qcom/tsens.c| 11 +-- drivers/thermal/qcom/tsens.h| 10 -- 4

[PATCH v4 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe

2019-09-20 Thread Amit Kucheria
Move platform_set_drvdata up to avoid an extra 'if (ret)' check after the call to tsens_register. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v4 00/15] thermal: qcom: tsens: Add interrupt support

2019-09-20 Thread Amit Kucheria
nst qcs404 and sdm845 and then tested on msm8916 and msm8974 (Thanks Brian). Testing on msm8998 would be appreciated since I don't have hardware handy. Amit Kucheria (15): drivers: thermal: tsens: Get rid of id field in tsens_sensor drivers: thermal: tsens: Simplify code flow in tsens_probe driver

[PATCH v4 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature

2019-09-20 Thread Amit Kucheria
Hide the details of how to convert values read from TSENS HW to mCelsius behind a function. All versions of the IP can be supported as a result. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 50 + 1 file changed, 36 insertions(+), 14

[PATCH v4 13/15] arm64: dts: msm8916: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916

[PATCH v4 11/15] arm64: dts: qcs404: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom

[PATCH v4 08/15] arm64: dts: sdm845: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +++- 1 file changed, 46 insertions(+), 42 deletions(-) diff --git a/arch/arm64/boot/dts/qcom

[PATCH v4 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor

2019-09-20 Thread Amit Kucheria
msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal zone for each of those sensors to expose the temperature of each zone. Signed-off-by: Amit Kucheria Tested-by: Brian Masney Reviewed-by: Stephen Boyd --- arch/arm/boot/dts/qcom-msm8974.dtsi | 90

[PATCH v4 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++- 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64

[PATCH v4 10/15] arm64: dts: msm8998: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 ++- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64

[PATCH v4 15/15] drivers: thermal: tsens: Add interrupt support

2019-09-20 Thread Amit Kucheria
status and clear. These differences are handled transparently by the interrupt handler. At each interrupt, we reprogram the new upper and lower threshold in the .set_trip callback. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 376 ++-- drivers

[PATCH v4 12/15] arm: dts: msm8974: thermal: Add interrupt support

2019-09-20 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria Tested-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 36 +++-- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch

Re: [PATCH v3 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema

2019-09-20 Thread Amit Kucheria
On Tue, Sep 17, 2019 at 12:06 PM Rob Herring wrote: > > On Wed, Sep 11, 2019 at 12:46:24PM +0530, Amit Kucheria wrote: > > Document interrupt support in the tsens driver by converting over to a > > YAML schema. > > > > Suggested-by: Stephen Boyd &g

Re: [PATCH 3/4] arm64: Kconfig: Fix VEXPRESS driver dependencies

2019-09-20 Thread Amit Kucheria
On Fri, Sep 13, 2019 at 3:12 AM Sudeep Holla wrote: > > On Thu, Sep 12, 2019 at 03:48:47AM +0530, Amit Kucheria wrote: > > Push various VEXPRESS drivers behind ARCH_VEXPRESS dependency so that it > > doesn't get enabled by default on other platforms. > > > > I coul

Re: [PATCH 5/5] cpufreq: qcom-hw: Move driver initialisation earlier

2019-09-20 Thread Amit Kucheria
Hi Sudeep, On Tue, Sep 17, 2019 at 6:20 AM Sudeep Holla wrote: > > On Tue, Sep 17, 2019 at 02:47:22PM +0200, Daniel Lezcano wrote: > > > > Hi Sudeep, > > > > On 17/09/2019 11:34, Sudeep Holla wrote: > > > On Thu, Sep 12, 2019 at 04:02:34AM +0530, Amit Kuch

Re: [PATCH 1/5] thermal: Initialize thermal subsystem earlier

2019-09-17 Thread Amit Kucheria
On Tue, Sep 17, 2019 at 1:30 AM Daniel Lezcano wrote: > > On 12/09/2019 00:32, Amit Kucheria wrote: > > From: Lina Iyer > > > > Now that the thermal framework is built-in, in order to facilitate > > thermal mitigation as early as possible in the boot cycle,

Re: [PATCH 4/5] clk: qcom: Initialise clock drivers earlier

2019-09-16 Thread Amit Kucheria
On Tue, Sep 17, 2019 at 1:24 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-09-11 15:32:33) > > Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we > > can have earlier access to cpufreq during booting. > > > > Signed-off-by: Amit Kuch

Re: [PATCH v4 1/6] dt-bindings: thermal: Add DT bindings documentation for Amlogic Thermal

2019-09-13 Thread Amit Kucheria
On Thu, Aug 22, 2019 at 3:54 AM Guillaume La Roque wrote: > > Adding the devicetree binding documentation for the Amlogic temperature > sensor found in the Amlogic Meson G12 SoCs. > the G12A and G12B SoCs are supported. Merge the two sentences into a single one? > Signed-off-by: Guillaume La

Re: [PATCH v4 2/6] thermal: amlogic: Add thermal driver to support G12 SoCs

2019-09-13 Thread Amit Kucheria
On Thu, Aug 22, 2019 at 3:54 AM Guillaume La Roque wrote: > > Amlogic G12A and G12B SoCs integrate two thermal sensors > with the same design. > One is located close to the DDR controller and the other one is > located close to the PLLs (between the CPU and GPU). Merge into one paragraph? > The

Re: [PATCH v4 4/6] arm64: dts: meson: sei510: Add minimal thermal zone

2019-09-13 Thread Amit Kucheria
On Thu, Aug 22, 2019 at 4:59 AM Kevin Hilman wrote: > > Guillaume La Roque writes: > > > Add minimal thermal zone for two temperature sensor > > One is located close to the DDR and the other one is > > located close to the PLLs (between the CPU and GPU) > > > > Signed-off-by: Guillaume La Roque

Re: [PATCH 0/4] Cleanup arm64 driver dependencies

2019-09-12 Thread Amit Kucheria
On Thu, Sep 12, 2019 at 3:17 PM Mark Brown wrote: > > On Thu, Sep 12, 2019 at 03:48:44AM +0530, Amit Kucheria wrote: > > > I was using initcall_debugging on a QCOM platform and ran across a bunch of > > driver initcalls that are enabled even if their SoC support is disab

Re: [PATCH 0/4] Cleanup arm64 driver dependencies

2019-09-12 Thread Amit Kucheria
Hi Arnd, On Thu, Sep 12, 2019 at 2:59 PM Arnd Bergmann wrote: > > On Thu, Sep 12, 2019 at 12:18 AM Amit Kucheria > wrote: > > > > I was using initcall_debugging on a QCOM platform and ran across a bunch of > > driver initcalls that are enabled even if th

[PATCH 1/5] thermal: Initialize thermal subsystem earlier

2019-09-11 Thread Amit Kucheria
in the boot process, the userspace is not available yet. So initialize the netlink events later in fs_initcall. Signed-off-by: Lina Iyer [Rebased, refactored and moved to core_initcall] Signed-off-by: Amit Kucheria --- drivers/thermal/thermal_core.c | 41 -- 1 file

[PATCH 2/5] cpufreq: Initialise the governors in core_initcall

2019-09-11 Thread Amit Kucheria
Initialise the cpufreq governors earlier to allow for earlier performance control during the boot process. Signed-off-by: Amit Kucheria --- drivers/cpufreq/cpufreq_conservative.c | 2 +- drivers/cpufreq/cpufreq_ondemand.c | 2 +- drivers/cpufreq/cpufreq_performance.c | 2 +- drivers

[PATCH 5/5] cpufreq: qcom-hw: Move driver initialisation earlier

2019-09-11 Thread Amit Kucheria
Allow qcom-hw driver to initialise right after the cpufreq and thermal subsystems are initialised in core_initcall so we get earlier access to thermal mitigation. Signed-off-by: Amit Kucheria --- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/5] Initialise thermal framework earlier during boot

2019-09-11 Thread Amit Kucheria
devices. This series only converts over the qcom-hw driver to initialize earlier but can be extended to other platforms as well. Amit Kucheria (4): cpufreq: Initialise the governors in core_initcall cpufreq: Initialize cpufreq-dt driver earlier clk: qcom: Initialise clock drivers earlier

[PATCH 3/5] cpufreq: Initialize cpufreq-dt driver earlier

2019-09-11 Thread Amit Kucheria
This allows HW drivers that depend on cpufreq-dt to initialise earlier. Signed-off-by: Amit Kucheria --- drivers/cpufreq/cpufreq-dt-platdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index

[PATCH 4/5] clk: qcom: Initialise clock drivers earlier

2019-09-11 Thread Amit Kucheria
Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we can have earlier access to cpufreq during booting. Signed-off-by: Amit Kucheria --- drivers/clk/qcom/clk-rpmh.c | 2 +- drivers/clk/qcom/gcc-qcs404.c | 2 +- drivers/clk/qcom/gcc-sdm845.c | 2 +- 3 files changed, 3

[PATCH 1/4] arm64: Kconfig: Fix XGENE driver dependencies

2019-09-11 Thread Amit Kucheria
Push various XGENE drivers behind ARCH_XGENE dependency so that it doesn't get enabled by default on other platforms. Signed-off-by: Amit Kucheria --- arch/arm64/Kconfig.platforms | 3 +++ drivers/clk/Kconfig| 2 +- drivers/gpio/Kconfig | 1 + drivers/pci/controller

[PATCH 3/4] arm64: Kconfig: Fix VEXPRESS driver dependencies

2019-09-11 Thread Amit Kucheria
Push various VEXPRESS drivers behind ARCH_VEXPRESS dependency so that it doesn't get enabled by default on other platforms. Signed-off-by: Amit Kucheria --- drivers/bus/Kconfig | 2 +- drivers/clk/versatile/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 4/4] arm64: Kconfig: Fix EXYNOS driver dependencies

2019-09-11 Thread Amit Kucheria
Push various EXYNOS drivers behind ARCH_EXYNOS dependency so that it doesn't get enabled by default on other platforms. Signed-off-by: Amit Kucheria --- drivers/clk/Kconfig | 1 + drivers/regulator/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/clk/Kconfig b/drivers

[PATCH 2/4] arm64: Kconfig: Fix BRCMSTB driver dependencies

2019-09-11 Thread Amit Kucheria
Push various BRCMSTB drivers behind ARCH_BRCMSTB dependency so that it doesn't get enabled by default on other platforms. Signed-off-by: Amit Kucheria --- drivers/bus/Kconfig | 1 + drivers/power/reset/Kconfig | 1 + drivers/soc/bcm/Kconfig | 1 + 3 files changed, 3 insertions

[PATCH 0/4] Cleanup arm64 driver dependencies

2019-09-11 Thread Amit Kucheria
I was using initcall_debugging on a QCOM platform and ran across a bunch of driver initcalls that are enabled even if their SoC support is disabled. Here are some fixups for a subset of them. Amit Kucheria (4): arm64: Kconfig: Fix XGENE driver dependencies arm64: Kconfig: Fix BRCMSTB driver

[PATCH v3 15/15] drivers: thermal: tsens: Add interrupt support

2019-09-11 Thread Amit Kucheria
status and clear. These differences are handled transparently by the interrupt handler. At each interrupt, we reprogram the new upper and lower threshold in the .set_trip callback. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 376 ++-- drivers

[PATCH v3 12/15] arm: dts: msm8974: thermal: Add interrupt support

2019-09-11 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria Tested-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 36 +++-- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch

[PATCH v3 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature

2019-09-11 Thread Amit Kucheria
Hide the details of how to convert values read from TSENS HW to mCelsius behind a function. All versions of the IP can be supported as a result. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 50 + 1 file changed, 36 insertions(+), 14

[PATCH v3 11/15] arm64: dts: qcs404: thermal: Add interrupt support

2019-09-11 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom

[PATCH v3 10/15] arm64: dts: msm8998: thermal: Add interrupt support

2019-09-11 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 ++- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64

[PATCH v3 13/15] arm64: dts: msm8916: thermal: Add interrupt support

2019-09-11 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916

[PATCH v3 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-09-11 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++- 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64

[PATCH v3 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema

2019-09-11 Thread Amit Kucheria
Document interrupt support in the tsens driver by converting over to a YAML schema. Suggested-by: Stephen Boyd Signed-off-by: Amit Kucheria --- .../bindings/thermal/qcom-tsens.txt | 55 -- .../bindings/thermal/qcom-tsens.yaml | 174 ++ MAINTAINERS

[PATCH v3 04/15] drivers: thermal: tsens: Add debugfs support

2019-09-11 Thread Amit Kucheria
404000 Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- drivers/thermal/qcom/tsens-common.c | 83 + drivers/thermal/qcom/tsens.c| 2 + drivers/thermal/qcom/tsens.h| 6 +++ 3 files changed, 91 insertions(+) diff --git a/drivers/thermal

[PATCH v3 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements

2019-09-11 Thread Amit Kucheria
Printing the function name when enabling debugging makes logs easier to read. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens-common.c | 8 drivers/thermal/qcom/tsens.c| 6 +++--- 2 files changed, 7 insertions

[PATCH v3 08/15] arm64: dts: sdm845: thermal: Add interrupt support

2019-09-11 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +++- 1 file changed, 46 insertions(+), 42 deletions(-) diff --git a/arch/arm64/boot/dts/qcom

[PATCH v3 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe

2019-09-11 Thread Amit Kucheria
Move platform_set_drvdata up to avoid an extra 'if (ret)' check after the call to tsens_register. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v3 00/15] thermal: qcom: tsens: Add interrupt support

2019-09-11 Thread Amit Kucheria
). Testing on msm8998 would be appreciated since I don't have hardware handy. Amit Kucheria (15): drivers: thermal: tsens: Get rid of id field in tsens_sensor drivers: thermal: tsens: Simplify code flow in tsens_probe drivers: thermal: tsens: Add __func__ identifier to debug statements driver

[PATCH v3 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor

2019-09-11 Thread Amit Kucheria
-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens-8960.c | 4 ++-- drivers/thermal/qcom/tsens-common.c | 16 +--- drivers/thermal/qcom/tsens.c| 11 +-- drivers/thermal/qcom/tsens.h| 10 -- 4

[PATCH v3 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor

2019-09-11 Thread Amit Kucheria
msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal zone for each of those sensors to expose the temperature of each zone. Signed-off-by: Amit Kucheria Tested-by: Brian Masney Reviewed-by: Stephen Boyd --- arch/arm/boot/dts/qcom-msm8974.dtsi | 90

[PATCH v3 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors

2019-09-11 Thread Amit Kucheria
msm8916 uses sensors 0, 1, 2, 4 and 5. Sensor 3 is NOT used. Fixup the device tree so that the correct sensor ID is used and as a result we can actually check the temperature for the cpu2_3 sensor. Signed-off-by: Amit Kucheria Reviewed-by: Daniel Lezcano Reviewed-by: Stephen Boyd --- arch

Re: [PATCH v2 15/15] drivers: thermal: tsens: Add interrupt support

2019-09-10 Thread Amit Kucheria
Hi Thara, Thanks for the review. Please find replies below. On Thu, Aug 29, 2019 at 9:23 AM Thara Gopinath wrote: > > Hi Amit, > > On 08/27/2019 08:14 AM, Amit Kucheria wrote: > > Depending on the IP version, TSENS supports upper, lower, max, min and > > critical thres

Re: [PATCH -next 08/15] thermal: tsens: use devm_platform_ioremap_resource() to simplify code

2019-09-05 Thread Amit Kucheria
On Wed, Sep 4, 2019 at 6:05 PM YueHaibing wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Amit Kucheria > --- > drivers/thermal

Re: [PATCH v2 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-08-30 Thread Amit Kucheria
On Wed, Aug 28, 2019 at 6:05 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-27 05:14:05) > > Register upper-lower interrupts for each of the two tsens controllers. > > > > Signed-off-by: Amit Kucheria > > --- > > arch/a

Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-30 Thread Amit Kucheria
On Fri, Aug 30, 2019 at 9:25 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-30 04:32:54) > > On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria > > wrote: > > > > > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > > > &

Re: [PATCH 0/5] dt-bindings: arm: idle-states: Miscellaneous improvements

2019-08-30 Thread Amit Kucheria
int guarantees", > - Add punctuation marks to improve readability, > - Move exit-latency-us explanation to exit-latency-us section. > > Signed-off-by: Geert Uytterhoeven This improves the readability of the doc. So for the series, feel free to add Reviewed-by: Amit Kucheria

Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-30 Thread Amit Kucheria
On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria wrote: > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > > > Quoting Amit Kucheria (2019-08-29 01:48:27) > > > On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd wrote: > > > > > > &

Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-29 Thread Amit Kucheria
On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-29 01:48:27) > > On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd wrote: > > > > > > Quoting Amit Kucheria (2019-08-27 05:14:03) > > > > Define two ne

Re: [PATCH v2 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements

2019-08-29 Thread Amit Kucheria
On Thu, Aug 29, 2019 at 8:49 PM Daniel Thompson wrote: > > On Thu, Aug 29, 2019 at 07:58:45PM +0530, Amit Kucheria wrote: > > On Thu, Aug 29, 2019 at 7:35 PM Daniel Thompson > > wrote: > > > > > > On Tue, Aug 27, 2019 at 05:43:59PM +0530, Amit Kucheria wrote

Re: [PATCH v2 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements

2019-08-29 Thread Amit Kucheria
On Thu, Aug 29, 2019 at 7:35 PM Daniel Thompson wrote: > > On Tue, Aug 27, 2019 at 05:43:59PM +0530, Amit Kucheria wrote: > > Printing the function name when enabling debugging makes logs easier to > > read. > > > > Signed-off-by: Amit Kucheria > > Rev

Re: [PATCH v2 15/15] drivers: thermal: tsens: Add interrupt support

2019-08-29 Thread Amit Kucheria
On Thu, Aug 29, 2019 at 3:12 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-27 05:14:11) > > diff --git a/drivers/thermal/qcom/tsens-common.c > > b/drivers/thermal/qcom/tsens-common.c > > index 06b44cfd5eab9..c549f8e1488ba 100644 > > --- a/drivers/thermal

Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-29 Thread Amit Kucheria
On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-27 05:14:03) > > Define two new required properties to define interrupts and > > interrupt-names for tsens. > > > > Signed-off-by: Amit Kucheria > > --- > > Docu

[PATCH v2 15/15] drivers: thermal: tsens: Add interrupt support

2019-08-27 Thread Amit Kucheria
to denote status and clear. At each interrupt, we reprogram the new upper and lower threshold in the .set_trip callback. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 377 ++-- drivers/thermal/qcom/tsens-v0_1.c | 11 + drivers/thermal/qcom/tsens-v1

[PATCH v2 08/15] arm64: dts: sdm845: thermal: Add interrupt support

2019-08-27 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 88 +++- 1 file changed, 46 insertions(+), 42 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot

[PATCH v2 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature

2019-08-27 Thread Amit Kucheria
Hide the details of how to convert values read from TSENS HW to mCelsius behind a function. All versions of the IP can be supported as a result. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 50 + drivers/thermal/qcom/tsens.h| 2

[PATCH v2 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors

2019-08-27 Thread Amit Kucheria
msm8916 uses sensors 0, 1, 2, 4 and 5. Sensor 3 is NOT used. Fixup the device tree so that the correct sensor ID is used and as a result we can actually check the temperature for the cpu2_3 sensor. Signed-off-by: Amit Kucheria Reviewed-by: Daniel Lezcano --- arch/arm64/boot/dts/qcom/msm8916

[PATCH v2 09/15] arm64: dts: msm8996: thermal: Add interrupt support

2019-08-27 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 60 ++- 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64

[PATCH v2 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe

2019-08-27 Thread Amit Kucheria
Move platform_set_drvdata up to avoid an extra 'if (ret)' check after the call to tsens_register. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v2 12/15] arm: dts: msm8974: thermal: Add interrupt support

2019-08-27 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria Tested-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 36 +++-- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch

[PATCH v2 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor

2019-08-27 Thread Amit Kucheria
-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens-8960.c | 4 ++-- drivers/thermal/qcom/tsens-common.c | 16 +--- drivers/thermal/qcom/tsens.c| 11 +-- drivers/thermal/qcom/tsens.h| 10 -- 4

[PATCH v2 13/15] arm64: dts: msm8916: thermal: Add interrupt support

2019-08-27 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916

[PATCH v2 11/15] arm64: dts: qcs404: thermal: Add interrupt support

2019-08-27 Thread Amit Kucheria
Register upper-lower interrupt for the tsens controller. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 42 +++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom

[PATCH v2 04/15] drivers: thermal: tsens: Add debugfs support

2019-08-27 Thread Amit Kucheria
404000 Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 83 + drivers/thermal/qcom/tsens.c| 2 + drivers/thermal/qcom/tsens.h| 6 +++ 3 files changed, 91 insertions(+) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers

[PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver

2019-08-27 Thread Amit Kucheria
Define two new required properties to define interrupts and interrupt-names for tsens. Signed-off-by: Amit Kucheria --- Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt

[PATCH v2 10/15] arm64: dts: msm8998: thermal: Add interrupt support

2019-08-27 Thread Amit Kucheria
Register upper-lower interrupts for each of the two tsens controllers. Signed-off-by: Amit Kucheria --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 82 ++- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64

[PATCH v2 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor

2019-08-27 Thread Amit Kucheria
msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal zone for each of those sensors to expose the temperature of each zone. Signed-off-by: Amit Kucheria Tested-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 90 + 1 file changed, 90

[PATCH v2 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements

2019-08-27 Thread Amit Kucheria
Printing the function name when enabling debugging makes logs easier to read. Signed-off-by: Amit Kucheria Reviewed-by: Stephen Boyd Reviewed-by: Daniel Lezcano --- drivers/thermal/qcom/tsens-common.c | 8 drivers/thermal/qcom/tsens.c| 6 +++--- 2 files changed, 7 insertions

[PATCH v2 00/15] thermal: qcom: tsens: Add interrupt support

2019-08-27 Thread Amit Kucheria
on msm8916 and msm8974 (Thanks Brian). Testing on msm8998 would be appreciated since I don't have hardware handy. Amit Kucheria (15): drivers: thermal: tsens: Get rid of id field in tsens_sensor drivers: thermal: tsens: Simplify code flow in tsens_probe drivers: thermal: tsens: Add __func__ identifie

Re: [PATCH] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read

2019-08-23 Thread Amit Kucheria
xc0 > [] __device_attach_driver+0x9c/0xac > [] bus_for_each_drv+0x60/0x8c > [] __device_attach+0x8c/0x100 > [] device_initial_probe+0x20/0x28 > [] bus_probe_device+0x34/0x7c > [] deferred_probe_work_func+0x6c/0x98 > [] process_one_work+0x160/0x2f

Re: [PATCH 15/15] drivers: thermal: tsens: Add interrupt support

2019-08-22 Thread Amit Kucheria
Hi Stephen, Thanks for the thorough review. On Sat, Aug 17, 2019 at 11:39 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-07-25 15:18:50) > > diff --git a/drivers/thermal/qcom/tsens-common.c > > b/drivers/thermal/qcom/tsens-common.c > > index 13a875b99

Re: [PATCH v4 1/8] arm64: dts: qcom: sm8150: Add base dts file

2019-08-21 Thread Amit Kucheria
> +#include This include isn't strictly needed until patch 8, I believe. Sorry didn't catch this earlier. Other than that, for the series, Reviewed-by: Amit Kucheria > +#include > + > +/ { > + interrupt-parent = <>; > + > + #address-cells = <2>;

Re: [PATCH 04/15] drivers: thermal: tsens: Add debugfs support

2019-08-21 Thread Amit Kucheria
On Mon, Aug 19, 2019 at 7:57 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-19 00:58:23) > > On Sat, Aug 17, 2019 at 9:37 AM Stephen Boyd wrote: > > > > + > > > > +static void tsens_debug_init(struct platform_device *pdev) > > >

[PATCH] MAINTAINERS: Add Amit Kucheria as reviewer for thermal

2019-08-21 Thread Amit Kucheria
Add Amit Kucheria as the reviewer for thermal as he would like to participate in the review process effort for the thermal framework. Signed-off-by: Amit Kucheria --- Hi thermal maintainers, I'd like to help out with reviewing patches to the thermal framework. I respectfully submit this patch

Re: [PATCH v3 8/8] arm64: dts: qcom: sm8150: Add apps shared nodes

2019-08-21 Thread Amit Kucheria
On Tue, Aug 20, 2019 at 10:55 PM Vinod Koul wrote: > > Add hwlock, pmu, smem, tcsr_mutex_regs, apss_shared mailbox, apps_rsc > including the rpmhcc child nodes to the SM8150 DTSI > > Co-developed-by: Sibi Sankar > Signed-off-by: Sibi Sankar > Signed-off-by: Vinod Koul > --- >

Re: [PATCH v3 5/8] arm64: dts: qcom: sm8150-mtp: add base dts file

2019-08-21 Thread Amit Kucheria
On Tue, Aug 20, 2019 at 10:55 PM Vinod Koul wrote: > > This add base DTS file for sm8150-mtp and enables boot to console, adds > tlmm reserved range, resin node, volume down key and also includes pmic > file. For some reason, your mailer sent out 2 patches 5/8. I was wondering why the patch 5

Re: [PATCH v2 1/8] arm64: dts: qcom: sm8150: add base dts file

2019-08-20 Thread Amit Kucheria
On Tue, Aug 20, 2019 at 12:14 PM Vinod Koul wrote: > > This add base DTS file with cpu, psci, firmware, clock, tlmm and > spmi nodes which enables boot to console > > Signed-off-by: Vinod Koul > --- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 305 +++ > 1 file changed, 305

Re: [PATCH 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature

2019-08-19 Thread Amit Kucheria
On Sat, Aug 17, 2019 at 9:46 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-07-25 15:18:49) > > diff --git a/drivers/thermal/qcom/tsens-common.c > > b/drivers/thermal/qcom/tsens-common.c > > index 7ab2e740a1da..13a875b99094 100644 > > --- a/drivers/thermal

<    1   2   3   4   5   6   7   8   9   10   >