On Wed, Aug 29, 2018 at 3:09 PM Daniel Lezcano
wrote:
>
> On 18/07/2018 09:49, Amit Kucheria wrote:
> > One thermal zone per cpu is defined
>
> The thermal zones are very close, especially when the CPUs belong to the
> same 'cluster'. Very likely the temperature wi
Andy,
Do you have any feedback for this patch?
Regards,
Amit
On Wed, Jul 18, 2018 at 1:19 PM, Amit Kucheria wrote:
> One thermal zone per cpu is defined
>
> Signed-off-by: Amit Kucheria
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 170
> +++
Create an entry for the TSENS drivers and mark them as maintained
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
Acked-by: Rajendra Nayak
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index a5b256b25905..b8c96e0699c9 100644
The SROT registers are initialised by the secure firmware at boot. We
don't have write access to the registers. Check if the block is enabled
before continuing.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens-common.c | 17 +
1
The TSENS drivers use a GPL-2.0 license. Replace with equivalent SPDX
tags and delete the full license text.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens-8916.c | 11 +--
drivers/thermal/qcom/tsens-8960.c | 11 +--
drivers
ld instead of the id field consistently across the
tsens code.
While we're at it, document the fields of struct tsens_sensor.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens.c | 5 ++---
drivers/thermal/qcom/tsens.h | 10 +-
2 files changed
c(1) + x(1) was actually meant to be c(1) * x(1).
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/thermal/thermal.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings
-0c2651fe : thermal-sensor@c265000
becomes
0c222000-0c2221fe : tsens0_srot
0c223000-0c2231fe : tsens1_srot
0c263000-0c2631fe : tsens0_tm
0c265000-0c2651fe : tsens1_tm
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 1 +
arch/arm64/boot/dts/qcom
On platforms whose device trees specify two address spaces for TSENS, the
second one points to the SROT registers. Initialise the SROT map on those
platforms.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens-common.c | 14 --
drivers
more appropriate "tm_map".
The 8960 doesn't have a clear split between TM and SROT registers. To avoid
complicating the data structure, it will switchover to using tm_map for its
maps.
There is no functional change with this patch.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias K
hw_id is dynamically allocated but not used anywhere. Get rid of dead
code.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index
This new property allows the number of sensors to be configured from DT
instead of being hardcoded in platform data. Use it.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 1 +
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
2 files changed
Since tsens-common.c/init_common() currently only registers one address
space, the order is important (TM before SROT). This is OK since the
code doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
arch/arm/boot/dts/qcom-msm8974.
added qcom,sensors
property into two separate patches
- Remove brackets in typo correction patch
Amit Kucheria (11):
arm/arm64: dts: msm8974/msm8916: thermal: Split address space into two
arm/arm64: dts: msm8974/msm8916: thermal: Add "qcom,sensors" property
dt-bindings: thermal:
On Sat, Aug 25, 2018 at 5:00 AM Eduardo Valentin wrote:
>
> On Thu, Aug 09, 2018 at 06:02:39PM +0530, Amit Kucheria wrote:
> > The SROT registers are initialised by the secure firmware at boot. We
> > don't have write access to the registers. Check if the block is enable
On Sat, Aug 25, 2018 at 4:58 AM Eduardo Valentin wrote:
>
> On Thu, Aug 09, 2018 at 06:02:33PM +0530, Amit Kucheria wrote:
> > We've earlier added support to split the register address space into TM
> > and SROT regions.
> >
> > Split up the regmap addre
(Adding arm-soc folks)
On Thu, Aug 23, 2018 at 9:01 PM, Sudeep Holla wrote:
> Hi Amit,
>
> Thanks for fixing this.
>
> On Thu, Aug 23, 2018 at 02:23:29PM +0530, Amit Kucheria wrote:
>> The idle-states binding documentation[1] mentions that the
>> 'entry-method
f various boards to reflect current
documentation.
[1] Documentation/devicetree/bindings/arm/idle-states.txt (see
idle-states node)
Signed-off-by: Amit Kucheria
---
Documentation/devicetree/bindings/arm/cpu-capacity.txt | 2 +-
Documentation/devicetree/bindings/arm/idle-states.txt | 4 ++--
On Fri, Aug 10, 2018 at 12:41 AM Matthias Kaehlcke wrote:
>
> On Thu, Aug 09, 2018 at 06:02:33PM +0530, Amit Kucheria wrote:
> > We've earlier added support to split the register address space into TM
> > and SROT regions.
> >
> > Split up the regmap addre
-0c2651fe : thermal-sensor@c265000
becomes
0c222000-0c2221fe : tsens0_srot
0c223000-0c2231fe : tsens1_srot
0c263000-0c2631fe : tsens0_tm
0c265000-0c2651fe : tsens1_tm
Signed-off-by: Amit Kucheria
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 1 +
arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 +
arch/arm64
ld instead of the id field consistently across the
tsens code.
While, we're at it, document the fields of struct tsens_sensor.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens.c | 5 ++---
drivers/thermal/qcom/tsens.h | 10 +-
2 files changed, 11 insertions(+), 4 deletions
Create an entry for the TSENS drivers and mark them as maintained
Signed-off-by: Amit Kucheria
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 68b4ff8ed205..ca6183d6d545 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11862,6 +11862,13
On platforms whose device trees specify two address spaces for TSENS, the
second one points to the SROT registers. Initialise the SROT map on those
platforms.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-common.c | 14 --
drivers/thermal/qcom/tsens.h| 1 +
2
The SROT registers are initialised by the secure firmware at boot. We
don't have write access to the registers. Check if the block is enabled
before continuing.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-common.c | 17 +
1 file changed, 17 insertions(+)
more appropriate "tm_map".
The 8960 doesn't have a clear split between TM and SROT registers. To avoid
complicating the data structure, it will switchover to using tm_map for its
maps.
There is no functional change with this patch.
Signed-off-by: Amit Kucheria
---
Since tsens-common.c/init_common() currently only registers one address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 6 --
arch/arm64/boo
hw_id is dynamically allocated but not used anywhere. Get rid of dead
code.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 90bb431cf740..9a8e8f7b4ae1 100644
The TSENS drivers use a GPL-2.0 license. Replace with equivalent SPDX
tags and delete the full license text.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-8916.c | 11 +--
drivers/thermal/qcom/tsens-8960.c | 11 +--
drivers/thermal/qcom/tsens-8974.c | 11
c(1) + x(1) was actually meant to be c(1) * x(1).
While we're at it, add some brackets to make it nicer to read.
Signed-off-by: Amit Kucheria
---
Documentation/devicetree/bindings/thermal/thermal.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devic
,
Amit
[1] https://lore.kernel.org/lkml/cover.1531895128.git.amit.kuche...@linaro.org/
[2] https://lore.kernel.org/lkml/cover.1532600791.git.amit.kuche...@linaro.org/
Amit Kucheria (10):
arm/arm64: dts: msm8974/msm8916: thermal: Split address space into two
dt-bindings: thermal: Fix a typo in
On Fri, Jul 27, 2018 at 2:38 AM Eduardo Valentin wrote:
>
> Hey Amit,
>
>
> On Thu, Jul 26, 2018 at 04:03:07PM +0530, Amit Kucheria wrote:
> > Here is another series of tsens-related bugfixes and cleanups to prepare
> > for IRQ support, among other things. It applies
devm_ioremap_resources() automatically requests resources (so that the I/O
region shows up in /proc/iomem) and devm_ wrappers do better error handling
and unmapping of the I/O region when needed.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens
We're actually reading the temperature from the status register. Fix the
variable name to reflect that.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens-common.c | 6 +++---
drivers/thermal/qcom/tsens-v2.c | 10 +-
2 files chang
The current code will always return 0x in case of negative
temperatures due to a bug in how the binary sign extension is being done.
Use sign_extend32() instead.
Signed-off-by: Amit Kucheria
Reviewed-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens-v2.c | 13 +
1 file
Changes since v1:
- Fixup a couple of typos
- Add review tag
Amit Kucheria (3):
thermal: tsens: Rename variable
thermal: tsens: switch from of_iomap() to devm_ioremap_resource()
thermal: tsens: Fix negative temperature reporting
drivers/thermal/qcom/tsens-common.c | 19
On Thu, Jul 26, 2018 at 5:19 AM, Matthias Kaehlcke wrote:
> On Wed, Jul 18, 2018 at 12:55:03PM +0530, Amit Kucheria wrote:
>> The current code will always return 0x in case of negative
>> temperatures due to a bug in how the binary sign extension is being done.
>>
On Thu, Jul 26, 2018 at 6:17 AM, Matthias Kaehlcke wrote:
> Hi Amit,
>
> On Wed, Jul 18, 2018 at 01:19:17PM +0530, Amit Kucheria wrote:
>> One thermal zone per cpu is defined
>>
>> Signed-off-by: Amit Kucheria
>> ---
>> arc
Andy, Eduardo: Please consider this a gentle ping to understand how
this will get merged.
Andy, I guess you'll take the DT patches 2,4 and 7 and the rest will
go through Eduardo's thermal tree?
Regards,
Amit
On Wed, Jul 18, 2018 at 12:13 PM, Amit Kucheria
wrote:
> Here is a
property (clock latency) as well to make it all
> work.
>
> Signed-off-by: Viresh Kumar
FWIW,
Reviewed-by: Amit Kucheria
> ---
> arch/arm/boot/dts/qcom-ipq4019.dtsi | 24
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts
On Wed, Jul 18, 2018 at 2:18 AM, Niklas Cassel wrote:
> If of_nvmem_cell_get() fails due to probe deferal, we shouldn't print an
> error message. Just be silent in this case.
>
> Signed-off-by: Niklas Cassel
Reviewed-by: Amit Kucheria
> ---
> drivers/cpufreq/
One thermal zone per cpu is defined
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 170 +++
1 file changed, 170 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 01ff146
The current code will always return 0x in case of negative
temperatures due to a bug in how the binary sign extension is being done.
Use sign_extend32() instead.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-v2.c | 13 +
1 file changed, 5 insertions(+), 8
devm_ioremap_resources() automatically requests resources (so that the I/O
region shows up in /proc/iomem) and devm_ wrappers do better error handling
and unmapping of the I/O region when needed.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-common.c | 13 +++--
1 file
Amit Kucheria (3):
thermal: tsens: Rename variable
thermal: tsens: switch from of_iomap() to devm_ioremap_resource()
thermal: tsens: Fix negative temperature reporting
drivers/thermal/qcom/tsens-common.c | 19 ++-
drivers/thermal/qcom/tsens-v2.c | 23
We're actually reading the temperature from the status register. Fix the
variable name to reflect that.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-common.c | 6 +++---
drivers/thermal/qcom/tsens-v2.c | 10 +-
2 files changed, 8 insertions(+), 8 deletions(-)
The TSENS block inside the 8996 is internally classified as version 2 of
the IP. Several other SoC families use this block and can share this code.
We rename get_temp() to reflect that it can be used across the v2 family.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by
SDM845 has two tsens blocks, one with 13 sensors and the other with 8
sensors. It uses version 2 of the TSENS IP, so use the fallback property to
allow more common code.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
Reviewed-by: Matthias Kaehlcke
SDM845 uses v2 of the TSENS IP block but the get_temp() function appears to
be identical across v2.x.y in code seen so far. We use the generic
get_temp() function defined as part of ops_generic_v2.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
Reviewed
() currently only registers one address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
Reviewed-by: Matthias Kaehlcke
Review
M and SROT
register banks because their offsets are not constant across SoC families.
Signed-off-by: Amit Kucheria
Reviewed-by: Rob Herring
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
Reviewed-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
---
.../devicetree/bindings/th
DTs and
adjust associated offsets for the TM register bank so that the old DTs will
continue to function correctly.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
Reviewed-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
---
drivers/thermal/qcom
river on sdm845, now that
4.18-rc1 will contain an sdm845.dtsi
Changes since v1:
- Move get_temp() from tsens-8996 to tsens-common and rename
- Change 8996 DT entry to allow init_common() to work across
sdm845 and 8996 due to different offsets
Amit Kucheria (7):
thermal: tsens: Get rid of u
On Wed, Jul 18, 2018 at 5:39 AM, Matthias Kaehlcke wrote:
> On Thu, Jul 12, 2018 at 02:09:06PM +0530, Amit Kucheria wrote:
>> We want to create common code for v2 of the TSENS IP block that is used in
>> a large number of Qualcomm SoCs. "qcom,tsens-v2" should be able
status_field and trdy are unused in any of the tsens drivers. Remove them.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Acked-by: Rajendra Nayak
Tested-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thermal
On Wed, Jul 18, 2018 at 4:59 AM Matthias Kaehlcke wrote:
>
> On Thu, Jul 12, 2018 at 02:09:03PM +0530, Amit Kucheria wrote:
> > There are two banks of registers for v2 TSENS IPs: SROT and TM. On older
> > SoCs these were contiguous, leading to DTs mapping them as one register
&g
SDM845 has two tsens blocks, one with 13 sensors and the other with 8
sensors. It uses version 2 of the TSENS IP, so use the fallback property to
allow more common code.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/sdm845
The TSENS block inside the 8996 is internally classified as version 2 of
the IP. Several other SoC families use this block and can share this code.
We rename get_temp() to reflect that it can be used across the v2 family.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by
M and SROT
register banks because their offsets are not constant across SoC families.
Signed-off-by: Amit Kucheria
Reviewed-by: Rob Herring
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
---
.../devicetree/bindings/thermal/qcom-tsens.txt | 31 +-
1 file c
a DT patch to initialize tsens driver on sdm845, now that
4.18-rc1 will contain an sdm845.dtsi
Changes since v1:
- Move get_temp() from tsens-8996 to tsens-common and rename
- Change 8996 DT entry to allow init_common() to work across
sdm845 and 8996 due to different offsets
Amit Kucheria (7):
SDM845 uses v2 of the TSENS IP block but the get_temp() function appears to
be identical across v2.x.y in code seen so far. We use the generic
get_temp() function defined as part of ops_generic_v2.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
() currently only registers one address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
---
arch/arm64/boot/dts/qcom/msm8996.dtsi
DTs and
adjust associated offsets for the TM register bank so that the old DTs will
continue to function correctly.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Tested-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens-8996.c | 4 ++--
drivers/thermal/qcom/tsens-common.c | 12
status_field and trdy are unused in any of the tsens drivers. Remove them.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Acked-by: Rajendra Nayak
Tested-by: Matthias Kaehlcke
---
drivers/thermal/qcom/tsens.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thermal
On Thu, Jul 12, 2018 at 12:12 AM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Jul 9, 2018 at 4:43 AM, Amit Kucheria
> wrote:
> > We want to create common code for v2 of the TSENS IP block that is used in
> > a large number of Qualcomm SoCs. "qcom,tsens-v2" sho
On Thu, Jul 12, 2018 at 3:30 AM Doug Anderson wrote:
>
> Hi Matthias,
>
> On Wed, Jul 11, 2018 at 2:51 PM, Matthias Kaehlcke wrote:
> > On Wed, Jul 11, 2018 at 11:44:13AM -0700, Doug Anderson wrote:
> >> Hi,
> >>
> >> On Mon, Jul 9, 2018 at 4:43 AM,
On Thu, Jul 12, 2018 at 12:10 AM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Jul 9, 2018 at 4:43 AM, Amit Kucheria
> wrote:
> > SDM845 uses v2 of the TSENS IP block but the get_temp() function
> > appears to be identical across v2.x.y in code seen so far. We use the
>
On Thu, Jul 12, 2018 at 12:09 AM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Jul 9, 2018 at 4:43 AM, Amit Kucheria
> wrote:
> > We also split up the regmap address space into two, one for the TM
> > registers, the other for the SROT registers. This was required to deal
On Thu, Jul 12, 2018 at 12:07 AM, Doug Anderson wrote:
> Hi,
>
> On Mon, Jul 9, 2018 at 4:43 AM, Amit Kucheria
> wrote:
>> There are two banks of registers for v2 TSENS IPs: SROT and TM. On older
>> SoCs these were contiguous, leading to DTs mapping them as one register
On Mon, Jul 9, 2018 at 9:31 PM, Matthias Kaehlcke wrote:
> On Mon, Jul 09, 2018 at 04:56:51PM +0530, Amit Kucheria wrote:
>> On Wed, Jul 4, 2018 at 3:18 AM, Matthias Kaehlcke wrote:
>> > Hi,
>> >
>> > On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucher
SDM845 uses v2 of the TSENS IP block but the get_temp() function
appears to be identical across v2.x.y in code seen so far. We use the
generic get_temp() function defined as part of ops_generic_v2.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-v2.c | 6 +-
drivers/thermal/qcom
address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boo
SDM845 has two tsens blocks, one with 13 sensors and the other with 8
sensors. It uses version 2 of the TSENS IP, so use the fallback property to
allow more common code.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 16
1 file changed, 16 insertions
M and SROT
register banks because their offsets are not constant across SoC families.
Signed-off-by: Amit Kucheria
---
.../devicetree/bindings/thermal/qcom-tsens.txt | 25 +-
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/th
status_field and trdy are unused in any of the tsens drivers. Remove them.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Acked-by: Rajendra Nayak
---
drivers/thermal/qcom/tsens.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal
have cleaner
common code e.g. get_temp() that is shared across new and old platforms.
But we need to add logic to init_common() to differentiate between old and
new DTs and adjust associated offsets for the TM register bank so that the
old DTs will continue to function correctly.
Signed-off-by: Amit
The TSENS block inside the 8996 is internally classified as version 2 of
the IP. Several other SoC families use this block and can share this code.
We rename get_temp() to reflect that it can be used across the v2 family.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/Makefile
to tsens-common and rename
- Change 8996 DT entry to allow init_common() to work across
sdm845 and 8996 due to different offsets
Amit Kucheria (7):
thermal: tsens: Get rid of unused fields in structure
thermal: tsens: Add support to split up register address space into
two
dt: qcom: 89
On Mon, Jul 9, 2018 at 4:57 PM, Amit Kucheria wrote:
> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
> sensors. It uses version 2 of the TSENS IP, so use the fallback property to
> allow more common code.
>
> Signed-off-by: Amit Kucheria
> ---
> arc
On Mon, Jul 2, 2018 at 11:23 PM, Eduardo Valentin wrote:
> On Mon, Jul 02, 2018 at 06:14:03PM +0530, Amit Kucheria wrote:
>> This series is a mixed bag:
>> - Some code moves to allow code sharing between various v2.x.y versions of
>> the TSENS IP,
>> - new qcom,t
The TSENS block inside the 8996 is internally classified as version 2 of
the IP. Several other SoC families use this block and can share this code.
We rename get_temp() to reflect that it can be used across the v2 family.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/Makefile
M and SROT
register banks because their offsets are not constant across SoC families.
Signed-off-by: Amit Kucheria
---
.../devicetree/bindings/thermal/qcom-tsens.txt | 25 +-
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/th
address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boo
SDM845 has two tsens blocks, one with 13 sensors and the other with 8
sensors. It uses version 2 of the TSENS IP, so use the fallback property to
allow more common code.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 16
1 file changed, 16 insertions
SDM845 uses v2 of the TSENS IP block but the get_temp() function
appears to be identical across v2.x.y in code seen so far. We use the
generic get_temp() function defined as part of ops_generic_v2.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/tsens-v2.c | 6 +-
drivers/thermal/qcom
have cleaner
common code e.g. get_temp() that is shared across new and old platforms.
But we need to add logic to init_common() to differentiate between old and
new DTs and adjust associated offsets for the TM register bank so that the
old DTs will continue to function correctly.
Signed-off-by: Amit
status_field and trdy are unused in any of the tsens drivers. Remove them.
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
Acked-by: Rajendra Nayak
---
drivers/thermal/qcom/tsens.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal
and 8996 due to different offsets
Amit Kucheria (7):
thermal: tsens: Get rid of unused fields in structure
thermal: tsens: Add support to split up register address space into
two
dt: qcom: 8996: thermal: Move to DT initialisation
thermal: tsens: Rename tsens-8996 to tsens-v2 for reuse
ther
On Fri, Jul 6, 2018 at 11:01 PM, Stephen Boyd wrote:
> Quoting Amit Kucheria (2018-07-02 05:44:09)
>> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
>> sensors.
>>
>> Signed-off-by: Amit Kucheria
>> ---
>> arch/arm64/boot/dts/qcom/
On Wed, Jul 4, 2018 at 3:18 AM, Matthias Kaehlcke wrote:
> Hi,
>
> On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucheria wrote:
>> SDM845 has two tsens blocks, one with 13 sensors and the other with 8
>> sensors.
>>
>> Signed-off-by: Amit Kucheria
>>
re derived from 96Boards CE Specification 1.0, Appendix
> "Expansion Connector Signal Description". Line names for PMI8994 MPP
> pins are not added due to the absence of the gpio-controller support.
>
> Signed-off-by: Manivannan Sadhasivam
FWIW,
Reviewed-by: Amit Kucheria
>
On Fri, Jul 6, 2018 at 2:07 AM Rob Herring wrote:
>
> On Wed, Jul 04, 2018 at 10:56:26PM +0530, Amit Kucheria wrote:
> > On Tue, Jul 3, 2018 at 9:56 PM, Rob Herring wrote:
> > > On Mon, Jul 02, 2018 at 06:14:07PM +0530, Amit Kucheria wrote:
> > >> SDM845 uses v2.
On Tue, Jul 3, 2018 at 9:56 PM, Rob Herring wrote:
> On Mon, Jul 02, 2018 at 06:14:07PM +0530, Amit Kucheria wrote:
>> SDM845 uses v2.4.0 of the TSENS IP block but the get_temp() function
>> appears to be identical across v2.x.y in code seen so far. We use the
>> generi
On Tue, Jul 3, 2018 at 12:23 AM Bjorn Andersson
wrote:
>
> On Mon 02 Jul 05:44 PDT 2018, Amit Kucheria wrote:
>
> > The TSENS block inside the 8996 is internally classified as version 2 of
> > the IP. Several other SoC families use this block and can share this code.
>
On Mon, Jul 2, 2018 at 6:14 PM, Amit Kucheria wrote:
> This series is a mixed bag:
> - Some code moves to allow code sharing between various v2.x.y versions of
> the TSENS IP,
> - new qcom,tsens-v2.4.0 DT property for SDM845 and a generic qcom,tsens-v2
> property as a fallback
compatible. I hope patch 4 does what
you were looking for.
Regards,
Amit
Amit Kucheria (6):
thermal: tsens: Get rid of unused fields in structure
dt: qcom: 8996: thermal: Move to DT initialisation
thermal: tsens: Rename tsens-8996 to tsens-v2 for reuse
thermal: tsens: Add support for SDM845
The TSENS block inside the 8996 is internally classified as version 2 of
the IP. Several other SoC families use this block and can share this code.
We rename get_temp() to reflect that it can be used across the v2 family.
Signed-off-by: Amit Kucheria
---
drivers/thermal/qcom/Makefile
SDM845 has two tsens blocks, one with 13 sensors and the other with 8
sensors.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
b/arch/arm64/boot/dts/qcom/sdm845.dtsi
SDM845 uses v2.4.0 of the TSENS IP block but the get_temp() function
appears to be identical across v2.x.y in code seen so far. We use the
generic get_temp() function.
Signed-off-by: Amit Kucheria
---
Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 2 ++
drivers/thermal/qcom/tsens-v2
Signed-off-by: Amit Kucheria
Reviewed-by: Bjorn Andersson
---
drivers/thermal/qcom/tsens-v2.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/thermal/qcom/tsens-v2.c b/drivers/thermal/qcom/tsens-v2.c
index 1871945..0473f33 100644
--- a/drivers/thermal/qcom/tsens-v2.c
+++ b
address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.
Signed-off-by: Amit Kucheria
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boo
701 - 800 of 923 matches
Mail list logo
