Hi all,
This is just a trivial patch to fix the shrink_list name on some files
under mm/ directory.
Signed-off-by: Anderson Briglia <[EMAIL PROTECTED]>
---
Index: linux-linus-2.6.git/mm/swap_state.c
===
--- linux-linus-2.6.gi
Hi Pierre,
ext Pierre Ossman wrote:
> Anderson Briglia wrote:
>> Hi Pierre,
>>
>> How about now? Is better?
>>
>>
>
> Locking problem is still there. You need to unclaim the host even when
> claim fails.
Bug fixed. Is there anything else to improve?
Hi Pierre,
How about now? Is better?
Regards,
Anderson Briglia
ext Pierre Ossman wrote:
> Anderson Briglia wrote:
>> Hi Pierre,
>>
>> Sorry about the delay.
>> I changed a bit the code to align with your latest suggestions.
>>
>>
>
> Nice, but
u send an invalid string to sysfs it will return
-EINVAL.
>
> And third, you're a bit excessive on the goto:s. E.g. out_unlocked is
> used in a single place, so it is completely unnecessary. Please do a
> general cleanup of the control flow.
I believe now the number of goto'
ues sent to
itself that were not handled.
>
> And third, you're a bit excessive on the goto:s. E.g. out_unlocked is
> used in a single place, so it is completely unnecessary. Please do a
> general cleanup of the control flow.
Ok.
Regards,
Anderson Briglia
-
To unsubscribe from
Implement card lock/unlock operation, using the MMC_LOCK_UNLOCK command.
Signed-off-by: Carlos Eduardo Aguiar <[EMAIL PROTECTED]>
Signed-off-by: Anderson Lizardo <[EMAIL PROTECTED]>
Signed-off-by: Anderson Briglia <[EMAIL PROTECTED]>
Index: linux-linus-2.6
Implement key retention operations.
Signed-off-by: Carlos Eduardo Aguiar <[EMAIL PROTECTED]>
Signed-off-by: Anderson Lizardo <[EMAIL PROTECTED]>
Signed-off-by: Anderson Briglia <[EMAIL PROTECTED]>
Index: linux-linus-2.6/d
Hi all,
I believe this code is following the latest Russel's comments.
Regards,
Anderson Briglia
---> cut here <
Implement MMC password force erase, remove password, change password,
unlock card and assign password operations. It uses the sysfs mechanism
to send commands
me later to make the card available to the
block driver.
Signed-off-by: Carlos Eduardo Aguiar <[EMAIL PROTECTED]>
Signed-off-by: Anderson Lizardo <[EMAIL PROTECTED]>
Signed-off-by: Anderson Briglia <[EMAIL PROTECTED]>
Signed-off-by: David Brownell <[EMAIL PROTECTED]>
In
nt me on the 15th was before Russell pointed out the
> dangling lock, and doesn't contain a fix for it.
Yes, I'm already fixed the latest Russel's comment. I'm preparing it to send
again to you and LKML. Do you have other
comments? If the others patches are ok, I intend to send
ext Russell King wrote:
> On Mon, Dec 04, 2006 at 04:13:39PM -0400, Anderson Briglia wrote:
>> Implement MMC password force erase, remove password, change password,
>> unlock card and assign password operations. It uses the sysfs mechanism
>> to send commands to the MMC s
n incorrect behaviour (hardware bug?) regarding password
acceptance: if an affected card has password
, it accepts as the correct password too, where is any
sequence of characters, of any length. In
other words, on these cards only the first bytes need to
match the correct password.
Comments an
Implement key retention operations.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-linus-2.6/drivers/mm
me later to make the card available to the
block driver.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Signed-off-by: David Brownell pacbell.net>
Index: linux-l
off-by: Anderson Briglia indt.org.br>
Index: linux-linus-2.6/drivers/mmc/mmc_sysfs.c
===
--- linux-linus-2.6.orig/drivers/mmc/mmc_sysfs.c2006-12-15
14:35:14.0 -0400
+++ linux-linus-2.6/drivers/mmc/mmc_sysfs.c 2
Implement card lock/unlock operation, using the MMC_LOCK_UNLOCK command.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-linus-2.6/drivers/
to send another set.
Best Regards,
Anderson Briglia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi,
ext Frank Seidel wrote:
> Quoting Anderson Briglia <[EMAIL PROTECTED]>:
>> [...]
> Hi,
> thats really cool stuff you're providing with your patches. :)
> I have some feedback or questions some parts here.
> But as i just started trying to get into kernelhac
Hi all,
Someone has comments for these patches?
Best regards,
Anderson Briglia
Anderson Briglia wrote:
> Hi all,
>
> New in this version:
>
> - mmc_sysfs.c: "change" and "assign" code merged to avoid code
> duplication.
> - OMAP specific patch not in
inition of MMC_LOCK_MODE_UNLOCK changed to 1 << 2.
- Use bit operations to handle with LOCK_MODE's macros.
Comments are always welcome.
Best regards,
Anderson Briglia
Implement card lock/unlock operation, using the MMC_LOCK_UNLOCK command.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-
ext Pierre Ossman wrote:
Anderson Briglia wrote:
Actually they represent the bits regarding the modes and it is used
when we
have to send the LOCK/UNLOCK mode on the command data block, according
to the MMC Spec.
If you take a look at mmc_lock_unlock function, we use those modes to
set the
Implement card lock/unlock operation, using the MMC_LOCK_UNLOCK command.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-linus-2.6/drivers/
me later to make the card available to the
block driver.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Signed-off-by: David Brownell pacbell.net>
Index: linux-l
Implement key retention operations.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-linus-2.6/drivers/mm
off-by: Anderson Briglia indt.org.br>
Index: linux-linus-2.6/drivers/mmc/mmc_sysfs.c
===
--- linux-linus-2.6.orig/drivers/mmc/mmc_sysfs.c2006-12-04
15:26:05.0 -0400
+++ linux-linus-2.6/drivers/mmc/mmc_sysfs.c 2
er words, on these cards
only the first bytes need to match the correct
password.
Comments and suggestions are always welcome.
--
Anderson Briglia
Embedded Linux Lab - 10LE
Nokia Institute of Technology - INdT
Manaus - Brazil
--
___
Linux-omap-open-so
ext Pierre Ossman wrote:
Anderson Briglia wrote:
@@ -244,5 +244,13 @@ struct _mmc_csd {
#define SD_BUS_WIDTH_1 0
#define SD_BUS_WIDTH_4 2
+/*
+ * MMC_LOCK_UNLOCK modes
+ */
+#define MMC_LOCK_MODE_ERASE(1<<3)
+#define MMC_LOCK_MODE_UNLOCK(0<<2)
+#define MMC_LOCK_
ext Pierre Ossman wrote:
Anderson Briglia wrote:
This patch is needed only for lock/unlock commands. So, it's necessary to
make MMC omap works when using that feature. It's not a generic patch.
But I can take off this one from the series and send after (if) the
series
is integrat
ext Pierre Ossman wrote:
Anderson Briglia wrote:
Hi Pierre,
ext Pierre Ossman wrote:
Patch looks ok. But I never got an answer what the difference between
"change" and "assign" is.
You're right, the command is the same, but the difference is the
password's
leng
ording to MMC spec 4.1, when a password replacement is done, the length value
(PWD_LEN) shall include both passwords, the old and the new one, and the
password
(PWD) shall include the old (currently) followed by the new password.
Best Regards,
Anderson Briglia
-
To unsubscribe from this list: send the
ext Pierre Ossman wrote:
Anderson Briglia wrote:
OMAP platform specific patch.
- Adjust the frame size for DMA transfers.
Signed-off-by: Anderson Briglia indt.org.br>
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
This looks like a generic patch for OMAP and shouldn't be
ext Pierre Ossman wrote:
Anderson Briglia wrote:
@@ -244,5 +244,13 @@ struct _mmc_csd {
#define SD_BUS_WIDTH_1 0
#define SD_BUS_WIDTH_4 2
+/*
+ * MMC_LOCK_UNLOCK modes
+ */
+#define MMC_LOCK_MODE_ERASE(1<<3)
+#define MMC_LOCK_MODE_UNLOCK(0<<2)
+#define MMC_LOCK_
Hi Russel and Pierre,
Thanks for all comments, I'm fixing the series and will send another version
asap.
ext Russell King wrote:
On Fri, Nov 17, 2006 at 09:01:11AM -0400, Anderson Briglia wrote:
Index: linux-omap-2.6.git/drivers/mmc/mmc_sy
OMAP platform specific patch.
- Adjust the frame count for DMA transfers.
Signed-off-by: Anderson Briglia indt.org.br>
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Index: linux-omap-2.6.git/drivers/mmc/omap.c
===
---
off-by: Anderson Briglia indt.org.br>
Index: linux-omap-2.6.git/drivers/mmc/mmc_sysfs.c
===
--- linux-omap-2.6.git.orig/drivers/mmc/mmc_sysfs.c 2006-11-16
15:45:20.0 -0400
+++ linux-omap-2.6.git/drivers/mmc/mmc_sysfs.c 2
tch the correct
password.
Comments and suggestions are always welcome.
--
Anderson Briglia,
Carlos Eduardo Aguiar
Embedded Linux Lab - 10LE
Nokia Institute of Technology - INdT
Manaus - Brazil
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Implement card lock/unlock operation, using the MMC_LOCK_UNLOCK command.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-omap-2.6.git/drivers/
ich will fail anyway.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Signed-off-by: David Brownell pacbell.net>
Index: linux-omap
Implement key retention operations.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-omap-2.6.git/drivers/mm
OMAP platform specific patch.
- Add the host MMC lock/unlock capability support.
Signed-off-by: Carlos Eduardo Aguiar indt.org.br>
Signed-off-by: Anderson Lizardo indt.org.br>
Signed-off-by: Anderson Briglia indt.org.br>
Index: linux-omap-2.6.git/drivers/m
40 matches
Mail list logo
