On Mike Kravetz, February 9, 2017 8:32 PM wrote:
> I believe another way of stating the problem is as follows:
>
> At mmap(MAP_HUGETLB) time a reservation for the number of huge pages
> is made. If surplus huge pages need to be (and can be) allocated to
> satisfy the reservation, they will be allo
On Friday, February 3, 2017 11:48 AM Pavel wrote:
> > Is info level OK for that message?
>
> I'd say so.
Thanks, I will update patch.
On Friday, January 20, 2017 Grzegorz wrote:
> Following patches enable the use of the feature that allows
> the Intel Xeon Phi x200 devices to use MONITOR/MWAIT instructions
> outside ring 0. This feature allows userspace application to use
> more efficient synchronization operations, which improve
On Thursday, December 22, 2016 3:21 PM Thomas Gleixner wrote:
> Changing types to match is the proper solution to all problems? You cannot
> just change types to make the compiler happy. You have to check what type
> is expected for it in the places which consume it, including compat mode.
HWCAP i
>It also warns on the 64bit build.
It is, I missed it. I changed the type of elf_hwcap2 to long unsigned int.
>> I used set_bit because I wanted to be sure that this operation to be
>> done atomically. There might be data race when multiple values of
>> ELF_HWCAP2 will be set by multiple thread
>
> Changelogs should not describe WHAT the patch is doing. We can see that from
> the patch. Changelogs should describe the WHY and CONCEPTS not implementation
> details.
So enable for Ring 3 MWAIT for Knights Landing + explanation of model
comparison and potential issues below. Should be Ok.
>
> This last define is not used anywhere. I told you before, but addressing my
> review comments completely is an unduly burden, or what?
>
I left to be consistent with the rest of the file. I will remove the line.
> > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > > +#ifdef CONFIG_X86_64
> > > > +static int phi_r3mwait_disabled __read_mostly;
> > > > +
> > > > +static int __init phir3mwait_disable(char *__unused) {
> > > > + phi_r3mwait_di
-Original Message-
From: Thomas Gleixner [mailto:t...@linutronix.de]
Sent: Wednesday, November 9, 2016 3:32 PM
To: Andrejczuk, Grzegorz
Cc: mi...@redhat.com; h...@zytor.com; x...@kernel.org; b...@suse.de;
dave.han...@linux.intel.com; Daniluk, Lukasz ;
Cownie, James H ; Pan, Jacob jun
>>On Tue, 1 Nov 2016, Grzegorz Andrejczuk wrote:
>>
>> +/* Intel Xeon Phi x200 ring 3 MONITOR/MWAIT */
>
>Oh well. I asked you to make that whole PHI thing go away.
>
>This is a feature which has nothing to do with PHI. It just happens to be
>implemented on PHI. The FEATURES_ENABLES MSR is not
> > init_intel_energy_perf(c);
> > +
> > + /*
> > + * Setting ring 3 MONITOR/MWAIT for thread
> > + * when CPU is Xeon Phi Family x200 (KnightsLanding).
> > + */
> > + if (c->x86 == 6 && c->x86_model == INTEL_FAM6_XEON_PHI_KNL)
>
> Please move this conditional into the probe function.
> On Thu, Oct 27, 2016 at 04:02:03PM +0200, Grzegorz Andrejczuk wrote:
> > Add cpu feature for ring 3 monitor/mwait.
> > Set HWCAP2 1st bit during init.
> >
> > Signed-off-by: Grzegorz Andrejczuk
> > ---
> > arch/x86/include/asm/cpufeatures.h | 2 ++
> > arch/x86/kernel/cpu/intel.c| 4 ++
12 matches
Mail list logo
