Re: [PATCH] ubsan: remove overflow checks

2021-02-10 Thread Andrey Rybainin
On 2/10/21 3:19 AM, Kees Cook wrote: > On Wed, Feb 10, 2021 at 02:23:48AM +0300, Andrey Ryabinin wrote: >> Since GCC 8.0 -fsanitize=signed-integer-overflow doesn't work with -fwrapv. >> -fwrapv makes signed overflows defines and GCC essentially disables >> ubsan checks. On GCC < 8.0 -fwrapv does

Re: [PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-02-09 Thread Andrey Rybainin
On 2/9/21 9:24 PM, Josh Poimboeuf wrote: > On Mon, Jan 18, 2021 at 11:53:37AM -0600, Josh Poimboeuf wrote: >> On Thu, Jan 14, 2021 at 02:09:28PM +0300, Andrey Ryabinin wrote: >>> >>> >>> On 1/14/21 1:59 PM, Peter Zijlstra wrote: On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Andrey Rybainin
On 07/14/2017 10:58 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: >> >>> yet when I look at the generated code for __ip_map_lookup, I see >>> >>>movl$32, %edx #, >>>movq%r13, %rsi # class, >>>leaq48(%rax), %r

Re: [PATCH] Revert "x86/uaccess: Add stack frame output operand in get_user() inline asm"

2017-07-13 Thread Andrey Rybainin
On 07/14/2017 12:14 AM, Matthias Kaehlcke wrote: > El Thu, Jul 13, 2017 at 11:20:04PM +0300 Andrey Rybainin ha dit: > >> On 07/13/2017 09:47 PM, Matthias Kaehlcke wrote: >> >>> Thanks for your analysis! >>> >>>> What happens if you try the below p

Re: [PATCH] Revert "x86/uaccess: Add stack frame output operand in get_user() inline asm"

2017-07-13 Thread Andrey Rybainin
On 07/13/2017 09:47 PM, Matthias Kaehlcke wrote: > Thanks for your analysis! > >> What happens if you try the below patch instead of the revert? Any >> chance the offending instruction goes away? >> >> diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h >> index 11433f9.