On Mon, Mar 8, 2021 at 6:34 PM Maximilian Luz wrote:
>
> On 3/8/21 4:35 PM, Andy Shevchenko wrote:
> > On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> >> Following commit 036e126c72eb ("pinctrl: intel: Split
> >> intel_pinctrl_add
On Mon, Mar 8, 2021 at 6:28 PM Calvin Johnson
wrote:
> On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote:
> I thought of including device.h instead of dev_printk.h because, it is the
> only file that includes dev_printk.h and device.h is widely used. Of course,
>
On Mon, Mar 08, 2021 at 04:37:10PM +0100, Bartosz Golaszewski wrote:
> On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko
> wrote:
> >
> > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote:
> > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko
> >
On Mon, Mar 08, 2021 at 04:38:42PM +0100, Bartosz Golaszewski wrote:
> On Thu, Mar 4, 2021 at 12:01 PM Andy Shevchenko
> wrote:
> > On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote:
> > > On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
> > > wrot
On Mon, Mar 08, 2021 at 05:35:59PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> > Following commit 036e126c72eb ("pinctrl: intel: Split
> > intel_pinctrl_add_padgroups() for better maintenance"),
> > gpiochip_ge
On Mon, Mar 8, 2021 at 6:06 PM Andy Shevchenko
wrote:
> On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote:
>
> > - depends on EXTCON || !EXTCON
>
> I stumbled over this.
> What is the point of having this line at all?
> What magic trick does it serve for?
Okay,
On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote:
> - depends on EXTCON || !EXTCON
I stumbled over this.
What is the point of having this line at all?
What magic trick does it serve for?
--
With Best Regards,
Andy Shevchenko
-H 15 /sys/bus/acpi/devices/*/status`.
> There is probably a better option than straight up reverting this, so
> consider this more of a bug-report.
Indeed.
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote:
> On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko
> wrote:
> > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote:
...
> > I have strong opinion not to open code "yet another parser
On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote:
> On Fri, Mar 5, 2021 at 11:15 AM Andy Shevchenko
> wrote:
> > On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote:
> > > On Thu, Mar 4, 2021 at 2:15 PM Andy Shevchenko
> > > wrote
On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson
wrote:
> On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
> > wrote:
> > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
&g
On Mon, Mar 08, 2021 at 02:36:27PM +0100, Rafael J. Wysocki wrote:
> On Sun, Mar 7, 2021 at 9:39 PM Andy Shevchenko
> wrote:
> > On Sun, Mar 7, 2021 at 3:36 PM Daniel Scally wrote:
> > > On 22/02/2021 13:34, Andy Shevchenko wrote:
> > > > On Mon, Feb
On Mon, Mar 8, 2021 at 3:02 PM Henning Schild
wrote:
> Am Fri, 5 Mar 2021 19:44:57 +0200
> schrieb Andy Shevchenko :
> > On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko
> > wrote:
> > > On Fri, Mar 5, 2021 at 6:47 PM Henning Schild
> > > wrote:
>
The following commit has been merged into the x86/core branch of tip:
Commit-ID: 3fb0fdb3bbe7aed495109b3296b06c2409734023
Gitweb:
https://git.kernel.org/tip/3fb0fdb3bbe7aed495109b3296b06c2409734023
Author:Andy Lutomirski
AuthorDate:Sat, 13 Feb 2021 11:19:44 -08:00
The following commit has been merged into the x86/core branch of tip:
Commit-ID: d0962f2b24c99889a386f0658c71535f56358f77
Gitweb:
https://git.kernel.org/tip/d0962f2b24c99889a386f0658c71535f56358f77
Author:Andy Lutomirski
AuthorDate:Sat, 13 Feb 2021 11:19:45 -08:00
Instead of open coding pci_p2sb_bar() functionality we are going to
use generic library for that. There one more user of it is coming.
Besides cleaning up it fixes a potential issue if, by some reason,
SPI bar is 64-bit.
Signed-off-by: Andy Shevchenko
---
drivers/mfd/Kconfig | 1 +
drivers
the former one as static inline helper.
Signed-off-by: Andy Shevchenko
---
drivers/pci/pci.h | 13 -
drivers/pci/probe.c | 69 +++--
2 files changed, 48 insertions(+), 34 deletions(-)
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index ef7c4661314f
From: Jonathan Yong
There is already one and at least one more user is coming which
requires an access to Primary to Sideband bridge (P2SB) in order to
get IO or MMIO bar hidden by BIOS. Create a library to access P2SB
for x86 devices.
Signed-off-by: Jonathan Yong
Co-developed-by: Andy
controllers on Apollo Lake
when it's used with ABL bootloader w/o ACPI support.
Please, comment on the approach and individual patches.
(Since it's cross subsystem, the PCI seems like a main one and
I think it makes sense to route it thru it with immutable tag
or branch provided for the others).
Andy
Factor out duplicate code to lpc_ich_enable_spi_write() helper function.
Signed-off-by: Andy Shevchenko
---
drivers/mfd/lpc_ich.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 3bbb29a7e7a5..3a19ed57260e
and unhide P2SB to lookup P2SB BAR and pass
the PCI BAR address to GPIO.
Signed-off-by: Tan Jui Nee
Signed-off-by: Andy Shevchenko
---
drivers/mfd/lpc_ich.c | 100 +-
1 file changed, 99 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/lpc_ich.c b/drivers
Since we have a common P2SB accessor in tree we may use it instead of
open coded variants.
Replace custom code by pci_p2sb_bar() call.
Signed-off-by: Andy Shevchenko
---
drivers/i2c/busses/Kconfig| 1 +
drivers/i2c/busses/i2c-i801.c | 40 ---
drivers/pci
In some cases PCI device structure is not available and we want to print
information based on the bus and devfn parameters. For this cases introduce
pci_bus_*() printing macros and replace in existing users.
Signed-off-by: Andy Shevchenko
---
drivers/pci/probe.c | 12 +++-
include/linux
On Mon, Mar 8, 2021 at 1:50 PM Marc Zyngier wrote:
> On Fri, 05 Mar 2021 15:05:08 +,
> Andy Shevchenko wrote:
...
> > > +#define TIMER_FIRING(x)
> > > \
> > > + (((x) & (ARCH_TIMER_
On Sun, Mar 07, 2021 at 06:14:49PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 7, 2021 at 4:22 PM Bartosz Golaszewski
> wrote:
> > On Fri, Mar 5, 2021 at 1:02 PM Andy Shevchenko
> > wrote:
> > >
> > > On STM32MP1, the GPIO banks are subnodes of pin-controll
After a few updates against swnode APIs the kernel documentation, i.e.
for swnode group registration and unregistration deviates from the one
for swnode array. In general, the same rules are applied to both.
Hence, synchronize descriptions of swnode array and group APIs
Signed-off-by: Andy
On Fri, Feb 12, 2021 at 06:25:39PM +0200, Andy Shevchenko wrote:
> Add test cases for fwnode_property_count_*() APIs.
>
> While at it, modify the arrays of integers to be size of non-power-of-2
> for better test coverage and decreasing stack usage.
Any comments on this?
> Sign
NG=n. Therefore, it
> makes sense to keep the message for no_hash_pointers as __initconst, and
> not move the NOTICE-printing to a common function.
This seems to have 2-in-1 patch. Care to split?
Feel free to add
Reviewed-by: Andy Shevchenko
to the __initconst part, but the rest.
>
On Mon, Mar 8, 2021 at 12:17 PM Borislav Petkov wrote:
>
> On Mon, Mar 08, 2021 at 11:59:34AM +0200, Andy Shevchenko wrote:
> > It works, but... The question here is why the script behaviour depends
> > so much on the architecture in question (by environment). ARM stuff is
>
On Sat, Mar 6, 2021 at 12:25 AM Borislav Petkov wrote:
>
> On Fri, Mar 05, 2021 at 08:39:48PM +0200, Andy Shevchenko wrote:
> > On x86_64 host the objdump uses current architecture which is 64-bit
> > and hence decodecode shows wrong instructions.
> >
> > Fix it
On Sun, Mar 7, 2021 at 3:36 PM Daniel Scally wrote:
> On 22/02/2021 13:34, Andy Shevchenko wrote:
> > On Mon, Feb 22, 2021 at 3:12 PM Daniel Scally wrote:
> >> The acpi_walk_dep_device_list() is not as generalisable as its name
> >> implies, serving only to dec
}
> + ret = devm_gpiochip_add_data(>dev, >chip, p);
> + if (ret) {
> + dev_err(>dev, "unable to add gpio chip\n");
> + return ret;
> + }
> +
> + dev_info(>dev, "elba spics registered\n");
> + return 0;
if (ret)
dev_err(...);
return ret;
> +}
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 3, 2021 at 4:51 AM Aili Yao wrote:
>
> On Wed, 3 Mar 2021 20:24:02 +0800
> Aili Yao wrote:
>
> > On Mon, 1 Mar 2021 11:09:36 -0800
> > Andy Lutomirski wrote:
> >
> > > > On Mar 1, 2021, at 11:02 AM, Luck, Tony wrote:
> > > >
&g
gt; +
> +struct bcm63xx_pinctrl {
> + struct device *dev;
> + struct regmap *regs;
> +
> + struct pinctrl_desc pctl_desc;
> + struct pinctrl_dev *pctl_dev;
> +
> + void *driver_data;
> +};
> +
> +static inline unsigned int bcm63xx_bank_pin(unsigned int pin)
> +{
> + return pin % BCM63XX_BANK_GPIOS;
> +}
> +
> +int bcm63xx_pinctrl_probe(struct platform_device *pdev,
> + const struct bcm63xx_pinctrl_soc *soc,
> + void *driver_data);
> +
> +#endif /* __PINCTRL_BCM63XX_H__ */
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
On Sun, Mar 7, 2021 at 4:22 PM Bartosz Golaszewski
wrote:
>
> On Fri, Mar 5, 2021 at 1:02 PM Andy Shevchenko
> wrote:
> >
> > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000,
> > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for
> > pin-
> + chip->of_node = to_of_node(config->fwnode);
> + else
> + chip->of_node = dev_of_node(config->parent);
...and these lines are not needed. If there is no of_node in the chip,
the GPIO library will take care of it to be parent's one.
--
With Best Regards,
Andy Shevchenko
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: 5d5675df792ff67e74a500c4c94db0f99e6a10ef
Gitweb:
https://git.kernel.org/tip/5d5675df792ff67e74a500c4c94db0f99e6a10ef
Author:Andy Lutomirski
AuthorDate:Thu, 04 Mar 2021 11:05:54 -08:00
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: e59ba7bf71a09e474198741563e0e587ae43d1c7
Gitweb:
https://git.kernel.org/tip/e59ba7bf71a09e474198741563e0e587ae43d1c7
Author:Andy Lutomirski
AuthorDate:Thu, 04 Mar 2021 11:05:54 -08:00
On x86_64 host the objdump uses current architecture which is 64-bit
and hence decodecode shows wrong instructions.
Fix it by supplying '-M i386' in case of ARCH i?86 or x86.
Signed-off-by: Andy Shevchenko
---
scripts/decodecode | 14 +-
1 file changed, 9 insertions(+), 5 deletions
On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko
wrote:
>
> On Fri, Mar 5, 2021 at 6:47 PM Henning Schild
> wrote:
> > Am Fri, 5 Mar 2021 17:42:42 +0200
> > schrieb Andy Shevchenko :
> > > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede
> > > wrote:
>
>
On Fri, Mar 5, 2021 at 6:47 PM Henning Schild
wrote:
> Am Fri, 5 Mar 2021 17:42:42 +0200
> schrieb Andy Shevchenko :
> > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede
> > wrote:
...
> > [1]: https://gitlab.com/andy-shev/next/-/tree/p2sb
>
> That is a little weir
On Fri, Mar 5, 2021 at 6:41 PM Andy Shevchenko
wrote:
>
> On Fri, Mar 5, 2021 at 6:25 PM Andy Shevchenko
> wrote:
> > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote:
> > > On 3/5/21 4:42 PM, Andy Shevchenko wrote:
>
> ...
>
> > > So I to
On Fri, Mar 5, 2021 at 6:25 PM Andy Shevchenko
wrote:
> On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote:
> > On 3/5/21 4:42 PM, Andy Shevchenko wrote:
...
> > So I took a quick look at the following 2 commits:
>
> (One of the latter commits moves the code to drivers/pci
On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote:
> On 3/5/21 4:42 PM, Andy Shevchenko wrote:
> > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote:
> >> On 3/4/21 11:11 AM, Andy Shevchenko wrote:
> >>> On Thu, Mar 4, 2021 at 8:36 AM Henning Schild
> >&
On Fri, Mar 5, 2021 at 6:16 PM Hector Martin wrote:
>
> On 06/03/2021 00.17, Andy Shevchenko wrote:
> > Add a separate change that removes flags from the spin lock in the IRQ
> > handler.
>
> This commit should have no functional changes;
Exactly my point why I'm sugge
On Fri, Mar 5, 2021 at 5:55 PM Hector Martin wrote:
> On 06/03/2021 00.13, Andy Shevchenko wrote:
...
> >> - return ioremap(res.start, resource_size());
> >> + if (res.flags & IORESOURCE_MEM_NONPOSTED)
> >> + return i
On Thu, Mar 4, 2021 at 9:52 PM Henning Schild
wrote:
> Am Thu, 4 Mar 2021 12:11:12 +0200
> schrieb Andy Shevchenko :
> > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild
> > wrote:
...
> > Check for the rest of the series as well (basically this is the rule
> > o
On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote:
> On 3/4/21 11:11 AM, Andy Shevchenko wrote:
> > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild
> > wrote:
...
> >> +u32 simatic_ipc_get_membase0(unsigned int p2sb)
> >> +{
> >> + u32 bar0 = 0
(1 <<
> APPLE_S5L_UCON_TXTHRESH_ENA)
BIT() ?
...
> +#define APPLE_S5L_UCON_DEFAULT (S3C2410_UCON_TXIRQMODE | \
> +S3C2410_UCON_RXIRQMODE | \
> +S3C2410_UCON_RXFIFO_TOI)
Indentation level is too high. Hint: start a value of the definition
on the new line.
...
> +#define APPLE_S5L_UTRSTAT_RXTHRESH (1<<4)
> +#define APPLE_S5L_UTRSTAT_TXTHRESH (1<<5)
> +#define APPLE_S5L_UTRSTAT_RXTO (1<<9)
> +#define APPLE_S5L_UTRSTAT_ALL_FLAGS(0x3f0)
BIT() ?
--
With Best Regards,
Andy Shevchenko
no longer
> > necessary, since devm_ioremap_resource takes care of that already. Most
> > other drivers already do it this way, anyway.
> >
For the patches 18-22, with Krzysztof's and mine comments addressed
Reviewed-by: Andy Shevchenko
> > Signed-off-by: Hector Mart
irq(ourport->rx_irq, s3c24xx_serial_rx_chars, 0,
> + ret = request_irq(ourport->rx_irq, s3c24xx_serial_rx_irq, 0,
> s3c24xx_serial_portname(port), ourport);
>
> if (ret != 0) {
> @@ -1169,7 +1175,7 @@ static int s3c24xx_serial_startup(struct uart_port
> *port)
>
> ourport->tx_enabled = 1;
>
> - ret = request_irq(ourport->tx_irq, s3c24xx_serial_tx_chars, 0,
> + ret = request_irq(ourport->tx_irq, s3c24xx_serial_tx_irq, 0,
> s3c24xx_serial_portname(port), ourport);
>
> if (ret) {
> --
> 2.30.0
>
--
With Best Regards,
Andy Shevchenko
break;
> + }
> + parent = of_get_parent(node);
> + of_node_put(node);
> + node = parent;
> + }
I believe above can be slightly optimized. Don't we have helpers to
traverse to all parents?
--
With Best Regards,
Andy Shevchenko
here. That is what I have stumbled upon reading carefully.
--
With Best Regards,
Andy Shevchenko
(of_node_to_fwnode(node),
> + irqc->nr_hw + AIC_NR_FIQ,
> + _irq_domain_ops, irqc);
If you are sure it will be always OF-only, why not to use
irq_domain_add_linear()?
...
> + for (i = 0; i < BITS_TO_U32(irqc->nr_hw); i++)
> + aic_ic_write(irqc, AIC_MASK_SET + i * 4, ~0);
> + for (i = 0; i < BITS_TO_U32(irqc->nr_hw); i++)
> + aic_ic_write(irqc, AIC_SW_CLR + i * 4, ~0);
~0 is a beast when it suddenly gets into > int size.
I would recommend using either GENMASK() if it's a bit field, or
type_MAX values if it's a plain number.
--
With Best Regards,
Andy Shevchenko
5) /* dup: IORESOURCE_SHADOWABLE
> */
> #define IORESOURCE_MEM_EXPANSIONROM(1<<6)
> +#define IORESOURCE_MEM_NONPOSTED (1<<7)
Not sure it's the right location (in a bit field) for this flag.
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 05, 2021 at 01:11:39PM +0100, Marek Vasut wrote:
> On 3/5/21 1:02 PM, Andy Shevchenko wrote:
> > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000,
> > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for
> > pin-controller@50002000 is in
ames() for
device properties")
Reported-by: Marek Vasut
Reported-by: Roman Guskov
Signed-off-by: Andy Shevchenko
---
drivers/gpio/gpiolib.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 3bc25a9c4c
reverts commit 8d7b3a6dac4eae22c58b0853696cbd256966741b.
FWIW,
Reviewed-by: Andy Shevchenko
> Fixes: 8d7b3a6dac4e ("mfd: stmpe: Constify static struct resource")
> Reported-by: Andy Shevchenko
> Signed-off-by: Rikard Falkeborn
> ---
> Changes
> V1-V2: Add comments to the
The following commit has been merged into the x86/urgent branch of tip:
Commit-ID: dabf017539988a9bfc40a38dbafd35c501bacc44
Gitweb:
https://git.kernel.org/tip/dabf017539988a9bfc40a38dbafd35c501bacc44
Author:Andy Lutomirski
AuthorDate:Thu, 04 Mar 2021 11:05:54 -08:00
On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote:
> On Thu, Mar 4, 2021 at 2:15 PM Andy Shevchenko
> wrote:
> > On Thu, Mar 04, 2021 at 11:24:49AM +0100, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski
> > > +
> > > +
On Fri, Mar 5, 2021 at 9:45 AM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 17:33, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 5:44 PM Álvaro Fernández Rojas
> > wrote:
> >>> El 4 mar 2021, a las 16:28, Andy Shevchenko
> >>
On Thu, Mar 4, 2021 at 7:24 PM Michael Walle wrote:
> Am 2021-03-04 17:46, schrieb Andy Shevchenko:
> > On Thu, Mar 4, 2021 at 6:33 PM Andy Shevchenko
> > wrote:
> >> On Thu, Mar 4, 2021 at 5:44 PM Álvaro Fernández Rojas
> >> wrote:
> >
> > Let m
per.
Amend gpiolib.c and gpiolib-of.c code in order to group OF operations.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-of.c | 6 --
drivers/gpio/gpiolib.c| 9 -
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/g
In the ACPI case we may use the firmware node in the similar way
as it's done for OF case. We may use that fwnode for other purposes
in the future.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-acpi.c | 7 +++
drivers/gpio/gpiolib-acpi.h | 4
:
unknown-1 ==> \_SB.PCI0.GIP0.GPO
unknown-2 ==> \_SB.NIO3
Signed-off-by: Andy Shevchenko
---
drivers/gpio/gpiolib.c | 28
1 file changed, 8 insertions(+), 20 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
On Thu, Mar 04, 2021 at 06:29:32PM +, Marc Zyngier wrote:
> On Thu, 04 Mar 2021 15:02:11 +,
> Andy Shevchenko wrote:
> Please move this as an inline helper in linux/irqdomain.h, so that we
> can drop this export altogether.
Done in v3, thanks!
--
With Best Regards,
Andy Shevchenko
irq_domain_add_simple() static inline (Marc)
In v2:
- added a new patch due to functionality in irq_comain_add_simple() (Linus)
- tagged patches 2-4 (Linus)
- Cc'ed to Rafael
Andy Shevchenko (5):
irqdomain: Introduce irq_domain_create_simple() API
gpiolib: Unify the checks on fwnode type
gpiolib
We have (historically) different approaches how we identify the type
of a given fwnode. Let's standardize them across the library code.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib.c | 28 +---
1 file changed, 13 insertions(+), 15
irq_domain_add_simple(),
but takes a pointer to the struct fwnode_handle as a parameter.
While at it, amend documentation to mention irq_domain_create_*()
functions where it makes sense.
Signed-off-by: Andy Shevchenko
---
Documentation/core-api/irq/irq-domain.rst | 22 --
include/linux
If arch code calls the wrong kernel entry helpers, syscall entries and
exits can get out of sync. Add a new field to task_struct to track the
syscall state and validate that it transitions correctly.
Signed-off-by: Andy Lutomirski
---
include/linux/sched.h | 4
init/init_task.c | 8
(). It's also only used by arm64. Give it
the same treatment.
Signed-off-by: Andy Lutomirski
---
include/linux/entry-common.h | 34 ++
kernel/entry/common.c| 4
2 files changed, 10 insertions(+), 28 deletions(-)
diff --git a/include/linux/entry-common.h
-by: Andy Lutomirski
---
arch/x86/kernel/traps.c | 4 ++--
include/asm-generic/bug.h | 8
include/linux/instrumentation.h | 25 -
kernel/entry/common.c | 7 +++
4 files changed, 33 insertions(+), 11 deletions(-)
diff --git a/arch/x86/kernel
of the kentry
code, and trying to debug the resulting state machine will be painful.
arm64 can turn it back on when it starts using the entire generic
path.
Signed-off-by: Andy Lutomirski
---
arch/x86/Kconfig.debug | 10 --
lib/Kconfig.debug | 11 +++
2 files changed, 11
It's quite easy to mess up kentry calls. Add debgging checks that kentry
transitions to and from user mode match up and that kentry_nmi_enter() and
kentry_nmi_exit() match up.
Checking full matching of kentry_enter() with kentry_exit() needs
per-task state.
Signed-off-by: Andy Lutomirski
Poimboeuf
Signed-off-by: Andy Lutomirski
---
arch/x86/entry/common.c | 23 ++
arch/x86/entry/entry_32.S| 51 +---
arch/x86/entry/entry_64.S| 33 +
arch/x86/include/asm/switch_to.h | 2 +-
arch/x86/kernel
The new common syscall API had a large and confusing API surface. Simplify
it. Now there is exactly one way to use it. It's a bit more verbose than
the old way for the simple x86_64 native case, but it's much easier to use
right, and the diffstat should speak for itself.
Signed-off-by: Andy
copy_from_user_nmi() validates that the pointer is in the user range,
so there is no need for an extra check in copy_code().
Signed-off-by: Andy Lutomirski
---
arch/x86/kernel/dumpstack.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel
contemplate
changing that later. That code predates the common entry code.
Signed-off-by: Andy Lutomirski
---
arch/x86/entry/common.c | 8 ++---
arch/x86/include/asm/idtentry.h | 28 +++
arch/x86/kernel/cpu/mce/core.c | 10 +++---
arch/x86/kernel/kvm.c | 6 ++--
arch
work involved a small change to
ret_from_fork, and adjusting the asm is a mess. So C it is.
Changes from v1 and v2: Complete rewrite
Andy Lutomirski (11):
x86/entry: Fix entry/exit mismatch on failed fast 32-bit syscalls
kentry: Rename irqentry to kentry
x86/dumpstack: Remove unnecessary range
of fetch failed. This makes it much easier to understand what's happening.
Cc: Josh Poimboeuf
Signed-off-by: Andy Lutomirski
---
arch/x86/kernel/dumpstack.c | 4 ++--
arch/x86/kernel/process.c | 13 +
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel
, ptrace_syscall_info.op == 2
...
This is a minimal fix intended for ease of backporting. A more
complete cleanup is coming.
Cc: sta...@vger.kernel.org
Fixes: 0b085e68f407 ("x86/entry: Consolidate 32/64 bit syscall entry")
Signed-off-by: Andy Lutomirski
---
arch/x86/entry/common.c
Signed-off-by: Andy Lutomirski
---
tools/testing/selftests/x86/thunks_32.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/x86/thunks_32.S
b/tools/testing/selftests/x86/thunks_32.S
index a71d92da8f46..f3f56e681e9f 100644
--- a/tools/testing/selftests/x86/thunks_32.S
+
On Thu, Mar 4, 2021 at 6:33 PM Andy Shevchenko
wrote:
> On Thu, Mar 4, 2021 at 5:44 PM Álvaro Fernández Rojas
> wrote:
Let me summarize what we can do this independently on any of my
patches and be okay with.
In the regmap GPIO configuration you supply struct fwnode_handle *fwnode.
Y
On Thu, Mar 4, 2021 at 5:44 PM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 16:28, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 5:24 PM Álvaro Fernández Rojas
> > wrote:
> >>> El 4 mar 2021, a las 16:17, Andy Shevchenko
> >>
On Thu, Mar 04, 2021 at 05:02:12PM +0200, Andy Shevchenko wrote:
> We have (historically) different approaches how we identify the type
> of a given fwnode. Let's standardize them across the library code.
>
> Signed-off-by: Andy Shevchenko
> Reviewed-by: Linus Walleij
> -
On Thu, Mar 04, 2021 at 01:18:09PM +0200, Mika Westerberg wrote:
> On Thu, Mar 04, 2021 at 12:54:32PM +0200, Andy Shevchenko wrote:
> > In IRQ handler interrupts are already disabled, hence no need
> > to repeat it. Even in the threaded case, which is disabled here,
> > it is
On Thu, Mar 04, 2021 at 02:41:24PM +0100, Rafael J. Wysocki wrote:
> On Thu, Mar 4, 2021 at 1:25 PM Andy Shevchenko
> wrote:
> >
> > On Thu, Mar 04, 2021 at 09:06:08AM +0100, Linus Walleij wrote:
> > > On Wed, Mar 3, 2021 at 10:35 AM Andy Shevchenko
> > >
On Thu, Mar 4, 2021 at 5:33 PM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 16:25, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 2:25 PM Álvaro Fernández Rojas
> > wrote:
> >>> El 4 mar 2021, a las 13:12, Andy Shevchenko
> >>
On Thu, Mar 4, 2021 at 5:24 PM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 16:17, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 5:06 PM Álvaro Fernández Rojas
> > wrote:
> >>> El 4 mar 2021, a las 11:35, Andy Shevchenko
> >&g
On Thu, Mar 4, 2021 at 2:25 PM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 13:12, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 1:13 PM Álvaro Fernández Rojas
> > wrote:
> >>> El 4 mar 2021, a las 11:49, Andy Shevchenko
> >&g
y you need this patch at all.
The second part, i.e. assigning parent's fwnode, is done already in
the GPIO library core.
The first part, keeping fwnode in the regmap configuration puzzles me. Why?
--
With Best Regards,
Andy Shevchenko
On Thu, Mar 4, 2021 at 2:28 PM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 13:09, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 1:17 PM Álvaro Fernández Rojas
> > wrote:
> >>> El 4 mar 2021, a las 11:43, Andy Shevchenko
> >&g
On Thu, Mar 4, 2021 at 5:06 PM Álvaro Fernández Rojas wrote:
> > El 4 mar 2021, a las 11:35, Andy Shevchenko
> > escribió:
> > On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
> > wrote:
> >> + * @of_node: (Optional) The device node
> >
&
:
unknown-1 ==> \_SB.PCI0.GIP0.GPO
unknown-2 ==> \_SB.NIO3
Signed-off-by: Andy Shevchenko
---
drivers/gpio/gpiolib.c | 28
1 file changed, 8 insertions(+), 20 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
irq_domain_add_simple(),
but takes a pointer to the struct fwnode_handle as a parameter.
While at it, amend documentation to mention irq_domain_create_*()
functions where it makes sense.
Signed-off-by: Andy Shevchenko
---
Documentation/core-api/irq/irq-domain.rst | 22 --
include/linux
We have (historically) different approaches how we identify the type
of a given fwnode. Let's standardize them across the library code.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib.c | 28 +---
1 file changed, 13 insertions(+), 15
per.
Amend gpiolib.c and gpiolib-of.c code in order to group OF operations.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-of.c | 6 --
drivers/gpio/gpiolib.c| 9 -
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/g
In the ACPI case we may use the firmware node in the similar way
as it's done for OF case. We may use that fwnode for other purposes
in the future.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-acpi.c | 7 +++
drivers/gpio/gpiolib-acpi.h | 4
in irq_comain_add_simple() (Linus)
- tagged patches 2-4 (Linus)
- Cc'ed to Rafael
Andy Shevchenko (5):
irqdomain: Introduce irq_domain_create_simple() API
gpiolib: Unify the checks on fwnode type
gpiolib: Move of_node operations to gpiolib-of and correct fwnode use
gpiolib: Introduce
In order to group x86 related platform data move intel-spi.h to x85 folder.
While at it, remove duplicate inclusion in C file.
Signed-off-by: Andy Shevchenko
---
drivers/mtd/spi-nor/controllers/intel-spi.c | 1 -
drivers/mtd/spi-nor/controllers/intel-spi.h | 2 +-
include/linux/mfd
801 - 900 of 41493 matches
Mail list logo
