ers 11-13 refer to the tags.
> On Fri, Mar 12, 2021 at 10:35 AM Andy Shevchenko
> wrote:
> >
> > On Fri, Mar 12, 2021 at 4:21 PM Tong Zhang wrote:
> > >
> > > ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown()
> > > before cal
cvf]
Don't you miss the tag I gave?
--
With Best Regards,
Andy Shevchenko
for bikeshedding
and small improvements
Reviewed-by: Andy Shevchenko
Thanks!
> Signed-off-by: Oleksij Rempel
> ---
> MAINTAINERS | 8 +
> drivers/iio/adc/Kconfig | 12 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/ti-tsc2046.c | 713 +
The unnecessary explicit casting is being used. Drop it for good.
Signed-off-by: Andy Shevchenko
---
drivers/iio/light/gp2ap002.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c
index 7ba7aa59437c..d048ae257c51
In a few places the unnecessary explicit castings are being used.
Drop them for good.
Signed-off-by: Andy Shevchenko
---
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i2c.c | 3 +--
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 3 +--
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_spi.c | 3 +--
3 files changed
In a few places the unnecessary explicit castings are being used.
Drop them for good.
Signed-off-by: Andy Shevchenko
---
drivers/iio/imu/fxos8700_i2c.c | 3 +--
drivers/iio/imu/fxos8700_spi.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/imu/fxos8700_i2c.c
In few places the unnecessary explicit castings are being used.
Drop them for good.
Signed-off-by: Andy Shevchenko
---
drivers/iio/chemical/bme680_i2c.c | 3 +--
drivers/iio/chemical/bme680_spi.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/chemical
On Thu, Mar 11, 2021 at 5:23 PM 周琰杰 (Zhou Yanjie)
wrote:
>
> v1->v2:
> 1.Split [1/3] in v1 to [1/6] [2/6] [3/6] [4/6] in v2.
> 2.Fix the uninitialized warning.
With the split done the series looks much better!
FWIW,
Reviewed-by: Andy Shevchenko
(with the exception of DT binding
oddie # for JZ4730
> Signed-off-by: H. Nikolaus Schaller # for JZ4730
> Signed-off-by: 周琰杰 (Zhou Yanjie)
Shouldn't it have the Co-developed-by tag(s)?
--
With Best Regards,
Andy Shevchenko
about this? Is this passing static analysis?
>
> It will take me 2 hours to re-run the analysis, but from eyeballing the
> code I think the assignments will fix this.
It surprises me that tools in the 21st century can't run on a subset
of the data.
Had you filed a bug to the Coverity team that they will provide a way
to rerun analysis on a subset of the data?
--
With Best Regards,
Andy Shevchenko
t Regards,
Andy Shevchenko
verywhere else use a common sense, when put
backtraces, oopses, etc in the commit message, i.e. leave only ~2-3
(significant) lines instead of 20-30.
--
With Best Regards,
Andy Shevchenko
On Fri, Mar 12, 2021 at 09:54:58AM +0100, Bartosz Golaszewski wrote:
> On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko
> wrote:
...
> > > + ret = sprintf(page, "n/a\n");
> >
> > I dunno '/' (slash) is a good character to be handled
il, the vf2pf_lock is either not initialized or destroyed, a subsequent
> use of vf2pf_lock will cause issue.
> To fix this issue, only set this flag if adf_dev_init() returns 0.
Makes sense, but please leave only ~2-3 (significant) lines from the
below noisy dump
Reviewed-by: Andy Shevchen
On Thu, Mar 11, 2021 at 8:00 PM Calvin Johnson
wrote:
> On Thu, Mar 11, 2021 at 02:09:37PM +0200, Andy Shevchenko wrote:
> > On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson
> > wrote:
...
> > > +config FWNODE_MDIO
> > > + def_tristate PHYLIB
> >
>
On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai wrote:
> On Thu, 11 Mar 2021 14:27:41 +0100,
> Andy Shevchenko wrote:
> >
> > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> > No functional change implied.
>
> I'd love to apply this kind o
On Thu, Mar 11, 2021 at 3:40 PM Takashi Iwai wrote:
>
> On Thu, 11 Mar 2021 14:27:41 +0100,
> Andy Shevchenko wrote:
> >
> > Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
> > No functional change implied.
>
> I'd love to apply this kin
On Thu, Mar 11, 2021 at 3:36 PM Takashi Iwai wrote:
>
> On Thu, 11 Mar 2021 14:27:48 +0100,
> Andy Shevchenko wrote:
> >
> > Sort alphanumerically the HDA_CODEC_ENTRY() entries for better maintenance.
> > No functional change implied.
> >
> > Note
Sort alphanumerically the HDA_CODEC_ENTRY() entries for better maintenance.
No functional change implied.
Note, that HDA_CODEC_REV_ENTRY() goes after HDA_CODEC_ENTRY() as per
default value in the latter macro.
Signed-off-by: Andy Shevchenko
---
sound/pci/hda/patch_realtek.c | 10 +-
1
Sort alphanumerically the SND_PCI_QUIRK() entries for better maintenance.
No functional change implied.
Signed-off-by: Andy Shevchenko
---
sound/pci/hda/patch_realtek.c | 73 +--
1 file changed, 36 insertions(+), 37 deletions(-)
diff --git a/sound/pci/hda
dio.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * ACPI helper for the MDIO (Ethernet PHY) API
> + */
> +
> +#ifndef __LINUX_ACPI_MDIO_H
> +#define __LINUX_ACPI_MDIO_H
> +
> +#include
> +
> +#if IS_ENABLED(CONFIG_ACPI_MDIO)
> +int acpi_mdiobus_register(st
On Thu, Mar 11, 2021 at 8:22 AM Calvin Johnson
wrote:
>
> Introduce a wrapper around the _ADR evaluation.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Calvin Johnson
> ---
>
> Changes in v7: None
> Changes in v6: None
> Changes in v5:
> - Replace fwnode_get_id()
e
> *mdio_np);
> int of_phy_register_fixed_link(struct device_node *np);
> void of_phy_deregister_fixed_link(struct device_node *np);
> bool of_phy_is_fixed_link(struct device_node *np);
> +struct mii_timestamper *of_find_mii_timestamper(struct device_node *np);
> int of_mdiobus_phy_device_register(struct mii_bus *mdio, struct phy_device
> *phy,
>struct device_node *child, u32 addr);
>
> @@ -118,7 +119,10 @@ static inline bool of_phy_is_fixed_link(struct
> device_node *np)
> {
> return false;
> }
> -
> +static inline struct mii_timestamper *of_find_mii_timestamper(struct
> device_node *np)
> +{
> + return NULL;
> +}
> static inline int of_mdiobus_phy_device_register(struct mii_bus *mdio,
> struct phy_device *phy,
> struct device_node *child, u32
> addr)
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson
wrote:
>
> Callers of unregister_mii_timestamper() currently check for NULL
> value of mii_ts before calling it.
>
> Place the NULL check inside unregister_mii_timestamper() and update
> the callers accordingly
FWIW,
Reviewed-b
On Thu, Mar 11, 2021 at 11:25:21AM +0300, Heikki Krogerus wrote:
> Making Andy and myself (Heikki) the designated reviewers of
> the thing. The software node mailing list shall be
> linux-a...@vger.kernel.org for now.
Acked-by: Andy Shevchenko
> Signed-off-by: Hei
On Thu, Mar 11, 2021 at 12:15:29AM +0100, Linus Walleij wrote:
> On Thu, Mar 4, 2021 at 9:13 PM Andy Shevchenko
> wrote:
>
> > Linus Walleij pointed out that ird_domain_add_simple() gained
> > additional functionality and can't be anymore replaced with
> > a simple
PI, which recently becomes swnode) which aims exactly
this.
--
With Best Regards,
Andy Shevchenko
by: Veerabhadrarao Badiganti
> Signed-off-by: Rajendra Nayak
Should be no blank lines in the tag block.
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 10, 2021 at 2:55 PM Álvaro Fernández Rojas
wrote:
>
> Add a helper for registering BCM63XX pin controllers.
Reviewed-by: Andy Shevchenko
(from use of the fwnode API perspective)
I'll think about of_match_node() case and perhaps come up with
corresponding fwnode API so
t consistent
> with other Ingenic SoCs.
> 4.Fix bug in "ingenic_pinconf_get()", so that it can read the configuration
> of X1830 SoC correctly.
>
Split to 4 patches then.
It's quite hard for everybody to handle regression fixes like this.
--
With Best Regards,
Andy Shevchenko
On Wed, Mar 10, 2021 at 2:55 PM Álvaro Fernández Rojas
wrote:
>
> This is needed for properly registering GPIO regmap as a child of a regmap
> pin controller.
Reviewed-by: Andy Shevchenko
Thanks!
> Signed-off-by: Álvaro Fernández Rojas
> Reviewed-by: Michael Walle
> ---
On Tue, Mar 09, 2021 at 11:40:08AM +0200, Andy Shevchenko wrote:
> On Mon, Mar 08, 2021 at 11:01:44PM +0200, Andy Shevchenko wrote:
> > On Mon, Mar 8, 2021 at 10:34 PM Stephen Rothwell
> > wrote:
> > > On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell
> > >
for gpio-mockup that will be easily extensible
> with new features and doesn't require reloading the module to change
> the setup.
Thanks for an update!
Looks much better now, although few minor comments below.
Reviewed-by: Andy Shevchenko
>
> Signed-off-by: Bartosz Golaszewski
> ---
> Do
On Wed, Mar 10, 2021 at 10:35:39AM +, Lee Jones wrote:
> On Mon, 08 Mar 2021, Andy Shevchenko wrote:
>
> > Instead of open coding pci_p2sb_bar() functionality we are going to
> > use generic library for that. There one more user of it is coming.
> >
> >
it.
>
> So as long as Andy is aware of how his patches got rebased and don't
> match his branch any more, I think it's not a big deal, and I've
> pulled it as-is.
Thanks! It's not big deal, but a good learning anyway how to communicate and
proceed with the git in such (rare I suppose) situations.
--
With Best Regards,
Andy Shevchenko
On Tue, Mar 9, 2021 at 6:36 PM Linus Walleij wrote:
> On Mon, Mar 8, 2021 at 8:45 PM Andy Shevchenko
> wrote:
>
> > Linus Walleij pointed out that ird_domain_add_simple() gained
> > additional functionality and can't be anymore replaced with
> > a simple conditional
0
> __device_attach_driver+0xb4/0x110
After addressing above, FWIW,
Reviewed-by: Andy Shevchenko
> Fixes: 59c324683400 ("gpio: wcd934x: Add support to wcd934x gpio controller")
> Signed-off-by: Srinivas Kandagatla
> ---
> drivers/gpio/gpio-wcd934x.c | 2 +-
> 1 fi
1) till the first rc of the new cycle (v5.12-rc1).
Now we are more than a week after v5.12-rc1.
--
With Best Regards,
Andy Shevchenko
;type, "ccgx-ucsi",
> sizeof(i2c_dw_ccgx_ucsi->type));
> + i2c_dw_ccgx_ucsi->addr = 0x08;
> + i2c_dw_ccgx_ucsi->irq = i2cd->irq;
> +
> + ccgx_client = i2c_new_client_device(>adapter, i2c_dw_ccgx_ucsi);
> + if (!ccgx_client)
> + return -ENODEV;
> +
> + return 0;
> +}
This is the same as in nVidia GPU I²C driver. Can you do a preparatory changes
to deduplicate this?
Also why (1) and this can't be instantiated from ACPI / DT?
--
With Best Regards,
Andy Shevchenko
TI_TSC2046_NAME, dev_name(dev));
NULL check?
...
> + trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
> + indio_dev->name, indio_dev->id);
One line?
> + if (!trig)
> + return -ENOMEM;
...
> +static const struct of_device_id ads7950_of_table[] = {
> + { .compatible = "ti,tsc2046e-adc", .data = _adc_dcfg_tsc2046e
> },
> + { },
No comma needed for a terminator line.
> +};
--
With Best Regards,
Andy Shevchenko
On Tue, Mar 9, 2021 at 2:18 PM Oleksij Rempel wrote:
>
> On Tue, Mar 09, 2021 at 01:46:55PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 9, 2021 at 1:42 PM Oleksij Rempel
> > wrote:
> > > On Tue, Mar 09, 2021 at 01:05:27PM +0200, Andy Shevchenko wrote:
> > &
On Tue, Mar 9, 2021 at 1:42 PM Oleksij Rempel wrote:
> On Tue, Mar 09, 2021 at 01:05:27PM +0200, Andy Shevchenko wrote:
> > On Fri, Mar 5, 2021 at 9:05 PM Jonathan Cameron
> > wrote:
> > >
> > > On Fri, 5 Mar 2021 14:38:13 +0100
> > > Oleksij Rempel wro
On Tue, Mar 09, 2021 at 11:51:58AM +0100, Rodolfo Giometti wrote:
> On 09/03/21 11:47, Andy Shevchenko wrote:
> > +Cc: Greg
> >
> > On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote:
> >> On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote:
Rearrange optional stuff in pps_gpio_setup() so it will go after mandatory one
and with reduced indentation. This will increase readability of the sources.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 33 ++---
1 file changed, 18 insertions
In most parts of the code the platform device is not used.
Use struct device pointer directly to reduce code size and
increase readability.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 42 +++---
1 file changed, 19 insertions(+), 23 deletions
The timer along with GPIO API are NULL-aware, there is no need to test
against existing GPIO echo line.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps
When requesting optional GPIO echo line, bail out on error,
so user will know that something wrong with the existing property.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pps/clients/pps
Platform data is a legacy interface to supply device properties
to the driver. In this case we even don't have in-kernel users
for it. Just remove it for good.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 17 +++--
include/linux/pps-gpio.h | 19
Device property API allows to gather device resources from different sources,
such as ACPI. Convert the drivers to unleash the power of device property API.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions
When GPIO APIs return -EPROBE_DEFER there is no need to print the message,
especially taking into consideration that it may repeat several times.
Use dev_err_probe() to avoid log noise in such cases.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 15 ++-
1 file
t stop review of this in the meantime.
>
> There are quite a few things in here that feel pretty specific to the
> touchscreen
> usecase. That makes me wonder if this is a sensible approach or not.
I'm wondering if this has any similarities with existing drivers under
drivers/input/touchscreen.
--
With Best Regards,
Andy Shevchenko
ecause this one needs a very good
justification why it's a new driver rather than extension of the
existing one.
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 01, 2021 at 05:30:10PM +0300, Heikki Krogerus wrote:
> Hi,
>
> The second one only affects 5.12-rc1.
Rafael, Greg, can this be applied for v5.12-rcX?
--
With Best Regards,
Andy Shevchenko
+Cc: Greg
On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote:
> > When requesting optional GPIO echo line, bail out on error,
> > so user will know that something wrong with the existing property.
On Tue, Mar 09, 2021 at 09:19:19AM +0100, Bartosz Golaszewski wrote:
> On Mon, Mar 8, 2021 at 8:52 PM Andy Shevchenko
> wrote:
> > On Mon, Mar 08, 2021 at 09:36:52PM +0200, Andy Shevchenko wrote:
...
> > So, I will send v6 with those included.
>
> Does this series d
On Mon, Mar 08, 2021 at 11:01:44PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 8, 2021 at 10:34 PM Stephen Rothwell
> wrote:
> > On Tue, 9 Mar 2021 07:26:20 +1100 Stephen Rothwell
> > wrote:
> > >
> > > Commits
> > >
> > > eb441337c714 (
irq_domain_add_simple(),
but takes a pointer to the struct fwnode_handle as a parameter.
While at it, amend documentation to mention irq_domain_create_*()
functions where it makes sense.
Signed-off-by: Andy Shevchenko
Acked-by: Marc Zyngier
---
Documentation/core-api/irq/irq-domain.rst | 22
WARN() deduplication in the commit message (Rafael)
In v3:
- fixed subtle bug in gpiod_count
- made irq_domain_add_simple() static inline (Marc)
In v2:
- added a new patch due to functionality in irq_comain_add_simple() (Linus)
- tagged patches 2-4 (Linus)
- Cc'ed to Rafael
Andy Shevchenko (6
Signed-off-by: Andy Shevchenko
Reviewed-by: Rafael J. Wysocki
---
drivers/gpio/gpiolib.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 1853075df741..afee48e7dd41 100644
--- a/drivers/gpio/gpiolib.c
+++ b/d
It's quite spread code to initialize IRQ domain options.
Let's fold it into a simple oneliner.
Signed-off-by: Andy Shevchenko
---
drivers/gpio/gpiolib.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index
We have (historically) different approaches how we identify the type
of a given fwnode. Let's standardize them across the library code.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib.c | 28 +---
1 file changed, 13 insertions(+), 15
per.
Amend gpiolib.c and gpiolib-of.c code in order to group OF operations.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-of.c | 6 --
drivers/gpio/gpiolib.c| 9 -
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/g
In the ACPI case we may use the firmware node in the similar way
as it's done for OF case. We may use that fwnode for other purposes
in the future.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-acpi.c | 7 +++
drivers/gpio/gpiolib-acpi.h | 4
inal will be fixed I'll fix mine.
Thanks!
P.S. Bart, you may simply merge my tag even on top of v5.12-rc2. It
will save you time and keep the original SHA IDs.
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 08, 2021 at 08:47:47PM +0100, Rafael J. Wysocki wrote:
> On Mon, Mar 8, 2021 at 8:45 PM Andy Shevchenko
> wrote:
> >
> > It's quite spread code to initialize IRQ domain options.
> > Let's fold it into a simple oneliner.
> >
> > Signed-off-
On Mon, Mar 08, 2021 at 09:46:52PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 08, 2021 at 08:43:19PM +0100, Rafael J. Wysocki wrote:
> I just sent v5 without this, sorry :-)
I will do it in v6.
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 08, 2021 at 09:36:52PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 08, 2021 at 08:29:27PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Mar 8, 2021 at 8:26 PM Rafael J. Wysocki wrote:
> > > On Mon, Mar 8, 2021 at 8:23 PM Bartosz Golaszewski
> > >
On Mon, Mar 08, 2021 at 08:43:19PM +0100, Rafael J. Wysocki wrote:
> On Mon, Mar 8, 2021 at 8:33 PM Andy Shevchenko
> wrote:
...
> It looks like the ops local var is redundant.
>
> > unsigned int type;
> > unsigned int i;
> >
> &g
in gpiod_count
- made irq_domain_add_simple() static inline (Marc)
In v2:
- added a new patch due to functionality in irq_comain_add_simple() (Linus)
- tagged patches 2-4 (Linus)
- Cc'ed to Rafael
Andy Shevchenko (6):
irqdomain: Introduce irq_domain_create_simple() API
gpiolib: Unify the checks
Signed-off-by: Andy Shevchenko
---
drivers/gpio/gpiolib.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 1853075df741..afee48e7dd41 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -
It's quite spread code to initialize IRQ domain options.
Let's fold it into a simple oneliner.
Signed-off-by: Andy Shevchenko
---
drivers/gpio/gpiolib.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index afee48e7dd41
In the ACPI case we may use the firmware node in the similar way
as it's done for OF case. We may use that fwnode for other purposes
in the future.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-acpi.c | 7 +++
drivers/gpio/gpiolib-acpi.h | 4
We have (historically) different approaches how we identify the type
of a given fwnode. Let's standardize them across the library code.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib.c | 28 +---
1 file changed, 13 insertions(+), 15
irq_domain_add_simple(),
but takes a pointer to the struct fwnode_handle as a parameter.
While at it, amend documentation to mention irq_domain_create_*()
functions where it makes sense.
Signed-off-by: Andy Shevchenko
Acked-by: Marc Zyngier
---
Documentation/core-api/irq/irq-domain.rst | 22
per.
Amend gpiolib.c and gpiolib-of.c code in order to group OF operations.
Signed-off-by: Andy Shevchenko
Reviewed-by: Linus Walleij
---
drivers/gpio/gpiolib-of.c | 6 --
drivers/gpio/gpiolib.c| 9 -
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/g
ges show up this release cycle. I'd rather take them through
> the usual channel. Thanks!
Since now we have v4 based on Rafael's bleeding-edge, what do you want me to
do? Resend a v5 with all patches included?
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 08, 2021 at 08:26:39PM +0100, Rafael J. Wysocki wrote:
> On Mon, Mar 8, 2021 at 8:23 PM Bartosz Golaszewski
> wrote:
> > On Mon, Mar 8, 2021 at 7:22 PM Rafael J. Wysocki wrote:
> > > On Thu, Mar 4, 2021 at 9:13 PM Andy Shevchenko
> > > wrote:
>
Signed-off-by: Andy Shevchenko
---
v4: added a paragraph about WARN changes, split out ops optimizations (Rafael)
drivers/gpio/gpiolib.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 1853075df741..afee48
It's quite spread code to initialize IRQ domain options.
Let's fold it into a simple oneliner.
Signed-off-by: Andy Shevchenko
---
v4: new patch (see changelog of previous one)
drivers/gpio/gpiolib.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio
On Mon, Mar 08, 2021 at 12:52:12PM -0600, Bjorn Helgaas wrote:
> On Mon, Mar 08, 2021 at 02:20:16PM +0200, Andy Shevchenko wrote:
> > From: Jonathan Yong
> >
> > There is already one and at least one more user is coming which
> > requires an access to Primary to Side
On Mon, Mar 08, 2021 at 07:32:47PM +0100, Rafael J. Wysocki wrote:
> On Thu, Mar 4, 2021 at 4:02 PM Andy Shevchenko
> wrote:
> >
> > When IRQ domain is created for an ACPI case, the name of it becomes
> > unknown-%d
> > since for now it utilizes of_node member on
* administrator!
> > **\n");
> > - pr_warn("**
> > **\n");
> > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE
> > **\n");
> > -
> > pr_warn("**\n");
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 08, 2021 at 07:08:42PM +0200, Andy Shevchenko wrote:
> During the split of intel_pinctrl_add_padgroups(), the _by_size() variant
> missed the GPIO base calculations and hence made unable to retrieve proper
> GPIO number.
>
> Assign the gpio_base explicitly in _by
.
Fixes: 036e126c72eb ("pinctrl: intel: Split intel_pinctrl_add_padgroups() for
better maintenance")
Reported-and-tested-by: Maximilian Luz
Signed-off-by: Andy Shevchenko
Acked-by: Mika Westerberg
---
v2: added tag and Cc'ed to stable@ (Mika)
drivers/pinctrl/intel/pinctrl-intel.c | 2
.
Fixes: 036e126c72eb ("pinctrl: intel: Split intel_pinctrl_add_padgroups() for
better maintenance")
Reported-and-tested-by: Maximilian Luz
Signed-off-by: Andy Shevchenko
---
drivers/pinctrl/intel/pinctrl-intel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/int
On Mon, Mar 8, 2021 at 6:44 PM Maximilian Luz wrote:
> On 3/8/21 5:31 PM, Andy Shevchenko wrote:
> > On Mon, Mar 08, 2021 at 05:35:59PM +0200, Andy Shevchenko wrote:
> >> On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> >>> Following commit 036e12
On Mon, Mar 8, 2021 at 6:34 PM Maximilian Luz wrote:
>
> On 3/8/21 4:35 PM, Andy Shevchenko wrote:
> > On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> >> Following commit 036e126c72eb ("pinctrl: intel: Split
> >> intel_pinctrl_add
On Mon, Mar 8, 2021 at 6:28 PM Calvin Johnson
wrote:
> On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote:
> I thought of including device.h instead of dev_printk.h because, it is the
> only file that includes dev_printk.h and device.h is widely used. Of course,
>
On Mon, Mar 08, 2021 at 04:37:10PM +0100, Bartosz Golaszewski wrote:
> On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko
> wrote:
> >
> > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote:
> > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko
> >
On Mon, Mar 08, 2021 at 04:38:42PM +0100, Bartosz Golaszewski wrote:
> On Thu, Mar 4, 2021 at 12:01 PM Andy Shevchenko
> wrote:
> > On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote:
> > > On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
> > > wrot
On Mon, Mar 08, 2021 at 05:35:59PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
> > Following commit 036e126c72eb ("pinctrl: intel: Split
> > intel_pinctrl_add_padgroups() for better maintenance"),
> > gpiochip_ge
On Mon, Mar 8, 2021 at 6:06 PM Andy Shevchenko
wrote:
> On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote:
>
> > - depends on EXTCON || !EXTCON
>
> I stumbled over this.
> What is the point of having this line at all?
> What magic trick does it serve for?
Okay,
On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote:
> - depends on EXTCON || !EXTCON
I stumbled over this.
What is the point of having this line at all?
What magic trick does it serve for?
--
With Best Regards,
Andy Shevchenko
-H 15 /sys/bus/acpi/devices/*/status`.
> There is probably a better option than straight up reverting this, so
> consider this more of a bug-report.
Indeed.
--
With Best Regards,
Andy Shevchenko
On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote:
> On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko
> wrote:
> > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote:
...
> > I have strong opinion not to open code "yet another parser
On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote:
> On Fri, Mar 5, 2021 at 11:15 AM Andy Shevchenko
> wrote:
> > On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote:
> > > On Thu, Mar 4, 2021 at 2:15 PM Andy Shevchenko
> > > wrote
On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson
wrote:
> On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
> > wrote:
> > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
&g
On Mon, Mar 08, 2021 at 02:36:27PM +0100, Rafael J. Wysocki wrote:
> On Sun, Mar 7, 2021 at 9:39 PM Andy Shevchenko
> wrote:
> > On Sun, Mar 7, 2021 at 3:36 PM Daniel Scally wrote:
> > > On 22/02/2021 13:34, Andy Shevchenko wrote:
> > > > On Mon, Feb
On Mon, Mar 8, 2021 at 3:02 PM Henning Schild
wrote:
> Am Fri, 5 Mar 2021 19:44:57 +0200
> schrieb Andy Shevchenko :
> > On Fri, Mar 5, 2021 at 7:17 PM Andy Shevchenko
> > wrote:
> > > On Fri, Mar 5, 2021 at 6:47 PM Henning Schild
> > > wrote:
>
Instead of open coding pci_p2sb_bar() functionality we are going to
use generic library for that. There one more user of it is coming.
Besides cleaning up it fixes a potential issue if, by some reason,
SPI bar is 64-bit.
Signed-off-by: Andy Shevchenko
---
drivers/mfd/Kconfig | 1 +
drivers
601 - 700 of 17509 matches
Mail list logo
