[PATCH] selftests/mm: compaction_test: convert comments to preferred style

2025-05-16 Thread George Anthony Vernon
Convert multi-line comments to preferred style with beginning and ending almost-blank lines. Signed-off-by: George Anthony Vernon --- tools/testing/selftests/mm/compaction_test.c | 22 +--- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/mm

Re: [PATCH] ice: set the value of global config lock timeout longer

2021-04-20 Thread Nguyen, Anthony L
On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote: > It may need hold Global Config Lock a longer time when download DDP > package file, extend the timeout value to 5000ms to ensure that > download can be finished before other AQ command got time to run, > this will fix the issue below when probe

Re: [PATCH net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-12 Thread Nguyen, Anthony L
On Sun, 2021-04-11 at 02:45 +0100, Salil Mehta wrote: > If user has explicitly requested the number of {R,T}XQs, then it is > unnecessary > to get the count of already available {R,T}XQs from the PF > avail_{r,t}xqs > bitmap. This value will get overriden by user specified value in any s/override

[PATCH 1/3] Revert "USB: cdc-acm: fix rounding error in TIOCSSERIAL"

2021-04-07 Thread Anthony Mallet
ich is granted to regular users. Best, Anthony

Re: [RFC v2 01/43] mm: add PKRAM API stubs and Kconfig

2021-03-31 Thread Anthony Yznaga
On 3/31/21 11:43 AM, Randy Dunlap wrote: > On 3/30/21 2:35 PM, Anthony Yznaga wrote: >> Preserved-across-kexec memory or PKRAM is a method for saving memory >> pages of the currently executing kernel and restoring them after kexec >> boot into a new one. This can be utilized

[RFC v2 39/43] shmem: optimize adding pages to the LRU in shmem_insert_pages()

2021-03-30 Thread Anthony Yznaga
Reduce LRU lock contention when inserting shmem pages by staging pages to be added to the same LRU and adding them en masse. Signed-off-by: Anthony Yznaga --- mm/shmem.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index c3fa72061d8a

[RFC v2 31/43] memblock, mm: defer initialization of preserved pages

2021-03-30 Thread Anthony Yznaga
skipping them when other reserved pages are initialized and initializing them later with a separate kernel thread. Signed-off-by: Anthony Yznaga --- arch/x86/mm/init_64.c | 1 - include/linux/mm.h| 2 +- mm/memblock.c | 11 +-- mm/page_alloc.c | 55

[RFC v2 42/43] shmem: reduce time holding xa_lock when inserting pages

2021-03-30 Thread Anthony Yznaga
, add them to a local xarray, export the xarray node, and then take the lock on the page cache xarray and insert the node. Signed-off-by: Anthony Yznaga --- mm/shmem.c | 162 ++--- 1 file changed, 156 insertions(+), 6 deletions(-) diff --git

[RFC v2 41/43] XArray: add xas_export_node() and xas_import_node()

2021-03-30 Thread Anthony Yznaga
it. Signed-off-by: Anthony Yznaga --- Documentation/core-api/xarray.rst | 8 +++ include/linux/xarray.h| 2 + lib/test_xarray.c | 45 + lib/xarray.c | 100 ++ 4 files changed, 155 insertions

[RFC v2 43/43] PKRAM: improve index alignment of pkram_link entries

2021-03-30 Thread Anthony Yznaga
and the next aligned page will not fit on the pkram_link page. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/mm/pkram.c b/mm/pkram.c index b63b2a3958e7..3f43809c8a85 100644 --- a/mm/pkram.c +++ b/mm/pkram.c @@ -911,9

[RFC v2 40/43] shmem: initial support for adding multiple pages to pagecache

2021-03-30 Thread Anthony Yznaga
, but improvements in performance when multiple threads are adding to the same pagecache are achieved by calling a new shmem_add_to_page_cache_fast() function that does not check for conflicts and drops the xarray lock before updating stats. Signed-off-by: Anthony Yznaga --- mm/shmem.c | 123

[RFC v2 36/43] PKRAM: add support for loading pages in bulk

2021-03-30 Thread Anthony Yznaga
index of the first page are provided to the caller. Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 4 mm/pkram.c| 46 ++ 2 files changed, 50 insertions(+) diff --git a/include/linux/pkram.h b/include/linux/pkram.h index

[RFC v2 38/43] mm: implement splicing a list of pages to the LRU

2021-03-30 Thread Anthony Yznaga
. For now only unevictable pages are supported. Signed-off-by: Anthony Yznaga --- include/linux/swap.h | 13 mm/swap.c| 86 2 files changed, 99 insertions(+) diff --git a/include/linux/swap.h b/include/linux/swap.h index

[RFC v2 35/43] shmem: introduce shmem_insert_pages()

2021-03-30 Thread Anthony Yznaga
the shmem_inode_info lock and prepare for future optimizations, introduce shmem_insert_pages() which allows a caller to pass an array of pages to be inserted into a shmem segment. Signed-off-by: Anthony Yznaga --- include/linux/shmem_fs.h | 3 +- mm/shmem.c | 93

[RFC v2 37/43] shmem: PKRAM: enable bulk loading of preserved pages into shmem

2021-03-30 Thread Anthony Yznaga
Make use of new interfaces for loading and inserting preserved pages into a shmem file in bulk. Signed-off-by: Anthony Yznaga --- mm/shmem_pkram.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/mm/shmem_pkram.c b/mm/shmem_pkram.c index 354c2b58962c

[RFC v2 25/43] mm: shmem: prevent swapping of PKRAM-enabled tmpfs pages

2021-03-30 Thread Anthony Yznaga
Work around the limitation that shmem pages must be in memory in order to be preserved by preventing them from being swapped out in the first place. Do this by marking shmem pages associated with a PKRAM node as unevictable. Signed-off-by: Anthony Yznaga --- mm/shmem.c | 2 ++ 1 file changed

[RFC v2 34/43] shmem: PKRAM: multithread preserving and restoring shmem pages

2021-03-30 Thread Anthony Yznaga
: Anthony Yznaga --- mm/shmem_pkram.c | 94 +--- 1 file changed, 89 insertions(+), 5 deletions(-) diff --git a/mm/shmem_pkram.c b/mm/shmem_pkram.c index e52722b3a709..354c2b58962c 100644 --- a/mm/shmem_pkram.c +++ b/mm/shmem_pkram.c @@ -115,6 +115,7

[RFC v2 30/43] memblock: PKRAM: mark memblocks that contain preserved pages

2021-03-30 Thread Anthony Yznaga
To support deferred initialization of page structs for preserved pages, separate memblocks containing preserved pages by setting a new flag when adding them to the memblock reserved list. Signed-off-by: Anthony Yznaga --- include/linux/memblock.h | 6 ++ mm/pkram.c | 2 ++ 2

[RFC v2 33/43] PKRAM: atomically add and remove link pages

2021-03-30 Thread Anthony Yznaga
Add and remove pkram_link pages from a pkram_obj atomically to prepare for multithreading. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/mm/pkram.c b/mm/pkram.c index 08144c18d425

[RFC v2 20/43] PKRAM: disable feature when running the kdump kernel

2021-03-30 Thread Anthony Yznaga
The kdump kernel should not preserve or restore pages. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/pkram.c b/mm/pkram.c index 8700fd77dc67..aea069cc49be 100644 --- a/mm/pkram.c +++ b/mm/pkram.c @@ -1,4 +1,5

[RFC v2 29/43] PKRAM: ensure memblocks with preserved pages init'd for numa

2021-03-30 Thread Anthony Yznaga
In order to facilitate fast initialization of page structs for preserved pages, memblocks with preserved pages must not cross numa node boundaries and must have a node id assigned to them. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 9 + 1 file changed, 9 insertions(+) diff --git a

[RFC v2 27/43] mm: shmem: when inserting, handle pages already charged to a memcg

2021-03-30 Thread Anthony Yznaga
ff-by: Anthony Yznaga --- mm/shmem.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 8dfe80aeee97..44cc158ab34d 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -671,7 +671,7 @@ static inline bool is_huge_enabled(struct shmem_sb_info *s

[RFC v2 11/43] PKRAM: prepare for adding preserved ranges to memblock reserved

2021-03-30 Thread Anthony Yznaga
that does not overlap any preserved range, and populate it with a new, merged regions array. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 241 + 1 file changed, 241 insertions(+) diff --git a/mm/pkram.c b/mm/pkram.c index 4cfa236a4126

[RFC v2 14/43] PKRAM: prevent inadvertent use of a stale superblock

2021-03-30 Thread Anthony Yznaga
When pages have been saved to be preserved by the current boot, set a magic number on the super block to be validated by the next kernel. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 9 + 1 file changed, 9 insertions(+) diff --git a/mm/pkram.c b/mm/pkram.c index dab6657080bf

[RFC v2 32/43] shmem: preserve shmem files a chunk at a time

2021-03-30 Thread Anthony Yznaga
To prepare for multithreading the work to preserve a shmem file, divide the work into subranges of the total index range of the file. The chunk size is a rather arbitrary 256k indices. Signed-off-by: Anthony Yznaga --- mm/shmem_pkram.c | 64

[RFC v2 28/43] x86/mm/numa: add numa_isolate_memblocks()

2021-03-30 Thread Anthony Yznaga
. Signed-off-by: Anthony Yznaga --- arch/x86/include/asm/numa.h | 4 arch/x86/mm/numa.c | 32 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h index e3bae2b60a0d..632b5b6d8cb3

[RFC v2 24/43] mm: shmem: enable saving to PKRAM

2021-03-30 Thread Anthony Yznaga
implified: it supports only regular files in the root directory without multiple hard links, and it does not save swapped out files and aborts if any are found. However, it can be elaborated to fully support tmpfs. Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/shmem_

[RFC v2 23/43] mm: shmem: introduce shmem_insert_page

2021-03-30 Thread Anthony Yznaga
-off-by: Anthony Yznaga --- include/linux/shmem_fs.h | 3 ++ mm/shmem.c | 77 2 files changed, 80 insertions(+) diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h index d82b6f396588..3f0dd95efd46 100644 --- a/include

[RFC v2 22/43] x86/boot/compressed/64: use 1GB pages for mappings

2021-03-30 Thread Anthony Yznaga
results in the need for far fewer page table pages. As is this breaks AMD SEV-ES which expects the mappings to be 2M. This could possibly be fixed by updating split code to split 1GB page if the aren't any other issues with using 1GB mappings. Signed-off-by: Anthony Yznaga --- arch/x86

[RFC v2 26/43] mm: shmem: specify the mm to use when inserting pages

2021-03-30 Thread Anthony Yznaga
Explicitly specify the mm to pass to shmem_insert_page() when the pkram_stream is initialized rather than use the mm of the current thread. This will allow for multiple kernel threads to target the same mm when inserting pages in parallel. Signed-off-by: Anthony Yznaga --- mm/shmem_pkram.c | 6

[RFC v2 18/43] kexec: PKRAM: avoid clobbering already preserved pages

2021-03-30 Thread Anthony Yznaga
-off-by: Anthony Yznaga --- kernel/kexec_core.c | 3 +++ kernel/kexec_file.c | 5 + 2 files changed, 8 insertions(+) diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index a0b6780740c8..fda4abb865ff 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -37,6 +37,7 @@ #include

[RFC v2 10/43] PKRAM: pass a list of preserved ranges to the next kernel

2021-03-30 Thread Anthony Yznaga
not prepared to avoid possible conflicts with changes in a newer kernel and to avoid having to allocate a contiguous range larger than a page. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 183 ++--- 1 file changed, 176 insertions(+), 7

[RFC v2 19/43] mm: PKRAM: allow preserved memory to be freed from userspace

2021-03-30 Thread Anthony Yznaga
To free all space utilized for preserved memory, one can write 0 to /sys/kernel/pkram. This will destroy all PKRAM nodes that are not currently being read or written. Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- mm/pkram.c | 39 ++- 1

[RFC v2 21/43] x86/KASLR: PKRAM: support physical kaslr

2021-03-30 Thread Anthony Yznaga
Avoid regions of memory that contain preserved pages when computing slots used to select where to put the decompressed kernel. Signed-off-by: Anthony Yznaga --- arch/x86/boot/compressed/Makefile | 3 ++ arch/x86/boot/compressed/kaslr.c | 10 +++- arch/x86/boot/compressed/misc.h | 10

[RFC v2 09/43] PKRAM: track preserved pages in a physical mapping pagetable

2021-03-30 Thread Anthony Yznaga
existing architecture definitions for building a memory mapping pagetable except that a bitmap is used to represent the presence or absence of preserved pages at the PTE level. Signed-off-by: Anthony Yznaga --- mm/Makefile | 2 +- mm/pkram.c | 30 +++- mm/pkram_pagetable.c

[RFC v2 17/43] PKRAM: provide a way to check if a memory range has preserved pages

2021-03-30 Thread Anthony Yznaga
When a kernel is loaded for kexec the address ranges where the kexec segments will be copied to may conflict with pages already set to be preserved. Provide a way to determine if preserved pages exist in a specified range. Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 2 ++ mm

[RFC v2 16/43] kexec: PKRAM: prevent kexec clobbering preserved pages in some cases

2021-03-30 Thread Anthony Yznaga
reboot. Not yet handled is the case where pages have been preserved before a kexec kernel is loaded. This will be covered by a later patch. Signed-off-by: Anthony Yznaga --- kernel/kexec.c | 9 + kernel/kexec_file.c | 10 ++ 2 files changed, 19 insertions(+) diff --git a

[RFC v2 13/43] PKRAM: free the preserved ranges list

2021-03-30 Thread Anthony Yznaga
Free the pages used to pass the preserved ranges to the new boot. Signed-off-by: Anthony Yznaga --- arch/x86/mm/init_64.c | 1 + include/linux/pkram.h | 2 ++ mm/pkram.c| 20 3 files changed, 23 insertions(+) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm

[RFC v2 07/43] mm: PKRAM: link nodes by pfn before reboot

2021-03-30 Thread Anthony Yznaga
Since page structs are used for linking PKRAM nodes and cleared on boot, organize all PKRAM nodes into a list singly-linked by pfns before reboot to facilitate restoring the node list in the new kernel. Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- mm/pkram.c | 50

[RFC v2 02/43] mm: PKRAM: implement node load and save functions

2021-03-30 Thread Anthony Yznaga
pkram_finish_load() function must be called to free the node. Nodes are also deleted when a save operation is discarded, i.e. pkram_discard_save() is called instead of pkram_finish_save(). Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 8 ++- mm/pkram.c

[RFC v2 03/43] mm: PKRAM: implement object load and save functions

2021-03-30 Thread Anthony Yznaga
() is called to free the object. Objects are also deleted when a save operation is discarded. Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 2 ++ mm/pkram.c| 72 --- 2 files changed, 70 insertions(+), 4 deletions(-) diff

[RFC v2 06/43] mm: PKRAM: implement byte stream operations

2021-03-30 Thread Anthony Yznaga
This patch adds the ability to save an arbitrary byte streams to a a PKRAM object using pkram_write() to be restored later using pkram_read(). Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 11 + mm/pkram.c| 123

[RFC v2 00/43] PKRAM: Preserved-over-Kexec RAM

2021-03-30 Thread Anthony Yznaga
_files/kvmforum2019/66/VMM-fast-restart_kvmforum2019.pdf [3] https://www.youtube.com/watch?v=pBsHnf93tcQ https://static.sched.com/hosted_files/kvmforum2020/10/Device-Keepalive-State-KVMForum2020.pdf Anthony Yznaga (43): mm: add PKRAM API stubs and Kconfig mm: PKRAM: implement node load and save funct

[RFC v2 01/43] mm: add PKRAM API stubs and Kconfig

2021-03-30 Thread Anthony Yznaga
) /* free the object */ pkram_finish_load_obj() /* free the node */ pkram_finish_load() Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 47 + mm/Kconfig| 9 +++ mm/Makefile | 1 + mm/pkram.c| 179

[RFC v2 04/43] mm: PKRAM: implement page stream operations

2021-03-30 Thread Anthony Yznaga
freed after the last user puts it. Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 42 +++- mm/pkram.c| 282 +- 2 files changed, 317 insertions(+), 7 deletions(-) diff --git a/include/linux

[RFC v2 08/43] mm: PKRAM: introduce super block

2021-03-30 Thread Anthony Yznaga
pkram' boot param. For that purpose, the pkram super block pfn is exported via /sys/kernel/pkram. If none is passed, any preserved memory will not be kept, and a new super block will be allocated. Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- mm/pkr

[RFC v2 05/43] mm: PKRAM: support preserving transparent hugepages

2021-03-30 Thread Anthony Yznaga
Support preserving a transparent hugepage by recording the page order and a flag indicating it is a THP. Use these values when the page is restored to reconstruct the THP. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 20 1 file changed, 16 insertions(+), 4 deletions

[RFC v2 12/43] mm: PKRAM: reserve preserved memory at boot

2021-03-30 Thread Anthony Yznaga
Keep preserved pages from being recycled during boot by adding them to the memblock reserved list during early boot. If memory reservation fails (e.g. a region has already been reserved), all preserved pages are dropped. Signed-off-by: Anthony Yznaga --- arch/x86/kernel/setup.c | 3 ++ arch

[RFC v2 15/43] PKRAM: provide a way to ban pages from use by PKRAM

2021-03-30 Thread Anthony Yznaga
: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 2 + mm/pkram.c| 205 ++ 2 files changed, 207 insertions(+) diff --git a/include/linux/pkram.h b/include/linux/pkram.h index c2099a4f2004..97a7c2ac44a9 100644

Re: [PATCH STABLE 5.10 5.11] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
On Thu, Mar 04, 2021 at 05:58:49PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 04, 2021 at 05:30:00PM +0100, Anthony Iliopoulos wrote: > > On Thu, Mar 04, 2021 at 04:16:26PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 04, 2021 at 04:08:24PM +0100, Anthony Iliopoulos wro

Re: [PATCH STABLE 5.10 5.11] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
On Thu, Mar 04, 2021 at 04:16:26PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 04, 2021 at 04:08:24PM +0100, Anthony Iliopoulos wrote: > > commit caf6912f3f4af7232340d500a4a2008f81b93f14 upstream. > > No, this does not look like that commit. > > Why can I not just tak

[PATCH STABLE 5.4] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
kernel.org # 5.4 Signed-off-by: Anthony Iliopoulos --- mm/page_io.c | 11 +++ mm/swapfile.c | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 60a66a58b9bf..f03dca3f43d9 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -37,7 +37,6

[PATCH STABLE 5.10 5.11] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
kernel.org # 5.10+ Signed-off-by: Anthony Iliopoulos --- mm/page_io.c | 12 mm/swapfile.c | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 433df1263349..1541c0d6ad6e 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -37,7 +37,6

[PATCH STABLE 4.4] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
kernel.org # 4.4 Signed-off-by: Anthony Iliopoulos --- mm/page_io.c | 11 +++ mm/swapfile.c | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index b995a5ba5e8f..ab92cd559404 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -32,7 +32,6

[PATCH STABLE 4.14 4.19] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
kernel.org # 4.14 4.19 Signed-off-by: Anthony Iliopoulos --- mm/page_io.c | 11 +++ mm/swapfile.c | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index 08d2eae58fce..9b646f07f47f 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -

[PATCH STABLE ONLY] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
The following patches fix the swapfile page-to-sector mapping for block devices that implement rw_page for all the stable kernels. This is related to the upstream fix of commit caf6912f3f4a ("swap: fix swapfile read/write offset"), but for kernels prior to v5.12-rc1 the bug only affects swapfiles

[PATCH STABLE 4.9] swap: fix swapfile page to sector mapping

2021-03-04 Thread Anthony Iliopoulos
kernel.org # 4.9 Signed-off-by: Anthony Iliopoulos --- mm/page_io.c | 11 +++ mm/swapfile.c | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/mm/page_io.c b/mm/page_io.c index a2651f58c86a..ad0e0ce31090 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -32,7 +32,6

Re: [PATCH] e1000e: use proper #include guard name in hw.h

2021-03-01 Thread Nguyen, Anthony L
On Sat, 2021-02-27 at 10:58 +0100, Greg Kroah-Hartman wrote: > The include guard for the e1000e and e1000 hw.h files are the same, > so > add the proper "E" term to the hw.h file for the e1000e driver. There's a patch in process that addresses this issue [1]. > This resolves some static analyzer

Re: [PATCH resend] e100: switch from 'pci_' to 'dma_' API

2021-01-28 Thread Nguyen, Anthony L
On Thu, 2021-01-28 at 22:07 +0100, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has > been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > Whe

Re: [PATCH 4.19 12/58] dm integrity: select CRYPTO_SKCIPHER

2021-01-25 Thread Anthony Iliopoulos
On Mon, Jan 25, 2021 at 07:58:29PM +0100, Pavel Machek wrote: > Hi! > > > From: Anthony Iliopoulos > > > > [ Upstream commit f7b347acb5f6c29d9229bb64893d8b6a2c7949fb ] > > > > The integrity target relies on skcipher for encryption/decryption, but >

[PATCH] dm integrity: select the Kconfig option CRYPTO_SKCIPHER

2020-12-14 Thread Anthony Iliopoulos
-by: Anthony Iliopoulos --- drivers/md/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig index 30ba3573626c..5c0e7063f5f5 100644 --- a/drivers/md/Kconfig +++ b/drivers/md/Kconfig @@ -585,6 +585,7 @@ config DM_INTEGRITY select

Re: [Intel-wired-lan] [PATCH] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init()

2020-10-12 Thread Nguyen, Anthony L
On Mon, 2020-10-12 at 08:16 -0700, Jakub Kicinski wrote: > On Mon, 12 Oct 2020 14:20:16 +0200 Bartosz Golaszewski wrote: > > On Mon, Sep 28, 2020 at 9:17 AM Bartosz Golaszewski > > wrote: > > > > > > From: Bartosz Golaszewski > > > > > > It's a valid use-case for ixgbe_mii_bus_init() to return

Re: [PATCH] net: intel: ice: Use uintptr_t for casting data

2020-10-09 Thread Nguyen, Anthony L
On Fri, 2020-10-09 at 14:18 +0800, Pujin Shi wrote: > Fix up a compiler error on 64bit architectures where pointers. > > In file included from > drivers/net/ethernet/intel/ice/ice_flex_pipe.c:6:0: > drivers/net/ethernet/intel/ice/ice_flex_pipe.c: In function > 'ice_free_flow_profs': > drivers/net/

Re: [PATCH v2] PR_SPEC_DISABLE_NOEXEC support for arm64.

2020-09-29 Thread Anthony Steinhauser
Thanks a lot Will, Everything looks good to me now. On Tue, Sep 29, 2020 at 4:10 AM Will Deacon wrote: > > Hi Anthony, > ... > > I'll fold in the diff below, which I think solves the problem above; it's > closer to what you had originally, just refactored a bit

Re: [PATCH v2] PR_SPEC_DISABLE_NOEXEC support for arm64.

2020-09-28 Thread Anthony Steinhauser
} > @@ -744,6 +753,9 @@ static int ssbd_prctl_get(struct task_struct *task) > if (task_spec_ssb_force_disable(task)) > return PR_SPEC_PRCTL | PR_SPEC_FORCE_DISABLE; > > + if (task_spec_ssb_noexec(task)) > + return PR_SPEC_PRCTL | PR_SPEC_DISABLE_NOEXEC; > + > if (task_spec_ssb_disable(task)) > return PR_SPEC_PRCTL | PR_SPEC_DISABLE; > Best, Anthony

[PATCH v2] PR_SPEC_DISABLE_NOEXEC support for arm64.

2020-09-22 Thread Anthony Steinhauser
Support of Spectre v4 PR_SPEC_DISABLE_NOEXEC mitigation mode for on arm64. PR_SPEC_DISABLE_NOEXEC turns the mitigation on, but it is automatically turned off whenever a new program is being execve'ed. Signed-off-by: Anthony Steinhauser --- I added the "#include " line to the ar

Re: [PATCH] PR_SPEC_DISABLE_NOEXEC support for arm64.

2020-09-20 Thread Anthony Steinhauser
using PR_SPEC_DISABLE_NOEXEC to decide > what we set the SSBS bit to on exec, but the logic here requires TIF_SSBD > to be set and so won't trigger afaict. > You're right. The SSBS support is incomplete. I guess "test_thread_flag(TIF_SSBD)" can be replaced just with "arm64_get_ssbd_state() == ARM64_SSBD_KERNEL". Thanks, Anthony

Re: [PATCH] i40e: Fix use of uninitialized variable

2020-09-17 Thread Nguyen, Anthony L
On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote: > In i40e_clean_rx_irq_zc(), the variable failure is only set when a > condition is met, but then its value is used unconditionally. Fix > this. > > Addresses-Coverity: 1496986 ("Uninitialized value") > Fixes: 8cbf74149903 ("i40e, xsk: move buff

Re: [RFC PATCH 3/5] mm: introduce VM_EXEC_KEEP

2020-07-29 Thread Anthony Yznaga
On 7/29/20 6:52 AM, Kirill A. Shutemov wrote: > On Mon, Jul 27, 2020 at 10:11:25AM -0700, Anthony Yznaga wrote: >> A vma with the VM_EXEC_KEEP flag is preserved across exec. For anonymous >> vmas only. For safety, overlap with fixed address VMAs created in the new >> mm

Re: [RFC PATCH 3/5] mm: introduce VM_EXEC_KEEP

2020-07-28 Thread Anthony Yznaga
On 7/28/20 6:38 AM, ebied...@xmission.com wrote: > Anthony Yznaga writes: > >> A vma with the VM_EXEC_KEEP flag is preserved across exec. For anonymous >> vmas only. For safety, overlap with fixed address VMAs created in the new >> mm during exec (e.g. the stack and e

Re: [RFC PATCH 0/5] madvise MADV_DOEXEC

2020-07-28 Thread Anthony Yznaga
On 7/28/20 4:34 AM, Kirill Tkhai wrote: > On 27.07.2020 20:11, Anthony Yznaga wrote: >> This patchset adds support for preserving an anonymous memory range across >> exec(3) using a new madvise MADV_DOEXEC argument. The primary benefit for >> sharing memory in this man

[RFC PATCH 5/5] mm: introduce MADV_DOEXEC

2020-07-27 Thread Anthony Yznaga
reverts to MADV_DONTEXEC. Signed-off-by: Steve Sistare Signed-off-by: Anthony Yznaga --- include/uapi/asm-generic/mman-common.h | 3 +++ mm/madvise.c | 25 + 2 files changed, 28 insertions(+) diff --git a/include/uapi/asm-generic/mman-common.h

[RFC PATCH 3/5] mm: introduce VM_EXEC_KEEP

2020-07-27 Thread Anthony Yznaga
no conflicts. Comments welcome.) Signed-off-by: Steve Sistare Signed-off-by: Anthony Yznaga --- arch/x86/Kconfig | 1 + fs/exec.c | 20 include/linux/mm.h | 5 + kernel/fork.c | 2 +- mm/mmap.c | 47

[RFC PATCH 0/5] madvise MADV_DOEXEC

2020-07-27 Thread Anthony Yznaga
et up. Patch 1 re-introduces the use of MAP_FIXED_NOREPLACE to load ELF binaries that addresses the previous issues and could be considered on its own. Patches 3, 4, and 5 introduce the feature and an opt-in method for its use using an ELF note. Anthony Yznaga (5): elf: reintroduce

[RFC PATCH 1/5] elf: reintroduce using MAP_FIXED_NOREPLACE for elf executable mappings

2020-07-27 Thread Anthony Yznaga
nue to map at a system-selected address in the mmap region. Signed-off-by: Anthony Yznaga --- fs/binfmt_elf.c | 112 1 file changed, 64 insertions(+), 48 deletions(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 9fe3b51c116a..6445

[RFC PATCH 4/5] exec, elf: require opt-in for accepting preserved mem

2020-07-27 Thread Anthony Yznaga
Don't copy preserved VMAs to the binary being exec'd unless the binary has a "preserved-mem-ok" ELF note. Signed-off-by: Anthony Yznaga --- fs/binfmt_elf.c | 84 + fs/exec.c | 17 +- include/

[RFC PATCH 2/5] mm: do not assume only the stack vma exists in setup_arg_pages()

2020-07-27 Thread Anthony Yznaga
there is no vma between the vma passed to it and the address to expand to, so check before calling it. Signed-off-by: Anthony Yznaga --- fs/exec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/exec.c b/fs/exec.c index e6e8a9a70327..262112e5f9f8 100644 --- a/fs/exec.c

[PATCH] PR_SPEC_DISABLE_NOEXEC support for arm64.

2020-07-17 Thread Anthony Steinhauser
For x64 it was already implemented in: https://github.com/torvalds/linux/commit/71368af The rationale is the same as for the x64 implementation. Signed-off-by: Anthony Steinhauser --- It's actively attempted by OpenJDK on arm64 CentOS and Fedora: https://git.centos.org/rpms/java-11-op

Urgent Attention

2020-07-07 Thread Mr Anthony Ehimare
Good Day, I am Anthony Ehimare a banker I have something very important to discuss with you about an unpaid inheritance fund left in my bank for a long time by a late customer who has the same last name with you I do not know if he was a member of your family.The Lawyer that contacted you in the

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Anthony Steinhauser
Yes, this probably requires an explanation why the change is necessary or useful. Without that it is difficult to give some meaningful feedback.

Re: [PATCH] x86/speculation: Merge one test in spectre_v2_user_select_mitigation()

2020-06-15 Thread Anthony Steinhauser
Thanks, Borislav.

Re: [tip: x86/urgent] x86/speculation: Avoid force-disabling IBPB based on STIBP and enhanced IBRS.

2020-06-11 Thread Anthony Steinhauser
Hi Borislav, On Thu, Jun 11, 2020 at 7:09 AM Borislav Petkov wrote: > > Can we merge this test into the one above? Diff ontop: Yes, I think it's fine. > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette

Your response is needed.

2020-06-09 Thread ANTHONY NUGAN
details. I anticipate your reply. Best regards, Anthony Nugan. -- This email has been checked for viruses by AVG. https://www.avg.com

[tip: x86/urgent] x86/speculation: Avoid force-disabling IBPB based on STIBP and enhanced IBRS.

2020-06-09 Thread tip-bot2 for Anthony Steinhauser
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 21998a351512eba4ed5969006f0c55882d995ada Gitweb: https://git.kernel.org/tip/21998a351512eba4ed5969006f0c55882d995ada Author:Anthony Steinhauser AuthorDate:Tue, 19 May 2020 06:40:42 -07:00

[tip: x86/urgent] x86/speculation: PR_SPEC_FORCE_DISABLE enforcement for indirect branches.

2020-06-09 Thread tip-bot2 for Anthony Steinhauser
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 4d8df8cbb9156b0a0ab3f802b80cb5db57acc0bf Gitweb: https://git.kernel.org/tip/4d8df8cbb9156b0a0ab3f802b80cb5db57acc0bf Author:Anthony Steinhauser AuthorDate:Sun, 07 Jun 2020 05:44:19 -07:00

[tip: x86/urgent] x86/speculation: Prevent rogue cross-process SSBD shutdown

2020-06-09 Thread tip-bot2 for Anthony Steinhauser
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: dbbe2ad02e9df26e372f38cc3e70dab9222c832e Gitweb: https://git.kernel.org/tip/dbbe2ad02e9df26e372f38cc3e70dab9222c832e Author:Anthony Steinhauser AuthorDate:Sun, 05 Jan 2020 12:19:43 -08:00

[PATCH 0/3] avoid unnecessary memslot rmap walks

2020-06-02 Thread Anthony Yznaga
won't need updating. I can't find any reason for this not to be the case, but I've taken a more cautious approach to fixing this by dividing things into three patches. Anthony Yznaga (3): KVM: x86: remove unnecessary rmap walk of read-only memslots KVM: x86: avoid unneces

[PATCH 1/3] KVM: x86: remove unnecessary rmap walk of read-only memslots

2020-06-02 Thread Anthony Yznaga
There's no write access to remove. An existing memslot cannot be updated to set or clear KVM_MEM_READONLY, and any mappings established in a newly created or moved read-only memslot will already be read-only. Signed-off-by: Anthony Yznaga --- arch/x86/kvm/x86.c | 6 ++ 1 file chang

[PATCH 2/3] KVM: x86: avoid unnecessary rmap walks when creating/moving slots

2020-06-02 Thread Anthony Yznaga
properties of the new slot. Signed-off-by: Anthony Yznaga --- arch/x86/kvm/x86.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 23fd888e52ee..d211c8ced6bb 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -10138,7 +10138,7

[PATCH 3/3] KVM: x86: minor code refactor and comments fixup around dirty logging

2020-06-02 Thread Anthony Yznaga
Consolidate the code and correct the comments to show that the actions taken to update existing mappings to disable or enable dirty logging are not necessary when creating, moving, or deleting a memslot. Signed-off-by: Anthony Yznaga --- arch/x86/kvm/x86.c | 104

Re: [RFC 14/43] mm: memblock: PKRAM: prevent memblock resize from clobbering preserved pages

2020-05-11 Thread Anthony Yznaga
On 5/11/20 6:57 AM, Mike Rapoport wrote: > On Wed, May 06, 2020 at 05:41:40PM -0700, Anthony Yznaga wrote: >> The size of the memblock reserved array may be increased while preserved >> pages are being reserved. When this happens, preserved pages that have >> not yet been

Re: [RFC 21/43] x86/KASLR: PKRAM: support physical kaslr

2020-05-07 Thread Anthony Yznaga
On 5/7/20 10:51 AM, Kees Cook wrote: > On Wed, May 06, 2020 at 05:41:47PM -0700, Anthony Yznaga wrote: >> Avoid regions of memory that contain preserved pages when computing >> slots used to select where to put the decompressed kernel. > This is changing the slot-walki

Re: [RFC 34/43] shmem: PKRAM: multithread preserving and restoring shmem pages

2020-05-07 Thread Anthony Yznaga
On 5/7/20 9:30 AM, Randy Dunlap wrote: > On 5/6/20 5:42 PM, Anthony Yznaga wrote: >> Improve performance by multithreading the work to preserve and restore >> shmem pages. >> >> Add 'pkram_max_threads=' kernel option to specify the maximum number >> o

[RFC 34/43] shmem: PKRAM: multithread preserving and restoring shmem pages

2020-05-06 Thread Anthony Yznaga
of a file to a pkram_obj until no more no more chunks are available. When restoring pages each thread loads pages using a copy of a pkram_stream initialized by pkram_prepare_load_obj(). Under the hood each thread ends up fetching and operating on pkram_link pages. Signed-off-by: Anth

[RFC 27/43] x86/mm/numa: add numa_isolate_memblocks()

2020-05-06 Thread Anthony Yznaga
. Signed-off-by: Anthony Yznaga --- arch/x86/include/asm/numa.h | 4 arch/x86/mm/numa.c | 32 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h index bbfde3d2662f..f9e05f4eb1c6

[RFC 29/43] memblock: PKRAM: mark memblocks that contain preserved pages

2020-05-06 Thread Anthony Yznaga
To support deferred initialization of page structs for preserved pages, separate memblocks containing preserved pages by setting a new flag when adding them to the memblock reserved list. Signed-off-by: Anthony Yznaga --- include/linux/memblock.h | 7 +++ mm/memblock.c| 8

[RFC 23/43] mm: shmem: enable saving to PKRAM

2020-05-06 Thread Anthony Yznaga
implified: it supports only regular files in the root directory without multiple hard links, and it does not save swapped out files and aborts if any are found. However, it can be elaborated to fully support tmpfs. Originally-by: Vladimir Davydov Signed-off-by: Anthony Yznaga --- include/linux/pkram

[RFC 33/43] PKRAM: atomically add and remove link pages

2020-05-06 Thread Anthony Yznaga
Add and remove pkram_link pages from a pkram_obj atomically to prepare for multithreading. Signed-off-by: Anthony Yznaga --- mm/pkram.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/mm/pkram.c b/mm/pkram.c index 5f4e4d12865f..042c14dedc25

[RFC 17/43] PKRAM: provide a way to check if a memory range has preserved pages

2020-05-06 Thread Anthony Yznaga
When a kernel is loaded for kexec the address ranges where the kexec segments will be copied to may conflict with pages already set to be preserved. Provide a way to determine if preserved pages exist in a specified range. Signed-off-by: Anthony Yznaga --- include/linux/pkram.h | 2 ++ mm

[RFC 41/43] XArray: add xas_export_node() and xas_import_node()

2020-05-06 Thread Anthony Yznaga
it. Signed-off-by: Anthony Yznaga --- Documentation/core-api/xarray.rst | 8 +++ include/linux/xarray.h| 2 + lib/test_xarray.c | 45 + lib/xarray.c | 100 ++ 4 files changed, 155 insertions

  1   2   3   4   5   6   >