Re: [RESEND PATCH] perf: ftrace: Add filter support for option -F/--funcs

2020-09-04 Thread Arnaldo Carvalho de Melo
o perf ftrace -F vfs_* > vfs_fadvise > vfs_fallocate > vfs_truncate > vfs_open > vfs_setpos > vfs_llseek > vfs_readf > vfs_writef > ... I'll process these now, the urgent ones were already sent to Linus, so I will now concentrate on the new stuff for v5.10, Thanks for working on thi

Re: [PATCH -next] perf bench: fix return value check in do_run_multi_threaded()

2020-09-04 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 09:25:02PM +0800, Yuehaibing escreveu: > On 2020/9/4 2:55, Arnaldo Carvalho de Melo wrote: > > Em Thu, Sep 03, 2020 at 03:54:51PM -0300, Arnaldo Carvalho de Melo escreveu: > >>>> Fixes: 13edc237200c ("perf bench: Add a multi-threaded

Re: [PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 04, 2020 at 10:38:35AM +0900, Namhyung Kim escreveu: > On Fri, Sep 4, 2020 at 3:41 AM Arnaldo Carvalho de Melo > wrote: > > Em Thu, Sep 03, 2020 at 10:47:39AM -0700, Ian Rogers escreveu: > > > On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote: > > >

[GIT PULL] perf tools fixes for v5.9: 2nd batch

2020-09-03 Thread Arnaldo Carvalho de Melo
ERR_PTR() in 'perf bench'. Signed-off-by: Arnaldo Carvalho de Melo Arnaldo Carvalho de Melo (1): perf parse-events: Use uintptr_t when casting numbers to pointers Jin Yao (1): perf stat: Turn off summary for interval mode

Re: [PATCH V3 4/6] perf tools: Add FIFO file names as alternative options to --control

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 08:03:08PM +0300, Alexey Budankov escreveu: > > On 02.09.2020 13:57, Adrian Hunter wrote: > > Enable the --control option to accept file names as an alternative to > > file descriptors. > > > > Example: > > > > $ mkfifo perf.control > > $ mkfifo perf.ack > > $ cat

Re: [PATCH V2 3/6] perf tools: Use AsciiDoc formatting for --control option documentation

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 07:12:43PM +0300, Alexey Budankov escreveu: > > On 01.09.2020 12:37, Adrian Hunter wrote: > > The --control option does not display well in man pages unless AsciiDoc > > formatting is used. > > > > Signed-off-by: Adrian Hunter > > --- > >

Re: [PATCH V2 2/6] perf tools: Handle read errors from ctl_fd

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 07:11:14PM +0300, Alexey Budankov escreveu: > > On 01.09.2020 12:37, Adrian Hunter wrote: > > Handle read errors from ctl_fd such as EINTR, EAGAIN and EWOULDBLOCK. > > > > Signed-off-by: Adrian Hunter > > --- > > tools/perf/util/evlist.c | 16 +++- > > 1

Re: [PATCH V2 1/6] perf tools: Consolidate --control option parsing into one function

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 07:06:51PM +0300, Alexey Budankov escreveu: > > On 01.09.2020 12:37, Adrian Hunter wrote: > > Consolidate --control option parsing into one function, in preparation for > > adding FIFO file name options. > > > > Signed-off-by: Adrian Hunter > > --- > >

Re: [PATCH] tools build feature: cleanup feature files on make clean

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 09:20:35PM +0200, Daniel Borkmann escreveu: > Hi Arnaldo, > > On 9/3/20 9:03 PM, Arnaldo Carvalho de Melo wrote: > > Em Thu, Aug 27, 2020 at 10:53:36AM +0200, Jesper Dangaard Brouer escreveu: > > > The system for "Auto-detecting system featur

Re: [PATCH] perf tools: Add bpf image check to __map__is_kmodule

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 11:30:17PM +0200, Jiri Olsa escreveu: > When validating kcore modules the do_validate_kcore_modules > function checks on every kernel module dso against modules > record. The __map__is_kmodule check is used to get only > kernel module dso objects through. > > Currently the

Re: [PATCH] tools build feature: cleanup feature files on make clean

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 27, 2020 at 10:53:36AM +0200, Jesper Dangaard Brouer escreveu: > The system for "Auto-detecting system features" located under > tools/build/ are (currently) used by perf, libbpf and bpftool. It can > contain stalled feature detection files, which are not cleaned up by > libbpf and

Re: [PATCH] perf record/stat: Explicitly call out event modifiers in the documentation

2020-09-03 Thread Arnaldo Carvalho de Melo
; Signed-off-by: Kim Phillips > Fixes: 2055fdaf8703 ("perf list: Document precise event sampling for AMD IBS") > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhy

Re: [PATCH -next] perf bench: fix return value check in do_run_multi_threaded()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 03:54:51PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Sep 03, 2020 at 03:53:01PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Sep 02, 2020 at 10:05:26PM +0800, YueHaibing escreveu: > > > In case of error, the function perf_session__new

Re: [PATCH -next] perf bench: fix return value check in do_run_multi_threaded()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 03:53:01PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Sep 02, 2020 at 10:05:26PM +0800, YueHaibing escreveu: > > In case of error, the function perf_session__new() returns ERR_PTR() > > and never returns NULL. The NULL test in the return value c

Re: [PATCH -next] perf bench: fix return value check in do_run_multi_threaded()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 10:05:26PM +0800, YueHaibing escreveu: > In case of error, the function perf_session__new() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR() > > Fixes: 13edc237200c ("perf bench: Add a multi-threaded

Re: [PATCH] perf stat: Turn off summary for interval mode by default

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 09:01:13AM +0800, Jin Yao escreveu: > There's a risk that outputting interval mode summaries by default > breaks CSV consumers. It already broke pmu-tools/toplev. > > So now we turn off the summary by default but we create a new > option '--summary' to enable the summary.

[PATCH] perf parse-events: Use uintptr_t when casting numbers to pointers

2020-09-03 Thread Arnaldo Carvalho de Melo
Hi Ian, Please check that this is ok with you, Thanks, - Arnaldo commit 0823f768b800cca2592fad3b5649766ae6bc4eba Author: Arnaldo Carvalho de Melo Date: Thu Sep 3 15:34:20 2020 -0300 perf parse-events: Use uintptr_t when casting numbers to pointers To address

Re: [PATCH] perf jevents: Fix suspicious code in fixregex()

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 03, 2020 at 10:47:39AM -0700, Ian Rogers escreveu: > On Thu, Sep 3, 2020 at 8:25 AM Namhyung Kim wrote: > > The new string should have enough space for the original string and > > the back slashes IMHO. > > Cc: John Garry > > Cc: Kajol Jain > > Cc: Ian Rogers > > Signed-off-by:

Re: [PATCH v3 1/3] perf dso: Use libbfd to read build_id and .gnu_debuglink section

2020-09-03 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 09:25:19PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Aug 21, 2020 at 06:52:36PM +0200, Remi Bernon escreveu: > > Wine generates PE binaries for most of its modules and perf is unable > > to parse these files to get build_id or .gnu_de

Re: [PATCH v3 1/3] perf dso: Use libbfd to read build_id and .gnu_debuglink section

2020-09-02 Thread Arnaldo Carvalho de Melo
olve debug file location regardless of the dso binary format. > > Signed-off-by: Remi Bernon > Cc: Alexander Shishkin > Cc: Arnaldo Carvalho de Melo > Cc: Ingo Molnar > Cc: Jiri Olsa > Cc: Mark Rutland > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Jacek C

Re: [GIT PULL] perf tools fixes for v5.9

2020-09-02 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2020 at 07:43:33PM -0700, Linus Torvalds escreveu: > On Tue, Sep 1, 2020 at 3:42 PM Arnaldo Carvalho de Melo > wrote: > > > > - The SNOOPX and REMOTE offsets in the data_src bitmask in perf records were > > were both 37, SNOOPX is 38, fix it. > &g

Re: [PATCH] perf/core: Fix hung issue on perf stat command during cpu hotplug

2020-09-02 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 27, 2020 at 12:17:32PM +0530, Kajol Jain escreveu: > Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") > added assignment of ret value as -EAGAIN in case function > call to 'smp_call_function_single' fails. > For non-zero ret value, it did > 'ret = !ret ?

Re: [PATCH] perf c2c report: count remote loads correctly

2020-09-02 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 01:09:42PM +0100, Al Grant escreveu: > On 01/09/2020 22:26, Joe Mario wrote: > > On 9/1/20 4:46 PM, Jiri Olsa wrote: > > > On Tue, Sep 01, 2020 at 10:17:19PM +0200, Jiri Olsa wrote: > > > > On Thu, Aug 20, 2020 at 02:48:58PM +0100, Al Grant wrote: > > > > I'm getting

Re: [PATCH 1/2] perf cs-etm: Fix corrupt data after perf inject from

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 02, 2020 at 08:39:32AM +0800, Leo Yan escreveu: > On Tue, Sep 01, 2020 at 11:54:32AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu: > > > On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote: >

[GIT PULL] perf tools fixes for v5.9

2020-09-01 Thread Arnaldo Carvalho de Melo
rmats on 32-bit. - Correct the help info of "perf record --no-bpf-event" option. - Add entries for CoreSight and Arm SPE tooling to MAINTAINERS. Signed-off-by: Arnaldo Carvalho de Melo Al Grant (3): perf cs-etm: Fix corrupt data after perf inject from perf intel-pt: Fix corrupt data afte

libtracevent: Build warning on 32-bit arches

2020-09-01 Thread Arnaldo Carvalho de Melo
Hi Tzvetomir, I noticed this: 27 debian:experimental-x-mips: Ok mips-linux-gnu-gcc (Debian 8.3.0-19) 8.3.0 29 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 9.2.1-8) 9.2.1 20190909 64 ubuntu:16.04-x-powerpc: Ok powerpc-linux-gnu-gcc (Ubuntu

Re: linux-next: build warnings from perf build in Linus' tree

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 27, 2020 at 09:10:09AM +1000, Stephen Rothwell escreveu: > Hi all, > > On Thu, 27 Aug 2020 08:38:39 +1000 Stephen Rothwell > wrote: > > > > /home/sfr/next/next/tools/perf/util/namespaces.c: In function 'nsinfo__new': > > /home/sfr/next/next/tools/perf/util/namespaces.c:139:12: note:

Re: [PATCH] perf c2c report: count remote loads correctly

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 20, 2020 at 02:48:58PM +0100, Al Grant escreveu: > "perf c2c report" can show load counts for cache lines, which don't match > the actual number of load samples, e.g. as displayed by "perf script". This > is specific to "Remote Any cache hit" loads. Firstly, these loads are > counted

Re: [PATCH] perf inject: correct event attribute sizes

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 10:42:04AM +0100, Al Grant escreveu: > When perf inject reads a perf.data file from an older version of perf, > it writes event attributes into the output with the original size field, > but lays them out as if they had the size currently used. Readers see > a corrupt file.

Re: [PATCH 1/2] perf tools: Disable ordered_events for report raw dump

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 27, 2020 at 03:48:29PM +0200, Jiri Olsa escreveu: > Disable ordered_events for report raw dump, because > for raw dump we want to see events as they are stored > in the perf.data file, not sorted by time. Applied to perf/urgent, Thanks, - Arnaldo > Signed-off-by: Jiri Olsa > ---

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2020 at 05:12:04PM +0200, pet...@infradead.org escreveu: > On Tue, Sep 01, 2020 at 12:06:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > Also you mixed up tools/ with include/ things, the perf part of the > > kernel is maintained by Ingo, PeterZ. &g

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 01, 2020 at 12:02:25PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: > > On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > >

Re: [PATCH] perf: correct SNOOPX field offset

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 03:33:35PM +0100, Al Grant escreveu: > On 26/08/2020 15:26, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > > > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > > > > perf_

Re: [PATCH 1/2] perf cs-etm: Fix corrupt data after perf inject from

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 31, 2020 at 08:04:32AM +0800, Leo Yan escreveu: > Hi Mathieu, > > On Thu, Aug 27, 2020 at 02:53:54PM -0600, Mathieu Poirier wrote: > > Hi Leo and Al, > > > > On Wed, Aug 19, 2020 at 04:47:50PM +0800, Leo Yan wrote: > > > From: Al Grant > > > > > > Commit 42bbabed09ce ("perf tools:

Re: [PATCH 2/2] perf intel-pt: Fix corrupt data after perf inject from

2020-09-01 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 31, 2020 at 02:38:32PM -0600, Mathieu Poirier escreveu: > On Wed, Aug 19, 2020 at 04:47:51PM +0800, Leo Yan wrote: > > From: Al Grant > > > > Commit 42bbabed09ce ("perf tools: Add hw_idx in struct branch_stack") > > changed the format of branch stacks in perf samples. When samples

Re: [PATCH] perf: correct SNOOPX field offset

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 10:40:43AM -0700, Andi Kleen escreveu: > On Mon, Aug 24, 2020 at 10:28:34AM +0100, Al Grant wrote: > > perf_event.h has macros that define the field offsets in the > > data_src bitmask in perf records. The SNOOPX and REMOTE offsets > > were both 37. These are distinct

Re: [RFC] perf/core: Fixes hung issue on perf stat command during cpu hotplug

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 03:02:36PM +0530, Kajol Jain escreveu: > Commit 2ed6edd33a21 ("perf: Add cond_resched() to task_function_call()") > added assignment of ret value as -EAGAIN in case function > call to 'smp_call_function_single' fails. > For non-zero ret value, it did > 'ret = !ret ?

Re: [PATCH 2/2] perf parse-events: Avoid an uninitialized read.

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 26, 2020 at 01:34:18PM +0200, Jiri Olsa escreveu: > On Tue, Aug 25, 2020 at 09:29:10PM -0700, Ian Rogers wrote: > > With a fake_pmu the pmu_info isn't populated by perf_pmu__check_alias. > > In this case, don't try to copy the uninitialized values to the evsel. > > > > Signed-off-by:

Re: [PATCH] perf stat: Fix s390x compile error on F32 utils/stat-display.c

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 09:14:42AM +0200, Jiri Olsa escreveu: > On Tue, Aug 25, 2020 at 08:33:04AM +0200, Thomas Richter wrote: > > SNIP > > > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > > index 57d0706e1330..cbe836649f84 100644 > > ---

Re: [PATCH] perf test: Perf test 67 dumps core on s390

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 02:04:30PM -0700, Ian Rogers escreveu: > On Tue, Aug 25, 2020 at 12:12 AM Thomas Richter wrote: > > Linux 5.9 introduced perf test case "Parse and process metrics" and > > on s390 this test case always dumps core: > Acked-by: Ian Rogers > > This also shows up with

Re: [PATCH] perf test: Perf test 67 dumps core on s390

2020-08-26 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 02:04:30PM -0700, Ian Rogers escreveu: > On Tue, Aug 25, 2020 at 12:12 AM Thomas Richter wrote: > > > > Linux 5.9 introduced perf test case "Parse and process metrics" and > > on s390 this test case always dumps core: > > Signed-off-by: Thomas Richter > > Reviewed-by:

Re: [PATCH v3] perf parse-events: Set exclude_guest=1 for user-space counting

2020-08-25 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 25, 2020 at 03:54:37PM +0800, Jin, Yao escreveu: > Hi Arnaldo, > > On 8/19/2020 11:05 AM, Like Xu wrote: > > Hi Arnaldo, > > > > On 2020/8/17 10:32, Jin, Yao wrote: > > > Hi Arnaldo, > > > > > > On 8/14/2020 8:47 PM, Arnaldo Carv

Re: [PATCH] perf record: Correct the help info of option "--no-bpf-event"

2020-08-21 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 19, 2020 at 03:38:30PM +, Song Liu escreveu: > > > > On Aug 18, 2020, at 8:19 PM, Wei Li wrote: > > > > The help info of option "--no-bpf-event" is wrongly described as > > "record bpf events", correct it. > > > > Fixes: 71184c6ab7e6 ("perf record: Replace option --bpf-event

Re: [PATCH] perf tools: Use %zd for size_t printf formats on 32b

2020-08-21 Thread Arnaldo Carvalho de Melo
Cc: Peter Zijlstra > Cc: Ingo Molnar > cc: Arnaldo Carvalho de Melo > --- > tools/perf/util/session.c | 2 +- > tools/perf/util/zstd.c| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > ind

Re: [PATCH v2] MAINTAINERS: Add entries for CoreSight and Arm SPE

2020-08-21 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 21, 2020 at 10:05:31AM +0100, Will Deacon escreveu: > On Thu, Aug 20, 2020 at 11:55:10AM -0600, Mathieu Poirier wrote: > > Add entries for perf tools elements related to the support of Arm CoreSight > > and Arm SPE. Also lump in Arm and Arm64 architecture files to provide > >

Re: [PATCH] perf: arm-spe: Fix check error when synthesizing events

2020-08-20 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 24, 2020 at 04:32:18PM +0800, Leo Yan escreveu: > Hi Wei, > > On Fri, Jul 24, 2020 at 03:26:28PM +0800, Wei Li wrote: > > In arm_spe_read_record(), when we are processing an events packet, > > 'decoder->packet.index' is the length of payload, which has been > > transformed in

Re: [PATCH] perf top: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-18 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 18, 2020 at 08:30:37PM +0800, Tiezhu Yang escreveu: > When I execute perf top without HAVE_LIBBPF_SUPPORT, there exists the > following segmentation fault, skip the side-band event setup to fix it, > this is similar with commit 1101c872c8c7 ("perf record: Skip side-band > event setup

Re: [PATCH v2] perf sched timehist: Fix use of CPU list with summary option

2020-08-18 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 18, 2020 at 10:29:29AM +0900, Namhyung Kim escreveu: > Hi David, > > On Tue, Aug 18, 2020 at 2:09 AM David Ahern wrote: > > > > Do not update thread stats or show idle summary unless CPU is in > > the list of interest. > > > > Fixes: c30d630d1bcf ("perf sched timehist: Add support

[GIT PULL] perf tool changes for v5.9: 2nd batch

2020-08-14 Thread Arnaldo Carvalho de Melo
er of processes in "2x3-convergence" test perf bench numa: Fix benchmark names perf bench numa: Fix cpumask memory leak in node_has_cpus() perf bench numa: Use numa_node_to_cpus() to bind tasks to nodes Arnaldo Carvalho de Melo (6): perf trace beauty: Add scrip

Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 14, 2020 at 09:12:50AM -0300, Arnaldo Carvalho de Melo escreveu: > > It indicates that the argument is in units of 'pages', while you don't > > state that in: > > > > $ perf ftrace -h -m > > > > -m, --buffer-size > >

Re: [PATCH v3] perf parse-events: Set exclude_guest=1 for user-space counting

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 14, 2020 at 09:21:20AM +0800, Jin Yao escreveu: > Currently if we run 'perf record -e cycles:u', exclude_guest=0. > > But it doesn't make sense in most cases that we request for > user-space counting but we also get the guest report. > > Of course, we also need to consider perf kvm

Re: [PATCH] perf stat: update POWER9 metrics to utilize other metrics

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 14, 2020 at 11:20:42AM +0530, kajoljain escreveu: > > > On 8/14/20 9:13 AM, Ian Rogers wrote: > > On Thu, Aug 13, 2020 at 3:21 PM Paul A. Clarke wrote: > >> > >> These changes take advantage of the new capability added in > >> merge commit 00e4db51259a5f936fec1424b884f029479d3981 >

Re: [PATCH] perf bench numa: Remove dead code in parse_nodes_opt()

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 14, 2020 at 06:44:54PM +0800, Peng Fan escreveu: > In the function parse_nodes_opt(), the statement "return 0;" is dead > code, remove it. Thanks, applied. - Arnaldo > Signed-off-by: Peng Fan > --- > tools/perf/bench/numa.c | 2 -- > 1 file changed, 2 deletions(-) > > diff

Re: [PATCH v8 00/18] [PATCH v7 00/18] perf: ftrace enhancement

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:23AM +0800, Changbin Du escreveu: > The perf has basic kernel ftrace support but lack support of most tracing > options. This serias is target to enhance the perf ftrace functionality so > that we can make full use of kernel ftrace with perf. > > In general, this

Re: [PATCH v8 13/18] perf ftrace: add support for trace option tracing_thresh

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:36AM +0800, Changbin Du escreveu: > This adds an option '--graph-opts thresh' to setup trace duration > threshold for funcgraph tracer. Applied, please consider making --duration an alias for this, as this is also available in 'perf trace': [root@quaco ~]# perf

Re: [PATCH v8 11/18] perf ftrace: add support for tracing option 'irq-info'

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:34AM +0800, Changbin Du escreveu: > This adds support to display irq context info for function tracer. To do > this, just specify a '--func-opts irq-info' option. Applied, ditto about adding an example to perf-ftrace.txt > Signed-off-by: Changbin Du > --- >

Re: [PATCH v8 10/18] perf ftrace: add support for trace option funcgraph-irqs

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:33AM +0800, Changbin Du escreveu: > This adds an option '--graph-opts noirqs' to filter out functions executed > in irq context. ditto, no example provided, please consider adding an example + explanation to perf-ftrace.txt. > Signed-off-by: Changbin Du > > --- >

Re: [PATCH v8 09/18] perf ftrace: add support for trace option sleep-time

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:32AM +0800, Changbin Du escreveu: > This adds an option '--graph-opts nosleep-time' which allow us > only to measure on-CPU time. This option is function_graph tracer > only. Here an example showing its usage would be great. Even better, on perf-ftrace.txt, so that

Re: [PATCH v8 08/18] perf ftrace: add support for tracing option 'func_stack_trace'

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:31AM +0800, Changbin Du escreveu: > This adds support to display call trace for function tracer. To do this, > just specify a '--func-opts call-graph' option. Applied, thanks for providing the usage example and the output of the tool, please consider making this more

Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 14, 2020 at 08:53:18AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Aug 08, 2020 at 10:31:27AM +0800, Changbin Du escreveu: > > This adds an option '-m/--buffer-size' to allow us set the size of per-cpu > > tracing buffer. > > > > Signed-o

Re: [PATCH v8 06/18] perf ftrace: add option '--inherit' to trace children processes

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:29AM +0800, Changbin Du escreveu: > This adds an option '--inherit' to allow us trace children > processes spawned by our target. One thing I'm missing from your commit log messages is the exact sequence of commands and the outputs for the options you're introducing.

Re: [PATCH v8 05/18] perf ftrace: show trace column header

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 14, 2020 at 08:56:55AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Aug 08, 2020 at 10:31:28AM +0800, Changbin Du escreveu: > > This makes perf-ftrace display column header before printing trace. > > > > $ sudo perf ftrace > > # tracer: funct

Re: [PATCH v8 05/18] perf ftrace: show trace column header

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:28AM +0800, Changbin Du escreveu: > This makes perf-ftrace display column header before printing trace. > > $ sudo perf ftrace > # tracer: function > # > # entries-in-buffer/entries-written: 0/0 #P:8 > # > #TASK-PID CPU# TIMESTAMP

Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:27AM +0800, Changbin Du escreveu: > This adds an option '-m/--buffer-size' to allow us set the size of per-cpu > tracing buffer. > > Signed-off-by: Changbin Du So this is a little bit confusing, i.e. if I don't specify a suffix (B, K, M, G) I get: # perf ftrace

Re: [PATCH v8 02/18] perf ftrace: add option '-F/--funcs' to list available functions

2020-08-14 Thread Arnaldo Carvalho de Melo
Em Sat, Aug 08, 2020 at 10:31:25AM +0800, Changbin Du escreveu: > This adds an option '-F/--funcs' to list all available functions to trace, > which is read from tracing file 'available_filter_functions'. > > $ sudo ./perf ftrace -F | head > trace_initcall_finish_cb > initcall_blacklisted >

Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp

2020-08-13 Thread Arnaldo Carvalho de Melo
wrote: > > > On Wed, Aug 12, 2020 at 03:53:34PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Wed, Aug 12, 2020 at 10:06:53AM -0600, Mathieu Poirier escreveu: > > > > > The ARM SPE perf tools code is orphan and I don't have the cycles to > > >

Re: [PATCH v3 1/2] perf bench numa: use numa_node_to_cpus() to bind tasks to nodes

2020-08-13 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 13, 2020 at 05:37:38PM +0530, Srikar Dronamraju escreveu: > > Looks good to me. > > Reviewed-by: Srikar Dronamraju Thanks, applied. - Arnaldo

Re: [PATCH v3 1/2] perf bench numa: fix cpumask memory leak in node_has_cpus()

2020-08-13 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 13, 2020 at 05:36:49PM +0530, Srikar Dronamraju escreveu: > Looks good to me. > > Reviewed-by: Srikar Dronamraju Thanks, applied. - Arnaldo

Re: [PATCH] tools build feature: Quote CC and CXX for their arguments

2020-08-13 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 12, 2020 at 07:31:32PM -0700, Tom Hebb escreveu: > On Wed, Aug 12, 2020 at 3:15 PM Daniel Díaz wrote: > > Makefile.config:414: *** No gnu/libc-version.h found, please install > > glibc-dev[el]. Stop. > > Makefile.perf:230: recipe for target 'sub-make' failed > > make[1]: ***

Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 12, 2020 at 10:06:53AM -0600, Mathieu Poirier escreveu: > Hi Arnaldo, > > On Fri, 7 Aug 2020 at 01:16, Leo Yan wrote: > > > > This patch set is to enable Arm arch timer counter and Arm SPE is the > > first customer to use arch timer counter for its timestamp. > > > > Patches 01 ~ 03

Re: [PATCH] perf parse-events: Set exclude_guest for user-space counting

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 12, 2020 at 09:15:04AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 12, 2020 at 02:59:53PM +0800, Jin Yao escreveu: > > Currently if we run 'perf record -e cycles:u', exclude_guest is 0. > > > > But it doesn't make sense that we request for user-spac

Re: [PATCH] MAINTAINERS: Add missing tools/lib/perf/ path to perf maintainers

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 01:32:25PM -0600, Rob Herring escreveu: > Commit 3ce311afb558 ("libperf: Move to tools/lib/perf") moved libperf > out of tools/perf/, but failed to update MAINTAINERS. Thanks, applied. - Arnaldo > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc:

Re: [PATCH] libperf: Fix man page typos

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 01:32:41PM -0600, Rob Herring escreveu: > Fix various typos and inconsistent capitalization of CPU in the libperf > man pages. Thanks, applied, - Arnaldo > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutlan

Re: [PATCH] perf bench mem: Always memset source before memcpy

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 10, 2020 at 03:34:04PM +0200, Vincent Whitchurch escreveu: > For memcpy, the source pages are memset to zero only when --cycles is > used. This leads to wildly different results with or without --cycles, > since all sources pages are likely to be mapped to the same zero page > without

Re: [PATCH V6 06/16] perf script: Use ULL for enum perf_output_field

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 10, 2020 at 02:24:26PM -0700, Kan Liang escreveu: > The Bitwise-Shift operator (1U << ) is used in the enum > perf_output_field, which has already reached its capacity (32 items). > If more items are added, a compile error will be triggered. > > Change the U to ULL, which extend the

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 11, 2020 at 03:42:45PM +0900, Namhyung Kim escreveu: > Hi David, > > On Sat, Aug 8, 2020 at 1:48 AM David Ahern wrote: > > > > Commit fbd705a0c618 ("sched: Introduce the 'trace_sched_waking' tracepoint") > > added sched_waking tracepoint which should be preferred over sched_wakeup >

Re: [PATCH] perf parse-events: Set exclude_guest for user-space counting

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 12, 2020 at 02:59:53PM +0800, Jin Yao escreveu: > Currently if we run 'perf record -e cycles:u', exclude_guest is 0. > > But it doesn't make sense that we request for user-space counting > but we also get the guest report. > > To keep perf semantics consistent and clear, this patch

Re: [PATCH] perf bench: fix a couple of spelling mistakes in options text

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 12, 2020 at 07:46:47AM +0100, Colin King escreveu: > From: Colin Ian King > > There are a couple of spelling mistakes in the text. Fix these. Thanks, applied. - Arnaldo > Signed-off-by: Colin Ian King > --- > tools/perf/bench/find-bit-bench.c | 4 ++-- > 1 file changed, 2

Re: [PATCH v2 3/3] perf bench numa: fix benchmark names

2020-08-12 Thread Arnaldo Carvalho de Melo
veral benchmarks names do not correspond to their actual > running configuration. Fix that and also some whitespace > and comment inconsistencies. Looks, ok, applied. - Arnaldo > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Mark Rutland > Cc: Alexander

Re: [PATCH v2 2/3] perf bench numa: fix number of processes in "2x3-convergence" test

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 11, 2020 at 04:27:35PM +0900, Namhyung Kim escreveu: > On Mon, Aug 10, 2020 at 3:22 PM Alexander Gordeev > wrote: > > > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > Cc: Arnaldo Carvalho de Melo > > Cc: Mark Rutland > > Cc: Alexander Shi

Re: [PATCH] Fix s390x compile error on F32 utils/stat-display.c

2020-08-12 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 22, 2020 at 11:20:53AM +0200, Thomas Richter escreveu: > Fix a compile error on F32 and gcc version 10.1 on s390 in file > utils/stat-display.c. The error does not show up with make DEBUG=y. > In fact the issue shows up when using both compiler options > -O6 and -D_FORTIFY_SOURCE=2

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-10 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 01:50:47PM -0600, David Ahern escreveu: > On 8/7/20 1:43 PM, Arnaldo Carvalho de Melo wrote: > >> @@ -2958,9 +2967,10 @@ static int timehist_check_attr(struct perf_sched > >> *sched, > >> > >> static int perf_s

[GIT PULL] perf tools changes for v5.9

2020-08-10 Thread Arnaldo Carvalho de Melo
duce --control fd:ctl-fd[,ack-fd] options perf evsel: Extend message to mention CAP_SYS_PTRACE and perf security doc link Anju T Sudhakar (1): perf tools powerpc: Add support for extended register capability Arnaldo Carvalho de Melo (17): perf parse: Provide a way to pass a fake

Re: [PATCH 1/2] perf sched: Prefer sched_waking event when it exists

2020-08-07 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 10:48:44AM -0600, David Ahern escreveu: > Commit fbd705a0c618 ("sched: Introduce the 'trace_sched_waking' tracepoint") > added sched_waking tracepoint which should be preferred over sched_wakeup > when analyzing scheduling delays. > > Update 'perf sched record' to collect

Re: [PATCH] perf record: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-07 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 09:16:29AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Aug 07, 2020 at 09:09:56AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Aug 07, 2020 at 09:08:24AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Aug 06, 2020 at 09:43:57P

Re: [PATCH] perf record: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-07 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 09:09:56AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Aug 07, 2020 at 09:08:24AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Aug 06, 2020 at 09:43:57PM +0200, Jiri Olsa escreveu: > > > On Wed, Aug 05, 2020 at 10:29:37AM +0800, Jin Yao

Re: [PATCH] perf record: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-07 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 07, 2020 at 09:08:24AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Aug 06, 2020 at 09:43:57PM +0200, Jiri Olsa escreveu: > > On Wed, Aug 05, 2020 at 10:29:37AM +0800, Jin Yao wrote: > > > We received an error report that perf-record caused 'Segmentation fault

Re: [PATCH] perf record: Skip side-band event setup if HAVE_LIBBPF_SUPPORT is not set

2020-08-07 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 06, 2020 at 09:43:57PM +0200, Jiri Olsa escreveu: > On Wed, Aug 05, 2020 at 10:29:37AM +0800, Jin Yao wrote: > > We received an error report that perf-record caused 'Segmentation fault' > > on a newly system (e.g. on the new installed ubuntu). > > > > (gdb) backtrace > > #0

Re: [PATCH v2 4/7] perf tools: Move clockid_res_ns under clock struct

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 11:34:41AM +0200, Jiri Olsa escreveu: > Moving clockid_res_ns under clock struct, so we have > clock related stuff in one place. Thanks, applied. - Arnaldo > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-record.c | 6 +++--- > tools/perf/util/env.h | 2 +-

Re: [PATCH v1] perf/core: take over CAP_SYS_PTRACE creds to CAP_PERFMON cap

2020-08-06 Thread Arnaldo Carvalho de Melo
monitoring more secure by reducing > attack surface. Acked-by: Arnaldo Carvalho de Melo Peter, can you pick up this one? You said it was ok last time we discussed this. - Arnaldo > [1] > https://lore.kernel.org/lkml/7776fa40-6c65-2aa6-1322-eb3a01201...@linux.intel.com/ > >

Re: [PATCH v2 6/7] perf script: Change enum perf_output_field values to be 64 bits

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 11:34:43AM +0200, Jiri Olsa escreveu: > So it's possible to add new values. I did not find any place > where the enum values are passed through some number type, > so it's safe to make this change. Thanks, applied. - Arnaldo > Signed-off-by: Jiri Olsa > --- >

Re: [PATCH v2 1/7] perf tools: Move parse_clockid into clockid object

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 11:34:38AM +0200, Jiri Olsa escreveu: > Move parse_clockid and all needed clcckid related stuff > into clockid object. We are going to add clockid_name > function in following change, so it's better it's placed > in separated object and not in builtin-record.c. > > No

Re: [PATCH V2 12/12] perf intel-pt: Add support for decoding PSB+ only

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 20, 2020 at 03:25:02PM -0700, Andi Kleen escreveu: > But looks overall the patches look good to me now. > (for the whole series) > Reviewed-by: Andi Kleen Thanks, applied. - Arnaldo

Re: [PATCH v2 7/7] perf script: Add tod field to display time of day

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 11:34:44AM +0200, Jiri Olsa escreveu: > Adding tod field to display time of day column with > time of date (wallclock) time. > > # perf record -k CLOCK_MONOTONIC kill > kill: not enough arguments > [ perf record: Woken up 1 times to write data ] > [ perf record:

Re: [PATCH v1] perf: extend message to mention CAP_SYS_PTRACE and perf security doc link

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 10:31:20AM +0300, Alexey Budankov escreveu: > > Adjust limited access message to mention CAP_SYS_PTRACE capability > for processes of unprivileged users. Add link to perf security > document in the end of the section about capabilities. > The change has been inspired by

Re: [PATCH v2 5/7] perf tools: Add support to store time of day in CTF data conversion

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 11:34:42AM +0200, Jiri Olsa escreveu: > Adding support to convert and store time of day in CTF > data conversion for 'perf data convert' subcommand. > > The perf.data used for conversion needs to have clock data > information - must be recorded with -k/--clockid option). >

Re: [PATCH v2 3/7] perf tools: Store clock references for -k/--clockid option

2020-08-06 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 05, 2020 at 11:34:40AM +0200, Jiri Olsa escreveu: > Adding new CLOCK_DATA feature that stores reference times > when -k/--clockid option is specified. > > It contains clock id and its reference time together with > wall clock time taken at the 'same time', both values are > in

Re: [PATCH v7 01/18] perf ftrace: select function/function_graph tracer automatically

2020-08-05 Thread Arnaldo Carvalho de Melo
On August 5, 2020 9:14:48 PM GMT-03:00, Changbin Du wrote: >On Tue, Aug 04, 2020 at 09:51:15AM -0300, Arnaldo Carvalho de Melo >wrote: >> Em Sat, Jul 18, 2020 at 02:48:09PM +0800, Changbin Du escreveu: >> > The '-g/-G' options have already implied function_graph tracer

Re: [PATCH V2 00/12] perf intel-pt: Add support for decoding FUP/TIP only

2020-08-04 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 04, 2020 at 04:34:36PM +0300, Adrian Hunter escreveu: > On 10/07/20 6:10 pm, Adrian Hunter wrote: > > Hi > > > > Here are some fixes and small improvements for Intel PT. > > Andi added his "Reviewed-by" with 2 comments to tweak the > documentation. > > The patches still apply, so do

Re: [PATCH v7 01/18] perf ftrace: select function/function_graph tracer automatically

2020-08-04 Thread Arnaldo Carvalho de Melo
Em Sat, Jul 18, 2020 at 02:48:09PM +0800, Changbin Du escreveu: > The '-g/-G' options have already implied function_graph tracer should be > used instead of function tracer. So the extra option '--tracer' can be > killed. > > This patch changes the behavior as below: > - By default, function

<    2   3   4   5   6   7   8   9   10   11   >