[PATCH V6 2/5] rpmsg: Guard against null endpoint ops in destroy

2020-05-20 Thread Arun Kumar Neelakantam
From: Chris Lew In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar

[PATCH V6 3/5] rpmsg: glink: Add support for rpmsg glink chrdev

2020-05-20 Thread Arun Kumar Neelakantam
From: Chris Lew RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 38

[PATCH V6 5/5] rpmsg: glink: unregister rpmsg device during endpoint destroy

2020-05-20 Thread Arun Kumar Neelakantam
Rpmsg device unregister is not happening if channel close is triggered from local side and causing re-registration of device failures. Unregister rpmsg device for local close in endpoint destroy path. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 9 + 1

[PATCH V6 1/5] rpmsg: glink: Use complete_all for open states

2020-05-20 Thread Arun Kumar Neelakantam
From: Chris Lew The open_req and open_ack completion variables are the state variables to represent a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg

[PATCH V5 0/5] Add chrdev and name query support for GLINK

2020-05-20 Thread Arun Kumar Neelakantam
- Change chrdev allocation to use glink channel allocation - Change glink attr struct to const Arun Kumar Neelakantam (1): rpmsg: glink: unregister rpmsg device during endpoint destroy Chris Lew (4): rpmsg: glink: Use complete_all for open states rpmsg: Guard against null endpoint ops in destroy

[PATCH V6 4/5] rpmsg: glink: Expose rpmsg name attr for glink

2020-05-20 Thread Arun Kumar Neelakantam
From: Chris Lew Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 26 ++ 1 file changed, 26

Re: [PATCH V5 5/5] rpmsg: glink: unregister rpmsg device during endpoint destroy

2020-05-20 Thread Arun Kumar Neelakantam
On 5/14/2020 3:43 AM, Mathieu Poirier wrote: On Wed, May 13, 2020 at 10:40:06AM +0530, Arun Kumar Neelakantam wrote: Rpmsg device unregister is not happening if channel close is triggered from local side and causing re-registration of device failures. Unregister rpmsg device for local close

Re: [PATCH V5 1/5] rpmsg: glink: Use complete_all for open states

2020-05-20 Thread Arun Kumar Neelakantam
On 5/14/2020 2:29 AM, Mathieu Poirier wrote: Hi Arun, On Wed, May 13, 2020 at 10:40:02AM +0530, Arun Kumar Neelakantam wrote: From: Chris Lew The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no s

[PATCH V4 2/4] rpmsg: glink: Add support to handle signals command

2020-05-12 Thread Arun Kumar Neelakantam
Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers

[RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices

2020-05-12 Thread Arun Kumar Neelakantam
patches Arun Kumar Neelakantam (4): rpmsg: core: Add signal API support rpmsg: glink: Add support to handle signals command rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support rpmsg: char: Add signal callback and POLLPRI support drivers/rpmsg/qcom_glink_native.c | 126

[PATCH V4 4/4] rpmsg: char: Add signal callback and POLLPRI support

2020-05-12 Thread Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/rpmsg

[PATCH V4 1/4] rpmsg: core: Add signal API support

2020-05-12 Thread Arun Kumar Neelakantam
Some transports like Glink support the state notifications between clients using signals similar to serial protocol signals. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 41 + drivers/rpmsg

[PATCH V4 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2020-05-12 Thread Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 53 +++--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git

[PATCH V5 0/5] Add chrdev and name query support for GLINK

2020-05-12 Thread Arun Kumar Neelakantam
- Change glink attr struct to const Arun Kumar Neelakantam (1): rpmsg: glink: unregister rpmsg device during endpoint destroy Chris Lew (4): rpmsg: glink: Use complete_all for open states rpmsg: Guard against null endpoint ops in destroy rpmsg: glink: Add support for rpmsg glink chrdev

[PATCH V5 2/5] rpmsg: Guard against null endpoint ops in destroy

2020-05-12 Thread Arun Kumar Neelakantam
From: Chris Lew In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar

[PATCH V5 3/5] rpmsg: glink: Add support for rpmsg glink chrdev

2020-05-12 Thread Arun Kumar Neelakantam
From: Chris Lew RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 40

[PATCH V5 1/5] rpmsg: glink: Use complete_all for open states

2020-05-12 Thread Arun Kumar Neelakantam
From: Chris Lew The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg

[PATCH V5 4/5] rpmsg: glink: Expose rpmsg name attr for glink

2020-05-12 Thread Arun Kumar Neelakantam
From: Chris Lew Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 26 ++ 1 file changed, 26

[PATCH V5 5/5] rpmsg: glink: unregister rpmsg device during endpoint destroy

2020-05-12 Thread Arun Kumar Neelakantam
Rpmsg device unregister is not happening if channel close is triggered from local side and causing re-registration of device failures. Unregister rpmsg device for local close in endpoint destroy path. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 9 + 1

Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver

2019-05-21 Thread Arun Kumar Neelakantam
Hi Bjorn, On 5/1/2019 10:07 AM, Bjorn Andersson wrote: The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver is used to communicate with the AOSS for certain side-channel requests, that are not available through the RPMh interface. The communication is a very simple synchronou

Re: [PATCH v2 2/7] soc: qcom: Add AOSS QMP communication driver

2019-01-10 Thread Arun Kumar Neelakantam
doorbell in the AOSS is rung. As the AOSS has processed the message length is cleared and an interrupt is fired by the AOSS as acknowledgment. Signed-off-by: Bjorn Andersson --- Reviewed-by: Arun Kumar Neelakantam Changes since v1: - Skip check in send for empty TX buffer - Don't follow WA

Re: [PATCH 2/3] soc: qcom: Add AOSS QMP communication driver

2019-01-03 Thread Arun Kumar Neelakantam
On 12/27/2018 1:58 AM, Bjorn Andersson wrote: On Tue 20 Nov 04:22 PST 2018, Arun Kumar Neelakantam wrote: Thanks for the review Arun. On 11/12/2018 1:35 PM, Bjorn Andersson wrote: [..] +int qmp_send(struct qmp *qmp, const void *data, size_t len) +{ + int ret; + + if (WARN_ON

[PATCH V4 4/4] rpmsg: char: Add signal callback and POLLPRI support

2018-10-07 Thread Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/rpmsg

[PATCH V4 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2018-10-07 Thread Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 53 +++--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git

[PATCH V4 2/4] rpmsg: glink: Add support to handle signals command

2018-10-07 Thread Arun Kumar Neelakantam
Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers

[PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices

2018-10-07 Thread Arun Kumar Neelakantam
header Arun Kumar Neelakantam (4): rpmsg: core: Add signal API support rpmsg: glink: Add support to handle signals command rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support rpmsg: char: Add signal callback and POLLPRI support drivers/rpmsg/qcom_glink_native.c | 126

[PATCH V4 1/4] rpmsg: core: Add signal API support

2018-10-07 Thread Arun Kumar Neelakantam
Some transports like Glink support the state notifications between clients using signals similar to serial protocol signals. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 41 + drivers/rpmsg

[PATCH V3 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2018-10-05 Thread Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 53 +++--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git

[PATCH V3 4/4] rpmsg: char: Add signal callback and POLLPRI support

2018-10-05 Thread Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/rpmsg

[PATCH V3 2/4] rpmsg: glink: Add support to handle signals command

2018-10-05 Thread Arun Kumar Neelakantam
Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers

[PATCH V3 1/4] rpmsg: core: Add signal API support

2018-10-05 Thread Arun Kumar Neelakantam
Some transports like Glink support the state notifications between clients using signals similar to serial protocol signals. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 41 + drivers/rpmsg

[PATCH V3 0/4] Add TIOCM Signals support for RPMSG char devices

2018-10-05 Thread Arun Kumar Neelakantam
, glink - Add set, clear mask for TIOCMSET - Merge the char signal callback and POLLPRI patches Changes since v2: - Modify the rpmsg_get_signals function prototype Arun Kumar Neelakantam (4): rpmsg: core: Add signal API support rpmsg: glink: Add support to handle signals command rpmsg: char: Add

[PATCH V2 0/4] Add TIOCM Signals support for RPMSG char devices

2018-10-04 Thread Arun Kumar Neelakantam
, glink - Add set, clear mask for TIOCMSET - Merge the char signal callback and POLLPRI patches Arun Kumar Neelakantam (4): rpmsg: core: Add signal API support rpmsg: glink: Add support to handle signals command rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support rpmsg: char: Add signal callback

[PATCH V2 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support

2018-10-04 Thread Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 54 +++--- 1 file changed, 51 insertions(+), 3 deletions(-) diff --git

[PATCH V2 2/4] rpmsg: glink: Add support to handle signals command

2018-10-04 Thread Arun Kumar Neelakantam
Remote peripherals send signal notifications over glink with commandID 15. Add support to send and receive the signal command and convert the signals from NATIVE to TIOCM while receiving and vice versa while sending. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers

[PATCH V2 4/4] rpmsg: char: Add signal callback and POLLPRI support

2018-10-04 Thread Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg and send POLLPRI mask to indicate the signal change in POLL system call. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/rpmsg

[PATCH V2 1/4] rpmsg: core: Add signal API support

2018-10-04 Thread Arun Kumar Neelakantam
Some transports like Glink support the state notifications between clients using signals similar to serial protocol signals. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_core.c | 42 ++ drivers/rpmsg

[PATCH] rpmsg: glink: smem: Support rx peak for size less than 4 bytes

2018-10-03 Thread Arun Kumar Neelakantam
The current rx peak function fails to read the data if size is less than 4bytes. Use memcpy_fromio to support data reads of size less than 4 bytes. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_smem.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff

[PATCH 4/5] rpmsg: wakeup poll to notify signal update

2018-10-03 Thread Arun Kumar Neelakantam
Add support to wait on poll to get signal notifications. Send POLLPRI mask to indicate the signal change. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg

[PATCH 3/5] rpmsg: Add TIOCMGET/TIOCMSET ioctl support

2018-10-03 Thread Arun Kumar Neelakantam
Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 54 +++--- 1 file changed, 51 insertions(+), 3 deletions(-) diff --git

[PATCH 5/5] rpmsg: glink: Convert the native signals to TIOCM

2018-10-03 Thread Arun Kumar Neelakantam
Native signals over SMEM transport are different from Linux TIOCM signals. Add a macro to convert signals when sent or received from clients. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 29 + 1 file changed, 29 insertions(+) diff

[PATCH 0/5] Add TIOCM Signals support for RPMSG char devices

2018-10-03 Thread Arun Kumar Neelakantam
Glink transport support signals to exchange state notification between local and remote side clients. Adding support to send/receive the signal command and notify the clients through callback and POLL notification. Arun Kumar Neelakantam (5): rpmsg: glink: Add GLINK signal support for RPMSG

[PATCH 2/5] rpmsg: Add signal callback to rpmsg char device

2018-10-03 Thread Arun Kumar Neelakantam
Register a callback to get the signal notifications from rpmsg. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index a76b963..86003d5 100644 --- a/drivers

[PATCH 1/5] rpmsg: glink: Add GLINK signal support for RPMSG

2018-10-03 Thread Arun Kumar Neelakantam
Add support to handle SMD signals to RPMSG over GLINK. SMD signals mimic serial protocol signals to notify of ports opening and closing. This change affects the rpmsg core, rpmsg char and glink drivers. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg

[PATCH V4 8/9] rpmsg: glink: unregister rpmsg device during endpoint destroy

2018-07-27 Thread Arun Kumar Neelakantam
Rpmsg device unregister is not happening if channel close is triggered from local side and causing re-registration of device failures. Unregister rpmsg device for local close in endpoint destroy path. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 9 + 1

[PATCH V4 9/9] rpmsg: Add compat ioctl for rpmsg char driver

2018-07-27 Thread Arun Kumar Neelakantam
Add compat ioctl callback to support 32bit user space applications. Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/rpmsg_char.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 76a4477..a76b963 100644 --- a/drivers

[PATCH V4 3/9] rpmsg: glink: Use complete_all for open states

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew The open_req and open_ack completion variables are the state variables to represet a remote channel as open. Use complete_all so there are no races with waiters and using completion_done. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg

[PATCH V4 6/9] rpmsg: glink: Expose rpmsg name attr for glink

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew Expose the name field as an attr so clients listening to uevents for rpmsg can identify the edge the events correspond to. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 26 ++ 1 file changed, 26

[PATCH V4 2/9] rpmsg: glink: Store edge name for glink device

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew Channels may need to identify the edge their channel was probed for. Store the edge name by reading the label property from device tree or default to the node name. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 6

[PATCH V4 7/9] rpmsg: glink: Remove chunk size word align warning

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew It is possible for the chunk sizes coming from the non RPM remote procs to not be word aligned. Remove the alignment warning and continue to read from the FIFO so execution is not stalled. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg

[PATCH V4 4/9] rpmsg: Guard against null endpoint ops in destroy

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew In RPMSG GLINK the chrdev device will allocate an ept as part of the rpdev creation. This device will not register endpoint ops even though it has an allocated ept. Protect against the case where the device is being destroyed. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar

[PATCH V4 5/9] rpmsg: glink: Add support for rpmsg glink chrdev

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew RPMSG provides a char device interface to userspace. Probe the rpmsg chrdev channel to enable the rpmsg_ctrl device creation on glink transports. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 40

[PATCH V4 1/9] dt-bindings: soc: qcom: Add label for GLINK bindings

2018-07-27 Thread Arun Kumar Neelakantam
From: Chris Lew There are GLINK clients who open the same channel on multiple GLINK links. These clients need a way to distinguish which remoteproc they are communicating to. Add a label property to identify the edge this node represents. Signed-off-by: Chris Lew Signed-off-by: Arun Kumar

[PATCH V4 0/9] Add chrdev and name query support for GLINK

2018-07-27 Thread Arun Kumar Neelakantam
allocation to use glink channel allocation - Change glink attr struct to const Arun Kumar Neelakantam (2): rpmsg: glink: unregister rpmsg device during endpoint destroy rpmsg: Add compat ioctl for rpmsg char driver Chris Lew (7): dt-bindings: soc: qcom: Add label for GLINK bindings rpmsg

Re: [PATCH] soc: qcom: smp2p: Access APCS as mailbox client

2017-11-16 Thread Arun Kumar Neelakantam
On 11/16/2017 12:48 PM, Bjorn Andersson wrote: Attempt to acquire the APCS IPC through the mailbox framework and fall back to the old syscon based approach, to allow us to move away from using the syscon. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/Kconfig | 1 + drivers/soc/qcom/

Re: [PATCH] rpmsg: qcom_smd: Access APCS through mailbox framework

2017-11-16 Thread Arun Kumar Neelakantam
On 11/16/2017 12:38 PM, Bjorn Andersson wrote: Attempt to acquire the APCS IPC through the mailbox framework and fall back to the old syscon based approach, to allow us to move away from using the syscon. Signed-off-by: Bjorn Andersson Reviewed-by: Arun Kumar Neelakantam --- drivers

Re: [PATCH v2 2/5] soc: qcom: Introduce QMI helpers

2017-11-07 Thread Arun Kumar Neelakantam
On 11/7/2017 10:50 AM, Bjorn Andersson wrote: Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing

[PATCH V1] rpmsg: glink: Initialize the "intent_req_comp" completion variable

2017-10-29 Thread Arun Kumar Neelakantam
Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 5dcc9bf..fcd46ab 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glin

[PATCH] rpmsg: glink: Initialize the "intent_req_comp" completion variable

2017-10-27 Thread Arun Kumar Neelakantam
Signed-off-by: Arun Kumar Neelakantam --- drivers/rpmsg/qcom_glink_native.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 5dcc9bf..fcd46ab 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glin

Re: [PATCH v2 17/20] rpmsg: glink: Receive and store the remote intent buffers

2017-08-28 Thread Arun Kumar Neelakantam
R Signed-off-by: Bjorn Andersson Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 71 ++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg

Re: [PATCH v2 11/20] rpmsg: glink: Fix idr_lock from mutex to spinlock

2017-08-28 Thread Arun Kumar Neelakantam
: Sricharan R Signed-off-by: Bjorn Andersson Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 58 +++ 1 file changed, 40 insertions(+), 18 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg

Re: [PATCH v2 16/20] rpmsg: glink: Add announce_create ops and preallocate intents

2017-08-28 Thread Arun Kumar Neelakantam
announce_create ops, which gets called right after the rpmsg device gets probed. Signed-off-by: Sricharan R Signed-off-by: Bjorn Andersson Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 20 1 file changed, 20 insertions(+) diff --git a

Re: [PATCH v2 13/20] rpmsg: glink: Use the local intents when receiving data

2017-08-28 Thread Arun Kumar Neelakantam
. Signed-off-by: Sricharan R Signed-off-by: Bjorn Andersson Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 75 ++- 1 file changed, 50 insertions(+), 25 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_native.c b

Re: [PATCH v2 15/20] rpmsg: glink: Add rx done command

2017-08-28 Thread Arun Kumar Neelakantam
Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 83 +++ 1 file changed, 83 insertions(+) diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index ff83cbb..1458bdb 100644 --- a

Re: [PATCH v2 14/20] rpmsg: glink: Make RX FIFO peak accessor to take an offset

2017-08-28 Thread Arun Kumar Neelakantam
read together, simplifying things. So introduce this. Signed-off-by: Bjorn Andersson Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 15 +++ drivers/rpmsg/qcom_glink_native.h | 2 +- drivers/rpmsg

Re: [PATCH v2 10/20] rpmsg: glink: Add support for transport version negotiation

2017-08-28 Thread Arun Kumar Neelakantam
: Sricharan R Signed-off-by: Bjorn Andersson Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 75 --- drivers/rpmsg/qcom_glink_native.h | 5 +++ drivers/rpmsg/qcom_glink_rpm.c| 4 ++- drivers/rpmsg

Re: [PATCH v2 12/20] rpmsg: glink: Add support for TX intents

2017-08-28 Thread Arun Kumar Neelakantam
to allocate buffers using CMD_RX_INTENT_REQ, we allocate buffers of requested size, store the buffer id locally and also communicate the intent id to the remote. Signed-off-by: Bjorn Andersson Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg

Re: [PATCH v2 09/20] rpmsg: glink: Fix default case while handling received commands

2017-08-28 Thread Arun Kumar Neelakantam
On 8/24/2017 12:51 PM, Sricharan R wrote: Currently if we receive a command that we still do not support, then its simply discarded. While doing so, the RX FIFO pointer also needs to be incremented. Fixing this. Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N

Re: [PATCH v2 08/20] rpmsg: glink: Introduce glink smem based transport

2017-08-28 Thread Arun Kumar Neelakantam
smem based transports. Adding a new smem transport register function and the fifo accessors for the same. Signed-off-by: Bjorn Andersson Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/Kconfig | 10 ++ drivers/rpmsg/Makefile

Re: [PATCH v2 07/20] rpmsg: glink: Do a mbox_free_channel in remove

2017-08-28 Thread Arun Kumar Neelakantam
On 8/24/2017 12:51 PM, Sricharan R wrote: mbox_request_channel is done in probe, so free the channel in remove. Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH v2 06/20] rpmsg: glink: Return -EAGAIN when there is no FIFO space

2017-08-28 Thread Arun Kumar Neelakantam
On 8/24/2017 12:51 PM, Sricharan R wrote: The TX FIFO can be full, if the remote client has not read enough data (or) reading it slowly. So its nessecary to return -EAGAIN to the local client to enable retry. Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N

Re: [PATCH v2 05/20] rpmsg: glink: Allow unaligned data access

2017-08-28 Thread Arun Kumar Neelakantam
index accordingly, effectively removing the alignment restriction. Signed-off-by: Bjorn Andersson Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_native.c | 6 -- drivers/rpmsg/qcom_glink_rpm.c| 22 +- 2

Re: [PATCH v2 04/20] rpmsg: glink: Move the common glink protocol implementation to glink_native.c

2017-08-28 Thread Arun Kumar Neelakantam
: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/Kconfig |6 +- drivers/rpmsg/Makefile|1 + drivers/rpmsg/qcom_glink_native.c | 1017 + drivers/rpmsg/qcom_glink_native.h | 38 ++ drivers/rpmsg/qcom_glink_rpm.c

Re: [PATCH v2 03/20] rpmsg: glink: Split rpm_probe to reuse the common code

2017-08-28 Thread Arun Kumar Neelakantam
-smem based transport. Also reuse driver's remove as well. Signed-off-by: Bjorn Andersson Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_rpm.c | 85 -- 1 file changed, 49 insertions(+

Re: [PATCH v2 02/20] rpmsg: glink: Associate indirections for pipe fifo accessor's

2017-08-28 Thread Arun Kumar Neelakantam
-by: Bjorn Andersson Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Regards, Arun N --- drivers/rpmsg/qcom_glink_rpm.c | 144 ++--- 1 file changed, 106 insertions(+), 38 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/dri

Re: [PATCH v2 01/20] rpmsg: glink: Rename glink_rpm_xx functions to qcom_glink_xx

2017-08-28 Thread Arun Kumar Neelakantam
Signed-off-by: Sricharan R Acked-by: Arun Kumar Neelakantam Reagrds Arun N --- drivers/rpmsg/qcom_glink_rpm.c | 248 + 1 file changed, 128 insertions(+), 120 deletions(-) diff --git a/drivers/rpmsg/qcom_glink_rpm.c b/drivers/rpmsg/qcom_glink_rpm.c index

Re: [PATCH 13/18] rpmsg: glink: Add rx done command

2017-08-22 Thread Arun Kumar Neelakantam
On 8/22/2017 7:46 PM, Sricharan R wrote: Hi, +    /* Take it off the tree of receive intents */ +    if (!intent->reuse) { +    spin_lock(&channel->intent_lock); +    idr_remove(&channel->liids, intent->id); +    spin_unlock(&channel->intent_lock); +    } + +    /* Schedule the sen

Re: [PATCH 15/18] rpmsg: glink: Receive and store the remote intent buffers

2017-08-22 Thread Arun Kumar Neelakantam
On 8/16/2017 10:49 PM, Sricharan R wrote: Just like we allocating and sending intent ids to remote, remote side allocates and sends us the intents as well. So save the intent ids and use it later while sending data targeting the appropriate intents based on the size. Signed-off-by: Sricharan R

Re: [PATCH 13/18] rpmsg: glink: Add rx done command

2017-08-22 Thread Arun Kumar Neelakantam
On 8/16/2017 10:49 PM, Sricharan R wrote: Send RX data receive ack to remote and also inform that local intent buffer is used and freed. This informs the remote to request for next set of intent buffers before doing a send operation. Signed-off-by: Sricharan R Signed-off-by: Bjorn Andersson

Re: [PATCH 11/18] rpmsg: glink: Use the local intents when receiving data

2017-08-22 Thread Arun Kumar Neelakantam
On 8/16/2017 10:49 PM, Sricharan R wrote: So previously on request from remote side, we allocated local intent buffers and passed the ids to the remote. Now when we receive data buffers from remote directed to that intent id, copy the data to the corresponding preallocated intent buffer. Signe

Re: [PATCH 10/18] rpmsg: glink: Add support for TX intents

2017-08-22 Thread Arun Kumar Neelakantam
On 8/16/2017 10:49 PM, Sricharan R wrote: Intents are nothing but pre-allocated buffers of appropriate size that are allocated on the local side and communicated to the remote side and the remote stores the list of intent ids that it is informed. Later when remote side is intenting to send dat

Re: [PATCH 04/18] rpmsg: glink: Move the common glink protocol implementation to glink_native.c

2017-08-21 Thread Arun Kumar Neelakantam
On 8/16/2017 10:48 PM, Sricharan R wrote: + +struct glink_msg { + __le16 cmd; + __le16 param1; + __le32 param2; + u8 data[]; +} __packed; why we are using extra u8 data[] member here ? + +/** + * struct glink_defer_cmd - deferred incoming control message + * @node:

Re: [PATCH 2/3] soc: qcom: smem: Support dynamic item limit

2017-08-21 Thread Arun Kumar Neelakantam
On 8/18/2017 6:45 AM, Chris Lew wrote: In V12 SMEM, SBL writes SMEM parameter information after the TOC. Use the SBL provided item count as the max item number. Signed-off-by: Chris Lew --- drivers/soc/qcom/smem.c | 41 +++-- 1 file changed, 39 insertion

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-20 Thread Arun Kumar Neelakantam
On 8/18/2017 6:45 AM, Chris Lew wrote: @@ -782,7 +855,10 @@ static int qcom_smem_probe(struct platform_device *pdev) } version = qcom_smem_get_sbl_version(smem); - if (version >> 16 != SMEM_EXPECTED_VERSION) { + switch (version >> 16) { + case SMEM_GLOBAL_PART_V