On 4/19/2021 11:37 AM, Adrian Hunter wrote:
On 16/04/21 10:49 pm, Asutosh Das wrote:
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
I came across 3 issues while testing. See comments below.
Hi Adrian
Thanks for the comments.
@@ -5794,7 +5839,7
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Adrian Hunter
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 24
1 file changed, 12 insertions(+), 12 deletions
Carpenter
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs-debugfs.c | 6 +-
drivers/scsi/ufs/ufs-debugfs.h | 2 +-
drivers/scsi/ufs/ufs
On 4/15/2021 4:11 PM, Bart Van Assche wrote:
On 4/14/21 11:58 AM, Asutosh Das wrote:
[ ... ]
Hi Bart,
Thanks for the comments. I will fix the comments in the next version.
The following code is executed before ufshcd_async_scan() is called:
dev = hba->
suspend.
Fixed smatch warnings:
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs-debugfs.c
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Adrian Hunter
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 24
1 file changed, 12 insertions(+), 12 deletions
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi
this as a
supplier for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2
On 4/9/2021 3:07 AM, Adrian Hunter wrote:
On 9/04/21 5:27 am, Daejun Park wrote:
Hi Asutosh Das,
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU (START_STOP_UNIT) to wlun
during its runtime
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
this as a
supplier for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2
this as a
supplier for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
On 4/7/2021 3:21 AM, Adrian Hunter wrote:
On 6/04/21 8:52 pm, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU (START_STOP_UNIT) to wlun
during its runtime-suspend.
During
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
this as a
supplier for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2
On 3/31/2021 11:19 AM, Adrian Hunter wrote:
On 31/03/21 1:31 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU (START_STOP_UNIT) to wlun
during its runtime-suspend.
During
On 3/21/2021 2:57 PM, Nitin Rawat wrote:
Add a vops to configure VCC voltage VCC voltage level
for platform supporting both ufs2.x and ufs 3.x devices.
Suggested-by: Stanley Chu
Suggested-by: Asutosh Das
Suggested-by: Bjorn Andersson
Signed-off-by: Nitin Rawat
Signed-off-by: Veerabhadrarao
this as a
supplier for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
On 3/23/2021 12:19 PM, Adrian Hunter wrote:
On 23/03/21 5:13 pm, Asutosh Das (asd) wrote:
On 3/22/2021 11:12 PM, Adrian Hunter wrote:
On 22/03/21 9:53 pm, Asutosh Das (asd) wrote:
On 3/19/2021 10:47 AM, Adrian Hunter wrote:
On 19/03/21 2:35 am, Asutosh Das wrote:
During runtime-suspend
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
this as a
supplier for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2
On 3/22/2021 11:12 PM, Adrian Hunter wrote:
On 22/03/21 9:53 pm, Asutosh Das (asd) wrote:
On 3/19/2021 10:47 AM, Adrian Hunter wrote:
On 19/03/21 2:35 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them
On 3/19/2021 10:47 AM, Adrian Hunter wrote:
On 19/03/21 2:35 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During the process
On 3/18/2021 8:12 PM, Bart Van Assche wrote:
On 3/18/21 5:35 PM, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During the process
On 3/18/2021 12:16 PM, Adrian Hunter wrote:
On 18/03/21 7:58 pm, Asutosh Das (asd) wrote:
On 3/18/2021 10:54 AM, Rafael J. Wysocki wrote:
On Thu, Mar 18, 2021 at 6:33 PM Asutosh Das (asd)
wrote:
On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote:
On Wed, Mar 17, 2021 at 7:37 AM Adrian Hunter
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
On 3/15/2021 7:29 AM, Adrian Hunter wrote:
On 12/03/21 12:19 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During the process
On 3/18/2021 10:54 AM, Rafael J. Wysocki wrote:
On Thu, Mar 18, 2021 at 6:33 PM Asutosh Das (asd)
wrote:
On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote:
On Wed, Mar 17, 2021 at 7:37 AM Adrian Hunter wrote:
On 16/03/21 10:35 pm, Asutosh Das (asd) wrote:
On 3/16/2021 12:48 AM, Adrian Hunter
On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote:
On Wed, Mar 17, 2021 at 7:37 AM Adrian Hunter wrote:
On 16/03/21 10:35 pm, Asutosh Das (asd) wrote:
On 3/16/2021 12:48 AM, Adrian Hunter wrote:
On 16/03/21 12:22 am, Asutosh Das (asd) wrote:
On 3/14/2021 1:11 AM, Adrian Hunter wrote:
On 10/03
On 3/16/2021 12:48 AM, Adrian Hunter wrote:
On 16/03/21 12:22 am, Asutosh Das (asd) wrote:
On 3/14/2021 1:11 AM, Adrian Hunter wrote:
On 10/03/21 5:04 am, Asutosh Das (asd) wrote:
On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote:
On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote:
On Mon, Mar 8, 2021
On 3/15/2021 7:29 AM, Adrian Hunter wrote:
On 12/03/21 12:19 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During the process
On 3/14/2021 1:11 AM, Adrian Hunter wrote:
On 10/03/21 5:04 am, Asutosh Das (asd) wrote:
On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote:
On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote:
On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki wrote:
On Sat, Mar 6, 2021 at 5:17 PM Alan Stern wrote
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
On 3/10/2021 8:27 AM, Alan Stern wrote:
On Tue, Mar 09, 2021 at 08:04:53PM -0800, Asutosh Das (asd) wrote:
On 3/9/2021 7:14 PM, Alan Stern wrote:
On Tue, Mar 09, 2021 at 07:04:34PM -0800, Asutosh Das (asd) wrote:
Hello
I & Can (thanks CanG) debugged this further:
Looks like this issue
On 3/9/2021 7:14 PM, Alan Stern wrote:
On Tue, Mar 09, 2021 at 07:04:34PM -0800, Asutosh Das (asd) wrote:
Hello
I & Can (thanks CanG) debugged this further:
Looks like this issue can occur if the sd probe is asynchronous.
Essentially, the sd_probe() is done asynchrono
On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote:
On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote:
On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki
wrote:
On Sat, Mar 6, 2021 at 5:17 PM Alan Stern
wrote:
On Fri, Mar 05, 2021 at 06:54:24PM -0800, Asutosh Das (asd) wrote:
Now during my testing
On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote:
On Mon, Mar 8, 2021 at 5:21 PM Rafael J. Wysocki wrote:
On Sat, Mar 6, 2021 at 5:17 PM Alan Stern wrote:
On Fri, Mar 05, 2021 at 06:54:24PM -0800, Asutosh Das (asd) wrote:
Now during my testing I see a weird issue sometimes (1 in 7).
Scenario
On 3/4/2021 7:35 AM, Adrian Hunter wrote:
On 3/03/21 12:52 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During the process
On Thu, Mar 04 2021 at 23:45 -0800, Adrian Hunter wrote:
On 3/03/21 12:52 am, Asutosh Das wrote:
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Since "scsi: ufs: ufs-debugfs: Add user-defined exception_event_mask"
is now in
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 30 +-
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
On Tue, Mar 02 2021 at 06:14 -0800, Adrian Hunter wrote:
On 2/03/21 5:21 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
,
ufshcd_reset_and_restore() will change the state to UFSHCD_STATE_ERROR,
otherwise ufshcd_probe_hba() will have set the state appropriately.
Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and other error
recovery paths")
Signed-off-by: Adrian Hunter
---
Reviewed-by: A
On Mon, Mar 01 2021 at 05:23 -0800, Adrian Hunter wrote:
Hi
A couple of minor things, but also a potential issue with when link state
transitions are done. Please see comments below.
On 26/02/21 1:37 am, Asutosh Das wrote:
Hi Adrian
Thanks for your comments.
During runtime-suspend of ufs
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
On Thu, Feb 25 2021 at 07:55 -0800, Adrian Hunter wrote:
On 25/02/21 5:00 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/cdns-pltfrm.c | 2 +
drivers/scsi/ufs/tc-dwc-g210-pci.c | 2 +
drivers/scsi/ufs/ufs
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
On Wed, Feb 24 2021 at 06:34 -0800, Adrian Hunter wrote:
On 24/02/21 7:13 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-qcom.c | 2 +
drivers/scsi/ufs/ufshcd-pci.c| 24 --
drivers/scsi/ufs/ufshcd
On Tue, Feb 23 2021 at 12:23 -0800, Adrian Hunter wrote:
On 23/02/21 1:04 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During
On Tue, Feb 23 2021 at 12:23 -0800, Adrian Hunter wrote:
On 23/02/21 1:04 am, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During
Resumes the actual scsi device the unit descriptor of which
is being accessed instead of the hba alone.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-sysfs.c | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-sysfs.c b
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufshcd.c | 455 +++--
drivers/scsi/ufs/ufshcd.h
On Fri, Feb 19 2021 at 00:35 -0800, Adrian Hunter wrote:
On 11/02/21 9:18 pm, Asutosh Das wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
During
On Tue, Feb 16 2021 at 09:44 -0800, Asutosh Das wrote:
On Sat, Feb 13 2021 at 13:37 -0800, Avri Altman wrote:
+ } else {
Is it possible to get here?
Scsi_scan_host is called only after successful add_wluns
It looks so.
scsi 0:0:0:49488: Link setup for lun - ufshcd_setup_links
On Fri, Feb 12 2021 at 19:25 -0800, Bart Van Assche wrote:
On 2/11/21 11:18 AM, Asutosh Das wrote:
+static inline bool is_rpmb_wlun(struct scsi_device *sdev)
+{
+ return (sdev->lun == ufshcd_upiu_wlun_to_scsi_wlun(UFS_UPIU_RPMB_WLUN));
+}
+
+static inline bool is_device_wlun(str
On Sat, Feb 13 2021 at 13:37 -0800, Avri Altman wrote:
+ } else {
Is it possible to get here?
Scsi_scan_host is called only after successful add_wluns
It looks so.
scsi 0:0:0:49488: Link setup for lun - ufshcd_setup_links
[...]
Call trace:
dump_backtrace+0x0/0x1d4
show_stack+0x18/0x24
for all other luns. That way, this device wlun
suspends after all the consumers and resumes after
hba resumes.
Co-developed-by: Can Guo
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufshcd.c | 415 +
drivers/scsi/ufs/ufshcd.h
On Thu, Jan 28 2021 at 04:21 -0800, Avri Altman wrote:
During runtime-suspend of ufs host, the scsi devices are
already suspended and so are the queues associated with them.
But the ufs host sends SSU to wlun during its runtime-suspend.
Do you possible meant: "sends request-sense while
/0x18
Signed-off-by: Asutosh Das
Signed-off-by: Can Guo
Signed-off-by: Bao D. Nguyen
---
drivers/scsi/ufs/ufshcd.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9c691e4..b7e7f81 100644
It may happen that the underlying device's runtime-pm is
not controlled by block-pm. So it's possible that when
commands are sent to the device, it's suspended and may not
be resumed by blk-pm. Hence explicitly resume the parent
which is the platform device.
Signed-off-by: Asutosh Das
Signed-off
/0x18
Change-Id: Id777fd52493c8b5522d1ebcad73cd30dac33e8a4
Signed-off-by: Asutosh Das
Signed-off-by: Can Guo
Signed-off-by: Bao D. Nguyen
---
drivers/scsi/ufs/ufshcd.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi
Resumes the scsi device before accessing it.
Change-Id: I2929af60f2a92c89704a582fcdb285d35b429fde
Signed-off-by: Asutosh Das
Signed-off-by: Can Guo
Signed-off-by: Bao D. Nguyen
---
block/bsg.c | 8
1 file changed, 8 insertions(+)
diff --git a/block/bsg.c b/block/bsg.c
index d7bae94
On 12/24/2020 5:47 AM, Stanley Chu wrote:
Hi Avri, Bean,
On Thu, 2020-12-24 at 13:01 +0100, Bean Huo wrote:
On Thu, 2020-12-24 at 11:03 +, Avri Altman wrote:
Do you see any substantial benefit of having
fWriteBoosterBufferFlushEn
disabled?
1. The definition of fWriteBoosterBufferFlushEn
On 12/8/2020 5:56 AM, Stanley Chu wrote:
Since more and more statements showing up in ufshcd_vops_device_reset(),
uninline it to allow compiler making possibly better optimization.
Signed-off-by: Stanley Chu
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd.c | 27
history functions
scsi: ufs: Introduce notify_event variant function
drivers/scsi/ufs/ufshcd.c | 122 ++
drivers/scsi/ufs/ufshcd.h | 82 -
2 files changed, 112 insertions(+), 92 deletions(-)
Hi Stanley,
Reviewed-by: Asutosh Das
On 12/2/2020 8:20 AM, Bean Huo wrote:
On Mon, 2020-11-30 at 15:19 -0800, Asutosh Das (asd) wrote:
+ return -EINVAL;
+
+ pm_runtime_get_sync(hba->dev);
+ res = ufshcd_wb_ctrl(hba, wb_enable);
Say, a platform supports clock-scaling and this bit is toggled.
The control g
On 11/30/2020 7:11 PM, Can Guo wrote:
On 2020-12-01 07:01, Asutosh Das (asd) wrote:
On 11/25/2020 6:01 PM, Can Guo wrote:
Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep
a flag
in struct ufs_clk_info to tell whether a clock can be disabled or not
while
the link is active
Reviewed-by: Bjorn Andersson
Signed-off-by: Stanley Chu
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd-pltfrm.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index a6f76399b3ae..09e2f04bf4f6 10064
On 11/30/2020 6:53 PM, Bjorn Andersson wrote:
On Mon 30 Nov 17:54 CST 2020, Asutosh Das (asd) wrote:
On 11/30/2020 3:14 PM, Bjorn Andersson wrote:
On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote:
On 11/30/2020 1:16 AM, Stanley Chu wrote:
UFS specficication allows different VCC
On 11/30/2020 5:25 PM, Stanley Chu wrote:
On Mon, 2020-11-30 at 15:54 -0800, Asutosh Das (asd) wrote:
On 11/30/2020 3:14 PM, Bjorn Andersson wrote:
On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote:
On 11/30/2020 1:16 AM, Stanley Chu wrote:
UFS specficication allows different VCC
in_use shall
evetually be cleared in __ufshcd_transfer_req_compl() invoked by the full
reset and restore from err_handler.
Signed-off-by: Can Guo
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd.c | 55 ---
drivers/scsi/ufs/ufshcd.h | 2 ++
2
On 11/16/2020 11:04 PM, Can Guo wrote:
Serialize eh_work with system PM events and async scan to make sure eh_work
does not run in parallel with them.
Signed-off-by: Can Guo
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd.c | 64
On 11/25/2020 6:01 PM, Can Guo wrote:
If we want to disable clocks to save power but still keep the link active,
core_clk_unipro, as same as ref_clk, should not be the one being disabled.
Reviewed-by: Hongwu Su
Signed-off-by: Can Guo
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufs
On 11/30/2020 3:14 PM, Bjorn Andersson wrote:
On Mon 30 Nov 16:51 CST 2020, Asutosh Das (asd) wrote:
On 11/30/2020 1:16 AM, Stanley Chu wrote:
UFS specficication allows different VCC configurations for UFS devices,
for example,
(1). 2.70V - 3.60V (By default)
(2). 1.70V
On 11/30/2020 10:11 AM, Bean Huo wrote:
From: Bean Huo
Currently we let UFS WriteBooster driver use clock scaling
up/down to set WB on/off, for the platform which doesn't
support UFSHCD_CAP_CLK_SCALING, WB will be always on. Provide
a sysfs attribute to enable/disable WB during runtime.
On 11/25/2020 6:01 PM, Can Guo wrote:
Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a flag
in struct ufs_clk_info to tell whether a clock can be disabled or not while
the link is active.
Reviewed-by: Hongwu Su
Reviewed-by: Bean Huo
Reviewed-by: Stanley Chu
On 11/26/2020 5:58 PM, Can Guo wrote:
Instead of making the scale down gear a hard code, make it a member of
ufs_clk_scaling struct.
Signed-off-by: Can Guo
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd.c | 12 +++-
drivers/scsi/ufs/ufshcd.h | 2 ++
2 files changed, 9
On 11/30/2020 1:16 AM, Stanley Chu wrote:
UFS specficication allows different VCC configurations for UFS devices,
for example,
(1). 2.70V - 3.60V (By default)
(2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in
device tree)
(3).
On 11/16/2020 11:04 PM, Can Guo wrote:
When AH8 error happens, all the regs and states are dumped in err handler.
Sometime we need to look into host regs right after AH8 error happens,
which is before leaving the IRQ handler.
Signed-off-by: Can Guo
---
Reviewed-by: Asutosh Das
drivers
ungate work is
queued. To make sure scsi_block_reqs_cnt is handled by ufshcd_hold() and
ufshcd_ungate_work() in a paired way, increase it only if queue_work()
returns true.
Signed-off-by: Can Guo
Reviewed-by: Hongwu Su
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd.c | 6 +++---
1
their corrsponding sysfs entries.
Fix it by adding a sanity check of parameter offset against the actual
decriptor length.
Signed-off-by: Can Guo
---
Reviewed-by: Asutosh Das
drivers/scsi/ufs/ufshcd.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git
vri Altman
Signed-off-by: Qinglang Miao
---
Reviewed-by: Asutosh Das
v2: consider missing destroy_workqueue ufshcd_remove either.
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b8f573a02713..ad
med that UFS devices with wspecversion >= 0x310 support
DeepSleep.
Signed-off-by: Adrian Hunter
---
Reviewed-by: Asutosh Das
Documentation/ABI/testing/sysfs-driver-ufs | 34 +++
drivers/scsi/ufs/ufs-sysfs.c | 7
drivers/scsi/ufs
rovide
the callback, but do not do the reset operation should return -EOPNOTSUPP.
Signed-off-by: Adrian Hunter
Reviewed-by: Asutosh Das
---
drivers/scsi/ufs/ufs-mediatek.c | 4 +++-
drivers/scsi/ufs/ufs-qcom.c | 6 --
drivers/scsi/ufs/ufshcd.h | 11 +++
3 files chang
Enabling this capability to let hba power-collapse
more often to save power.
Reviewed-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index f9d6ef3..9a19c6d
From: Can Guo
During clock gating, after clocks are disabled,
put hba into LPM to save more power.
Acked-by: Stanley Chu
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufshcd.c | 9 +++--
drivers/scsi/ufs/ufshcd.h | 13 +
2 files changed, 20
Enabling this capability to let hba power-collapse
more often to save power.
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufs-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index f9d6ef3..9a19c6d 100644
--- a/drivers/scsi
From: Can Guo
During clock gating, after clocks are disabled,
put hba into LPM to save more power.
Signed-off-by: Can Guo
Signed-off-by: Asutosh Das
---
drivers/scsi/ufs/ufshcd.c | 7 +--
drivers/scsi/ufs/ufshcd.h | 13 +
2 files changed, 18 insertions(+), 2 deletions
1 - 100 of 211 matches
Mail list logo
