Re: [PATCH] regulator: tps65218: Add NULL test for devm_kzalloc call

2017-11-16 19:23 GMT+08:00 Keerthy : > > > On Monday 13 November 2017 06:22 PM, Axel Lin wrote: >> Signed-off-by: Axel Lin > > One line commit message would be better than blank commit message. It's just too trivial and checkpatch does not complain.

[PATCH] regulator: tps65218: Remove unused enum tps65218_regulators

The enum tps65218_regulators is no longer being used after commit 2dc4940360d4 ("regulator: tps65218: Remove all the compatibles"). Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/tps65218-regulator.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/d

[PATCH] regulator: tps65218: Remove unused enum tps65218_regulators

The enum tps65218_regulators is no longer being used after commit 2dc4940360d4 ("regulator: tps65218: Remove all the compatibles"). Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/regulator/tps65218-regu

[PATCH] regulator: tps65218: Add NULL test for devm_kzalloc call

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/tps65218-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c index bc489958fed7..b3f89ebfb1a0 100644 --- a/drivers/regulator/tp

[PATCH] regulator: tps65218: Add NULL test for devm_kzalloc call

Signed-off-by: Axel Lin --- drivers/regulator/tps65218-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c index bc489958fed7..b3f89ebfb1a0 100644 --- a/drivers/regulator/tps65218-regulator.c +++ b

[PATCH] regulator: axp20x: Simplify axp20x_is_polyphase_slave implementation

The code to handle AXP803_ID and AXP813_ID cases are exactly the same. Make the switch-case fall through to avoid duplicate code. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/axp20x-regulator.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff

[PATCH] regulator: axp20x: Simplify axp20x_is_polyphase_slave implementation

The code to handle AXP803_ID and AXP813_ID cases are exactly the same. Make the switch-case fall through to avoid duplicate code. Signed-off-by: Axel Lin --- drivers/regulator/axp20x-regulator.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/regulator

[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices

This fixes missing mfd_remove_devices() call when unload the module. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/mfd/lp87565.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c index 340ad0c..32d2a07

[PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices

This fixes missing mfd_remove_devices() call when unload the module. Signed-off-by: Axel Lin --- drivers/mfd/lp87565.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c index 340ad0c..32d2a07 100644 --- a/drivers/mfd/lp87565

[PATCH] regulator: bd9571mwv: Statize local symbols

These functions are only used by this driver, make them static. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/bd9571mwv-regulator.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/reg

[PATCH] regulator: bd9571mwv: Statize local symbols

These functions are only used by this driver, make them static. Signed-off-by: Axel Lin --- drivers/regulator/bd9571mwv-regulator.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c

Re: [PATCH RESEND] regulator: rn5t618: Fix out of bounds array access

2017-04-16 9:12 GMT+08:00 Axel Lin <axel@ingics.com>: > 2017-04-16 0:53 GMT+08:00 Stefan Agner <ste...@agner.ch>: >> On 2017-04-15 07:52, Axel Lin wrote: >>> The commit "regulator: rn5t618: Add RN5T567 PMIC support" added >>> RN5T618_DCDC4

Re: [PATCH RESEND] regulator: rn5t618: Fix out of bounds array access

2017-04-16 9:12 GMT+08:00 Axel Lin : > 2017-04-16 0:53 GMT+08:00 Stefan Agner : >> On 2017-04-15 07:52, Axel Lin wrote: >>> The commit "regulator: rn5t618: Add RN5T567 PMIC support" added >>> RN5T618_DCDC4 to the enum, then RN5T618_REG_NUM is also chan

Re: [PATCH RESEND] regulator: rn5t618: Fix out of bounds array access

2017-04-16 0:53 GMT+08:00 Stefan Agner <ste...@agner.ch>: > On 2017-04-15 07:52, Axel Lin wrote: >> The commit "regulator: rn5t618: Add RN5T567 PMIC support" added >> RN5T618_DCDC4 to the enum, then RN5T618_REG_NUM is also changed. >> So for rn5t618, the

Re: [PATCH RESEND] regulator: rn5t618: Fix out of bounds array access

2017-04-16 0:53 GMT+08:00 Stefan Agner : > On 2017-04-15 07:52, Axel Lin wrote: >> The commit "regulator: rn5t618: Add RN5T567 PMIC support" added >> RN5T618_DCDC4 to the enum, then RN5T618_REG_NUM is also changed. >> So for rn5t618, there is out of bounds array acc

[PATCH RESEND] regulator: rn5t618: Fix out of bounds array access

n5t618, so we had better remove RN5T618_REG_NUM and get the correct num_regulators during probe instead. Fixes: ed6d362d8dbc ("regulator: rn5t618: Add RN5T567 PMIC support") Signed-off-by: Axel Lin <axel@ingics.com> --- RESEND: Correct subject line (remove double Fix)

[PATCH RESEND] regulator: rn5t618: Fix out of bounds array access

n5t618, so we had better remove RN5T618_REG_NUM and get the correct num_regulators during probe instead. Fixes: ed6d362d8dbc ("regulator: rn5t618: Add RN5T567 PMIC support") Signed-off-by: Axel Lin --- RESEND: Correct subject line (remove double Fix) drivers/regulator/rn5

[PATCH] regulator: rn5t618: Fix Fix out of bounds array access

n5t618, so we had better remove RN5T618_REG_NUM and get the correct num_regulators during probe instead. Fixes: ed6d362d8dbc ("regulator: rn5t618: Add RN5T567 PMIC support") Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/rn5t618-regulator.c | 8 i

[PATCH] regulator: rn5t618: Fix Fix out of bounds array access

n5t618, so we had better remove RN5T618_REG_NUM and get the correct num_regulators during probe instead. Fixes: ed6d362d8dbc ("regulator: rn5t618: Add RN5T567 PMIC support") Signed-off-by: Axel Lin --- drivers/regulator/rn5t618-regulator.c | 8 include/linux/mfd/rn5t618.h

[PATCH] regulator: vctrl: Fix out of bounds array access for vctrl->vtable

Current code only allocates rdesc->n_voltages entries for vctrl->vtable. Thus use rdesc->n_voltages instead of n_voltages in the for loop. While at it, also switch to use devm_kcalloc instead of devm_kmalloc_array + __GFP_ZERO flag and fix the argument order. Signed-off-by: Axel

[PATCH] regulator: vctrl: Fix out of bounds array access for vctrl->vtable

Current code only allocates rdesc->n_voltages entries for vctrl->vtable. Thus use rdesc->n_voltages instead of n_voltages in the for loop. While at it, also switch to use devm_kcalloc instead of devm_kmalloc_array + __GFP_ZERO flag and fix the argument order. Signed-off-by:

[PATCH] regulator: tps65132: Fix off-by-one for .max_register setting

TPS65132_REG_CONTROL(0xFF) is the latest valid register. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/tps65132-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps65132-regulator.c b/drivers/regulator/tps65132-regul

[PATCH] regulator: tps65132: Fix off-by-one for .max_register setting

TPS65132_REG_CONTROL(0xFF) is the latest valid register. Signed-off-by: Axel Lin --- drivers/regulator/tps65132-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps65132-regulator.c b/drivers/regulator/tps65132-regulator.c index a949206..a2fc732

[PATCH 1/2] regulator: twl: Remove unused fields from struct twlreg_info

The min_mV, max_mV and flags fields are not used, so remove them. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/twl-regulator.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c index d

[PATCH 1/2] regulator: twl: Remove unused fields from struct twlreg_info

The min_mV, max_mV and flags fields are not used, so remove them. Signed-off-by: Axel Lin --- drivers/regulator/twl-regulator.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c index d572b8a..6c9ec84 100644

[PATCH 2/2] regulator: twl6030: Remove unused fields from struct twlreg_info

The table_len, *table, remap and max_mV fields are not used, so remove them. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/twl6030-regulator.c | 46 +-- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/drivers/regulator/t

[PATCH 2/2] regulator: twl6030: Remove unused fields from struct twlreg_info

The table_len, *table, remap and max_mV fields are not used, so remove them. Signed-off-by: Axel Lin --- drivers/regulator/twl6030-regulator.c | 46 +-- 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/drivers/regulator/twl6030-regulator.c b

[PATCH] regulator: tps6507x: Drop pointless static qualifier for *reg_data variable

There is no need to use static for this local variable. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/tps6507x-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regul

[PATCH] regulator: tps6507x: Drop pointless static qualifier for *reg_data variable

There is no need to use static for this local variable. Signed-off-by: Axel Lin --- drivers/regulator/tps6507x-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c index dad0bac..c179a3a

[PATCH] regulator: rk808: Use rdev_get_id() to access id of regulator

RK808_ID_DCDC1 is 0, no need to do subtract RK808_ID_DCDC1. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/rk808-regulator.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator

[PATCH] regulator: rk808: Use rdev_get_id() to access id of regulator

RK808_ID_DCDC1 is 0, no need to do subtract RK808_ID_DCDC1. Signed-off-by: Axel Lin --- drivers/regulator/rk808-regulator.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c index 3314bf2

Re: [PATCH RFT] platform/x86: intel_pmc_ipc: Convert to use platform_device_register_full

2016-09-29 7:36 GMT+08:00 Darren Hart : > +LKML > > Axel, please always include LKML on any patch. I thought +LKML is optional if you already have a dedicated platform-driver-x86 maillist.

Re: [PATCH RFT] platform/x86: intel_pmc_ipc: Convert to use platform_device_register_full

2016-09-29 7:36 GMT+08:00 Darren Hart : > +LKML > > Axel, please always include LKML on any patch. I thought +LKML is optional if you already have a dedicated platform-driver-x86 maillist.

Re: [PATCH] phy: meson-usb2: Fix build dependency

2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I <kis...@ti.com>: > > > On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote: >> Martin Blumenstingl <martin.blumensti...@googlemail.com> writes: >> >>> Hi Axel, >>> >>> On Fri, S

Re: [PATCH] phy: meson-usb2: Fix build dependency

2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I : > > > On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote: >> Martin Blumenstingl writes: >> >>> Hi Axel, >>> >>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin wrote: >>>> of_usb

[PATCH] phy: sun4i-usb: Fix build dependency

of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below build error. ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Signed-off-by: Axel

[PATCH] phy: sun4i-usb: Fix build dependency

of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below build error. ERROR: "of_usb_get_dr_mode_by_phy" [drivers/phy/phy-sun4i-usb.ko] undefined! scripts/Makefile.modpost:91: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Signed-off-by

[PATCH] phy: meson-usb2: Fix build dependency

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/phy/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 6ad87ec..cc27c12 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -458,6 +458,8 @@ config PHY_MESO

[PATCH] phy: meson-usb2: Fix build dependency

Signed-off-by: Axel Lin --- drivers/phy/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 6ad87ec..cc27c12 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -458,6 +458,8 @@ config PHY_MESON_USB2 tristate "Meson

[PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x

The mutex is not used, so remove it. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/mfd/lp873x.c | 2 -- include/linux/mfd/lp873x.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c index 9af064c..873c608 100644 --- a/drive

[PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x

The mutex is not used, so remove it. Signed-off-by: Axel Lin --- drivers/mfd/lp873x.c | 2 -- include/linux/mfd/lp873x.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c index 9af064c..873c608 100644 --- a/drivers/mfd/lp873x.c +++ b/drivers

Re: [RESEND AGAIN][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

2016-08-30 22:05 GMT+08:00 Kishon Vijay Abraham I <kis...@ti.com>: > > > On Tuesday 30 August 2016 07:23 PM, Axel Lin wrote: >> By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be >> removed. >> >> Signed-off-by: Axel Lin <axel@ingics

Re: [RESEND AGAIN][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

2016-08-30 22:05 GMT+08:00 Kishon Vijay Abraham I : > > > On Tuesday 30 August 2016 07:23 PM, Axel Lin wrote: >> By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be >> removed. >> >> Signed-off-by: Axel Lin >> Reviewed-and-tested-by: Jon

[RESEND AGAIN][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be removed. Signed-off-by: Axel Lin <axel@ingics.com> Reviewed-and-tested-by: Jon Mason <jon.ma...@broadcom.com> --- This was sent on http://www.spinics.net/lists/netdev/msg383513.html Resent on https://lkml.org/lk

[RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops

Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. While at it, also makes ns2_pci_phy_ops const as it's never get modified. Signed-off-by: Axel Lin <axel@ingics.com> Reviewed-and-tested-by: Jon Mason <jon.ma...@broadcom.com> --- This was

[RESEND AGAIN][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be removed. Signed-off-by: Axel Lin Reviewed-and-tested-by: Jon Mason --- This was sent on http://www.spinics.net/lists/netdev/msg383513.html Resent on https://lkml.org/lkml/2016/8/12/658 drivers/phy/phy-bcm-ns2-pcie.c | 25

[RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops

Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. While at it, also makes ns2_pci_phy_ops const as it's never get modified. Signed-off-by: Axel Lin Reviewed-and-tested-by: Jon Mason --- This was sent on http://www.spinics.net/lists/netdev/msg383514.html Resent on https

[RESEND][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be removed. Signed-off-by: Axel Lin <axel@ingics.com> --- I don't have this h/w. Appreciate if someone can test this patch serial. This was sent on http://www.spinics.net/lists/netdev/msg383513.html drivers/phy/phy-b

[RESEND][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops

Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. While at it, also makes ns2_pci_phy_ops const as it's never get modified. Signed-off-by: Axel Lin <axel@ingics.com> --- This was sent on http://www.spinics.net/lists/netdev/msg383514.html drivers/phy/phy-b

[RESEND][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy

By setting phy_set_drvdata(phy, mdiodev), struct ns2_pci_phy can be removed. Signed-off-by: Axel Lin --- I don't have this h/w. Appreciate if someone can test this patch serial. This was sent on http://www.spinics.net/lists/netdev/msg383513.html drivers/phy/phy-bcm-ns2-pcie.c | 25

[RESEND][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops

Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. While at it, also makes ns2_pci_phy_ops const as it's never get modified. Signed-off-by: Axel Lin --- This was sent on http://www.spinics.net/lists/netdev/msg383514.html drivers/phy/phy-bcm-ns2-pcie.c | 3 ++- 1 file

[PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable

The 'reg' local variable does not need to be static. Signed-off-by: Axel Lin <axel@ingics.com> --- This patch was sent on http://www.spinics.net/lists/linux-samsung-soc/msg51405.html drivers/phy/phy-exynos5-usbdrd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH RESEND] phy: exynos5-usbdrd: Remove "static" from local variable

The 'reg' local variable does not need to be static. Signed-off-by: Axel Lin --- This patch was sent on http://www.spinics.net/lists/linux-samsung-soc/msg51405.html drivers/phy/phy-exynos5-usbdrd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/phy-exynos5

[PATCH RESEND] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

Return proper error instead of 0 if brcm_sata_phy_init fails. Signed-off-by: Axel Lin <axel@ingics.com> --- It was sent on https://lkml.org/lkml/2016/5/23/12 . drivers/phy/phy-brcm-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-brcm-sa

[PATCH RESEND] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

Return proper error instead of 0 if brcm_sata_phy_init fails. Signed-off-by: Axel Lin --- It was sent on https://lkml.org/lkml/2016/5/23/12 . drivers/phy/phy-brcm-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c

[PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const

It's only used in this driver and never get modified, make it static const. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/mfd/altera-a10sr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c index c

[PATCH] mfd: altera-a10sr: Make altr_a10sr_regmap_config static const

It's only used in this driver and never get modified, make it static const. Signed-off-by: Axel Lin --- drivers/mfd/altera-a10sr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/altera-a10sr.c b/drivers/mfd/altera-a10sr.c index c05aa4f..40ed65e 100644

[RESEND][PATCH 2/2] regulator: mt6323: Constify struct regulator_ops

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/mt6323-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index f7831f3..b7b9670 100644 --- a/drivers/reg

[RESEND][PATCH 2/2] regulator: mt6323: Constify struct regulator_ops

Signed-off-by: Axel Lin --- drivers/regulator/mt6323-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index f7831f3..b7b9670 100644 --- a/drivers/regulator/mt6323-regulator.c +++ b

[RESEND][PATCH 1/2] regulator: mt6323: Fix module description

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/mt6323-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index 927cc23..f7831f3 100644 --- a/drivers/regulator/

[RESEND][PATCH 1/2] regulator: mt6323: Fix module description

Signed-off-by: Axel Lin --- drivers/regulator/mt6323-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index 927cc23..f7831f3 100644 --- a/drivers/regulator/mt6323-regulator.c +++ b/drivers

[PATCH 2/2] regulator: mt6323: Constify struct regulator_ops

Signed-off-by: Axel Lin <axel@ingics.com> ---  drivers/regulator/mt6323-regulator.c | 6 +++---  1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index f7831f3..b7b9670 100644 --- a/drivers/reg

[PATCH 2/2] regulator: mt6323: Constify struct regulator_ops

Signed-off-by: Axel Lin ---  drivers/regulator/mt6323-regulator.c | 6 +++---  1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index f7831f3..b7b9670 100644 --- a/drivers/regulator/mt6323-regulator.c +++ b

[PATCH 1/2] regulator: mt6323: Fix module description

Signed-off-by: Axel Lin <axel@ingics.com> ---  drivers/regulator/mt6323-regulator.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index 927cc23..f7831f3 100644 --- a/drivers/regulator/

[PATCH 1/2] regulator: mt6323: Fix module description

Signed-off-by: Axel Lin ---  drivers/regulator/mt6323-regulator.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/mt6323-regulator.c b/drivers/regulator/mt6323-regulator.c index 927cc23..f7831f3 100644 --- a/drivers/regulator/mt6323-regulator.c +++ b/drivers

[PATCH] regulator: lp873x: Drop _nlr parameter from LP873X_REGULATOR()

No need to pass _nlr to LP873X_REGULATOR(), use ARRAY_SIZE to calculate it. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/lp873x-regulator.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/regulator/lp873x-regulator.c b/d

[PATCH] regulator: lp873x: Drop _nlr parameter from LP873X_REGULATOR()

No need to pass _nlr to LP873X_REGULATOR(), use ARRAY_SIZE to calculate it. Signed-off-by: Axel Lin --- drivers/regulator/lp873x-regulator.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/regulator/lp873x-regulator.c b/drivers/regulator/lp873x

[PATCH RFT] regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed

esc->fixed_uV without .list_voltage implementation. Fixes: 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback") Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/qcom_smd-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/q

[PATCH RFT] regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed

esc->fixed_uV without .list_voltage implementation. Fixes: 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback") Signed-off-by: Axel Lin --- drivers/regulator/qcom_smd-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/qcom_smd-regulator.c b/d

[PATCH] mfd: max77620: Constify resources tables

These tables are never modified, so declare them as const. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/mfd/max77620.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index 199d261..e831422

[PATCH] mfd: max77620: Constify resources tables

These tables are never modified, so declare them as const. Signed-off-by: Axel Lin --- drivers/mfd/max77620.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index 199d261..e831422 100644 --- a/drivers/mfd/max77620.c

[PATCH] pinctrl: tegra: Fix build dependency

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/pinctrl/Makefile | 2 +- drivers/pinctrl/tegra/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2ed0b3f..25ec450 100644 --- a/drivers/pinctr

[PATCH] pinctrl: tegra: Fix build dependency

Signed-off-by: Axel Lin --- drivers/pinctrl/Makefile | 2 +- drivers/pinctrl/tegra/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2ed0b3f..25ec450 100644 --- a/drivers/pinctrl/Makefile +++ b/drive

[PATCH RFT] regulator: tps51632: Fix setting ramp delay

register to 6mV/us. Fix the logic to set slew register. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/tps51632-regulator.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tp

[PATCH RFT] regulator: tps51632: Fix setting ramp delay

register to 6mV/us. Fix the logic to set slew register. Signed-off-by: Axel Lin --- drivers/regulator/tps51632-regulator.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps51632-regulator.c b/drivers/regulator/tps51632-regulator.c index 572816e

[RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

Current code for .set_ramp_delay() rounds down the value written to register, while the implementation of .set_voltage_time_sel() works on original constraints (not rounded down). Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin <a

[RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

Current code for .set_ramp_delay() rounds down the value written to register, while the implementation of .set_voltage_time_sel() works on original constraints (not rounded down). Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin --- v2: Update

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski <k.kozlow...@samsung.com>: > On 05/29/2016 01:16 PM, Axel Lin wrote: >> Current code can set ramp delay to a wrong setting that the return value >> from .set_voltage_time_sel is not enough for proper delay. > > I don't under

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski : > On 05/29/2016 01:16 PM, Axel Lin wrote: >> Current code can set ramp delay to a wrong setting that the return value >> from .set_voltage_time_sel is not enough for proper delay. > > I don't understand what yo wanted to say her

[RFT][PATCH RESEND] regulator: max8973: Fix setting ramp delay

Current code can set ramp delay to a wrong setting that the return value from .set_voltage_time_sel is not enough for proper delay. Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin <axel@ingics.com> --- RESEND: Fix typo in subject line

[RFT][PATCH RESEND] regulator: max8973: Fix setting ramp delay

Current code can set ramp delay to a wrong setting that the return value from .set_voltage_time_sel is not enough for proper delay. Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin --- RESEND: Fix typo in subject line, it's max8973. drivers

[PATCH RFT] regulator: max8972: Fix setting ramp delay

Current code can set ramp delay to a wrong setting that the return value from .set_voltage_time_sel is not enough for proper delay. Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/max8973-regul

[PATCH RFT] regulator: max8972: Fix setting ramp delay

Current code can set ramp delay to a wrong setting that the return value from .set_voltage_time_sel is not enough for proper delay. Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin --- drivers/regulator/max8973-regulator.c | 16

[PATCH] regulator: palmas: Remove *rdev[PALMAS_NUM_REGS] from struct palmas_pmic

Current code uses devm_regulator_register(), so *rdev[PALMAS_NUM_REGS] is no longer required. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/palmas-regulator.c | 12 include/linux/mfd/palmas.h | 1 - 2 files changed, 13 deletions(-) diff

[PATCH] regulator: palmas: Remove *rdev[PALMAS_NUM_REGS] from struct palmas_pmic

Current code uses devm_regulator_register(), so *rdev[PALMAS_NUM_REGS] is no longer required. Signed-off-by: Axel Lin --- drivers/regulator/palmas-regulator.c | 12 include/linux/mfd/palmas.h | 1 - 2 files changed, 13 deletions(-) diff --git a/drivers/regulator/palmas

[PATCH] regulator: pv880x0: Clean up unnecessary header inclusion

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/regulator/pv88060-regulator.c | 3 --- drivers/regulator/pv88080-regulator.c | 3 --- drivers/regulator/pv88090-regulator.c | 3 --- 3 files changed, 9 deletions(-) diff --git a/drivers/regulator/pv88060-regulator.c b/drivers/reg

[PATCH] regulator: pv880x0: Clean up unnecessary header inclusion

Signed-off-by: Axel Lin --- drivers/regulator/pv88060-regulator.c | 3 --- drivers/regulator/pv88080-regulator.c | 3 --- drivers/regulator/pv88090-regulator.c | 3 --- 3 files changed, 9 deletions(-) diff --git a/drivers/regulator/pv88060-regulator.c b/drivers/regulator/pv88060-regulator.c

Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

2016-05-23 13:28 GMT+08:00 Kishon Vijay Abraham I <kis...@ti.com>: > Hi, > > On Monday 23 May 2016 10:51 AM, Axel Lin wrote: >> Signed-off-by: Axel Lin <axel@ingics.com> > > however obvious the patch maybe, it's nice to add a little commit log. I think the s

Re: [PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

2016-05-23 13:28 GMT+08:00 Kishon Vijay Abraham I : > Hi, > > On Monday 23 May 2016 10:51 AM, Axel Lin wrote: >> Signed-off-by: Axel Lin > > however obvious the patch maybe, it's nice to add a little commit log. I think the subject line is already very clear about the int

[PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/phy/phy-brcm-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c index 6c4c5cb..5d7fad4b 100644 --- a/drivers/phy/phy-brcm-sata.c +++ b/drivers/phy/ph

[PATCH] phy: brcm-sata: Return proper error if brcm_sata_phy_init fails

Signed-off-by: Axel Lin --- drivers/phy/phy-brcm-sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-brcm-sata.c b/drivers/phy/phy-brcm-sata.c index 6c4c5cb..5d7fad4b 100644 --- a/drivers/phy/phy-brcm-sata.c +++ b/drivers/phy/phy-brcm-sata.c @@ -288,7

Re: [PATCH] mailbox: xgene-slimpro: Fix wrong test for devm_kzalloc

2016-03-21 20:12 GMT+08:00 Axel Lin <axel@ingics.com>: > devm_kzalloc() returns NULL on failure. Hi, I'm wondering if this trivial fix is lost. Should I resend it?

Re: [PATCH] mailbox: xgene-slimpro: Fix wrong test for devm_kzalloc

2016-03-21 20:12 GMT+08:00 Axel Lin : > devm_kzalloc() returns NULL on failure. Hi, I'm wondering if this trivial fix is lost. Should I resend it?

[PATCH] mailbox: xgene-slimpro: Fix wrong test for devm_kzalloc

devm_kzalloc() returns NULL on failure. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/mailbox/mailbox-xgene-slimpro.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox-xgene-slimpro.c b/drivers/mailbox/mailbox-xgene-slimpro.c

[PATCH] mailbox: xgene-slimpro: Fix wrong test for devm_kzalloc

devm_kzalloc() returns NULL on failure. Signed-off-by: Axel Lin --- drivers/mailbox/mailbox-xgene-slimpro.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox-xgene-slimpro.c b/drivers/mailbox/mailbox-xgene-slimpro.c index bd07f39..dd2afbc 100644

[tip:irq/urgent] irqchip/tegra: Switch to use irq_domain_free_irqs_common

Commit-ID: 46f920d8a970cf102e18f25814a4ff4729ad8537 Gitweb: http://git.kernel.org/tip/46f920d8a970cf102e18f25814a4ff4729ad8537 Author: Axel Lin <axel@ingics.com> AuthorDate: Sun, 20 Mar 2016 20:44:05 +0800 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Sun,

[tip:irq/urgent] irqchip/tegra: Switch to use irq_domain_free_irqs_common

Commit-ID: 46f920d8a970cf102e18f25814a4ff4729ad8537 Gitweb: http://git.kernel.org/tip/46f920d8a970cf102e18f25814a4ff4729ad8537 Author: Axel Lin AuthorDate: Sun, 20 Mar 2016 20:44:05 +0800 Committer: Thomas Gleixner CommitDate: Sun, 20 Mar 2016 20:08:28 +0100 irqchip/tegra: Switch

[PATCH] irqchip: tegra: Switch to use irq_domain_free_irqs_common

Current code calls irq_domain_alloc_irqs_parent() in .alloc, so it should call irq_domain_free_irqs_parent() accordingly in .free. Fix it by switching to use irq_domain_free_irqs_common() instead of open-coded. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/irqchip/irq-tegra.

[PATCH] irqchip: tegra: Switch to use irq_domain_free_irqs_common

Current code calls irq_domain_alloc_irqs_parent() in .alloc, so it should call irq_domain_free_irqs_parent() accordingly in .free. Fix it by switching to use irq_domain_free_irqs_common() instead of open-coded. Signed-off-by: Axel Lin --- drivers/irqchip/irq-tegra.c | 14 +- 1 file

[PATCH 2/2] gpio: xgene-sb: Use irq_domain_free_irqs_common instead of open coded

Current code calls irq_domain_alloc_irqs_parent() in .alloc, so it should call irq_domain_free_irqs_parent() accordingly in .free. Fix it by switching to use irq_domain_free_irqs_common() instead. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/gpio/gpio-xgene-sb.

<    1   2   3   4   5   6   7   8   9   10   >