[PATCH v3 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc()

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide managed variants of bitmap_alloc() and bitmap_zalloc(). Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 8 lib/bitmap.c | 33 + 2 files changed, 41 insertions

[PATCH v3 06/11] lib: bitmap: order includes alphabetically

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: order the includes in bitmap source files alphabetically. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 4 ++-- lib/bitmap.c | 9 + 2 files changed, 7 insertions

[PATCH v3 05/11] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The 'extern' keyword doesn't have any benefits in header files. Remove it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 115 - 1 file changed, 57 insertions(+), 58 deletions

[PATCH v3 01/11] configfs: increase the item name length

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 20 characters limit for item name is relatively small. Let's increase it to 32 to fit '04-committable-children' - a name we'll use in the sample code for committable items. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- include/linux/configfs.h | 2

[PATCH v3 04/11] samples: configfs: add a committable group

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add an example of using committable items to configfs samples. Each config item has two attributes: read-write 'storeme' which works similarly to other examples in this file and a read-only 'committed' attribute which changes its value between false and true depending

[PATCH v3 02/11] configfs: use (1UL << bit) for internal flags

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: use the (1UL << bit) for flag definitions. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- fs/configfs/configfs_internal.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v3 03/11] configfs: implement committable items

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This implements configfs committable items. We mostly follow the documentation except that we extend config_group_ops with uncommit_item() callback for reverting the changes made by commit_item(). Each committable group has two sub-directories: pending and live. New

[PATCH v3 00/11] gpio: implement the configfs testing module

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds a new GPIO testing module based on configfs committable items and sysfs. The goal is to provide a testing driver that will be configurable at runtime (won't need module reload) and easily extensible. The control over the attributes is also much more

Re: [GIT PULL] gpio: fixes for v5.12-rc3

2021-03-09 Thread Bartosz Golaszewski
On Tue, Mar 9, 2021 at 4:34 PM Bartosz Golaszewski wrote: > > Linus, > > Here's a bunch of fixes for the GPIO subsystem. We have two regressions in the > core code spotted right after the merge window, a series of fixes for ACPI > GPIO > and a subsequent fix for a relat

[GIT PULL] gpio: fixes for v5.12-rc3

2021-03-09 Thread Bartosz Golaszewski
-line-names to remedy a regression in stm32mp151. Please pull! Best Regards, Bartosz Golaszewski The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux

Re: [PATCH v2 05/12] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-09 Thread Bartosz Golaszewski
On Thu, Mar 4, 2021 at 1:59 PM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 11:24:45AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The 'extern' keyword doesn't have any benefits in header files. Remove it. > > Reviewed-by: Andy Shev

Re: [PATCH v3 0/5] gpiolib: switch to fwnode in the core

2021-03-09 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 8:52 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 09:36:52PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 08:29:27PM +0100, Bartosz Golaszewski wrote: > > > On Mon, Mar 8, 2021 at 8:26 PM Rafael J. Wysocki > > > wrot

Re: [PATCH v3 0/5] gpiolib: switch to fwnode in the core

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 8:26 PM Rafael J. Wysocki wrote: > > On Mon, Mar 8, 2021 at 8:23 PM Bartosz Golaszewski > wrote: > > > > On Mon, Mar 8, 2021 at 7:22 PM Rafael J. Wysocki wrote: > > > > > > On Thu, Mar 4, 2021 at 9:13 PM Andy Shevchenko > >

Re: [PATCH v3 0/5] gpiolib: switch to fwnode in the core

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 7:22 PM Rafael J. Wysocki wrote: > > On Thu, Mar 4, 2021 at 9:13 PM Andy Shevchenko > wrote: > > > > GPIO library uses of_node and fwnode in the core in non-unified way. > > The series cleans this up and improves IRQ domain creation for non-OF cases > > where currently the

Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

2021-03-08 Thread Bartosz Golaszewski
On Thu, Mar 4, 2021 at 12:01 PM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote: > > On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko > > wrote: > > > At least one module will benefit from using next_arg() helper. > > > Let's export it for that module

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote: > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko > > wrote: > > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote: &g

Re: [PATCH] docs: driver-api: gpio: consumer: Mark another line of code as such

2021-03-08 Thread Bartosz Golaszewski
On Wed, Mar 3, 2021 at 9:43 PM Jonathan Neuschäfer wrote: > > Make it so that this #include line is rendered in monospace, like other > code blocks. > > Signed-off-by: Jonathan Neuschäfer > --- > Documentation/driver-api/gpio/consumer.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote: > > On Fri, Mar 5, 2021 at 11:15 AM Andy Shevchenko > > wrote: > > > On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote:

Re: [PATCH 1/3] mfd: lp87565: fix typo in define names

2021-03-08 Thread Bartosz Golaszewski
On Fri, Feb 19, 2021 at 11:39 PM Luca Ceresoli wrote: > > "GOIO" should be "GPIO" here. > > Signed-off-by: Luca Ceresoli > --- For GPIO part: Acked-by: Bartosz Golaszewski

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-08 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 11:15 AM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote: > > On Thu, Mar 4, 2021 at 2:15 PM Andy Shevchenko > > wrote: > > > On Thu, Mar 04, 2021 at 11:24:49AM +0100, Bartosz Golaszewski w

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 12:45 PM Andy Shevchenko wrote: > > On Sun, Mar 07, 2021 at 06:14:49PM +0200, Andy Shevchenko wrote: > > On Sun, Mar 7, 2021 at 4:22 PM Bartosz Golaszewski > > wrote: > > > On Fri, Mar 5, 2021 at 1:02 PM Andy Shevchenko > > > wrote: &

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-08 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 4:01 PM Greg KH wrote: > > On Fri, Mar 05, 2021 at 03:20:27PM +0100, Bartosz Golaszewski wrote: > > On Fri, Mar 5, 2021 at 12:27 PM Greg KH wrote: > > > > > > On Fri, Mar 05, 2021 at 11:58:18AM +0100, Bartosz Golaszewski wrote: > > >

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-07 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 1:02 PM Andy Shevchenko wrote: > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for > pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c > and iterates over all of its DT subnodes

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 12:27 PM Greg KH wrote: > > On Fri, Mar 05, 2021 at 11:58:18AM +0100, Bartosz Golaszewski wrote: > > On Fri, Mar 5, 2021 at 11:24 AM Greg KH wrote: > > > > > > On Fri, Mar 05, 2021 at 10:16:10AM +0100, Bartosz Golaszewski wrote: > > >

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 11:24 AM Greg KH wrote: > > On Fri, Mar 05, 2021 at 10:16:10AM +0100, Bartosz Golaszewski wrote: > > On Fri, Mar 5, 2021 at 9:55 AM Greg KH wrote: > > > > > > On Fri, Mar 05, 2021 at 09:45:41AM +0100, Bartosz Golaszewski wrote: > > >

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 9:55 AM Greg KH wrote: > > On Fri, Mar 05, 2021 at 09:45:41AM +0100, Bartosz Golaszewski wrote: > > On Fri, Mar 5, 2021 at 9:34 AM Greg KH wrote: > > > > > > On Fri, Mar 05, 2021 at 09:18:30AM +0100, Geert Uytterhoeven wrote: > > >

Re: [PATCH v2 08/12] drivers: export device_is_bound()

2021-03-05 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 9:34 AM Greg KH wrote: > > On Fri, Mar 05, 2021 at 09:18:30AM +0100, Geert Uytterhoeven wrote: > > CC Greg > > > > On Thu, Mar 4, 2021 at 11:30 AM Bartosz Golaszewski wrote: > > > > > > From: Bartosz Golaszewski > > &g

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-04 Thread Bartosz Golaszewski
On Thu, Mar 4, 2021 at 2:15 PM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 11:24:49AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Implement a new, modern GPIO testing module controlled by configfs > > attributes instead

[PATCH v2 10/12] selftests: gpio: provide a helper for reading chip info

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to retrieve chip properties from the GPIO character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v2 07/12] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc()

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide managed variants of bitmap_alloc() and bitmap_zalloc(). Signed-off-by: Bartosz Golaszewski --- include/linux/bitmap.h | 10 ++ lib/bitmap.c | 33 + 2 files changed, 43 insertions(+) diff --git a/include/linux

[PATCH v2 12/12] selftests: gpio: add test cases for gpio-sim

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a set of tests for the new gpio-sim module. This is a pure shell test-suite and uses the helper programs available in the gpio selftests directory. These test-cases only test the functionalities exposed by the gpio-sim driver, not those handled by core gpiolib code

[PATCH v2 08/12] drivers: export device_is_bound()

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Export the symbol for device_is_bound() so that we can use it in gpio-sim to check if the simulated GPIO chip is bound before fetching its driver data from configfs callbacks in order to retrieve the name of the GPIO chip device. Signed-off-by: Bartosz Golaszewski

[PATCH v2 09/12] gpio: sim: new testing module

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Implement a new, modern GPIO testing module controlled by configfs attributes instead of module parameters. The goal of this driver is to provide a replacement for gpio-mockup that will be easily extensible with new features and doesn't require reloading the module

[PATCH v2 05/12] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The 'extern' keyword doesn't have any benefits in header files. Remove it. Signed-off-by: Bartosz Golaszewski --- include/linux/bitmap.h | 115 - 1 file changed, 57 insertions(+), 58 deletions(-) diff --git a/include/linux

[PATCH v2 11/12] selftests: gpio: add a helper for reading GPIO line names

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to read GPIO line names from the character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v2 03/12] configfs: implement committable items

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This implements configfs committable items. We mostly follow the documentation except that we extend config_group_ops with uncommit_item() callback for reverting the changes made by commit_item(). Each committable group has two sub-directories: pending and live. New

[PATCH v2 06/12] lib: bitmap: order includes alphabetically

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: order the includes in bitmap source files alphabetically. Signed-off-by: Bartosz Golaszewski --- include/linux/bitmap.h | 4 ++-- lib/bitmap.c | 9 + 2 files changed, 7 insertions(+), 6 deletions(-) diff

[PATCH v2 04/12] samples: configfs: add a committable group

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add an example of using committable items to configfs samples. Each config item has two attributes: read-write 'storeme' which works similarly to other examples in this file and a read-only 'committed' attribute which changes its value between false and true depending

[PATCH v2 02/12] configfs: use (1UL << bit) for internal flags

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: use the (1UL << bit) for flag definitions. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- fs/configfs/configfs_internal.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v2 00/12] gpio: implement the configfs testing module

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds a new GPIO testing module based on configfs committable items and sysfs. The goal is to provide a testing driver that will be configurable at runtime (won't need module reload) and easily extensible. The control over the attributes is also much more

[PATCH v2 01/12] configfs: increase the item name length

2021-03-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 20 characters limit for item name is relatively small. Let's increase it to 32 to fit '04-committable-children' - a name we'll use in the sample code for committable items. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- include/linux/configfs.h | 2

Re: [PATCH v2 0/3] Introduce the for_each_set_clump macro

2021-03-03 Thread Bartosz Golaszewski
On Fri, Feb 12, 2021 at 2:19 PM Syed Nayyar Waris wrote: > > Hello Bartosz, > > Since this patchset primarily affects GPIO drivers, would you like > to pick it up through your GPIO tree? > Sure, as soon as you figure out what's wrong with the xilinx patch. Could you also follow William's

Re: [PATCH] selftests: gpio: update .gitignore

2021-03-02 Thread Bartosz Golaszewski
On Tue, Mar 2, 2021 at 4:27 PM Shuah Khan wrote: > > On 3/2/21 7:44 AM, Linus Walleij wrote: > > On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski wrote: > > > >> From: Bartosz Golaszewski > >> > >> The executable that we build for GPIO selftest

Re: [PATCH v1 1/3] gpiolib: acpi: Add ACPI_GPIO_QUIRK_ABSOLUTE_NUMBER quirk

2021-03-02 Thread Bartosz Golaszewski
On Tue, Mar 2, 2021 at 4:21 PM Andy Shevchenko wrote: > > On Tue, Mar 02, 2021 at 05:14:30PM +0200, Mika Westerberg wrote: > > On Tue, Mar 02, 2021 at 05:09:24PM +0200, Andy Shevchenko wrote: > > > On Tue, Mar 02, 2021 at 03:48:43PM +0100, Linus Walleij wrote: > > > > On Thu, Feb 25, 2021 at 5:33

Re: [PATCH] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

2021-03-02 Thread Bartosz Golaszewski
kb: > desc_data.len = skb_tailroom(new_skb); > desc_data.skb = new_skb; > -- > 2.18.0 > Thanks for spotting that. Maybe also update the commit so that it says: "it's safe to unmap the old skb"? Would make the thing clearer IMO. In any case: Acked-by: Bartosz Golaszewski Bartosz

Re: [PATCH v2 0/2] gpio: regression fixes

2021-03-01 Thread Bartosz Golaszewski
On Mon, Mar 1, 2021 at 5:57 PM Andy Shevchenko wrote: > > On Mon, Mar 1, 2021 at 11:13 AM Bartosz Golaszewski > wrote: > > On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold wrote: > > > > > > Here's a fix for a regression in 5.12 due to the new stub-driver hack, &

[RESEND PATCH] irq/irq_sim: shrink devm_irq_domain_create_sim()

2021-03-01 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We don't have to use a custom devres structure if all we manage is a single pointer - we can use devm_add_action_or_reset() for that and shrink the code a bit. Signed-off-by: Bartosz Golaszewski --- kernel/irq/irq_sim.c | 31 --- 1 file

Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT

2021-03-01 Thread Bartosz Golaszewski
On Thu, Feb 25, 2021 at 4:07 PM Andy Shevchenko wrote: > > On Tue, Feb 23, 2021 at 01:51:53PM +0200, Andy Shevchenko wrote: > > On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote: > > > fixed the following coccicheck: > > > ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no

Re: [PATCH v2 0/2] gpio: regression fixes

2021-03-01 Thread Bartosz Golaszewski
On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold wrote: > > Here's a fix for a regression in 5.12 due to the new stub-driver hack, > and a fix for potential list corruption due to missing locking which has > been there since the introduction of the character-device interface in > 4.6. > > Johan > >

[PATCH] selftests: gpio: update .gitignore

2021-02-24 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The executable that we build for GPIO selftests was renamed to gpio-mockup-cdev. Let's update .gitignore so that we don't show it as an untracked file. Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation") Signed-off-by: Bartosz G

[GIT PULL] gpio: updates for v5.12

2021-02-22 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Linus, This is the pull request from the GPIO subsystem for this merge window. It's been a relatively calm release cycle and we're actually removing more code than we're adding. All patches have been in next with most having spent several weeks there. The PR is rebased

Re: [PATCH v2 6/8] cxl/mem: Enable commands via CEL

2021-02-16 Thread Bartosz Golaszewski
On Thu, Feb 11, 2021 at 1:12 PM Jonathan Cameron wrote: > [snip!] > > > > @@ -869,6 +891,14 @@ static struct cxl_mem *cxl_mem_create(struct pci_dev > > *pdev, u32 reg_lo, > > mutex_init(>mbox_mutex); > > cxlm->pdev = pdev; > > cxlm->regs = regs + offset; > > +

[GIT PULL] gpio: fixes for v5.11

2021-02-11 Thread Bartosz Golaszewski
Linus, This is hopefully the last batch of fixes for this release cycle. We have a minor fix for a Kconfig regression as well as fixes for older bugs in gpio-ep93xx. Please pull, Bartosz The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3: Linux 5.11-rc7 (2021-02-07

Re: [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support

2021-02-11 Thread Bartosz Golaszewski
On Mon, Feb 8, 2021 at 11:22 PM Enrico Weigelt, metux IT consult wrote: > > Add support for probing via device tree. > --- > drivers/gpio/gpio-amd-fch.c | 58 > + > include/dt-bindings/gpio/amd-fch-gpio.h | 36 +++ >

Re: [PATCH v11 7/7] at24: Support probing while in non-zero ACPI D state

2021-02-11 Thread Bartosz Golaszewski
ute probe while being in ACPI D state other than 0 (which means fully > powered on). > > Signed-off-by: Sakari Ailus > Reviewed-by: Tomasz Figa > --- I like this much better now, thanks! Acked-by: Bartosz Golaszewski

Re: [PATCH v6 0/7] gpio: ep93xx: fixes series patch

2021-02-10 Thread Bartosz Golaszewski
On Tue, Feb 9, 2021 at 2:31 PM Nikita Shubin wrote: > > v2: > https://lore.kernel.org/linux-gpio/20210127104617.1173-1-nikita.shu...@maquefel.me/ > > v3: > https://lore.kernel.org/linux-gpio/20210128122123.25341-1-nikita.shu...@maquefel.me/ > > v4: >

Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally

2021-02-10 Thread Bartosz Golaszewski
On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven wrote: > > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS, > and ask the user in case of compile-testing. > > Fixes: 6876ca311bfca5d7 ("gpio: mxs: add

Re: [PATCH] gpio: uapi: use the preferred SPDX license identifier

2021-02-10 Thread Bartosz Golaszewski
On Thu, Feb 4, 2021 at 4:29 PM Greg Kroah-Hartman wrote: > > On Thu, Feb 04, 2021 at 04:17:51PM +0100, Bartosz Golaszewski wrote: > > On Thu, Feb 4, 2021 at 3:35 PM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Feb 04, 2021 at 03:15:50PM +0100, Bartosz Go

Re: [PATCH v10 7/7] at24: Support probing while off

2021-02-10 Thread Bartosz Golaszewski
> > > > On Tue, Feb 9, 2021 at 5:23 PM Sakari Ailus > > > > wrote: > > > > > > > > > > Hi Bartosz, Rafael, > > > > > > > > > > On Tue, Feb 09, 2021 at 04:49:37PM +0100, Bartosz Golaszewski wrote: > > > &g

[tip: timers/core] clocksource/drivers/davinci: Move pr_fmt() before the includes

2021-02-10 Thread tip-bot2 for Bartosz Golaszewski
The following commit has been merged into the timers/core branch of tip: Commit-ID: 98509310e490bf3de13c96fbbbca8ef4af9db010 Gitweb: https://git.kernel.org/tip/98509310e490bf3de13c96fbbbca8ef4af9db010 Author:Bartosz Golaszewski AuthorDate:Mon, 11 Jan 2021 15:08:14 +01:00

Re: [PATCH v10 7/7] at24: Support probing while off

2021-02-09 Thread Bartosz Golaszewski
On Mon, Feb 8, 2021 at 5:54 PM Rafael J. Wysocki wrote: > > On Mon, Feb 8, 2021 at 5:44 PM Bartosz Golaszewski > wrote: > > > > On Fri, Feb 5, 2021 at 2:25 PM Sakari Ailus > > wrote: > > > > > > In certain use cases (where the chip is part of

Re: [PATCH v10 7/7] at24: Support probing while off

2021-02-08 Thread Bartosz Golaszewski
or this use-case and I've been saying that for 10 versions now with everyone just ignoring my remarks. :/ Acked-by: Bartosz Golaszewski

Re: [PATCH] gpiolib: cdev: convert stream-like files from

2021-02-07 Thread Bartosz Golaszewski
On Sun, Feb 7, 2021 at 10:00 AM Yang Li wrote: > > Eliminate the following coccicheck warning: > ./drivers/gpio/gpiolib-cdev.c:2307:7-23: WARNING: gpio_fileops: .read() > has stream semantic; safe to change nonseekable_open -> stream_open. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li >

Re: [PATCH v1] gpiolib: Don't probe gpio_device if it's not the primary device

2021-02-05 Thread Bartosz Golaszewski
*/ > + if (dev->fwnode && dev->fwnode->dev != dev) > + return 0; > + return 1; > +} > + > static int gpio_stub_drv_probe(struct device *dev) > { > /* > -- > 2.30.0.365.g02bc693789-goog > Acked-by: Bartosz Golaszewski

Re: [PATCH v4 0/7] gpio: ep93xx: fixes series patch

2021-02-05 Thread Bartosz Golaszewski
Nikita, please include the review tags from previous series in the future. Linus has left his Reviewed-by: under v3. Bart On Fri, Feb 5, 2021 at 9:05 AM Nikita Shubin wrote: > > v2: > https://lore.kernel.org/linux-gpio/20210127104617.1173-1-nikita.shu...@maquefel.me/ > > v3: >

Re: [PATCH V5 0/5] gpio-xilinx: Update on xilinx gpio driver

2021-02-05 Thread Bartosz Golaszewski
On Fri, Jan 29, 2021 at 3:27 PM Srinivas Neeli wrote: > > This patch series does the following: > -Simplify with dev_err_probe(). > -Reduce spinlock array to array. > -Add interrupt support > -Add support for suspend and resume > -Add check for gpio-width > --- > Changes in V5: > -Removed

Re: [PATCH] gpio: uapi: use the preferred SPDX license identifier

2021-02-04 Thread Bartosz Golaszewski
On Thu, Feb 4, 2021 at 3:35 PM Greg Kroah-Hartman wrote: > > On Thu, Feb 04, 2021 at 03:15:50PM +0100, Bartosz Golaszewski wrote: > > On Thu, Feb 4, 2021 at 2:47 PM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Feb 04, 2021 at 01:43:57PM +0100, Bar

Re: [PATCH] gpio: uapi: use the preferred SPDX license identifier

2021-02-04 Thread Bartosz Golaszewski
On Thu, Feb 4, 2021 at 2:47 PM Greg Kroah-Hartman wrote: > > On Thu, Feb 04, 2021 at 01:43:57PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > GPL-2.0 license identifier is deprecated, let's use the preferred > > identifier: GPL-2.0-only.

[PATCH] gpio: uapi: use the preferred SPDX license identifier

2021-02-04 Thread Bartosz Golaszewski
From: Bartosz Golaszewski GPL-2.0 license identifier is deprecated, let's use the preferred identifier: GPL-2.0-only. Signed-off-by: Bartosz Golaszewski --- Hi Kent, Greg, I started working on making libgpiod licensing reuse-compliant and noticed that the reuse-tool is telling me that the GPL

Re: [PATCH] irq/irq_sim: shrink devm_irq_domain_create_sim()

2021-02-04 Thread Bartosz Golaszewski
On Tue, Jan 5, 2021 at 2:56 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > We don't have to use a custom devres structure if all we manage is a > single pointer - we can use devm_add_action_or_reset() for that and > shrink the code a bit. > > Signed-off

Re: [PATCH] clocksource: davinci: move pr_fmt() before the includes

2021-02-04 Thread Bartosz Golaszewski
On Mon, Jan 11, 2021 at 3:08 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > We no longer need to undef pr_fmt if we define our own before including > any headers. > > Signed-off-by: Bartosz Golaszewski > --- > drivers/clocksource/timer-davinci.c | 5

[GIT PULL] gpio: fixes for v5.11-rc7

2021-02-03 Thread Bartosz Golaszewski
Linus, here are some more fixes from the GPIO subsystem for this release. This time it's only core fixes. Details are in the signed tag. Please pull, Bartosz The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available

Re: [PATCH] gpio: pca953x: add support for open drain pins on PCAL6524

2021-02-02 Thread Bartosz Golaszewski
On Thu, Jan 28, 2021 at 4:36 PM Alban Bedel wrote: > > From a quick glance at various datasheet the PCAL6524 seems to be the > only chip in this familly that support setting the drive mode of > single pins. Other chips either don't support it at all, or can only > set the drive mode of whole

Re: [PATCH] gpiolib: free device name on error path to fix kmemleak

2021-02-01 Thread Bartosz Golaszewski
On Sat, Jan 30, 2021 at 4:45 AM quanyang.wang wrote: > > Hi Andy, > > On 1/30/21 1:26 AM, Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 2:01 PM wrote: > >> From: Quanyang Wang > >> > >> In gpiochip_add_data_with_key, we should check the return value of > >> dev_set_name to ensure that

Re: [PATCH 8/8] gpio: sim: new testing module

2021-02-01 Thread Bartosz Golaszewski
On Mon, Feb 1, 2021 at 1:49 PM Andy Shevchenko wrote: > > On Mon, Feb 01, 2021 at 11:59:31AM +0100, Bartosz Golaszewski wrote: > > On Mon, Feb 1, 2021 at 11:28 AM Andy Shevchenko > > wrote: > > > On Sat, Jan 30, 2021 at 09:37:55PM +0100, Bartosz Golaszewski wrote: &

Re: [PATCH 0/8] gpio: implement the configfs testing module

2021-02-01 Thread Bartosz Golaszewski
On Mon, Feb 1, 2021 at 10:24 AM Uwe Kleine-König wrote: > > On Mon, Feb 01, 2021 at 09:37:30AM +0100, Bartosz Golaszewski wrote: > > On Sat, Jan 30, 2021 at 10:20 PM Uwe Kleine-König > > wrote: > > > > > > Hello, > > > > > > On Fri, Jan 2

Re: [PATCH 8/8] gpio: sim: new testing module

2021-02-01 Thread Bartosz Golaszewski
On Mon, Feb 1, 2021 at 11:28 AM Andy Shevchenko wrote: > > On Sat, Jan 30, 2021 at 09:37:55PM +0100, Bartosz Golaszewski wrote: > > On Fri, Jan 29, 2021 at 4:57 PM Andy Shevchenko > > wrote: > > > On Fri, Jan 29, 2021 at 02:46:24PM +0100, Bartosz Golaszewski wrote: &g

Re: [PATCH 2/2] ARM: dts: am335x-boneblack.dts: unique gpio-line-names

2021-02-01 Thread Bartosz Golaszewski
t; to the gpio line. "[NC]" is also renamed to the standard "NC" name to > represent "not connected". > > [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ > > Signed-off-by: Drew Fustini > --- Reviewed-by: Bartosz Golaszewski

Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

2021-02-01 Thread Bartosz Golaszewski
t; to the gpio line. "[NC]" is also renamed to the standard "NC" name to > represent "not connected". > > [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/ > > Signed-off-by: Drew Fustini > --- Reviewed-by: Bartosz Golaszewski

Re: [PATCH v9 7/7] at24: Support probing while off

2021-02-01 Thread Bartosz Golaszewski
On Fri, Jan 29, 2021 at 1:20 PM Sakari Ailus wrote: > > Hi Bartosz, > > Thanks for the review. > > On Fri, Jan 29, 2021 at 11:56:00AM +0100, Bartosz Golaszewski wrote: > > On Fri, Jan 29, 2021 at 12:27 AM Sakari Ailus > > wrote: > > > > > &

Re: [PATCH 8/8] gpio: sim: new testing module

2021-02-01 Thread Bartosz Golaszewski
On Sun, Jan 31, 2021 at 1:43 AM Kent Gibson wrote: > > On Sat, Jan 30, 2021 at 09:37:55PM +0100, Bartosz Golaszewski wrote: > > On Fri, Jan 29, 2021 at 4:57 PM Andy Shevchenko > > wrote: > > > > > > On Fri, Jan 29, 2021 at 02:46:24PM +0100, Bartosz Gola

Re: [PATCH 0/8] gpio: implement the configfs testing module

2021-02-01 Thread Bartosz Golaszewski
On Sat, Jan 30, 2021 at 10:20 PM Uwe Kleine-König wrote: > > Hello, > > On Fri, Jan 29, 2021 at 02:46:16PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > This series adds a new GPIO testing module based on configfs committable >

Re: [PATCH 8/8] gpio: sim: new testing module

2021-01-30 Thread Bartosz Golaszewski
On Fri, Jan 29, 2021 at 4:57 PM Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 02:46:24PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Implement a new, modern GPIO testing module controlled by configfs > > attributes instead

Re: [PATCH 5/8] lib: bitmap: remove the 'extern' keyword from function declarations

2021-01-30 Thread Bartosz Golaszewski
On Fri, Jan 29, 2021 at 4:59 PM Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 02:46:21PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The 'extern' keyword doesn't have any benefits in header files. Remove it. > > > +int __bitmap_e

Re: [PATCH] eeprom: at24: Add permission to write_timeout

2021-01-28 Thread Bartosz Golaszewski
On Thu, Jan 28, 2021 at 10:12 AM Greg Kroah-Hartman wrote: > > On Thu, Jan 28, 2021 at 10:04:42AM +0100, Bartosz Golaszewski wrote: > > On Thu, Jan 28, 2021 at 9:10 AM Jenny Ho wrote: > > > > > > Need to change timeout time for different use > > > cases t

Re: [PATCH] eeprom: at24: Add permission to write_timeout

2021-01-28 Thread Bartosz Golaszewski
On Thu, Jan 28, 2021 at 9:10 AM Jenny Ho wrote: > > Need to change timeout time for different use > cases to prevent I2C error cases. Open the api > and allow Read/Write permission to write_timeout > > Signed-off-by: Jenny Ho > --- > drivers/misc/eeprom/at24.c | 2 +- > 1 file changed, 1

Re: [PATCH] gpiolib: cdev: clear debounce period if line set to output

2021-01-27 Thread Bartosz Golaszewski
On Thu, Jan 21, 2021 at 3:11 PM Kent Gibson wrote: > > When set_config changes a line from input to output debounce is > implicitly disabled, as debounce makes no sense for outputs, but the > debounce period is not being cleared and is still reported in the > line info. > > So clear the debounce

Re: [PATCH v1] gpio: tegra: Fix irq_set_affinity

2021-01-27 Thread Bartosz Golaszewski
On Fri, Jan 22, 2021 at 1:56 PM Linus Walleij wrote: > > On Wed, Jan 20, 2021 at 1:46 AM Dmitry Osipenko wrote: > > > The irq_set_affinity callback should not be set if parent IRQ domain > > doesn't present because gpio-tegra driver callback fails in this case, > > causing a noisy error messages

Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module

2021-01-27 Thread Bartosz Golaszewski
On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko wrote: > > Hi, > > This small series adds modularization support to the gpio-tegra driver, > i.e. driver now could be built as a loadable kernel module. > > Dmitry Osipenko (3): > gpio: tegra: Use debugfs_create_devm_seqfile() > gpio: tegra:

Re: [PATCH v1] gpio: tegra: Improve formatting of the code

2021-01-27 Thread Bartosz Golaszewski
On Fri, Jan 22, 2021 at 9:00 PM Dmitry Osipenko wrote: > > Don't cross 80 chars of line length in order to keep formatting of the > code consistent. > > Signed-off-by: Dmitry Osipenko > --- Patch applied, thanks! Bartosz

Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default

2021-01-27 Thread Bartosz Golaszewski
tps://lore.kernel.org/lkml/20201014191235.7f71fcb4@xhacker.debian/ > > [2] - > > https://lore.kernel.org/lkml/e28e1f38d87c12a3c714a6573beba...@kernel.org/ > > Cc: Marc Zyngier > > Cc: Jisheng Zhang > > Cc: Kever Yang > > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > > As this commit is in my driver-core git tree, can I just take this in > the same tree? Can I get an ack from the maintainer for this? > > thanks, > > greg k-h Go ahead. Acked-by: Bartosz Golaszewski

Re: [PATCH v4 0/4] configfs: implement committable items and add sample code

2021-01-27 Thread Bartosz Golaszewski
han I do. Hi Joel, Gentle ping about this series. Since the user facing interface is mostly agreed upon, I already started working on the module using it - it would be great if we could get it in for v5.12. Best Regards, Bartosz Golaszewski

Re: [PATCH v2 -next] gpio: tegra186: convert comma to semicolon

2021-01-22 Thread Bartosz Golaszewski
On Fri, Jan 8, 2021 at 10:23 AM Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/gpio/gpio-tegra186.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-tegra186.c

Re: [PATCH v2 -next] gpio: vx855: convert comma to semicolon

2021-01-22 Thread Bartosz Golaszewski
On Fri, Jan 8, 2021 at 10:23 AM Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/gpio/gpio-vx855.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-vx855.c

Re: [PATCH v2 -next] gpio: max77620: convert comma to semicolon

2021-01-22 Thread Bartosz Golaszewski
On Fri, Jan 8, 2021 at 10:23 AM Zheng Yongjun wrote: > > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/gpio/gpio-max77620.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-max77620.c

Re: [PATCH 1/5] gpio: remove zte zx driver

2021-01-22 Thread Bartosz Golaszewski
On Wed, Jan 20, 2021 at 2:20 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The zte zx platform is getting removed, so this driver is no > longer needed. > > Cc: Jun Nie > Cc: Shawn Guo > Signed-off-by: Arnd Bergmann Applied, thanks! Bartosz

Re: [PATCH] gpio: uapi: fix line info flags description

2021-01-22 Thread Bartosz Golaszewski
On Tue, Jan 19, 2021 at 2:58 PM Kent Gibson wrote: > > The description of the flags field of the struct gpio_v2_line_info > mentions "the GPIO lines" while the info only applies to an individual > GPIO line. This was accidentally changed from "the GPIO line" during > formatting improvements. > >

[PATCH] gpio: mockup: tweak the Kconfig help text

2021-01-21 Thread Bartosz Golaszewski
From: Bartosz Golaszewski gpio-mockup doesn't require SYSFS to be selected so drop that bit from the Kconfig text. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig

[GIT PULL] gpio: fixes for v5.11-rc5

2021-01-21 Thread Bartosz Golaszewski
Hello Linus, This is my first pull-request sent directly to you. It contains a couple GPIO fixes for this release cycle - nothing too urgent. Details are in the signed tag. Please pull, Bartosz Golaszewski The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux

Re: [PATCH v3 0/7] selftests: gpio: rework and port to GPIO uAPI v2

2021-01-21 Thread Bartosz Golaszewski
On Tue, Jan 19, 2021 at 1:31 PM Kent Gibson wrote: > > Initially I just wanted to port the selftests to the latest GPIO uAPI, > but on finding that, due to dependency issues, the selftests are not built > for the buildroot environments that I do most of my GPIO testing in, I > decided to take a

<    1   2   3   4   5   6   7   8   9   10   >