code changes, the md5sums pre and post applying
this patch are the same. The at91 should be natively little endian
anyway.
Signed-off-by: Ben Dooks
---
Cc: Sebastian Reichel
Cc: Nicolas Ferre
Cc: Alexandre Belloni
Cc: Ludovic Desroches
Cc: linux...@vger.kernel.org
Cc: linux-arm-ker
/renesas_usbhs/common.c:175:39: warning: incorrect type in argument
3 (different base types)
drivers/usb/renesas_usbhs/common.c:175:39:expected unsigned short
[usertype] data
Note. I belive this to be correct, and should be a no-op on arm.
Signed-off-by: Ben Dooks
---
Cc: Greg Kroah-Hartman
Cc
mm.h:32:20: warning: symbol 'malloc_count' was not
declared. Should it be static?
arch/arm/boot/compressed/decompress.c:59:5: warning: symbol 'do_decompress' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Russell King
Cc: linux-arm-ker...@lists.
/renesas_usbhs/mod_gadget.c:335:14:got restricted __le16
[usertype]
Signed-off-by: Ben Dooks
---
Cc: Greg Kroah-Hartman
Cc: Yoshihiro Shimoda
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/usb/renesas_usbhs/mod_gadget.c | 2 +-
1 file changed, 1 insertion(+), 1
-debugfs.c:292:57:got restricted __le32 [usertype]
tx_info
Signed-off-by: Ben Dooks
---
Cc: Mathias Nyman
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
.. (open list)
---
drivers/usb/host/xhci-debugfs.c | 24
1 file changed, 12
/musb_core.c:390:56:got void [noderef] *addr
Signed-off-by: Ben Dooks
---
Cc: Bin Liu
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/usb/musb/musb_trace.h | 33 +
1 file changed, 21 insertions(+), 12
The hcd pointer in ohci_hcd_nxp_probe() is
being initialised with a 0, so fix to NULL to
avoid the following sparse warning:
drivers/usb/host/ohci-nxp.c:153:31: warning: Using plain integer as NULL pointer
Signed-off-by: Ben Dooks
---
Cc: Vladimir Zapolskiy
Cc: Sylvain Lemieux
Cc: Alan Stern
The stm_thermal_pm_ops struct is not exported to any
other units, so make it static to avoid the following
sparse warning:
drivers/thermal/st/stm_thermal.c:599:1: warning: symbol 'stm_thermal_pm_ops'
was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Zhang Rui
: obsolete array initializer, use C99
syntax
drivers/soc/imx/gpc.c:278:30: warning: obsolete array initializer, use C99
syntax
Signed-off-by: Ben Dooks
---
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: Pengutronix Kernel Team
Cc: Fabio Estevam
Cc: NXP Linux Team
Cc: linux-arm-ker...@lists.infradead.org
Cc
ng: symbol
'drm_fb_cma_get_gem_addr' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
drivers/gpu/drm
0: warning: symbol 'pcie_dev_groups' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Bjorn Helgaas
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/pci/pci-sysfs.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drive
NULL
pointer
Signed-off-by: Ben Dooks
---
Cc: Kishon Vijay Abraham I
Cc: Maxime Coquelin
Cc: Alexandre Torgue
Cc: linux-kernel@vger.kernel.org
Cc: linux-st...@st-md-mailman.stormreply.com
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/phy/st/phy-stm32-usbphyc.c | 4 ++--
1 file changed, 2
normal' was not declared. Should it
be static?
Signed-off-by: Ben Dooks
---
Cc: "Paul E. McKenney"
Cc: Josh Triplett
Cc: Steven Rostedt
Cc: Mathieu Desnoyers
Cc: Lai Jiangshan
Cc: Joel Fernandes
Cc: r...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/rcupdate.h
Move fsnotify_mark_connector_cachep to fsnotify.h to properly
share it with the user in mark.c and avoid the following warning
from sparse:
fs/notify/mark.c:82:19: warning: symbol 'fsnotify_mark_connector_cachep' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc
The uidhash_table is not exported from this file, so
make it static to avoid the following sparse warning:
kernel/user.c:85:19: warning: symbol 'uidhash_table' was not declared. Should
it be static?
Signed-off-by: Ben Dooks
---
Cc: linux-kernel@vger.kernel.org
---
kernel/user.c | 2
The omap_sr_pdata is not declared but is exported, so add a
define for it to fix the following warning:
arch/arm/mach-omap2/pdata-quirks.c:609:36: warning: symbol 'omap_sr_pdata' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Kevin Hilman
Cc: Nishanth Menon
The moxtet_bus_type object is exported from the bus
driver, but not declared. Add a declaration for use
and to silence the following warning:
drivers/bus/moxtet.c:105:17: warning: symbol 'moxtet_bus_type' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Marek
The current_stateid is exported from nfs4state.c but not
declared in any of the headers. Add to nfs4_fs.h to
remove the following warning:
fs/nfs/nfs4state.c:80:20: warning: symbol 'current_stateid' was not declared.
Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Trond Myk
eclared. Should it be static?
kernel/trace/trace_entries.h:322:1: warning: symbol '__event_branch' was not
declared. Should it be static?
kernel/trace/trace_entries.h:343:1: warning: symbol 'event_class_ftrace_hwlat'
was not declared. Should it be static?
kernel/trace/trace_entr
ng: symbol 'rcu_segcblist_add_len' was
not declared. Should it be static?
kernel/rcu/rcu_segcblist.c:137:6: warning: symbol 'rcu_segcblist_xchg_len' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: "Paul E. McKenney"
Cc: Josh Triplett
Cc: Steven
/fcntl.c:303:34:got unsigned long long [usertype] *argp
fs/fcntl.c:307:40: warning: incorrect type in argument 2 (different address
spaces)
fs/fcntl.c:307:40:expected void const [noderef] *from
fs/fcntl.c:307:40:got unsigned long long [usertype] *argp
Signed-off-by: Ben Dooks
---
Cc
: incorrect type in argument 2 (different
address spaces)
fs/namespace.c:3550:36:expected char const [noderef] *name
fs/namespace.c:3550:36:got char const *to_pathname
Signed-off-by: Ben Dooks
---
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
:expected signed char [noderef] *__p
mm/vmstat.c:825:29:got signed char *
mm/vmstat.c:825:29: warning: incorrect type in initializer (different address
spaces)
mm/vmstat.c:825:29:expected signed char [noderef] *__p
mm/vmstat.c:825:29:got signed char *
Signed-off-by: Ben Dooks
---
Cc
[noderef] [usertype]
*info
Signed-off-by: Ben Dooks
---
Cc: linux-kernel@vger.kernel.org
---
kernel/signal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index c4da1ef56fdf..94985c756693 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
On 2019-10-12 05:44, Paul E. McKenney wrote:
On Fri, Oct 11, 2019 at 06:08:24PM +0100, Ben Dooks wrote:
The rcu_state, rcu_rnp_online_cpus and rcu_dynticks_curr_cpu_in_eqs
do not have declarations in a header. Add these to remove the
following sparse warnings:
kernel/rcu/tree.c:87:18
ng: symbol 'rcu_rnp_online_cpus' was not
declared. Should it be static?
kernel/rcu/tree.c:297:6: warning: symbol 'rcu_dynticks_curr_cpu_in_eqs' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: "Paul E. McKenney"
Cc: Josh Triplett
Cc: Steven
7;guard_bio_eod' was not declared. Should it
be static?
Signed-off-by: Ben Dooks
---
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
fs/buffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/buffer.c b/fs/buffer.c
index 86a38b979323..792f2
Include for the definition of open_related_ns.
Fixes the following sparse warning:
fs/nsfs.c:145:5: warning: symbol 'open_related_ns' was not declared. Should it
be static?
Signed-off-by: Ben Dooks
---
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: linux-kernel@vger.
Include "internal.h" for the ns_dentry_operations definiton.
Fixes the following spare warning:
fs/nsfs.c:41:32: warning: symbol 'ns_dentry_operations' was not declared.
Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.
const struct cpumask *cpu_corepower_mask(int cpu)
Signed-off-by: Ben Dooks
---
KernelVersion: 5.4-rc3
Cc: Russell King
Cc: linux-kernel@vger.kernel.org
---
arch/arm/kernel/topology.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
make spare just ignore
anything with the syscall_linkage attribute?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
On 09/10/2019 16:33, Christoph Hellwig wrote:
On Wed, Oct 09, 2019 at 03:06:37PM +0100, Ben Dooks wrote:
Add the definitions of arch_release_task_struct,
arch_task_cache_init and arch_dup_task_struct which
are used in kernel/fork.c but defined in various
architecture's .
So please lift
On 09/10/2019 18:51, Christoph Hellwig wrote:
On Wed, Oct 09, 2019 at 12:39:30PM +0100, Ben Dooks wrote:
When building for arm, cpuinfo_op generates a warning due
to no declaration. Since this is used in fs/proc/cpuinfo.c
and inconsitently declared across archiectures move the
declaration info
Include internal.h in d_path.c for the definition of
simple_dname to fix the following sparse warning:
fs/d_path.c:311:6: warning: symbol 'simple_dname' was not declared. Should it
be static?
Signed-off-by: Ben Dooks
---
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: li
Include for the definition of
is_vma_temporary_stack to fix the following
sparse warning:
mm/rmap.c:1673:6: warning: symbol 'is_vma_temporary_stack' was not declared.
Should it be static?
Signed-off-by: Ben Dooks
---
Cc: linux...@kvack.org
Cc: linux-kernel@vger.kernel.org
---
mm/
The to_mnt_ns() is not exported outside the file so
make it static to fix the following sparse warning:
fs/namespace.c:1731:22: warning: symbol 'to_mnt_ns' was not declared. Should it
be static?
Signed-off-by: Ben Dooks
---
Cc: Alexander Viro
Cc: linux-fsde...@vger.kernel.org
Cc: li
d. Should it be static?
kernel/fork.c:752:20: warning: symbol 'arch_task_cache_init' was not declared.
Should it be static?
kernel/fork.c:841:12: warning: symbol 'arch_dup_task_struct' was not declared.
Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Russell King
Cc: linu
tty/serial/sirfsoc_uart.h:189:30: warning: symbol 'sirfsoc_uart' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: Barry Song
Cc: linux-ser...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.
Cleanup the .driver setup to just do it once, to avoid
the following sparse warning:
drivers/net/ethernet/calxeda/xgmac.c:1914:10: warning: Initializer entry
defined twice
drivers/net/ethernet/calxeda/xgmac.c:1920:10: also defined here
Signed-off-by: Ben Dooks
---
Cc: "David S. Miller
warning:
arch/arm/kernel/setup.c:1320:29: warning: symbol 'cpuinfo_op' was not declared.
Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Greg Kroah-Hartman
Cc: Mark Salter
Cc: Aurelien Jacquiot
Cc: Heiko Carstens
Cc: Yoshinori Sato
Cc: Rich Felker
Cc: "David S. Mill
27; was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/drm_fb_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index a7ba5b4902d6..23e10075619f 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+
. Should it be static?
crypto/jitterentropy-kcapi.c:93:6: warning: symbol 'jent_get_nstime' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
crypto/jitterentropy-kcapi.c | 8 +---
crypto/jitterentropy.c | 7 +--
crypto/jitterentropy.h |
/engine/gr/gf100.c:760:1: warning: symbol
'gf100_gr_fecs_stop_ctxsw' was not declared. Should it be static?
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:2071:1: warning: symbol
'gf100_gr_ctor_fw_legacy' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Include the for the definition of
pm_wq to avoid the following warning:
kernel/power/main.c:890:25: warning: symbol 'pm_wq' was not declared. Should it
be static?
Signed-off-by: Ben Dooks
---
kernel/power/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/power/main.
The generic_file_vm_ops is defined in so include
it to fix the following warning:
mm/filemap.c:2717:35: warning: symbol 'generic_file_vm_ops' was not declared.
Should it be static?
Signed-off0-by: Ben Dooks
---
mm/filemap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/f
/
On 2019-09-25 19:43, Matthias Kaehlcke wrote:
devfreq has two functions with very similar names,
devfreq_update_status()
and devfreq_update_stats(). _update_status() currently updates
frequency transitions statistics, while _update_stats() retrieves the
device 'status'. The function names are
drivers/clk/hisilicon/clk-hi3670.c:808:69: warning: Using plain integer as NULL
pointer
drivers/clk/hisilicon/clk-hi3670.c:810:70: warning: Using plain integer as NULL
pointer
drivers/clk/hisilicon/clk-hi3670.c:812:69: warning: Using plain integer as NULL
pointer
Signed-off-by: Ben Dooks
drivers/clk/hisilicon/clk-hi3670.c:808:69: warning: Using plain integer as NULL
pointer
drivers/clk/hisilicon/clk-hi3670.c:810:70: warning: Using plain integer as NULL
pointer
drivers/clk/hisilicon/clk-hi3670.c:812:69: warning: Using plain integer as NULL
pointer
Signed-off-by: Ben Dooks
Move the pcibios_report_status to include to remove the
following sparse warning and to remove the extra definition in the
footbrdige dc21285.c driver:
arch/arm/kernel/bios32.c:59:6: warning: symbol 'pcibios_report_status' was not
declared. Should it be static?
Signed-off-by:
d. Should it be static?
arch/arm/mm/dma-mapping.c:2018:26: warning: symbol 'iommu_ops' was not
declared. Should it be static?
arch/arm/mm/dma-mapping.c:2040:26: warning: symbol 'iommu_coherent_ops' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
arc
The arch_timer_arch_init is defined in so include
that to fix the following sparse error:
arch/arm/kernel/arch_timer.c:31:12: warning: symbol 'arch_timer_arch_init' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
arch/arm/kernel/arch_timer.c | 1 +
1 file
The module_frob_arch_sections function is missing the header declaration
which is in so include that to fix the following
sparse warning:
arch/arm/kernel/module-plts.c:188:5: warning: symbol
'module_frob_arch_sections' was not declared. Should it be static?
Signed-off-by: Ben Dooks
The efi_rci2_sysfs_init() is not used outside of rci2-table.c so
make it static to silence the following sparse warning:
drivers/firmware/efi/rci2-table.c:79:12: warning: symbol 'efi_rci2_sysfs_init'
was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/firmwar
On 09/08/2019 21:27, Arnd Bergmann wrote:
ks8695 is an older SoC originally made by Kendin, which was later acquired
by Micrel, and subsequently by Microchip.
The platform port was originally contributed by Andrew Victor and Ben
Dooks, and later maintained by Greg Ungerer.
When I recently
On 2019-08-09 21:27, Arnd Bergmann wrote:
ks8695 is an older SoC originally made by Kendin, which was later
acquired
by Micrel, and subsequently by Microchip.
The platform port was originally contributed by Andrew Victor and Ben
Dooks, and later maintained by Greg Ungerer.
When I recently
On 19/06/2019 12:10, Dmitry Osipenko wrote:
19.06.2019 13:55, Jon Hunter пишет:
On 19/06/2019 11:27, Dmitry Osipenko wrote:
19.06.2019 13:04, Jon Hunter пишет:
On 19/06/2019 00:27, Dmitry Osipenko wrote:
19.06.2019 1:22, Ben Dooks пишет:
On 13/06/2019 22:08, Dmitry Osipenko wrote
On 19/06/2019 11:13, Jon Hunter wrote:
On 19/06/2019 11:08, Ben Dooks wrote:
On 19/06/2019 11:04, Jon Hunter wrote:
On 19/06/2019 00:27, Dmitry Osipenko wrote:
19.06.2019 1:22, Ben Dooks пишет:
On 13/06/2019 22:08, Dmitry Osipenko wrote:
Tegra's APB DMA engine updates words counter
On 19/06/2019 11:04, Jon Hunter wrote:
On 19/06/2019 00:27, Dmitry Osipenko wrote:
19.06.2019 1:22, Ben Dooks пишет:
On 13/06/2019 22:08, Dmitry Osipenko wrote:
Tegra's APB DMA engine updates words counter after each transferred burst
of data, hence it can report transfer's res
g playback in a chromiuim web browser. The patch is
based on the original work that was made by Ben Dooks [1]. It was tested
on Tegra20 and Tegra30 devices.
[1]
https://lore.kernel.org/lkml/20190424162348.23692-1-ben.do...@codethink.co.uk/
Inspired-by: Ben Dooks
Signed-off-by: Dmitr
On 24/04/2019 19:17, Dmitry Osipenko wrote:
24.04.2019 19:23, Ben Dooks пишет:
The tx_status callback does not report the state of the transfer
beyond complete segments. This causes problems with users such as
ALSA when applications want to know accurately how much data has
been moved.
This
the residual information accordinly. It
takes into account any hardware issues when trying to read the
state, such as delays between finishing a buffer and signalling
the interrupt.
Signed-off-by: Ben Dooks
---
Cc: Dmitry Osipenko
Cc: Laxman Dewangan (supporter:TEGRA DMA DRIVERS)
Cc: Jon Hunter
Commit-ID: b5dbb6799e3e5b8ebdce33b52b2d4ec9c66e15fe
Gitweb: https://git.kernel.org/tip/b5dbb6799e3e5b8ebdce33b52b2d4ec9c66e15fe
Author: Ben Dooks
AuthorDate: Sat, 30 Mar 2019 11:56:24 +
Committer: Borislav Petkov
CommitDate: Tue, 2 Apr 2019 10:38:51 +0200
x86/asm: Annotate
ay around.
But there's no absolutely right answer here, and nobody should ever
use copy_user_generic() directly (ie it is very much meant to be only
used as a internal helper for the cases that get the pointer
annotations right).
Signed-off-by: Ben Dooks
---
arch/x86/include/asm/uaccess_64.h | 2
On 2019-03-29 13:39, Borislav Petkov wrote:
On Thu, Mar 28, 2019 at 10:23:21PM +0100, Jann Horn wrote:
Fix __user annotations in various places across the x86 tree:
- cast to wrong pointer type in __user_atomic_cmpxchg_inatomic()
- generic_load_microcode() deals with a pointer that can be
ta(dev, gpio, NULL);
+ ret = devm_gpiochip_add_data(&pdev->dev, gpio, NULL);
if (ret) {
- dev_err(dev, "unable to add GPIO chip\n");
+ dev_err(&pdev->dev, "unable to add GPIO chip\n");
-by: Ben Dooks
---
net/compat.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/compat.c b/net/compat.c
index 3d348198004f..8c8c57d814af 100644
--- a/net/compat.c
+++ b/net/compat.c
@@ -589,7 +589,7 @@ int compat_mc_setsockopt(struct sock *sock, int level, int
/usercopy_64.c:70:21:expected void const volatile [noderef]
*
arch/x86/lib/usercopy_64.c:70:21:got char *to
Signed-off-by: Ben Dooks
---
arch/x86/include/asm/uaccess_64.h | 2 +-
arch/x86/lib/usercopy_64.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86
On 2019-01-23 16:04, Mark Brown wrote:
On Mon, Jan 21, 2019 at 07:37:23PM +0100, Martin Blumenstingl wrote:
Suppress the "Failed to get PWM" error output if the actual error code
is EPROBE_DEFER. This makes the behavior of the pwm-regulator driver
consistent with what most other drivers do (w
The RTC_COUNTER register which holds the time is 32-bits wide.
There are four 32-bit wide (in total: 16 bytes) "regmem" registers which
are exposed using nvmem. On Amlogic's 3.10 kernel this is used to store
data which needs to survive a suspend / resume cycle.
Signed-of
On Fri, Nov 16, 2018 at 10:38:18AM -0500, Alan Stern wrote:
> On Fri, 16 Nov 2018, Ben Dooks wrote:
>
> > On 14/11/18 18:47, Alan Stern wrote:
> > > On Wed, 14 Nov 2018, Ben Dooks wrote:
> > >
> > >> From: Ben Dooks
> > >>
> > >
I have been looking at the usbnet drivers and the possibility of some
code cleanups. One of the things I've found is that changing the way
the drivers use the private data with the usbnet structure is often
hand-coded each time is needed.
An easy cleanp (and making it easier in the future to chang
There are a number of places in the qmi_wwan driver where it gets the
private-data from the usbnet passed in. It would be sensible to have
one inline function to convert it and change all points in the driver
to use that.
Signed-off-by: Ben Dooks
---
drivers/net/usb/qmi_wwan.c | 31
There are a number of places in the asix driver where it gets the
private-data from the usbnet passed in. It would be sensible to have
one inline function to convert it and change all points in the driver
to use that.
Signed-off-by: Ben Dooks
---
drivers/net/usb/asix.h | 5
There are a number of places in the huawei driver where it gets the
private-data from the usbnet passed in. It would be sensible to have
one inline function to convert it and change all points in the driver
to use that.
Signed-off-by: Ben Dooks
---
---
drivers/net/usb/huawei_cdc_ncm.c | 15
There are a number of places in the cdc drivers where it gets the
private-data from the usbnet passed in. It would be sensible to have
one inline function to convert it and change all points in the driver
to use that.
Signed-off-by: Ben Dooks
---
drivers/net/usb/cdc_ether.c | 8 ++---
drivers
There are a number of places in the sr8900 driver where it gets the
private-data from the usbnet passed in. It would be sensible to have
one inline function to convert it and change all points in the driver
to use that.
Signed-off-by: Ben Dooks
---
drivers/net/usb/sr9800.c | 15
to LE32 conversion as well and
makes the whole sequence easier to understand hopefully.
Signed-off-by: Ben Dooks
---
Since v1:
- Add alignment changes using put_unaligned_le32()
---
drivers/net/usb/smsc95xx.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions
The tasklet initialisation would be better done by tasklet_init()
instead of assuming all the fields are in an ok state by default.
This does not fix any actual know bug.
Signed-off-by: Ben Dooks
---
drivers/net/usb/cdc_ncm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
On 02/10/18 14:19, David Laight wrote:
From: Ben Dooks
Sent: 02 October 2018 10:27
The tegra driver requires alignment of the buffer, so try and
make this better by pushing the buffer start back to an word
aligned address. At the worst this makes memcpy() easier as
it is word aligned, at best
Move the checking of the LOG_DEVICE into a function to reduce the
number of #ifdefs and ensure more of the code gets compiled/checked,
and make it easier to change this for internal debugging purposes
(such as checking >1 device).
Signed-off-by: Ben Dooks
---
drivers/base/regmap/regmap.c |
On 2018-07-30 16:07, Mark Brown wrote:
On Mon, Jul 30, 2018 at 03:04:46PM +0100, Jon Hunter wrote:
On 30/07/18 11:18, Mark Brown wrote:
> DSP modes only care about the rising edge of the LRCLK, the pulse can be
> any width without causing interoperability problems.
OK, thanks I was not a
On 2018-07-27 13:59, Jorge Sanjuan wrote:
This patchset adds support for TDM audio on Tegra30 hardware.
It adds the DAI's `set_tdm_slot` callback and enables a tegra
pcm to have up to 8 channels.
It also includes support for other audio formats supported by
the Tegra30 HW and fixes a broken m
On Mon, Jul 30, 2018 at 09:49:08AM +0100, Mark Brown wrote:
> On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote:
> > From: Edward Cragg
> >
> > Add a callback to configure TDM settings for the Tegra30
> > I2S ASoC 'platform' driver.
> >
&
On 2018-07-28 23:28, kbuild test robot wrote:
Hi Edward,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tegra/for-next]
[also build test ERROR on v4.18-rc6 next-20180727]
[if your patch is applied to the wrong git tree, please drop us a note
to help improve the
On 2018-07-26 16:22, Stephen Boyd wrote:
Quoting Ben Dooks (2018-07-26 06:32:29)
On 2018-07-20 14:45, Ben Dooks wrote:
> Hi, this is a set of clock updates and fixes we did when developing
> the tegra20/tegra30 auto support. The audio change is due to using
> the tegra in clock-s
On 2018-07-20 14:45, Ben Dooks wrote:
Hi, this is a set of clock updates and fixes we did when developing
the tegra20/tegra30 auto support. The audio change is due to using
the tegra in clock-slave mode (this hasn't been done before)
We have also implemented the clock reset status callba
On 24/07/18 12:31, Dmitry Osipenko wrote:
On Monday, 23 July 2018 16:05:21 MSK Dmitry Osipenko wrote:
On Friday, 20 July 2018 16:45:30 MSK Ben Dooks wrote:
The 2D and 3D clocks have an IDLE field in bits 15:8 so add these
clocks by making a 2D and 3D mux, and split the divider into the
On 2018-07-23 12:33, Dmitry Osipenko wrote:
On Monday, 23 July 2018 11:28:25 MSK Ben Dooks wrote:
On 2018-07-22 12:55, Dmitry Osipenko wrote:
> On Friday, 20 July 2018 16:45:30 MSK Ben Dooks wrote:
>> The 2D and 3D clocks have an IDLE field in bits 15:8 so add these
>> clocks
On 2018-07-23 12:12, Peter De Schrijver wrote:
On Mon, Jul 23, 2018 at 10:32:58AM +0100, Ben Dooks wrote:
On 2018-07-23 09:50, Peter De Schrijver wrote:
>On Fri, Jul 20, 2018 at 02:45:26PM +0100, Ben Dooks wrote:
>>The host1x clock according to both tegra2 and tegra3 manuals is
On 2018-07-23 09:50, Peter De Schrijver wrote:
On Fri, Jul 20, 2018 at 02:45:26PM +0100, Ben Dooks wrote:
The host1x clock according to both tegra2 and tegra3 manuals is
an 8bit divider with lsb being fractional. This is running into
an issue where the host1x is being set on a tegra20a
On 2018-07-22 12:55, Dmitry Osipenko wrote:
On Friday, 20 July 2018 16:45:30 MSK Ben Dooks wrote:
The 2D and 3D clocks have an IDLE field in bits 15:8 so add these
clocks by making a 2D and 3D mux, and split the divider into the
standard 2D/3D ones and 2D/3D idle clocks.
Signed-off-by: Ben
The clocks vde, vi, epp, mpe, 2d and 3d are all fractional
divisors, and not integer divisors as setup in the current
kernel. This seems to be the same for tegra2 and tegra3.
Signed-off-by: Ben Dooks
---
drivers/clk/tegra/clk-tegra-periph.c | 12 ++--
1 file changed, 6 insertions(+), 6
data.
Signed-off-by: Ben Dooks
---
drivers/clk/tegra/clk.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
index a2cb3d0d38bf..3bba3509ca1f 100644
--- a/drivers/clk/tegra/clk.c
+++ b/drivers/clk/tegra/clk.c
Hi, this is a set of clock updates and fixes we did when developing
the tegra20/tegra30 auto support. The audio change is due to using
the tegra in clock-slave mode (this hasn't been done before)
We have also implemented the clock reset status callback as it is
used by some of the driver work we d
Add a the status callback for the reset controller part of the clock
code in the tegra to allow drivers to query the status of a reset line.
Signed-off-by: Ben Dooks
---
drivers/clk/tegra/clk.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/clk/tegra/clk.c b/drivers
-off-by: Ben Dooks
---
drivers/clk/tegra/clk-periph.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/tegra/clk-periph.c b/drivers/clk/tegra/clk-periph.c
index 9475c00b7cf9..0c377d2dac43 100644
--- a/drivers/clk/tegra/clk-periph.c
+++ b/drivers/clk
The 2D and 3D clocks have an IDLE field in bits 15:8 so add these
clocks by making a 2D and 3D mux, and split the divider into the
standard 2D/3D ones and 2D/3D idle clocks.
Signed-off-by: Ben Dooks
---
drivers/clk/tegra/clk-id.h | 4
drivers/clk/tegra/clk-tegra-periph.c
From: Thomas Preston
The i2s clock mux should take audio_2x as a parent, but the
current macro misses the _2x suffix off the audio input clock
which means the audio_2x cannot be selected as a parent of i2s.
Fix the issue by appending the _2x prefix in the name array.
Signed-off-by: Thomas Prest
If the _calc_rate() function fails in the tegra clock code, print
the name of the clock that failed to allow debugging.
Signed-off-by: Ben Dooks
---
drivers/clk/tegra/clk-pll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk
The host1x clock according to both tegra2 and tegra3 manuals is
an 8bit divider with lsb being fractional. This is running into
an issue where the host1x is being set on a tegra20a system to
266.4MHz but ends up at 222MHz instead.
Signed-off-by: Ben Dooks
---
drivers/clk/tegra/clk-tegra
101 - 200 of 430 matches
Mail list logo
