[PATCH] power: fixup clock_ops

2014-01-10 Thread Ben Dooks
nt to fail to work: WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:883 __clk_enable+0x2c/0xa0() Cc: "Rafael J. Wysocki" Cc: Pavel Machek Cc: Greg Kroah-Hartman Cc: linux...@vger.kernel.org Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Ben Dooks Rev

[PATCH] power: fixup clock_ops

2014-01-10 Thread Ben Dooks
-off-by: Ben Dooks ben.do...@codethink.co.uk Reviewed-by: Ian Molton ian.mol...@codethink.co.uk --- drivers/base/power/clock_ops.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c index 9d8fde7..b9dd8fa 100644

[PATCH] ARM: shmobile: compile drivers/sh for CONFIG_ARCH_SHMOBILE_MULTI

2014-01-10 Thread Ben Dooks
...@linuxfoundation.org Signed-off-by: Ben Dooks ben.do...@codethink.co.uk --- drivers/Makefile| 1 + drivers/sh/Makefile | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/Makefile b/drivers/Makefile index 8e3b8b0..abc4744 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -118,6 +118,7

Re: [PATCH] power: fixup clock_ops

2014-01-10 Thread Ben Dooks
Sorry, as a note the patch title /should/ have been: power: fixup clock_ops clk prepare count usage -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line

Re: [PATCH] power: fixup clock_ops

2014-01-10 Thread Ben Dooks
On 10/01/14 15:59, Geert Uytterhoeven wrote: Hi Ben, On Fri, Jan 10, 2014 at 4:06 PM, Ben Dooks ben.do...@codethink.co.uk wrote: On the Renesas Lager board, this causes numerous warnings of the following and even worse the clock system will not enable clocks, causing drivers

Re: [PATCH] power: fixup clock_ops

2014-01-10 Thread Ben Dooks
On 10/01/14 17:09, Geert Uytterhoeven wrote: On Fri, Jan 10, 2014 at 5:23 PM, Ben Dooks ben.do...@codethink.co.uk wrote: On 10/01/14 15:59, Geert Uytterhoeven wrote: On Fri, Jan 10, 2014 at 4:06 PM, Ben Dooks ben.do...@codethink.co.uk wrote: On the Renesas Lager board, this causes numerous

Re: [PATCH] watchdog: s3c2410_wdt: Only register for cpufreq on CPU_FREQ_S3C24XX

2013-11-25 Thread Ben Dooks
On Mon, Nov 25, 2013 at 02:55:37PM -0800, Doug Anderson wrote: > On modern SoCs the watchdog timer is parented on a clock that doesn't > change every time we have a cpufreq change. That means we don't need > to constantly adjust the watchdog timer, so avoid registering for and > dealing with

Re: [PATCH] watchdog: s3c2410_wdt: Only register for cpufreq on CPU_FREQ_S3C24XX

2013-11-25 Thread Ben Dooks
On Mon, Nov 25, 2013 at 02:55:37PM -0800, Doug Anderson wrote: On modern SoCs the watchdog timer is parented on a clock that doesn't change every time we have a cpufreq change. That means we don't need to constantly adjust the watchdog timer, so avoid registering for and dealing with cpufreq

Re: [PATCH v2] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions

2013-11-12 Thread Ben Dooks
to add a note about endian-ness. Given these are single instructoins for ARM, is it possible we could make a table of all the callers and fix them up when we initialise as we do for the SMP/UP case and for page-offset? -- Ben Dooks htt

Re: [PATCH v2] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions

2013-11-12 Thread Ben Dooks
these are single instructoins for ARM, is it possible we could make a table of all the callers and fix them up when we initialise as we do for the SMP/UP case and for page-offset? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink

Re: [PATCH v2 1/3] clk: emev2: Add support for emev2 SMU clocks with DT

2013-10-09 Thread Ben Dooks
clocks, which I added in mine. This is also an issue with the clock and serial drivers which do not ensure the bus/module clocks have been enabled in the driver. Mine also dealt with the multiple parents that some of these clocks have. I can try and re-post tonight for discussion. -- Ben Dooks

Re: [PATCH v2 1/3] clk: emev2: Add support for emev2 SMU clocks with DT

2013-10-09 Thread Ben Dooks
try and re-post tonight for discussion. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

2013-10-08 Thread Ben Dooks
to indicate the criticality of operation + * r3 - @pargs: Physical address of parameter list + */ +ENTRY(omap_smc3) + stmfd sp!, {r4-r11, lr} + mov r12, r0 @ Copy the secure service ID I think you should save r12 in the call. -- Ben Dooks http

Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

2013-10-08 Thread Ben Dooks
service ID I think you should save r12 in the call. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-21 Thread Ben Dooks
ble without changing the kernel source to add these flag checks. I also don't like information hidden away that the user cannot see. Having the device specifically named allows us to see from sysfs exactly what we are dealing with. -- Ben Dooks http://www.codethink.co

Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver

2012-09-21 Thread Ben Dooks
the kernel source to add these flag checks. I also don't like information hidden away that the user cannot see. Having the device specifically named allows us to see from sysfs exactly what we are dealing with. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

Re: [PATCH] MAINTAINERS: fix tree for current i2c-embedded development

2012-09-13 Thread Ben Dooks
ernel/people/jdelvare/linux-2.6/jdelvare-i2c/ > -T: git git://git.fluff.org/bjdooks/linux.git > +T: git git://git.pengutronix.de/git/wsa/linux.git > S: Maintained > F: Documentation/i2c/ > F: drivers/i2c/ Acked-by: Ben Dooks -- Ben Dooks, b...@fluff.org, ht

Re: [PATCH] MAINTAINERS: fix tree for current i2c-embedded development

2012-09-13 Thread Ben Dooks
/jdelvare-i2c/ -T: git git://git.fluff.org/bjdooks/linux.git +T: git git://git.pengutronix.de/git/wsa/linux.git S: Maintained F: Documentation/i2c/ F: drivers/i2c/ Acked-by: Ben Dooks ben-li...@fluff.org -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada

Re: [PATCH 03/11] pinctrl: mvebu: kirkwood pinctrl driver

2012-08-27 Thread Ben Dooks
On 20/08/2012 06:49, Linus Walleij wrote: On Sat, Aug 11, 2012 at 2:56 PM, Sebastian Hesselbarth wrote: This patch adds a SoC specific pinctrl driver for Marvell Kirkwood SoCs plus DT binding documentation. This driver will use the mvebu pinctrl driver core. Thanks for working on

Re: [PATCH 03/11] pinctrl: mvebu: kirkwood pinctrl driver

2012-08-27 Thread Ben Dooks
On 20/08/2012 06:49, Linus Walleij wrote: On Sat, Aug 11, 2012 at 2:56 PM, Sebastian Hesselbarth sebastian.hesselba...@gmail.com wrote: This patch adds a SoC specific pinctrl driver for Marvell Kirkwood SoCs plus DT binding documentation. This driver will use the mvebu pinctrl driver core.

Re: [RFC] [PATCH] Fix b43 driver build for arm

2008-02-26 Thread Ben Dooks
On Wed, Feb 20, 2008 at 08:37:09PM +0100, Sam Ravnborg wrote: > On Wed, Feb 20, 2008 at 03:44:04PM +0100, Michael Buesch wrote: > > On Wednesday 20 February 2008 01:44:38 Gordon Farquharson wrote: > > > Hi Michael > > > > > > On Feb 19, 2008 3:41 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > >

Re: [RFC] [PATCH] Fix b43 driver build for arm

2008-02-26 Thread Ben Dooks
On Wed, Feb 20, 2008 at 08:37:09PM +0100, Sam Ravnborg wrote: On Wed, Feb 20, 2008 at 03:44:04PM +0100, Michael Buesch wrote: On Wednesday 20 February 2008 01:44:38 Gordon Farquharson wrote: Hi Michael On Feb 19, 2008 3:41 AM, Michael Buesch [EMAIL PROTECTED] wrote: [2]

sysdev: detecting multiple driver registrations

2008-02-18 Thread Ben Dooks
I've just found how easy it is to accidentally register a sysdev_driver for two different classes. When this happens, bad things happen as the sysdev_driver structure keeps has the list entry for the driver registration. The following patch makes a WARN_ON() if this happens, although I think

sysdev: detecting multiple driver registrations

2008-02-18 Thread Ben Dooks
I've just found how easy it is to accidentally register a sysdev_driver for two different classes. When this happens, bad things happen as the sysdev_driver structure keeps has the list entry for the driver registration. The following patch makes a WARN_ON() if this happens, although I think

Re: [PATCH] ubi: fix sparse errors in ubi.h

2008-02-14 Thread Ben Dooks
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote: > In C, signed 1-bit bitfields can only take the values 0 and -1, only > 0 and 1 are ever assigned in current code. Make them unsigned > bitfields. > > Fixes the (repeated) sparse errors: > drivers/mtd/ubi/ubi.h:220:15: error:

MemoryStick: reference to MMC should be MemoryStick

2008-02-14 Thread Ben Dooks
The drivers/memstick/Kconfig references MMC where it should read MemoryStick Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> diff -urNp linux-2.6.25-rc1/drivers/memstick/Kconfig linux-2.6.25-rc1-bjd1/drivers/memstick/Kconfig --- linux-2.6.25-rc1/drivers/memstick/Kconfig 2008-02-13

MemoryStick: reference to MMC should be MemoryStick

2008-02-14 Thread Ben Dooks
The drivers/memstick/Kconfig references MMC where it should read MemoryStick Signed-off-by: Ben Dooks [EMAIL PROTECTED] diff -urNp linux-2.6.25-rc1/drivers/memstick/Kconfig linux-2.6.25-rc1-bjd1/drivers/memstick/Kconfig --- linux-2.6.25-rc1/drivers/memstick/Kconfig 2008-02-13 20:04

Re: [PATCH] ubi: fix sparse errors in ubi.h

2008-02-14 Thread Ben Dooks
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote: In C, signed 1-bit bitfields can only take the values 0 and -1, only 0 and 1 are ever assigned in current code. Make them unsigned bitfields. Fixes the (repeated) sparse errors: drivers/mtd/ubi/ubi.h:220:15: error: dubious

Re: [PATCH] sm501: Add uart support

2008-02-12 Thread Ben Dooks
On Fri, Feb 08, 2008 at 06:57:42PM +0900, Magnus Damm wrote: > This patch extends the sm501 mfd with 8250 uart support. We're currently > doing this in the board specific r2d-1 code already, but it would be nice to > do move things into the mfd since it's more chip specific than board specific.

Re: [PATCH] sm501: Add uart support

2008-02-12 Thread Ben Dooks
On Fri, Feb 08, 2008 at 06:57:42PM +0900, Magnus Damm wrote: This patch extends the sm501 mfd with 8250 uart support. We're currently doing this in the board specific r2d-1 code already, but it would be nice to do move things into the mfd since it's more chip specific than board specific.

Re: Questions regarding mfd drivers

2008-02-04 Thread Ben Dooks
On Mon, Feb 04, 2008 at 12:37:14PM +0100, Kristoffer Ericson wrote: > Greetings, > > Trying to wrap my head around sm501. From what I can tell an mfd driver is a > "master" driver that takes control of all > memory and io areas. It then hands out areas of those to drivers. Anywhere > near

Re: Questions regarding mfd drivers

2008-02-04 Thread Ben Dooks
On Mon, Feb 04, 2008 at 12:37:14PM +0100, Kristoffer Ericson wrote: Greetings, Trying to wrap my head around sm501. From what I can tell an mfd driver is a master driver that takes control of all memory and io areas. It then hands out areas of those to drivers. Anywhere near correct?

Re: [PATCH] ARM: Ignore memory tags with invalid data

2008-01-22 Thread Ben Dooks
On Mon, Jan 21, 2008 at 10:05:56PM -0600, Corey Minyard wrote: > From: Corey Minyard <[EMAIL PROTECTED]> > > The DNS-323 system has several bogus memory entries in the tag table, > and it caused the system to crash at startup. Ignore tag entries that > are obviously bogus. This should have gone

Re: [PATCH] ARM: Ignore memory tags with invalid data

2008-01-22 Thread Ben Dooks
On Mon, Jan 21, 2008 at 10:05:56PM -0600, Corey Minyard wrote: From: Corey Minyard [EMAIL PROTECTED] The DNS-323 system has several bogus memory entries in the tag table, and it caused the system to crash at startup. Ignore tag entries that are obviously bogus. This should have gone to the

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-18 Thread Ben Dooks
On Fri, Jan 18, 2008 at 06:11:45PM +, Dmitry Baryshkov wrote: > Hi, > > Dmitry Torokhov wrote: > > > I will need some more time to review and understand the need for the new > > bus in the driver. > > Most likely this can be converted to platform_bus. Maybe this can also get > help from

Re: [RFC, PATCH] watchdog on gpio

2008-01-10 Thread Ben Dooks
On Thu, Jan 10, 2008 at 04:11:08PM +0100, Marc Pignat wrote: > watchdog driver for embedded systems with a supervisor watchdog (MAX823 or so) > connected to a gpio. This is the platform_driver and needs platform_data for > defining the gpio pin and the watchdog timeout. > > Signed-off-by: Marc

Re: Size of kernel halts startup

2008-01-07 Thread Ben Dooks
On Mon, Jan 07, 2008 at 11:28:29AM +0800, cksim wrote: > Hi, > > Yesterday, I have encountered an issue when the kernel size is more than > 1.3MB. > > Info on problem encountered as follows: > 1) I am using Atmel AT91SAM9261 part. Circuit similar to that of AT91SAM9261EK > evaluation board. >

Re: Size of kernel halts startup

2008-01-07 Thread Ben Dooks
On Mon, Jan 07, 2008 at 11:28:29AM +0800, cksim wrote: Hi, Yesterday, I have encountered an issue when the kernel size is more than 1.3MB. Info on problem encountered as follows: 1) I am using Atmel AT91SAM9261 part. Circuit similar to that of AT91SAM9261EK evaluation board. 2) I am

Re: [PATCH 2/3] Rework arch specific Makefiles to use mkubootimg

2008-01-03 Thread Ben Dooks
On Thu, Jan 03, 2008 at 04:04:06PM -0600, Josh Boyer wrote: > Rework the architecture specific Makefiles to use the in-kernel version of > the mkubootimg tool. > > Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> A CC: to RMK and any other arch maintainers being touched by this would have useful

Re: [PATCH 2/3] Rework arch specific Makefiles to use mkubootimg

2008-01-03 Thread Ben Dooks
On Thu, Jan 03, 2008 at 04:04:06PM -0600, Josh Boyer wrote: Rework the architecture specific Makefiles to use the in-kernel version of the mkubootimg tool. Signed-off-by: Josh Boyer [EMAIL PROTECTED] A CC: to RMK and any other arch maintainers being touched by this would have useful too. --

Re: [PATCH] Tokyo Electron SDIO controller (Ellen) support

2007-12-03 Thread Ben Dooks
On Mon, Dec 03, 2007 at 08:22:07AM -0600, Matt Porter wrote: > On Sat, Dec 01, 2007 at 09:50:10PM +0100, Pierre Ossman wrote: > > As for the patch, it's a big NAK at this point. Vendors who can't be > > bothered to follow > > the standard will have to wait for Ben's separation patches before they

Re: [PATCH] Tokyo Electron SDIO controller (Ellen) support

2007-12-03 Thread Ben Dooks
On Mon, Dec 03, 2007 at 08:22:07AM -0600, Matt Porter wrote: On Sat, Dec 01, 2007 at 09:50:10PM +0100, Pierre Ossman wrote: As for the patch, it's a big NAK at this point. Vendors who can't be bothered to follow the standard will have to wait for Ben's separation patches before they can

Re: [RFC] Documentation about unaligned memory access

2007-11-26 Thread Ben Dooks
On Fri, Nov 23, 2007 at 01:43:29PM +0200, Heikki Orsila wrote: > On Fri, Nov 23, 2007 at 12:15:53AM +, Daniel Drake wrote: > > Why unaligned access is bad > > === > > > > Most architectures are unable to perform unaligned memory accesses. Any > > unaligned access

Re: [RFC] Documentation about unaligned memory access

2007-11-26 Thread Ben Dooks
On Fri, Nov 23, 2007 at 01:43:29PM +0200, Heikki Orsila wrote: On Fri, Nov 23, 2007 at 12:15:53AM +, Daniel Drake wrote: Why unaligned access is bad === Most architectures are unable to perform unaligned memory accesses. Any unaligned access causes a

[PATCH] MFD: SM501 debug typo fix

2007-11-19 Thread Ben Dooks
Remove errnoeous x character from dev_dbg() call that stops the driver compiling under debug. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.22-quilt2/drivers/mfd/sm501.c === --- linux-2.6.22-quilt2.orig/drive

[PATCH] MFD: SM501 debug typo fix

2007-11-19 Thread Ben Dooks
Remove errnoeous x character from dev_dbg() call that stops the driver compiling under debug. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.22-quilt2/drivers/mfd/sm501.c === --- linux-2.6.22-quilt2.orig/drivers/mfd

Re: [BUG] New Kernel Bugs

2007-11-15 Thread Ben Dooks
On Tue, Nov 13, 2007 at 10:34:37PM +, Russell King wrote: > On Tue, Nov 13, 2007 at 06:25:16PM +, Alan Cox wrote: > > > Given the wide range of ARM platforms today, it is utterly idiotic to > > > expect a single person to be able to provide responses for all ARM bugs. > > > I for one wish

Re: [BUG] New Kernel Bugs

2007-11-15 Thread Ben Dooks
On Tue, Nov 13, 2007 at 10:34:37PM +, Russell King wrote: On Tue, Nov 13, 2007 at 06:25:16PM +, Alan Cox wrote: Given the wide range of ARM platforms today, it is utterly idiotic to expect a single person to be able to provide responses for all ARM bugs. I for one wish I'd never

Re: [PATCH] Tweak Documentation/SM501.txt

2007-09-30 Thread Ben Dooks
On Sat, Sep 29, 2007 at 10:15:12PM -0500, Rob Landley wrote: > From: Rob Landley <[EMAIL PROTECTED]> > > The existing Documentation/SM501.txt gives no clue what the chip is or does, > so copy the description from Kconfig help text. > > cc: Ben Dooks <[EMAIL PROT

Re: [PATCH] Tweak Documentation/SM501.txt

2007-09-30 Thread Ben Dooks
On Sat, Sep 29, 2007 at 10:15:12PM -0500, Rob Landley wrote: From: Rob Landley [EMAIL PROTECTED] The existing Documentation/SM501.txt gives no clue what the chip is or does, so copy the description from Kconfig help text. cc: Ben Dooks [EMAIL PROTECTED] Acked-by: Ben Dooks [EMAIL PROTECTED

Re: [PATCH] nand/s3c2410.c: fix header file include path

2007-08-16 Thread Ben Dooks
On Wed, Aug 15, 2007 at 02:11:17AM +0800, Conke Hu wrote: > regs-nand.h and nand.h for s3c nand driver have been moved to plat-s3c/ dir. > > Signed-off-by: [EMAIL PROTECTED] This patch is currently awaiting the MTD maintainer to push to linus, which should hopefully be next week. -- Ben

Re: [PATCH] nand/s3c2410.c: fix header file include path

2007-08-16 Thread Ben Dooks
On Wed, Aug 15, 2007 at 02:11:17AM +0800, Conke Hu wrote: regs-nand.h and nand.h for s3c nand driver have been moved to plat-s3c/ dir. Signed-off-by: [EMAIL PROTECTED] This patch is currently awaiting the MTD maintainer to push to linus, which should hopefully be next week. -- Ben ([EMAIL

[PATCH] s3c2410: fixup after arch moves

2007-07-24 Thread Ben Dooks
Fixup the changes from moving around the arch support for s3c24xx based systems. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.22-git16-moves1/Documentation/dontdiff linux-2.6.22-git16-moves1/drivers/rtc/rtc-s3c.c linux-2.6.22-git16-moves1-fixups-split-moves2

[PATCH] s3c2410_wdt: fixup after arch include moves

2007-07-24 Thread Ben Dooks
Fixup the s3c2410 watchdog driver after moving some of the arch specific includes it has been relying on. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.22-git16-moves1/Documentation/dontdiff linux-2.6.22-git16-moves1/drivers/char/watchdog/s3c2410_wdt.c linux-2.6.22

[PATCH] s3c2410_wdt: fixup after arch include moves

2007-07-24 Thread Ben Dooks
Fixup the s3c2410 watchdog driver after moving some of the arch specific includes it has been relying on. Signed-off-by: Ben Dooks [EMAIL PROTECTED] diff -urpN -X linux-2.6.22-git16-moves1/Documentation/dontdiff linux-2.6.22-git16-moves1/drivers/char/watchdog/s3c2410_wdt.c linux-2.6.22-git16

[PATCH] s3c2410: fixup after arch moves

2007-07-24 Thread Ben Dooks
Fixup the changes from moving around the arch support for s3c24xx based systems. Signed-off-by: Ben Dooks [EMAIL PROTECTED] diff -urpN -X linux-2.6.22-git16-moves1/Documentation/dontdiff linux-2.6.22-git16-moves1/drivers/rtc/rtc-s3c.c linux-2.6.22-git16-moves1-fixups-split-moves2-fixup/drivers

Re: [PATCH] smp_call_function_single() should be a macro on UP

2007-07-17 Thread Ben Dooks
On Tue, Jul 17, 2007 at 02:40:42PM -0700, David Miller wrote: > From: Al Viro <[EMAIL PROTECTED]> > Date: Tue, 17 Jul 2007 22:29:46 +0100 > > > ... or we end up with header include order problems from hell. > > E.g. on m68k this is 100% fatal - local_irq_enable() there > > wants preempt_count(),

Re: [PATCH] smp_call_function_single() should be a macro on UP

2007-07-17 Thread Ben Dooks
On Tue, Jul 17, 2007 at 02:40:42PM -0700, David Miller wrote: From: Al Viro [EMAIL PROTECTED] Date: Tue, 17 Jul 2007 22:29:46 +0100 ... or we end up with header include order problems from hell. E.g. on m68k this is 100% fatal - local_irq_enable() there wants preempt_count(), which wants

Re: PXA270 sleeping problems after update

2007-06-22 Thread Ben Dooks
On Fri, Jun 22, 2007 at 11:34:36AM +0200, Rodolfo Giometti wrote: > I just updated my linux tree from 2.6.20-rc6 to 2.6.22-rc3 for my > custom PXA270 based board and I discovered that now sleep/wakeup > functionality doesn't work anymore! :'( This is already on linux-arm-kernel, the best place to

Re: PXA270 sleeping problems after update

2007-06-22 Thread Ben Dooks
On Fri, Jun 22, 2007 at 11:34:36AM +0200, Rodolfo Giometti wrote: I just updated my linux tree from 2.6.20-rc6 to 2.6.22-rc3 for my custom PXA270 based board and I discovered that now sleep/wakeup functionality doesn't work anymore! :'( This is already on linux-arm-kernel, the best place to

SM501: only compile suspend/resume if CONFIG_PM

2007-06-21 Thread Ben Dooks
The suspend and resume support only needs to be built if CONFIG_PM is defined. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt9/drivers/mfd/sm501.c === --- linux-2.6.21-quilt9.orig/drivers/mfd/s

SM501: only compile suspend/resume if CONFIG_PM

2007-06-21 Thread Ben Dooks
The suspend and resume support only needs to be built if CONFIG_PM is defined. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt9/drivers/mfd/sm501.c === --- linux-2.6.21-quilt9.orig/drivers/mfd/sm501.c +++ linux

Re: [patch 0/6] SM501 fixes and updates

2007-06-14 Thread Ben Dooks
On Thu, Jun 14, 2007 at 01:22:00PM +0200, Sam Ravnborg wrote: > On Thu, Jun 14, 2007 at 11:01:09AM +0100, Ben Dooks wrote: > > A set of fixes and documentation updates for > > the drivers/mfd/sm501.c SM501 driver > > What is this mfd / sm501 thing? > A _very_ quick

[patch 1/2] WATCHDOG: s3c2410_wdt announce initialisation

2007-06-14 Thread Ben Dooks
Announce the watchdog once the initialisation is complete. This aides debugging problems where the watchdog driver has been loaded and shows the current state for the user. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt2/drivers/char/watchdog/s3c2410

[patch 2/2] WATCHDOG: change s3c2410_wdt to using dev_() macros for output

2007-06-14 Thread Ben Dooks
Move to using dev_info(), dev_dbg() and dev_err() for reporting information from the driver. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt2/drivers/char/watchdog/s3c2410_wdt.c === --- linux-2.6.21-

[patch 0/2] S3C24XX watchdog updates

2007-06-14 Thread Ben Dooks
Updates for the S3C24XX watchdog driver -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: An error of compile kernel2.6.22-rc3 for ARM CPU s3c2440

2007-06-14 Thread Ben Dooks
On Mon, May 28, 2007 at 07:05:43PM +0800, ?? wrote: > Hi,All. > > I compiled new kernel2.6.22-rc3 for my s3c2440 platform yesterday, > I got follow error message from gcc-compiler. > > >CC arch/arm/plat-s3c24xx/devs.o > >linux/linux-2.6/arch/arm/plat-s3c24xx/devs.c:410: >

[patch 1/6] SM501: suspend support

2007-06-14 Thread Ben Dooks
This patch adds support for suspending the core (mfd driver) of the SM501. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c === --- linux-2.6.21-quilt8.orig/drivers/mfd/sm501.c

[patch 5/6] SM501: Add Documentation/SM501.txt

2007-06-14 Thread Ben Dooks
Add documentation for the SM501 in Documentation/SM501.txt outlining the SM501 driver. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/Documentation/SM501.txt === --- /dev/null 1970-01-01 00:00:00.000

[patch 6/6] SM501: Check SM501 ID register on initialisation

2007-06-14 Thread Ben Dooks
When binding the driver, check the ID register for a valid identity, in case the SM501 is not functioning correctly. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c === --- linux-

[patch 4/6] SM501: Clock updates and checks

2007-06-14 Thread Ben Dooks
Ensure that the M1XCLK and MCLK are sourced from the same PLL (and refuse to bind the driver if they are not). Update the PCI to safe initialisation values, as 72MHz is the maximum clock for 33MHz PCI bus mastering. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/d

[patch 0/6] SM501 fixes and updates

2007-06-14 Thread Ben Dooks
A set of fixes and documentation updates for the drivers/mfd/sm501.c SM501 driver -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

[patch 3/6] SM501: Fix sm501_init_reg() mask/set order

2007-06-14 Thread Ben Dooks
The order of the set and mask operation in sm501_init_reg() was setting and then masking the bits set. Correct the order so that we do not end up with 288MHz SDRAM clocks on certain systems. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/drivers/mfd/s

[patch 2/6] SM501: initialise SDRAM clock before bus clocks

2007-06-14 Thread Ben Dooks
This init sequence of setting the SDRAM clock before the bus clock is recommend by Silicon Motion to stop problems with writes not sticking into registers. Signed-off-by: Vincent Sanders <[EMAIL PROTECTED]> Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/drive

[patch 3/6] SM501: Fix sm501_init_reg() mask/set order

2007-06-14 Thread Ben Dooks
The order of the set and mask operation in sm501_init_reg() was setting and then masking the bits set. Correct the order so that we do not end up with 288MHz SDRAM clocks on certain systems. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c

[patch 2/6] SM501: initialise SDRAM clock before bus clocks

2007-06-14 Thread Ben Dooks
This init sequence of setting the SDRAM clock before the bus clock is recommend by Silicon Motion to stop problems with writes not sticking into registers. Signed-off-by: Vincent Sanders [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c

[patch 4/6] SM501: Clock updates and checks

2007-06-14 Thread Ben Dooks
Ensure that the M1XCLK and MCLK are sourced from the same PLL (and refuse to bind the driver if they are not). Update the PCI to safe initialisation values, as 72MHz is the maximum clock for 33MHz PCI bus mastering. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers

[patch 0/6] SM501 fixes and updates

2007-06-14 Thread Ben Dooks
A set of fixes and documentation updates for the drivers/mfd/sm501.c SM501 driver -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

[patch 5/6] SM501: Add Documentation/SM501.txt

2007-06-14 Thread Ben Dooks
Add documentation for the SM501 in Documentation/SM501.txt outlining the SM501 driver. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/Documentation/SM501.txt === --- /dev/null 1970-01-01 00:00:00.0

[patch 6/6] SM501: Check SM501 ID register on initialisation

2007-06-14 Thread Ben Dooks
When binding the driver, check the ID register for a valid identity, in case the SM501 is not functioning correctly. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c === --- linux-2.6.21

[patch 1/6] SM501: suspend support

2007-06-14 Thread Ben Dooks
This patch adds support for suspending the core (mfd driver) of the SM501. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c === --- linux-2.6.21-quilt8.orig/drivers/mfd/sm501.c2007

Re: An error of compile kernel2.6.22-rc3 for ARM CPU s3c2440

2007-06-14 Thread Ben Dooks
On Mon, May 28, 2007 at 07:05:43PM +0800, ?? wrote: Hi,All. I compiled new kernel2.6.22-rc3 for my s3c2440 platform yesterday, I got follow error message from gcc-compiler. CC arch/arm/plat-s3c24xx/devs.o linux/linux-2.6/arch/arm/plat-s3c24xx/devs.c:410: error:'S3C2443_PA_HSMMC'

[patch 0/2] S3C24XX watchdog updates

2007-06-14 Thread Ben Dooks
Updates for the S3C24XX watchdog driver -- Ben ([EMAIL PROTECTED], http://www.fluff.org/) 'a smiley only costs 4 bytes' - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[patch 1/2] WATCHDOG: s3c2410_wdt announce initialisation

2007-06-14 Thread Ben Dooks
Announce the watchdog once the initialisation is complete. This aides debugging problems where the watchdog driver has been loaded and shows the current state for the user. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt2/drivers/char/watchdog/s3c2410_wdt.c

[patch 2/2] WATCHDOG: change s3c2410_wdt to using dev_() macros for output

2007-06-14 Thread Ben Dooks
Move to using dev_info(), dev_dbg() and dev_err() for reporting information from the driver. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt2/drivers/char/watchdog/s3c2410_wdt.c === --- linux-2.6.21-quilt2.orig

Re: [patch 0/6] SM501 fixes and updates

2007-06-14 Thread Ben Dooks
On Thu, Jun 14, 2007 at 01:22:00PM +0200, Sam Ravnborg wrote: On Thu, Jun 14, 2007 at 11:01:09AM +0100, Ben Dooks wrote: A set of fixes and documentation updates for the drivers/mfd/sm501.c SM501 driver What is this mfd / sm501 thing? A _very_ quick googeling did not reveal it. drivers

[patch 6/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Check SM501 ID register on initialisation When binding the driver, check the ID register for a valid identity, in case the SM501 is not functioning correctly. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/drivers/mfd/s

[patch 4/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Clock updates and checks Ensure that the M1XCLK and MCLK are sourced from the same PLL (and refuse to bind the driver if they are not). Update the PCI to safe initialisation values, as 72MHz is the maximum clock for 33MHz PCI bus mastering. Signed-off-by: Ben Dooks <[EMAIL PROTEC

[patch 5/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Add Documentation/SM501.txt Add documentation for the SM501 in Documentation/SM501.txt outlining the SM501 driver. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/Documentation/SM501.txt === --

[patch 0/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
Fixes and documentation updates for the SM501 MFD driver. These should all be suitable for inclusion into the current kernel. All patches based on 2.6.22-rc4 -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

[patch 1/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: suspend support This patch adds support for suspending the core (mfd driver) of the SM501. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c === --- linux-2.6.21-quilt8.orig/d

[patch 3/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Fix sm501_init_reg() mask/set order The order of the set and mask operation in sm501_init_reg() was setting and then masking the bits set. Correct the order so that we do not end up with 288MHz SDRAM clocks on certain systems. Signed-off-by: Ben Dooks <[EMAIL PROTECTED]> Index:

[patch 2/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: initialise SDRAM clock before bus clocks This init sequence of setting the SDRAM clock before the bus clock is recommend by Silicon Motion to stop problems with writes not sticking into registers. Signed-off-by: Vincent Sanders <[EMAIL PROTECTED]> Signed-off-by: Ben Dooks &

[patch 3/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Fix sm501_init_reg() mask/set order The order of the set and mask operation in sm501_init_reg() was setting and then masking the bits set. Correct the order so that we do not end up with 288MHz SDRAM clocks on certain systems. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux

[patch 2/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: initialise SDRAM clock before bus clocks This init sequence of setting the SDRAM clock before the bus clock is recommend by Silicon Motion to stop problems with writes not sticking into registers. Signed-off-by: Vincent Sanders [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED

[patch 0/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
Fixes and documentation updates for the SM501 MFD driver. These should all be suitable for inclusion into the current kernel. All patches based on 2.6.22-rc4 -- - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

[patch 1/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: suspend support This patch adds support for suspending the core (mfd driver) of the SM501. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c === --- linux-2.6.21-quilt8.orig/drivers

[patch 4/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Clock updates and checks Ensure that the M1XCLK and MCLK are sourced from the same PLL (and refuse to bind the driver if they are not). Update the PCI to safe initialisation values, as 72MHz is the maximum clock for 33MHz PCI bus mastering. Signed-off-by: Ben Dooks [EMAIL PROTECTED

[patch 5/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Add Documentation/SM501.txt Add documentation for the SM501 in Documentation/SM501.txt outlining the SM501 driver. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/Documentation/SM501.txt === --- /dev

[patch 6/6] SM501 MFD driver updates

2007-06-13 Thread Ben Dooks
SM501: Check SM501 ID register on initialisation When binding the driver, check the ID register for a valid identity, in case the SM501 is not functioning correctly. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c

<    1   2   3   4   5   6   7   >