> - dev_err(>dev, "failed to ioremap\n");
> + if (IS_ERR(sc->base))
> return ERR_CAST(sc->base);
> - }
Reviewed-by: Benoit Parrot
>
> return sc;
> }
> --
> 2.25.1
>
(IS_ERR(csc->base)) {
> - dev_err(>dev, "failed to ioremap\n");
> + if (IS_ERR(csc->base))
> return ERR_CAST(csc->base);
> - }
Reviewed-by: Benoit Parrot
>
> return csc;
> }
> --
> 2.25.1
>
Pratyush,
Tomi Valkeinen wrote on Wed [2021-Mar-31
09:06:35 +0300]:
> Hi,
>
> On 30/03/2021 20:33, Pratyush Yadav wrote:
> > TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate
> > capture over a CSI-2 bus.
> >
> > The Cadence CSI2RX IP acts as a bridge between the TI
occinelle.lip6.fr)
>
> Signed-off-by: Daniel W. S. Almeida
Reviewed-by: Benoit Parrot
> ---
> drivers/media/platform/ti-vpe/vpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c
> b/drivers/media/platfor
Hi Rob,
Thanks for the review.
Rob Herring wrote on Thu [2020-May-28 17:39:33 -0600]:
> On Fri, May 22, 2020 at 05:54:11PM -0500, Benoit Parrot wrote:
> > Device Tree bindings for the Video Input Port (VIP) driver.
>
> Bindings document h/w, not drivers.
I'll fix that.
>
&
Several drivers implement the same enclosed_rectangle() function to
check if a rectangle is enclosed into another. Replace this with the
newly added v4l2_rect_enclosed() helper function.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/am437x/am437x-vpfe.c | 19
Add a helper function to check if one rectangle is enclosed inside
another.
Signed-off-by: Benoit Parrot
---
include/media/v4l2-rect.h | 20
1 file changed, 20 insertions(+)
diff --git a/include/media/v4l2-rect.h b/include/media/v4l2-rect.h
index 8800a640c224..bd587d0c0dc3
This series introduces a new v4l2_rect_enclosed helper function which
already exist in some form in several drivers. It then proceed to
update those drivers to use the new helper function.
Benoit Parrot (2):
media: v4l2-rect.h: add enclosed rectangle helper
media: use v4l2_rect_enclosed
each connected to its own
sub-device.
Signed-off-by: Benoit Parrot
Signed-off-by: Nikhil Devshatwar
---
drivers/media/platform/Kconfig | 13 +
drivers/media/platform/ti-vpe/Makefile |2 +
drivers/media/platform/ti-vpe/vip.c| 4158
drivers/media/platform
test USERPTR (no poll): OK (Not Supported)
test USERPTR (select): OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total for vip device /dev/video1: 51, Succeeded: 51, Failed: 0, Warnings: 57
Benoit Parrot (2):
dt-binbings: media: ti
Device Tree bindings for the Video Input Port (VIP) driver.
Signed-off-by: Benoit Parrot
---
.../devicetree/bindings/media/ti,vip.yaml | 394 ++
MAINTAINERS | 1 +
2 files changed, 395 insertions(+)
create mode 100644 Documentation
Reviewed-by: Benoit Parrot
Arnd Bergmann wrote on Tue [2020-Apr-28 23:34:19 +0200]:
> gcc warns about empty array declarations, which we get in this driver
> when compile-testing without CONFIG_OF:
>
> drivers/media/platform/ti-vpe/cal.c:2194:34: warning: array 'cal_of_match
Sakari Ailus wrote on Tue [2019-Oct-22 10:46:23 +0300]:
> Hi Benoit,
>
> Thanks for the patch.
>
> On Fri, Oct 18, 2019 at 10:34:37AM -0500, Benoit Parrot wrote:
> > Convert ti-cal.txt to ti,cal.yaml.
> >
> > Signed-off-by: Benoit Parrot
> > ---
> &g
Hans Verkuil wrote on Mon [2019-Oct-21 12:49:00 +0200]:
> On 10/18/19 5:34 PM, Benoit Parrot wrote:
> > Convert ti-cal.txt to ti,cal.yaml.
> >
> > Signed-off-by: Benoit Parrot
>
> Can you add this bindings file to MAINTAINERS as well in a separate patch?
Yes I can d
nge.
>
> Once I have Rob's Acks I can merge this.
Ok, thanks.
I'll send a v2 probably later this week or early next.
Benoit
>
> Regards,
>
> Hans
>
> On 10/18/19 5:34 PM, Benoit Parrot wrote:
Hans Verkuil wrote on Mon [2019-Oct-21 12:38:03 +0200]:
> On 10/18/19 5:34 PM, Benoit Parrot wrote:
> > Apply Errata i913 every time the functional clock is enabled.
> > This should take care of suspend/resume case as well.
> >
> > Signed-off-by: Benoit Parrot
&g
Tony Lindgren wrote on Tue [2019-Oct-22 09:37:54 -0700]:
> * Benoit Parrot [191022 16:34]:
> > Tony Lindgren wrote on Tue [2019-Oct-22 09:30:48 -0700]:
> > > * Benoit Parrot [191022 16:28]:
> > > > Tony,
> > > >
> > > > Ping,
> > &
Tony Lindgren wrote on Tue [2019-Oct-22 09:30:48 -0700]:
> * Benoit Parrot [191022 16:28]:
> > Tony,
> >
> > Ping,
> >
> > I already had comments from Rob but i would like your feedback before
> > sending a v2.
>
> Looks good to me in general oth
Tony,
Ping,
I already had comments from Rob but i would like your feedback before
sending a v2.
Regards,
Benoit
Benoit Parrot wrote on Wed [2019-Oct-09 12:56:25 -0500]:
> This patch series adds the needed clkctrl and ty-sysc nodes for VPE module.
> We also document the VPE DT bi
Tony Lindgren wrote on Tue [2019-Oct-22 08:48:16 -0700]:
> * Benoit Parrot [191016 18:47]:
> > --- a/arch/arm/boot/dts/am43xx-clocks.dtsi
> > +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
> > @@ -704,6 +704,60 @@
> > ti,bit-shift = <8&g
Tony Lindgren wrote on Tue [2019-Oct-22 08:44:46 -0700]:
> * Benoit Parrot [191018 15:46]:
> > Add device nodes for CSI2 camera board OV5640.
> > Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> >
> > Signed-off-by: Benoit Parrot
> > ---
Tony Lindgren wrote on Tue [2019-Oct-22 08:40:12 -0700]:
> * Benoit Parrot [191018 15:46]:
> > Add clkctrl nodes for CAM domain.
>
> You're missing the Linux clk folks and list from Cc, can
> you please resend?
Sure.
>
> I need an ack for the clk-7xx.c changes if I
Add support for the OV5640 CSI camera:
- add the OV5640 nodes
- add the CAL node linkage
- enable CAL node
Signed-off-by: Benoit Parrot
---
.../arm64/boot/dts/ti/k3-am654-base-board.dts | 36 +++
1 file changed, 36 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base
Add device nodes for CSI2 camera board OV5640.
Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/dra72
Add CAL dtsi node for AM654 device. Including proper power-domains and
clock properties.
Signed-off-by: Benoit Parrot
---
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 23 +++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
b/arch/arm64
Add the required dtsi node to support the Camera
Adaptation Layer (CAL) for the DRA76 family of devices.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra76x.dtsi | 43 +++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/dra76x.dtsi b/arch
implements the latter.
Signed-off-by: Benoit Parrot
---
arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c
b/arch/arm/mach-omap2/clockdomains7xx_data.c
index 3068802824b7..27835c4d1aa9 100644
This patch adds the required dtsi node to support the Camera
Adaptation Layer (CAL) for the DRA72 family of devices.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra72x.dtsi | 43 +++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts
Add clkctrl nodes for CAM domain.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra7xx-clocks.dtsi | 14 ++
drivers/clk/ti/clk-7xx.c | 19 +++
include/dt-bindings/clock/dra7.h | 10 ++
3 files changed, 43 insertions(+)
diff --git a/arch
Add device nodes for CSI2 camera board OV5640.
Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra76-evm.dts | 39 +
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/dra76
This patch series adds the needed clkctrl and ty-sysc nodes for CAL module.
It also adds support for the module in related dtsi and dts for DRA72,
DRA76 and AM654 SoC.
Benoit Parrot (9):
ARM: dts: dra7: add cam clkctrl node
ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only
ARM: dts: dra7
Add CAM nodes as a child of l4 interconnect in order for it to probe
using ti-sysc.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra7-l4.dtsi | 43 +-
1 file changed, 37 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm
The pixel processing unit was hard coded to only handle 8 bits per pixel
from input to output.
We now add handling for 10, 12 and 16 bits per pixel at the source and
setting the in-memory size (i.e. container size) to 16 bits for these 3
cases.
Signed-off-by: Benoit Parrot
---
drivers/media
Allow CAL to be able to export DMA buffer.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri Sarha
---
drivers/media/platform/ti-vpe/cal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/ti-vpe/cal.c
b/drivers/media/platform/ti-vpe/cal.c
index 26f95a81e4ed
Apply Errata i913 every time the functional clock is enabled.
This should take care of suspend/resume case as well.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri Sarha
---
drivers/media/platform/ti-vpe/cal.c | 56 +++-
drivers/media/platform/ti-vpe/cal_regs.h | 27
the DMA to maximum height as specified in the S_FMT ioctl.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/cal.c
b/drivers/media/platform/ti
bit layout for the CTRL_CORE_CAMERRX_CONTROL
changes depending on the device. In order to support this we need to use
a register access scheme based on data configuration instead of using
static macro.
In this case we make use of the regmap facility and create data set
based on the various device and phy available.
Signed-off-
to show the actual
number of bits per pixel being received.
The "container" size will be derived from the "bpp" value.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 98 +
1 file changed, 44 insertions(+), 54 deletions(-)
Make sure that both enum_mbus_code() and enum_framesize() properly
populate the .which parameter member, otherwise -EINVAL is return
causing the subdev asynchronous registration handshake to fail.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 2 ++
1 file changed, 2
Update Device Tree bindings for the CAL driver to add AM654 support.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt
b/Documentation/devicetree/bindings
Update binding example to show proper endpoint properties and linkage.
Signed-off-by: Benoit Parrot
---
.../devicetree/bindings/media/ti-cal.txt | 32 ++-
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt
b
Update Device Tree bindings for the CAL driver to use syscon to access
the phy config register instead of trying to map it directly.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff
for pre ES2.0 silicon errata.
- Reworked the DPHY initialization sequence to match the technical
reference manual and provide a more robust restartability.
- Adds the missing ability to power subdevice.
- Update the devicetree binding and then converts it to dt-schema
Benoit Parrot (18):
dt
Convert ti-cal.txt to ti,cal.yaml.
Signed-off-by: Benoit Parrot
---
.../devicetree/bindings/media/ti,cal.yaml | 186 ++
.../devicetree/bindings/media/ti-cal.txt | 82
2 files changed, 186 insertions(+), 82 deletions(-)
create mode 100644 Documentation
Update Device Tree bindings for the CAL driver to add support for
the CSI2 PHY LDO errata workaround for pre-es2 devices.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri Sarha
---
Documentation/devicetree/bindings/media/ti-cal.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
When start_streaming fails after the buffers have been queued we have to
make sure all buffers are returned to user-space properly otherwise a
v4l2 level WARN is generated.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 5 +
1 file changed, 5 insertions(+)
diff
Based on V4L2 documentations bridge driver must power on and off sub
device explicitly if media-controller mode is not used.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/platform/ti-vpe/cal.c
and
height based on the maximum line width in bytes and re-calculating the
pixel width based on the given pixel format.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/ti-vpe
Update Device Tree bindings for the CAL driver to add DRA76x support.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-cal.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt
b/Documentation/devicetree/bindings
Add the needed control module register bit layout to support the AM654
family of devices.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/Kconfig | 2 +-
drivers/media/platform/ti-vpe/cal.c | 28 +++-
2 files changed, 28 insertions(+), 2 deletions(-)
diff
The current CSI2 DPHY initialization sequence although
functional does not match with the documented sequence
in the Technical Reference Manual.
This may affect capture re-startability in stop/start
situations.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 199
Add the needed control module register bit layout to support
the DRA76x family of devices.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 36 +
1 file changed, 36 insertions(+)
diff --git a/drivers/media/platform/ti-vpe/cal.c
b/drivers/media
Add VPFE device nodes entries.
Add OmniVision OV2659 sensor device nodes and linkage.
The sensor clock (xvclk) is sourced from clkout1.
Add clock entries to properly select clkout1 and set its parent
clock to sys_clkin_ck.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/am437x-sk-evm.dts
.
Benoit Parrot (2):
ARM: dts: am437x-sk-evm: Add VPFE and OV2659 entries
ARM: dts: am43x-epos-evm: Add VPFE and OV2659 entries
Tero Kristo (1):
ARM: dts: am43xx: add support for clkout1 clock
arch/arm/boot/dts/am437x-sk-evm.dts | 27 +-
arch/arm/boot/dts/am43x-epos-evm.dts | 23
Add VPFE device nodes entries.
Add OmniVision OV2659 sensor device nodes and linkage.
Since Rev1.2a on this board the sensor source clock (xvclk) has a
dedicated 12Mhz oscillator instead of using clkout1.
Add 'audio_mstrclk' fixed clock object to represent it.
Signed-off-by: Benoit Parrot
r
clkout1 clock") which is needed for the ov2659 camera sensor clock
definition hence it is being re-applied here.
Fixes: 664ae1ab2536 ("ARM: dts: am43xx: add clkctrl nodes")
Signed-off-by: Tero Kristo
Tested-by: Benoit Parrot
Signed-off-by: Tony Lindgren
Signed-off-by: Benoit Parrot
Rob Herring wrote on Tue [2019-Oct-15 17:29:47 -0500]:
> On Wed, Oct 09, 2019 at 12:56:26PM -0500, Benoit Parrot wrote:
> > Device Tree bindings for the Video Processing Engine (VPE) driver.
> >
> > Signed-off-by: Benoit Parrot
> > ---
> > .../devicetree/bi
gt; - coeff = csc_coeffs.y2r.r601.full.coeff;
> + coeff = csc_coeffs.r2y.r601.full.coeff;
> }
> } else {
> *csc_reg5 |= CSC_BYPASS;
Reviewed-by: Benoit Parrot
> --
> 2.20.1
>
Stephen Rothwell wrote on Fri [2019-Oct-11 07:47:02
+1100]:
> Hi all,
>
> In commit
>
> e20b248051ca ("media: ti-vpe: vpe: Make sure YUYV is set as default format")
>
> Fixes tag
>
> Fixes: 40cc823f7005 ("media: ti-vpe: Add support for NV21 format")
>
> has these problem(s):
>
> -
Device Tree bindings for the Video Processing Engine (VPE) driver.
Signed-off-by: Benoit Parrot
---
.../devicetree/bindings/media/ti-vpe.txt | 48 +++
MAINTAINERS | 1 +
2 files changed, 49 insertions(+)
create mode 100644 Documentation
This patch series adds the needed clkctrl and ty-sysc nodes for VPE module.
We also document the VPE DT bindings.
Benoit Parrot (3):
dt-bindings: media: ti-vpe: Document VPE driver
ARM: dts: dra7: add vpe clkctrl node
ARM: dts: dra7: Add ti-sysc node for VPE
.../devicetree/bindings/media
Add clkctrl nodes for VPE module.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra7xx-clocks.dtsi | 18 --
drivers/clk/ti/clk-7xx.c | 6 ++
include/dt-bindings/clock/dra7.h | 10 ++
3 files changed, 32 insertions(+), 2 deletions(-)
diff --git
Add VPE node as a child of l4 interconnect in order for it to probe
using ti-sysc.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra7-l4.dtsi | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot
In the 1920x1080 register array an extra pair of reset ctrl disable
re-enable was causing unwanted init delays.
Signed-off-by: Benoit Parrot
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c
The sensor data sheet clearly state that 2592x1944 only works at 15 fps
make sure we don't try to miss configure the pll out of acceptable
range.
Signed-off-by: Benoit Parrot
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 5 +
1 file changed, 5 insertions(+)
diff --git
Add v4l2 controls to report the pixel rates of each mode. This is
needed by some CSI2 receiver in order to perform proper DPHY
configuration.
Signed-off-by: Benoit Parrot
---
drivers/media/i2c/ov5640.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git
of the calc_pixel_rate in set_mode also
- Cleaned up the pixel_rate ctrl struct
- Fix the fps condition checking for the max resolution case
Changes since v1:
- Addressed comment from Sakari.
added a function to calculate the pixel rate and remove the need to
cache its value
Benoit Parrot (3):
media
Sakari Ailus wrote on Mon [2019-Oct-07 11:03:20
+0300]:
> On Fri, Oct 04, 2019 at 12:24:16PM -0500, Benoit Parrot wrote:
> > @@ -2657,6 +2669,12 @@ static int ov5640_init_controls(struct ov5640_dev
> > *sensor)
> > /* we can use our own mutex for the ctrl lock */
>
When TI CAL was introduce as another driver under platform/ti-vpe
adding a second entry into the ti-vpe directory in the platform
Makefile caused issues during parallel build.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri Sarha
---
drivers/media/platform/Makefile | 4 +---
1 file changed, 1
-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 56f60dbea15c..0e9cb0319a92 100644
--- a/drivers/media/platform
SEQ_BT.
Replace SEQ_TB with SEQ_XX wherever applicable.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 73 ++---
1 file changed, 46 insertions(+), 27 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b
): OK (Not Supported)
test USERPTR (select): OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total for vpe device /dev/video0: 51, Succeeded: 51, Failed: 0, Warnings: 2
==
Benoit Parrot (18):
media: ti-vpe: Fix a parallel
ad of hard-coding an offset which might change over time we need
to use a lookup helper instead so we know the default will always be what
we intended.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
invalid or
not supported.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpe.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index
All 4 of the "colorspace" components were not originally handled.
Causing issue related to xfer_func not being initialized properly.
This was found with v4l2-compliance test.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 5 -
1 file changed, 4 insert
For each queue we need to maintain resolutions, pixel format,
bytesperline, sizeimage, colorspace, etc.
Instead of manually adding more entries in the vpe_q_data struct, it is
better to just add a "struct v4l2_format" member and use that to store
all needed information.
Signed-off-
rework the csc module to use "struct v4l2_format *" as
parameters, and reorganize the coefficients tables in a more logical
way.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/csc.c | 254 +++-
drivers/media/platform/ti-vpe/csc.h | 4 +-
drivers/medi
entralized manner.
We therefore add a pixel_enc member to the v4l2_format_info structure to
quickly identify the related pixel encoding.
And add helper functions to check pixel encoding.
Signed-off-by: Benoit Parrot
---
drivers/media/v4l2-core/v4l2-common.c | 126 +-
inc
The RGB to YUV HD full range coefficients did not match the TRM values
and appeared to be a cut-n-paste from the YUV to RGB section.
Replace the entries with the values from the TRM.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/csc.c | 4 ++--
1 file changed, 2 insertions
cleaned
up/release during an abort use case.
In the abort cases the VPDMA desc buffers would still be mapped and the
in-flight VB2 buffers would not be released properly causing a kernel
warning from being generated by the videobuf2-core level.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi
Add RGB565 and RGB555 to the v4l2_format_info table.
Signed-off-by: Benoit Parrot
---
drivers/media/v4l2-core/v4l2-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-common.c
b/drivers/media/v4l2-core/v4l2-common.c
index 09a3915b98a3..d0e5ebc736f9
VPE uses VPDMA (built-in dma engine) to transfer data to and from the IP
and memory. VPDMA expect 32 bits addresses. To make sure that is always
the case set the DMA mask and coherent mask for the device.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 7 +++
1 file
vpdma: add support for user
specified stride")
Signed-off-by: Benoit Parrot
Acked-by: Nikhil Devshatwar
---
drivers/media/platform/ti-vpe/vpe.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/plat
ess.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 0a7cf9c820c6..8ab1c3241b74 100644
--- a/drivers/media/platform/ti-
height.
Signed-off-by: Ram Prasad
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index f3ee9ff87927..bbbf11174e16 100644
--- a/drivers
confuses the firmware.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpdma_priv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpdma_priv.h
b/drivers/media/platform/ti-vpe/vpdma_priv.h
index d8ae3e1cd54d..0bbee45338bd 100644
A few NULL pointer checks were missing.
Add check with appropriate return code.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti
Because the driver fails to properly check the 'num_planes' values for
proper ranges it ends up accessing out of bound data causing the kernel
panic.
Since this driver only handle single or dual plane pixel format, make
sure the provided value does not exceed 2 planes.
Signed-off-by: Benoit Parrot
failing to handle out range
'bytesperline' values from user space applications.
VPDMA hardware is limited to 64k line stride (16 bytes aligned, so 65520
bytes). So make sure the provided or calculated 'bytesperline' is
smaller than the maximum value.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi
.
Add support for V4L2_PIX_FMT_NV21 format for both capture and output
streams.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpdma.c | 11 ++--
drivers/media/platform/ti-vpe/vpdma.h | 1 +
drivers/media
Hans Verkuil wrote on Mon [2019-Oct-07 10:06:39 +0200]:
> On 10/4/19 6:29 PM, Benoit Parrot wrote:
> > It is often useful to figure out if a pixel_format is either YUV or RGB
> > especially for driver who can perform the pixel encoding conversion.
> >
> > Instead of h
Hans Verkuil wrote on Mon [2019-Oct-07 09:57:26 +0200]:
> On 10/4/19 6:29 PM, Benoit Parrot wrote:
> > For each queue we need to maintain resolutions, pixel format,
> > bytesperline, sizeimage, colorspace, etc.
> >
> > Instead of manually adding more entri
for the max resolution case
Changes since v1:
- Addressed comment from Sakari.
added a function to calculate the pixel rate and remove the need to
cache its value
Benoit Parrot (3):
media: ov5640: add PIXEL_RATE control
media: ov5640: Fix 1920x1080 mode to remove extra enable/disable
media
Add v4l2 controls to report the pixel rates of each mode. This is
needed by some CSI2 receiver in order to perform proper DPHY
configuration.
Signed-off-by: Benoit Parrot
---
drivers/media/i2c/ov5640.c | 25 +++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git
The sensor data sheet clearly state that 2592x1944 only works at 15 fps
make sure we don't try to miss configure the pll out of acceptable
range.
Signed-off-by: Benoit Parrot
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 5 +
1 file changed, 5 insertions(+)
diff --git
In the 1920x1080 register array an extra pair of reset ctrl disable
re-enable was causing unwanted init delays.
Signed-off-by: Benoit Parrot
Reviewed-by: Jacopo Mondi
---
drivers/media/i2c/ov5640.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c
): OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total for vpe device /dev/video0: 51, Succeeded: 51, Failed: 0, Warnings: 2
==
Benoit Parrot (18):
media: ti-vpe: Fix a parallel build issue
media: ti-vpe: vpe: Fix Motion Vector
-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 56f60dbea15c..0e9cb0319a92 100644
--- a/drivers/media/platform
invalid or
not supported.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpe.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index
.
Add support for V4L2_PIX_FMT_NV21 format for both capture and output
streams.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpdma.c | 11 ++--
drivers/media/platform/ti-vpe/vpdma.h | 1 +
drivers/media
1 - 100 of 613 matches
Mail list logo
