Re: [PATCH 0/2] mfd: platform/chrome: some more cleanups between these subsystems.

_commands.h | 295 +++--- > > 8 files changed, 322 insertions(+), 221 deletions(-) > > rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_mec.h > > (96%) > > rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_re

Re: [GIT PULL] chrome-platform updates for v4.19

On Tue, Aug 21, 2018 at 01:40:21PM -0700, Linus Torvalds wrote: > On Tue, Aug 21, 2018 at 11:54 AM Benson Leung wrote: > > > > Minor changes this time around for 4.19. > > > > cros_ec_i2c and cros_ec_spi drivers moved from mfd > > to chrome platform. > > A

[GIT PULL] chrome-platform updates for v4.19

d for 4.19. cros_ec_i2c and cros_ec_spi drivers moved from mfd to chrome platform. -------- Benson Leung (2): platform/chrome: chromeos_tbmc - fix SPDX identifier Merge tag 'ib-platform-chrome-mfd-move-cros-ec-transport-for-4.19

[GIT PULL] Immutable branch (mfd, chrome) due for the v4.19 window

2c.c (100%) rename drivers/{mfd => platform/chrome}/cros_ec_spi.c (100%) Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 0/3] platform/chrome: mfd: Move cros-ec transport drivers to drivers/platform

or the others to pull. What do you all think? Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 2/3] arm/arm64: configs: Remove the MFD_ prefix for MFD_CROS_EC_I2C/SPI symbols.

ou are pushing this through arm-soc or Russell. > In such case, for Exynos boards: > Acked-by: Krzysztof Kozlowski > > Best regards, > Krzysztof I was planning on creating an immutable branch for this series and merging it through platform/chrome. Lee, Russell, Dmitry, what do

Re: [PATCH] mfd: cros_ec: remove unused __remove function

> Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data") Gwendal, in PATCH v2 of https://patchwork.kernel.org/patch/10439449/ you mentioned that you readded the __remove to avoid a warning when built as a module. Can you explain what's going on? Benson --

Re: [PATCH] ACPI LID: increment wakeup count only when notified.

t(&device->dev); > > if (button->suspended) > > break; > > > > -- Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 2/8] platform/chrome: pstore: Switch to SPDX identifier.

// Copyright (C) 2013 Google, Inc. > > #include > #include > -- > 2.17.1 > Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 1/8] platform/chrome: cros_ec: Switch to SPDX identifier.

; #include > diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c > b/drivers/platform/chrome/cros_kbd_led_backlight.c > index ca3e4da852b4..bd4aa9331806 100644 > --- a/drivers/platform/chrome/cros_kbd_led_backlight.c > +++ b/drivers/platform/chrome/cros_kbd_led_backli

Re: [PATCH v2 7/8] extcon: usbc-cros-ec: Switch to SPDX identifier.

On Tue, Jun 05, 2018 at 07:54:28PM +0200, Enric Balletbo i Serra wrote: > Adopt the SPDX license identifier headers to ease license compliance > management. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Benson Leung > --- > > Changes in v2: > - [8/9] Fi

Re: [PATCH] ACPI LID: increment wakeup count only when notified.

> source for the last wake will be thrown off by this. Instead increment > the wakeup count only when there is a FIXED_HARDWARE/NOTFIY_STATUS event. > > Signed-off-by: Ravi Chandra Sadineni Reviewed-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google I

[GIT PULL] chrome-platform updates for v4.18

witch driver, which is useful for x86 convertible Chromebooks. Other misc. cleanup. Thanks, Benson Arnd Bergmann (1): platform: chrome: Add input dependency for tablet switch driver Benson Leung (2): platform/c

Re: [PATCH] mfd: cros_ec_dev: Don't advertise junk features on failure

oduce a new function to check EC > features.") > Cc: Benson Leung > Cc: Enric Balletbo i Serra > Cc: Gwendal Grignou > Cc: Andy Shevchenko > Signed-off-by: Stephen Boyd Acked-by: Benson Leung > --- > drivers/mfd/cros_ec_dev.c | 4 ++-- > 1 file changed, 2 inserti

Re: [PATCH v2] platform/chrome: Use to_cros_ec_dev more broadly

add the new macro in cros_ec.h through my tree. Looks to merge clean with mfd's changes this time. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] platform/chrome: chromeos_laptop: fix touchpad button mapping on Celes

being stuck in pressed state > after the first click. > > Reported-by: Sultan Alsawaf > Signed-off-by: Dmitry Torokhov Applied for v4.18. Thanks. -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org sig

Re: [PATCH] platform: chrome: Add input dependency for tablet switch driver

efined! > > This adds the corresponding Kconfig dependency > > Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver") > Signed-off-by: Arnd Bergmann Thanks for the catch! Applied for 4.18. Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Go

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

t8_t address; > + }; > +} __packed; > + > +/* Read various CEC parameters */ > +#define EC_CMD_CEC_GET 0x00BB > + > +struct ec_params_cec_get { > + uint8_t cmd; /* enum cec_command */ > +} __packed; > + > +struct ec_response_cec_get { > + union { > +

Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver

return ret; > + } > + return 0; > +} > + > +static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] = { > + { ACPI_DRV_NAME, 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids); > + > +static const SIMPLE_DEV_

Re: [PATCH 2/2] Input: atmel_mxt_ts - require device properties present when probing

with the chromeos_laptop patch that preceeds this. Reviewed-by: Benson Leung > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 152 ++- > 1 file changed, 12 insertions(+), 140 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c &g

[GIT PULL] IB chrome-platform/input for atmel_mxt_ts & chromeos_laptop for device properties

(1): platform/chrome: chromeos_laptop - supply properties for ACPI devices drivers/platform/chrome/chromeos_laptop.c | 307 +++--- 1 file changed, 278 insertions(+), 29 deletions(-) Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble

Re: [PATCH 1/2] platform/chrome: chromeos_laptop - supply properties for ACPI devices

error = chromeos_laptop_prepare_acpi_peripherals(cros_laptop, > + src); > + > + if (error) { > + chromeos_laptop_destroy(cros_laptop); > + return ERR_PTR(error); > + } > + > + return cros_laptop; > +} > + > static int __init chromeos_laptop_init(void) > { > const struct dmi_system_id *dmi_id; > @@ -652,21 +889,33 @@ static int __init chromeos_laptop_init(void) > if (IS_ERR(cros_laptop)) > return PTR_ERR(cros_laptop); > > + if (!cros_laptop->num_i2c_peripherals && > + !cros_laptop->num_acpi_peripherals) { > + pr_debug("no relevant devices detected\n"); > + error = -ENODEV; > + goto err_destroy_cros_laptop; > + } > + > error = bus_register_notifier(&i2c_bus_type, > &chromeos_laptop_i2c_notifier); > if (error) { > - pr_err("failed to register i2c bus notifier: %d\n", error); > - chromeos_laptop_destroy(cros_laptop); > - return error; > + pr_err("failed to register i2c bus notifier: %d\n", > +error); > + goto err_destroy_cros_laptop; > } > > /* > - * Scan adapters that have been registered before we installed > - * the notifier to make sure we do not miss any devices. > + * Scan adapters that have been registered and clients that have > + * been created before we installed the notifier to make sure > + * we do not miss any devices. >*/ > - i2c_for_each_dev(NULL, chromeos_laptop_scan_adapter); > + i2c_for_each_dev(NULL, chromeos_laptop_scan_peripherals); > > return 0; > + > +err_destroy_cros_laptop: > + chromeos_laptop_destroy(cros_laptop); > + return error; > } > > static void __exit chromeos_laptop_exit(void) > -- > 2.17.0.441.gb46fe60e1d-goog > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [v3] platform: chrome: Add Tablet Switch ACPI driver

On Wed, May 23, 2018 at 11:19 AM Guenter Roeck wrote: > What happened with this driver ? It is not upstream, yet the comments > on patchwork seem to suggest that it was accepted. My bad. I dropped this last year. I'll pick this now. -- Benson Leung Staff Software Engineer Chrom

Re: [PATCH] platform/chrome: cros_ec_lpc: do not try DMI match when ACPI device found

y: Dmitry Torokhov Nice fix. Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [GIT PULL] chrome-platform updates for v4.17

them even in some rebased form. > > I'll take this for now, but next time I see this kind of "late in the > merge window, absolutely zero exposure anywhere else", I'll just skip > the whole pull request. Don't do it. Sorry about that, Linus. Won't hap

[GIT PULL] chrome-platform updates for v4.17

ks, Benson -------- Benson Leung (2): Merge remote-tracking branch 'chrome-platform-stop-being-a-platform-driver-plus-atmel_mxt_ts-for-v4.17' into working-branch-for-4.17 Merge remote-tracking branch 'origin/ib-chrome-platform-cros-ec-sysfs-debugfs

Re: [PATCH v2 00/14] chrome_laptop: stop being a platform driver

| 1 - > drivers/input/touchscreen/atmel_mxt_ts.c | 231 +++--- > drivers/platform/chrome/chromeos_laptop.c | 896 +++-- > include/linux/platform_data/atmel_mxt_ts.h | 31 - > 4 files changed, 579 insertions(+), 580 deletions(-) > delete mode 100644 include/linux/platform_data/atm

[GIT PULL] Immutable branch between MFD and Platform due for the v4.17 merge window

3 + 5 files changed, 194 insertions(+), 59 deletions(-) -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH v2 01/14] Input: atmel_mxt_ts - do not pass suspend mode in platform data

mxt_probe(struct i2c_client *client, const > struct i2c_device_id *id) > init_completion(&data->reset_completion); > init_completion(&data->crc_completion); > > + data->suspend_mode = dmi_check_system(chromebook_T9_suspend_dmi) ? > + MXT_

Re: [PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

> Unnecessary and incorrect whitespace changes. Thanks Alan. Fixed in v3. Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[PATCH v3] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson

Re: [PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

s this (bcdDevice: 0.03 for example) and in my experience > > it has generally matched up with how hardware manufacturers refer > > to their firmware. > > Nevermind, %x should show bcd properly. looks fine. I like the way lsusb -v does it better. Take a look at v2. Thanks, Benson --

[PATCH v2] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Match the %2x.%02x formatting that's used by lsusb -v for this same value. Signed-off-by: Benson

[PATCH] USB: announce bcdDevice as well as idVendor, idProduct.

Print bcdDevice which is used by vendors to identify different versions of the same product (or different versions of firmware). Adding this to the logs will be useful for support purposes. Signed-off-by: Benson Leung --- drivers/usb/core/hub.c | 16 +--- 1 file changed, 9

Re: [PATCH v2 05/14] platform/chrome: chromeos_laptop - stop setting suspend mode for Atmel devices

evice = { > > static struct mxt_platform_data atmel_1664s_platform_data = { > .irqflags = IRQF_TRIGGER_FALLING, > - .suspend_mode = MXT_SUSPEND_T9_CTRL, > }; > > static struct i2c_board_info atmel_1664s_device = { > -- > 2.16.2.804.g6dcf76e118-goog

Re: [PATCH 07/14] platform/chrome: chromeos_laptop - factor out getting IRQ from DMI

pr_err("failed to get data from dmi for %s\n", name); > + info->irq = chromeos_laptop_get_irq_from_dmi(name); > + if (info->irq < 0) > return NULL; > - } > - info->irq = dev_data->instance; > } > > adapter = i2c_get_adapter(bus); > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 06/14] platform/chrome: chromeos_laptop - introduce pr_fmt()

c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -4,6 +4,8 @@ > // Copyright (C) 2012 Google, Inc. > // Author: Benson Leung > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include > #include > #include > @@ -139,15 +1

Re: [PATCH 04/14] platform/chrome: chromeos_laptop - add SPDX identifier

599736a41a2..54a13c70e1d8f 100644 > --- a/drivers/platform/chrome/chromeos_laptop.c > +++ b/drivers/platform/chrome/chromeos_laptop.c > @@ -1,25 +1,8 @@ > -/* > - * chromeos_laptop.c - Driver to instantiate Chromebook i2c/smbus devices. > - * > - * Author : Benson Leung > - *

Re: [RESEND][PATCH] platform/chrome: cros_ec_lpc: Add support for Google devices using custom coreboot firmware

ot;Google_*" as BIOS version string, > instead the system vendor string would still be "GOOGLE", so this > seems to be a reasonable match for every Chromebook/box running > a custom firmware. > > Signed-off-by: Salvatore Bellizzi > Signed-off-by: Vittorio Gambaletta

Re: [PATCH] platform/chrome: cros_ec_lpc: wake up from s2idle on Chrome EC

2idle can happen. > > Suggested-by: Rafael J. Wysocki > Signed-off-by: Wenkai Du LGTM. Applied to my for v4.17 branch. Thank you! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.as

Re: [PATCH 1/3] powercap: intel_rapl: Add support for Cannon Lake

ore), > > RAPL_CPU(INTEL_FAM6_ATOM_SILVERMONT1, rapl_defaults_byt), > RAPL_CPU(INTEL_FAM6_ATOM_AIRMONT, rapl_defaults_cht), > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: OpenPGP digital signature

Re: [PATCH 3/3] perf/x86/intel: Enable C-state residency events for Cannon Lake

. > > Signed-off-by: Harry Pan Reviewed-by: Benson Leung > --- > arch/x86/events/intel/cstate.c | 44 > +- > 1 file changed, 31 insertions(+), 13 deletions(-) > > diff --git a/arch/x86/events/intel/cstate.c b/arch/x8

Re: [PATCH 2/3] perf/x86/intel: Add Cannon Lake support of RAPL profiling

example: > > $ perf list > $ perf stat -a -e power/energy-cores/,power/energy-pkg/ sleep 10 > > Signed-off-by: Harry Pan Reviewed-by: Benson Leung > --- > arch/x86/events/intel/rapl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/events/intel/ra

Re: [PATCH 1/3] powercap: intel_rapl: Add support for Cannon Lake

Hi Harry, On 03/09/2018 04:15 AM, Harry Pan wrote: > Cannon Lake microarchitecture is similar to Kaby Lake in terms of > RAPL, this patch enables CNL RAPL support. > > Signed-off-by: Harry Pan Reviewed-by: Benson Leung > --- > drivers/powercap/intel_rapl.c | 1 + &g

Re: [PATCH 00/14] chrome_laptop: stop being a platform driver

tree > (if you are OK with the patches, of course). > I'm all for this change. I can push this through my tree. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform fixes on v4.16-rc4

(-) Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] Revert "platform/chrome: chromeos_laptop: make chromeos_laptop const"

}, > }; > > -static const struct chromeos_laptop hp_pavilion_14_chromebook = { > +static struct chromeos_laptop hp_pavilion_14_chromebook = { > .i2c_peripherals = { > /* Touchpad. */ > { .add = setup_cyapa_tp, I2C_ADAPTER_SMBUS }, > }, >

Re: [PATCH] Revert "mfd: cros_ec: Add ACPI GPE handler for LID0 devices"

wake up doesn't work because default EC > event handler that can wake up system is not getting called. > > Signed-off-by: Wenkai Du Acked-by: Benson Leung > --- > drivers/mfd/Makefile | 1 - > drivers/mfd/cros_ec.c | 15 ++ &

Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

os_ec.h | 2 ++ Looks like this will need an immutable branch between mfd and chrome-platform again, Lee. Do you want to do one, or should I? Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform updates for v4.16

maintenance fixes. Arnd Bergmann (1): cros_ec: fix nul-termination for firmware build info Benson Leung (1): Merge branch 'ibs-for-chrome-platform-merged' into working-branch-for-4.16 Bhumika Goyal (1): platf

Re: linux-next: Signed-off-by missing for commit in the chrome-platform tree

Hi Stephen, On Mon, Dec 18, 2017 at 07:57:20AM +1100, Stephen Rothwell wrote: > Hi Benson, > > Commit > > b2104e654703 ("platform/chrome: cros_ec_lpc: remove redundant pointer > request") > > is missing a Signed-off-by from its committer. Thanks for t

[PATCH] mfd: cros_ec_dev - Use devm_mfd_add_devices

Kevin (DT) [ 123.536242] task: ffc0f28bab80 task.stack: ffc0f1b3 [ 123.536247] PC is at sysfs_warn_dup+0x68/0x84 [ 123.536251] LR is at sysfs_warn_dup+0x68/0x84 Signed-off-by: Jeffy Chen [bleung: resending this patch after the move to mfd from platform/chrome] Signed-off-by: Benson Leung --- d

[PATCH] mfd: cros_ec: register shutdown function for debugfs

Wu Signed-off-by: Thierry Escande [resent this patch after rename of this file from platform/chrome to mfd] Signed-off-by: Benson Leung --- drivers/mfd/cros_ec_dev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

On Fri, Dec 01, 2017 at 11:49:54AM -0800, Gwendal Grignou wrote: > Checked against 7412f0a0d90ee6ddbad4cde794f88f1489422f3a (CHROMIUM: > platform/chrome: Support MKBP protocol over ACPI) > Reviewed-by: Gwendal Grignou > Thanks Gwendal. (ps, don't top post.) -- Benson Leu

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"), > + }, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table); > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

platform_driver_unregister(&cros_ec_lpc_driver); > + cros_ec_lpc_reg_destroy(); > + } > + } > + > + return ret; > } > > static void __exit cros_ec_lpc_exit(void) > { > + if (!cros_ec_lpc_acpi_device_found) > +

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

pport for GOOG004 > ACPI device") > Signed-off-by: Guenter Roeck > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Thierry Escande Applied for v4.16. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS

Re: [PATCH] platform/chrome: cros_ec_lpc: remove redundant pointer request

r_lpc(struct cros_ec_device *ec, > /* Write buffer */ > cros_ec_lpc_write_bytes(EC_LPC_ADDR_HOST_PACKET, ret, ec->dout); > > - request = (struct ec_host_request *)ec->dout; > - > /* Here we go */ > sum = EC_COMMAND_PROTOCOL_3; > cros_ec_lpc_write_byte

Re: [PATCH] cros_ec: fix nul-termination for firmware build info

> 4294967295 is above array bounds of 'uint8_t[]' [-Werror=array-bounds] > > This changes the code back to what it did before changing to a > zero-length array structure. > > Fixes: a841178445bb ("mfd: cros_ec: Use a zero-length array for command data") > Sign

Re: [GIT PULL] Immutable branch between MFD and Platform due for the v4.16 merge window

s Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Excellent. Pulled. Thank you so much! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

[PATCH 2/5] ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/intel/boards

[PATCH 0/5] ASoC: Map BTN_0 for Android Headsets to KEY_PLAYPAUSE

The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support.

[PATCH 4/5] ASoC: rk3399_gru_sound: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/rockchip/rk3399_gru_sound.c

[PATCH 1/5] ASoC: Intel: kbl_rt5663_rt5514_max98927: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/intel/boards

[PATCH 3/5] ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/codecs/ts3a227e.c | 2 +- 1

[PATCH 5/5] ASoC: qcom: apq8016-sbc: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/qcom/apq8016_sbc.c | 2 +- 1

Re: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling

27; results is > almost always the wrong decision, and can result in host commands > silently being lost. > > Reported-and-tested-by: Jon Hunter > Signed-off-by: Shawn Nematbakhsh Acked-by: Benson Leung > --- > drivers/mfd/cros_ec_spi.c | 52 > ++

Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

is zero. Remove the code that checks if this variable is zero. > > Signed-off-by: Jon Hunter > Reviewed-by: Brian Norris Acked-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH V2 1/2] mfd: cros ec: spi: Don't send first message too soon

iable after calling > spi_setup() and before sending the first SPI message. > > Cc: > > Signed-off-by: Jon Hunter > Reviewed-by: Brian Norris Acked-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] HID: hidraw: fix power sequence when closing device

; Signed-off-by: Dmitry Torokhov Reviewed-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

+/475212 > > Ok, thanks, will use that one. How about > > Reviewed-by: Benson Leung > > which is missing in the mail you've sent, but is there in the above > reference commit? Submission looks good to me. Go ahead and add. Reviewed-by: Benson Leung Thanks, Bens

Re: linux-next: Signed-off-by missing for commit in the chrome-platform tree

t;) > 3bd61d4d1d9e ("platform/chrome: cros_ec: Add sysfs entry to set keyboard > wake lid angle") > > are missing a Signed-off-by from their committer. > Whoops. My mistake. Will fix. Thanks! > -- > Cheers, > Stephen Rothwell -- Benson Leung Staff Software Eng

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

Hi Oliver, On Mon, Sep 11, 2017 at 01:02:52PM -0700, Benson Leung wrote: > Thanks for the pointer. I'll respin the patch with the no_resume version of > usb_autopm_get_interface and retest. > I went and tried this patch but with usb_autopm_get_interface_no_resume instead and the

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

Hi Oliver, On Sat, Sep 09, 2017 at 09:35:52AM +0200, Oliver Neukum wrote: > Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov: > > From: Benson Leung > > > > usbhid->intf->needs_remote_wakeup is set when a device is opened, and is > > cleared whe

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

> Signed-off-by: Shawn Nematbakhsh > Signed-off-by: Brian Norris > Reviewed-by: Javier Martinez Canillas Looks good. Applied for v4.14. Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

to do something meaningful. > Also, this patch makes use of cros_ec_cmd_xfer_status() instead of > cros_ec_cmd_xfer() so an error message is printed in the syslog. > > Signed-off-by: Gwendal Grignou > Signed-off-by: Thierry Escande Looks good. Applied. -- Benson Leung Staff Soft

Re: [PATCH v2 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

are controlled by the EC. > > This patch also moves the cros_ec features check before the device is > added so the features map obtained from the EC is ready on time. > > Signed-off-by: Gwendal Grignou > Signed-off-by: Thierry Escande V2 Looks good. Applied. Thanks! -- Ben

Re: [PATCH] platform/chrome: chromeos_laptop: make chromeos_laptop const

Applied. Thanks for the patch! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] platform/chrome: cros_ec_dev - Use devm_mfd_add_devices

n_dup+0x68/0x84 > > Signed-off-by: Jeffy Chen Thanks for the fix. Applied for v4.14. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

his patch registers a shutdown callback used to cancel the debugfs log > worker thread. > > Signed-off-by: Daniel Hung-yu Wu > Signed-off-by: Thierry Escande Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromi

Re: [PATCH v2 3/8] mfd: cros_ec: Stop the debugfs work when suspended

i5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson > Signed-off-by: Thierry Escande Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@g

Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

iner_of(dev, struct cros_ec_dev, > + class_dev); > + > + if (a == &dev_attr_kb_wake_angle.attr && !ec->has_kb_wake_angle) > + return 0; > + > + return a->mode; > +} > + > struct attribute_group cros_ec_attr_group = { > .attrs = __ec_attrs, > + .is_visible = cros_ec_ctrl_visible, > }; > > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index 4e887ba..350b8a4 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -191,6 +191,7 @@ struct cros_ec_dev { > struct cros_ec_device *ec_dev; > struct device *dev; > struct cros_ec_debugfs *debug_info; > + bool has_kb_wake_angle; > u16 cmd_offset; > u32 features[2]; > }; > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH 6/8] mfd: cros_ec_i2c: add ACPI module device table

ry Escande Acked-by: Benson Leung > --- > drivers/mfd/cros_ec_i2c.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c > index 576fcc4..56fc667 100644 > --- a/drivers/mfd/cros_ec_i2c.c > +++

Re: [PATCH 5/8] mfd: cros_ec: fail early if we cannot identify the EC

uninformed mistakes (using the wrong protocol, the > wrong buffer size, mixing the EC with other chips). > > Signed-off-by: Vincent Palatin > Signed-off-by: Thierry Escande Acked-by: Benson Leung > --- > drivers/mfd/cros_ec.c | 6 +- > 1 file changed, 5 insertions(+), 1

Re: [PATCH 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

his patch registers a shutdown callback used to cancel the debugfs log > worker thread. > > Signed-off-by: Daniel Hung-yu Wu > Signed-off-by: Thierry Escande Applied. Thanks. Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromi

Re: [PATCH 3/8] mfd: cros_ec: Stop the debugfs work when suspended

ros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson > Signed-off-by: Thierry Escande Looks good. Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Ker

Re: [PATCH 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late

; normally. > > Signed-off-by: Joseph Lo > Signed-off-by: Thierry Escande Acked-by: Benson Leung Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH 1/8] iio: cros_ec: Relax sampling frequency before suspending

ight_prox.c > index 7217223..f8658d4 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -279,6 +279,7 @@ MODULE_DEVICE_TABLE(platform, cros_ec_light_prox_ids); > static struct platform_driver cros_ec_light_prox_platform_driver = { > .driver = { > .name = "cros-ec-light-prox", > + .pm = &cros_ec_sensors_pm_ops, > }, > .probe = cros_ec_light_prox_probe, > .id_table = cros_ec_light_prox_ids, > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

e this configuration, but the first one we shipped did, so we will have to support it. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v3 3/4] rtc: cros-ec: add cros-ec-rtc driver.

o i Serra > Acked-by: Alexandre Belloni Acked-by: Benson Leung Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v3 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.

o i Serra > Acked-by: Lee Jones Acked-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: OpenPGP digital signature

[GIT PULL] chrome-platform updates for v4.13

): platform/chrome: cros_ec_lightbar - hide unused PM functions Benson Leung (1): platform/chrome : Add myself as Maintainer Eric Caruso (4): mfd: cros_ec: add debugfs, console log file platform/chrome: cros_ec_lightbar - Add lightbar program feature to sysfs platform

Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events

Hi Lee, On Mon, Jul 03, 2017 at 12:46:41PM +0100, Lee Jones wrote: > On Tue, 27 Jun 2017, Benson Leung wrote: > > > Hi Thierry, > > > > On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote: > > > From: Shawn Nematbakhsh > > > > > >

Re: [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions

Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of > suspend/resume lightbar sequence") > Signed-off-by: Arnd Bergmann Good catch. Applied. Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events

drivers/platform/chrome/cros_ec_proto.c | 76 > ++--- > include/linux/mfd/cros_ec.h | 5 ++- > 3 files changed, 85 insertions(+), 9 deletions(-) > Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since this patch was posted, so I went ahead and

Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe

Thierry Escande Applied. Thanks again! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 1/3] cros_ec: Don't return error when checking command version

supported > field) and cros_ec_query_all() returns 0. > > Signed-off-by: Thierry Escande Applied. Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH RESEND 13/13] platform/chrome: cros_ec_lightbar - Avoid I2C xfer to EC during suspend

y Yu > Signed-off-by: Guenter Roeck > Signed-off-by: Enric Balletbo i Serra Signed-off-by: Benson Leung Applied. > --- > drivers/platform/chrome/cros_ec_dev.c | 12 > drivers/platform/chrome/cros_ec_lightbar.c | 13 + > 2 files changed, 13 inserti

Re: [PATCH RESEND 12/13] platform/chrome: cros_ec_lightbar - Add userspace lightbar control bit to EC

resume pathways. > > Signed-off-by: Eric Caruso > Signed-off-by: Guenter Roeck > Signed-off-by: Enric Balletbo i Serra Signed-off-by: Benson Leung Applied. > --- > drivers/platform/chrome/cros_ec_lightbar.c | 38 > ++ > 1 file changed, 38

Re: [PATCH RESEND 11/13] platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence

lletbo i Serra > Acked-by: Lee Jones Signed-off-by: Benson Leung Applied. Thanks. > --- > drivers/platform/chrome/cros_ec_dev.c | 37 + > drivers/platform/chrome/cros_ec_dev.h | 6 +++ > drivers/platform/chrome/cros_ec_lightbar.c | 85 >

<    1   2   3   4   5   >