Increase maximum mkbp event size")
>
> Acked-by: Enric Balletbo i Serra
> Tested-by: Emil Renner Berthing
> Signed-off-by: Emil Karlson
Applied. Sent to Greg for rc8, hopefully.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
&& ec_dev->irq <= 0) {
> status = acpi_install_notify_handler(adev->handle,
>ACPI_ALL_NOTIFY,
>cros_ec_lpc_acpi_notify,
> --
> 2.19.0.605.g01d371f741-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
&& ec_dev->irq <= 0) {
> status = acpi_install_notify_handler(adev->handle,
>ACPI_ALL_NOTIFY,
>cros_ec_lpc_acpi_notify,
> --
> 2.19.0.605.g01d371f741-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
insertions(+), 221 deletions(-)
rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_mec.h (96%)
rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_reg.h (94%)
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Proje
insertions(+), 221 deletions(-)
rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_mec.h (96%)
rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_reg.h (94%)
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Proje
(-)
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
(-)
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
his as urgent fix for the coming release I
> am
> happy with it. We can always send follow up patches to sync with the
> downstream
> version if is preferred.
>
> Neil, can you give us your Tested-by to have the make sure this doesn't break
> with protocol v1, I don't have such hardware.
>
&
his as urgent fix for the coming release I
> am
> happy with it. We can always send follow up patches to sync with the
> downstream
> version if is preferred.
>
> Neil, can you give us your Tested-by to have the make sure this doesn't break
> with protocol v1, I don't have such hardware.
>
&
On Mon, Sep 10, 2018 at 5:12 PM Lee Jones wrote:
>
> On Fri, 07 Sep 2018, Benson Leung wrote:
>
> > Hi Enric,
> >
> > On Wed, Jul 18, 2018 at 06:09:56PM +0200, Enric Balletbo i Serra wrote:
> > > cros-ec includes inside the MFD subsystem, specially the fil
On Mon, Sep 10, 2018 at 5:12 PM Lee Jones wrote:
>
> On Fri, 07 Sep 2018, Benson Leung wrote:
>
> > Hi Enric,
> >
> > On Wed, Jul 18, 2018 at 06:09:56PM +0200, Enric Balletbo i Serra wrote:
> > > cros-ec includes inside the MFD subsystem, specially the fil
mentation.
> This patch tries to improve the documentation and also fixes all the
> issues reported by kerneldoc script.
>
> Signed-off-by: Enric Balletbo i Serra
Applied, thanks.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Projec
mentation.
> This patch tries to improve the documentation and also fixes all the
> issues reported by kerneldoc script.
>
> Signed-off-by: Enric Balletbo i Serra
Applied, thanks.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Projec
includes
> are only used for the platform driver and are not really related to the
> MFD subsystem, so move the includes from include/linux/mfd to
> drivers/platform/chrome.
>
> Signed-off-by: Enric Balletbo i Serra
Thanks. Applied to my working branch for v4.20.
--
Benson Leung
includes
> are only used for the platform driver and are not really related to the
> MFD subsystem, so move the includes from include/linux/mfd to
> drivers/platform/chrome.
>
> Signed-off-by: Enric Balletbo i Serra
Thanks. Applied to my working branch for v4.20.
--
Benson Leung
ce/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2:
> error: implicit declaration of function 'usleep_range'
> [-Werror,-Wimplicit-function-declaration]
> usleep_range(1, 11000);
> ^
>
> Including delay.h "fixes" this.
>
> Signed-
ce/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2:
> error: implicit declaration of function 'usleep_range'
> [-Werror,-Wimplicit-function-declaration]
> usleep_range(1, 11000);
> ^
>
> Including delay.h "fixes" this.
>
> Signed-
h | 295 +++---
> > 8 files changed, 322 insertions(+), 221 deletions(-)
> > rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_mec.h
> > (96%)
> > rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_reg.h
>
h | 295 +++---
> > 8 files changed, 322 insertions(+), 221 deletions(-)
> > rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_mec.h
> > (96%)
> > rename {include/linux/mfd => drivers/platform/chrome}/cros_ec_lpc_reg.h
>
On Tue, Aug 21, 2018 at 01:40:21PM -0700, Linus Torvalds wrote:
> On Tue, Aug 21, 2018 at 11:54 AM Benson Leung wrote:
> >
> > Minor changes this time around for 4.19.
> >
> > cros_ec_i2c and cros_ec_spi drivers moved from mfd
> > to chrome platform.
>
> A
On Tue, Aug 21, 2018 at 01:40:21PM -0700, Linus Torvalds wrote:
> On Tue, Aug 21, 2018 at 11:54 AM Benson Leung wrote:
> >
> > Minor changes this time around for 4.19.
> >
> > cros_ec_i2c and cros_ec_spi drivers moved from mfd
> > to chrome platform.
>
> A
.
cros_ec_i2c and cros_ec_spi drivers moved from mfd
to chrome platform.
Benson Leung (2):
platform/chrome: chromeos_tbmc - fix SPDX identifier
Merge tag 'ib-platform-chrome-mfd-move-cros-ec-transport-for-4.19' into
working
.
cros_ec_i2c and cros_ec_spi drivers moved from mfd
to chrome platform.
Benson Leung (2):
platform/chrome: chromeos_tbmc - fix SPDX identifier
Merge tag 'ib-platform-chrome-mfd-move-cros-ec-transport-for-4.19' into
working
2c.c (100%)
rename drivers/{mfd => platform/chrome}/cros_ec_spi.c (100%)
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
2c.c (100%)
rename drivers/{mfd => platform/chrome}/cros_ec_spi.c (100%)
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
or the others to pull. What do you all think?
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
or the others to pull. What do you all think?
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
e you are pushing this through arm-soc or Russell.
> In such case, for Exynos boards:
> Acked-by: Krzysztof Kozlowski
>
> Best regards,
> Krzysztof
I was planning on creating an immutable branch for this series and merging it
through platform/chrome.
Lee, Russell, Dmitry, what do
e you are pushing this through arm-soc or Russell.
> In such case, for Exynos boards:
> Acked-by: Krzysztof Kozlowski
>
> Best regards,
> Krzysztof
I was planning on creating an immutable branch for this series and merging it
through platform/chrome.
Lee, Russell, Dmitry, what do
s: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")
Gwendal, in PATCH v2 of https://patchwork.kernel.org/patch/10439449/
you mentioned that you readded the __remove to avoid a warning when built
as a module. Can you explain what's going on?
Benson
--
Benson Leung
St
s: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")
Gwendal, in PATCH v2 of https://patchwork.kernel.org/patch/10439449/
you mentioned that you readded the __remove to avoid a warning when built
as a module. Can you explain what's going on?
Benson
--
Benson Leung
St
gt;input->users;
> > @@ -426,7 +424,6 @@ static void acpi_button_notify(struct acpi_device
> > *device, u32 event)
> > } else {
> > int keycode;
> >
> > - acpi_pm_wakeup_event(>dev);
> >
gt;input->users;
> > @@ -426,7 +424,6 @@ static void acpi_button_notify(struct acpi_device
> > *device, u32 event)
> > } else {
> > int keycode;
> >
> > - acpi_pm_wakeup_event(>dev);
> >
// Copyright (C) 2013 Google, Inc.
>
> #include
> #include
> --
> 2.17.1
>
Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
// Copyright (C) 2013 Google, Inc.
>
> #include
> #include
> --
> 2.17.1
>
Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
e
> diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c
> b/drivers/platform/chrome/cros_kbd_led_backlight.c
> index ca3e4da852b4..bd4aa9331806 100644
> --- a/drivers/platform/chrome/cros_kbd_led_backlight.c
> +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
>
e
> diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c
> b/drivers/platform/chrome/cros_kbd_led_backlight.c
> index ca3e4da852b4..bd4aa9331806 100644
> --- a/drivers/platform/chrome/cros_kbd_led_backlight.c
> +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
>
On Tue, Jun 05, 2018 at 07:54:28PM +0200, Enric Balletbo i Serra wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Benson Leung
> ---
>
> Changes in v2:
> - [8/9] Fi
On Tue, Jun 05, 2018 at 07:54:28PM +0200, Enric Balletbo i Serra wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management.
>
> Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Benson Leung
> ---
>
> Changes in v2:
> - [8/9] Fi
> source for the last wake will be thrown off by this. Instead increment
> the wakeup count only when there is a FIXED_HARDWARE/NOTFIY_STATUS event.
>
> Signed-off-by: Ravi Chandra Sadineni
Reviewed-by: Benson Leung
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google I
> source for the last wake will be thrown off by this. Instead increment
> the wakeup count only when there is a FIXED_HARDWARE/NOTFIY_STATUS event.
>
> Signed-off-by: Ravi Chandra Sadineni
Reviewed-by: Benson Leung
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google I
driver, which is useful for x86
convertible Chromebooks.
Other misc. cleanup.
Thanks,
Benson
Arnd Bergmann (1):
platform: chrome: Add input dependency for tablet switch driver
Benson Leung (2):
platform/chrome
driver, which is useful for x86
convertible Chromebooks.
Other misc. cleanup.
Thanks,
Benson
Arnd Bergmann (1):
platform: chrome: Add input dependency for tablet switch driver
Benson Leung (2):
platform/chrome
ction to check EC
> features.")
> Cc: Benson Leung
> Cc: Enric Balletbo i Serra
> Cc: Gwendal Grignou
> Cc: Andy Shevchenko
> Signed-off-by: Stephen Boyd
Acked-by: Benson Leung
> ---
> drivers/mfd/cros_ec_dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 delet
ction to check EC
> features.")
> Cc: Benson Leung
> Cc: Enric Balletbo i Serra
> Cc: Gwendal Grignou
> Cc: Andy Shevchenko
> Signed-off-by: Stephen Boyd
Acked-by: Benson Leung
> ---
> drivers/mfd/cros_ec_dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 delet
he new macro in cros_ec.h through my tree. Looks to
merge clean with mfd's changes this time.
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
he new macro in cros_ec.h through my tree. Looks to
merge clean with mfd's changes this time.
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
ton being stuck in pressed state
> after the first click.
>
> Reported-by: Sultan Alsawaf
> Signed-off-by: Dmitry Torokhov
Applied for v4.18. Thanks.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
sig
ton being stuck in pressed state
> after the first click.
>
> Reported-by: Sultan Alsawaf
> Signed-off-by: Dmitry Torokhov
Applied for v4.18. Thanks.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
sig
efined!
>
> This adds the corresponding Kconfig dependency
>
> Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver")
> Signed-off-by: Arnd Bergmann
Thanks for the catch! Applied for 4.18.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Go
efined!
>
> This adds the corresponding Kconfig dependency
>
> Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver")
> Signed-off-by: Arnd Bergmann
Thanks for the catch! Applied for 4.18.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Go
; + uint8_t address;
> + };
> +} __packed;
> +
> +/* Read various CEC parameters */
> +#define EC_CMD_CEC_GET 0x00BB
> +
> +struct ec_params_cec_get {
> + uint8_t cmd; /* enum cec_command */
> +} __packed;
> +
> +struct ec_response_cec_get {
&
};
> +} __packed;
> +
> +/* Read various CEC parameters */
> +#define EC_CMD_CEC_GET 0x00BB
> +
> +struct ec_params_cec_get {
> + uint8_t cmd; /* enum cec_command */
> +} __packed;
> +
> +struct ec_response_cec_get {
> + union {
> + uint8_t enable;
return ret;
> + }
> + return 0;
> +}
> +
> +static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] = {
> + { ACPI_DRV_NAME, 0 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids);
> +
> +static const SIMPLE_D
return 0;
> +}
> +
> +static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] = {
> + { ACPI_DRV_NAME, 0 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids);
> +
> +static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL,
k...@gmail.com>
Looks good with the chromeos_laptop patch that preceeds this.
Reviewed-by: Benson Leung <ble...@chromium.org>
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 152 ++-
> 1 file changed, 12 insertions(+), 140 deletions(-)
>
> diff --g
good with the chromeos_laptop patch that preceeds this.
Reviewed-by: Benson Leung
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 152 ++-
> 1 file changed, 12 insertions(+), 140 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
&g
(1):
platform/chrome: chromeos_laptop - supply properties for ACPI devices
drivers/platform/chrome/chromeos_laptop.c | 307 +++---
1 file changed, 278 insertions(+), 29 deletions(-)
Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble
(1):
platform/chrome: chromeos_laptop - supply properties for ACPI devices
drivers/platform/chrome/chromeos_laptop.c | 307 +++---
1 file changed, 278 insertions(+), 29 deletions(-)
Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble
return ERR_PTR(-ENOMEM);
> +
> + error = chromeos_laptop_prepare_i2c_peripherals(cros_laptop, src);
> + if (!error)
> + error = chromeos_laptop_prepare_acpi_peripherals(cros_laptop,
> + src);
> +
> +
+ error = chromeos_laptop_prepare_i2c_peripherals(cros_laptop, src);
> + if (!error)
> + error = chromeos_laptop_prepare_acpi_peripherals(cros_laptop,
> + src);
> +
> + if (error) {
> +
On Wed, May 23, 2018 at 11:19 AM Guenter Roeck <li...@roeck-us.net> wrote:
> What happened with this driver ? It is not upstream, yet the comments
> on patchwork seem to suggest that it was accepted.
My bad. I dropped this last year. I'll pick this now.
--
Benson Leung
Staff Softw
On Wed, May 23, 2018 at 11:19 AM Guenter Roeck wrote:
> What happened with this driver ? It is not upstream, yet the comments
> on patchwork seem to suggest that it was accepted.
My bad. I dropped this last year. I'll pick this now.
--
Benson Leung
Staff Software Engineer
Chrome OS
rokhov <dmitry.torok...@gmail.com>
Nice fix. Applied.
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
itry Torokhov
Nice fix. Applied.
Thanks,
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
based form.
>
> I'll take this for now, but next time I see this kind of "late in the
> merge window, absolutely zero exposure anywhere else", I'll just skip
> the whole pull request. Don't do it.
Sorry about that, Linus. Won't happen again.
--
Benson Leung
Staff Softw
based form.
>
> I'll take this for now, but next time I see this kind of "late in the
> merge window, absolutely zero exposure anywhere else", I'll just skip
> the whole pull request. Don't do it.
Sorry about that, Linus. Won't happen again.
--
Benson Leung
Staff Softw
Benson Leung (2):
Merge remote-tracking branch
'chrome-platform-stop-being-a-platform-driver-plus-atmel_mxt_ts-for-v4.17' into
working-branch-for-4.17
Merge remote-tracking branch
'origin/ib-chrome-platform-cros-ec-sysfs-debugfs-for-v4.17' into
working
Benson Leung (2):
Merge remote-tracking branch
'chrome-platform-stop-being-a-platform-driver-plus-atmel_mxt_ts-for-v4.17' into
working-branch-for-4.17
Merge remote-tracking branch
'origin/ib-chrome-platform-cros-ec-sysfs-debugfs-for-v4.17' into
working
1 -
> drivers/input/touchscreen/atmel_mxt_ts.c | 231 +++---
> drivers/platform/chrome/chromeos_laptop.c | 896 +++--
> include/linux/platform_data/atmel_mxt_ts.h | 31 -
> 4 files changed, 579 insertions(+), 580 deletions(-)
> delete mode 100644 include/linux/platform_data/atmel_mxt_ts.
1 -
> drivers/input/touchscreen/atmel_mxt_ts.c | 231 +++---
> drivers/platform/chrome/chromeos_laptop.c | 896 +++--
> include/linux/platform_data/atmel_mxt_ts.h | 31 -
> 4 files changed, 579 insertions(+), 580 deletions(-)
> delete mode 100644 include/linux/platform_data/atmel_mxt_ts.
changed, 194 insertions(+), 59 deletions(-)
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
changed, 194 insertions(+), 59 deletions(-)
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
35,6 +3149,9 @@ static int mxt_probe(struct i2c_client *client, const
> struct i2c_device_id *id)
> init_completion(>reset_completion);
> init_completion(>crc_completion);
>
> + data->suspend_mode = dmi_check_system(chromebook_T9_suspend_dmi) ?
> +
(struct i2c_client *client, const
> struct i2c_device_id *id)
> init_completion(>reset_completion);
> init_completion(>crc_completion);
>
> + data->suspend_mode = dmi_check_system(chromebook_T9_suspend_dmi) ?
> + MXT_SUSPEND_T9_CTRL : MXT_SUS
ary and incorrect whitespace changes.
Thanks Alan. Fixed in v3.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
ary and incorrect whitespace changes.
Thanks Alan. Fixed in v3.
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Match the %2x.%02x formatting that's used by lsusb -v for this same value.
Signed-off-by: Benson Leung
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Match the %2x.%02x formatting that's used by lsusb -v for this same value.
Signed-off-by: Benson Leung
s this (bcdDevice: 0.03 for example) and in my experience
> > it has generally matched up with how hardware manufacturers refer
> > to their firmware.
>
> Nevermind, %x should show bcd properly. looks fine.
I like the way lsusb -v does it better. Take a look at v2.
Thanks,
Benson
--
s this (bcdDevice: 0.03 for example) and in my experience
> > it has generally matched up with how hardware manufacturers refer
> > to their firmware.
>
> Nevermind, %x should show bcd properly. looks fine.
I like the way lsusb -v does it better. Take a look at v2.
Thanks,
Benson
--
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Match the %2x.%02x formatting that's used by lsusb -v for this same value.
Signed-off-by: Benson Leung
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Match the %2x.%02x formatting that's used by lsusb -v for this same value.
Signed-off-by: Benson Leung
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Signed-off-by: Benson Leung <ble...@chromium.org>
---
drivers/usb/core/hub.c | 16 +
Print bcdDevice which is used by vendors to identify different versions
of the same product (or different versions of firmware).
Adding this to the logs will be useful for support purposes.
Signed-off-by: Benson Leung
---
drivers/usb/core/hub.c | 16 +---
1 file changed, 9
_board_info atmel_224s_tp_device = {
>
> static struct mxt_platform_data atmel_1664s_platform_data = {
> .irqflags = IRQF_TRIGGER_FALLING,
> - .suspend_mode = MXT_SUSPEND_T9_CTRL,
> };
>
> static struct i2c_board_info atmel_1664s_device = {
> --
>
= {
>
> static struct mxt_platform_data atmel_1664s_platform_data = {
> .irqflags = IRQF_TRIGGER_FALLING,
> - .suspend_mode = MXT_SUSPEND_T9_CTRL,
> };
>
> static struct i2c_board_info atmel_1664s_device = {
> --
> 2.16.2.804.g6dcf76e118-goog
>
if (!dev_data) {
> - pr_err("failed to get data from dmi for %s\n", name);
> + info->irq = chromeos_laptop_get_irq_from_dmi(name);
> + if (info->irq < 0)
> return NULL;
> - }
> - info->irq = dev_data->instance;
> }
>
> adapter = i2c_get_adapter(bus);
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
pr_err("failed to get data from dmi for %s\n", name);
> + info->irq = chromeos_laptop_get_irq_from_dmi(name);
> + if (info->irq < 0)
> return NULL;
> - }
> - info->irq = dev_data->instance;
> }
>
> adapter = i2c_get_adapter(bus);
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
atform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -4,6 +4,8 @@
> // Copyright (C) 2012 Google, Inc.
> // Author: Benson Leung <ble...@chromium.org>
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #incl
c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -4,6 +4,8 @@
> // Copyright (C) 2012 Google, Inc.
> // Author: Benson Leung
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> #include
> #include
> #include
> @@ -139,15 +1
omeos_laptop.c
> index d8599736a41a2..54a13c70e1d8f 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -1,25 +1,8 @@
> -/*
> - * chromeos_laptop.c - Driver to instantiate Chromebook i2c/smbus devices.
&
599736a41a2..54a13c70e1d8f 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -1,25 +1,8 @@
> -/*
> - * chromeos_laptop.c - Driver to instantiate Chromebook i2c/smbus devices.
> - *
> - * Author : Ben
ff-by: Vittorio Gambaletta <linuxb...@vittgam.net>
Applied for v4.17.
Thanks!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: PGP signature
ot;Google_*" as BIOS version string,
> instead the system vendor string would still be "GOOGLE", so this
> seems to be a reasonable match for every Chromebook/box running
> a custom firmware.
>
> Signed-off-by: Salvatore Bellizzi
> Signed-off-by: Vittorio Gambaletta
2idle can happen.
>
> Suggested-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
> Signed-off-by: Wenkai Du <wenkai...@intel.com>
LGTM. Applied to my for v4.17 branch.
Thank you!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@goog
2idle can happen.
>
> Suggested-by: Rafael J. Wysocki
> Signed-off-by: Wenkai Du
LGTM. Applied to my for v4.17 branch.
Thank you!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.as
ANNONLAKE_MOBILE, rapl_defaults_core),
>
> RAPL_CPU(INTEL_FAM6_ATOM_SILVERMONT1, rapl_defaults_byt),
> RAPL_CPU(INTEL_FAM6_ATOM_AIRMONT, rapl_defaults_cht),
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
ore),
>
> RAPL_CPU(INTEL_FAM6_ATOM_SILVERMONT1, rapl_defaults_byt),
> RAPL_CPU(INTEL_FAM6_ATOM_AIRMONT, rapl_defaults_cht),
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
>
> Signed-off-by: Harry Pan <harry@intel.com>
Reviewed-by: Benson Leung <ble...@chromium.org>
> ---
> arch/x86/events/intel/cstate.c | 44
> +-
> 1 file changed, 31 insertions(+), 13 deletions(-)
>
> diff --git a/arc
101 - 200 of 755 matches
Mail list logo
