Re: [PATCH 3/3] perf/x86/intel: Enable C-state residency events for Cannon Lake

> > Signed-off-by: Harry Pan Reviewed-by: Benson Leung > --- > arch/x86/events/intel/cstate.c | 44 > +- > 1 file changed, 31 insertions(+), 13 deletions(-) > > diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/eve

Re: [PATCH 2/3] perf/x86/intel: Add Cannon Lake support of RAPL profiling

ple: > > $ perf list > $ perf stat -a -e power/energy-cores/,power/energy-pkg/ sleep 10 > > Signed-off-by: Harry Pan <harry....@intel.com> Reviewed-by: Benson Leung <ble...@chromium.org> > --- > arch/x86/events/intel/rapl.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH 2/3] perf/x86/intel: Add Cannon Lake support of RAPL profiling

ple: > > $ perf list > $ perf stat -a -e power/energy-cores/,power/energy-pkg/ sleep 10 > > Signed-off-by: Harry Pan Reviewed-by: Benson Leung > --- > arch/x86/events/intel/rapl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/events/intel/rapl.c

Re: [PATCH 1/3] powercap: intel_rapl: Add support for Cannon Lake

Hi Harry, On 03/09/2018 04:15 AM, Harry Pan wrote: > Cannon Lake microarchitecture is similar to Kaby Lake in terms of > RAPL, this patch enables CNL RAPL support. > > Signed-off-by: Harry Pan <harry@intel.com> Reviewed-by: Benson Leung <ble...@chromium.org> &

Re: [PATCH 1/3] powercap: intel_rapl: Add support for Cannon Lake

Hi Harry, On 03/09/2018 04:15 AM, Harry Pan wrote: > Cannon Lake microarchitecture is similar to Kaby Lake in terms of > RAPL, this patch enables CNL RAPL support. > > Signed-off-by: Harry Pan Reviewed-by: Benson Leung > --- > drivers/powercap/intel_rapl.c | 1 + &g

Re: [PATCH 00/14] chrome_laptop: stop being a platform driver

her tree > (if you are OK with the patches, of course). > I'm all for this change. I can push this through my tree. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH 00/14] chrome_laptop: stop being a platform driver

her tree > (if you are OK with the patches, of course). > I'm all for this change. I can push this through my tree. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform fixes on v4.16-rc4

(-) Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform fixes on v4.16-rc4

(-) Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

Re: [PATCH] Revert "platform/chrome: chromeos_laptop: make chromeos_laptop const"

tatic const struct chromeos_laptop acer_c720 = { > }, > }; > > -static const struct chromeos_laptop hp_pavilion_14_chromebook = { > +static struct chromeos_laptop hp_pavilion_14_chromebook = { > .i2c_peripherals = { > /* Touchpad. */ > { .add = setup_cyapa_t

Re: [PATCH] Revert "platform/chrome: chromeos_laptop: make chromeos_laptop const"

}, > }; > > -static const struct chromeos_laptop hp_pavilion_14_chromebook = { > +static struct chromeos_laptop hp_pavilion_14_chromebook = { > .i2c_peripherals = { > /* Touchpad. */ > { .add = setup_cyapa_tp, I2C_ADAPTER_SMBUS }, > }, >

Re: [PATCH] Revert "mfd: cros_ec: Add ACPI GPE handler for LID0 devices"

wake up doesn't work because default EC > event handler that can wake up system is not getting called. > > Signed-off-by: Wenkai Du <wenkai...@intel.com> Acked-by: Benson Leung <ble...@chromium.org> > --- > drivers/mfd/Makefile | 1 - > drivers/mfd/c

Re: [PATCH] Revert "mfd: cros_ec: Add ACPI GPE handler for LID0 devices"

wake up doesn't work because default EC > event handler that can wake up system is not getting called. > > Signed-off-by: Wenkai Du Acked-by: Benson Leung > --- > drivers/mfd/Makefile | 1 - > drivers/mfd/cros_ec.c | 15 ++ >

Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

os_ec_dev.c | 4 > drivers/platform/chrome/cros_ec_debugfs.c | 20 > include/linux/mfd/cros_ec.h | 2 ++ Looks like this will need an immutable branch between mfd and chrome-platform again, Lee. Do you want to do one, or should I? Thanks, Benson -- Benson Leu

Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

| 2 ++ Looks like this will need an immutable branch between mfd and chrome-platform again, Lee. Do you want to do one, or should I? Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature

[GIT PULL] chrome-platform updates for v4.16

maintenance fixes. Arnd Bergmann (1): cros_ec: fix nul-termination for firmware build info Benson Leung (1): Merge branch 'ibs-for-chrome-platform-merged' into working-branch-for-4.16 Bhumika Goyal (1): platform/chrome

[GIT PULL] chrome-platform updates for v4.16

maintenance fixes. Arnd Bergmann (1): cros_ec: fix nul-termination for firmware build info Benson Leung (1): Merge branch 'ibs-for-chrome-platform-merged' into working-branch-for-4.16 Bhumika Goyal (1): platform/chrome

Re: linux-next: Signed-off-by missing for commit in the chrome-platform tree

Hi Stephen, On Mon, Dec 18, 2017 at 07:57:20AM +1100, Stephen Rothwell wrote: > Hi Benson, > > Commit > > b2104e654703 ("platform/chrome: cros_ec_lpc: remove redundant pointer > request") > > is missing a Signed-off-by from its committer. Thanks for t

Re: linux-next: Signed-off-by missing for commit in the chrome-platform tree

Hi Stephen, On Mon, Dec 18, 2017 at 07:57:20AM +1100, Stephen Rothwell wrote: > Hi Benson, > > Commit > > b2104e654703 ("platform/chrome: cros_ec_lpc: remove redundant pointer > request") > > is missing a Signed-off-by from its committer. Thanks for t

[PATCH] mfd: cros_ec_dev - Use devm_mfd_add_devices

rom platform/chrome] Signed-off-by: Benson Leung <ble...@chromium.org> --- drivers/mfd/cros_ec_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index e4fafdd96e5e..0597a2dca024 100644 --- a/drivers/mfd/c

[PATCH] mfd: cros_ec_dev - Use devm_mfd_add_devices

) [ 123.536242] task: ffc0f28bab80 task.stack: ffc0f1b3 [ 123.536247] PC is at sysfs_warn_dup+0x68/0x84 [ 123.536251] LR is at sysfs_warn_dup+0x68/0x84 Signed-off-by: Jeffy Chen [bleung: resending this patch after the move to mfd from platform/chrome] Signed-off-by: Benson Leung --- drivers/mfd

[PATCH] mfd: cros_ec: register shutdown function for debugfs

ed-off-by: Daniel Hung-yu Wu <h...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> [resent this patch after rename of this file from platform/chrome to mfd] Signed-off-by: Benson Leung <ble...@chromium.org> --- drivers/mfd/cros_ec_dev.c | 9

[PATCH] mfd: cros_ec: register shutdown function for debugfs

Wu Signed-off-by: Thierry Escande [resent this patch after rename of this file from platform/chrome to mfd] Signed-off-by: Benson Leung --- drivers/mfd/cros_ec_dev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

On Fri, Dec 01, 2017 at 11:49:54AM -0800, Gwendal Grignou wrote: > Checked against 7412f0a0d90ee6ddbad4cde794f88f1489422f3a (CHROMIUM: > platform/chrome: Support MKBP protocol over ACPI) > Reviewed-by: Gwendal Grignou <gwen...@chromium.org> > Thanks Gwendal. (ps, don't top

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

On Fri, Dec 01, 2017 at 11:49:54AM -0800, Gwendal Grignou wrote: > Checked against 7412f0a0d90ee6ddbad4cde794f88f1489422f3a (CHROMIUM: > platform/chrome: Support MKBP protocol over ACPI) > Reviewed-by: Gwendal Grignou > Thanks Gwendal. (ps, don't top post.) -- Benson Leung St

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

(DMI_SYS_VENDOR, "GOOGLE"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"), > + }, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table); > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer

DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"), > + }, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table); > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

pr_err(DRV_NAME ": can't register device: %d\n", ret); > + platform_driver_unregister(_ec_lpc_driver); > + cros_ec_lpc_reg_destroy(); > + } > + } > + > + return ret; > } > > static

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

_ec_lpc_driver); > + cros_ec_lpc_reg_destroy(); > + } > + } > + > + return ret; > } > > static void __exit cros_ec_lpc_exit(void) > { > + if (!cros_ec_lpc_acpi_device_found) > + platform_device_unregister(_ec_lpc_device); > platform_driver_unregister(_ec_lpc_driver); > cros_ec_lpc_reg_destroy(); > } > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

orm/chrome: cros_ec_lpc: Add support for GOOG004 > ACPI device") > Signed-off-by: Guenter Roeck <gro...@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> App

Re: [PATCH v5 1/3] platform/chrome: cros_ec_lpc: Register the driver if ACPI entry is missing.

for GOOG004 > ACPI device") > Signed-off-by: Guenter Roeck > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Thierry Escande Applied for v4.16. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Proje

Re: [PATCH] platform/chrome: cros_ec_lpc: remove redundant pointer request

8 +64,6 @@ static int cros_ec_pkt_xfer_lpc(struct cros_ec_device *ec, > /* Write buffer */ > cros_ec_lpc_write_bytes(EC_LPC_ADDR_HOST_PACKET, ret, ec->dout); > > - request = (struct ec_host_request *)ec->dout; > - > /* Here we go */ > sum = EC_C

Re: [PATCH] platform/chrome: cros_ec_lpc: remove redundant pointer request

ct cros_ec_device *ec, > /* Write buffer */ > cros_ec_lpc_write_bytes(EC_LPC_ADDR_HOST_PACKET, ret, ec->dout); > > - request = (struct ec_host_request *)ec->dout; > - > /* Here we go */ > sum = EC_COMMAND_PROTOCOL_3; > cros_ec_lpc_write_bytes(EC_LPC_AD

Re: [PATCH] cros_ec: fix nul-termination for firmware build info

d Bergmann <a...@arndb.de> Applied. Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] cros_ec: fix nul-termination for firmware build info

967295 is above array bounds of 'uint8_t[]' [-Werror=array-bounds] > > This changes the code back to what it did before changing to a > zero-length array structure. > > Fixes: a841178445bb ("mfd: cros_ec: Use a zero-length array for command data") > Signed-off-by: Arnd Berg

Re: [GIT PULL] Immutable branch between MFD and Platform due for the v4.16 merge window

s Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Excellent. Pulled. Thank you so much! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [GIT PULL] Immutable branch between MFD and Platform due for the v4.16 merge window

s Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Excellent. Pulled. Thank you so much! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

[PATCH 2/5] ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung <ble...@chromium.org> --- sound/soc

[PATCH 2/5] ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/intel/boards

[PATCH 0/5] ASoC: Map BTN_0 for Android Headsets to KEY_PLAYPAUSE

The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support.

[PATCH 0/5] ASoC: Map BTN_0 for Android Headsets to KEY_PLAYPAUSE

The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support.

[PATCH 1/5] ASoC: Intel: kbl_rt5663_rt5514_max98927: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung <ble...@chromium.org> --- sound/soc

[PATCH 4/5] ASoC: rk3399_gru_sound: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung <ble...@chromium.org> --- sou

[PATCH 4/5] ASoC: rk3399_gru_sound: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/rockchip/rk3399_gru_sound.c

[PATCH 1/5] ASoC: Intel: kbl_rt5663_rt5514_max98927: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/intel/boards

[PATCH 3/5] ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung <ble...@chromium.org> --- sound/soc/

[PATCH 3/5] ASoC: ts3a227e: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/codecs/ts3a227e.c | 2 +- 1

[PATCH 5/5] ASoC: qcom: apq8016-sbc: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung <ble...@chromium.org> --- sound/so

[PATCH 5/5] ASoC: qcom: apq8016-sbc: Map BTN_0 to KEY_PLAYPAUSE

not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung --- sound/soc/qcom/apq8016_sbc.c | 2 +- 1

Re: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling

sults is > almost always the wrong decision, and can result in host commands > silently being lost. > > Reported-and-tested-by: Jon Hunter <jonath...@nvidia.com> > Signed-off-by: Shawn Nematbakhsh <sha...@chromium.org> Acked-by: Benson Leung <ble...@

Re: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling

sults is > almost always the wrong decision, and can result in host commands > silently being lost. > > Reported-and-tested-by: Jon Hunter > Signed-off-by: Shawn Nematbakhsh Acked-by: Benson Leung > --- > drivers/mfd/cros_ec_spi.c | 52 > ++--

Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

checks if this variable is zero. > > Signed-off-by: Jon Hunter <jonath...@nvidia.com> > Reviewed-by: Brian Norris <briannor...@chromium.org> Acked-by: Benson Leung <ble...@chromium.org> -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...

Re: [PATCH V2 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

checks if this variable is zero. > > Signed-off-by: Jon Hunter > Reviewed-by: Brian Norris Acked-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH V2 1/2] mfd: cros ec: spi: Don't send first message too soon

> spi_setup() and before sending the first SPI message. > > Cc: <sta...@vger.kernel.org> > > Signed-off-by: Jon Hunter <jonath...@nvidia.com> > Reviewed-by: Brian Norris <briannor...@chromium.org> Acked-by: Benson Leung <ble...@chromium.org> -- Benson L

Re: [PATCH V2 1/2] mfd: cros ec: spi: Don't send first message too soon

> spi_setup() and before sending the first SPI message. > > Cc: > > Signed-off-by: Jon Hunter > Reviewed-by: Brian Norris Acked-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] HID: hidraw: fix power sequence when closing device

> Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com> Reviewed-by: Benson Leung <ble...@chromium.org> -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] HID: hidraw: fix power sequence when closing device

> Signed-off-by: Dmitry Torokhov Reviewed-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

+/475212 > > Ok, thanks, will use that one. How about > > Reviewed-by: Benson Leung <ble...@chromium.org> > > which is missing in the mail you've sent, but is there in the above > reference commit? Submission looks good to me. Go ahead and add. Reviewed-by:

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

+/475212 > > Ok, thanks, will use that one. How about > > Reviewed-by: Benson Leung > > which is missing in the mail you've sent, but is there in the above > reference commit? Submission looks good to me. Go ahead and add. Reviewed-by: Benson Leung Thanks, Benson --

Re: linux-next: Signed-off-by missing for commit in the chrome-platform tree

t;) > 3bd61d4d1d9e ("platform/chrome: cros_ec: Add sysfs entry to set keyboard > wake lid angle") > > are missing a Signed-off-by from their committer. > Whoops. My mistake. Will fix. Thanks! > -- > Cheers, > Stephen Rothwell -- Benson Leung Staff Software Eng

Re: linux-next: Signed-off-by missing for commit in the chrome-platform tree

t;) > 3bd61d4d1d9e ("platform/chrome: cros_ec: Add sysfs entry to set keyboard > wake lid angle") > > are missing a Signed-off-by from their committer. > Whoops. My mistake. Will fix. Thanks! > -- > Cheers, > Stephen Rothwell -- Benson Leung Staff Software Eng

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

Hi Oliver, On Mon, Sep 11, 2017 at 01:02:52PM -0700, Benson Leung wrote: > Thanks for the pointer. I'll respin the patch with the no_resume version of > usb_autopm_get_interface and retest. > I went and tried this patch but with usb_autopm_get_interface_no_resume instead and the origi

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

Hi Oliver, On Mon, Sep 11, 2017 at 01:02:52PM -0700, Benson Leung wrote: > Thanks for the pointer. I'll respin the patch with the no_resume version of > usb_autopm_get_interface and retest. > I went and tried this patch but with usb_autopm_get_interface_no_resume instead and the origi

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

Hi Oliver, On Sat, Sep 09, 2017 at 09:35:52AM +0200, Oliver Neukum wrote: > Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov: > > From: Benson Leung <ble...@chromium.org> > > > > usbhid->intf->needs_remote_wakeup is set when a device is opened,

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

Hi Oliver, On Sat, Sep 09, 2017 at 09:35:52AM +0200, Oliver Neukum wrote: > Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov: > > From: Benson Leung > > > > usbhid->intf->needs_remote_wakeup is set when a device is opened, and is > >

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

roto v3 skeleton") > Signed-off-by: Shawn Nematbakhsh <sha...@chromium.org> > Signed-off-by: Brian Norris <briannor...@chromium.org> > Reviewed-by: Javier Martinez Canillas <jav...@osg.samsung.com> Looks good. Applied for v4.14. Thanks! Benson -- Benson Leu

Re: [PATCH v3] platform/chrome: Use proper protocol transfer function

Signed-off-by: Shawn Nematbakhsh > Signed-off-by: Brian Norris > Reviewed-by: Javier Martinez Canillas Looks good. Applied for v4.14. Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

lt;thierry.esca...@collabora.com> Looks good. Applied. -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

to do something meaningful. > Also, this patch makes use of cros_ec_cmd_xfer_status() instead of > cros_ec_cmd_xfer() so an error message is printed in the syslog. > > Signed-off-by: Gwendal Grignou > Signed-off-by: Thierry Escande Looks good. Applied. -- Benson Leung Staff Soft

Re: [PATCH v2 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

hierry Escande <thierry.esca...@collabora.com> V2 Looks good. Applied. Thanks! -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

are controlled by the EC. > > This patch also moves the cros_ec features check before the device is > added so the features map obtained from the EC is ready on time. > > Signed-off-by: Gwendal Grignou > Signed-off-by: Thierry Escande V2 Looks good. Applied. Thanks! -- Ben

Re: [PATCH] platform/chrome: chromeos_laptop: make chromeos_laptop const

ka Goyal <bhumi...@gmail.com> Applied. Thanks for the patch! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] platform/chrome: chromeos_laptop: make chromeos_laptop const

Applied. Thanks for the patch! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] platform/chrome: cros_ec_dev - Use devm_mfd_add_devices

> > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Thanks for the fix. Applied for v4.14. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH] platform/chrome: cros_ec_dev - Use devm_mfd_add_devices

/0x84 > > Signed-off-by: Jeffy Chen Thanks for the fix. Applied for v4.14. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v2 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

tate. > > This patch registers a shutdown callback used to cancel the debugfs log > worker thread. > > Signed-off-by: Daniel Hung-yu Wu <h...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Applied. Thanks, Benson -- Benson Leung

Re: [PATCH v2 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

This patch registers a shutdown callback used to cancel the debugfs log > worker thread. > > Signed-off-by: Daniel Hung-yu Wu > Signed-off-by: Thierry Escande Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromi

Re: [PATCH v2 3/8] mfd: cros_ec: Stop the debugfs work when suspended

ed: -108 > cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson <diand...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Applied. Than

Re: [PATCH v2 3/8] mfd: cros_ec: Stop the debugfs work when suspended

i5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson > Signed-off-by: Thierry Escande Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@g

Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

struct cros_ec_dev *ec = container_of(dev, struct cros_ec_dev, > + class_dev); > + > + if (a == _attr_kb_wake_angle.attr && !ec->has_kb_wake_angle) > + return 0; > + > + return a->mode; > +} > + > struct attribute_group cros_ec_attr_group = { > .attrs = __ec_attrs, > + .is_visible = cros_ec_ctrl_visible, > }; > > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index 4e887ba..350b8a4 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -191,6 +191,7 @@ struct cros_ec_dev { > struct cros_ec_device *ec_dev; > struct device *dev; > struct cros_ec_debugfs *debug_info; > + bool has_kb_wake_angle; > u16 cmd_offset; > u32 features[2]; > }; > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

class_dev); > + > + if (a == _attr_kb_wake_angle.attr && !ec->has_kb_wake_angle) > + return 0; > + > + return a->mode; > +} > + > struct attribute_group cros_ec_attr_group = { > .attrs = __ec_attrs, > + .is_visible = cros_ec_ctrl_visible, > }; > > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index 4e887ba..350b8a4 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -191,6 +191,7 @@ struct cros_ec_dev { > struct cros_ec_device *ec_dev; > struct device *dev; > struct cros_ec_debugfs *debug_info; > + bool has_kb_wake_angle; > u16 cmd_offset; > u32 features[2]; > }; > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH 6/8] mfd: cros_ec_i2c: add ACPI module device table

nhu...@google.com> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Benson Leung <ble...@chromium.org> > --- > drivers/mfd/cros_ec_i2c.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mfd/cros_ec_i2c.c

Re: [PATCH 6/8] mfd: cros_ec_i2c: add ACPI module device table

ierry Escande Acked-by: Benson Leung > --- > drivers/mfd/cros_ec_i2c.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c > index 576fcc4..56fc667 100644 > --- a/drivers/mfd/cros_ec_i2c.c > +++

Re: [PATCH 5/8] mfd: cros_ec: fail early if we cannot identify the EC

> commit all kind of uninformed mistakes (using the wrong protocol, the > wrong buffer size, mixing the EC with other chips). > > Signed-off-by: Vincent Palatin <vpala...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Benson Leun

Re: [PATCH 5/8] mfd: cros_ec: fail early if we cannot identify the EC

formed mistakes (using the wrong protocol, the > wrong buffer size, mixing the EC with other chips). > > Signed-off-by: Vincent Palatin > Signed-off-by: Thierry Escande Acked-by: Benson Leung > --- > drivers/mfd/cros_ec.c | 6 +- > 1 file changed, 5 insertions(+), 1 delet

Re: [PATCH 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

tate. > > This patch registers a shutdown callback used to cancel the debugfs log > worker thread. > > Signed-off-by: Daniel Hung-yu Wu <h...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Applied. Thanks. Benson -- Benson Leung

Re: [PATCH 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

This patch registers a shutdown callback used to cancel the debugfs log > worker thread. > > Signed-off-by: Daniel Hung-yu Wu > Signed-off-by: Thierry Escande Applied. Thanks. Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromi

Re: [PATCH 3/8] mfd: cros_ec: Stop the debugfs work when suspended

pi transfer failed: -108 > cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson <diand...@chromium.org> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Lo

Re: [PATCH 3/8] mfd: cros_ec: Stop the debugfs work when suspended

ros-ec-spi spi5.0: cs-deassert spi transfer failed: -108 > cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed > > Signed-off-by: Douglas Anderson > Signed-off-by: Thierry Escande Looks good. Applied. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Ker

Re: [PATCH 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late

stage to make it work > normally. > > Signed-off-by: Joseph Lo <jose...@nvidia.com> > Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Benson Leung <ble...@chromium.org> Thanks! Benson -- Benson Leung Staff Software Engineer Chrome

Re: [PATCH 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late

> normally. > > Signed-off-by: Joseph Lo > Signed-off-by: Thierry Escande Acked-by: Benson Leung Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH 1/8] iio: cros_ec: Relax sampling frequency before suspending

--git a/drivers/iio/light/cros_ec_light_prox.c > b/drivers/iio/light/cros_ec_light_prox.c > index 7217223..f8658d4 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -279,6 +279,7 @@ MODULE_DEVICE_TABLE(platform, cros_ec_light_prox_ids

Re: [PATCH 1/8] iio: cros_ec: Relax sampling frequency before suspending

; index 7217223..f8658d4 100644 > --- a/drivers/iio/light/cros_ec_light_prox.c > +++ b/drivers/iio/light/cros_ec_light_prox.c > @@ -279,6 +279,7 @@ MODULE_DEVICE_TABLE(platform, cros_ec_light_prox_ids); > static struct platform_driver cros_ec_light_prox_platform_driver = { > .driver = { > .name = "cros-ec-light-prox", > + .pm = _ec_sensors_pm_ops, > }, > .probe = cros_ec_light_prox_probe, > .id_table = cros_ec_light_prox_ids, > -- > 2.7.4 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

s configuration, but the first one we shipped did, so we will have to support it. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

s configuration, but the first one we shipped did, so we will have to support it. Thanks, Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: Digital signature

Re: [PATCH v3 3/4] rtc: cros-ec: add cros-ec-rtc driver.

r <smbar...@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > Acked-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Benson Leung <ble...@chromium.org> Thanks! Benson -- Benson Leung Staff Software Engineer Chro

Re: [PATCH v3 3/4] rtc: cros-ec: add cros-ec-rtc driver.

etbo i Serra > Acked-by: Alexandre Belloni Acked-by: Benson Leung Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: OpenPGP digital signature

Re: [PATCH v3 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.

r <smbar...@chromium.org> > Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com> > Acked-by: Lee Jones <lee.jo...@linaro.org> Acked-by: Benson Leung <ble...@chromium.org> -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble

Re: [PATCH v3 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.

etbo i Serra > Acked-by: Lee Jones Acked-by: Benson Leung -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: OpenPGP digital signature

[GIT PULL] chrome-platform updates for v4.13

): platform/chrome: cros_ec_lightbar - hide unused PM functions Benson Leung (1): platform/chrome : Add myself as Maintainer Eric Caruso (4): mfd: cros_ec: add debugfs, console log file platform/chrome: cros_ec_lightbar - Add lightbar program feature to sysfs platform

<    1   2   3   4   5   6   7   8   >