On 6/18/19 4:09 AM, Bitan Biswas wrote:
The usage of BUG() macro is generally discouraged in kernel, unless
it's a problem that results in a physical damage or loss of data.
This patch removes unnecessary BUG() macros and replaces the rest
with warning.
Signed-off-by: Bitan Biswas
On 6/18/19 4:29 AM, Dmitry Osipenko wrote:
18.06.2019 14:09, Bitan Biswas пишет:
The usage of BUG() macro is generally discouraged in kernel, unless
it's a problem that results in a physical damage or loss of data.
This patch removes unnecessary BUG() macros and replaces the rest
The usage of BUG() macro is generally discouraged in kernel, unless
it's a problem that results in a physical damage or loss of data.
This patch removes unnecessary BUG() macros and replaces the rest
with warning.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 47
On 6/17/19 11:32 PM, Jon Hunter wrote:
On 18/06/2019 06:23, Bitan Biswas wrote:
Synchronize ISR and tegra_i2c_xfer_msg execution
by disabling interrupt. This avoids spinlock usage
for same purpose.
I think that you need to explain the motivation/benefit of this. It is
not immediately
is achieved by disabling
I2C interrupt during preparation step and enabling interrupt
once preparation is over and spinlock is no longer needed.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c
Synchronize ISR and tegra_i2c_xfer_msg execution
by disabling interrupt. This avoids spinlock usage
for same purpose.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c
On 6/14/19 6:02 AM, Dmitry Osipenko wrote:
14.06.2019 12:50, Bitan Biswas пишет:
On 6/13/19 5:28 AM, Dmitry Osipenko wrote:
13.06.2019 14:30, Bitan Biswas пишет:
On 6/12/19 7:30 AM, Dmitry Osipenko wrote:
11.06.2019 13:51, Bitan Biswas пишет:
Fix expression for residual bytes(less
The usage of BUG() macro is generally discouraged in kernel, unless
it's a problem that results in a physical damage or loss of data.
This patch removes unnecessary BUG() macros and replaces the rest
with warning.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 49
On 6/17/19 12:28 PM, Dmitry Osipenko wrote:
17.06.2019 21:41, Bitan Biswas пишет:
On 6/17/19 5:13 AM, Dmitry Osipenko wrote:
17.06.2019 8:09, Bitan Biswas пишет:
Remove BUG, BUG_ON as it makes system usable:
- Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed
On 6/14/19 10:51 AM, Dmitry Osipenko wrote:
14.06.2019 18:50, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Remove BUG() and mask Rx interrupt similar as Tx
for message fully sent case. Add WARN_ON_ONCE check
for non-zero rx_fifo_avail
On 6/17/19 5:13 AM, Dmitry Osipenko wrote:
17.06.2019 8:09, Bitan Biswas пишет:
Remove BUG, BUG_ON as it makes system usable:
- Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed.
- Remove BUG() and mask Rx interrupt similar as Tx
for message fully sent case
On 6/17/19 12:09 AM, Thierry Reding wrote:
On Sat, Jun 15, 2019 at 06:54:05AM +0200, Wolfram Sang wrote:
Without a maintainer ack, this is an exception this time. Should we add
Dmitry as another maintainer or reviewer at least?
I shall followup with Maintainer for ACK in future I2C tegra
in tegra_i2c_empty_rx_fifo() after all processing.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 45 ++
1 file changed, 37 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 4dfb4c1
On 6/14/19 2:11 PM, Wolfram Sang wrote:
On Thu, Jun 06, 2019 at 10:37:47PM -0700, Bitan Biswas wrote:
Post suspend I2C registers have power on reset values. Before any
transfer initialize I2C registers to prevent I2C transfer timeout
and implement suspend and resume callbacks needed. Fix
On 6/14/19 8:48 AM, Thierry Reding wrote:
On Fri, Jun 14, 2019 at 05:31:39AM -0700, Bitan Biswas wrote:
Early resume Tegra bpmp to fix Xavier clock rate error as follows:
[ 159.017101] of_serial 311.serial: calling platform_pm_resume+0x0/0x58 @
317, parent: cbb
[ 159.025501] of_serial
If Tegra HSP device tree does not have 'shared irqs',
mailboxes pointer is NULL. Add non-NULL HSP mailboxes
check in resume callback before tegra_hsp_mailbox_startup()
call and prevent NULL pointer exception.
Signed-off-by: Bitan Biswas
---
drivers/mailbox/tegra-hsp.c | 10 ++
1 file
Add noirq resume instead of resume callback for Tegra HSP. Tegra HSP
resume needs tegra_hsp_doorbell_startup() call to fix timeout error for
tegra_bpmp_transfer() during genpd resume noirq on Jetson TX2.
Signed-off-by: Bitan Biswas
---
drivers/mailbox/tegra-hsp.c | 10 +-
1 file changed
On 6/14/19 8:52 AM, Thierry Reding wrote:
On Fri, Jun 14, 2019 at 05:35:34AM -0700, Bitan Biswas wrote:
If Tegra hsp device tree does not have 'shared irqs',
s/hsp/HSP/, otherwise looks good.
Shall correct.
Thierry
mailboxes pointer is NULL. Add non-NULL HSP mailboxes
check in resume
On 6/14/19 8:50 AM, Thierry Reding wrote:
On Fri, Jun 14, 2019 at 05:35:33AM -0700, Bitan Biswas wrote:
Add noirq resume instead of resume callback for Tegra HSP. Tegra HSP
resume needs tegra_hsp_doorbell_startup() call to fix timeout error for
tegra_bpmp_transfer() during genpd resume noirq
is also added.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 46 ++
1 file changed, 38 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 4dfb4c1..26a7c8c 100644
--- a/drivers
Add noirq resume instead of resume callback for Tegra HSP. Tegra HSP
resume needs tegra_hsp_doorbell_startup() call to fix timeout error for
tegra_bpmp_transfer() during genpd resume noirq on jetson-tx2.
Signed-off-by: Bitan Biswas
---
drivers/mailbox/tegra-hsp.c | 12 ++--
1 file
If Tegra hsp device tree does not have 'shared irqs',
mailboxes pointer is NULL. Add non-NULL HSP mailboxes
check in resume callback before tegra_hsp_mailbox_startup()
call and prevent NULL pointer exception.
Signed-off-by: Bitan Biswas
---
drivers/mailbox/tegra-hsp.c | 10 ++
1 file
usecs
[ 159.063875] PM: Device 31c.i2c failed to resume: error -22
Signed-off-by: Bitan Biswas
---
drivers/firmware/tegra/bpmp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
index dd775e8..de09036 100644
On 6/13/19 5:28 AM, Dmitry Osipenko wrote:
13.06.2019 14:30, Bitan Biswas пишет:
On 6/12/19 7:30 AM, Dmitry Osipenko wrote:
11.06.2019 13:51, Bitan Biswas пишет:
Fix expression for residual bytes(less than word) transfer
in I2C PIO mode RX/TX.
Signed-off-by: Bitan Biswas
---
[snip
On 6/12/19 6:55 AM, Dmitry Osipenko wrote:
11.06.2019 13:51, Bitan Biswas пишет:
Fix expression for residual bytes(less than word) transfer
in I2C PIO mode RX/TX.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 11 ++-
1 file changed, 6 insertions(+), 5
On 6/12/19 7:30 AM, Dmitry Osipenko wrote:
11.06.2019 13:51, Bitan Biswas пишет:
Fix expression for residual bytes(less than word) transfer
in I2C PIO mode RX/TX.
Signed-off-by: Bitan Biswas
---
[snip]
/*
-* Update state before writing to FIFO
On 6/12/19 6:33 AM, Dmitry Osipenko wrote:
11.06.2019 21:22, Bitan Biswas пишет:
On 6/11/19 4:34 AM, Dmitry Osipenko wrote:
11.06.2019 10:38, Bitan Biswas пишет:
On 6/10/19 2:00 PM, Dmitry Osipenko wrote:
10.06.2019 22:41, Bitan Biswas пишет:
On 6/10/19 11:12 AM, Dmitry Osipenko
On 6/12/19 3:24 AM, Wolfram Sang wrote:
On Tue, Jun 11, 2019 at 03:51:13AM -0700, Bitan Biswas wrote:
Fix expression for residual bytes(less than word) transfer
in I2C PIO mode RX/TX.
Signed-off-by: Bitan Biswas
I applied patches 1-5 to my for-next tree now. No need to resend them
On 6/6/19 11:27 PM, Dmitry Osipenko wrote:
07.06.2019 8:37, Bitan Biswas пишет:
Post suspend I2C registers have power on reset values. Before any
transfer initialize I2C registers to prevent I2C transfer timeout
and implement suspend and resume callbacks needed. Fix below errors
post suspend
On 6/11/19 4:34 AM, Dmitry Osipenko wrote:
11.06.2019 10:38, Bitan Biswas пишет:
On 6/10/19 2:00 PM, Dmitry Osipenko wrote:
10.06.2019 22:41, Bitan Biswas пишет:
On 6/10/19 11:12 AM, Dmitry Osipenko wrote:
10.06.2019 20:08, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Remove BUG() and make Rx and Tx case handling
similar. Add WARN_ON_ONCE check for non-zero rx_fifo_avail
in tegra_i2c_empty_rx_fifo() and return new error
I2C_ERR_UNEXPECTED_STATUS.
Signed-off-by: Bitan Biswas
---
drivers/i2c
Clean up macros by:
1) removing unused macros
2) replace constants by macro BIT()
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+ spinlock_t xfer_lock;
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Fix checkpatch.pl alignment and blank line check(s) in i2c-tegra.c
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c
Fix expression for residual bytes(less than word) transfer
in I2C PIO mode RX/TX.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index
Fix checkpatch.pl WARNING for delay of approximately 1msec
in flush i2c FIFO polling loop by using usleep_range(1000, 2000):
WARNING: msleep < 20ms can sleep for up to 20ms; see ...
Documentation/timers/timers-howto.txt
+ msleep(1);
Signed-off-by: Bitan Biswas
Reviewed-by: Dmi
Remove variable initializations in functions that
are followed by assignments before use
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
On 6/10/19 2:00 PM, Dmitry Osipenko wrote:
10.06.2019 22:41, Bitan Biswas пишет:
On 6/10/19 11:12 AM, Dmitry Osipenko wrote:
10.06.2019 20:08, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Remove BUG() and make Rx and Tx case handling
similar
On 6/10/19 11:12 AM, Dmitry Osipenko wrote:
10.06.2019 20:08, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Remove BUG() and make Rx and Tx case handling
similar.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 11
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Remove BUG() and make Rx and Tx case handling
similar.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c
Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+ spinlock_t xfer_lock;
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Clean up macros by:
1) removing unused macros
2) replace constants by macro BIT()
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Remove variable initializations in functions that
are followed by assignments before use
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Fix checkpatch.pl alignment and blank line check(s) in i2c-tegra.c
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c
Fix checkpatch.pl WARNING for delay of approximately 1msec
in flush i2c FIFO polling loop by using usleep_range(1000, 2000):
WARNING: msleep < 20ms can sleep for up to 20ms; see ...
Documentation/timers/timers-howto.txt
+ msleep(1);
Signed-off-by: Bitan Biswas
Reviewed-by: Dmi
On 6/10/19 3:30 AM, Dmitry Osipenko wrote:
10.06.2019 8:08, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 18 +++---
1 file changed, 11 insertions(+), 7
Fix checkpatch.pl alignment and blank line check(s) in i2c-tegra.c
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c
Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+ spinlock_t xfer_lock;
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Clean up macros by:
1) removing unused macros
2) replace constants by macro BIT()
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Remove variable initializations in functions that
are followed by assignments before use
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Fix checkpatch.pl WARNING for delay of approximately 1msec
in flush i2c FIFO polling loop by using usleep_range(1000, 2000):
WARNING: msleep < 20ms can sleep for up to 20ms; see ...
Documentation/timers/timers-howto.txt
+ msleep(1);
Signed-off-by: Bitan Biswas
Reviewed-by: Dmi
On 6/7/19 12:47 PM, Dmitry Osipenko wrote:
07.06.2019 22:30, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions
Fix checkpatch.pl WARNING for delay of approximately 1msec
in flush i2c FIFO polling loop by using usleep_range(1000, 2000):
WARNING: msleep < 20ms can sleep for up to 20ms; see ...
Documentation/timers/timers-howto.txt
+ msleep(1);
Signed-off-by: Bitan Biswas
Reviewed-by: Dmi
Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+ spinlock_t xfer_lock;
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Clean up macros by:
1) removing unused macros
2) replace constants by macro BIT()
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
Fix checkpatch.pl alignment and blank line check(s) in i2c-tegra.c
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c
Remove variable initializations in functions that
are followed by assignments before use
Signed-off-by: Bitan Biswas
Reviewed-by: Dmitry Osipenko
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b
On 6/7/19 11:55 AM, Bitan Biswas wrote:
On 6/7/19 5:18 AM, Dmitry Osipenko wrote:
07.06.2019 15:12, Dmitry Osipenko пишет:
07.06.2019 15:08, Dmitry Osipenko пишет:
07.06.2019 14:55, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG
On 6/7/19 5:18 AM, Dmitry Osipenko wrote:
07.06.2019 15:12, Dmitry Osipenko пишет:
07.06.2019 15:08, Dmitry Osipenko пишет:
07.06.2019 14:55, Bitan Biswas пишет:
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define
Fix checkpatch.pl WARNING for delay of approximately 1msec
in flush i2c FIFO polling loop by using usleep_range(1000, 2000):
WARNING: msleep < 20ms can sleep for up to 20ms; see ...
Documentation/timers/timers-howto.txt
+ msleep(1);
Signed-off-by: Bitan Biswas
---
drivers/
Clean up macros by:
1) removing unused macros
2) replace constants by macro BIT()
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+ spinlock_t xfer_lock;
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index
Fix checkpatch.pl alignment and blank line check(s) in i2c-tegra.c
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c
Remove variable initializations in functions that
are followed by assignments before use
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions
On 6/6/19 11:05 PM, Dmitry Osipenko wrote:
07.06.2019 8:25, Bitan Biswas пишет:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Ignore checkpatch WARNING for 80 character line limit at
places where renaming fields compromises readability.
Delay of approximately 1msec in flush
On 6/6/19 11:03 PM, Wolfram Sang wrote:
On Thu, Jun 06, 2019 at 10:25:03PM -0700, Bitan Biswas wrote:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Ignore checkpatch WARNING for 80 character line limit at
places where renaming fields compromises readability.
Delay
in resume callback as i2c_mark_adapter_*
(suspended-resumed) help ensure i2c core calls from client are not
executed before i2c-tegra resume.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/i2c/busses
.
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 61 ++
1 file changed, 32
On 6/6/19 1:45 PM, Peter Rosin wrote:
On 2019-06-06 09:35, Bitan Biswas wrote:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS
On 6/6/19 4:57 AM, Wolfram Sang wrote:
On Thu, Jun 06, 2019 at 12:35:23AM -0700, Bitan Biswas wrote:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define
On 6/6/19 4:39 AM, Dmitry Osipenko wrote:
06.06.2019 10:35, Bitan Biswas пишет:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS
On 6/6/19 5:06 AM, Dmitry Osipenko wrote:
06.06.2019 8:54, Bitan Biswas пишет:
Post suspend I2C registers have power on reset values. Before any
transfer initialize I2C registers to prevent I2C transfer timeout
and implement suspend and resume callbacks needed. Fix below errors
post suspend
On 6/6/19 4:52 AM, Dmitry Osipenko wrote:
06.06.2019 8:43, Bitan Biswas пишет:
On 5/31/19 5:43 AM, Dmitry Osipenko wrote:
31.05.2019 11:50, Bitan Biswas пишет:
On 5/30/19 4:27 AM, Dmitry Osipenko wrote:
30.05.2019 8:55, Bitan Biswas пишет:
Post suspend I2C registers have power
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Define I2C_ERR_UNEXPECTED_STATUS for error handling.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 67
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE
as needed. Replace BUG() with error handling code.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 66 +++---
1 file
On 5/31/19 5:45 AM, Dmitry Osipenko wrote:
31.05.2019 12:04, Bitan Biswas пишет:
On 5/30/19 4:43 AM, Dmitry Osipenko wrote:
30.05.2019 14:36, Dmitry Osipenko пишет:
30.05.2019 9:14, Bitan Biswas пишет:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
except for BUG/BUG_ON
in resume callback as i2c_mark_adapter_*
(suspended-resumed) help ensure i2c core calls from client are not
executed before i2c-tegra resume.
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/i2c/busses/i2c
On 5/31/19 5:43 AM, Dmitry Osipenko wrote:
31.05.2019 11:50, Bitan Biswas пишет:
On 5/30/19 4:27 AM, Dmitry Osipenko wrote:
30.05.2019 8:55, Bitan Biswas пишет:
Post suspend I2C registers have power on reset values. Before any
transfer initialize I2C registers to prevent I2C transfer
On 5/30/19 4:43 AM, Dmitry Osipenko wrote:
30.05.2019 14:36, Dmitry Osipenko пишет:
30.05.2019 9:14, Bitan Biswas пишет:
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
except for BUG/BUG_ON checks
Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
hence
On 5/30/19 4:27 AM, Dmitry Osipenko wrote:
30.05.2019 8:55, Bitan Biswas пишет:
Post suspend I2C registers have power on reset values. Before any
transfer initialize I2C registers to prevent I2C transfer timeout
and implement suspend and resume callbacks needed. Fix below errors
post suspend
Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
except for BUG/BUG_ON checks
Signed-off-by: Bitan Biswas
---
drivers/i2c/busses/i2c-tegra.c | 54 +++---
1 file changed, 30 insertions(+), 24 deletions(-)
diff --git a/drivers/i2c/busses/i2c
(): pca953x_resume+0x0/0x1b0 returns -110
[ 27.658375] pca953x 1-0074: pca953x_resume+0x0/0x1b0 returned -110 after
127152 usecs
[ 27.666194] PM: Device 1-0074 failed to resume: error -110
2) Tegra I2C transfer timeout error on jetson Xavier post resume.
Signed-off-by: Bitan Biswas
Hi Guenter,
Thank you for the guidance.
But looking at the hwmon linux documentation, seems the sensor
kernel drivers should report only raw readings.
The raw readings can be converted into required output,
e.g. temperature in this case, by respective user space implementation.
"raw" means
Hi Guenter,
Thank you for the guidance.
But looking at the hwmon linux documentation, seems the sensor
kernel drivers should report only raw readings.
The raw readings can be converted into required output,
e.g. temperature in this case, by respective user space implementation.
raw means
Hi,
I have a question related to hwmon driver and need suggestions.
I am working on a temperature sensor driver that is hwmon driver.
- The temperature is calculated from raw sensor reading and
certain initialization parameters.
- Raw reading obtained from 2 different sensor instances under
Hi,
I have a question related to hwmon driver and need suggestions.
I am working on a temperature sensor driver that is hwmon driver.
- The temperature is calculated from raw sensor reading and
certain initialization parameters.
- Raw reading obtained from 2 different sensor instances under
89 matches
Mail list logo
