Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap()

2021-03-18 Thread Borislav Petkov
On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote: > There was no more caller passing vm_flags to do_mmap(), and vm_flags was > removed from the function's input by: > > commit 45e55300f114 ("mm: remove unnecessary wrapper function > do_mmap_pgoff()"). > > There is a new user now.

Re: [PATCH v23 16/28] mm: Fixup places that call pte_mkwrite() directly

2021-03-18 Thread Borislav Petkov
On Thu, Mar 18, 2021 at 10:47:40AM +0100, Borislav Petkov wrote: > As with the previous one, I guess this one needs a mm person ACK. I > mean, it is pretty obvious but still... And that needs to happen for all mm patches in here. -- Regards/Gruss, Boris. https://people.kernel.or

[tip: x86/misc] tools/x86/kcpuid: Add AMD leaf 0x8000001E

2021-03-18 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/misc branch of tip: Commit-ID: f281854fa743f3474b2d0d69533301f48cf0e184 Gitweb: https://git.kernel.org/tip/f281854fa743f3474b2d0d69533301f48cf0e184 Author:Borislav Petkov AuthorDate:Mon, 15 Mar 2021 13:55:14 +01:00

[tip: x86/misc] tools/x86/kcpuid: Check last token too

2021-03-18 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/misc branch of tip: Commit-ID: e20f67026b5ead2afc5627e98b45e6b65e7fb38c Gitweb: https://git.kernel.org/tip/e20f67026b5ead2afc5627e98b45e6b65e7fb38c Author:Borislav Petkov AuthorDate:Mon, 15 Mar 2021 13:08:35 +01:00

Re: [PATCH v23 16/28] mm: Fixup places that call pte_mkwrite() directly

2021-03-18 Thread Borislav Petkov
On Tue, Mar 16, 2021 at 08:10:42AM -0700, Yu-cheng Yu wrote: > When serving a page fault, maybe_mkwrite() makes a PTE writable if it is in > a writable vma. A shadow stack vma is writable, but its PTEs need > _PAGE_DIRTY to be set to become writable. For this reason, maybe_mkwrite() > has been

[tip: x86/core] tools/insn: Restore the relative include paths for cross building

2021-03-17 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 0705ef64d1ff52b817e278ca6e28095585ff31e1 Gitweb: https://git.kernel.org/tip/0705ef64d1ff52b817e278ca6e28095585ff31e1 Author:Borislav Petkov AuthorDate:Wed, 17 Mar 2021 11:33:04 +01:00

Re: linux-next: build failure after merge of the tip tree

2021-03-17 Thread Borislav Petkov
On Thu, Mar 18, 2021 at 05:49:21AM +1100, Stephen Rothwell wrote: > That fixes the powerpc build for me, thanks. Thx, adding your Tested-by and pushing out. -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

Re: [PATCH] x86/cpu/AMD: Adjust x86_phys_bits to account for reduced PA in SEV-* guests

2021-03-17 Thread Borislav Petkov
On Wed, Mar 17, 2021 at 11:32:43AM -0700, Sean Christopherson wrote: > Always reduce x86_phys_bits per CPUID.0x801f[11:6] for SEV-* guests; > the existing flow that queries X86_FEATURE_SEV may or may not trigger > depending on what the VMM emulates, e.g. the VMM likely does not emulate >

Re: linux-next: build failure after merge of the tip tree

2021-03-17 Thread Borislav Petkov
>From d242b2639a23ed03d9aed94cf05b99af5343d4e9 Mon Sep 17 00:00:00 2001 From: Borislav Petkov Date: Wed, 17 Mar 2021 11:33:04 +0100 Subject: [PATCH] tools/insn: Restore the relative include paths for cross building Building perf on ppc causes: In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:15: u

Re: [PATCH v23 15/28] x86/mm: Update maybe_mkwrite() for shadow stack

2021-03-17 Thread Borislav Petkov
On Tue, Mar 16, 2021 at 08:10:41AM -0700, Yu-cheng Yu wrote: > When serving a page fault, maybe_mkwrite() makes a PTE writable if its vma > has VM_WRITE. > > A shadow stack vma has VM_SHSTK. Its PTEs have _PAGE_DIRTY, but not > _PAGE_WRITE. In fork(), _PAGE_DIRTY is cleared to effect

Re: [PATCH] EDAC: use NULL instead of using plain integer as pointer

2021-03-17 Thread Borislav Petkov
On Wed, Mar 17, 2021 at 03:47:25PM +0800, Yang Li wrote: > This fixes the following sparse warnings: > drivers/edac/sb_edac.c:433:10: warning: Using plain integer as NULL > pointer > drivers/edac/sb_edac.c:499:10: warning: Using plain integer as NULL > pointer > drivers/edac/sb_edac.c:570:10:

Re: linux-next: build failure after merge of the tip tree

2021-03-17 Thread Borislav Petkov
e tip tree from next-20210316 for today. Yah, this has come up in the past during review but the wrong version somehow snuck in, sorry. ;-\ Can you guys verify this fixes the build issue? I don't have a ppc build setup. Thx. --- >From 50d91054fc421e2a90923706d5ca79e941e28300 Mon Sep 17 00:00:00

Re: linux-next: manual merge of the hyperv tree with the tip tree

2021-03-16 Thread Borislav Petkov
On Wed, Mar 17, 2021 at 08:07:44AM +1100, Stephen Rothwell wrote: > No worries, I will keep applying the patch (my setup allows that to > happen automatically). Linus should apply it as a part of the merge > resolution (as do I). Thanks! -- Regards/Gruss, Boris. SUSE Software Solutions

Re: EDAC list as Trojan Horse distribution ??

2021-03-16 Thread Borislav Petkov
On Tue, Mar 16, 2021 at 06:55:19PM +0100, Hermann Ruckerbauer wrote: > > quite some tiem ago i sent a question to the EDAC list.. > > I never receveived an answer. > >   > > today i got an answer with my original question quoted  and a .zip > > file attached: Nothing new - just the next spammer

Re: [PATCH v23 6/9] x86/entry: Introduce ENDBR macro

2021-03-16 Thread Borislav Petkov
On Tue, Mar 16, 2021 at 10:12:39AM -0700, Yu, Yu-cheng wrote: > Alternatively, there is another compiler-defined macro _CET_ENDBR that can > be used. We can put the following in calling.h: Not calling.h - this is apparently needed in vdso code only so I guess some header there,

Re: linux-next: manual merge of the hyperv tree with the tip tree

2021-03-16 Thread Borislav Petkov
On Mon, Mar 15, 2021 at 02:35:05PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the hyperv tree got a conflict in: > > arch/x86/include/asm/mshyperv.h > > between commit: > > a0e2bf7cb700 ("x86/paravirt: Switch time pvops functions to use > static_call()") > >

Re: [PATCH 2/2] tools/x86/kcpuid: Add AMD leaf 0x8000001E

2021-03-16 Thread Borislav Petkov
On Tue, Mar 16, 2021 at 03:42:23PM +0800, Feng Tang wrote: > Also I'm wondering for some basic leaf and extended leaf which > may has different definition for different vendors, do we need > to seprate the csv to a general one and vendor specific ones. Do you know of such? Because AFAIK vendors

Re: [PATCH v7 5/6] x86/signal: Detect and prevent an alternate signal stack overflow

2021-03-16 Thread Borislav Petkov
On Mon, Mar 15, 2021 at 11:52:14PM -0700, Chang S. Bae wrote: > @@ -272,7 +275,8 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs > *regs, size_t frame_size, >* If we are on the alternate signal stack and would overflow it, don't. >* Return an always-bogus address instead so

Re: [PATCH 3/3] KVM: SVM: allow to intercept all exceptions for debug

2021-03-16 Thread Borislav Petkov
ing with kvm > trace. > This is not intended to be used on production systems. > > This is based on an idea first shown here: > https://patchwork.kernel.org/project/kvm/patch/20160301192822.gd22...@pd.tnic/ > > CC: Borislav Petkov > Signed-off-by: Maxim Levitsky > ---

Re: [tip:x86/cpu 2/3] arch/x86/kernel/alternative.c:96:10: warning: Undefined behaviour, pointer arithmetic 'x86nops+10' is out of bounds.

2021-03-16 Thread Borislav Petkov
Yet another useless report! On Tue, Mar 16, 2021 at 07:50:10AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu > head: 301cddc21a157a3072d789a3097857202e550a24 > commit: a89dfde3dc3c2dbf56910af75e2d8b11ec5308f6 [2/3] x86: Remove

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-15 Thread Borislav Petkov
On Mon, Mar 15, 2021 at 06:19:34PM +0100, Sedat Dilek wrote: > With my next build I try to apply this. Your perf tool command should look something like this: perf stat --repeat 5 --sync --pre=/root/bin/pre-build-kernel.sh -- make -s -j9 LLVM=1 LLVM_IAS=1 bzImage Also, needless to say, your

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-15 Thread Borislav Petkov
On Mon, Mar 15, 2021 at 06:04:41PM +0100, Sedat Dilek wrote: > Here some fresh numbers: Lemme paste my previous reply which still holds true here: "There's a reason I have -s for silent in the build - printing output during the build creates a *lot* of variance. And you have excessive printing

Re: [PATCH] x86/cpu: Resort and comment Intel models

2021-03-15 Thread Borislav Petkov
> 1 file changed, 28 insertions(+), 22 deletions(-) Anything that helps clear more of this names confusion: Acked-by: Borislav Petkov -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

[tip: x86/core] x86/sev-es: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 5e32c64bb6912bdddc05216655dd37e848b717af Gitweb: https://git.kernel.org/tip/5e32c64bb6912bdddc05216655dd37e848b717af Author:Borislav Petkov AuthorDate:Mon, 16 Nov 2020 18:21:23 +01:00

[tip: x86/core] perf/x86/intel/ds: Check insn_get_length() retval

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 2ff49881d606d5e0d5b27cb6066c8a18689bd341 Gitweb: https://git.kernel.org/tip/2ff49881d606d5e0d5b27cb6066c8a18689bd341 Author:Borislav Petkov AuthorDate:Fri, 06 Nov 2020 16:33:34 +01:00

[tip: x86/core] x86/traps: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 0be7f42d6fcce111f487283d596594c6da6588b0 Gitweb: https://git.kernel.org/tip/0be7f42d6fcce111f487283d596594c6da6588b0 Author:Borislav Petkov AuthorDate:Mon, 16 Nov 2020 18:38:45 +01:00

[tip: x86/core] x86/mce: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 1580f488ea8c6a62d002be364248c34c2f2e430b Gitweb: https://git.kernel.org/tip/1580f488ea8c6a62d002be364248c34c2f2e430b Author:Borislav Petkov AuthorDate:Fri, 06 Nov 2020 19:39:08 +01:00

[tip: x86/core] x86/alternative: Use insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 63c66cde7bbcc79aac14b25861c5b2495eede57b Gitweb: https://git.kernel.org/tip/63c66cde7bbcc79aac14b25861c5b2495eede57b Author:Borislav Petkov AuthorDate:Fri, 06 Nov 2020 19:37:25 +01:00

[tip: x86/core] x86/kprobes: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 77e768ec1391dc0d6cd89822aa60b9a1c1bd8128 Gitweb: https://git.kernel.org/tip/77e768ec1391dc0d6cd89822aa60b9a1c1bd8128 Author:Borislav Petkov AuthorDate:Mon, 16 Nov 2020 18:10:11 +01:00

[tip: x86/core] x86/uprobes: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 88afc23922137cd3efdb0f0b6722785c9f6a35eb Gitweb: https://git.kernel.org/tip/88afc23922137cd3efdb0f0b6722785c9f6a35eb Author:Borislav Petkov AuthorDate:Tue, 17 Nov 2020 15:26:12 +01:00

[tip: x86/core] perf/x86/intel/ds: Check return values of insn decoder functions

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 8c98a605544cfdec21d32fcf8fc855dc439f608f Gitweb: https://git.kernel.org/tip/8c98a605544cfdec21d32fcf8fc855dc439f608f Author:Borislav Petkov AuthorDate:Fri, 06 Nov 2020 16:36:24 +01:00

[tip: x86/core] x86/sev-es: Split vc_decode_insn()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 99e4b0de4d663e247f068bb5e014593b624a4ef0 Gitweb: https://git.kernel.org/tip/99e4b0de4d663e247f068bb5e014593b624a4ef0 Author:Borislav Petkov AuthorDate:Tue, 23 Feb 2021 11:28:02 +01:00

[tip: x86/core] x86/insn: Add @buf_len param to insn_init() kernel-doc comment

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 508ef28674c1fe6ac388586cb31dc0f0bbc4172c Gitweb: https://git.kernel.org/tip/508ef28674c1fe6ac388586cb31dc0f0bbc4172c Author:Borislav Petkov AuthorDate:Mon, 02 Nov 2020 19:12:16 +01:00

[tip: x86/core] x86/insn: Rename insn_decode() to insn_decode_from_regs()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 9e761296c52dcdb1aaa151b65bd39accb05740d9 Gitweb: https://git.kernel.org/tip/9e761296c52dcdb1aaa151b65bd39accb05740d9 Author:Borislav Petkov AuthorDate:Mon, 02 Nov 2020 18:47:34 +01:00

[tip: x86/core] x86/insn-eval: Handle return values from the decoder

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 6e8c83d2a3afbfd5ee019ec720b75a42df515caa Gitweb: https://git.kernel.org/tip/6e8c83d2a3afbfd5ee019ec720b75a42df515caa Author:Borislav Petkov AuthorDate:Thu, 19 Nov 2020 19:20:18 +01:00

[tip: x86/core] x86/boot/compressed/sev-es: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 514ef77607b9ff184c11b88e8f100bc27f07460d Gitweb: https://git.kernel.org/tip/514ef77607b9ff184c11b88e8f100bc27f07460d Author:Borislav Petkov AuthorDate:Thu, 05 Nov 2020 17:53:20 +01:00

[tip: x86/core] x86/insn: Add a __ignore_sync_check__ marker

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: d30c7b820be5c4777fe6c3b0c21f9d0064251e51 Gitweb: https://git.kernel.org/tip/d30c7b820be5c4777fe6c3b0c21f9d0064251e51 Author:Borislav Petkov AuthorDate:Mon, 22 Feb 2021 13:34:40 +01:00

[tip: x86/core] x86/tools/insn_decoder_test: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 0c925c61dae18ee3cb93a61cc9dd9562a066034d Gitweb: https://git.kernel.org/tip/0c925c61dae18ee3cb93a61cc9dd9562a066034d Author:Borislav Petkov AuthorDate:Fri, 20 Nov 2020 15:01:20 +01:00

[tip: x86/core] x86/insn: Add an insn_decode() API

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 93281c4a96572a34504244969b938e035204778d Gitweb: https://git.kernel.org/tip/93281c4a96572a34504244969b938e035204778d Author:Borislav Petkov AuthorDate:Tue, 03 Nov 2020 17:28:30 +01:00

[tip: x86/core] tools/objtool: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: c7e41b099be40112d53daccef8553e99e455e0d6 Gitweb: https://git.kernel.org/tip/c7e41b099be40112d53daccef8553e99e455e0d6 Author:Borislav Petkov AuthorDate:Fri, 20 Nov 2020 17:37:06 +01:00

[tip: x86/core] x86/insn: Make insn_complete() static

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: f935178b5c1c32ff803b15892a8ba85a1280cb01 Gitweb: https://git.kernel.org/tip/f935178b5c1c32ff803b15892a8ba85a1280cb01 Author:Borislav Petkov AuthorDate:Mon, 23 Nov 2020 23:19:03 +01:00

[tip: x86/core] x86/insn: Remove kernel_insn_init()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 404b639e510b36136ef15b08ca8a022845ed87db Gitweb: https://git.kernel.org/tip/404b639e510b36136ef15b08ca8a022845ed87db Author:Borislav Petkov AuthorDate:Sun, 22 Nov 2020 18:12:37 +01:00

[tip: x86/core] tools/perf: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: 62660b0fd238253aff951479a2adf1f06a231422 Gitweb: https://git.kernel.org/tip/62660b0fd238253aff951479a2adf1f06a231422 Author:Borislav Petkov AuthorDate:Mon, 23 Nov 2020 23:00:16 +01:00

[tip: x86/core] x86/tools/insn_sanity: Convert to insn_decode()

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/core branch of tip: Commit-ID: a277ce601cd1c75412a82dfcff547b3173098ef0 Gitweb: https://git.kernel.org/tip/a277ce601cd1c75412a82dfcff547b3173098ef0 Author:Borislav Petkov AuthorDate:Sun, 22 Nov 2020 18:11:10 +01:00

[tip: x86/misc] tools/x86/kcpuid: Add AMD Secure Encryption leaf

2021-03-15 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/misc branch of tip: Commit-ID: 2d4177c01b4e7496c7d47b31865f8c85bffb3604 Gitweb: https://git.kernel.org/tip/2d4177c01b4e7496c7d47b31865f8c85bffb3604 Author:Borislav Petkov AuthorDate:Sat, 13 Mar 2021 14:56:16 +01:00

[PATCH 2/2] tools/x86/kcpuid: Add AMD leaf 0x8000001E

2021-03-15 Thread Borislav Petkov
From: Borislav Petkov Contains core IDs, node IDs and other topology info. Signed-off-by: Borislav Petkov --- tools/arch/x86/kcpuid/cpuid.csv | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/tools/arch/x86/kcpuid/cpuid.csv b/tools/arch/x86/kcpuid

[PATCH 1/2] tools/x86/kcpuid: Check last token too

2021-03-15 Thread Borislav Petkov
From: Borislav Petkov Input lines like 0x801E, 0, EAX, 31:0, Extended APIC ID where the short name is missing lead to a segfault because the loop takes the long name for the short name and tokens[5] becomes NULL which explodes later in strcpy(). Check its value too before further

[PATCH] x86/mce/inject: Add IPID for injection too

2021-03-14 Thread Borislav Petkov
From: Borislav Petkov Add an injection file in order to specify IPID too when injecting an error, for example, for using the machinery to decode MCEs from other machines. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/mce/inject.c | 6 ++ 1 file changed, 6 insertions(+) diff

[GIT PULL] perf/urgent for v5.12-rc3

2021-03-14 Thread Borislav Petkov
Hi Linus, please pull there perf urgent fixes for v5.12-rc3. Thx. --- The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git

[GIT PULL] efi/urgent for v5.12-rc3

2021-03-14 Thread Borislav Petkov
Hi Linus, please pull a single (forwarded) EFI urgent fix for v5.12-rc3. Thx. --- The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at:

[GIT PULL] x86/urgent for v5.12-rc3

2021-03-14 Thread Borislav Petkov
Hi Linus, please pull the accumulated x86/urgent pile for v5.12-rc3. Thx. --- The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at:

Re: [PATCH] tools/x86/kcpuid: Add AMD Secure Encryption leaf

2021-03-13 Thread Borislav Petkov
On Sat, Mar 13, 2021 at 03:01:18PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > Add the 0x801f leaf's fields. > > Signed-off-by: Borislav Petkov > --- > tools/arch/x86/kcpuid/cpuid.csv | 10 ++ > 1 file changed, 10 insertions(+) > > diff

[PATCH] tools/x86/kcpuid: Add AMD Secure Encryption leaf

2021-03-13 Thread Borislav Petkov
From: Borislav Petkov Add the 0x801f leaf's fields. Signed-off-by: Borislav Petkov --- tools/arch/x86/kcpuid/cpuid.csv | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/arch/x86/kcpuid/cpuid.csv b/tools/arch/x86/kcpuid/cpuid.csv index f4a5b85073f4..7cb5c2189345 100644

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Borislav Petkov
On Sat, Mar 13, 2021 at 01:58:56PM +0100, Sedat Dilek wrote: > You can add Debian/experimental APT sources.list ... I could but I don't expect clang12 to behave any differently here. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Borislav Petkov
On Sat, Mar 13, 2021 at 01:38:22PM +0100, Sedat Dilek wrote: > AFAICS you did a 5 times x86-64 defconfig with dropped pagecache and `make > -j9`? The tailored .config for that particular test box. > Does your distribution offer LLVM/Clang v12.0.0-rc3 (released this > week) binaries? The

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Borislav Petkov
On Sat, Mar 13, 2021 at 01:10:29PM +0100, Sedat Dilek wrote: > Here we go: > > https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/patch/?id=864b435514b286c0be2a38a02f487aa28d990ef8 That's why I told earlier you to use tip/master - that patch is already in it and all you would've needed

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Borislav Petkov
On Sat, Mar 13, 2021 at 09:49:23AM +0100, Borislav Petkov wrote: > Lemme rerun here with clang. clang11 is almost twice as slow as gcc but difference is still negligible: ~0.6 seconds. ./tools/perf/perf stat --repeat 5 --sync --pre=/root/bin/pre-build-kernel.sh -- make -s -j9 LLVM=1 LLVM_IA

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-13 Thread Borislav Petkov
On Sat, Mar 13, 2021 at 06:26:15AM +0100, Sedat Dilek wrote: > x86/jump_label: Mark arguments as const to satisfy asm constraints Where do I find this patch? > x86: Remove dynamic NOP selection > objtool,x86: Use asm/nops.h > > My benchmark was to build a Linux-kernel with LLVM/Clang

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Borislav Petkov
On Fri, Mar 12, 2021 at 12:32:53PM +0100, Peter Zijlstra wrote: > Since ultimate performance of a 10 year old chip (Intel Sandy Bridge, 2011) is > simply irrelevant today, remove variable NOPs and use NOPL. Just ran them on my SNB box: cpu family : 6 model : 45 model name :

Re: amdgpu, WARNING: CPU: 12 PID: 389 at arch/x86/kernel/fpu/core.c:129 kernel_fpu_begin_mask+0xd5/0x100

2021-03-12 Thread Borislav Petkov
On Fri, Mar 12, 2021 at 06:20:25PM +, Deucher, Alexander wrote: > Should be fixed with these patches: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=15e8b95d5f7509e0b09289be8c422c459c9f0412 >

amdgpu, WARNING: CPU: 12 PID: 389 at arch/x86/kernel/fpu/core.c:129 kernel_fpu_begin_mask+0xd5/0x100

2021-03-12 Thread Borislav Petkov
Hi folks, I get the below on -rc2+tip/master. I added printks to your FPU macros: --- diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h index 126c2f3a4dd3..49629dc03f99 100644 --- a/drivers/gpu/drm/amd/display/dc/os_types.h +++

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Borislav Petkov
On Fri, Mar 12, 2021 at 06:35:45PM +0100, Sedat Dilek wrote: > Hey Steve, you degraded me to a number :-). How did he degrade you to a number?! Actually, he went the length to patiently explain what you could do. > I dunno which Git tree this patchset applies to, but I check if I can

Re: [PATCH 0/2] x86: Remove ideal_nops[]

2021-03-12 Thread Borislav Petkov
On Fri, Mar 12, 2021 at 03:29:48PM +0100, Sedat Dilek wrote: > What does this change exactly mean to/for me? Probably nothing. I would be very surprised if it would be at all noticeable for you - it's not like the kernel is executing long streams of NOPs in fast paths. -- Regards/Gruss,

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-03-11 Thread Borislav Petkov
On Thu, Mar 11, 2021 at 04:15:37PM -0600, Babu Moger wrote: > My host is > # cat /etc/redhat-release > Red Hat Enterprise Linux release 8.3 (Ootpa) > # uname -r > 5.12.0-rc2+ Please upload host and guest .config. Thx. -- Regards/Gruss, Boris.

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-03-11 Thread Borislav Petkov
On Thu, Mar 11, 2021 at 02:57:04PM -0600, Babu Moger wrote: > It is related PCID and INVPCID combination. Few more details. > 1. System comes up fine with "noinvpid". So, it happens when invpcid is > enabled. Which system, host or guest? > 2. Host is coming up fine. Problem is with the guest.

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-03-11 Thread Borislav Petkov
On Thu, Mar 11, 2021 at 01:23:47PM -0800, Jim Mattson wrote: > I would expect kaiser_enabled to be false (and PCIDs not to be used), > since AMD CPUs are not vulnerable to Meltdown. Ah, of course. The guest dmesg should have "Kernel/User page tables isolation: disabled." Lemme see if I can

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-03-11 Thread Borislav Petkov
On Thu, Mar 11, 2021 at 09:07:55PM +0100, Borislav Petkov wrote: > On Wed, Mar 10, 2021 at 07:21:23PM -0600, Babu Moger wrote: > > # git bisect good > > 59094faf3f618b2d2b2a45acb916437d611cede6 is the first bad commit > > commit 59094faf3f618b2d2b2a45acb916437d611cede6 > &

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-03-11 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 07:21:23PM -0600, Babu Moger wrote: > # git bisect good > 59094faf3f618b2d2b2a45acb916437d611cede6 is the first bad commit > commit 59094faf3f618b2d2b2a45acb916437d611cede6 > Author: Borislav Petkov > Date: Mon Dec 25 13:57:16 2017 +0100 > > x86

Re: [PATCH v6 00/12] x86: major paravirt cleanup

2021-03-11 Thread Borislav Petkov
On Thu, Mar 11, 2021 at 01:50:26PM +0100, Borislav Petkov wrote: > and move the cleanups patches 13 and 14 to the beginning of the set? Yeah, 14 needs ALTERNATIVE_TERNARY so I guess after patch 5, that is. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v6 00/12] x86: major paravirt cleanup

2021-03-11 Thread Borislav Petkov
On Tue, Mar 09, 2021 at 02:48:01PM +0100, Juergen Gross wrote: > This is a major cleanup of the paravirt infrastructure aiming at > eliminating all custom code patching via paravirt patching. > > This is achieved by using ALTERNATIVE instead, leading to the ability > to give objtool access to the

Re: [PATCH V2 2/25] x86/cpu: Add helper functions to get parameters of hybrid CPUs

2021-03-11 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 08:37:38AM -0800, kan.li...@linux.intel.com wrote: > From: Ricardo Neri > > On processors with Intel Hybrid Technology (i.e., one having more than one > type of CPU in the same package), all CPUs support the same instruction > set and enumerate the same features on CPUID.

Re: [PATCH v22 8/8] x86/vdso: Add ENDBR64 to __vdso_sgx_enter_enclave

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 02:55:55PM -0800, Yu, Yu-cheng wrote: > > > @@ -27,6 +27,9 @@ > > > SYM_FUNC_START(__vdso_sgx_enter_enclave) > > > /* Prolog */ > > > .cfi_startproc > > > +#ifdef CONFIG_X86_CET > > > + endbr64 > > > +#endif You can hide this ifdeffery in a macro and

Re: [PATCH V2 1/25] x86/cpufeatures: Enumerate Intel Hybrid Technology feature bit

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 11:46:44AM -0800, Ricardo Neri wrote: > But this series provides the use case, right? Kan's patches handle PMU > counters > that may differ cross types of CPUs. In patch 2, get_hybrid_params() > needs to check first if X86_FEATURE_HYBRID_CPU is enabled before > querying

Re: [PATCH v6 3/6] x86/elf: Support a new ELF aux vector AT_MINSIGSTKSZ

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 04:34:40PM +, Bae, Chang Seok wrote: > Yeah, right. While this attempts to fix the issue, it involves the ABI change. > Len and I think PATCH5 [1] is rather a backport candidate as it gives a more > reasonable behavior. Yap, patch 5 is more conservative, sure. I guess

Re: [PATCH V2 1/25] x86/cpufeatures: Enumerate Intel Hybrid Technology feature bit

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 08:37:37AM -0800, kan.li...@linux.intel.com wrote: > From: Ricardo Neri > > Add feature enumeration to identify a processor with Intel Hybrid > Technology: one in which CPUs of more than one type are the same package. > On a hybrid processor, all CPUs support the same

Re: [PATCH v6 05/12] x86/alternative: support ALTERNATIVE_TERNARY

2021-03-10 Thread Borislav Petkov
On Tue, Mar 09, 2021 at 02:48:06PM +0100, Juergen Gross wrote: > diff --git a/arch/x86/include/asm/alternative.h > b/arch/x86/include/asm/alternative.h > index 89889618ae01..4fb844e29d26 100644 > --- a/arch/x86/include/asm/alternative.h > +++ b/arch/x86/include/asm/alternative.h > @@ -178,6

Re: [PATCH v6 04/12] x86/alternative: support not-feature

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 08:52:40AM +0100, Jürgen Groß wrote: > Did you look at patch 13? :-) Well, I usually review in increasing patch order. :-P But make that change here pls because otherwise unnecessary churn. Thx. -- Regards/Gruss, Boris.

Re: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call()

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 08:51:22AM +0100, Jürgen Groß wrote: > It is combining the two needed actions: update the static call and > set the paravirt_using_native_sched_clock boolean. I actually meant what the point of using_native_sched_clock() is but put this comment at the wrong place, sorry.

Re: [PATCH v4 01/22] x86/fpu/xstate: Modify the initialization helper to handle both static and dynamic buffers

2021-03-10 Thread Borislav Petkov
On Sun, Feb 21, 2021 at 10:56:16AM -0800, Chang S. Bae wrote: > diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c > index 571220ac8bea..d43661d309ab 100644 > --- a/arch/x86/kernel/fpu/core.c > +++ b/arch/x86/kernel/fpu/core.c > @@ -192,8 +192,18 @@ static inline void

Re: [PATCH v2 00/25] KVM SGX virtualization support

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 10:27:05PM +1300, Kai Huang wrote: > Sorry for the mistake. I will send out another version with that fixed. If patch 3 is the only one which needs to change, you can send only that one as a reply to the original patch 3 message... Thx. -- Regards/Gruss, Boris.

Re: [PATCH] x86/vdso: avoid warning when building vdso2c on 32-bit host

2021-03-10 Thread Borislav Petkov
On Wed, Mar 10, 2021 at 10:22:16AM +0100, Jan Beulich wrote: > size_t arguments can't compatibly be passed for l-modifier format > specifiers. Use z instead. > > Fixes: 8382c668ce4f ("x86/vdso: Add support for exception fixup in vDSO > functions") > Signed-off-by: Jan Beulich > > ---

Re: [PATCH v6 04/12] x86/alternative: support not-feature

2021-03-09 Thread Borislav Petkov
On Tue, Mar 09, 2021 at 02:48:05PM +0100, Juergen Gross wrote: > Add support for alternative patching for the case a feature is not > present on the current cpu. > > For users of ALTERNATIVE() and friends an inverted feature is specified > by applying the ALT_NOT() macro to it, e.g.: > >

Re: [PATCH] stacktrace: Move documentation for arch_stack_walk_reliable() to header

2021-03-09 Thread Borislav Petkov
> Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Heiko Carstens > Cc: Christian Borntraeger > Cc: Josh Poimboeuf > Cc: Jiri Kosina > Cc: Petr Mladek > Cc: Joe Lawrence > Cc: x...@kernel.org > Cc: linux-s...@vg

Re: [PATCH v6 02/12] x86/paravirt: switch time pvops functions to use static_call()

2021-03-09 Thread Borislav Petkov
On Tue, Mar 09, 2021 at 02:48:03PM +0100, Juergen Gross wrote: > @@ -167,6 +168,17 @@ static u64 native_steal_clock(int cpu) > return 0; > } > > +DEFINE_STATIC_CALL(pv_steal_clock, native_steal_clock); > +DEFINE_STATIC_CALL(pv_sched_clock, native_sched_clock); > + > +bool

Re: [PATCH 2/2] sigaction.2: wfix - Clarify si_addr description.

2021-03-09 Thread Borislav Petkov
On Mon, Mar 08, 2021 at 01:46:07PM -0800, Yu, Yu-cheng wrote: > I think the sentence above is vague, but probably for the reason that each > arch is different. Maybe this patch is unnecessary and can be dropped? Maybe. If you want to clarify it, you should audit every arch. But what would that

Re: [PATCH v2 00/25] KVM SGX virtualization support

2021-03-09 Thread Borislav Petkov
On Tue, Mar 09, 2021 at 02:38:49PM +1300, Kai Huang wrote: > This series adds KVM SGX virtualization support. The first 14 patches starting > with x86/sgx or x86/cpu.. are necessary changes to x86 and SGX core/driver to > support KVM SGX virtualization, while the rest are patches to KVM subsystem.

Re: [PATCH 2/2] sigaction.2: wfix - Clarify si_addr description.

2021-03-08 Thread Borislav Petkov
On Fri, Feb 26, 2021 at 09:26:34AM -0800, Yu-cheng Yu wrote: > SIGSEGV fills si_addr only for memory access faults. Add a note to clarify. > > Signed-off-by: Yu-cheng Yu > Cc: Alejandro Colomar > Cc: Michael Kerrisk > Cc: Andy Lutomirski > Cc: Borislav Petkov &g

Re: [PATCH v5 11/12] x86/paravirt: switch functions with custom code to ALTERNATIVE

2021-03-08 Thread Borislav Petkov
On Mon, Mar 08, 2021 at 01:28:43PM +0100, Juergen Gross wrote: > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index 36cd71fa097f..04b3067f31b5 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -137,7 +137,8 @@ static

Re: [PATCH v1 1/1] scripts/decodecode: Decode 32-bit code correctly on x86_64

2021-03-08 Thread Borislav Petkov
On Mon, Mar 08, 2021 at 12:22:34PM +0200, Andy Shevchenko wrote: > For the ARM we have to provide ARCH, for x86 a variety of all the flags. For x86 you have to provide only AFLAGS. If you want to make this script parse proper cmdline options like --arch, --width and --help along with keeping the

Re: [PATCH v1 1/1] scripts/decodecode: Decode 32-bit code correctly on x86_64

2021-03-08 Thread Borislav Petkov
On Mon, Mar 08, 2021 at 11:59:34AM +0200, Andy Shevchenko wrote: > It works, but... The question here is why the script behaviour depends > so much on the architecture in question (by environment). ARM stuff is > using traditional ARCH (and that's what I have expected to work), > while x86 has a

[tip: x86/seves] x86/sev-es: Remove subtraction of res variable

2021-03-06 Thread tip-bot2 for Borislav Petkov
The following commit has been merged into the x86/seves branch of tip: Commit-ID: f3db3365c069c2a8505cdee8033fe3d22d2fe6c0 Gitweb: https://git.kernel.org/tip/f3db3365c069c2a8505cdee8033fe3d22d2fe6c0 Author:Borislav Petkov AuthorDate:Tue, 23 Feb 2021 12:03:19 +01:00

Re: [PATCH] x86/smpboot: remove duplicate include in smpboot.c

2021-03-06 Thread Borislav Petkov
On Fri, Mar 05, 2021 at 10:56:10PM -0800, menglong8.d...@gmail.com wrote: > From: Zhang Yunkai > > 'cpu_device_id.h' and 'intel_family.h' included in 'smpboot.c' > is duplicated. It is also included in the 80th line. > > Signed-off-by: Zhang Yunkai If you send another person's patch, then

Re: [PATCH v1 1/1] scripts/decodecode: Decode 32-bit code correctly on x86_64

2021-03-05 Thread Borislav Petkov
On Fri, Mar 05, 2021 at 08:39:48PM +0200, Andy Shevchenko wrote: > On x86_64 host the objdump uses current architecture which is 64-bit > and hence decodecode shows wrong instructions. > > Fix it by supplying '-M i386' in case of ARCH i?86 or x86. At the beginning of the script says: # e.g., to

Re: [PATCH 06/25] x86/cpu/intel: Allow SGX virtualization without Launch Control support

2021-03-05 Thread Borislav Petkov
On Mon, Mar 01, 2021 at 10:45:02PM +1300, Kai Huang wrote: > From: Sean Christopherson > > The kernel will currently disable all SGX support if the hardware does > not support launch control. Make it more permissive to allow SGX > virtualization on systems without Launch Control support. This

Re: [PATCH v21 10/26] x86/mm: Update pte_modify for _PAGE_COW

2021-03-05 Thread Borislav Petkov
On Wed, Feb 17, 2021 at 02:27:14PM -0800, Yu-cheng Yu wrote: > @@ -787,16 +802,34 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t > newprot) >*/ > val &= _PAGE_CHG_MASK; > val |= check_pgprot(newprot) & ~_PAGE_CHG_MASK; > + val = fixup_dirty_pte(val); Do I see it

Re: [PATCH] x86/platform/uv: Add set of kernel block size for hubless arches

2021-03-05 Thread Borislav Petkov
On Thu, Mar 04, 2021 at 04:39:55PM -0600, Mike Travis wrote: > The commit below added a call to set the block size value that is needed > to set the value used by the kernel. This was done for UV Hubbed systems. > This commit adds that same set call to hubless systems which supports the > same

Re: [PATCH v5] tools/x86: Add a kcpuid tool to show raw CPU features

2021-03-05 Thread Borislav Petkov
n prototype code from Borislav Petkov (http://sr71.net/~dave/intel/stupid-cpuid.c). [ bp: - Massage, add #define _GNU_SOURCE to fix implicit declaration of function ‘strcasestr' warning - remove superfluous newlines - fallback to cpuid.csv in the current dir if none found - fix

Re: [PATCH v6 3/6] x86/elf: Support a new ELF aux vector AT_MINSIGSTKSZ

2021-03-05 Thread Borislav Petkov
On Sat, Feb 27, 2021 at 08:59:08AM -0800, Chang S. Bae wrote: > Historically, signal.h defines MINSIGSTKSZ (2KB) and SIGSTKSZ (8KB), for > use by all architectures with sigaltstack(2). Over time, the hardware state > size grew, but these constants did not evolve. Today, literal use of these >

Re: [PATCH v3 17/21] tools/objtool: Convert to insn_decode()

2021-03-04 Thread Borislav Petkov
On Thu, Mar 04, 2021 at 06:49:08PM +0100, Peter Zijlstra wrote: > This is going to have trivial rejects/fuzz against tip/objtool/core. I was just wondering whether to you show you how I resolved :) diff --cc tools/objtool/arch/x86/decode.c index 431bafb881d4,8380d0b1d933..22a53ee322ea ---

[PATCH v3 20/21] x86/insn: Remove kernel_insn_init()

2021-03-04 Thread Borislav Petkov
From: Borislav Petkov Now that it is not needed anymore, drop it. Signed-off-by: Borislav Petkov --- arch/x86/include/asm/insn.h | 11 --- tools/arch/x86/include/asm/insn.h | 11 --- 2 files changed, 22 deletions(-) diff --git a/arch/x86/include/asm/insn.h b/arch/x86

<    1   2   3   4   5   6   7   8   9   10   >