[PATCH 14/19] perf ftrace: add option -P/--no-pager to disable pager

2020-05-10 Thread Changbin Du
Sometimes we want perf displays trace immediately. So this adds an option '-P/--no-pager' to disable pager if needed. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-

[PATCH 15/19] perf ftrace: show trace column header

2020-05-10 Thread Changbin Du
<...>-9246 [006] 10726.262767: fpregs_assert_state_consistent <-do_syscall_64 Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index 64c22f367ba2..0b39b6a88026 1

[PATCH 09/19] perf ftrace: add support for trace option tracing_thresh

2020-05-10 Thread Changbin Du
This adds an option '--tracing-thresh' to setup trace duration threshold for funcgraph tracer. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builti

[PATCH 08/19] perf ftrace: add option -l/--long-info to show more info

2020-05-10 Thread Changbin Du
lp_close() { 6800.190949 | 4) <...>-7683 | 0.320 us| dnotify_flush(); 6800.190950 | 4) <...>-7683 | 0.325 us| locks_remove_posix(); Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 28 1 file changed,

[PATCH 11/19] perf ftrace: add option '-u/--userstacktrace' to show userspace stacktrace

2020-05-10 Thread Changbin Du
This adds an option ''-u/--userstacktrace' for function tracer to display userspace back trace. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 24 1 file changed, 24 insertions(+) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/b

[PATCH 07/19] perf ftrace: add support for trace option funcgraph-irqs

2020-05-10 Thread Changbin Du
This adds an option '--nofuncgraph-irqs' to filter out functions executed in irq context. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftra

[PATCH 05/19] perf ftrace: add option '-l/--list-functions' to list available functions

2020-05-10 Thread Changbin Du
This adds an option '-l/--list-functions' to list all available functions which is read from tracing file 'available_filter_functions'. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 43 + 1 file changed, 43 insertions(+)

[PATCH 10/19] perf ftrace: add support for trace option funcgraph-tail

2020-05-10 Thread Changbin Du
This adds an option '--funcgraph-tail' for function graph tracer. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index 20bc14d6c5fb..2e

[PATCH 06/19] perf ftrace: add support for trace option sleep-time

2020-05-10 Thread Changbin Du
This adds an option '--nosleep-time' which allow us only to measure on-CPU time. This option is function_graph tracer only. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 20 1 file changed, 20 insertions(+) diff --git a/tools/perf/builtin-ftrace

[PATCH 03/19] perf ftrace: select function/function_graph tracer automatically

2020-05-10 Thread Changbin Du
ll trace all functions using function graph tracer: $ sudo perf ftrace -G This will trace function vfs_read using function graph tracer: $ sudo perf ftrace -G vfs_read Signed-off-by: Changbin Du --- tools/perf/Documentation/perf-config.txt | 5 --- tools/perf/builtin-ftrace.c | 39 +

[PATCH 04/19] perf ftrace: add support for tracing option 'func_stack_trace'

2020-05-10 Thread Changbin Du
=> __x64_sys_read => do_syscall_64 => entry_SYSCALL_64_after_hwframe ... Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 38 + 1 file changed, 38 insertions(+) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c inde

[PATCH 01/19] perf ftrace: trace system wide if no target is given

2020-05-10 Thread Changbin Du
This align ftrace to other perf sub-commands that if no target specified then we trace all functions. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index

[PATCH 02/19] perf ftrace: detect workload failure

2020-05-10 Thread Changbin Du
Currently there's no error message prompted if we failed to start workload. And we still get some trace which is confusing. Let's tell users what happened. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-)

[PATCH 00/19] perf: ftrace enhancement

2020-05-10 Thread Changbin Du
ns of which the duration is greater than µs Changbin Du (19): perf ftrace: trace system wide if no target is given perf ftrace: detect workload failure perf ftrace: select function/function_graph tracer automatically perf ftrace: add support for tracing option 'func_stack_trace' p

[PATCH v5] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

2020-05-09 Thread Changbin Du
Sometimes it is useful to preserve batches of configs when making localmodconfig. For example, I usually don't want any usb and fs modules to be disabled. Now we can do it by: $ make LMC_KEEP="drivers/usb:fs" localmodconfig Signed-off-by: Changbin Du --- v4: fix t

Re: [PATCH v4] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

2020-05-08 Thread Changbin Du
On Thu, May 07, 2020 at 09:18:07AM -0400, Steven Rostedt wrote: > On Thu, 7 May 2020 12:19:57 +0900 > Masahiro Yamada wrote: > > > On Sun, May 3, 2020 at 9:11 AM Changbin Du wrote: > > > > > > Sometimes it is useful to preserve batches of configs when making >

[PATCH] perf trace: add default value for opt 'call-graph'

2020-05-02 Thread Changbin Du
The documentation says the default value of call-graph.record_mode is 'fp'. But actually we never can omit value of call-graph parameter. This patch can fix this issue. Meanwhile, this patch adds a short name '-g' for opt 'call-graph' since it's very

[PATCH v4] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

2020-05-02 Thread Changbin Du
Sometimes it is useful to preserve batches of configs when making localmodconfig. For example, I usually don't want any usb and fs modules to be disabled. Now we can do it by: $ make LMC_KEEP="drivers/usb;fs" localmodconfig Signed-off-by: Changbin Du --- v4: fix t

Re: [PATCH v3] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

2020-05-02 Thread Changbin Du
On Sat, May 02, 2020 at 08:50:22AM -0700, Randy Dunlap wrote: > On 5/2/20 8:30 AM, Changbin Du wrote: > > Sometimes it is useful to preserve batches of configs when making > > localmodconfig. For example, I usually don't want any usb and fs > > modules to be dis

[PATCH v3] streamline_config.pl: add LMC_KEEP to preserve some kconfigs

2020-05-02 Thread Changbin Du
Sometimes it is useful to preserve batches of configs when making localmodconfig. For example, I usually don't want any usb and fs modules to be disabled. Now we can do it by: $ make LMC_KEEP="drivers/usb;fs" localmodconfig Signed-off-by: Changbin Du --- v3: rename LOCALMODCON

Re: [PATCH] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs

2020-05-02 Thread Changbin Du
Hi, Steven, On Sat, May 02, 2020 at 09:40:24AM -0400, Steven Rostedt wrote: > On Sat, 2 May 2020 21:30:54 +0800 > Changbin Du wrote: > > > > > Sometimes it is useful to preserve batches of configs when making > > > > localmodconfig. For example, I

[PATCH v2] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs

2020-05-02 Thread Changbin Du
Sometimes it is useful to preserve batches of configs when making localmodconfig. For example, I usually don't want any usb and fs modules to be disabled. Now we can do it by: $ make LOCALMODCONFIG_PRESERVE="drivers/usb;fs" localmodconfig Signed-off-by: Changbin Du ---

Re: [PATCH] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs

2020-05-02 Thread Changbin Du
On Fri, May 01, 2020 at 01:07:29PM -0400, Steven Rostedt wrote: > On Fri, 1 May 2020 10:37:08 +0800 > Changbin Du wrote: > > > Sometimes it is useful to preserve batches of configs when making > > localmodconfig. For example, I usually don't want any usb and fs >

Re: [PATCH] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs

2020-05-02 Thread Changbin Du
On Fri, May 01, 2020 at 09:51:17AM -0700, Randy Dunlap wrote: > On 4/30/20 7:37 PM, Changbin Du wrote: > > Sometimes it is useful to preserve batches of configs when making > > localmodconfig. For example, I usually don't want any usb and fs > > modules to be dis

[PATCH] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs

2020-04-30 Thread Changbin Du
Sometimes it is useful to preserve batches of configs when making localmodconfig. For example, I usually don't want any usb and fs modules to be disabled. Now we can do it by: $ make LOCALMODCONFIG_PRESERVE="drivers/usb;fs" localmodconfig Signed-off-by: Changbin Du --- Docu

Re: mm/slub: do not place freelist pointer to middle of object if redzone is on

2020-04-28 Thread Changbin Du
change description > also at another place? > Waiman just posted another fix for this issue. Let's use that patch instead. Thanks. > Regards, > Markus -- Cheers, Changbin Du

[PATCH v5 2/2] perf: add support for logging debug messages to file

2019-10-17 Thread Changbin Du
: Changbin Du --- v5: doc default log path. v4: fix another segfault. v3: fix a segfault issue. --- tools/perf/Documentation/perf.txt | 16 ++- tools/perf/util/debug.c | 44 --- 2 files changed, 50 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH v5 1/2] perf: support multiple debug options separated by ','

2019-10-17 Thread Changbin Du
This patch adds support for multiple debug options separated by ',' and non-int values. --debug verbose=2,stderr Signed-off-by: Changbin Du --- tools/perf/Documentation/perf.txt | 10 ++-- tools/perf/util/debug.c | 86 --- 2 files c

[PATCH v5 0/2] perf: add support for logging debug messages to file

2019-10-17 Thread Changbin Du
segfault issue. v2: o specific all debug options one time. Changbin Du (2): perf: support multiple debug options separated by ',' perf: add support for logging debug messages to file tools/perf/Documentation/perf.txt | 16 ++-- tools/perf/util/debug.c

Re: [PATCH v4 2/2] perf: add support for logging debug messages to file

2019-10-15 Thread Changbin Du
On Mon, Oct 14, 2019 at 05:29:53PM +0200, Jiri Olsa wrote: > On Tue, Oct 08, 2019 at 08:35:54PM +0800, Changbin Du wrote: > > When in TUI mode, it is impossible to show all the debug messages to > > console. This make it hard to debug perf issues using debug messages. > > Th

[PATCH v4 2/2] perf: add support for logging debug messages to file

2019-10-08 Thread Changbin Du
: Changbin Du -- v4: fix another segfault. v3: fix a segfault issue. --- tools/perf/Documentation/perf.txt | 15 ++- tools/perf/util/debug.c | 44 --- 2 files changed, 49 insertions(+), 10 deletions(-) diff --git a/tools/perf/Documentation/perf.txt

[PATCH v4 1/2] perf: support multiple debug options separated by ','

2019-10-08 Thread Changbin Du
This patch adds support for multiple debug options separated by ',' and non-int values. --debug verbose=2,stderr Signed-off-by: Changbin Du --- tools/perf/Documentation/perf.txt | 10 ++-- tools/perf/util/debug.c | 86 --- 2 files c

[PATCH v4 0/2] perf: add support for logging debug messages to file

2019-10-08 Thread Changbin Du
specific all debug options one time. Changbin Du (2): perf: support multiple debug options separated by ',' perf: add support for logging debug messages to file tools/perf/Documentation/perf.txt | 15 ++-- tools/perf/util/debug.c | 124 -- 2 files c

Re: [PATCH v3 0/2] perf: add support for logging debug messages to file

2019-10-08 Thread Changbin Du
On Mon, Oct 07, 2019 at 01:26:24PM +0200, Jiri Olsa wrote: > On Fri, Oct 04, 2019 at 10:39:52AM +0800, Changbin Du wrote: > > When in TUI mode, it is impossible to show all the debug messages to > > console. This make it hard to debug perf issues using debug messages. > > Th

Re: [PATCH] x86/mm: determine whether the fault address is canonical

2019-10-05 Thread Changbin Du
nr == X86_TRAP_GP. 0 is > canonical last I checked, which would make this patch a bit academic. :) My fault. I thought the 'fault_addr' is filled with a valid value. So we really don't know the answer without decoding the instruction which causes this #GP. :) -- Cheers, Changbin Du

[PATCH] x86/mm: determine whether the fault address is canonical

2019-10-04 Thread Changbin Du
We know the answer, so don't ask the user. Signed-off-by: Changbin Du --- arch/x86/mm/extable.c | 5 - arch/x86/mm/mm_internal.h | 11 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c index 4d75bc6

[PATCH v3 1/2] perf: support multiple debug options separated by ','

2019-10-03 Thread Changbin Du
This patch adds support for multiple debug options separated by ',' and non-int values. --debug verbose=2,stderr Signed-off-by: Changbin Du --- tools/perf/Documentation/perf.txt | 10 ++-- tools/perf/util/debug.c | 86 --- 2 files c

[PATCH v3 2/2] perf: add support for logging debug messages to file

2019-10-03 Thread Changbin Du
: Changbin Du -- v3: fix a segfault issue. --- tools/perf/Documentation/perf.txt | 15 ++- tools/perf/util/debug.c | 44 +++ 2 files changed, 48 insertions(+), 11 deletions(-) diff --git a/tools/perf/Documentation/perf.txt b/tools/perf/Documentation

[PATCH v3 0/2] perf: add support for logging debug messages to file

2019-10-03 Thread Changbin Du
. Changbin Du (2): perf: support multiple debug options separated by ',' perf: add support for logging debug messages to file tools/perf/Documentation/perf.txt | 15 ++-- tools/perf/util/debug.c | 124 +++--- 2 files changed, 90 insertions(+), 49

Re: [PATCH v2 0/2] perf: add support for logging debug messages to file

2019-10-03 Thread Changbin Du
On Sun, Sep 29, 2019 at 09:44:07AM +0200, Jiri Olsa wrote: > On Sun, Sep 22, 2019 at 10:38:21AM +0800, Changbin Du wrote: > > When in TUI mode, it is impossible to show all the debug messages to > > console. This make it hard to debug perf issues using debug messages. > > Th

[RESEND PATCH v3 9/9] hacking: Move DEBUG_FS to 'Generic Kernel Debugging Instruments'

2019-10-03 Thread Changbin Du
DEBUG_FS does not belong to 'Compile-time checks and compiler options'. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.d

[RESEND PATCH v3 7/9] hacking: Create a submenu for scheduler debugging options

2019-10-03 Thread Changbin Du
Create a submenu 'Scheduler Debugging' for scheduler debugging options. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 2c

[RESEND PATCH v3 1/9] hacking: Group sysrq/kgdb/ubsan into 'Generic Kernel Debugging Instruments'

2019-10-03 Thread Changbin Du
Group generic kernel debugging instruments sysrq/kgdb/ubsan together into a new submenu. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib

[RESEND PATCH v3 0/9] hacking: make kconfig menu 'kernel hacking' better structurized

2019-10-03 Thread Changbin Du
< Exit >< Help >< Save >< Load > │ └─┘ v3: o change subject prefix. v2: o rebase to linux-next. o move DEBUG_FS to 'Generic Kernel Debugging Instruments' o move DEBUG_NOTIFIERS to 'Debug kernel d

[RESEND PATCH v3 6/9] hacking: Move SCHED_STACK_END_CHECK after DEBUG_STACK_USAGE

2019-10-03 Thread Changbin Du
They are both memory debug options to debug kernel stack issues. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug

[RESEND PATCH v3 3/9] hacking: Group kernel data structures debugging together

2019-10-03 Thread Changbin Du
Group these similar runtime data structures verification options together. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/Kconfig.debug b/lib

[RESEND PATCH v3 2/9] hacking: Create submenu for arch special debugging options

2019-10-03 Thread Changbin Du
The arch special options are a little long, so create a submenu for them. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 157db30e626d

[RESEND PATCH v3 8/9] hacking: Move DEBUG_BUGVERBOSE to 'printk and dmesg options'

2019-10-03 Thread Changbin Du
I think DEBUG_BUGVERBOSE is a dmesg option which gives more debug info to dmesg. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib

[RESEND PATCH v3 4/9] hacking: Move kernel testing and coverage options to same submenu

2019-10-03 Thread Changbin Du
Move error injection, coverage, testing, kunit options to a new submenu 'Kernel Testing and Coverage'. They are all for test purpose. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 499 +++-

[RESEND PATCH v3 5/9] hacking: Move Oops into 'Lockups and Hangs'

2019-10-03 Thread Changbin Du
They are similar options so place them together. Signed-off-by: Changbin Du Acked-by: Randy Dunlap Tested-by: Randy Dunlap --- lib/Kconfig.debug | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/lib/Kconfig.debug b/lib

[PATCH v2 2/2] perf: add support for logging debug messages to file

2019-09-21 Thread Changbin Du
: Changbin Du --- tools/perf/Documentation/perf.txt | 14 -- tools/perf/util/debug.c | 22 +- 2 files changed, 29 insertions(+), 7 deletions(-) diff --git a/tools/perf/Documentation/perf.txt b/tools/perf/Documentation/perf.txt index c05a94b2488e

[PATCH v2 0/2] perf: add support for logging debug messages to file

2019-09-21 Thread Changbin Du
When in TUI mode, it is impossible to show all the debug messages to console. This make it hard to debug perf issues using debug messages. This patch adds support for logging debug messages to file to resolve this problem. v2: o specific all debug options one time. Changbin Du (2): perf

[PATCH v2 1/2] perf: support multiple debug options separated by ','

2019-09-21 Thread Changbin Du
This patch adds support for multiple debug options separated by ',' and non-int values. --debug verbose=2,stderr Signed-off-by: Changbin Du --- tools/perf/Documentation/perf.txt | 10 ++-- tools/perf/util/debug.c | 86 --- 2 files c

Re: [PATCH] perf: add support for logging debug messages to file

2019-09-20 Thread Changbin Du
On Fri, Sep 20, 2019 at 10:53:56PM +0200, Jiri Olsa wrote: > On Sun, Sep 15, 2019 at 06:27:40PM +0800, Changbin Du wrote: > > When in TUI mode, it is impossible to show all the debug messages to > > console. This make it hard to debug perf issues using debug messages. > > Th

Re: [PATCH v3 0/9] hacking: make 'kernel hacking' menu better structurized

2019-09-20 Thread Changbin Du
Gentle ping for status of this series. thx! On Mon, Sep 09, 2019 at 10:44:44PM +0800, Changbin Du wrote: > This series is a trivial improvment for the layout of 'kernel hacking' > configuration menu. Now we have many items in it which makes takes > a little time to look up them

[PATCH] perf: add support for logging debug messages to file

2019-09-15 Thread Changbin Du
of log file is '~/perf.log'. Signed-off-by: Changbin Du --- tools/perf/Documentation/perf.txt | 4 +++- tools/perf/util/debug.c | 20 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/tools/perf/Documentation/perf.txt b/tools/perf/Doc

[PATCH] mm, tracing: print symbol name for call_site

2019-09-14 Thread Changbin Du
ERNEL [002] 808.188925: kmem_cache_free: call_site=putname+0x47/0x50 ptr=cef40c80 [002] 808.188926: kfree: call_site=security_cred_free+0x42/0x50 ptr=62400820 [002] 808.188931: kmem_cache_free: call_site=put_cred_rcu+0x88/0xa0 ptr=58d74ef8 Signed-off-by: C

[PATCH] x86/nmi: remove the irqwork for long nmi handler duration warning

2019-09-13 Thread Changbin Du
the safe printk will flush its per-cpu buffer before panic. Signed-off-by: Changbin Du --- arch/x86/include/asm/nmi.h | 1 - arch/x86/kernel/nmi.c | 20 +--- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/nmi.h b/arch/x86/include/asm

[PATCH v3] ftrace: simplify ftrace hash lookup code in clear_func_from_hash()

2019-09-10 Thread Changbin Du
Function ftrace_lookup_ip() will check empty hash table. So we don't need extra check outside. Signed-off-by: Changbin Du --- v3: only keep the change in function clear_func_from_hash(). v2: fix incorrect code remove. --- kernel/trace/ftrace.c | 6 +- 1 file changed, 1 insertion(

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-10 Thread Changbin Du
On Tue, Sep 10, 2019 at 05:28:04AM -0400, Steven Rostedt wrote: > On Tue, 10 Sep 2019 08:33:23 +0800 > Changbin Du wrote: > > > > > > > bool ftrace_lookup_ip(struct ftrace_hash *hash, unsigned long ip, bool > > > empty_result) > > > { > > >

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-09 Thread Changbin Du
On Mon, Sep 09, 2019 at 10:54:24AM -0400, Steven Rostedt wrote: > On Mon, 9 Sep 2019 08:31:59 +0800 > Changbin Du wrote: > > > Function ftrace_lookup_ip() will check empty hash table. So we don't > > need extra check outside. > > > > Signed-off-by:

Re: [PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-09 Thread Changbin Du
On Mon, Sep 09, 2019 at 10:54:24AM -0400, Steven Rostedt wrote: > On Mon, 9 Sep 2019 08:31:59 +0800 > Changbin Du wrote: > > > Function ftrace_lookup_ip() will check empty hash table. So we don't > > need extra check outside. > > > > Signed-off-by:

[PATCH v3 8/9] hacking: Move DEBUG_BUGVERBOSE to 'printk and dmesg options'

2019-09-09 Thread Changbin Du
I think DEBUG_BUGVERBOSE is a dmesg option which gives more debug info to dmesg. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ce891713c914..ceefe0c1e78b 100644

[PATCH v3 9/9] hacking: Move DEBUG_FS to 'Generic Kernel Debugging Instruments'

2019-09-09 Thread Changbin Du
DEBUG_FS does not belong to 'Compile-time checks and compiler options'. Cc: Randy Dunlap Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ce

[PATCH v3 7/9] hacking: Create a submenu for scheduler debugging options

2019-09-09 Thread Changbin Du
Create a submenu 'Scheduler Debugging' for scheduler debugging options. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ce545bb80ea2..ce891713c914 100644 --- a/lib/Kconfig.debug

[PATCH v3 5/9] hacking: Move Oops into 'Lockups and Hangs'

2019-09-09 Thread Changbin Du
They are similar options so place them together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 7b3552531d02..1385e17122a1 100644

[PATCH v3 6/9] hacking: Move SCHED_STACK_END_CHECK after DEBUG_STACK_USAGE

2019-09-09 Thread Changbin Du
They are both memory debug options to debug kernel stack issues. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1385e17122a1..ce545bb80ea2 100644 --- a

[PATCH v3 3/9] hacking: Group kernel data structures debugging together

2019-09-09 Thread Changbin Du
Group these similar runtime data structures verification options together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index cc4d8e71ae81..92271898b029

[PATCH v3 1/9] hacking: Group sysrq/kgdb/ubsan into 'Generic Kernel Debugging Instruments'

2019-09-09 Thread Changbin Du
Group generic kernel debugging instruments sysrq/kgdb/ubsan together into a new submenu. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 10023dbac8e4..bd3938483514

[PATCH v3 4/9] hacking: Move kernel testing and coverage options to same submenu

2019-09-09 Thread Changbin Du
Move error injection, coverage, testing options to a new submenu 'Kernel Testing and Coverage'. They are all for test purpose. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 497 +++--- 1 file changed, 251 insertions(+), 246 deletions(-) di

[PATCH v3 2/9] hacking: Create submenu for arch special debugging options

2019-09-09 Thread Changbin Du
The arch special options are a little long, so create a submenu for them. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index bd3938483514..cc4d8e71ae81 100644 --- a/lib/Kconfig.debug +++ b/lib

[PATCH v3 0/9] hacking: make 'kernel hacking' menu better structurized

2019-09-09 Thread Changbin Du
< Exit >< Help >< Save >< Load > │ └─┘ v3: o change subject prefix. v2: o rebase to linux-next. o move DEBUG_FS to 'Generic Kernel Debugging Instruments' o move DEBUG_NOTIFIERS to 'Debug kernel d

Re: [PATCH v2 0/9] kconfig/hacking: make 'kernel hacking' menu better structurized

2019-09-09 Thread Changbin Du
On Mon, Sep 09, 2019 at 11:31:10PM +0900, Masahiro Yamada wrote: > Hi. > > On Mon, Sep 9, 2019 at 11:18 PM Changbin Du wrote: > > > > This series is a trivial improvment for the layout of 'kernel hacking' > > configuration menu. Now we have many items in it w

[PATCH v2 5/9] kconfig/hacking: Move Oops into 'Lockups and Hangs'

2019-09-09 Thread Changbin Du
They are similar options so place them together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 7b3552531d02..1385e17122a1 100644

[PATCH v2 9/9] kconfig/hacking: Move DEBUG_FS to 'Generic Kernel Debugging Instruments'

2019-09-09 Thread Changbin Du
DEBUG_FS does not belong to 'Compile-time checks and compiler options'. Cc: Randy Dunlap Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ce

[PATCH v2 3/9] kconfig/hacking: Group kernel data structures debugging together

2019-09-09 Thread Changbin Du
Group these similar runtime data structures verification options together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index cc4d8e71ae81..92271898b029

[PATCH v2 2/9] kconfig/hacking: Create submenu for arch special debugging options

2019-09-09 Thread Changbin Du
The arch special options are a little long, so create a submenu for them. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index bd3938483514..cc4d8e71ae81 100644 --- a/lib/Kconfig.debug +++ b/lib

[PATCH v2 7/9] kconfig/hacking: Create a submenu for scheduler debugging options

2019-09-09 Thread Changbin Du
Create a submenu 'Scheduler Debugging' for scheduler debugging options. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ce545bb80ea2..ce891713c914 100644 --- a/lib/Kconfig.debug

[PATCH v2 6/9] kconfig/hacking: Move SCHED_STACK_END_CHECK after DEBUG_STACK_USAGE

2019-09-09 Thread Changbin Du
They are both memory debug options to debug kernel stack issues. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 1385e17122a1..ce545bb80ea2 100644 --- a

[PATCH v2 8/9] kconfig/hacking: Move DEBUG_BUGVERBOSE to 'printk and dmesg options'

2019-09-09 Thread Changbin Du
I think DEBUG_BUGVERBOSE is a dmesg option which gives more debug info to dmesg. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ce891713c914..ceefe0c1e78b 100644

[PATCH v2 1/9] kconfig/hacking: Group sysrq/kgdb/ubsan into 'Generic Kernel Debugging Instruments'

2019-09-09 Thread Changbin Du
Group generic kernel debugging instruments sysrq/kgdb/ubsan together into a new submenu. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 10023dbac8e4..bd3938483514

[PATCH v2 4/9] kconfig/hacking: Move kernel testing and coverage options to same submenu

2019-09-09 Thread Changbin Du
Move error injection, coverage, testing options to a new submenu 'Kernel Testing and Coverage'. They are all for test purpose. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 497 +++--- 1 file changed, 251 insertions(+), 246 deletions(-) di

[PATCH v2 0/9] kconfig/hacking: make 'kernel hacking' menu better structurized

2019-09-09 Thread Changbin Du
< Exit >< Help >< Save >< Load > │ └─┘ v2: o rebase to linux-next. o move DEBUG_FS to 'Generic Kernel Debugging Instruments' o move DEBUG_NOTIFIERS to 'Debug kernel data structures

Re: [PATCH 0/8] kconfig/hacking: make 'kernel hacking' menu better structured

2019-09-09 Thread Changbin Du
On Sun, Sep 08, 2019 at 05:44:54PM -0700, Randy Dunlap wrote: > On 9/7/19 6:27 PM, Changbin Du wrote: > > This series is a trivial improvment for the layout of 'kernel hacking' > > configuration menu. Now we have many items in it which makes takes > > a little time

[PATCH v2] ftrace: simplify ftrace hash lookup code

2019-09-08 Thread Changbin Du
Function ftrace_lookup_ip() will check empty hash table. So we don't need extra check outside. Signed-off-by: Changbin Du --- v2: fix incorrect code remove. --- kernel/trace/ftrace.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/kernel/trace/ftrace.c b/k

Re: [PATCH] ftrace: simplify ftrace hash lookup code

2019-09-08 Thread Changbin Du
On Sun, Sep 08, 2019 at 08:05:45PM +0800, Changbin Du wrote: > diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > index 005f08629b8b..74162bc4024d 100644 > --- a/kernel/trace/trace.h > +++ b/kernel/trace/trace.h > @@ -941,11 +941,6 @@ static inline int ftrace_gr

[PATCH] ftrace: simplify ftrace hash lookup code

2019-09-08 Thread Changbin Du
Function ftrace_lookup_ip() will check empty hash table. So we don't need extra check outside. Signed-off-by: Changbin Du --- kernel/trace/ftrace.c | 15 --- kernel/trace/trace.h | 6 -- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/kernel/trace/ftrac

Re: [PATCH 0/8] kconfig/hacking: make 'kernel hacking' menu better structured

2019-09-07 Thread Changbin Du
< Exit >< Help >< Save >< Load >│ └───────┘ On Sun, Sep 08, 2019 at 09:27:52AM +0800, Changbin Du wrote: > This series is a trivial improvment for the layout of 'kernel hacking' > configuration menu. Now we

[PATCH 8/8] kconfig/hacking: Move DEBUG_BUGVERBOSE to 'printk and dmesg options'

2019-09-07 Thread Changbin Du
I think DEBUG_BUGVERBOSE is a dmesg option which gives more debug info to dmesg. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 740ada6744f6..bb82a02f6172 100644

[PATCH 6/8] kconfig/hacking: Move SCHED_STACK_END_CHECK after DEBUG_STACK_USAGE

2019-09-07 Thread Changbin Du
They are both memory debug options to debug kernel stack issues. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 99c6dbd64ce7..458d2a4435a4 100644 --- a

[PATCH 7/8] kconfig/hacking: Create a submenu for scheduler debugging options

2019-09-07 Thread Changbin Du
Create a submenu 'Scheduler Debugging' for scheduler debugging options. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 458d2a4435a4..740ada6744f6 100644 --- a/lib/Kconfig.debug

[PATCH 5/8] kconfig/hacking: Move Oops into 'Lockups and Hangs'

2019-09-07 Thread Changbin Du
They are similar options so place them together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 58 +++ 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ca2083350178..99c6dbd64ce7 100644

[PATCH 3/8] kconfig/hacking: Group kernel data structures debugging together

2019-09-07 Thread Changbin Du
Group these similar runtime data structures verification options together. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 96047140be93..3c9674483ec2

[PATCH 1/8] kconfig/hacking: Group sysrq/kgdb/ubsan into 'Generic Kernel Debugging Instruments'

2019-09-07 Thread Changbin Du
Group generic kernel debugging instruments sysrq/kgdb/ubsan together into a new submenu. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5960e2980a8a..868fa64a0901

[PATCH 2/8] kconfig/hacking: Create submenu for arch special debugging options

2019-09-07 Thread Changbin Du
The arch special options are a little long, so create a submenu for them. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 4 1 file changed, 4 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 868fa64a0901..96047140be93 100644 --- a/lib/Kconfig.debug +++ b/lib

[PATCH 4/8] kconfig/hacking: Move kernel testing and coverage options to same submenu

2019-09-07 Thread Changbin Du
Move error injection, coverage, testing options to a new submenu 'Kernel Testing and Coverage'. They are all for test purpose. Signed-off-by: Changbin Du --- lib/Kconfig.debug | 485 +++--- 1 file changed, 245 insertions(+), 240 deletions(-) di

[PATCH 0/8] kconfig/hacking: make 'kernel hacking' menu better structured

2019-09-07 Thread Changbin Du
This series is a trivial improvment for the layout of 'kernel hacking' configuration menu. Now we have many items in it which makes takes a little time to look up them since they are not well structured yet. Early discussion is here: https://lkml.org/lkml/2019/9/1/39 Changbin Du (8):

Re: [PATCH] genirq: move debugfs option to kernel hacking

2019-09-03 Thread Changbin Du
On Sun, Sep 01, 2019 at 11:49:36AM +0100, Marc Zyngier wrote: > On Sun, 1 Sep 2019 18:10:33 +0800 > Changbin Du wrote: > > > On Sun, Sep 01, 2019 at 08:23:02AM +0200, Thomas Gleixner wrote: > > > On Sun, 1 Sep 2019, Changbin Du wrote: > > > > > > &

Re: [PATCH] genirq: move debugfs option to kernel hacking

2019-09-01 Thread Changbin Du
On Sun, Sep 01, 2019 at 08:23:02AM +0200, Thomas Gleixner wrote: > On Sun, 1 Sep 2019, Changbin Du wrote: > > > Just like the other generic debug options, move the irq one to > > 'Kernel hacking' menu. > > Why? > > Kernel hacking is a inscrutable mess whe

[PATCH] genirq: move debugfs option to kernel hacking

2019-08-31 Thread Changbin Du
Just like the other generic debug options, move the irq one to 'Kernel hacking' menu. Signed-off-by: Changbin Du --- kernel/irq/Kconfig | 12 lib/Kconfig.debug | 11 +++ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/kernel/irq/Kconfig b/

<    1   2   3   4   5   6   7   >