[PATCH] igb: Workaround for igb i210 firmware issue.

2016-11-02 Thread Chris J Arges
J Arges <christopherar...@gmail.com> --- drivers/net/ethernet/intel/igb/e1000_phy.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index 5b54254..93ec2d0 100644 --- a/drivers/net/ethernet/int

[PATCH] igb: Workaround for igb i210 firmware issue.

2016-11-02 Thread Chris J Arges
J Arges --- drivers/net/ethernet/intel/igb/e1000_phy.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index 5b54254..93ec2d0 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net

[PATCH] livepatch: add load/unload hooks to objects

2016-08-26 Thread Chris J Arges
right after disabling functions. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 33 +++-- kernel/livepatch/core.c | 29 + 2 files changed, 56 insertions(+), 6 deletions(-) diff --git a/include

[PATCH] livepatch: add load/unload hooks to objects

2016-08-26 Thread Chris J Arges
right after disabling functions. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 33 +++-- kernel/livepatch/core.c | 29 + 2 files changed, 56 insertions(+), 6 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux

[RFC][PATCH] Load/Unload Hooks for Livepatch

2016-08-26 Thread Chris J Arges
hooks - handles properly when inserting/removing dependent modules - can handle load_hook for vmlinux as well The idea of these hooks are based off of the kpatch project. Chris J Arges (1): livepatch: add load/unload hooks to objects include/linux/livepatch.h | 33

[RFC][PATCH] Load/Unload Hooks for Livepatch

2016-08-26 Thread Chris J Arges
hooks - handles properly when inserting/removing dependent modules - can handle load_hook for vmlinux as well The idea of these hooks are based off of the kpatch project. Chris J Arges (1): livepatch: add load/unload hooks to objects include/linux/livepatch.h | 33

[PATCH] ecryptfs: fix spelling mistakes

2016-06-09 Thread Chris J Arges
Noticed some minor spelling errors when looking through the code. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- fs/ecryptfs/crypto.c | 8 fs/ecryptfs/file.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ec

[PATCH] ecryptfs: fix spelling mistakes

2016-06-09 Thread Chris J Arges
Noticed some minor spelling errors when looking through the code. Signed-off-by: Chris J Arges --- fs/ecryptfs/crypto.c | 8 fs/ecryptfs/file.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 0d8eb34..e5e29f8

[PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

2016-05-22 Thread Chris J Arges
for bogus values and filters them in order to prevent crashes. Signed-off-by: Chris J Arges <christopherar...@gmail.com> --- drivers/input/touchscreen/wacom_w8001.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touch

[PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

2016-05-22 Thread Chris J Arges
for bogus values and filters them in order to prevent crashes. Signed-off-by: Chris J Arges --- drivers/input/touchscreen/wacom_w8001.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c index bab3c6a

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-28 Thread Chris J Arges
On Wed, Apr 27, 2016 at 10:08:08PM +0200, Jiri Kosina wrote: > On Tue, 26 Apr 2016, Chris J Arges wrote: > > [ ... snip ... ] > > > + + Kretprobes using the ftrace framework conflict with the patched > > > > + + Kretprobes using the ftrace framework conflic

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-28 Thread Chris J Arges
On Wed, Apr 27, 2016 at 10:08:08PM +0200, Jiri Kosina wrote: > On Tue, 26 Apr 2016, Chris J Arges wrote: > > [ ... snip ... ] > > > + + Kretprobes using the ftrace framework conflict with the patched > > > > + + Kretprobes using the ftrace framework conflic

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-26 Thread Chris J Arges
On Mon, Apr 25, 2016 at 05:14:35PM +0200, Petr Mladek wrote: > LivePatch framework deserves some documentation, definitely. > This is an attempt to provide some basic info. I hope that > it will be useful for both LivePatch producers and also > potential developers of the framework itself. > >

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-26 Thread Chris J Arges
On Mon, Apr 25, 2016 at 05:14:35PM +0200, Petr Mladek wrote: > LivePatch framework deserves some documentation, definitely. > This is an attempt to provide some basic info. I hope that > it will be useful for both LivePatch producers and also > potential developers of the framework itself. > >

Re: [RFC PATCH v1.9 08/14] livepatch: separate enabled and patched states

2016-04-12 Thread Chris J Arges
On Tue, Apr 12, 2016 at 12:16:00PM -0500, Josh Poimboeuf wrote: > On Tue, Apr 12, 2016 at 09:44:43AM -0500, Chris J Arges wrote: > > On Fri, Mar 25, 2016 at 02:34:55PM -0500, Josh Poimboeuf wrote: > > > Once we have a consistency model, patches and their objects will be > >

Re: [RFC PATCH v1.9 08/14] livepatch: separate enabled and patched states

2016-04-12 Thread Chris J Arges
On Tue, Apr 12, 2016 at 12:16:00PM -0500, Josh Poimboeuf wrote: > On Tue, Apr 12, 2016 at 09:44:43AM -0500, Chris J Arges wrote: > > On Fri, Mar 25, 2016 at 02:34:55PM -0500, Josh Poimboeuf wrote: > > > Once we have a consistency model, patches and their objects will be > >

Re: [RFC PATCH v1.9 08/14] livepatch: separate enabled and patched states

2016-04-12 Thread Chris J Arges
On Fri, Mar 25, 2016 at 02:34:55PM -0500, Josh Poimboeuf wrote: > Once we have a consistency model, patches and their objects will be > enabled and disabled at different times. For example, when a patch is > disabled, its loaded objects' funcs can remain registered with ftrace > indefinitely

Re: [RFC PATCH v1.9 08/14] livepatch: separate enabled and patched states

2016-04-12 Thread Chris J Arges
On Fri, Mar 25, 2016 at 02:34:55PM -0500, Josh Poimboeuf wrote: > Once we have a consistency model, patches and their objects will be > enabled and disabled at different times. For example, when a patch is > disabled, its loaded objects' funcs can remain registered with ftrace > indefinitely

Re: Bug with paravirt ops and livepatches

2016-04-06 Thread Chris J Arges
On Wed, Apr 06, 2016 at 02:09:01PM +0200, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Chris J Arges wrote: > > > I think this approach needs more thought and my code has bug(s). > > And indeed there is... > > long (*__kvm_arch_vm_ioctl)(struct file *filp, unsigned long

Re: Bug with paravirt ops and livepatches

2016-04-06 Thread Chris J Arges
On Wed, Apr 06, 2016 at 02:09:01PM +0200, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Chris J Arges wrote: > > > I think this approach needs more thought and my code has bug(s). > > And indeed there is... > > long (*__kvm_arch_vm_ioctl)(struct file *filp, unsigned long

Re: Bug with paravirt ops and livepatches

2016-04-06 Thread Chris J Arges
On Wed, Apr 06, 2016 at 11:09:04AM +0200, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Chris J Arges wrote: > > > On Tue, Apr 05, 2016 at 03:07:13PM +0200, Miroslav Benes wrote: > > > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > > > > So I th

Re: Bug with paravirt ops and livepatches

2016-04-06 Thread Chris J Arges
On Wed, Apr 06, 2016 at 11:09:04AM +0200, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Chris J Arges wrote: > > > On Tue, Apr 05, 2016 at 03:07:13PM +0200, Miroslav Benes wrote: > > > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > > > > So I th

Re: Bug with paravirt ops and livepatches

2016-04-05 Thread Chris J Arges
On Tue, Apr 05, 2016 at 03:07:13PM +0200, Miroslav Benes wrote: > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > So I think this doesn't fix the problem. Dynamic relocations are > > applied to the "patch module", whereas the above code deals with the > > initialization order of the "patched

Re: Bug with paravirt ops and livepatches

2016-04-05 Thread Chris J Arges
On Tue, Apr 05, 2016 at 03:07:13PM +0200, Miroslav Benes wrote: > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > So I think this doesn't fix the problem. Dynamic relocations are > > applied to the "patch module", whereas the above code deals with the > > initialization order of the "patched

Re: Bug with paravirt ops and livepatches

2016-04-01 Thread Chris J Arges
On Fri, Apr 01, 2016 at 05:46:52PM +0200, Miroslav Benes wrote: > On Fri, 1 Apr 2016, Jiri Kosina wrote: > > > On Tue, 29 Mar 2016, Jiri Kosina wrote: > > > > > Agreed; I think we should be safe applying all the alternatives (with > > > paravirt being really just a special case of those) to the

Re: Bug with paravirt ops and livepatches

2016-04-01 Thread Chris J Arges
On Fri, Apr 01, 2016 at 05:46:52PM +0200, Miroslav Benes wrote: > On Fri, 1 Apr 2016, Jiri Kosina wrote: > > > On Tue, 29 Mar 2016, Jiri Kosina wrote: > > > > > Agreed; I think we should be safe applying all the alternatives (with > > > paravirt being really just a special case of those) to the

Re: Bug with paravirt ops and livepatches

2016-04-01 Thread Chris J Arges
On Fri, Apr 01, 2016 at 05:46:52PM +0200, Miroslav Benes wrote: > On Fri, 1 Apr 2016, Jiri Kosina wrote: > > > On Tue, 29 Mar 2016, Jiri Kosina wrote: > > > > > Agreed; I think we should be safe applying all the alternatives (with > > > paravirt being really just a special case of those) to the

Re: Bug with paravirt ops and livepatches

2016-04-01 Thread Chris J Arges
On Fri, Apr 01, 2016 at 05:46:52PM +0200, Miroslav Benes wrote: > On Fri, 1 Apr 2016, Jiri Kosina wrote: > > > On Tue, 29 Mar 2016, Jiri Kosina wrote: > > > > > Agreed; I think we should be safe applying all the alternatives (with > > > paravirt being really just a special case of those) to the

Bug with paravirt ops and livepatches

2016-03-29 Thread Chris J Arges
Paravirtualized ops and livepatching currently don't mix very well and can cause undefined behavor such as oops, invalid opcodes or corrupted stacks. The original discussion of this issue can be found here [1]. I've written an example livepatch module that reproduces the issue [2]. In order to

Bug with paravirt ops and livepatches

2016-03-29 Thread Chris J Arges
Paravirtualized ops and livepatching currently don't mix very well and can cause undefined behavor such as oops, invalid opcodes or corrupted stacks. The original discussion of this issue can be found here [1]. I've written an example livepatch module that reproduces the issue [2]. In order to

Re: [PATCH] livepatch: Fix the error message about unresolvable ambiguity

2016-03-09 Thread Chris J Arges
, objname); > > + pr_err("unresolvable ambiguity on symbol '%s' in object '%s'\n", > > While you're at it, can you improve the grammar: s/on/for/ ? > > "unresolvable ambiguity *for* symbol..." > > Either way, > > Acked-by: Josh Poimboeuf <jpoim...@redhat.com> > > -- > Josh > I agree that the 'matches' error message doesn't added anything helpful. With the word change above: Acked-by: Chris J Arges <chris.j.ar...@canonical.com> --chris

Re: [PATCH] livepatch: Fix the error message about unresolvable ambiguity

2016-03-09 Thread Chris J Arges
+ pr_err("unresolvable ambiguity on symbol '%s' in object '%s'\n", > > While you're at it, can you improve the grammar: s/on/for/ ? > > "unresolvable ambiguity *for* symbol..." > > Either way, > > Acked-by: Josh Poimboeuf > > -- > Josh > I agree that the 'matches' error message doesn't added anything helpful. With the word change above: Acked-by: Chris J Arges --chris

[tip:x86/debug] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-02-24 Thread tip-bot for Chris J Arges
Commit-ID: 3f62de5f6f369b67b7ac709e3c942c9130d2c51a Gitweb: http://git.kernel.org/tip/3f62de5f6f369b67b7ac709e3c942c9130d2c51a Author: Chris J Arges <chris.j.ar...@canonical.com> AuthorDate: Fri, 22 Jan 2016 15:44:38 -0600 Committer: Ingo Molnar <mi...@kernel.org> CommitDate:

[tip:x86/debug] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-02-24 Thread tip-bot for Chris J Arges
Commit-ID: 3f62de5f6f369b67b7ac709e3c942c9130d2c51a Gitweb: http://git.kernel.org/tip/3f62de5f6f369b67b7ac709e3c942c9130d2c51a Author: Chris J Arges AuthorDate: Fri, 22 Jan 2016 15:44:38 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:44 +0100 x86/kvm: Add output

[tip:x86/debug] x86/uaccess: Add stack frame output operand in get_user() inline asm

2016-02-24 Thread tip-bot for Chris J Arges
Commit-ID: f05058c4d652b619adfda6c78d8f5b341169c264 Gitweb: http://git.kernel.org/tip/f05058c4d652b619adfda6c78d8f5b341169c264 Author: Chris J Arges <chris.j.ar...@canonical.com> AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar <mi...@kernel.org> CommitDate:

[tip:x86/debug] x86/uaccess: Add stack frame output operand in get_user() inline asm

2016-02-24 Thread tip-bot for Chris J Arges
Commit-ID: f05058c4d652b619adfda6c78d8f5b341169c264 Gitweb: http://git.kernel.org/tip/f05058c4d652b619adfda6c78d8f5b341169c264 Author: Chris J Arges AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:43 +0100 x86/uaccess: Add stack

[tip:x86/debug] x86/uaccess: Add stack frame output operand in get_user() inline asm

2016-02-23 Thread tip-bot for Chris J Arges
Commit-ID: 5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Gitweb: http://git.kernel.org/tip/5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Author: Chris J Arges <chris.j.ar...@canonical.com> AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar <mi...@kernel.org> CommitDate:

[tip:x86/debug] x86/uaccess: Add stack frame output operand in get_user() inline asm

2016-02-23 Thread tip-bot for Chris J Arges
Commit-ID: 5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Gitweb: http://git.kernel.org/tip/5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Author: Chris J Arges AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:03:58 +0100 x86/uaccess: Add stack

[tip:x86/debug] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-02-23 Thread tip-bot for Chris J Arges
Commit-ID: 3aff5415db7e5a5e50f9b05ce1b0b92a4a55e169 Gitweb: http://git.kernel.org/tip/3aff5415db7e5a5e50f9b05ce1b0b92a4a55e169 Author: Chris J Arges <chris.j.ar...@canonical.com> AuthorDate: Fri, 22 Jan 2016 15:44:38 -0600 Committer: Ingo Molnar <mi...@kernel.org> CommitDate:

[tip:x86/debug] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-02-23 Thread tip-bot for Chris J Arges
Commit-ID: 3aff5415db7e5a5e50f9b05ce1b0b92a4a55e169 Gitweb: http://git.kernel.org/tip/3aff5415db7e5a5e50f9b05ce1b0b92a4a55e169 Author: Chris J Arges AuthorDate: Fri, 22 Jan 2016 15:44:38 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:04:01 +0100 x86/kvm: Add output

[PATCH 1/2] tools/stacktool: Add __reiserfs_panic to global_noreturns list

2016-01-22 Thread Chris J Arges
a noreturn attribute. Add this to the global list because this particular attribute cannot be determined from reading the ELF object. Signed-off-by: Chris J Arges --- tools/stacktool/builtin-check.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/stacktool/builtin-check.c b/tools

[PATCH 2/2] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-01-22 Thread Chris J Arges
assmebly statement. Signed-off-by: Chris J Arges --- arch/x86/kvm/vmx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index e2951b6..e153522 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -8356,6 +8356,7 @@ static void

[PATCH 0/2] A few stacktool warning fixes.

2016-01-22 Thread Chris J Arges
These patches fix a few warnings I saw testing stacktool v16. I've done light testing on these by booting it on a machine and running kvm-unit-tests on it. Chris J Arges (2): tools/stacktool: Add __reiserfs_panic to global_noreturns list x86/kvm: Add output operand in vmx_handle_external_intr

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-01-22 Thread Chris J Arges
On Fri, Jan 22, 2016 at 01:14:47PM -0600, Josh Poimboeuf wrote: > On Fri, Jan 22, 2016 at 11:43:48AM -0600, Chris J Arges wrote: > > On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > > > This is v16 of the compile-time stack metadata validation patch set, > &g

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-01-22 Thread Chris J Arges
ay > > v14: > - make tools/include/linux/list.h self-sufficient > - create FRAME_OFFSET to allow 32-bit code to be able to access function > arguments on the stack > - add FRAME_OFFSET usage in crypto patch 14/24: "Create stack frames in > aesni-intel_asm.S" > - r

[PATCH 0/2] A few stacktool warning fixes.

2016-01-22 Thread Chris J Arges
These patches fix a few warnings I saw testing stacktool v16. I've done light testing on these by booting it on a machine and running kvm-unit-tests on it. Chris J Arges (2): tools/stacktool: Add __reiserfs_panic to global_noreturns list x86/kvm: Add output operand in vmx_handle_external_intr

[PATCH 2/2] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-01-22 Thread Chris J Arges
assmebly statement. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- arch/x86/kvm/vmx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index e2951b6..e153522 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm

[PATCH 1/2] tools/stacktool: Add __reiserfs_panic to global_noreturns list

2016-01-22 Thread Chris J Arges
a noreturn attribute. Add this to the global list because this particular attribute cannot be determined from reading the ELF object. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- tools/stacktool/builtin-check.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/sta

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-01-22 Thread Chris J Arges
On Fri, Jan 22, 2016 at 01:14:47PM -0600, Josh Poimboeuf wrote: > On Fri, Jan 22, 2016 at 11:43:48AM -0600, Chris J Arges wrote: > > On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > > > This is v16 of the compile-time stack metadata validation patch set, > &g

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-01-22 Thread Chris J Arges
ay > > v14: > - make tools/include/linux/list.h self-sufficient > - create FRAME_OFFSET to allow 32-bit code to be able to access function > arguments on the stack > - add FRAME_OFFSET usage in crypto patch 14/24: "Create stack frames in > aesni-intel_asm.S" > - r

[PATCH 1/3 v9] livepatch: add old_sympos as disambiguator field to klp_func

2015-12-01 Thread Chris J Arges
disambiguation for relocations is added in the next patch in this series. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) diff --git

[PATCH 3/3 v9] livepatch: function,sympos scheme in livepatch sysfs directory

2015-12-01 Thread Chris J Arges
be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 0/3 v9] livepatch: disambiguate symbols with the same name

2015-12-01 Thread Chris J Arges
- amend/remove commit messages/comments to be more precise Chris J Arges (3): livepatch: add old_sympos as disambiguator field to klp_func livepatch: add sympos as disambiguator field to klp_reloc livepatch: function,sympos scheme in livepatch sysfs directory Documentation/ABI/testi

[PATCH 2/3 v9] livepatch: add sympos as disambiguator field to klp_reloc

2015-12-01 Thread Chris J Arges
ned-off-by: Chris J Arges --- include/linux/livepatch.h | 5 ++- kernel/livepatch/core.c | 84 +++ 2 files changed, 21 insertions(+), 68 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index b60e8ab..a882865 100

[PATCH 1/3 v9] livepatch: add old_sympos as disambiguator field to klp_func

2015-12-01 Thread Chris J Arges
disambiguation for relocations is added in the next patch in this series. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(

[PATCH 3/3 v9] livepatch: function,sympos scheme in livepatch sysfs directory

2015-12-01 Thread Chris J Arges
tching multiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files

[PATCH 0/3 v9] livepatch: disambiguate symbols with the same name

2015-12-01 Thread Chris J Arges
- amend/remove commit messages/comments to be more precise Chris J Arges (3): livepatch: add old_sympos as disambiguator field to klp_func livepatch: add sympos as disambiguator field to klp_reloc livepatch: function,sympos scheme in livepatch sysfs directory Documentation/ABI/testi

[PATCH 2/3 v9] livepatch: add sympos as disambiguator field to klp_reloc

2015-12-01 Thread Chris J Arges
ned-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 5 ++- kernel/livepatch/core.c | 84 +++ 2 files changed, 21 insertions(+), 68 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatc

Re: [PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-30 Thread Chris J Arges
On Mon, Nov 23, 2015 at 10:52:23AM +0100, Miroslav Benes wrote: > On Fri, 20 Nov 2015, Chris J Arges wrote: > > [...] > > > @@ -272,6 +233,7 @@ static int klp_write_object_relocations(struct module > > *pmod, > > struct klp_objec

Re: [PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-30 Thread Chris J Arges
On Mon, Nov 23, 2015 at 10:52:23AM +0100, Miroslav Benes wrote: > On Fri, 20 Nov 2015, Chris J Arges wrote: > > [...] > > > @@ -272,6 +233,7 @@ static int klp_write_object_relocations(struct module > > *pmod, > > struct klp_objec

[PATCH 0/3 v8] livepatch: disambiguate symbols with the same name

2015-11-20 Thread Chris J Arges
/comments to be more precise Chris J Arges (3): livepatch: add old_sympos as disambiguator field to klp_func livepatch: add sympos as disambiguator field to klp_reloc livepatch: function,sympos scheme in livepatch sysfs directory Documentation/ABI/testing/sysfs-kernel-livepatch | 6

[PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-20 Thread Chris J Arges
ned-off-by: Chris J Arges --- include/linux/livepatch.h | 5 ++- kernel/livepatch/core.c | 77 +++ 2 files changed, 20 insertions(+), 62 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index b60e8ab..a882865 100

[PATCH 1/3 v8] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-20 Thread Chris J Arges
disambiguation for relocations is added in the next patch in this series. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) diff --git

[PATCH 3/3 v8] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-20 Thread Chris J Arges
be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 0/3 v8] livepatch: disambiguate symbols with the same name

2015-11-20 Thread Chris J Arges
/comments to be more precise Chris J Arges (3): livepatch: add old_sympos as disambiguator field to klp_func livepatch: add sympos as disambiguator field to klp_reloc livepatch: function,sympos scheme in livepatch sysfs directory Documentation/ABI/testing/sysfs-kernel-livepatch | 6

[PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-20 Thread Chris J Arges
ned-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 5 ++- kernel/livepatch/core.c | 77 +++ 2 files changed, 20 insertions(+), 62 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatc

[PATCH 1/3 v8] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-20 Thread Chris J Arges
disambiguation for relocations is added in the next patch in this series. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(

[PATCH 3/3 v8] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-20 Thread Chris J Arges
tching multiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files

Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-18 Thread Chris J Arges
On 11/18/2015 10:37 AM, Petr Mladek wrote: > On Mon 2015-11-16 11:03:06, Chris J Arges wrote: >> In cases of duplicate symbols, sympos will be used to disambiguate instead >> of val. By default sympos will be 0, and patching will only succeed if >> the symbol is unique. Specif

Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-18 Thread Chris J Arges
On 11/18/2015 10:37 AM, Petr Mladek wrote: > On Mon 2015-11-16 11:03:06, Chris J Arges wrote: >> In cases of duplicate symbols, sympos will be used to disambiguate instead >> of val. By default sympos will be 0, and patching will only succeed if >> the symbol is unique. Specif

Re: [PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-17 Thread Chris J Arges
On 11/16/2015 03:59 PM, Jiri Kosina wrote: > On Mon, 16 Nov 2015, Chris J Arges wrote: > >> In cases of duplicate symbols, old_sympos will be used to disambiguate >> instead of old_addr. By default old_sympos will be 0, and patching will >> only succeed if the symb

Re: [PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-17 Thread Chris J Arges
On 11/16/2015 03:59 PM, Jiri Kosina wrote: > On Mon, 16 Nov 2015, Chris J Arges wrote: > >> In cases of duplicate symbols, old_sympos will be used to disambiguate >> instead of old_addr. By default old_sympos will be 0, and patching will >> only succeed if the symb

[PATCH 3/3 v7] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-16 Thread Chris J Arges
be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-16 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges --- include/li

[PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-16 Thread Chris J Arges
patch in this series. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux

[PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-16 Thread Chris J Arges
patch in this series. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) diff --git a/include

[PATCH 3/3 v7] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-16 Thread Chris J Arges
tching multiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files

[PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-16 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges <chris.j.ar...@canonic

[PATCH 3/3 v6] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-13 Thread Chris J Arges
be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 2/3 v6] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-13 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges --- include/li

[PATCH 1/3 v6] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-13 Thread Chris J Arges
for patching if it is valid. In addition, make old_addr an internal structure field not to be specified by the user. Finally, remove klp_find_verify_func_addr as it can be replaced by klp_find_object_symbol directly. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19

[PATCH 1/3 v6] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-13 Thread Chris J Arges
for patching if it is valid. In addition, make old_addr an internal structure field not to be specified by the user. Finally, remove klp_find_verify_func_addr as it can be replaced by klp_find_object_symbol directly. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include

[PATCH 3/3 v6] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-13 Thread Chris J Arges
tching multiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files

[PATCH 2/3 v6] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-13 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges <chris.j.ar...@canonic

[PATCH 3/4 v5] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-12 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges --- include/li

[PATCH 4/4 v5] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-12 Thread Chris J Arges
be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols

2015-11-12 Thread Chris J Arges
the search for the static symbols within the livepatch module. It makes it easier to understand the meaning of the external flag and klp_find_external_symbol() function. Signed-off-by: Petr Mladek Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 3 ++- kernel/livepatch/core.c | 12

[PATCH 1/4 v5] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-12 Thread Chris J Arges
for patching if it is valid. In addition, make old_addr an internal structure field not to be specified by the user. Finally, remove klp_find_verify_func_addr as it can be replaced by klp_find_object_symbol directly. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 20

[PATCH 3/4 v5] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-12 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges <chris.j.ar...@canonic

[PATCH 4/4 v5] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-12 Thread Chris J Arges
tching multiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files

[PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols

2015-11-12 Thread Chris J Arges
files. This patch removes the search for the static symbols within the livepatch module. It makes it easier to understand the meaning of the external flag and klp_find_external_symbol() function. Signed-off-by: Petr Mladek <pmla...@suse.com> Signed-off-by: Chris J Arges <chris.j.ar...@canonical.co

[PATCH 1/4 v5] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-12 Thread Chris J Arges
for patching if it is valid. In addition, make old_addr an internal structure field not to be specified by the user. Finally, remove klp_find_verify_func_addr as it can be replaced by klp_find_object_symbol directly. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
On 11/11/2015 10:29 AM, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default old_sympos will be 0, and patching will only succeed if Minor typo. old_sympos, should just be sympos. --chris > the symbol is unique. S

[PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
-by: Chris J Arges --- include/linux/livepatch.h | 5 ++-- kernel/livepatch/core.c | 74 ++- 2 files changed, 18 insertions(+), 61 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index df7b752..fb968a2 100644

[PATCH 3/3 v4] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-11 Thread Chris J Arges
here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH 1/3 v4] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-11 Thread Chris J Arges
. Finally, old_addr is now an internal structure element and not to be specified by the user. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 20 ++ kernel/livepatch/core.c | 53 +++ 2 files changed, 37 insertions(+), 36

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
On 11/11/2015 10:29 AM, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default old_sympos will be 0, and patching will only succeed if Minor typo. old_sympos, should just be sympos. --chris > the symbol is unique. S

[PATCH 1/3 v4] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-11 Thread Chris J Arges
. Finally, old_addr is now an internal structure element and not to be specified by the user. Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 20 ++ kernel/livepatch/core.c | 53 +++ 2 files c

[PATCH 3/3 v4] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-11 Thread Chris J Arges
ltiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges <chris.j.ar...@canonical.com> --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 1

[PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
-by: Chris J Arges <chris.j.ar...@canonical.com> --- include/linux/livepatch.h | 5 ++-- kernel/livepatch/core.c | 74 ++- 2 files changed, 18 insertions(+), 61 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index d

  1   2   3   >