[PATCH] igb: Workaround for igb i210 firmware issue.

2016-11-02 Thread Chris J Arges
J Arges --- drivers/net/ethernet/intel/igb/e1000_phy.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index 5b54254..93ec2d0 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net

[PATCH] livepatch: add load/unload hooks to objects

2016-08-26 Thread Chris J Arges
right after disabling functions. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 33 +++-- kernel/livepatch/core.c | 29 + 2 files changed, 56 insertions(+), 6 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux

[RFC][PATCH] Load/Unload Hooks for Livepatch

2016-08-26 Thread Chris J Arges
from hooks - handles properly when inserting/removing dependent modules - can handle load_hook for vmlinux as well The idea of these hooks are based off of the kpatch project. Chris J Arges (1): livepatch: add load/unload hooks to objects include/linux/livepatch.h

[PATCH] ecryptfs: fix spelling mistakes

2016-06-09 Thread Chris J Arges
Noticed some minor spelling errors when looking through the code. Signed-off-by: Chris J Arges --- fs/ecryptfs/crypto.c | 8 fs/ecryptfs/file.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 0d8eb34..e5e29f8

[PATCH] Input: wacom_w8001 - Ignore bogus idx values in interrupt

2016-05-22 Thread Chris J Arges
s for bogus values and filters them in order to prevent crashes. Signed-off-by: Chris J Arges --- drivers/input/touchscreen/wacom_w8001.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/input/touchscreen/wacom_w8001.c b/drivers/input/touchscreen/wacom_w8001.c index ba

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-28 Thread Chris J Arges
On Wed, Apr 27, 2016 at 10:08:08PM +0200, Jiri Kosina wrote: > On Tue, 26 Apr 2016, Chris J Arges wrote: > > [ ... snip ... ] > > > + + Kretprobes using the ftrace framework conflict with the patched > > > > + + Kretprobes using the ftrace framework conflic

Re: [PATCH v2] livepatch: Add some basic LivePatch documentation

2016-04-26 Thread Chris J Arges
On Mon, Apr 25, 2016 at 05:14:35PM +0200, Petr Mladek wrote: > LivePatch framework deserves some documentation, definitely. > This is an attempt to provide some basic info. I hope that > it will be useful for both LivePatch producers and also > potential developers of the framework itself. > > Sig

Re: [RFC PATCH v1.9 08/14] livepatch: separate enabled and patched states

2016-04-12 Thread Chris J Arges
On Tue, Apr 12, 2016 at 12:16:00PM -0500, Josh Poimboeuf wrote: > On Tue, Apr 12, 2016 at 09:44:43AM -0500, Chris J Arges wrote: > > On Fri, Mar 25, 2016 at 02:34:55PM -0500, Josh Poimboeuf wrote: > > > Once we have a consistency model, patches and their objects will be > >

Re: [RFC PATCH v1.9 08/14] livepatch: separate enabled and patched states

2016-04-12 Thread Chris J Arges
On Fri, Mar 25, 2016 at 02:34:55PM -0500, Josh Poimboeuf wrote: > Once we have a consistency model, patches and their objects will be > enabled and disabled at different times. For example, when a patch is > disabled, its loaded objects' funcs can remain registered with ftrace > indefinitely until

Re: Bug with paravirt ops and livepatches

2016-04-06 Thread Chris J Arges
On Wed, Apr 06, 2016 at 02:09:01PM +0200, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Chris J Arges wrote: > > > I think this approach needs more thought and my code has bug(s). > > And indeed there is... > > long (*__kvm_arch_vm_ioctl)(struct file *filp, unsigned long

Re: Bug with paravirt ops and livepatches

2016-04-06 Thread Chris J Arges
On Wed, Apr 06, 2016 at 11:09:04AM +0200, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Chris J Arges wrote: > > > On Tue, Apr 05, 2016 at 03:07:13PM +0200, Miroslav Benes wrote: > > > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > > > > > So I th

Re: Bug with paravirt ops and livepatches

2016-04-05 Thread Chris J Arges
On Tue, Apr 05, 2016 at 03:07:13PM +0200, Miroslav Benes wrote: > On Mon, 4 Apr 2016, Josh Poimboeuf wrote: > > > So I think this doesn't fix the problem. Dynamic relocations are > > applied to the "patch module", whereas the above code deals with the > > initialization order of the "patched modu

Re: Bug with paravirt ops and livepatches

2016-04-01 Thread Chris J Arges
On Fri, Apr 01, 2016 at 05:46:52PM +0200, Miroslav Benes wrote: > On Fri, 1 Apr 2016, Jiri Kosina wrote: > > > On Tue, 29 Mar 2016, Jiri Kosina wrote: > > > > > Agreed; I think we should be safe applying all the alternatives (with > > > paravirt being really just a special case of those) to the

Re: Bug with paravirt ops and livepatches

2016-04-01 Thread Chris J Arges
On Fri, Apr 01, 2016 at 05:46:52PM +0200, Miroslav Benes wrote: > On Fri, 1 Apr 2016, Jiri Kosina wrote: > > > On Tue, 29 Mar 2016, Jiri Kosina wrote: > > > > > Agreed; I think we should be safe applying all the alternatives (with > > > paravirt being really just a special case of those) to the

Bug with paravirt ops and livepatches

2016-03-29 Thread Chris J Arges
Paravirtualized ops and livepatching currently don't mix very well and can cause undefined behavor such as oops, invalid opcodes or corrupted stacks. The original discussion of this issue can be found here [1]. I've written an example livepatch module that reproduces the issue [2]. In order to tri

Re: [PATCH] livepatch: Fix the error message about unresolvable ambiguity

2016-03-09 Thread Chris J Arges
s.count, name, objname); > > + pr_err("unresolvable ambiguity on symbol '%s' in object '%s'\n", > > While you're at it, can you improve the grammar: s/on/for/ ? > > "unresolvable ambiguity *for* symbol..." > > Either way, > > Acked-by: Josh Poimboeuf > > -- > Josh > I agree that the 'matches' error message doesn't added anything helpful. With the word change above: Acked-by: Chris J Arges --chris

[tip:x86/debug] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-02-24 Thread tip-bot for Chris J Arges
Commit-ID: 3f62de5f6f369b67b7ac709e3c942c9130d2c51a Gitweb: http://git.kernel.org/tip/3f62de5f6f369b67b7ac709e3c942c9130d2c51a Author: Chris J Arges AuthorDate: Fri, 22 Jan 2016 15:44:38 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:44 +0100 x86/kvm: Add output

[tip:x86/debug] x86/uaccess: Add stack frame output operand in get_user() inline asm

2016-02-24 Thread tip-bot for Chris J Arges
Commit-ID: f05058c4d652b619adfda6c78d8f5b341169c264 Gitweb: http://git.kernel.org/tip/f05058c4d652b619adfda6c78d8f5b341169c264 Author: Chris J Arges AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar CommitDate: Wed, 24 Feb 2016 08:35:43 +0100 x86/uaccess: Add stack

[tip:x86/debug] x86/uaccess: Add stack frame output operand in get_user() inline asm

2016-02-23 Thread tip-bot for Chris J Arges
Commit-ID: 5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Gitweb: http://git.kernel.org/tip/5e947b38f8ead33bf6aaecc2af20a0a3a988fd02 Author: Chris J Arges AuthorDate: Thu, 21 Jan 2016 16:49:25 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:03:58 +0100 x86/uaccess: Add stack

[tip:x86/debug] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-02-23 Thread tip-bot for Chris J Arges
Commit-ID: 3aff5415db7e5a5e50f9b05ce1b0b92a4a55e169 Gitweb: http://git.kernel.org/tip/3aff5415db7e5a5e50f9b05ce1b0b92a4a55e169 Author: Chris J Arges AuthorDate: Fri, 22 Jan 2016 15:44:38 -0600 Committer: Ingo Molnar CommitDate: Tue, 23 Feb 2016 09:04:01 +0100 x86/kvm: Add output

[PATCH 1/2] tools/stacktool: Add __reiserfs_panic to global_noreturns list

2016-01-22 Thread Chris J Arges
hich has a noreturn attribute. Add this to the global list because this particular attribute cannot be determined from reading the ELF object. Signed-off-by: Chris J Arges --- tools/stacktool/builtin-check.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/stacktool/builtin-check

[PATCH 2/2] x86/kvm: Add output operand in vmx_handle_external_intr inline asm

2016-01-22 Thread Chris J Arges
assmebly statement. Signed-off-by: Chris J Arges --- arch/x86/kvm/vmx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index e2951b6..e153522 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -8356,6 +8356,7 @@ static void

[PATCH 0/2] A few stacktool warning fixes.

2016-01-22 Thread Chris J Arges
These patches fix a few warnings I saw testing stacktool v16. I've done light testing on these by booting it on a machine and running kvm-unit-tests on it. Chris J Arges (2): tools/stacktool: Add __reiserfs_panic to global_noreturns list x86/kvm: Add output operand in vmx_handle_external

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-01-22 Thread Chris J Arges
On Fri, Jan 22, 2016 at 01:14:47PM -0600, Josh Poimboeuf wrote: > On Fri, Jan 22, 2016 at 11:43:48AM -0600, Chris J Arges wrote: > > On Thu, Jan 21, 2016 at 04:49:04PM -0600, Josh Poimboeuf wrote: > > > This is v16 of the compile-time stack metadata validation patch set, > &g

Re: [PATCH 00/33] Compile-time stack metadata validation

2016-01-22 Thread Chris J Arges
ich was reported by 0day > > v14: > - make tools/include/linux/list.h self-sufficient > - create FRAME_OFFSET to allow 32-bit code to be able to access function > arguments on the stack > - add FRAME_OFFSET usage in crypto patch 14/24: "Create stack frames in > aesni-i

[PATCH 1/3 v9] livepatch: add old_sympos as disambiguator field to klp_func

2015-12-01 Thread Chris J Arges
l position disambiguation for relocations is added in the next patch in this series. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) di

[PATCH 3/3 v9] livepatch: function,sympos scheme in livepatch sysfs directory

2015-12-01 Thread Chris J Arges
found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a

[PATCH 0/3 v9] livepatch: disambiguate symbols with the same name

2015-12-01 Thread Chris J Arges
- remove klp_find_verify_func_addr - amend/remove commit messages/comments to be more precise Chris J Arges (3): livepatch: add old_sympos as disambiguator field to klp_func livepatch: add sympos as disambiguator field to klp_reloc livepatch: function,sympos scheme in livepatch sysfs

[PATCH 2/3 v9] livepatch: add sympos as disambiguator field to klp_reloc

2015-12-01 Thread Chris J Arges
ned-off-by: Chris J Arges --- include/linux/livepatch.h | 5 ++- kernel/livepatch/core.c | 84 +++ 2 files changed, 21 insertions(+), 68 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index b60e8ab..a882865 100644 --

Re: [PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-30 Thread Chris J Arges
On Mon, Nov 23, 2015 at 10:52:23AM +0100, Miroslav Benes wrote: > On Fri, 20 Nov 2015, Chris J Arges wrote: > > [...] > > > @@ -272,6 +233,7 @@ static int klp_write_object_relocations(struct module > > *pmod, > > struct klp_objec

[PATCH 0/3 v8] livepatch: disambiguate symbols with the same name

2015-11-20 Thread Chris J Arges
nd/remove commit messages/comments to be more precise Chris J Arges (3): livepatch: add old_sympos as disambiguator field to klp_func livepatch: add sympos as disambiguator field to klp_reloc livepatch: function,sympos scheme in livepatch sysfs directory Documentation/ABI/testing/sys

[PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-20 Thread Chris J Arges
ned-off-by: Chris J Arges --- include/linux/livepatch.h | 5 ++- kernel/livepatch/core.c | 77 +++ 2 files changed, 20 insertions(+), 62 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index b60e8ab..a882865 100644 --

[PATCH 1/3 v8] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-20 Thread Chris J Arges
l position disambiguation for relocations is added in the next patch in this series. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) di

[PATCH 3/3 v8] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-20 Thread Chris J Arges
found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-18 Thread Chris J Arges
On 11/18/2015 10:37 AM, Petr Mladek wrote: > On Mon 2015-11-16 11:03:06, Chris J Arges wrote: >> In cases of duplicate symbols, sympos will be used to disambiguate instead >> of val. By default sympos will be 0, and patching will only succeed if >> the symbol is unique. Specif

Re: [PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-17 Thread Chris J Arges
On 11/16/2015 03:59 PM, Jiri Kosina wrote: > On Mon, 16 Nov 2015, Chris J Arges wrote: > >> In cases of duplicate symbols, old_sympos will be used to disambiguate >> instead of old_addr. By default old_sympos will be 0, and patching will >> only succeed if the symbol

[PATCH 3/3 v7] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-16 Thread Chris J Arges
found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a

[PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-16 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges --- include/li

[PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-16 Thread Chris J Arges
patch in this series. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19 +++-- kernel/livepatch/core.c | 72 --- 2 files changed, 41 insertions(+), 50 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux

[PATCH 3/3 v6] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-13 Thread Chris J Arges
found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a

[PATCH 2/3 v6] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-13 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges --- include/li

[PATCH 1/3 v6] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-13 Thread Chris J Arges
for patching if it is valid. In addition, make old_addr an internal structure field not to be specified by the user. Finally, remove klp_find_verify_func_addr as it can be replaced by klp_find_object_symbol directly. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 19

[PATCH 3/4 v5] livepatch: add sympos as disambiguator field to klp_reloc

2015-11-12 Thread Chris J Arges
if it is valid. Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol as they are no longer used. >From the klp_reloc structure remove val, as it can be refactored as a local variable in klp_write_object_relocations. Signed-off-by: Chris J Arges --- include/li

[PATCH 4/4 v5] livepatch: function,sympos scheme in livepatch sysfs directory

2015-11-12 Thread Chris J Arges
found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a

[PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols

2015-11-12 Thread Chris J Arges
search for the static symbols within the livepatch module. It makes it easier to understand the meaning of the external flag and klp_find_external_symbol() function. Signed-off-by: Petr Mladek Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 3 ++- kernel/livepatch/core.c | 12

[PATCH 1/4 v5] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-12 Thread Chris J Arges
for patching if it is valid. In addition, make old_addr an internal structure field not to be specified by the user. Finally, remove klp_find_verify_func_addr as it can be replaced by klp_find_object_symbol directly. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 20

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
On 11/11/2015 10:29 AM, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default old_sympos will be 0, and patching will only succeed if Minor typo. old_sympos, should just be sympos. --chris > the symbol is unique. Spe

[PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
: Chris J Arges --- include/linux/livepatch.h | 5 ++-- kernel/livepatch/core.c | 74 ++- 2 files changed, 18 insertions(+), 61 deletions(-) diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h index df7b752..fb968a2 100644 --- a

[PATCH 3/3 v4] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-11 Thread Chris J Arges
here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 +- kernel/livepatch/core.c | 10 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH 1/3 v4] livepatch: add old_sympos as disambiguator field to klp_func

2015-11-11 Thread Chris J Arges
. Finally, old_addr is now an internal structure element and not to be specified by the user. Signed-off-by: Chris J Arges --- include/linux/livepatch.h | 20 ++ kernel/livepatch/core.c | 53 +++ 2 files changed, 37 insertions(+), 36

Re: [PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-09 Thread Chris J Arges
On 11/09/2015 02:56 PM, Josh Poimboeuf wrote: > I'd recommend splitting this up into two separate patches: > > 1. introduce old_sympos > 2. change the sysfs interface > > On Mon, Nov 09, 2015 at 10:16:05AM -0600, Chris J Arges wrote: >> In cases of duplicate symbol

[PATCH v3] livepatch: old_name,number scheme in livepatch sysfs directory

2015-11-09 Thread Chris J Arges
the patched object. An example of patching multiple symbols can be found here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 6 ++- include/linux/livepatch.h| 20 --- kernel

Re: [PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory

2015-11-05 Thread Chris J Arges
On Thu, Nov 05, 2015 at 09:56:56AM -0600, Josh Poimboeuf wrote: > On Thu, Nov 05, 2015 at 04:18:12PM +0100, Miroslav Benes wrote: > > On Wed, 4 Nov 2015, Josh Poimboeuf wrote: > > > > > On Wed, Nov 04, 2015 at 10:52:52AM +0100, Miroslav Benes wrote: > > > > On Tue, 3 Nov 2015, Josh Poimboeuf wrote

Re: [PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory

2015-11-04 Thread Chris J Arges
On 11/04/2015 10:03 AM, Josh Poimboeuf wrote: > On Wed, Nov 04, 2015 at 10:52:52AM +0100, Miroslav Benes wrote: >> On Tue, 3 Nov 2015, Josh Poimboeuf wrote: Object entry would be empty for not loaded object. I would not dare to propose to remove such object entries. It would make thing

Re: [PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory

2015-11-03 Thread Chris J Arges
On 11/03/2015 10:50 AM, Josh Poimboeuf wrote: > On Tue, Nov 03, 2015 at 05:09:48PM +0100, Miroslav Benes wrote: >> On Tue, 3 Nov 2015, Josh Poimboeuf wrote: >> >>> On Tue, Nov 03, 2015 at 11:52:08AM +0100, Miroslav Benes wrote: >>>> On

[PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory

2015-11-02 Thread Chris J Arges
: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 2 +- kernel/livepatch/core.c | 45 ++-- 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/Documentation/ABI

Re: [PATCH] livepatch: old_name.number scheme in livepatch sysfs directory

2015-11-02 Thread Chris J Arges
On Mon, Nov 02, 2015 at 01:52:44PM -0600, Josh Poimboeuf wrote: > On Mon, Nov 02, 2015 at 11:58:47AM -0600, Chris J Arges wrote: > > The following directory structure will allow for cases when the same > > function name exists in a single object. > > /sys/kernel/live

[PATCH] livepatch: old_name.number scheme in livepatch sysfs directory

2015-11-02 Thread Chris J Arges
: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI/testing/sysfs-kernel-livepatch | 2 +- kernel/livepatch/core.c | 20 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/Documentation/ABI

Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory

2015-10-31 Thread Chris J Arges
On 10/31/2015 08:53 PM, Jessica Yu wrote: > +++ Chris J Arges [30/10/15 22:44 -0500]: >> The following directory structure will allow for cases when the same >> function name exists in a single object. >> /sys/kernel/livepatch/// > > Hi Chris, thanks for the patch.

[PATCH] livepatch: old_name@old_addr scheme in livepatch sysfs directory

2015-10-30 Thread Chris J Arges
The following directory structure will allow for cases when the same function name exists in a single object. /sys/kernel/livepatch/// An example of this issue is documented here: https://github.com/dynup/kpatch/issues/493 Signed-off-by: Chris J Arges --- Documentation/ABI

Re: [PATCH v14 00/24] Compile-time stack metadata validation

2015-10-26 Thread Chris J Arges
ed with no issues, issued backtraces via sysrq, and used stress-ng. FWIW: Tested-by: Chris J Arges --chris j arges -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH v13.1 04/23] x86/stacktool: Compile-time stack metadata validation

2015-10-01 Thread Chris J Arges
On 10/01/2015 10:25 AM, Josh Poimboeuf wrote: > On Thu, Oct 01, 2015 at 09:50:51AM -0500, Chris J Arges wrote: >> >>> + >>> +$(STACKTOOL_IN): FORCE >>> + @$(MAKE) $(build)=stacktool >>> + >>> +$(STACKTOOL): $(STACKTOOL_IN) >>>

Re: [PATCH v13.1 04/23] x86/stacktool: Compile-time stack metadata validation

2015-10-01 Thread Chris J Arges
is failing on this diff: diff arch/x86/insn/x86-opcode-map.txt ../../arch/x86/lib/x86-opcode-map.txt And the output is as follows: 902,904d890 < 3: xrstors < 4: xsavec < 5: xsaves 949,950c935,936 < 6: XSAVEOPT | clwb (66) | mfence (11B) < 7: clflush | clflushopt (66) | sfence (

[PATCH 1/3] x86/uaccess: Add stack frame output operand in get_user inline asm

2015-09-17 Thread Chris J Arges
sm code if CONFIG_FRAME_POINTER is enabled by listing the stack pointer as an output operand for the get_user inline assembly statement. Signed-off-by: Chris J Arges --- arch/x86/include/asm/uaccess.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/u

[PATCH 3/3] kprobes/x86: stacktool: ignore kretprobe_trampoline_holder

2015-09-17 Thread Chris J Arges
The function kretprobe_trampoline_holder isn't called explicility and therefore should be ignored by stacktool. Signed-off-by: Chris J Arges --- arch/x86/kernel/kprobes/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/c

[PATCH 2/3] x86/stacktool: Ignore head_$(BITS) files.

2015-09-17 Thread Chris J Arges
Tell stacktool to skip validation of head_64, head_32 as they don't affect runtime kernel stack traces. Signed-off-by: Chris J Arges --- arch/x86/kernel/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index b1b78ff..f331fef 1

[PATCH 0/3] A few stacktool warning fixes.

2015-09-17 Thread Chris J Arges
Included here are a few patches to fix various stacktool warnings I've found. This patchset requires the stack validation patchset. Chris J Arges (3): x86/uaccess: Add stack frame output operand in get_user inline asm x86/stacktool: Ignore head_$(BITS) files. kprobes/x86: stacktool: i

Re: [PATCH v12 00/21] Compile-time stack metadata validation

2015-09-15 Thread Chris J Arges
[stacktool] Error 2 Makefile:1502: recipe for target 'tools/stacktool' failed make: *** [tools/stacktool] Error 2 The patch below addresses this issue for me. -- >From 9ec5827aa726300394c0155657820f2595008116 Mon Sep 17 00:00:00 2001 From: Chris J Arges Date: Tue, 15 Sep 2015 16:45:27 + Subject: [

Re: [PATCH v8 00/21] Compile-time stack validation

2015-08-13 Thread Chris J Arges
On Thu, Aug 13, 2015 at 06:22:20AM -0500, Josh Poimboeuf wrote: > On Wed, Aug 12, 2015 at 04:24:49PM -0500, Chris J Arges wrote: > > I still get build failures and I've pared it down to x86_64 defconfig plus: > > CONFIG_MODVERSIONS=y > > CONFIG_STACK_VALIDATION=y >

Re: [PATCH v8 00/21] Compile-time stack validation

2015-08-12 Thread Chris J Arges
.tmp_foo.o treatment while others end up foo.o so something like the following will not work: cmd_stackvalidate = $(if $(patsubst n%,, \ $(STACKVALIDATE_$(basetarget).o)$(STACKVALIDATE)y), \ $(__stackvalidate) $(nofp) "$(@D)/.tmp_$(@F)";) In addition, I'm not sure

Re: [PATCH v8 00/21] Compile-time stack validation

2015-08-11 Thread Chris J Arges
Josh, I've applied and tried to build your patchset against the latest mainline kernel with the following config: http://paste.ubuntu.com/12058017/ I can build if I disable CONFIG_STACK_VALIDATION, then re-enable it after all objects are already built, so this seems like it should be resolvable i

[PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Chris J Arges
ats[node]. Use nr_node_ids to allocate a maximal sparse array instead of num_possible_nodes(). The crash was noticed after 3af229f2 was applied as it changed the node_possible_map to match node_online_map on boot. Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861 Signed-off-by: Chris J Arges ---

Re: [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Chris J Arges
On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote: > On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: > > Some architectures like POWER can have a NUMA node_possible_map that > > contains sparse entries. This causes memory corruption with openvswitch > &g

[PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Chris J Arges
Signed-off-by: Chris J Arges --- net/openvswitch/flow.c | 10 ++ net/openvswitch/flow_table.c | 18 +++--- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index bc7b0ab..425d45d 100644 --- a/net/openvswitch/

[PATCH v2] package: Makefile: ensure $MAKE can use jobserver

2015-05-29 Thread Chris J Arges
tions can be parallelized. Signed-off-by: Chris J Arges --- scripts/package/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/Makefile b/scripts/package/Makefile index bc6aa00..ea2a405 100644 --- a/scripts/package/Makefile +++ b/scripts/packag

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-05-20 Thread Chris J Arges
On Mon, May 11, 2015 at 04:00:03PM +0200, Ingo Molnar wrote: > > So potentially, CPU0 generated an interrupt that caused > > vcpu_enter_guest to be called on CPU1. However, when > > vmx_handle_external_intr was called, it didn't progress any further. > > So the IPI does look like to be lost in t

[PATCH RESEND 0/2] make deb-pkg build speed improvements

2015-05-11 Thread Chris J Arges
user182m28.028s sys 148m17.724s Original submission: https://lkml.org/lkml/2015/4/24/617 Chris J Arges (2): package: Makefile: ensure $MAKE can use jobserver builddeb: parallelize debug module installation scripts/package/Makefile | 2 +- scripts/package/builddeb | 19 -

[PATCH 2/2] builddeb: parallelize debug module installation

2015-05-11 Thread Chris J Arges
appropriate flags to xargs to set MAXPROCS (-P) equal to the number of processing units on the system. Signed-off-by: Chris J Arges --- scripts/package/builddeb | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/bu

[PATCH 1/2] package: Makefile: ensure $MAKE can use jobserver

2015-05-11 Thread Chris J Arges
tions can be parallelized. Signed-off-by: Chris J Arges --- scripts/package/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/Makefile b/scripts/package/Makefile index 99ca6e7..0dbfae7 100644 --- a/scripts/package/Makefile +++ b/scripts/packag

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-04-29 Thread Chris J Arges
.135 us| mem_cgroup_begin_page_stat(); [ 643.522967] 22837.075496 | 1) | inode_to_bdi() { [ 643.522972] 22837.075497 | 1) 0.115 us| sb_is_blkdev_sb(); Thanks,

[PATCH v3] builddeb: parallelize debug module installation

2015-04-28 Thread Chris J Arges
appropriate flags to xargs to set MAXPROCS (-P) equal to the number of processing units on the system. Signed-off-by: Chris J Arges --- scripts/package/builddeb | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/bu

Re: [PATCH v2] builddeb: parallelize debug module installation

2015-04-28 Thread Chris J Arges
On Tue, Apr 28, 2015 at 12:05:19PM +0200, Michal Marek wrote: > On 2015-04-28 10:57, Riku Voipio wrote: > > On 27 April 2015 at 19:43, Chris J Arges > > wrote: > >> When building the dbg package, we use a large 'for module in $(find' loop > >> that >

[PATCH v2] builddeb: parallelize debug module installation

2015-04-27 Thread Chris J Arges
When building the dbg package, we use a large 'for module in $(find' loop that can be easily parallelized by using 'find | xargs'. This patch modifies this loop to use the later paradigm. In addition, ensure we add '-n1 -P0' to xargs to run as many processes as pos

[PATCH 2/2] builddeb: parallelize debug module installation

2015-04-24 Thread Chris J Arges
When building the dbg package, we use a large 'for module in $(find' loop that can be easily parallelized by using 'find | xargs'. This patch modifies this loop to use the later paradigm. Signed-off-by: Chris J Arges --- scripts/package/builddeb | 15 --

[PATCH 0/2] make deb-pkg build speed improvements

2015-04-24 Thread Chris J Arges
user182m28.028s sys 148m17.724s Chris J Arges (2): package: Makefile: ensure $MAKE can use jobserver builddeb: parallelize debug module installation scripts/package/Makefile | 2 +- scripts/package/builddeb | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) -- 1.9.1 -- T

[PATCH 1/2] package: Makefile: ensure $MAKE can use jobserver

2015-04-24 Thread Chris J Arges
tions can be parallelized. Signed-off-by: Chris J Arges --- scripts/package/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/package/Makefile b/scripts/package/Makefile index 99ca6e7..0dbfae7 100644 --- a/scripts/package/Makefile +++ b/scripts/packag

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-04-16 Thread Chris J Arges
On Thu, Apr 16, 2015 at 01:04:23PM +0200, Ingo Molnar wrote: > > * Chris J Arges wrote: > > > Ingo, > > > > Below are the patches and data I've gathered from the reproducer. My > > methodology was as described previously; however I used gdb on the >

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-04-15 Thread Chris J Arges
t; Having this message in place would ensure that the IPI indeed did not > get generated on the stuck vCPU. (Because we'd not get this message.) > > Thanks, > > Ingo Ingo, Below are the patches and data I've gathered from the reproducer. My methodology was as desc

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-04-12 Thread Chris J Arges
ers for both vCPUs * For the L1 kernel: - Dump a stacktrace when we detect a lockup. - Detect a lockup and try to not alter the state. - Have a reliable signal such that the L0 hypervisor can dump the lapic structures and registers when csd_lock_wait detects a softlockup. Hopefully I can make progress and present meaningful results in my next update. Thanks, --chris j arges -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-04-07 Thread Chris J Arges
On Tue, Apr 07, 2015 at 11:21:21AM +0200, Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > On Mon, Apr 6, 2015 at 9:58 AM, Chris J Arges > > wrote: > > > > > > I noticed that with this patch it never reached 'csd: Detected > > > non-r

Re: smp_call_function_single lockups

2015-04-06 Thread Chris J Arges
On Thu, Apr 02, 2015 at 10:31:50AM -0700, Linus Torvalds wrote: > On Wed, Apr 1, 2015 at 2:59 PM, Chris J Arges > wrote: > > > > It is worthwhile to do a 'bisect' to see where on average it takes > > longer to reproduce? Perhaps it will point to a relevant c

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-04-06 Thread Chris J Arges
On 04/03/2015 12:43 AM, Ingo Molnar wrote: > > * Chris J Arges wrote: > >> Ingo, >> >> I think tracking IPI calls from 'generic_exec_single' would make a lot >> of sense. When you say poll for completion do you mean a loop after >> 'arch_s

Re: smp_call_function_single lockups

2015-04-02 Thread Chris J Arges
On 04/02/2015 02:07 PM, Ingo Molnar wrote: > > * Chris J Arges wrote: > >> Whenever we look through the crashdump we see csd_lock_wait waiting >> for CSD_FLAG_LOCK bit to be cleared. Usually the signature leading >> up to that looks like the following (

Re: smp_call_function_single lockups

2015-04-02 Thread Chris J Arges
On 04/02/2015 01:26 PM, Ingo Molnar wrote: > > * Linus Torvalds wrote: > >> So unless we find a real clear signature of the bug (I was hoping >> that the ISR bit would be that sign), I don't think trying to bisect >> it based on how quickly you can reproduce things is worthwhile. > > So I'm w

Re: smp_call_function_single lockups

2015-04-01 Thread Chris J Arges
On 04/01/2015 11:14 AM, Linus Torvalds wrote: > On Wed, Apr 1, 2015 at 9:10 AM, Chris J Arges > wrote: >> >> Even with irqbalance removed from the L0/L1 machines the hang still occurs. >> >> This results in no 'apic: vector* or 'ack_APIC*' messa

Re: smp_call_function_single lockups

2015-04-01 Thread Chris J Arges
On Wed, Apr 01, 2015 at 02:43:36PM +0200, Ingo Molnar wrote: > Have you already tested whether the hang goes away if you remove > irq-affinity fiddling daemons from the system? Do you have irqbalance > installed or similar mechanisms? > > Thanks, > > Ingo > Even with irqbalance remove

Re: smp_call_function_single lockups

2015-04-01 Thread Chris J Arges
On Tue, Mar 31, 2015 at 04:07:32PM -0700, Linus Torvalds wrote: > On Tue, Mar 31, 2015 at 3:23 PM, Chris J Arges > wrote: > > > > I had a few runs with your patch plus modifications, and got the following > > results (modified patch inlined below): > > Ok

Re: [debug PATCHes] Re: smp_call_function_single lockups

2015-04-01 Thread Chris J Arges
On Wed, Apr 01, 2015 at 02:39:13PM +0200, Ingo Molnar wrote: > > * Chris J Arges wrote: > > > This was only tested only on the L1, so I can put this on the L0 host and > > run > > this as well. The results: > > > > [ 124.897002] apic:

Re: [debug PATCHes] Re: smp_call_function_single lockups

2015-03-31 Thread Chris J Arges
c: vector a2, sent cleanup vector, move completed [ 635.187433] apic: vector a2, new-domain move in progress [ 635.191643] apic: vector b2, sent cleanup vector, move completed [ 673.548020] apic: vector b2, new-domain move in progress

Re: smp_call_function_single lockups

2015-03-31 Thread Chris J Arges
On Tue, Mar 31, 2015 at 08:08:40AM -0700, Linus Torvalds wrote: > On Mon, Mar 30, 2015 at 8:15 PM, Chris J Arges > wrote: > > > > I modified the posted patch with the following: > > Actually, in addition to Ingo's patches (and the irq printout), which > you s

  1   2   >