checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers
sorry for late reply.
I will resend patches which couldn't be applied to stating-next branch.
Thanks.
Daeseok Youn.
2014-03-01 7:19 GMT+09:00 Greg KH :
> On Fri, Feb 28, 2014 at 04:33:49PM +0900, DaeSeok Youn wrote:
>> OK. sorry.
>> I will send again.
>
> Please resend
sorry for late reply.
I will resend patches which couldn't be applied to stating-next branch.
Thanks.
Daeseok Youn.
2014-03-01 7:19 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Fri, Feb 28, 2014 at 04:33:49PM +0900, DaeSeok Youn wrote:
OK. sorry.
I will send again.
Please resend all 3
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa khal...@piap.pl:
Daeseok Youn daeseok.y...@gmail.com writes:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
This warning should be long gone IMHO. It does more harm than good.
unsigned char *ucp
Youn.
2014-03-03 16:10 GMT+09:00 Joe Perches j...@perches.com:
On Mon, 2014-03-03 at 16:01 +0900, DaeSeok Youn wrote:
2014-03-03 15:46 GMT+09:00 Krzysztof Hałasa khal...@piap.pl:
why not use some existing *hex_dump*() instead?
OK. but this patch is only for fix line length over 80 characters
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers
OK. sorry.
I will send again.
Thanks.
Daeseok Youn
2014-02-28 16:28 GMT+09:00 Dan Carpenter :
> On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote:
>>
>> clean up checkpatch.pl warnings:
>> WARNING: Line length over 80 characters
>>
>
> Patch is white
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/cxt1e1
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 45
--
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c
b/drivers
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 585 +++---
1 file changed, 293 insertions(+), 292 deletions(-)
diff --git a/drivers/staging/cxt1e1
clean up checkpatch.pl warnings:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c | 120 +++---
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git a/drivers
Signed-off-by: Daeseok Youn
---
drivers/staging/cxt1e1/hwprobe.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 02b4f8f..07de83f 100644
--- a/drivers/staging/cxt1e1/hwprobe.c
+++ b/drivers
clean up checkpatch errors and bClassificationSucceed is set to "TRUE"
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Da
bClassificationSucceed is initialized with "false",
do not need to set "false" again.
Signed-off-by: Daeseok Youn
---
drivers/staging/bcm/Qos.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 072
bClassificationSucceed is initialized with false,
do not need to set false again.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/bcm/Qos.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 0727599
clean up checkpatch errors and bClassificationSucceed is set to TRUE
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Daeseok Youn
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c
index 02b4f8f..07de83f 100644
--- a/drivers/staging/cxt1e1
clean up checkpatch.pl warnings:
WARNING: space prohibited between function name
and open parenthesis '('
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 120 +++---
1 file changed, 60 insertions(+), 60 deletions
clean up checkpatch.pl warnings:
WARNING: please no spaces at the start of a line in
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 585 +++---
1 file changed, 293 insertions(+), 292 deletions(-)
diff --git a/drivers
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45
--
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging
checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging
clean up checkpatch.pl error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 62 +++---
1 file changed, 25 insertions(+), 37 deletions(-)
diff --git a/drivers
OK. sorry.
I will send again.
Thanks.
Daeseok Youn
2014-02-28 16:28 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Patch is white space dammaged
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/cxt1e1/hwprobe.c | 45 --
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/cxt1e1
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 70 ++--
1 file changed, 35 insertions(+), 35
Oh.. sorry.
Ok, I will seperate this patch as you said.
Thanks.
Daeseok Youn.
2014-02-26 20:31 GMT+09:00, Dan Carpenter :
> On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote:
>> Actually , I saw some code like this file which is seperate line
>> between return value an
Actually , I saw some code like this file which is seperate line
between return value and function name.
So I didn't make one line of them.
Ok, I will make another patch after merge this one.
Thanks.
Daeseok Youn.
2014-02-26 18:20 GMT+09:00, Dan Carpenter :
> On Wed, Feb 26, 2014 at 06:17:5
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++--
1 file changed, 47 insertions(+), 47
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++--
1 file changed
Actually , I saw some code like this file which is seperate line
between return value and function name.
So I didn't make one line of them.
Ok, I will make another patch after merge this one.
Thanks.
Daeseok Youn.
2014-02-26 18:20 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Wed, Feb
Oh.. sorry.
Ok, I will seperate this patch as you said.
Thanks.
Daeseok Youn.
2014-02-26 20:31 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com:
On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote:
Actually , I saw some code like this file which is seperate line
between return value
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 70 ++--
1 file changed
:
context imbalance in 'Handle1401Esc' - unexpected unlock
Reviewed-by: Dan Carpenter
Signed-off-by: Daeseok Youn
---
drivers/staging/ced1401/usb1401.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index f441e33..c281fda
Ok.
I will make a patch based on linux-next branch and send it again.
Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH :
> On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
>>
>> After spin_lock() is called, all of if-else conditions in this brace
>>
Signed-off-by: Daeseok Youn
---
fs/dcache.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 265e0ce..f360620 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -3345,10 +3345,9 @@ EXPORT_SYMBOL(d_tmpfile);
static __initdata unsigned long
:
context imbalance in 'Handle1401Esc' - unexpected unlock
Signed-off-by: Daeseok Youn
---
drivers/staging/ced1401/usb1401.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index efc310c..8195eb9 100644
--- a/drivers/staging
2014-02-24 17:06 GMT+09:00 Dan Carpenter :
> On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
>> >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>> Date: Mon, 24 Feb 2014 09:17:41 +0900
>> Subject: [
2014-02-24 17:06 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote:
From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Mon, 24 Feb 2014 09:17:41 +0900
Subject
:
context imbalance in 'Handle1401Esc' - unexpected unlock
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/ced1401/usb1401.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers/staging/ced1401/usb1401.c
index efc310c..8195eb9 100644
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
fs/dcache.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 265e0ce..f360620 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -3345,10 +3345,9 @@ EXPORT_SYMBOL(d_tmpfile);
static
Ok.
I will make a patch based on linux-next branch and send it again.
Thanks.
Daeseok Youn
2014-02-25 9:43 GMT+09:00 Greg KH gre...@linuxfoundation.org:
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote:
After spin_lock() is called, all of if-else conditions in this brace
should
:
context imbalance in 'Handle1401Esc' - unexpected unlock
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
drivers/staging/ced1401/usb1401.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ced1401/usb1401.c
b/drivers
>From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Mon, 24 Feb 2014 09:17:41 +0900
Subject: [PATCH] staging: ced401: remove redundant spin_unlock
sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401
From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Mon, 24 Feb 2014 09:17:41 +0900
Subject: [PATCH] staging: ced401: remove redundant spin_unlock
sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance
>From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL poin
>From 137a2f619f1fa93fc497d891954d83c6cb307d11 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 21 Feb 2014 08:43:56 +0900
Subject: [PATCH] [SCSI] be2iscsi: make beiscsi_process_mcc() as static
beiscsi_process_mcc() is only referenced in this file.
Signed-off-by: Daeseok Y
>From 9e7478f6e953fac5b2bef0f5abe76fe8dc9e59d1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Fri, 21 Feb 2014 09:03:32 +0900
Subject: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/lpfc/lpfc_sli.c:16547:37: warning:
Using plain integer as N
From 9e7478f6e953fac5b2bef0f5abe76fe8dc9e59d1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 21 Feb 2014 09:03:32 +0900
Subject: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/lpfc/lpfc_sli.c:16547:37: warning:
Using plain
From 137a2f619f1fa93fc497d891954d83c6cb307d11 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 21 Feb 2014 08:43:56 +0900
Subject: [PATCH] [SCSI] be2iscsi: make beiscsi_process_mcc() as static
beiscsi_process_mcc() is only referenced in this file.
Signed-off
From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain
npig...@kernel.dk account doesn't exist.
TO+ :
a...@linux-foundation.org, ax...@kernel.dk
On Thursday, February 20, 2014 03:56:30 PM you wrote:
> From cac24db7480b10b671d05320e0cb97a7bf5d0aea Mon Sep 17 00:00:00 2001
> From: Daeseok Youn
> Date: Thu, 20 Feb 2014 15:35:14 +0900
> Sub
>From cac24db7480b10b671d05320e0cb97a7bf5d0aea Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Thu, 20 Feb 2014 15:35:14 +0900
Subject: [PATCH] block: replace obsolete simple_strtol() with kstrtoul()
- Makes rd_size value as static, because it is only
referenced in this file.
Signed-
>From 6f865fde2e48ddc09f940ec30ebfc144cf074fd1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
sparse says:
drivers/ata/libahci.c:1390:5: warning:
symbol 'ahci_pmp_retry_softre
>From 4a31953389769f685db08f93473fcbe732baaefc Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] ata: libahci: replace obsolete simple_strtoul() with
kstrtouint()
Signed-off-by: Daeseok Youn
---
drivers/ata/libahci.c |5 +++--
1 f
2014-02-19 21:38 GMT+09:00 Sergei Shtylyov :
> Hello.
>
>
> On 19-0202014 9:07, Daeseok Youn wrote:
>
>> From 2a428e5e45bca3fc38fad17b9e2e14c5e6514ca0 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>> Date: Wed, 19 Feb 2014 10:56:37 +0900
>&
2014-02-19 21:38 GMT+09:00 Sergei Shtylyov sergei.shtyl...@cogentembedded.com:
Hello.
On 19-0202014 9:07, Daeseok Youn wrote:
From 2a428e5e45bca3fc38fad17b9e2e14c5e6514ca0 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject
From 4a31953389769f685db08f93473fcbe732baaefc Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] ata: libahci: replace obsolete simple_strtoul() with
kstrtouint()
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
From 6f865fde2e48ddc09f940ec30ebfc144cf074fd1 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
sparse says:
drivers/ata/libahci.c:1390:5: warning:
symbol
From cac24db7480b10b671d05320e0cb97a7bf5d0aea Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Thu, 20 Feb 2014 15:35:14 +0900
Subject: [PATCH] block: replace obsolete simple_strtol() with kstrtoul()
- Makes rd_size value as static, because it is only
referenced
npig...@kernel.dk account doesn't exist.
TO+ :
a...@linux-foundation.org, ax...@kernel.dk
On Thursday, February 20, 2014 03:56:30 PM you wrote:
From cac24db7480b10b671d05320e0cb97a7bf5d0aea Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Thu, 20 Feb 2014 15:35:14
I re-send this patch after fixing subject.
Thanks.
Daeseok Youn
2014-02-19 15:05 GMT+09:00 David Miller :
> From: Daeseok Youn
> Date: Wed, 19 Feb 2014 14:09:49 +0900
>
>> From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn
>>
>From a6ff4eec0b80ff6596a278623a02e3ed462c49ed Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] ata: libahci: replace obselete simple_strtoul() with
kstrtouint()
Signed-off-by: Daeseok Youn
---
drivers/ata/libahci.c |5 +++--
1 f
>From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 10:49:12 +0900
Subject: [PATCH] atm: solos-pci: make solos_bh() as static
sparse says:
drivers/atm/solos-pci.c:763:6: warning:
symbol 'solos_bh' was not declared. Sho
>From c320d2ea1ed51c88255c33a50c74fa3598ab7be6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 10:10:11 +0900
Subject: [PATCH] atm: nicstar: use NULL instead of 0 for pointer
sparse says:
drivers/atm/nicstar.c:642:27: warning:
Using plain integer as NULL pointer
drivers/
>From 932e928d53b1e588dc17019e7f9fa7a61b8b7468 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 10:35:41 +0900
Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer
sparse says:
drivers/atm/ambassador.c:1928:24: warning:
Using plain integer as NULL poin
>From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
kstrtouint()
Signed-off-by: Daeseok Youn
---
drivers/ata/libahci.c |5 +++--
1 f
>From 2a428e5e45bca3fc38fad17b9e2e14c5e6514ca0 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
sparse says:
drivers/ata/libahci.c:1390:5: warning:
symbol 'ahci_pmp_retry_softre
From 2a428e5e45bca3fc38fad17b9e2e14c5e6514ca0 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 10:56:37 +0900
Subject: [PATCH] ata: libahci: make ahci_pmp_retry_softreset() as static
sparse says:
drivers/ata/libahci.c:1390:5: warning:
symbol
From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] atm: libahci: replace obselete simple_strtoul() with
kstrtouint()
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
From 932e928d53b1e588dc17019e7f9fa7a61b8b7468 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 10:35:41 +0900
Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer
sparse says:
drivers/atm/ambassador.c:1928:24: warning:
Using plain integer
From c320d2ea1ed51c88255c33a50c74fa3598ab7be6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 10:10:11 +0900
Subject: [PATCH] atm: nicstar: use NULL instead of 0 for pointer
sparse says:
drivers/atm/nicstar.c:642:27: warning:
Using plain integer as NULL
From 6297aabeff748777b520cc0ee835af0a3ddc79e2 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 10:49:12 +0900
Subject: [PATCH] atm: solos-pci: make solos_bh() as static
sparse says:
drivers/atm/solos-pci.c:763:6: warning:
symbol 'solos_bh
From a6ff4eec0b80ff6596a278623a02e3ed462c49ed Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 13:44:24 +0900
Subject: [PATCH] ata: libahci: replace obselete simple_strtoul() with
kstrtouint()
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
I re-send this patch after fixing subject.
Thanks.
Daeseok Youn
2014-02-19 15:05 GMT+09:00 David Miller da...@davemloft.net:
From: Daeseok Youn daeseok.y...@gmail.com
Date: Wed, 19 Feb 2014 14:09:49 +0900
From 18bd7236f36a248a0871f810cec3c1e98f098a91 Mon Sep 17 00:00:00 2001
From: Daeseok
>From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Thu, 13 Feb 2014 17:16:36 +0900
Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer
following sparse warnings:
drivers/firmware/efi/efivars.c:230:66: warning:
Using plain inte
>From dc82a41842df1e20e8508cea6922882f8b122a50 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Thu, 13 Feb 2014 16:44:58 +0900
Subject: [PATCH] block: use NULL instead of 0 for pointer in blkdev.h
following sparse warning:
include/linux/blkdev.h:1518:16: warning:
Using plain integer as N
From dc82a41842df1e20e8508cea6922882f8b122a50 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Thu, 13 Feb 2014 16:44:58 +0900
Subject: [PATCH] block: use NULL instead of 0 for pointer in blkdev.h
following sparse warning:
include/linux/blkdev.h:1518:16: warning:
Using
From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Thu, 13 Feb 2014 17:16:36 +0900
Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer
following sparse warnings:
drivers/firmware/efi/efivars.c:230:66: warning
OK. If I send a patch like this again, ChangeLog is written as you comment.
Thanks.
Daeseok Youn.
2014-02-13 11:28 GMT+09:00 David Rientjes :
> On Thu, 13 Feb 2014, Daeseok Youn wrote:
>
>> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
>> From: Dae
>From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Thu, 13 Feb 2014 10:11:39 +0900
Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
kernel/resource.c:518:5: warning:
symbol 'reallocate_resource' was not declared. Sho
From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Thu, 13 Feb 2014 10:11:39 +0900
Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
kernel/resource.c:518:5: warning:
symbol 'reallocate_resource
OK. If I send a patch like this again, ChangeLog is written as you comment.
Thanks.
Daeseok Youn.
2014-02-13 11:28 GMT+09:00 David Rientjes rient...@google.com:
On Thu, 13 Feb 2014, Daeseok Youn wrote:
From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
From: Daeseok Youn
>From 5b07f49e38a55ccc2788c29b7e3852827298261a Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Mon, 10 Feb 2014 20:16:50 +0900
Subject: [PATCH] staging : ion : Fix some checkpatch warnings and an error
Warning:
- Unnecessary space after function pointer name
- quoted string split acr
Oh.. I see.
My tabstop size is 4 in my editor so I didn't get your comment.
Sorry for that.(I know tabs in kernel are 8 char.)
I will re-send fixing alignment as your comment.
Thanks a lot.
Daeseok Youn
2014-02-11 9:20 GMT+09:00 Joe Perches :
> On Tue, 2014-02-11 at 09:11 +0900, DaeSeok Y
Hi,
Thanks for review.
If I send this patch again, i will use a subject as you comment.
And alignment issue, my patch line seems to be same with your example.
Daeseok Youn
2014-02-11 1:33 GMT+09:00 Joe Perches :
> On Mon, 2014-02-10 at 20:25 +0900, Daeseok Youn wrote:
>
>
>From 2b94a20adb53fba1a6a3d2aebfbbc1b708e04f3b Mon Sep 17 00:00:00 2001
From: Daeseok Youn
Date: Mon, 10 Feb 2014 20:16:50 +0900
Subject: [PATCH] staging : ion : Fix some checkpatch warnings and an error
Warning:
- Unnecessary space after function pointer name
- quoted string split acr
OK. I will re-send this patch except replacing seq_printf() with seq_puts().
Your review helped me a lot.
Thanks.
Daeseok Youn.
2014-02-10 19:52 GMT+09:00 Dan Carpenter :
> On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote:
>> Thanks for reviewing.
>>
>>
similar with this patch.
You can see with this url
https://github.com/torvalds/linux/commit/2d219c518882d2b2bac77742a6a8979c9dad051a
https://github.com/mirrors/linux-2.6/commit/7aff38176e79a22b1749c2af74060028298e6a45
If you don't mind, let me know why it is not good.
Thanks.
Daeseok Youn
2014-02
similar with this patch.
You can see with this url
https://github.com/torvalds/linux/commit/2d219c518882d2b2bac77742a6a8979c9dad051a
https://github.com/mirrors/linux-2.6/commit/7aff38176e79a22b1749c2af74060028298e6a45
If you don't mind, let me know why it is not good.
Thanks.
Daeseok Youn
2014-02
OK. I will re-send this patch except replacing seq_printf() with seq_puts().
Your review helped me a lot.
Thanks.
Daeseok Youn.
2014-02-10 19:52 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote:
Thanks for reviewing.
Yes, I just
From 2b94a20adb53fba1a6a3d2aebfbbc1b708e04f3b Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Mon, 10 Feb 2014 20:16:50 +0900
Subject: [PATCH] staging : ion : Fix some checkpatch warnings and an error
Warning:
- Unnecessary space after function pointer name
- quoted
Hi,
Thanks for review.
If I send this patch again, i will use a subject as you comment.
And alignment issue, my patch line seems to be same with your example.
Daeseok Youn
2014-02-11 1:33 GMT+09:00 Joe Perches j...@perches.com:
On Mon, 2014-02-10 at 20:25 +0900, Daeseok Youn wrote:
Warning
Oh.. I see.
My tabstop size is 4 in my editor so I didn't get your comment.
Sorry for that.(I know tabs in kernel are 8 char.)
I will re-send fixing alignment as your comment.
Thanks a lot.
Daeseok Youn
2014-02-11 9:20 GMT+09:00 Joe Perches j...@perches.com:
On Tue, 2014-02-11 at 09:11 +0900
From 5b07f49e38a55ccc2788c29b7e3852827298261a Mon Sep 17 00:00:00 2001
From: Daeseok Youn daeseok.y...@gmail.com
Date: Mon, 10 Feb 2014 20:16:50 +0900
Subject: [PATCH] staging : ion : Fix some checkpatch warnings and an error
Warning:
- Unnecessary space after function pointer name
- quoted
CC+ Joe Perches.
2014-02-10 14:58 GMT+09:00 Daeseok Youn :
> From 16140b1ec1b1e1060f74707e4a6661aface81a14 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn
> Date: Mon, 10 Feb 2014 14:36:48 +0900
> Subject: [PATCH] staging : android : sync : fix a checkpatch warning
>
> - WARN
1001 - 1100 of 1119 matches
Mail list logo
