[PATCH 1/3] staging: dgnc: fix camelcase of SerialDriver and

Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc_tty.c| 118 ++--- 2 files changed, 61 insertions(+), 61 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h

[PATCH 2/3] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc

[PATCH 2/3] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc_tty.c| 118

Re: [PATCH 2/2] Staging: dgap: modified the block comments

2016-03-10 17:21 GMT+09:00 Tanvi Surana : > I have modified the file dgap.c ,making changes to the multiline > comments,thus making them appear presentable > > Signed-Off-By: Tanvi Surana > --- > drivers/staging/dgap/dgap.c | 59 >

Re: [PATCH 2/2] Staging: dgap: modified the block comments

2016-03-10 17:21 GMT+09:00 Tanvi Surana : > I have modified the file dgap.c ,making changes to the multiline > comments,thus making them appear presentable > > Signed-Off-By: Tanvi Surana > --- > drivers/staging/dgap/dgap.c | 59 > + > 1 file

[PATCH 2/2 V2] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- V2: removes appended email header on top of commit log drivers/staging/dgnc/dgnc_tty.

[PATCH 2/2 V2] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn --- V2: removes appended email header on top of commit log drivers/staging/dgnc/dgnc_tty.c | 86

[PATCH 1/2 V2] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- V2: removes appended email header on top of commit log drivers/stagin

[PATCH 1/2 V2] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn --- V2: removes appended email header on top of commit log drivers/staging/dgnc/dgnc_driver.h | 4

Re: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct

2016-03-07 16:10 GMT+09:00 Sudip Mukherjee <sudipm.mukher...@gmail.com>: > > On Mon, Feb 29, 2016 at 11:15:51AM +0900, Daeseok Youn wrote: > > From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 > > From: Daeseok Youn <daeseok.y...@gmail.com> >

Re: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct

2016-03-07 16:10 GMT+09:00 Sudip Mukherjee : > > On Mon, Feb 29, 2016 at 11:15:51AM +0900, Daeseok Youn wrote: > > From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 > > From: Daeseok Youn > > Date: Thu, 25 Feb 2016 14:53:37 +0900 > > Subject:

[PATCH 2/2 v2] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> --- v2 : typo in subject, changed from dgap to dgnc drivers/staging/dgnc/dgnc_tty.

[PATCH 2/2 v2] staging: dgnc: use tty_alloc_driver instead of kcalloc

the tty_alloc_driver() can allocate memory for ttys and termios. And also it can release allocated memory easly with using put_tty_driver(). Signed-off-by: Daeseok Youn --- v2 : typo in subject, changed from dgap to dgnc drivers/staging/dgnc/dgnc_tty.c | 86

[PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc

>From 60b1e6e5d9401f10f584928d4feeb8a3b72b46a9 Mon Sep 17 00:00:00 2001 From: Daeseok Youn <daeseok.y...@gmail.com> Date: Mon, 29 Feb 2016 11:04:02 +0900 Subject: [PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc the tty_alloc_driver() can allocate memory for ttys an

[PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc

>From 60b1e6e5d9401f10f584928d4feeb8a3b72b46a9 Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Mon, 29 Feb 2016 11:04:02 +0900 Subject: [PATCH 2/2] staging: dgap: use tty_alloc_driver instead of kcalloc the tty_alloc_driver() can allocate memory for ttys and termios. And also it can rele

[PATCH 1/2] staging: dgnc: use pointer type of tty_struct

>From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 From: Daeseok Youn <daeseok.y...@gmail.com> Date: Thu, 25 Feb 2016 14:53:37 +0900 Subject: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct For using tty_alloc_driver, SerialDriver has to be pointer type. It

[PATCH 1/2] staging: dgnc: use pointer type of tty_struct

>From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Thu, 25 Feb 2016 14:53:37 +0900 Subject: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warn

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

2015-05-03 13:13 GMT+09:00 Andrew Morton : > On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn wrote: > >> 2015-04-24 10:45 GMT+09:00 Daeseok Youn : >> > The use of 'status' in __ocfs2_add_entry() can return wrong >> > value. Some functions' return value in

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

2015-05-03 13:13 GMT+09:00 Andrew Morton a...@linux-foundation.org: On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn daeseok.y...@gmail.com wrote: 2015-04-24 10:45 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

2015-04-24 10:45 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > value. Some functions' return value in __ocfs2_add_entry(), > i.e ocfs2_journal_access_di() is saved to 'status'. > But 'status' is not used in 'bail' label for retu

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

2015-04-24 10:45 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But 'status' is not used in 'bail' label for returning

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-04-24 10:45 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > value. Some functions' return value in __ocfs2_add_entry(), > i.e ocfs2_journal_access_di() is saved to 'status'. > But 'status' is not used in 'bail' label for retu

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-04-24 10:45 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But 'status' is not used in 'bail' label

[PATCH RESEND] ocfs2: use retval instead of status for checking error

. Reviewed-by: Joseph Qi Signed-off-by: Daeseok Youn --- RESEND: missed my patch in ocfs2-devel mailing list so send it again And also add 'Reviewed-by' line. Previous sent message of my patch This patch was came from 'https://lkml.org/lkml/2015/2/27/655' This patch was needed to test but I didn't have

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Andrew. Is there problem this patch to merge? If you care about mlog_errno() cleanup, I will send another patch for that. And also if you have any reasons this patch has not been taken, please let me know. I will fix and test again. Thanks. regards, Daeseok Youn/ 2015-04-23 9:49 GMT+09:00

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Andrew. Is there problem this patch to merge? If you care about mlog_errno() cleanup, I will send another patch for that. And also if you have any reasons this patch has not been taken, please let me know. I will fix and test again. Thanks. regards, Daeseok Youn/ 2015-04-23 9:49 GMT+09:00

[PATCH RESEND] ocfs2: use retval instead of status for checking error

. Reviewed-by: Joseph Qi joseph...@huawei.com Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: missed my patch in ocfs2-devel mailing list so send it again And also add 'Reviewed-by' line. Previous sent message of my patch This patch was came from 'https://lkml.org/lkml/2015/2/27/655

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Joseph. 2015-04-23 9:49 GMT+09:00 Joseph Qi : > On 2015/4/19 13:43, Daeseok Youn wrote: >> The use of 'status' in __ocfs2_add_entry() can return wrong >> value. Some functions' return value in __ocfs2_add_entry(), >> i.e ocfs2_journal_access_di() is saved to 'st

Re: [PATCH] ocfs2: use retval instead of status for checking error

Hi, Joseph. 2015-04-23 9:49 GMT+09:00 Joseph Qi joseph...@huawei.com: On 2015/4/19 13:43, Daeseok Youn wrote: The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status

[PATCH] ocfs2: use retval instead of status for checking error

. Signed-off-by: Daeseok Youn --- This patch was came from 'https://lkml.org/lkml/2015/2/27/655' This patch was needed to test but I didn't have any environment for testing ocfs2 filesystem. But I have one, now. (I'm too busy to make this enviroment. And qemu for this fs is difficult for me. :-(, sorry

[PATCH] ocfs2: use retval instead of status for checking error

. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- This patch was came from 'https://lkml.org/lkml/2015/2/27/655' This patch was needed to test but I didn't have any environment for testing ocfs2 filesystem. But I have one, now. (I'm too busy to make this enviroment. And qemu for this fs is difficult

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-03-20 10:17 GMT+09:00 Joseph Qi : > Hi Andrew, > > On 2015/3/20 6:23, Andrew Morton wrote: >> On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn >> wrote: >> >>> The use of 'status' in __ocfs2_add_entry() can return wrong >&

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-03-20 10:17 GMT+09:00 Joseph Qi joseph...@huawei.com: Hi Andrew, On 2015/3/20 6:23, Andrew Morton wrote: On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn daeseok.y...@gmail.com wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions

Re: [Ocfs2-devel] [PATCH 3/4 RESEND] ocfs2: need to handle error for ocfs2_journal_access_di() call

OK. I will send this patch again. This patch will be based on https://lkml.org/lkml/2015/2/27/655 thanks regards, Daeseok Youn 2015-03-19 20:00 GMT+09:00 Joseph Qi : > On 2015/2/28 7:51, Daeseok Youn wrote: >> There is no error handle when ocfs2_journal_access_di() is failed. &g

Re: [Ocfs2-devel] [PATCH 2/4 RESEND] ocfs2: remove extra mlog_errno() call in __ocfs2_add_entry()

OK. If i want to clean up mlog() call twice, mlog() in " bail" can be removed, right? Thanks. Regards, Daeseok Youn 2015-03-19 19:45 GMT+09:00 Joseph Qi : > On 2015/2/28 7:49, Daeseok Youn wrote: >> Signed-off-by: Daeseok Youn >> --- >> RESEND: this patch is

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

2015-03-19 15:24 GMT+09:00 Joseph Qi : > Looks good to me. > > On 2015/2/28 7:48, Daeseok Youn wrote: >> The use of 'status' in __ocfs2_add_entry() can return wrong >> status when some functions are failed. >> >> If ocfs2_journal_access_db() in __ocfs2_add_

Re: [Ocfs2-devel] [PATCH 3/4 RESEND] ocfs2: need to handle error for ocfs2_journal_access_di() call

OK. I will send this patch again. This patch will be based on https://lkml.org/lkml/2015/2/27/655 thanks regards, Daeseok Youn 2015-03-19 20:00 GMT+09:00 Joseph Qi joseph...@huawei.com: On 2015/2/28 7:51, Daeseok Youn wrote: There is no error handle when ocfs2_journal_access_di() is failed

Re: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

2015-03-19 15:24 GMT+09:00 Joseph Qi joseph...@huawei.com: Looks good to me. On 2015/2/28 7:48, Daeseok Youn wrote: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed. If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, that status

Re: [Ocfs2-devel] [PATCH 2/4 RESEND] ocfs2: remove extra mlog_errno() call in __ocfs2_add_entry()

OK. If i want to clean up mlog() call twice, mlog() in bail can be removed, right? Thanks. Regards, Daeseok Youn 2015-03-19 19:45 GMT+09:00 Joseph Qi joseph...@huawei.com: On 2015/2/28 7:49, Daeseok Youn wrote: Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: this patch

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, This patch have been pending for 2 weeks. Do I need to check other things? please, check for me. Thanks! regards, Daeseok Youn 2015-02-28 8:48 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, This patch have been pending for 2 weeks. Do I need to check other things? please, check for me. Thanks! regards, Daeseok Youn 2015-02-28 8:48 GMT+09:00 Daeseok Youn daeseok.y...@gmail.com: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, How is this patch going on? please check for me. Thanks. Daeseok Youn. 2015-03-03 10:38 GMT+09:00 DaeSeok Youn : > Hi, all > > please, review this patch. > > thanks. > > regards, > Daeseok Youn. > > 2015-03-02 18:04 GMT+09:00 Richard Weinberger : >> Am

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, How is this patch going on? please check for me. Thanks. Daeseok Youn. 2015-03-03 10:38 GMT+09:00 DaeSeok Youn daeseok.y...@gmail.com: Hi, all please, review this patch. thanks. regards, Daeseok Youn. 2015-03-02 18:04 GMT+09:00 Richard Weinberger rich...@nod.at: Am 28.02.2015 um

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, all please, review this patch. thanks. regards, Daeseok Youn. 2015-03-02 18:04 GMT+09:00 Richard Weinberger : > Am 28.02.2015 um 00:48 schrieb Daeseok Youn: >> The use of 'status' in __ocfs2_add_entry() can return wrong >> status when some funct

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

Hi, all please, review this patch. thanks. regards, Daeseok Youn. 2015-03-02 18:04 GMT+09:00 Richard Weinberger rich...@nod.at: Am 28.02.2015 um 00:48 schrieb Daeseok Youn: The use of 'status' in __ocfs2_add_entry() can return wrong status when some functions are failed

[PATCH 4/4 RESEND] ocfs2: remove goto statement in ocfs2_check_dir_for_entry()

Signed-off-by: Daeseok Youn --- RESEND: this patch is rebased by 1/4. fs/ocfs2/dir.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index c63f2b6..b3ab2a6 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -2043,22 +2043,19

[PATCH 3/4 RESEND] ocfs2: need to handle error for ocfs2_journal_access_di() call

There is no error handle when ocfs2_journal_access_di() is failed. And also it doesn't need to call ocfs2_dx_dir_insert() when ocfs2_journal_access_db() is failed. Signed-off-by: Daeseok Youn --- RESEND: this patch rebased by 1/4 fs/ocfs2/dir.c |8 1 files changed, 4 insertions

[PATCH 2/4 RESEND] ocfs2: remove extra mlog_errno() call in __ocfs2_add_entry()

Signed-off-by: Daeseok Youn --- RESEND: this patch is rebased by 1/4 fs/ocfs2/dir.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 1478a50..c1ab24f 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1689,10 +1689,8 @@ int

[PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

() is failed but can be returned as 'success'. So replace 'status' with 'retval'. Signed-off-by: Daeseok Youn --- V2 : update changelog fs/ocfs2/dir.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index b08050b..1478a50 100644

Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Hi, 2015-02-27 18:41 GMT+09:00 Richard Weinberger : > On Fri, Feb 27, 2015 at 10:27 AM, DaeSeok Youn wrote: >> Hi, >> >> I think this patch was already queued. Can I send this patch again >> after update changelog? > > One thing that is much more important, how

Re: + ocfs2-remove-unneeded-rc-for-kfree.patch added to -mm tree

2015-02-27 16:06 GMT+09:00 Joseph Qi : > We can only free conn->cc_private if error occurs. Otherwise it will > trigger a bug in o2cb_cluster_disconnect since conn->cc_private has > already been freed. > So please drop this patch, thanks. Yes. right.. Sorry for noise. Th

Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Hi, I think this patch was already queued. Can I send this patch again after update changelog? Thanks. Regards, Daeseok Youn 2015-02-27 6:33 GMT+09:00 Andrew Morton : > On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn > wrote: > >> Use 'retval' instead of 'status'. >> >

Re: + ocfs2-remove-unneeded-rc-for-kfree.patch added to -mm tree

. Daeseok Youn. On 2015/2/18 7:32, a...@linux-foundation.org wrote: The patch titled Subject: ocfs2: remove unneeded 'rc' for kfree() has been added to the -mm tree. Its filename is ocfs2-remove-unneeded-rc-for-kfree.patch This patch should soon appear at http://ozlabs.org/~akpm

Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Hi, I think this patch was already queued. Can I send this patch again after update changelog? Thanks. Regards, Daeseok Youn 2015-02-27 6:33 GMT+09:00 Andrew Morton a...@linux-foundation.org: On Mon, 23 Feb 2015 19:38:10 +0900 Daeseok Youn daeseok.y...@gmail.com wrote: Use 'retval

[PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

() is failed but can be returned as 'success'. So replace 'status' with 'retval'. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- V2 : update changelog fs/ocfs2/dir.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index

[PATCH 3/4 RESEND] ocfs2: need to handle error for ocfs2_journal_access_di() call

There is no error handle when ocfs2_journal_access_di() is failed. And also it doesn't need to call ocfs2_dx_dir_insert() when ocfs2_journal_access_db() is failed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: this patch rebased by 1/4 fs/ocfs2/dir.c |8 1 files

[PATCH 2/4 RESEND] ocfs2: remove extra mlog_errno() call in __ocfs2_add_entry()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: this patch is rebased by 1/4 fs/ocfs2/dir.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 1478a50..c1ab24f 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c

[PATCH 4/4 RESEND] ocfs2: remove goto statement in ocfs2_check_dir_for_entry()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- RESEND: this patch is rebased by 1/4. fs/ocfs2/dir.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index c63f2b6..b3ab2a6 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c

Re: [PATCH 1/3] ocfs2: remove unneeded variable 'status'

Hi, 2015-02-27 18:41 GMT+09:00 Richard Weinberger richard.weinber...@gmail.com: On Fri, Feb 27, 2015 at 10:27 AM, DaeSeok Youn daeseok.y...@gmail.com wrote: Hi, I think this patch was already queued. Can I send this patch again after update changelog? One thing that is much more important

[PATCH] ocfs2: remove goto statement in ocfs2_check_dir_for_entry()

Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index c63f2b6..b3ab2a6 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -2043,22 +2043,19 @@ int ocfs2_check_dir_for_entry(struct

[PATCH] ocfs2: remove goto statement in ocfs2_check_dir_for_entry()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index c63f2b6..b3ab2a6 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -2043,22 +2043,19 @@ int

[PATCH 3/3] ocfs2: need to handle error for ocfs2_journal_access_di() call

There is no error handle when ocfs2_journal_access_di() is failed. And also it doesn't need to call ocfs2_dx_dir_insert() when ocfs2_journal_access_db() is failed. Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs

[PATCH 2/3] ocfs2: remove extra mlog_errno() call in __ocfs2_add_entry()

Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 1478a50..c1ab24f 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1689,10 +1689,8 @@ int __ocfs2_add_entry(handle_t *handle

[PATCH 1/3] ocfs2: remove unneeded variable 'status'

Use 'retval' instead of 'status'. Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index b08050b..1478a50 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1617,7 +1617,7 @@ int

[PATCH 2/3] ocfs2: remove extra mlog_errno() call in __ocfs2_add_entry()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 1478a50..c1ab24f 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -1689,10 +1689,8 @@ int

[PATCH 1/3] ocfs2: remove unneeded variable 'status'

Use 'retval' instead of 'status'. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index b08050b..1478a50 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c

[PATCH 3/3] ocfs2: need to handle error for ocfs2_journal_access_di() call

There is no error handle when ocfs2_journal_access_di() is failed. And also it doesn't need to call ocfs2_dx_dir_insert() when ocfs2_journal_access_db() is failed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c |8 1 files changed, 4 insertions(+), 4 deletions

[PATCH] ocfs2: avoid a pointless delay in o2cb_cluster_check()

Signed-off-by: Daeseok Youn --- fs/ocfs2/stack_o2cb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 1724d43..220cae7 100644 --- a/fs/ocfs2/stack_o2cb.c +++ b/fs/ocfs2/stack_o2cb.c @@ -295,7 +295,7 @@ static int

[PATCH] ocfs2: avoid a pointless delay in o2cb_cluster_check()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/stack_o2cb.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 1724d43..220cae7 100644 --- a/fs/ocfs2/stack_o2cb.c +++ b/fs/ocfs2/stack_o2cb.c @@ -295,7

[PATCH 2/2] ocfs2: remove unneeded 'rc' for kfree()

If kzalloc() is failed, just goto 'out' label and 'out_free' label doesn't need to check 'rc' variable. Signed-off-by: Daeseok Youn --- fs/ocfs2/stack_o2cb.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 813d726

[PATCH 1/2] ocfs2: remove useless if statement

The Local variable "i" in for loop is always less then O2CB_MAP_STABILIZE_COUNT. Signed-off-by: Daeseok Youn --- fs/ocfs2/stack_o2cb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 1724d43..813d726 10064

[PATCH 1/2] ocfs2: remove useless if statement

The Local variable i in for loop is always less then O2CB_MAP_STABILIZE_COUNT. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/stack_o2cb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 1724d43

[PATCH 2/2] ocfs2: remove unneeded 'rc' for kfree()

If kzalloc() is failed, just goto 'out' label and 'out_free' label doesn't need to check 'rc' variable. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/stack_o2cb.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2

[PATCH] ocfs2: remove goto statement in ocfs2_dx_dir_link_trailer()

It is nothing to do in 'out' label, so just return 'ret' variable. Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 319e786..e6e5de8 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c

[PATCH] mincore: remove unneeded variable 'err'

mincore_hugetlb() returns always '0' Signed-off-by: Daeseok Youn --- mm/mincore.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/mm/mincore.c b/mm/mincore.c index 8d6db5c..be25efd 100644 --- a/mm/mincore.c +++ b/mm/mincore.c @@ -22,7 +22,6 @@ static int

[PATCH] ocfs2: remove goto statement in ocfs2_dx_dir_link_trailer()

It is nothing to do in 'out' label, so just return 'ret' variable. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 319e786..e6e5de8 100644 --- a/fs/ocfs2/dir.c

[PATCH] mincore: remove unneeded variable 'err'

mincore_hugetlb() returns always '0' Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- mm/mincore.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/mm/mincore.c b/mm/mincore.c index 8d6db5c..be25efd 100644 --- a/mm/mincore.c +++ b/mm/mincore.c @@ -22,7 +22,6

[PATCH 3/3] ocfs2: remove unreachable code in __ocfs2_recovery_thread()

Signed-off-by: Daeseok Youn --- fs/ocfs2/journal.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index ca11c83..ff53192 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c @@ -1462,7 +1462,6 @@ bail: * requires

[PATCH 2/3] ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el()

The mlog_errno() function is called twice when some functions are failed. Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 940be6d..b08050b 100644 --- a/fs/ocfs2/dir.c +++ b/fs

[PATCH 1/3] ocfs2: remove unreachable code

Signed-off-by: Daeseok Youn --- fs/ocfs2/dir.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 319e786..940be6d 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -3513,7 +3513,6 @@ next: de = (struct ocfs2_dir_entry

[PATCH 2/3] ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el()

The mlog_errno() function is called twice when some functions are failed. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 940be6d..b08050b 100644 --- a/fs

[PATCH 1/3] ocfs2: remove unreachable code

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/dir.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index 319e786..940be6d 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -3513,7 +3513,6 @@ next: de

[PATCH 3/3] ocfs2: remove unreachable code in __ocfs2_recovery_thread()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- fs/ocfs2/journal.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index ca11c83..ff53192 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c @@ -1462,7 +1462,6 @@ bail

[PATCH 4/4] scsi: aic79xx: Use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn --- drivers/scsi/aic7xxx/aic79xx_osm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index d5c7b19..ce96a0b 100644 --- a/drivers/scsi/aic7xxx/aic79xx_osm.c +++ b

[PATCH] scsi: missing iounmap for mvi->regs_ex

It also need to call iounmap() when it fails to get res_start and res_len from pci_resource_start{len}(pdev, bar). Signed-off-by: Daeseok Youn --- drivers/scsi/mvsas/mv_init.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mvsas/mv_init.c b

[PATCH 1/4] scsi: aic7xxx: use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn --- drivers/scsi/aic7xxx/aic7xxx_osm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 8836011..a2f2c77 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b

[PATCH 2/4] scsi: aic79xx: Use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn --- drivers/scsi/aic7xxx/aic79xx_core.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c index 97f2acc..109e2c9 100644 --- a/drivers/scsi/aic7xxx/aic79xx_core.c +++ b

[PATCH 3/4] scsi: aic7xxx: Use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn --- drivers/scsi/aic7xxx/aic7xxx_core.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c index 10172a3..7f34d25 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_core.c

[PATCH 1/4] scsi: aic7xxx: use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/scsi/aic7xxx/aic7xxx_osm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 8836011..a2f2c77 100644 --- a/drivers/scsi/aic7xxx

[PATCH 2/4] scsi: aic79xx: Use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/scsi/aic7xxx/aic79xx_core.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_core.c b/drivers/scsi/aic7xxx/aic79xx_core.c index 97f2acc..109e2c9 100644 --- a/drivers/scsi/aic7xxx

[PATCH 3/4] scsi: aic7xxx: Use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/scsi/aic7xxx/aic7xxx_core.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c index 10172a3..7f34d25 100644 --- a/drivers/scsi

[PATCH 4/4] scsi: aic79xx: Use kzalloc instead of kmalloc/memset

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/scsi/aic7xxx/aic79xx_osm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c index d5c7b19..ce96a0b 100644 --- a/drivers/scsi/aic7xxx

[PATCH] scsi: missing iounmap for mvi-regs_ex

It also need to call iounmap() when it fails to get res_start and res_len from pci_resource_start{len}(pdev, bar). Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/scsi/mvsas/mv_init.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi

[PATCH] staging: dgap: fix "if" statement that always evaluates to true

cppcheck warning: (warnning) Logical disjunction always evaluates to true Reported-by: David Binderman Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap

[PATCH] staging: dgap: fix if statement that always evaluates to true

cppcheck warning: (warnning) Logical disjunction always evaluates to true Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH] staging: dgap: use gotos for handling error in dgap_remap()

Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index bdb5317..518ab56 100644 --- a/drivers/staging/dgap/dgap.c +++ b

[PATCH] staging: dgap: use gotos for handling error in dgap_remap()

Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/dgap/dgap.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index bdb5317..518ab56 100644 --- a/drivers/staging

[PATCH 4/4] staging: dgap: introducing find_board_by_major()

use find_board_by_major function instead of getting a brd from static arrary. Becasue tty's major number doesn't start zero and we can find a brd from dgap_board[]. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 28 +--- 1 files changed, 17 insertions

[PATCH 3/4] staging: dgap: remove useless variables for saving tty's major

The board_t has a tty_struct(serial_driver and print_driver) that has a major number. When major number is compared in dgap_tty_open(), just use brd->serial_driver{print_driver}->major. Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c |9 ++--- drivers/staging/dgap/

[PATCH 2/4] staging: dgap: fix memory leak caused by double allocation of tty_structs

The tty_struct of serial_driver and print_driver were getting allocated twice. One is allocated in tty_alloc_driver(), the other is in dgap_tty_register(). So remove these in dgap_tty_register(). Signed-off-by: Daeseok Youn --- drivers/staging/dgap/dgap.c | 16 1 files

<    1   2   3   4   5   6   7   8   9   10   >