On Mon, Oct 12, 2020 at 09:07:15AM -0700, Arun Easi wrote:
> This does not appear to be cut against the latest for-next/staging; "rval"
> is not used there for the initial set of returns.
Indeed, forgot to use staging. It's against queue. Let me update it.
> Anyway, returning EBUSY is the right
Hello RT-list!
I'm pleased to announce the 4.4.238-rt208 stable release.
This is an update to the latest stable Linux release. No RT spefic
changes.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git
branch: v4.4-rt
Head
Hi Sebastian,
On Sat, Oct 10, 2020 at 12:01:46AM +0200, Sebastian Andrzej Siewior wrote:
> Dear RT folks!
>
> I'm pleased to announce the v5.9-rc8-rt14 patch set.
>
> Changes since v5.9-rc8-rt13:
FWIW, all my tests passed.
Thanks,
Daniel
ps: this time I didn't do the same mistake...
When the fcport is about to be deleted we should return EBUSY instead
of ENODEV. Only for EBUSY the request will be requeued in a multipath
setup.
Also in case we have a valid qpair but the firmware has not yet
started return EBUSY to avoid dropping the request.
Signed-off-by: Daniel Wagner
Hi Sebastian,
On 06.10.20 18:13, Sebastian Andrzej Siewior wrote:
Just as heads up. I just tried to build for arm64 but PREEMPT_RT
is not available anymore. Looks like ARCH_SUPPORTS_RT is only
available for !KVM.
It has been announced in v5.9-rc2-rt1
Hi Sebastian,
On 06.10.20 10:58, Sebastian Andrzej Siewior wrote:
Dear RT folks!
I'm pleased to announce the v5.9-rc8-rt12 patch set.
Just as heads up. I just tried to build for arm64 but PREEMPT_RT
is not available anymore. Looks like ARCH_SUPPORTS_RT is only
available for !KVM.
Thanks,
On Tue, Sep 29, 2020 at 09:38:02AM +0200, Daniel Wagner wrote:
> qla2xx_process_get_sp_from_handle() will clear the slot which the
> current srb is stored. So this function has a side effect. Therefore,
> we can't use it in qla24xx_process_mbx_iocb_response() to check
> for consisten
directly into
qla24xx_mbx_iocb_entry() and avoid the double call or any open coding
of the qla2xx_process_get_sp_from_handle() functionality.
Fixes: 31a3271ff11b ("scsi: qla2xxx: Handle incorrect entry_type entries")
Signed-off-by: Daniel Wagner
---
Hi,
Brown bag for me please. My test
Hello RT-list!
I'm pleased to announce the 4.4.236-rt207 stable release.
This is an update to the latest stable Linux release. No RT spefic
changes.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git
branch: v4.4-rt
Head
E/0x03 but the call trace shows that qla24xx_mbx_iocb_entry()
is used.
Add a check to verify for consistency and reset the HBA if an invalid
state is reached. Obviously, this is only a workaround until the real
problem is solved.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_isr.
nce v2:
- added reviewed tags by Martin
- addressed review comments by Arun
- patch#1: add srb pointer to log message
- patch#3: print calling func name in qla2x00_get_sp_from_handle()
- patch#4: dropped comment, reset HBA
Daniel Wagner (4):
qla2xxx: Warn if done() or free() are
Refactor qla2x00_get_sp_from_handle() to avoid the unecessary
goto if early returns are used. With this we can also avoid
preinitilzing the sp pointer.
Reviewed-by: Martin Wilck
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_isr.c | 8 +++-
1 file changed, 3 insertions(+), 5
Commit 7c3df1320e5e ("[SCSI] qla2xxx: Code changes to support new
dynamic logging infrastructure.") removed the use of the func
argument. Let's add it back.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_isr.c | 10 ++
1 file changed, 6 insertions(+), 4 deletion
viewed-by: Martin Wilck
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_init.c | 10 ++
drivers/scsi/qla2xxx/qla_inline.h | 5 +
2 files changed, 15 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 57a2d76aa691..fb7d57dc4e69
Hi Arun,
On Mon, Sep 07, 2020 at 11:47:48PM -0700, Arun Easi wrote:
> Could you drop the above comment about firmware, as it is speculation at
> this point?
Sure, no problem.
> It'd be best to take a chip reset path, rather than assuming the
> packet is good and having the appropriate handler
Hi Arun,
On Mon, Sep 07, 2020 at 11:46:27PM -0700, Arun Easi wrote:
> How about printing the "func", which gives an indication of the caller
> function, in the ql_log-s, rather than removing it? At least in the cases
> like you describe, it'd give an indication which handler the path was
>
Hello RT-list!
I'm pleased to announce the 4.4.235-rt206 stable release.
This is just an update to the latest stable release. No RT specifc
changes.
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git
branch: v4.4-rt
Head
Hello RT-list!
I'm pleased to announce the 4.4.234-rt205 stable release.
This updates the v4.4-rt almost to the latest stable release. Just
can't keep up with Greg. Anyway there was a small merge conflict in
page_alloc.c but with the help from Vlastimil Babka it was easy to
resolve. Thanks!
Commit 7c3df1320e5e ("[SCSI] qla2xxx: Code changes to support new
dynamic logging infrastructure.") removed the use of the func
argument.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_gbl.h | 3 +--
drivers/scsi/qla2xxx/qla_isr.c | 36 ---
uption.
An extensive search didn't bring any lights on the real problem. The
initial idea was to set both pointers to NULL and try to catch invalid
accesses. But instead the memory corruption was gone and the driver
didn't crash.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_init.c
Thanks,
Daniel
Daniel Wagner (4):
qla2xxx: Warn if done() or free() are called on an already freed srb
qla2xxx: Simplify return value logic in qla2x00_get_sp_from_handle()
qla2xxx: Drop unused function argument from
qla2x00_get_sp_from_handle()
qla2xxx: Handle incorrect entry_type e
h dump shows the expected
value of STATUS_TYPE/0x03 but the call trace shows that
qla24xx_mbx_iocb_entry() is used.
One possible explanation is when pkt->entry_type is read it doesn't
contain the correct information. That means the driver observes an data
race by the firmware.
Signed-off-b
Refactor qla2x00_get_sp_from_handle() to avoid the unecessary
goto if early returns are used. With this we can also avoid
preinitilzing the sp pointer.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_isr.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
On Thu, Aug 27, 2020 at 05:50:24PM +0200, Daniel Vacek wrote:
> Maybe the threshold is 33554432, eg. 32 megs...
I've rearranged the load addresses for the kernel and the dtb and now
the board is booting again. Starting with a full test run now.
The size list was mainly to see if the v5.9 tree is
On Thu, Aug 27, 2020 at 12:28:40PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-08-27 12:16:22 [+0200], Daniel Wagner wrote:
> > The -rt kernel is roughly 6MB larger. Just need to check the memory
> > ranges u-boot is using.
>
> so that 6MiB sounded bad but then it
> Would be interesting to see the size numbers for v5.6-rt? Hmm, I'll
> just start the compiler. It's all scripted anyway :)
v5.6-rt:
-rw-r--r-- 1 wagi users 28688896 Aug 27 13:38 rpi3-image-ll-v5.6.19-rt12
-rw-r--r-- 1 wagi users 28688896 Aug 27 13:34 rpi3-image-nohz-v5.6.19-rt12
-rw-r--r-- 1
On Thu, Aug 27, 2020 at 12:17:13PM +0200, Martin Wilck wrote:
> Should we perhaps log an error message when we detect a mismatch
> between sp->type and entry_type?
Sure can do, but does it really help? Not much we can do in the
driver. I hope the firmware gets fixed eventually. I am not against
> How about setting them to a dummy function that prints a big fat
> warning?
Good idea. I'll update the patch accordingly. This might even help to
find the real cause.
On Thu, Aug 27, 2020 at 11:27:43AM +0200, Sebastian Andrzej Siewior wrote:
> So v5.9-rc2-rt1 with PREEMPT_RT=y enabled leads to the problem and
> v5.9-rc2-rt1 with PREEMPT_PREEMPT=y boots fine?
Yes. But it must be something with uboot related since it's not the
kernel printing the error message.
Refactor qla2x00_get_sp_from_handle() to avoid the unecessary
goto if early returns are used. With this we can also avoid
preinitilzing the sp pointer.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_isr.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
Commit 7c3df1320e5e ("[SCSI] qla2xxx: Code changes to support new
dynamic logging infrastructure.") removed the use of the func
argument.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_gbl.h | 3 +--
drivers/scsi/qla2xxx/qla_isr.c | 36 ---
ailbox entry, it is a status
entry. Patch #4 changes the process logic for mailbox commands so that
the sp is parsed before calling the correct proccess function.
Thanks,
Daniel
Daniel Wagner (4):
qla2xxx: Reset done and free callback pointer on release
qla2xxx: Simplify return value
bring any lights on the real problem. The
initial idea was to set both pointers to NULL and try to catch invalid
accesses. But instead the memory corruption was gone and the driver
didn't crash.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_inline.h | 2 ++
1 file changed, 2 inse
h dump shows the expected
value of STATUS_TYPE/0x03 but the call trace shows that
qla24xx_mbx_iocb_entry() is used.
One possible explanation is when pkt->entry_type is read it doesn't
contain the correct information. That means the driver observes an data
race by the firmware.
Signed-off-b
On Wed, Aug 26, 2020 at 12:43:26PM +0200, Daniel Wagner wrote:
> All looks good, no crash and all tests do pass on x86_64. Firing up the
> ARM boards now.
All test pass on the BeagleBone Black.
Something is a bit weird with my RPi3 in 64bit mode. uboot loads
the the dtb file v
On Wed, Aug 26, 2020 at 11:05:18AM +0200, Daniel Wagner wrote:
> Yep, this patch helps. The system boots now. I give it a complete test
> run, just to make sure.
All looks good, no crash and all tests do pass on x86_64. Firing up the
ARM boards now.
On Wed, Aug 26, 2020 at 10:12:11AM +0200, Sebastian Andrzej Siewior wrote:
> The RT patch replaced a local-irq-disable with a local-lock which broke.
> I intend to get rid of this local-irq-disable on RT, the local-lock is
> just duct-tape to make it look the same. If this works for everyone then
Hi Sebastian,
On Mon, Aug 24, 2020 at 05:46:05PM +0200, Sebastian Andrzej Siewior wrote:
> I'm pleased to announce the v5.9-rc2-rt1 patch set.
I gave it a quick run on my test system. Can't boot the system at this
point. Didn't look closer at it, maybe it's something obvious...
stack segment:
bring any lights on the real problem. The
initial idea was to set both pointers to NULL and try to catch invalid
accesses. But instead the memory corruption was gone and the driver
didn't crash.
Signed-off-by: Daniel Wagner
---
Hi,
Although I would prefer to fix the real problem, it's propably
No need to define typedefs for the callbacks, because there is not a
single user except blk_mq_ops.
Signed-off-by: Daniel Wagner
---
v1: updated indentation
include/linux/blk-mq.h | 50 ++
1 file changed, 18 insertions(+), 32 deletions(-)
diff
On Tue, Jul 28, 2020 at 10:13:06AM -0600, Jens Axboe wrote:
> On 7/28/20 10:05 AM, Daniel Wagner wrote:
> > No need to define typedefs for the callbacks, because there is not a
> > single user except blk_mq_ops.
>
> Concept looks fine to me, but you're mixing indentations
No need to define typedefs for the callbacks, because there is not a
single user except blk_mq_ops.
Signed-off-by: Daniel Wagner
---
include/linux/blk-mq.h | 56 --
1 file changed, 22 insertions(+), 34 deletions(-)
diff --git a/include/linux/blk
tag_set()"
Cc: Ming Lei
Signed-off-by: Daniel Wagner
---
block/blk-mq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index e32cb0217135..14ee7506f32f 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2792,7 +2792,7 @@ sta
Do not update nr_hw_queues again after setting it to 1 for a kdump
kernel. This avoids allocating a tag set of size nr_cpu_ids and but
then just using one tag set.
Signed-off-by: Daniel Wagner
---
Hi,
I stumbled across this and didn't make sense to me that we might
allocated more tag sets than
Hi,
On 24.07.20 15:41, Daniel Wagner wrote:
Known issues:
sigwaittest with hackbench as workload is able to trigger a crash on x86_64,
the same as reported for the v4.4.220-rt196 release. As it turns
out it was not triggered by BPF.
https://paste.opensuse.org/view/raw/58939248
Hello RT-list!
I'm pleased to announce the v4.4.231-rt202 stable release.
This release is an update to the new stable v4.4.231 version.
It also includes the backport ("BPF: Disable on PREEMPT_RT") as
Sebastian suggested to include in v4.4-rt.
Known issues:
sigwaittest with hackbench as
On Tue, Jul 14, 2020 at 02:48:09PM -0500, Tom Zanussi wrote:
> Yeah, so do I, it's just that the srt script doesn't push the
> intervening tags (but does push the release tags).
It's on the TOOD list to add this feature to srt for ages... sorry haven't
found the time yet
Hello RT-list!
I'm pleased to announce the 4.4.229-rt200 stable release.
This release is just an update to the new stable 4.4.215 version.
Note: This update required dealing with a conflict in net/core/dev.c, where
devnet_rename_seq was moved from a seqence count to an RWSEM and renamed
to
Hi,
While trying to debug something in qla2xxx I enabled KASAN. As it turns out,
KASAN finds something in lpfc (and not qla2xxx so far).
I was able to reproduce this with v5.8-rc4 and the current mkp/queue
branch. Almost all memory debug options are enabled. Not sure which
one is able to trigger
Hi,
while trying to debug something completely unrelated to this report
I stumpled the KASAN splatter below. This happens with v5.8-rc4
and most of the memory debug config options enabled.
Showing busy workqueues and worker pools:
workqueue events: flags=0x0
pwq 0: cpus=0 node=0 flags=0x0
>
> If lockdep is disabled this lock association is compiled out and has
> neither storage size nor runtime overhead.
>
> Signed-off-by: Ahmed S. Darwish
Reviewed-by: Daniel Wagner
On Mon, Jun 29, 2020 at 07:36:15AM -0700, Dave Hansen wrote:
> On 6/29/20 12:13 AM, Daniel Wagner wrote:
> > I went to go add a new RECLAIM_* mode for the zone_reclaim_mode
> > sysctl.
>
> This conveys my motivation.
You don't need to tell a story. As explained in the docume
Hi Dave,
On Fri, Jun 26, 2020 at 06:53:33AM -0700, Dave Hansen wrote:
> Was there something else specifically in the documentation which you
> think I've neglected?
The first paragraph explains how you ended up modifying the code. While
I understand that you want to document the process, it wont
ve Hansen
> Fixes: commit 648b5cf368e0 ("mm/vmscan: remove unused
> RECLAIM_OFF/RECLAIM_ZONE")
> Acked-by: Ben Widawsky
> Cc: Alex Shi
> Cc: Daniel Wagner
> Cc: "Tobin C. Harding"
> Cc: Christoph Lameter
> Cc: Andrew Morton
> Cc: sta...@kernel.o
gain, after starring on it for while and reading up and down,
I'd say, it looks good. Also a quick test run with blktests and
lockdep enabled didn't produce any warnings.
Reviewed-by: Daniel Wagner
does not call put_io_context().
>
> The nested subclass for the ioc spinlock is no longer needed. Since it
> existed as an exception and no longer applies, remove the nested subclass
> usage.
>
> Signed-off-by: John Ogness
As far I can tell, looks good.
Reviewed-by: Daniel Wagner
On Thu, Jun 18, 2020 at 04:32:40PM +0200, Niklas Cassel wrote:
> If, for some reason, we want to allow builds with gcc < 4.6.0
> even though the minimum gcc version is now 4.8.0,
Just one thing to watch out: the stable trees are still using
older version of gcc. Note sure how relevant this is
.
>
> Reported-by: syzbot+5ac8bac25f95e8b22...@syzkaller.appspotmail.com
> Signed-off-by: Juri Lelli
> Tested-by: Daniel Wagner
Well, as it turns I can't trigger a warning on mainline but pretty simple on
RT (5.6.14-rt7-rt):
invalid opcode: [#1] PREEMPT_RT SMP NOPTI
CPU: 1 PID
Hi Alex,
On Tue, Jun 16, 2020 at 03:26:36PM -0600, Alex Williamson wrote:
> The next use of the device will generate an underflow from the
> stale reference.
>
> Cc: Qian Cai
> Fixes: 1518ac272e78 ("vfio/pci: fix memory leaks of eventfd ctx")
> Reported-by: Daniel W
Hi,
I'm getting the warning below when starting a KVM the second time with an
Emulex PCI card 'passthroughed' into a KVM. I'm terminating the session
via 'ctrl-a x', not sure if this is relevant.
This is with 5.8-rc1. IIRC, older version didn't have this problem.
modprobe -r lpfc
modprobe
y checking that the potential donor task is actually (even if
> > > > temporary because in turn boosted) running at DEADLINE priority before
> > > > using its 'dynamic' deadline value.
> > > >
> > > > Reported-by: syzbot+119ba87189432ead0...@syzkaller.appspotmail.com
> > > > Signed-off-by: Juri Lelli
> > >
> > > Reviewed-by: Daniel Bristot de Oliveira
> >
> > What happened with this patch? I still don't see it in linux-next.
> >
> > There is a number of reproducers that involve sched_setattr and lead
> > to dead machines on syzbot:
> > https://syzkaller.appspot.com/bug?id=0b210638616bb68109e9642158d4c0072770ae1c
> >
>
> Ping. Patch is not applied, and this WARNING is still being hit.
>
> Also note the bisection result:
>
> commit 7c80cfc99b7bfdc92cee26f8008859f326f4a37f
> Author: Peter Zijlstra
> Date: Sat May 6 14:03:17 2017 +
>
> sched/fair: Clean up calc_cfs_shares()
I've tested this patch against 5.8-rc1. Without the fix, after around 2 hours
the warning was triggered by the reproducer. With the patch, it survived
roughly 12 hours without the warning.
Tested-by: Daniel Wagner
. There isn't any benefit to map the QLA status
code to the NVME status code. Therefore, let's use NVME_SC_INTERNAL to
indicate an error which aligns it with the lpfc driver.
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_nvme.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
gt;
> Fixes: bf0beec0607db3c6 ("blk-mq: drain I/O when all CPUs in a hctx are
> offline")
> Signed-off-by: Dongli Zhang
Reviewed-by: Daniel Wagner
Hello RT-list!
I'm pleased to announce the 4.4.225-rt198 stable release.
This release is just an update to the new stable 4.4.215 version
and no RT specific changes have been made.
Known issues:
sigwaittest with hackbench as workload is able to trigger a crash on x86_64,
the same as
Asynchronous event notifications do not have an request
associated. When fcp_io() fails we unconditionally call
nvme_cleanup_cmd() which leads to a crash.
Fixes: 16686f3a6c3c ("nvme: move common call to nvme_cleanup_cmd to core layer")
Cc: Max Gurtovoy
Signed-off-by: Daniel Wagner
--
uot;ndlp" in DEV_LOSS.
This sounds reasonable. At least the lpfc_nlp_init() and lpfc_nlp_get() case
needs this. And I suppose this is also ok for the lfpc_enable_node().
Reviewed-by: Daniel Wagner
Thanks,
Daniel
v4.4.220-rt196:
---
Daniel Wagner (1):
Linux 4.4.220-rt197
Steven Rostedt (VMware) (1):
irq_work: Fix checking of IRQ_WORK_LAZY flag set on non PREEMPT_RT
---
kernel/irq_work.c | 12 +---
localversion-rt | 2 +-
2 files changed, 10 insertions(+), 4 deletions(-)
---
diff --git
Sebastian suggested to try this here:
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1264,8 +1264,11 @@ static void lan78xx_status(struct lan78xx_net *dev,
struct urb *urb)
netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata);
> > Wouldn't handle_nested_irq() work here instead of the simple thingy?
>
> Daniel could you try this suggestion? Would it work?
[6.427289] [ cut here ]
[6.431977] kernel BUG at drivers/net/phy/mdio_bus.c:626!
[6.437453] Internal error: Oops - BUG: 0 [#1]
:82:00.0: 2:(0):2755 ADISC failure
DID:05DF00 Status:x9/x7
Fixes: 92d7f7b0cde3 ("[SCSI] lpfc: NPIV: add NPIV support on top of SLI-3")
Cc: Dick Kennedy
Cc: James Smart
Signed-off-by: Daniel Wagner
Reviewed-by: Hannes Reinecke
Reviewed-by: James Smart
---
v2:
- fixed a couple
:82:00.0: 2:(0):2755 ADISC failure
DID:05DF00 Status:x9/x7
Fixes: 92d7f7b0cde3 ("[SCSI] lpfc: NPIV: add NPIV support on top of SLI-3")
Cc: James Smart
Cc: Alex Iannicelli
Signed-off-by: Daniel Wagner
---
Hi,
Unfortunatly, I don't really know all the procotols involved. So this
is just a roug
ames Smart
Signed-off-by: Daniel Wagner
---
Hi,
Not entirely sure if this correct. I tried to understand the logic of
the mentioned patch but failed to grasps all the details. Anyway, we
observe a crash in lpfc_sli4_process_missed_mbox_completions() while
iterating the array. All but the last one
Use irq_domain for phy interrupt from USB Int.
EP")
Cc: Woojung Huh
Cc: Marc Zyngier
Cc: Andrew Lunn
Cc: Stefan Wahren
Cc: Jisheng Zhang
Cc: Sebastian Andrzej Siewior
Cc: Thomas Gleixner
Signed-off-by: Daniel Wagner
---
Hi,
With Andrew's "net: usb: lan78xx: Connect P
mments
Fixes: 82dd23e84be3 ("mm/vmalloc.c: preload a CPU with one object for split
purpose")
Reviewed-by: Steven Rostedt (VMware)
Signed-off-by: Uladzislau Rezki (Sony)
Acked-by: Sebastian Andrzej Siewior
Acked-by: Daniel Wagner
On Tue, Oct 08, 2019 at 06:04:59PM +0200, Uladzislau Rezki wrote:
> > so, we do not guarantee, instead we minimize number of allocations
> > with GFP_NOWAIT flag. For example on my 4xCPUs i am not able to
> > even trigger the case when CPU is not preloaded.
> >
> > I can test it tomorrow on my
On Mon, Oct 07, 2019 at 06:56:11PM +0200, Uladzislau Rezki wrote:
> On Mon, Oct 07, 2019 at 06:34:43PM +0200, Daniel Wagner wrote:
> > I supppose, one thing which would help in this discussion, is what do
> > you gain by using preempt_disable() instead of moving the lock up?
On Mon, Oct 07, 2019 at 06:23:30PM +0200, Uladzislau Rezki wrote:
> Hello, Daniel, Sebastian.
>
> > > On Fri, Oct 04, 2019 at 06:30:42PM +0200, Sebastian Andrzej Siewior wrote:
> > > > On 2019-10-04 18:20:41 [+0200], Uladzislau Rezki wrote:
> > > > > If we have migrate_disable/enable, then, i
Hi,
On Fri, Oct 04, 2019 at 06:30:42PM +0200, Sebastian Andrzej Siewior wrote:
> On 2019-10-04 18:20:41 [+0200], Uladzislau Rezki wrote:
> > If we have migrate_disable/enable, then, i think preempt_enable/disable
> > should be replaced by it and not the way how it has been proposed
> > in the
On Fri, Oct 04, 2019 at 05:37:28PM +0200, Sebastian Andrzej Siewior wrote:
> If you post something that is related to PREEMPT_RT please keep tglx and
> me in Cc.
Sure, just forgot to add it this time. My email setup needs a bit more
love. Sorry.
h one object for
split purpose")
Cc: Uladzislau Rezki (Sony)
Signed-off-by: Daniel Wagner
---
mm/vmalloc.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 08c134aa7ff3..0d1175673583 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@
Hi,
> Should the following be added?
>
> Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
> called from the completion path")
Good point. Just send out and updated version
> Anyway:
>
> Reviewed-by: Bart Van Assche
Thanks!
Daniel
t is possible that multiple status continuations are emitted by the
firmware.
Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not
called from the completion path")
Cc: Bart Van Assche
Signed-off-by: Daniel Wagner
Reviewed-by: Hannes Reinecke
Reviewed-by: Bart Van Assche
---
On Wed, Sep 25, 2019 at 06:33:35PM -0700, Bart Van Assche wrote:
> On 2019-09-25 05:39, Daniel Wagner wrote:
> > So I after starring on the code I am not sure if the WARN_ON_ONCE is
> > correct. It assumes that after processing one status continuation,
> > there is no more
t is possible that multiple status continuations are emitted by the
firmware.
Cc: Bart Van Assche
Signed-off-by: Daniel Wagner
---
drivers/scsi/qla2xxx/qla_isr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 4c26630c1c3e..009fd5
Hi,
While testing an update of the qla2xxx driver (10.01.00.19-k) in our
downstream kernel, I noticed that the WARN_ON_ONCE in
qla2x00_status_cont_entry() is triggered. It was introduced by
88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called
from the completion path")
This happens
Add qedf_get_host_port_id() to the transport template.
The fc_transport_template initializes the port_id member to the
default value of -1. The new getter ensures that the sysfs entry shows
the current value and not the default one, e.g by using 'lsscsi -H -t'
Signed-off-by: Daniel Wagner
Hi Saurav,
On Tue, Sep 24, 2019 at 09:11:38AM +0200, Daniel Wagner wrote:
> On Tue, Sep 24, 2019 at 06:08:09AM +, Saurav Kashyap wrote:
> > > +static void qedf_get_host_port_id(struct Scsi_Host *shost) {
> > > + struct fc_lport *lport = shost_priv(shost);
> > > +
On Tue, Sep 24, 2019 at 06:08:09AM +, Saurav Kashyap wrote:
> > +static void qedf_get_host_port_id(struct Scsi_Host *shost) {
> > + struct fc_lport *lport = shost_priv(shost);
> > +
> > + fc_host_port_id(shost) = lport->port_id; }
>
> Minor stuff, the closing brace should be in next line.
Add qedf_get_host_port_id() to the transport template.
The fc_transport_template initializes the port_id member to the
default value of -1. The new getter ensures that the sysfs entry shows
the current value and not the default one, e.g by using 'lsscsi -H -t'
Signed-off-by: Daniel Wagner
Hello RT Folks!
I'm pleased to announce the 4.4.190-rt187 stable release.
This release is just an update to the new stable 4.4.190 version
and no RT specific changes have been made.
You can get this release via the git tree at:
Hi,
On 8/13/19 10:14 AM, Ming Lei wrote:
Now __irq_build_affinity_masks() spreads vectors evenly per node, and
all vectors may not be spread in case that each numa node has different
CPU number, then the following warning in irq_build_affinity_masks() can
be triggered:
if (nr_present <
Hello RT Folks!
I'm pleased to announce the 4.4.189-rt186 stable release.
This release is just an update to the new stable 4.4.188 version
and no RT specific changes have been made.
You can get this release via the git tree at:
Hello RT Folks!
I'm pleased to announce the 4.4.188-rt185 stable release.
This release is just an update to the new stable 4.4.188 version
and no RT specific changes have been made.
The know issue from last time is now resolved. The missing patch for
-rt has is now also part of stable
Hi Greg,
Second attempt on this topic [1]:
"""
Upstream commmit 0eb77e988032 ("vmstat: make vmstat_updater deferrable
again and shut down on idle") was back ported in v4.4.178
(bdf3c006b9a2). For -rt we definitely need the bugfix f01f17d3705b
("mm, vmstat: make quiet_vmstat lighter") as well.
ph Lameter
Acked-by: Michal Hocko
Cc: Johannes Weiner
Cc: Tetsuo Handa
Cc: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: Daniel Wagner
---
mm/vmstat.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index dd0a13013cb4..23
Signed-off-by: Linus Torvalds
Signed-off-by: Daniel Wagner
---
mm/vmstat.c | 68 -
1 file changed, 46 insertions(+), 22 deletions(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index 233045057a30..59e131e82b81 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@
Hello RT Folks!
I'm pleased to announce the 4.4.185-rt184 stable release.
This release is just an update to the new stable 4.4.185 version and
no RT specific changes have been made.
There were a couple of merge conflicts. Nothing too scary but please
verify the intermediated releases
is renamed to PREEMPT_LL which select PREEMPT as
well.
No functional change.
Signed-off-by: Thomas Gleixner
As one of the stable-rt maintainers I love to see this move forward!
Acked-by: Daniel Wagner
Hi Greg,
On 16.05.19 18:49, Greg Kroah-Hartman wrote:
> Jon, thanks for the testing, I'll go drop this patch now from the final
> version.
That's fine, I wanted to suggest this too. I have some time to look at
this next week. So there is no hurry with this patch.
> Daniel, if you can come up
Hi Jon,
> Boot regression detected for Tegra ...
>
> Test results for stable-v4.4:
> 6 builds: 6 pass, 0 fail
> 15 boots: 6 pass, 9 fail
> 8 tests: 8 pass, 0 fail
>
> Linux version:4.4.180-rc1-gbe756da
> Boards tested:tegra124-jetson-tk1, tegra20-ventana,
>
101 - 200 of 1249 matches
Mail list logo
