ndle battery reports that contain additional data.
>
Applied and tested on 5.8.0-rc4+ (aa0c9086b40c) with a 3Dconnexion
SpaceMouse Wireless (tested connected via USB). Observed the same
behavior Grant reports before the patch. After the patch, the device stays
connected successfully.
Tested-by: Darr
of best practice (at VMware), that can and
should all be removed when adding the SPDX identifier - and of course, as
you said, be done as a separate patch.
Thanks,
--
Darren Hart
On Wed, May 08, 2019 at 03:55:22PM -0700, Darren Hart wrote:
> On Wed, May 08, 2019 at 11:20:52AM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 08-05-19 10:42, Andy Shevchenko wrote:
> > > On Wed, May 8, 2019 at 10:48 AM Hans de Goede wrote:
> > >
u32(value, cap);
> }
> + /* fall through */
Similarly here.
Are we documenting intended behavior, or covering up a bug.
> case ACER_WMID:
> return WMID_set_u32(value, cap);
--
Darren Hart
VMware Open Source Technology Center
, will do.
Andy, what is the issue here? If the dependency is in v5.1 we can do a "merge
--ff-only v5.1" in our for-next branch in order to pull it in, that would be the
same as an immutable branch basically.
--
Darren Hart
VMware Open Source Technology Center
On Wed, Apr 03, 2019 at 11:05:12PM +0100, Colin Ian King wrote:
> On 03/04/2019 23:02, Darren Hart wrote:
> > On Sat, Mar 30, 2019 at 12:17:12AM +, Colin King wrote:
> >> From: Colin Ian King
> >>
> >> Currently the kfree of output.pointer can be pote
On Wed, Apr 03, 2019 at 09:54:27PM +, mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Darren Hart
> > Sent: Wednesday, April 3, 2019 3:24 PM
> > To: Limonciello, Mario
> > Cc: Andy Shevchenko; LKML; platform-driver-...@vger.kern
orrect a memory leak")
> Signed-off-by: Colin Ian King
Thanks for the catch Colin, queued for testing.
Did you trigger this error or detect it via review or static analysis?
--
Darren Hart
VMware Open Source Technology Center
atform/x86: dell-smbios: Introduce dispatcher for SMM
> calls")
> Signed-off-by: Mario Limonciello
> Acked-by: Pali Rohár
Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's
been broken that long :-(
--
Darren Hart
VMware Open Source Technology Center
it a/drivers/platform/x86/dell-smbios-base.c
> b/drivers/platform/x86/dell-smbios-base.c
> index 0537d44d45a6..a74c0df25b15 100644
> --- a/drivers/platform/x86/dell-smbios-base.c
> +++ b/drivers/platform/x86/dell-smbios-base.c
> @@ -625,6 +625,8 @@ static int __init dell_smbios_init(void)
>
> fail_platform_driver:
> kfree(da_tokens);
> + da_tokens = NULL;
> + da_num_tokens = 0;
> return ret;
> }
>
> --
> 2.20.1
>
>
--
Darren Hart
VMware Open Source Technology Center
On Sun, Mar 10, 2019 at 01:22:24PM -0700, Linus Torvalds wrote:
> On Fri, Mar 8, 2019 at 12:33 PM Darren Hart wrote:
> >
> > The wmi mod alias changes collide with a similar series for TEE based
> > devices.
>
> Anyway, you also used a *very* new subkey. Can you ple
Documentation/ABI: Correct mlxreg-io KernelVersion for 5.0
- ff7c634b4f x86/CPU: Add Icelake model number
Thanks,
Darren Hart
VMware Open Source Technology Center
The following changes since commit 49a57857aeea06ca831043acbb0fa5e0f50602fd:
Linux 5.0-rc3 (2019-01-21 13:14:44 +1300)
are available in
g
for example.
Perhaps I'm missing your desired workflow though. I tend to find the
options I need and record them in a fragment, and save it off for later
to quickly be able to "make defconfig fragA.config fragB.config" etc. Is
what you're trying to do different?
--
Darren Hart
VMware Open Source Technology Center
attias. I have this queued up for testing, and with an ack from
Masahiro for 2/8, I'll pull this in. Thanks for the patches.
--
Darren Hart
VMware Open Source Technology Center
On Wed, Mar 06, 2019 at 10:09:26PM -0800, Darren Hart wrote:
> On Sat, Feb 23, 2019 at 08:57:50PM +0100, Mattias Jacobsson wrote:
> > On 2019-02-20, Masahiro Yamada wrote:
>
> > > > > If you want all the patches to go through x86 platform-driver tree,
> &
eade65b2c.1550603967.git@mok.nu
> >
> >
> > I saw it. The 2/8 uses ALIAS_SIZE.
> >
> > So, I think it will be better to include this one in your series.
> > If necessary, please feel free to add
> >
> > Acked-by: Masahiro Yamada
> >
>
> Okey, will do. Thanks!
Agree, I'll pull it in.
--
Darren Hart
VMware Open Source Technology Center
Avoid conflicts from other subsystems by including the header with the
rest of the driver files.
Cc: Andy Shevchenko
Cc: Vadim Pasternak
Signed-off-by: Darren Hart (VMware)
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 51029a425dbe
On Wed, Mar 06, 2019 at 09:27:01PM -0800, Darren Hart wrote:
> On Mon, Mar 04, 2019 at 02:37:35PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Today's linux-next merge of the drivers-x86 tree got a conflict in:
> >
> > include/linux/platform
imise any particularly
> complex conflicts.
Thanks Stephen.
I suspect this will be a rare occurence. That said - Vadim - could you please
ensure that all the mellanox driver changes Cc the platform driver x86 mailing
list by adding it to MAINTAINERS?
--
Darren Hart
VMware Open Source Technology Center
useful in defect analysis).
And always document in your commit messages the approach you take to fix
the reported issue.
Thanks,
--
Darren Hart
VMware Open Source Technology Center
ase or send the bad patch to mainline - both
are bad. Don't get me wrong, I'm glad next catches them but I'd like
to get to the point where it doesn't trigger on our subsystem :-)
Are your patch mechanics tests available for us to integrate into our
commit and prepublication checks?
Thanks,
--
Darren Hart
VMware Open Source Technology Center
ould
definitely be automated in our workflow.
I have corrected it.
--
Darren Hart
VMware Open Source Technology Center
or example be NULL if
> > a WMI driver is registered without specifying the id_table field in
> > struct wmi_driver.
> >
> > Add a NULL check and return that the driver can't handle the device if
> > the variable is NULL.
> >
>
> Good for me, thanks
s patch includes a lot of changes
driven by your feedback. Are you satisfied with the changes, would you like to
add your Reviewed-by?
--
Darren Hart
VMware Open Source Technology Center
maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
Rob, I saw you ack this patch in an earlier version. Based on your comment here,
is that ack still valid?
--
Darren Hart
VMware Open Source Technology Center
> > > I will fix this in next version.
> > Hmm... this came to our published branch, i.e. for-next, would it be
> > better to update it via rebasing?
> >
> > Darren, what do you think?
>
> Hi Andy, I have corrected this in v2 anyway and i sent to upstream today,
> just in case you prefer it over rebasing.
>
> https://patchwork.kernel.org/patch/10810123/
>
While we try hard not to rebase, if the choice is to rebase for-next or send a
bad commit to upstream, I will opt for the rebase.
Andy, I would suggest doing the rebase.
--
Darren Hart
VMware Open Source Technology Center
6a730fcb9cb472ba2d42b26a50ac65dacdd68882:
Documentation/ABI: Correct mlxreg-io KernelVersion for 5.0 (2019-01-26
11:30:26 -0800)
Thanks,
Darren Hart
VMware Open Source Technology Center
platform-drivers-x86 for v5.0-2
Correct
On Sat, Feb 02, 2019 at 06:16:59PM +0100, Christoph Hellwig wrote:
> On Fri, Feb 01, 2019 at 03:15:59PM -0800, Darren Hart wrote:
> > On Tue, Jan 29, 2019 at 08:34:09AM +0100, Christoph Hellwig wrote:
> > > For some odd reason dell_rbu actually seems to want the physical a
hould probably also
tag for stable.
--
Darren Hart
VMware Open Source Technology Center
wig
> > ---
...
>
> Acked-by: Stuart Hayes
>
Ah, prematurely pulled in Mario - thanks Stuart.
--
Darren Hart
VMware Open Source Technology Center
On Mon, Jan 28, 2019 at 12:36:19PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov
>
> ... so that they can get CCed on platform patches.
>
> Signed-off-by: Borislav Petkov
> Cc: Darren Hart
> Cc: Andy Shevchenko
> Cc: x...@kernel.org
Acked-by: Darren Hart (V
t;platform/x86: ideapad-laptop: add lenovo
> RESCUER R720-15IKBN to no_hw_rfkill_list")
> Signed-off-by: Yang Fan
Thanks for the patch, queued for testing.
--
Darren Hart
VMware Open Source Technology Center
Goede
Hi Hans,
A few typos above, please consider adding a spellchecker to your editor for
commit message authoring... I've taken care of them and queued this patch for
testing.
Thanks!
--
Darren Hart
VMware Open Source Technology Center
removing the need for
driver authors to prefix the modules alias with "wmi:" - which is an advantage
and avoids careless errors. Is that the only goal? It adds some complexity by
spreading the implementation across more files and more directories, so we need
to document the justificatio
r each unassociated device on the bus, so I'm not
immediately seeing how dev or driver would end up being NULL here.
See: Documentation/driver-model/bus.txt
--
Darren Hart
VMware Open Source Technology Center
ner
> Cc: Ingo Molnar
> Cc: Peter Zijlstra
> Cc: Darren Hart
> Signed-off-by: Greg Kroah-Hartman
As documented, and futexes can't be modules, so no need to check for the dentry.
Reviewed-by: Darren Hart (VMware)
> ---
> kernel/futex.c | 8 ++--
> 1 file changed,
The mlxreg-io for the merge window assumed 4.21 as the next kernel
version. Replace 4.21 with 5.0.
Signed-off-by: Darren Hart (VMware)
---
Documentation/ABI/stable/sysfs-driver-mlxreg-io | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/ABI/stable/sysfs
57 AM
> > To: Alex Hung
> > Cc: platform-driver-...@vger.kernel.org; Andy Shevchenko; Darren Hart;
> > Limonciello, Mario; Rafael J. Wysocki; Chih-Wei Huang; Tristian Celestin;
> > linux-
> > ker...@vger.kernel.org
> > Subject: [PATCH] platform/x86: in
e
What appears to be needed here is for someone with the hardware and some
experience tracing ACPI calls from whatever OS it ships with to figure out the
new interface. I suspect it is either pure ACPI or possibly WMI, and a new
driver may be needed.
Have you tried this driver in BIOS mode with th
thin 48 business hours, but I find that pretty difficult to keep up
with myself.
Let's continue the discussion in the original thread.
--
Darren Hart
VMware Open Source Technology Center
gt; nouveau driver. That is another issue that I need to tackle.
>
I would expect a different error than "no such device" in that case.
I think your first thought was correct.
As a simple test, I'd suggest replacing "10" with "0A" in the existing
DMI_CHASSIS_TYPE match, recompile, and see if it loads and works
correctly. Would you be able to test this?
> Oh happy new year :-)
Happy New Year!
--
Darren Hart
VMware Open Source Technology Center
/* XO 1.75 */
> + data->new_proto = 1;
> + data->little_endian = 1;
> } else if (ecver < 0x44) {
> /*
>* We've seen a number of EC protocol changes; this driver
> --
> 2.19.1
>
>
--
Darren Hart
VMware Open Source Technology Center
ry" },
The code previously supported xo1.5 (it seems), and the commit message doesn't
mention changing the compatible string. Was this an intentional change? If so,
it should be mentioned in the commit message.
> {}
> };
> MODULE_DEVICE_TABLE(of, olpc_battery_ids);
> --
> 2.19.1
>
>
--
Darren Hart
VMware Open Source Technology Center
+ if (WARN_ON(!ec_driver->ec_cmd))
> return -ENODEV;
>
> if (!ec)
> --
> 2.19.1
>
>
--
Darren Hart
VMware Open Source Technology Center
al changes.
>
> Basically all of the above is based on the review by Andy Shevchenko.
Andy, what was your intent for Lubomir here? From the above, this looks
like it should be several patches to me.
Thanks,
--
Darren Hart
VMware Open Source Technology Center
s there a cleaner way to deal with this? There are two
> instances of the same bus type, each of which would like to have a
> device called "70FE8229-D03B-4214-A1C6-1F884B1A892A". Can we somehow
> rename the symlinks without renaming the device, or are we just
> supposed to prefix the device name like Mario is doing here?
>
Mario, if this is still a concern (I presume it is) would you please
resend the patch Cc gregkh directly?
--
Darren Hart
VMware Open Source Technology Center
value *= 60;
> unit = KBD_TIMEOUT_SECONDS;
> --
> 2.7.4
>
>
--
Darren Hart
VMware Open Source Technology Center
s = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Yoga 2 13"),
> + },
> + },
> {
> .ident = "Lenovo Yoga 3 1170 / 1470",
> .matches = {
> --
> 2.17.1
>
>
--
Darren Hart
VMware Open Source Technology Center
echo Previous value: $PREV_VAL
> + echo New value: $NEW_VAL
> + echo Will use previous value.
echo "-y passed, will not demote y to m"
Or something along those lines.
> + echo
> + elif [ "x$PREV_VAL" != "x$NEW_VAL" ] ; then
> echo Value of $CFG is redefined by fragment $MERGE_FILE:
> echo Previous value: $PREV_VAL
> echo New value: $NEW_VAL
> --
> 2.11.0
>
>
--
Darren Hart
VMware Open Source Technology Center
think were Arnd's words.
So, doing something like:
$ make arm64-selftest.config drm.config
where arm64-selftest.config defines DRM=y and drm.config defines DRM=m, the
result should be "DRM=y".
So the first step is to make merge_config.sh support it. A follow up step would
be to integrate this into the kernel Makefile system if we determine this is the
correct behavior, or to provide a parameter if we don't want to change the
default behavior.
--
Darren Hart
VMware Open Source Technology Center
ted, easily filtered by those that might not want
it, and reduces the number of times you have to explain your preference
as new maintainers come and go.
--
Darren Hart
VMware Open Source Technology Center
Hi Linus,
This tag has a few merge conflicts with some x86/cpu id changes. Stephen
Rothwell's merge in next/master is correct, and I have provided an
example here as well:
git://git.infradead.org/linux-platform-drivers-x86.git pdx86-v4.20-1-merge
Thanks,
Darren Hart
VMware Open S
changes up to ff0e9f26288d2daee4950f42b37a3d3d30d36ec1:
platform/x86: alienware-wmi: Correct a memory leak (2018-09-10 13:45:43 -0700)
Thanks,
Darren Hart
VMware Open Source Technology Center
platform-drivers-x86 for v4.19-2
Free
On Wed, Sep 12, 2018 at 12:14:34PM +, mario.limoncie...@dell.com wrote:
> Darren,
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Monday, September 10, 2018 3:52 PM
> > To: Limonciello, Mario
> > Cc: An
On Sun, Jul 08, 2018 at 03:56:17AM +0900, Mattia Dongili wrote:
> On Fri, Jul 06, 2018 at 04:24:27PM -0700, Darren Hart wrote:
> > On Thu, Jul 05, 2018 at 03:47:03PM -0500, Gustavo A. R. Silva wrote:
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
, priv->buf->std.output[1],
> priv->buf->std.output[2], priv->buf->std.output[3]);
> + kfree(output.pointer);
>
> return 0;
> }
> --
> 2.7.4
>
>
--
Darren Hart
VMware Open Source Technology Center
On Mon, Jul 09, 2018 at 09:08:56PM +, mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Monday, July 9, 2018 4:07 PM
> > To: Limonciello, Mario
> > Cc: srinivas.pandruv...@linux.intel.
dell_fill_request(&buffer, token->location, 0, 0, 0);
> ret = dell_send_request(&buffer,
> CLASS_TOKEN_READ,
> SELECT_TOKEN_AC);
> - if (ret)
> + if (ret == 0)
> max_intensity = buffer.output[3];
> }
>
> --
> 2.17.1
>
--
Darren Hart
VMware Open Source Technology Center
'version_proc_show'
> defined but not used [-Wunused-function]
>
> Signed-off-by: Randy Dunlap
> Cc: Azael Avalos
> Cc: platform-driver-...@vger.kernel.org
> Cc: Darren Hart
> Cc: Andy Shevchenko
Thanks Randy, queued.
--
Darren Hart
VMware Open Source Technology Center
On Mon, Jul 09, 2018 at 04:38:16AM +, mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com]
> > Sent: Saturday, July 7, 2018 8:44 AM
> > To: Darren Hart; Andy Shevchenko
> > Cc:
this is
feature development.
I strongly advocate for vendors to have more control over their drivers,
but this scenario really frustrates me. I don't think I can justify this
to Linus as a fix. But before we just say "no" (because hey, I want
these fixes available as early as possible too), let's ask Rafael if he
has an opinion or if there is precedent for this in his experience with
ACPI drivers in general:
Rafael?
Finally, we can also just ask Linus. The firmware update broke the power
button, we can get it working again by supporting the new API with this
patch... see what he says.
--
Darren Hart
VMware Open Source Technology Center
ntentional. Either way, from what I can see, the
final line in the function:
return AE_CTRL_TERMINATE;
Is unreachable as there are no "break" statements in the switch, and the default
falls through to return AE_OK. Something doesn't seem right here.
--
Darren Hart
VMware Open Source Technology Center
WMID_get_u32(value, cap);
> break;
> @@ -1386,6 +1388,7 @@ static acpi_status set_u32(u32 value, u32 cap)
>
> return AMW0_set_u32(value, cap);
> }
> + /* else: fall through */
I suspect you ar
refix the device name like Mario is doing here?
>
Mario,
This one has been lingering at the bottom of my patch stack for a while now -
sorry for not poking on this earlier. Is this still something you have a need
for?
If so, would you resend and add Greg to Cc - specifically directing Andy's
question above to him?
--
Darren Hart
VMware Open Source Technology Center
On Sat, Jun 23, 2018 at 08:24:26AM +0200, Julia Lawall wrote:
>
>
> On Fri, 22 Jun 2018, Darren Hart wrote:
>
> > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote:
> > > From: Colin Ian King
> > >
> > > The function dell_smbios_smm_call a
On Tue, Jun 26, 2018 at 10:32:17PM +0300, Andy Shevchenko wrote:
> On Sat, Jun 23, 2018 at 3:22 AM, Darren Hart wrote:
> > On Thu, Jun 21, 2018 at 07:15:24PM +0100, Colin King wrote:
> >> From: Colin Ian King
> >>
> >> The function dell_smbios_smm_call and po
stead - I do worry about the "static" suggesting
to someone reading the code that this data is not used outside of this file,
when it is.
I'm not finding a position on this in coding-style.
Andy, do you care to weigh in on this?
--
Darren Hart
VMware Open Source Technology Center
ll.
>
> Trim the last letter from the string so that it matches to both
> Y20-15IKBN and Y20-15IKBM models.
>
> Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1098626
> Cc:
> Signed-off-by: Takashi Iwai
Thanks Takashi, queued.
--
Darren Hart
VMware Open Source Technology Center
On Fri, Jun 15, 2018 at 12:12:51PM -0500, Mario Limonciello wrote:
> Some Dell servers can use dell-smbios but they don't support the
> token interface. Make it optional.
>
> Signed-off-by: Mario Limonciello
Thanks Mario, queued.
--
Darren Hart
VMware Open Source Technology Center
On Thu, Jun 21, 2018 at 01:24:34AM +, mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Wednesday, June 20, 2018 7:17 PM
> > To: Kees Cook
> > Cc: LKML; Andy Shevchenko; Platform Dr
On Wed, Jun 20, 2018 at 04:43:14PM -0700, Kees Cook wrote:
> On Wed, Jun 20, 2018 at 4:37 PM, Darren Hart wrote:
> > On Wed, Jun 20, 2018 at 02:31:41PM -0700, Kees Cook wrote:
> >> The probe handler_data was being allocated with __get_free_pages()
> >> for no reason I
free_pages((unsigned long)wblock->handler_data,
> -get_order(wblock->req_buf_size));
> + kfree(wblock->handler_data);
> }
>
> if (wdriver->remove)
> --
> 2.17.1
>
>
> --
> Kees Cook
> Pixel Security
>
--
Darren Hart
VMware Open Source Technology Center
. Once the builds complete, I'll move these to for-next.
Vadim, I see you've already updated the kernel version in the sys documentation
to 4.19, so I won't attempt to push these into the 4.18 RC cycle.
--
Darren Hart
VMware Open Source Technology Center
to 26ed9d1c07efa5c3a3810dbb7c668e132e91d426:
platform/x86: silead_dmi: Add entry for Chuwi Hi8 tablet touchscreen
(2018-06-08 14:22:15 +0300)
Thanks,
Darren Hart
VMware Open Source Technology Center
platform-drivers-x86 for v4.18
Vi10 tablet")
>
> I have reverted that commit for today. More care please.
Thank you Stephen. We caught this earlier, but failed to remove it from for-next
while repairing the series. Our apologies. I have removed this series back to
the known good patch in for-next:
26ed9d1 platform/x86: silead_dmi: Add entry for Chuwi Hi8 tablet touchscreen
Andy has this reworked already and is working on completing
testing before pushing the update to for-next.
--
Darren Hart
VMware Open Source Technology Center
mm_buff_addr + 8;
>
> lower_32_bits() ?
>
> > + smi_data_buf = eps_buffer + 8;
>
> > + smi_data_buf_size = (unsigned long) min(eps->num_of_4k_pages * 4096
> > - 8,
> > + (u64) ULONG_MAX);
>
> This is too twisted code. First, it needs explanation.
> Second, it might need some refactoring.
>
> (Yes, I got the idea, but would it be better implementation?)
>
> > + max_smi_data_buf_size = smi_data_buf_size;
> > + wsmt_enabled = true;
> > + dev_info(&dcdbas_pdev->dev,
> > +"WSMT found, using firmware-provided SMI buffer.\n");
> > + return 1;
> > +}
>
> > #define SMI_CMD_MAGIC (0x534D4931)
> >
> > +#define SMM_EPS_SIG"$SCB"
>
> Just integer like above and put the sting as a comment.
> (Side note: above magic also looks like string)
Given the above, I think we can use the more recognizable string - since
that is clearly how they think of this label.
Otherwise, agree with a follow-up to all of Andy's feedback.
--
Darren Hart
VMware Open Source Technology Center
ery simple 3 level brightness cycle being handled in the kernel.
2) Why is a module option preferable to a compile time option? It seems
to me the policy will be largely distro dependent, and the same kernel
needing to support both modes seems likely to be pretty rare.
--
Darren Hart
VMware Open Source Technology Center
> Signed-off-by: Vadim Pasternak
No further comments on patch 7 or 8. Thanks for the updates.
--
Darren Hart
VMware Open Source Technology Center
tributes: %d\n",
> + err);
> + return err;
> + }
> +
> + priv->hwmon = devm_hwmon_device_register_with_groups(&pdev->dev,
> + "mlxreg_io",
> + priv,
> + priv->groups);
> + if (IS_ERR(priv->hwmon)) {
> + dev_err(&pdev->dev, "Failed to register hwmon device %ld\n",
> + PTR_ERR(priv->hwmon));
> + return PTR_ERR(priv->hwmon);
> + }
> +
> + dev_set_drvdata(&pdev->dev, priv);
> +
> + return 0;
> +}
> +
> +static struct platform_driver mlxreg_io_driver = {
> + .driver = {
> + .name = "mlxreg-io",
> + },
> + .probe = mlxreg_io_probe,
> +};
> +
> +module_platform_driver(mlxreg_io_driver);
> +
> +MODULE_AUTHOR("Vadim Pasternak ");
> +MODULE_DESCRIPTION("Mellanox regmap I/O access driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:mlxreg-io");
> --
> 2.1.4
>
>
--
Darren Hart
VMware Open Source Technology Center
ice_unregister(dcdbas_pdev_reg);
> > platform_driver_unregister(&dcdbas_driver);
> > }
> > diff --git a/drivers/firmware/dcdbas.h b/drivers/firmware/dcdbas.h
> > index ca3cb0a54ab6..7ea5b3e070b9 100644
> > --- a/drivers/firmware/dcdbas.h
> > +++ b/drivers/firmware/dcdbas.h
> > @@ -54,6 +54,8 @@
> >
> > #define SMI_CMD_MAGIC (0x534D4931)
> >
> > +#define SMM_EPS_SIG"$SCB"
> > +
> > #define DCDBAS_DEV_ATTR_RW(_name) \
> > DEVICE_ATTR(_name,0600,_name##_show,_name##_store);
> >
> > @@ -103,5 +105,14 @@ struct apm_cmd {
> >
> > int dcdbas_smi_request(struct smi_cmd *smi_cmd);
> >
> > +struct smm_eps_table {
> > + char smm_comm_buff_anchor[4];
> > + u8 length;
> > + u8 checksum;
> > + u8 version;
> > + u64 smm_comm_buff_addr;
> > + u64 num_of_4k_pages;
> > +} __packed;
> > +
> > #endif /* _DCDBAS_H_ */
> >
> > --
> > 2.14.2
>
> Darren, Andy,
>
> Stuart and I were hoping you guys could bring this through the
> platform-driver-x86 tree.
> The logic behind this is that the only consumer for dcdbas in kernel is
> dell-smbios.
>
> There isn't a subsystem maintainer for someone to pull in dcdbas even though
> the
> current maintainer (Doug W) has acked it.
Apologies for the delay. I'm OK bringing it in in general. I'm reviewing patches
today and tomorrow to try and close out the backlog. Should have a review by EOD
tomorrow.
I've been wondering about drivers/firmware anyway - that is almost by definition
platform specific and might make more sense as part of the platform drivers,
especially if it is currently without a maintainer (although akpm will often
take such things).
--
Darren Hart
VMware Open Source Technology Center
want to implement software
> dimming / auto-off of the kbd backlight when the no keys are
> touched for x seconds. This would seriously get in the way of that.
>
> So sorry, but NACK to this series.
So if instead of modifying the LED value, the kernel platform drivers
converted the
goto exit;
Or, just treat them as separate events:
if (code == NOTIFY_KBD_BRTDWN) {
kbd_led_set(&asus->kbd_led, asus->kbd_led_wk - 1);
goto exit;
}
if (code == NOTIFY_KBD_BRTUP) {
kbd_led_set(&asus->kbd_led, asus->kbd_led_wk + 1);
goto exit;
}
> if (is_display_toggle(code) &&
> asus->driver->quirks->no_display_toggle)
> goto exit;
> --
> 2.11.0
>
>
--
Darren Hart
VMware Open Source Technology Center
should correctly show the OSD when this is done.
This makes sense. Userspace can't be aware of every platforms sys files,
so there needs to be a common mechanism. LED_BRIGHT_HW_CHANGED makes
sense.
--
Darren Hart
VMware Open Source Technology Center
> +Date:May 2018
> +KernelVersion: 4.18
> +Contact: Vadim Pasternak
> +Description: These files allow assert system's power cycling and PS units
> + on/off switching.
This Description is awkward. Consider:
These files allow asserting system power cycling and switching power
supply units on and off.
> + The files are write only.
Please provide usage and resulting behavior.
--
Darren Hart
VMware Open Source Technology Center
g_io_attr_init(struct mlxreg_io_priv_data *priv)
...
> + for (i = 0; i < priv->pdata->counter; i++) {
> + priv->mlxreg_io_attr[i] =
> + &priv->mlxreg_io_dev_attr[i].dev_attr.attr;
> + memcpy(&priv->mlxreg_io_dev_attr[i].dev_attr,
> +&mlxreg_io_devattr_rw, sizeof(struct device_attribute));
> +
> + /* Set attribute name as a label. */
:-) OK, so this comment is rather obvious from the code but where
things are really opaque in the processing above, there are no comments.
Let's focus the comments where the code is non-obvious.
--
Darren Hart
VMware Open Source Technology Center
are defined per system type bases and includes the registers
> > > > related
> > > > + to system resets operation, system reset causes monitoring
> > > > and some
> > > > + kinds of mux selection.
> > >
> > > No Documentation/ABI/ entries for these new sysfs files? Not good :(
> > >
> >
> > Thanks Greg for your comment.
> >
> > Should I call doc file like:
> > Documentation/ABI/stable/sysfs-driver-mlxreg-io
> > ?
>
> What ever matches the naming scheme for the driver, yes.
Vadim, I'm happy to help out with the docs if you like.
Will you be able to document this in a static way, or is this likely to change
significantly from platform to platform? I ask because of the automated
attribute creation in the code.
--
Darren Hart
VMware Open Source Technology Center
r Darren's queue, but for some reason
> didn't processed yet.
Thanks for getting this one Andy. I'm traveling, but am working through these
currently. I'll assume you are handling this one.
--
Darren Hart
VMware Open Source Technology Center
want the
> "gitk" invocation if you are doing this automatically, of course. The
> script just takes a commit range.
Thanks for sharing Stephen.
--
Darren Hart
VMware Open Source Technology Center
On Sat, May 26, 2018 at 11:15:35AM +, Vadim Pasternak wrote:
>
>
> > -Original Message-
> > From: Darren Hart [mailto:dvh...@infradead.org]
> > Sent: Friday, May 25, 2018 3:31 AM
> > To: Vadim Pasternak
> > Cc: andy.shevche...@gmail.com; gre...
media who has also confirmed this
to solve
her camera issue with her Dell XPS 13 (I didn't get the specific model).
Took a looking at linux-next today, I didn't see it. Anything else needed to get
this queued up? We'd love to get this in the 4.18 merge window, and stable if
possible.
--
Darren Hart
VMware Open Source Technology Center
t; + mlxreg_io_attr_show;
> + priv->mlxreg_io_dev_attr[i].dev_attr.store =
> + mlxreg_io_attr_store;
> + break;
If this is necessary, we can simplify this by checking for the read mask and the
write mask and setting each once - rather than duplicating this for r, w, and
rw. As it is a 0400 would not assign the show function, even though it is
readable by somebody.
--
Darren Hart
VMware Open Source Technology Center
file;
Please remember to put the patch changelog below the --- line below.
> ---
Here
Queued up for testing, thanks.
--
Darren Hart
VMware Open Source Technology Center
#x27;d consider dependencies.
I've fixed the sha in the commit message, and queued for testing.
Thanks,
--
Darren Hart
VMware Open Source Technology Center
for this Kconfig to try and catch
more of this - and of course I've learned a few things to look out for
as well.
Thanks,
Darren Hart
VMware Open Source Technology Center
The following changes since commit 7fe3fa3b5ec8e75389cce4bf5d052a52e6198d59:
platform/x86: Kconfig: Fix dell-laptop depe
On Sat, May 12, 2018 at 11:51:02AM -0700, Randy Dunlap wrote:
> On 05/12/2018 11:32 AM, Darren Hart wrote:
> > On Sat, May 12, 2018 at 05:28:05PM +0800, kbuild test robot wrote:
> >> Hi Mario,
> >>
> >> FYI, the error/warning still remains.
> >>
>
tristate "Dell SMBIOS driver"
+ depends on DCDBAS || DCDBAS=n
--
Darren Hart
VMware Open Source Technology Center
Activation of Mellanox LED driver from mlx-platform.
>
> Introduction of new mlxreg-io driver.
>
> Activation of mlxreg-io driver from mlx-platform.
Patches 1,2 are queued up. Dropping 3-7 and reviewing them now from v2.
--
Darren Hart
VMware Open Source Technology Center
I was concerned because this override was a deliberate decision made in:
9705315b7562 selftests/futex: Update Makefile to use lib.mk
But reviewing lib.mk today, the RUN_TESTS and EMIT_TESTS perform the same
function running TEST_PROGS.
Reviewed-by: Darren Hart (VMware)
--
Darren Hart
VMw
On Fri, May 04, 2018 at 06:27:00PM +, mario.limoncie...@dell.com wrote:
> Darren,
>
> Is this with that fix of mine merged?
FYI: This fix has now been merged to linus/master.
--
Darren Hart
VMware Open Source Technology Center
nfiguration for
4.17 and 4.16 via stable.
Thanks,
Darren Hart
VMware Open Source Technology Center
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)
are available in the git repository at:
git://git.infradead.org/linux-p
1 - 100 of 1041 matches
Mail list logo
