Re: [PATCH] xfs: Remove noinline from #define STATIC

On Mon, Nov 12, 2018 at 09:31:51PM -0800, Joe Perches wrote: > On Tue, 2018-11-13 at 16:26 +1100, Dave Chinner wrote: > > On Mon, Nov 12, 2018 at 08:23:42PM -0800, Joe Perches wrote: > > > On Tue, 2018-11-13 at 14:09 +1100, Dave Chinner wrote: > > > > On Mon, Nov 12, 2018 at 08:54:10PM -0500,

Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c

On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote: Sorry, but all submissions must have a Signed-off-by: to be reviewed. Also, there's no To: header on this message?? NAK. --D > --- > fs/xfs/kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/kmem.c

Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c

On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote: Sorry, but all submissions must have a Signed-off-by: to be reviewed. Also, there's no To: header on this message?? NAK. --D > --- > fs/xfs/kmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/kmem.c

[GIT PULL] xfs: fixes for v4.20-rc2

Christophe JAILLET (1): xfs: Fix error code in 'xfs_ioc_getbmap()' Darrick J. Wong (1): xfs: print buffer offsets when dumping corrupt buffers Dave Chinner (1): xfs: fix overflow in xfs_attr3_leaf_verify fs/xfs/libxfs/xfs_attr_leaf.c | 11 +-- fs/xfs/xfs_ioctl.c

[GIT PULL] xfs: fixes for v4.20-rc2

Christophe JAILLET (1): xfs: Fix error code in 'xfs_ioc_getbmap()' Darrick J. Wong (1): xfs: print buffer offsets when dumping corrupt buffers Dave Chinner (1): xfs: fix overflow in xfs_attr3_leaf_verify fs/xfs/libxfs/xfs_attr_leaf.c | 11 +-- fs/xfs/xfs_ioctl.c

Re: Leaking Path in XFS's ioctl interface(missing LSM check)

On Mon, Oct 01, 2018 at 04:04:42PM +0100, Alan Cox wrote: > > /* only root can play with this */ > > if (!capable(CAP_SYS_ADMIN)) > > return -EACCES; > > > > Think about it - if DM control ioctls only require CAP_SYS_ADMIN, > > then if have that cap you can use DM

Re: Leaking Path in XFS's ioctl interface(missing LSM check)

On Mon, Oct 01, 2018 at 04:04:42PM +0100, Alan Cox wrote: > > /* only root can play with this */ > > if (!capable(CAP_SYS_ADMIN)) > > return -EACCES; > > > > Think about it - if DM control ioctls only require CAP_SYS_ADMIN, > > then if have that cap you can use DM

Re: [PATCH] xfs: remove duplicated include from alloc.c

On Tue, Sep 18, 2018 at 10:07:34AM +0800, YueHaibing wrote: > Remove duplicated include xfs_alloc.h > > Signed-off-by: YueHaibing Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/scrub/alloc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xf

Re: [PATCH] xfs: remove duplicated include from alloc.c

On Tue, Sep 18, 2018 at 10:07:34AM +0800, YueHaibing wrote: > Remove duplicated include xfs_alloc.h > > Signed-off-by: YueHaibing Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/scrub/alloc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xf

Re: [Patch] acpi_power_meter: remove 'ignoring unsafe software power cap' message

now. But /me shrugs and says, "eh, good enough". Also, nice to hear from you & lcm again. :) Reviewed-by: Darrick J. Wong --D > > Patch: Remove error message because it is generally misinterpreted. A > replacement > for the message is not necessary. > > Signed-of

Re: [Patch] acpi_power_meter: remove 'ignoring unsafe software power cap' message

now. But /me shrugs and says, "eh, good enough". Also, nice to hear from you & lcm again. :) Reviewed-by: Darrick J. Wong --D > > Patch: Remove error message because it is generally misinterpreted. A > replacement > for the message is not necessary. > > Signed-of

[GIT PULL] xfs: 4.19 merge, part 3

when monting. Darrick J. Wong (3): xfs: recalculate summary counters at mount time if icount is bad xfs: sanity check ag header values in xrep_calc_ag_resblks iomap: fix WARN_ON_ONCE on uninitialized variable fs

[GIT PULL] xfs: 4.19 merge, part 3

when monting. Darrick J. Wong (3): xfs: recalculate summary counters at mount time if icount is bad xfs: sanity check ag header values in xrep_calc_ag_resblks iomap: fix WARN_ON_ONCE on uninitialized variable fs

[GIT PULL] xfs: 4.19 merge, part 2

c xfs: remove the xfs_ifork_t typedef xfs: introduce a new xfs_inode_has_cow_data helper xfs: maintain a sequence count for inode fork manipulations xfs: avoid COW fork extent lookups in writeback if the fork didn't change xfs: use WRITE_ONCE to update if_seq Darrick

[GIT PULL] xfs: 4.19 merge, part 2

c xfs: remove the xfs_ifork_t typedef xfs: introduce a new xfs_inode_has_cow_data helper xfs: maintain a sequence count for inode fork manipulations xfs: avoid COW fork extent lookups in writeback if the fork didn't change xfs: use WRITE_ONCE to update if_seq Darrick

[GIT PULL] xfs: 4.19 merge, part 1

Hi Linus, This is the first part of the XFS changes for 4.19. Christoph and Andreas coordinated some refactoring work on the iomap code in preparation for removing buffer heads from XFS and porting gfs2 to iomap. I'm sending this small pull request ahead of the main XFS merge to avoid holding

[GIT PULL] xfs: 4.19 merge, part 1

Hi Linus, This is the first part of the XFS changes for 4.19. Christoph and Andreas coordinated some refactoring work on the iomap code in preparation for removing buffer heads from XFS and porting gfs2 to iomap. I'm sending this small pull request ahead of the main XFS merge to avoid holding

Re: [PATCH] iomap: Switch to offset_in_page for clarity

[add linux-xfs to cc] On Fri, Aug 10, 2018 at 04:56:27PM +0200, Andreas Gruenbacher wrote: > Instead of open-coding pos & (PAGE_SIZE - 1) and pos & ~PAGE_MASK, use > the offset_in_page macro. > > Signed-off-by: Andreas Gruenbacher Looks ok, will test... Reviewed-by: D

Re: [PATCH] iomap: Switch to offset_in_page for clarity

[add linux-xfs to cc] On Fri, Aug 10, 2018 at 04:56:27PM +0200, Andreas Gruenbacher wrote: > Instead of open-coding pos & (PAGE_SIZE - 1) and pos & ~PAGE_MASK, use > the offset_in_page macro. > > Signed-off-by: Andreas Gruenbacher Looks ok, will test... Reviewed-by: D

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 11:18:36AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 08:10:29AM -0700, Darrick J. Wong wrote: > > On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > > > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > Hi, > > > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > > dfops buffer relogging") removed the assignment of variable error: > > > > -

Re: xfs: cancel dfops on xfs_defer_finish() error

On Tue, Aug 07, 2018 at 10:37:21AM -0400, Brian Foster wrote: > On Tue, Aug 07, 2018 at 03:14:07PM +0100, Colin Ian King wrote: > > Hi, > > > > Recent commit 82ff27bc52a88cb5cc400bfa64e210d3ec8dfebd ("xfs: automatic > > dfops buffer relogging") removed the assignment of variable error: > > > > -

[GIT PULL] xfs: 4.18 fixes, part 3

Hi Linus, Here's one more patch for 4.18 to fix a coding error in the iomap_bmap function introduced in -rc1. This series has been run through a full xfstests run during the week and through a quick xfstests run against this morning's master, with no major failures reported. --D The following

[GIT PULL] xfs: 4.18 fixes, part 3

Hi Linus, Here's one more patch for 4.18 to fix a coding error in the iomap_bmap function introduced in -rc1. This series has been run through a full xfstests run during the week and through a quick xfstests run against this morning's master, with no major failures reported. --D The following

Re: [PATCH] xfs: fix a comment in xfs_log_reserve

On Fri, Aug 03, 2018 at 04:31:33PM +0800, Huang Chong wrote: > From: "Huang Chong" > > Fix the comment in xfs_log_reserve to avoid confusing. > > Signed-of-by: Huang Chong Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_log.c | 2 +- >

Re: [PATCH] xfs: fix a comment in xfs_log_reserve

On Fri, Aug 03, 2018 at 04:31:33PM +0800, Huang Chong wrote: > From: "Huang Chong" > > Fix the comment in xfs_log_reserve to avoid confusing. > > Signed-of-by: Huang Chong Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_log.c | 2 +- >

Re: [PATCH] xfs: substitute spaces with tabs

as Bianchi Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_attr_list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c > index f9ca801..a580340 100644 > --- a/fs/xfs/xfs_attr_list.c >

Re: [PATCH] xfs: substitute spaces with tabs

as Bianchi Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_attr_list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c > index f9ca801..a580340 100644 > --- a/fs/xfs/xfs_attr_list.c >

Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

On Fri, Jul 27, 2018 at 06:35:10PM +0100, David Howells wrote: > Add a system call to allow filesystem information to be queried. A request > value can be given to indicate the desired attribute. Support is provided > for enumerating multi-value attributes. > > === > NEW SYSTEM CALL

Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

On Fri, Jul 27, 2018 at 06:35:10PM +0100, David Howells wrote: > Add a system call to allow filesystem information to be queried. A request > value can be given to indicate the desired attribute. Support is provided > for enumerating multi-value attributes. > > === > NEW SYSTEM CALL

Re: Remounting filesystem read-only

On Fri, Jul 27, 2018 at 08:18:23PM -0400, Theodore Y. Ts'o wrote: > On Fri, Jul 27, 2018 at 01:34:31PM -0700, Sodagudi Prasad wrote: > > > The error should be pretty clear: "Inode table for bg 0 marked as > > > needing zeroing". That should never happen. > > > > Can you provide any debug patch

Re: Remounting filesystem read-only

On Fri, Jul 27, 2018 at 08:18:23PM -0400, Theodore Y. Ts'o wrote: > On Fri, Jul 27, 2018 at 01:34:31PM -0700, Sodagudi Prasad wrote: > > > The error should be pretty clear: "Inode table for bg 0 marked as > > > needing zeroing". That should never happen. > > > > Can you provide any debug patch

[GIT PULL] xfs: 4.18 fixes, part 2

Hi Linus, Here are a couple of late patches for 4.18 to fix a coding bug introduced in -rc1 and a fix for incorrect metadata verification of on-disk data. This series has been run through a full xfstests run over the weekend and through a quick xfstests run against this morning's master, with no

[GIT PULL] xfs: 4.18 fixes, part 2

Hi Linus, Here are a couple of late patches for 4.18 to fix a coding bug introduced in -rc1 and a fix for incorrect metadata verification of on-disk data. This series has been run through a full xfstests run over the weekend and through a quick xfstests run against this morning's master, with no

Re: [PATCH] fs: iomap: Change return type to vm_fault_t

On Fri, Jul 20, 2018 at 10:31:30AM +0530, Souptick Joarder wrote: > On Wed, Jul 4, 2018 at 3:22 AM, Andreas Gruenbacher > wrote: > > On 3 July 2018 at 23:39, Darrick J. Wong wrote: > >> On Mon, Jul 02, 2018 at 07:52:41PM +0200, Andreas Gruenbacher wrote: > >>>

Re: [PATCH] fs: iomap: Change return type to vm_fault_t

On Fri, Jul 20, 2018 at 10:31:30AM +0530, Souptick Joarder wrote: > On Wed, Jul 4, 2018 at 3:22 AM, Andreas Gruenbacher > wrote: > > On 3 July 2018 at 23:39, Darrick J. Wong wrote: > >> On Mon, Jul 02, 2018 at 07:52:41PM +0200, Andreas Gruenbacher wrote: > >>>

Re: [PATCH] xfs: use swap macro in xfs_dir2_leafn_rebalance

> > Signed-off-by: Gustavo A. R. Silva Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_dir2_node.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_dir2_node.c b/fs/xfs/li

Re: [PATCH] xfs: use swap macro in xfs_dir2_leafn_rebalance

> > Signed-off-by: Gustavo A. R. Silva Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_dir2_node.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_dir2_node.c b/fs/xfs/li

Re: linux-next: duplicate patches in the gfs2 and xfs trees

On Thu, Jul 12, 2018 at 07:16:18AM +0200, Andreas Gruenbacher wrote: > Hi Stephen, > > On 12 July 2018 at 06:41, Stephen Rothwell wrote: > > Hi Andreas, > > > > On Thu, 12 Jul 2018 04:30:07 +0200 Andreas Gruenbacher > > wrote: > >> > >> this is what I'm seeing (git log --pretty=oneline

Re: linux-next: duplicate patches in the gfs2 and xfs trees

On Thu, Jul 12, 2018 at 07:16:18AM +0200, Andreas Gruenbacher wrote: > Hi Stephen, > > On 12 July 2018 at 06:41, Stephen Rothwell wrote: > > Hi Andreas, > > > > On Thu, 12 Jul 2018 04:30:07 +0200 Andreas Gruenbacher > > wrote: > >> > >> this is what I'm seeing (git log --pretty=oneline

Re: [PATCH] xfs_attr_leaf: use swap macro in xfs_attr3_leaf_rebalance

> > Signed-off-by: Gustavo A. R. Silva Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_attr_leaf.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_

Re: [PATCH] xfs_attr_leaf: use swap macro in xfs_attr3_leaf_rebalance

> > Signed-off-by: Gustavo A. R. Silva Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_attr_leaf.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_

Re: [PATCH v2] xfs_bmap_util: use swap macro

> > Signed-off-by: Gustavo A. R. Silva Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > Changes in v2 > - Use swap in a couple more of places. > > fs/xfs/xfs_bmap_util.c | 28 +--- > 1 file changed, 5 insertions(+), 23 deletions(-) &

Re: [PATCH v2] xfs_bmap_util: use swap macro

> > Signed-off-by: Gustavo A. R. Silva Looks ok, will test... Reviewed-by: Darrick J. Wong --D > --- > Changes in v2 > - Use swap in a couple more of places. > > fs/xfs/xfs_bmap_util.c | 28 +--- > 1 file changed, 5 insertions(+), 23 deletions(-) &

Re: [PATCH] xfs_bmap_util: use swap macro

On Mon, Jul 09, 2018 at 09:05:39AM -0500, Gustavo A. R. Silva wrote: > Make use of the swap macro and remove some unnecessary variables. > This makes the code easier to read and maintain. Also, reduces the > stack usage. > > This code was detected with the help of Coccinelle. > > Signed-off-by:

Re: [PATCH] xfs_bmap_util: use swap macro

On Mon, Jul 09, 2018 at 09:05:39AM -0500, Gustavo A. R. Silva wrote: > Make use of the swap macro and remove some unnecessary variables. > This makes the code easier to read and maintain. Also, reduces the > stack usage. > > This code was detected with the help of Coccinelle. > > Signed-off-by:

Re: [PATCH] fs: iomap: Change return type to vm_fault_t

On Mon, Jul 02, 2018 at 07:52:41PM +0200, Andreas Gruenbacher wrote: > On 2 July 2018 at 17:43, Souptick Joarder wrote: > > Return type has been changed to vm_fault_t type for > > iomap_page_mkwrite(). > > > > see commit 1c8f422059ae ("mm: change return type to > > vm_fault_t") for reference. > >

Re: [PATCH] fs: iomap: Change return type to vm_fault_t

On Mon, Jul 02, 2018 at 07:52:41PM +0200, Andreas Gruenbacher wrote: > On 2 July 2018 at 17:43, Souptick Joarder wrote: > > Return type has been changed to vm_fault_t type for > > iomap_page_mkwrite(). > > > > see commit 1c8f422059ae ("mm: change return type to > > vm_fault_t") for reference. > >

Re: [PATCH 2/2] fs: xfs: use BUG_ON if writepage call comes from direct reclaim

UG_ON." in commit > 94054fa3fca1fd78db02cb3d68d5627120f0a1d4 ("xfs: warn if direct reclaim > tries to writeback pages"), > > It has been many years since that commit, so it should be safe to > elevate WARN_ON to BUG_ON now. > > Cc: Mel Gorman > Cc: Darrick J. Wong > C

Re: [PATCH 2/2] fs: xfs: use BUG_ON if writepage call comes from direct reclaim

UG_ON." in commit > 94054fa3fca1fd78db02cb3d68d5627120f0a1d4 ("xfs: warn if direct reclaim > tries to writeback pages"), > > It has been many years since that commit, so it should be safe to > elevate WARN_ON to BUG_ON now. > > Cc: Mel Gorman > Cc: Darrick J. Wong > C

[GIT PULL] xfs: 4.18 fixes, part 1

at eof - Fix accounting problems with per-ag reservations causing statfs reports to vary incorrectly Christoph Hellwig (1): xfs: simplify xfs_bmap_punch_delalloc_range Darrick J. Wong (8): xfs: allow empty transactions

[GIT PULL] xfs: 4.18 fixes, part 1

at eof - Fix accounting problems with per-ag reservations causing statfs reports to vary incorrectly Christoph Hellwig (1): xfs: simplify xfs_bmap_punch_delalloc_range Darrick J. Wong (8): xfs: allow empty transactions

Re: [RFC PATCH 0/5] kbuild: build modules from code in multiple directories.

On Mon, Jun 18, 2018 at 09:47:48PM -0700, Christoph Hellwig wrote: > On Tue, Jun 19, 2018 at 02:05:23PM +1000, NeilBrown wrote: > > From: NeilBrown > > Date: Tue, 19 Jun 2018 13:59:16 +1000 > > Subject: [PATCH] kbuild/xfs: example modobj-m conversion > > > > This is a demonstration patch to show

Re: [RFC PATCH 0/5] kbuild: build modules from code in multiple directories.

On Mon, Jun 18, 2018 at 09:47:48PM -0700, Christoph Hellwig wrote: > On Tue, Jun 19, 2018 at 02:05:23PM +1000, NeilBrown wrote: > > From: NeilBrown > > Date: Tue, 19 Jun 2018 13:59:16 +1000 > > Subject: [PATCH] kbuild/xfs: example modobj-m conversion > > > > This is a demonstration patch to show

[GIT PULL] xfs: 4.18 merge, part 2

set functions Darrick J. Wong (15): xfs: don't forbid setting dax flag on directories if device doesn't dax xfs: don't assert when reporting on-disk corruption while loading btree xfs: remove redundant ASSERT on insufficient bestfree length in _leaf_addname xfs: xfs_alloc_get_

[GIT PULL] xfs: 4.18 merge, part 2

set functions Darrick J. Wong (15): xfs: don't forbid setting dax flag on directories if device doesn't dax xfs: don't assert when reporting on-disk corruption while loading btree xfs: remove redundant ASSERT on insufficient bestfree length in _leaf_addname xfs: xfs_alloc_get_

Re: [PATCH 02/39] vfs: dedupe: rationalize args

loff_t, size_t, unsigned int); > int (*clone_file_range)(struct file *, loff_t, struct file *, loff_t, > u64); > - loff_t (*dedupe_file_range)(struct file *, u64, u64, struct file *, > - u64); > + loff_t (*dedupe_file_range)(struct file *, loff_t, > + struct file *, loff_t, loff_t); > } __randomize_layout; XFS/vfs parts look ok, Reviewed-by: Darrick J. Wong --D > > struct inode_operations { > -- > 2.14.3 >

Re: [PATCH 02/39] vfs: dedupe: rationalize args

loff_t, size_t, unsigned int); > int (*clone_file_range)(struct file *, loff_t, struct file *, loff_t, > u64); > - loff_t (*dedupe_file_range)(struct file *, u64, u64, struct file *, > - u64); > + loff_t (*dedupe_file_range)(struct file *, loff_t, > + struct file *, loff_t, loff_t); > } __randomize_layout; XFS/vfs parts look ok, Reviewed-by: Darrick J. Wong --D > > struct inode_operations { > -- > 2.14.3 >

Re: [PATCH V2] xfs: fix string handling in get/set functions

t;) > Cc: Eric Sandeen > Cc: Martin Sebor > Signed-off-by: Arnd Bergmann > Signed-off-by: Eric Sandeen Working around strncpy warnings with memcpy? I guess... Reviewed-by: Darrick J. Wong --D > --- > > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > ind

Re: [PATCH V2] xfs: fix string handling in get/set functions

t;) > Cc: Eric Sandeen > Cc: Martin Sebor > Signed-off-by: Arnd Bergmann > Signed-off-by: Eric Sandeen Working around strncpy warnings with memcpy? I guess... Reviewed-by: Darrick J. Wong --D > --- > > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > ind

[GIT PULL] xfs: 4.18 merge, part 1

remove the buffer_unwritten check in page_seek_hole_data fs: use ->is_partially_uptodate in page_cache_seek_hole_data Darrick J. Wong (54): xfs: bmap debugging should never panic the system xfs: add missing rmap error return xfs: release new dquot buffer on defer_finish error

[GIT PULL] xfs: 4.18 merge, part 1

remove the buffer_unwritten check in page_seek_hole_data fs: use ->is_partially_uptodate in page_cache_seek_hole_data Darrick J. Wong (54): xfs: bmap debugging should never panic the system xfs: add missing rmap error return xfs: release new dquot buffer on defer_finish error

Re: linux-next: Signed-off-by missing for commit in the xfs tree

On Tue, Jun 05, 2018 at 08:03:40AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 1e7fb5893364 ("xfs_repair: check and repair quota metadata") > > is missing a Signed-off-by from its committer. Oops, yeah, I just backported that over from xfsprogs, will fix it up. Thanks for

Re: linux-next: Signed-off-by missing for commit in the xfs tree

On Tue, Jun 05, 2018 at 08:03:40AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 1e7fb5893364 ("xfs_repair: check and repair quota metadata") > > is missing a Signed-off-by from its committer. Oops, yeah, I just backported that over from xfsprogs, will fix it up. Thanks for

Re: linux-next: manual merge of the nvdimm tree with the xfs tree

On Fri, Jun 01, 2018 at 06:58:46PM +1000, Stephen Rothwell wrote: > Hi Dan, > > Today's linux-next merge of the nvdimm tree got a conflict in: > > drivers/dax/super.c > > between commits: > > ba23cba9b3bd ("fs: allow per-device dax status checking for filesystems") > 80660f20252d ("dax:

Re: linux-next: manual merge of the nvdimm tree with the xfs tree

On Fri, Jun 01, 2018 at 06:58:46PM +1000, Stephen Rothwell wrote: > Hi Dan, > > Today's linux-next merge of the nvdimm tree got a conflict in: > > drivers/dax/super.c > > between commits: > > ba23cba9b3bd ("fs: allow per-device dax status checking for filesystems") > 80660f20252d ("dax:

[GIT PULL] xfs: hair on fire fixes for 4.17-rc7

. Darrick J. Wong (1): fs: clear writeback errors in inode_init_always fs/inode.c | 1 + 1 file changed, 1 insertion(+)

[GIT PULL] xfs: hair on fire fixes for 4.17-rc7

. Darrick J. Wong (1): fs: clear writeback errors in inode_init_always fs/inode.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH][next] aio: fix missing break in switch statement

> to make sense. Fix this by adding the break back again. > > Detected by CoverityScan, CID#1469469 ("Missing break in switch") > > Fixes: 2c14fa838cbe ("aio: implement IOCB_CMD_POLL") > Signed-off-by: Colin Ian King Makes sense to me... Reviewed-by: Dar

Re: [PATCH][next] aio: fix missing break in switch statement

> to make sense. Fix this by adding the break back again. > > Detected by CoverityScan, CID#1469469 ("Missing break in switch") > > Fixes: 2c14fa838cbe ("aio: implement IOCB_CMD_POLL") > Signed-off-by: Colin Ian King Makes sense to me... Reviewed-by: Dar

Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems

On Fri, May 25, 2018 at 09:42:29AM -0600, Ross Zwisler wrote: > On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote: > > On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote: > > > From: "Darrick J. Wong" <darrick.w...@oracle.com> > &

Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems

On Fri, May 25, 2018 at 09:42:29AM -0600, Ross Zwisler wrote: > On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote: > > On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote: > > > From: "Darrick J. Wong" > > > > &g

Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems

On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote: > From: "Darrick J. Wong" <darrick.w...@oracle.com> > > Remove __bdev_dax_supported and change to bdev_dax_supported that takes a > bdev parameter. This enables multi-device filesystems like xfs to check

Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems

On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote: > From: "Darrick J. Wong" > > Remove __bdev_dax_supported and change to bdev_dax_supported that takes a > bdev parameter. This enables multi-device filesystems like xfs to check > that a dax device ca

Re: [PATCH 2/7] dax: change bdev_dax_supported() to support boolean returns

e code very confusing. Changing the return values > to return a bool where if DAX is supported then return true and no DAX > support returns false. > > Signed-off-by: Dave Jiang <dave.ji...@intel.com> > Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> L

Re: [PATCH 2/7] dax: change bdev_dax_supported() to support boolean returns

ging the return values > to return a bool where if DAX is supported then return true and no DAX > support returns false. > > Signed-off-by: Dave Jiang > Signed-off-by: Ross Zwisler Looks ok, Reviewed-by: Darrick J. Wong --D > --- > drivers/dax/super.c | 16

Re: [REVIEW][PATCH 0/6] Wrapping up the vfs support for unprivileged mounts

On Fri, May 25, 2018 at 01:57:16PM +1000, Dave Chinner wrote: > On Thu, May 24, 2018 at 06:23:30PM -0500, Eric W. Biederman wrote: > > "Theodore Y. Ts'o" writes: > > > > > On Wed, May 23, 2018 at 06:22:56PM -0500, Eric W. Biederman wrote: > > >> > > >> Very slowly the work has

Re: [REVIEW][PATCH 0/6] Wrapping up the vfs support for unprivileged mounts

On Fri, May 25, 2018 at 01:57:16PM +1000, Dave Chinner wrote: > On Thu, May 24, 2018 at 06:23:30PM -0500, Eric W. Biederman wrote: > > "Theodore Y. Ts'o" writes: > > > > > On Wed, May 23, 2018 at 06:22:56PM -0500, Eric W. Biederman wrote: > > >> > > >> Very slowly the work has been progressing

Re: INFO: task hung in xlog_grant_head_check

On Tue, May 22, 2018 at 03:52:08PM -0700, Eric Biggers wrote: > On Wed, May 23, 2018 at 08:26:20AM +1000, Dave Chinner wrote: > > On Tue, May 22, 2018 at 08:31:08AM -0400, Brian Foster wrote: > > > On Mon, May 21, 2018 at 10:55:02AM -0700, syzbot wrote: > > > > Hello, > > > > > > > > syzbot found

Re: INFO: task hung in xlog_grant_head_check

On Tue, May 22, 2018 at 03:52:08PM -0700, Eric Biggers wrote: > On Wed, May 23, 2018 at 08:26:20AM +1000, Dave Chinner wrote: > > On Tue, May 22, 2018 at 08:31:08AM -0400, Brian Foster wrote: > > > On Mon, May 21, 2018 at 10:55:02AM -0700, syzbot wrote: > > > > Hello, > > > > > > > > syzbot found

Re: [PATCH 11/12] xfs: convert to bioset_init()/mempool_init()

On Sun, May 20, 2018 at 06:25:57PM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet <kent.overstr...@gmail.com> Looks ok, I guess... Acked-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/xfs/xfs_aops.c | 2 +- > fs/xfs/xfs_aops.h | 2 +- &g

Re: [PATCH 11/12] xfs: convert to bioset_init()/mempool_init()

On Sun, May 20, 2018 at 06:25:57PM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Looks ok, I guess... Acked-by: Darrick J. Wong --D > --- > fs/xfs/xfs_aops.c | 2 +- > fs/xfs/xfs_aops.h | 2 +- > fs/xfs/xfs_super.c | 11 +-- > 3 files changed,

Re: [PATCH 14/14] mm: turn on vm_fault_t type checking

ricate problems with > sparse. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- For the iomap and xfs parts, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> That said... > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 54f1e05ecf

Re: [PATCH 14/14] mm: turn on vm_fault_t type checking

ricate problems with > sparse. > > Signed-off-by: Christoph Hellwig > --- For the iomap and xfs parts, Reviewed-by: Darrick J. Wong That said... > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 54f1e05ecf3e..da2b77a19911 100644 > --- a/include/linux/mm_type

Re: [RFC v2 2/4] xfs: add verifier check for symlink with append/immutable flags

On Thu, May 10, 2018 at 04:13:57PM -0700, Luis R. Rodriguez wrote: > The Linux VFS does not allow a way to set append/immuttable attributes > to symlinks, this is just not possible. If this is detected we can > correct this with xfs_repair, so inform the user. > > Signed-off-by: Luis R. Rodriguez

Re: [RFC v2 2/4] xfs: add verifier check for symlink with append/immutable flags

On Thu, May 10, 2018 at 04:13:57PM -0700, Luis R. Rodriguez wrote: > The Linux VFS does not allow a way to set append/immuttable attributes > to symlinks, this is just not possible. If this is detected we can > correct this with xfs_repair, so inform the user. > > Signed-off-by: Luis R. Rodriguez

Re: [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

_fixed_metadata’ [-Wmissing-prototypes] > > Signed-off-by: Mathieu Malaterre <ma...@debian.org> Sorry about being late to the party, Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > --- > fs/ext4/fsmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH] ext4: make function ‘ext4_getfsmap_find_fixed_metadata’ static

_fixed_metadata’ [-Wmissing-prototypes] > > Signed-off-by: Mathieu Malaterre Sorry about being late to the party, Reviewed-by: Darrick J. Wong --D > --- > fs/ext4/fsmap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/fsmap.c b/

Re: vmalloc with GFP_NOFS

On Wed, May 09, 2018 at 11:04:47PM +0200, Michal Hocko wrote: > On Wed 09-05-18 08:13:51, Darrick J. Wong wrote: > > On Wed, May 09, 2018 at 03:42:22PM +0200, Michal Hocko wrote: > > > On Tue 24-04-18 13:25:42, Michal Hocko wrote: > > > [...] > > >

Re: vmalloc with GFP_NOFS

On Wed, May 09, 2018 at 11:04:47PM +0200, Michal Hocko wrote: > On Wed 09-05-18 08:13:51, Darrick J. Wong wrote: > > On Wed, May 09, 2018 at 03:42:22PM +0200, Michal Hocko wrote: > > > On Tue 24-04-18 13:25:42, Michal Hocko wrote: > > > [...] > > >

Re: vmalloc with GFP_NOFS

lems. Sometimes if the context is not really clear or there are > layering violations then the recommended way around that is to wrap > ``vmalloc`` > by the scope API with a comment explaining the problem. Otherwise looks ok to me based on my understanding of how all this is supposed to work... Reviewed-by: Darrick J. Wong <darrick.w...@oracle.com> --D > -- > Michal Hocko > SUSE Labs

Re: vmalloc with GFP_NOFS

text is not really clear or there are > layering violations then the recommended way around that is to wrap > ``vmalloc`` > by the scope API with a comment explaining the problem. Otherwise looks ok to me based on my understanding of how all this is supposed to work... Reviewed-by: Darrick J. Wong --D > -- > Michal Hocko > SUSE Labs

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Wed, May 09, 2018 at 12:38:55AM +, Luis R. Rodriguez wrote: > On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote: > > On Wed, May 09, 2018 at 12:03:28AM +, Luis R. Rodriguez wrote: > > > Groovy, thanks, let's not forget the xfs_repair respective fix :)

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Wed, May 09, 2018 at 12:38:55AM +, Luis R. Rodriguez wrote: > On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote: > > On Wed, May 09, 2018 at 12:03:28AM +, Luis R. Rodriguez wrote: > > > Groovy, thanks, let's not forget the xfs_repair respective fix :)

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Wed, May 09, 2018 at 12:03:28AM +, Luis R. Rodriguez wrote: > On Mon, May 07, 2018 at 05:30:55PM -0700, Darrick J. Wong wrote: > > On Tue, May 01, 2018 at 05:45:12PM +, Luis R. Rodriguez wrote: > > > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote: >

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Wed, May 09, 2018 at 12:03:28AM +, Luis R. Rodriguez wrote: > On Mon, May 07, 2018 at 05:30:55PM -0700, Darrick J. Wong wrote: > > On Tue, May 01, 2018 at 05:45:12PM +, Luis R. Rodriguez wrote: > > > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote: >

Re: [PATCH v2 21/35] ovl: add reflink/copyfile/dedup support

On Tue, May 08, 2018 at 04:13:01PM +0200, Miklos Szeredi wrote: > On Mon, May 7, 2018 at 10:43 PM, Darrick J. Wong > <darrick.w...@oracle.com> wrote: > > On Mon, May 07, 2018 at 10:37:53AM +0200, Miklos Szeredi wrote: > >> Since set of arguments are so similar

Re: [PATCH v2 21/35] ovl: add reflink/copyfile/dedup support

On Tue, May 08, 2018 at 04:13:01PM +0200, Miklos Szeredi wrote: > On Mon, May 7, 2018 at 10:43 PM, Darrick J. Wong > wrote: > > On Mon, May 07, 2018 at 10:37:53AM +0200, Miklos Szeredi wrote: > >> Since set of arguments are so similar, handle in a common helper. > >&

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Tue, May 01, 2018 at 05:45:12PM +, Luis R. Rodriguez wrote: > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote: > > On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote: > > > Linux filesystems cannot set extra file attributes (stx_attributes as

<    1   2   3   4   5   6   7   8   9   10   >