Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread David E. Box
On Sat, 2021-04-17 at 10:52 +0200, Hans de Goede wrote: > Hi David, > > On 4/17/21 5:12 AM, David E. Box wrote: > > From: Gayatri Kammela > > > > Platforms that support low power modes (LPM) such as Tiger Lake > > maintain > > requirements for ea

Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread David E. Box
On Sat, 2021-04-17 at 11:00 +0200, Hans de Goede wrote: > Hi, > > On 4/17/21 5:12 AM, David E. Box wrote: > > From: Gayatri Kammela > > > > Platforms that support low power modes (LPM) such as Tiger Lake > > maintain > > requirements for each sub-state

[PATCH V2 2/9] platform/x86: intel_pmc_core: Remove global struct pmc_dev

2021-04-16 Thread David E. Box
the global pmc_dev in favor of one that is allocated during probe. Modify users of the global to obtain the object by argument instead. Signed-off-by: David E. Box Reviewed-by: Hans de Goede Reviewed-by: Rajneesh Bhardwaj --- V2: No change drivers/platform/x86/intel_pmc_core.c | 41

[PATCH V2 3/9] platform/x86: intel_pmc_core: Handle sub-states generically

2021-04-16 Thread David E. Box
howing all possible ones. After this patch, the debugfs file looks like this: Substate Residency S0i2.0 0 S0i3.0 0 S0i2.1 9329279 S0i3.1 0 S0i3.2 0 Suggested-by: David E. Box Signed-off-by: Gayatri Kammela Signed-off-by: David E. Box Reviewed-by: Hans de Goede Acked-by

[PATCH V2 7/9] platform/x86: intel_pmc_core: Add option to set/clear LPM mode

2021-04-16 Thread David E. Box
. Clearing the status registers before testing removes ambiguity around when the current values were set. The new file, latch_lpm_mode, looks like this: [c10] S0i2.0 S0i3.0 S0i2.1 S0i3.1 S0i3.2 clear Signed-off-by: David E. Box Reviewed-by: Hans de Goede --- V2: - Rebase on Tamar

[PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-16 Thread David E. Box
the requirements for Tiger Lake using the _DSM method and store in a buffer. Signed-off-by: Gayatri Kammela Co-developed-by: David E. Box Signed-off-by: David E. Box Reviewed-by: Hans de Goede --- V2: - Move buffer allocation so that it does not need to be freed (which was missing anyway) when

[PATCH V2 6/9] platform/x86: intel_pmc_core: Add requirements file to debugfs

2021-04-16 Thread David E. Box
| | Required | | Required | Required | | Signed-off-by: Gayatri Kammela Co-developed-by: David E. Box Signed-off-by: David E. Box Reviewed-by: Hans de Goede --- V2: No change drivers/platform/x86/intel_pmc_core.c | 86 +++ 1 file changed

[PATCH V2 9/9] platform/x86: intel_pmc_core: Add support for Alder Lake PCH-P

2021-04-16 Thread David E. Box
Alder PCH-P is based on Tiger Lake PCH. Signed-off-by: David E. Box Reviewed-by: Hans de Goede Acked-by: Rajneesh Bhardwaj --- V2: No change drivers/platform/x86/intel_pmc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers

[PATCH V2 8/9] platform/x86: intel_pmc_core: Add LTR registers for Tiger Lake

2021-04-16 Thread David E. Box
-by: Gayatri Kammela Signed-off-by: David E. Box Reviewed-by: Hans de Goede Acked-by: Rajneesh Bhardwaj --- V2: No change drivers/platform/x86/intel_pmc_core.c | 2 ++ drivers/platform/x86/intel_pmc_core.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform

[PATCH V2 4/9] platform/x86: intel_pmc_core: Show LPM residency in microseconds

2021-04-16 Thread David E. Box
-by: Gayatri Kammela Signed-off-by: David E. Box Reviewed-by: Hans de Goede Reviewed-by: Rajneesh Bhardwaj --- V2: No change drivers/platform/x86/intel_pmc_core.c | 14 -- drivers/platform/x86/intel_pmc_core.h | 3 +++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git

[PATCH V2 1/9] platform/x86: intel_pmc_core: Don't use global pmcdev in quirks

2021-04-16 Thread David E. Box
condition is met. This allows removing the global pmc_dev later. Signed-off-by: David E. Box Reviewed-by: Hans de Goede Reviewed-by: Rajneesh Bhardwaj --- V2: No change drivers/platform/x86/intel_pmc_core.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git

[PATCH V2 0/9] intel_pmc_core: Add sub-state requirements and mode

2021-04-16 Thread David E. Box
- Patch 9 adds support for ADL-P which is based on TGL Applied on top of latest hans-review/review-hans Patches that changed in V2: Patch 3: Variable name change Patch 5: Do proper cleanup after fail Patch 7: Debugfs write function fixes David E. Box (4): platform/x86

Re: [PATCH 6/9] platform/x86: intel_pmc_core: Add requirements file to debugfs

2021-04-07 Thread David E. Box
On Wed, 2021-04-07 at 11:45 -0400, Rajneesh Bhardwaj wrote: > On Wed, Mar 31, 2021 at 11:06 PM David E. Box > wrote: > > > > From: Gayatri Kammela > > > > Add the debugfs file, substate_requirements, to view the low power > > mode > > (LPM) requirement

Re: [PATCH 7/9] platform/x86: intel_pmc_core: Add option to set/clear LPM mode

2021-04-07 Thread David E. Box
Hi Hans. Ack on your comments for this series. Questions answered below. On Wed, 2021-04-07 at 16:37 +0200, Hans de Goede wrote: > Hi, > > On 4/1/21 5:05 AM, David E. Box wrote: > > By default the Low Power Mode (LPM or sub-state) status registers > > will > > latc

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread David E. Box
7 > > > > > +++++++++++ > > > > >  drivers/platform/x86/intel_pmc_core.h |  6 ++ > > > > >  4 files changed, 115 insertions(+) > > > > >  create mode 100644 > > > > > Documentation/ABI/testing/sysfs-pla

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-06 Thread David E. Box
ce you're adding the same new register as I am. > > Documentation/ABI/testing/sysfs-platform-intel-pmc > > File ? > > Regards, > > Hans > > > > > > > The register in MMIO space is defined for Cannon Lake and newer PCHs. > > > > C

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread David E. Box
Hi Tomas, I have a patch set that also adds the ETR3 register, although for an entirely different purpose. It doesn't touch the same bits. But your patch can be taken as is. I'll rebase on top of this one. Thanks. Reviewed-by: David E Box On Fri, 2021-04-02 at 18:21 +0300, Tomas Winkler wrote

[PATCH 4/9] platform/x86: intel_pmc_core: Show LPM residency in microseconds

2021-03-31 Thread David E. Box
-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 14 -- drivers/platform/x86/intel_pmc_core.h | 3 +++ 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c

[PATCH 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-03-31 Thread David E. Box
the requirements for Tiger Lake using the _DSM method and store in a buffer. Signed-off-by: Gayatri Kammela Co-developed-by: David E. Box Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 49 +++ drivers/platform/x86/intel_pmc_core.h | 2 ++ 2 files changed, 51

[PATCH 0/9] intel_pmc_core: Add sub-state requirements and mode latching support

2021-03-31 Thread David E. Box
- Patch 9 adds support for ADL-P which is based on TGL Applied on top of latest 5.12-rc2 based hans-review/review-hans David E. Box (4): platform/x86: intel_pmc_core: Don't use global pmcdev in quirks platform/x86: intel_pmc_core: Remove global struct pmc_dev platform/x86: intel_pmc_core: Add

[PATCH 3/9] platform/x86: intel_pmc_core: Handle sub-states generically

2021-03-31 Thread David E. Box
howing all possible ones. After this patch, the debugfs file looks like this: Substate Residency S0i2.0 0 S0i3.0 0 S0i2.1 9329279 S0i3.1 0 S0i3.2 0 Suggested-by: David E. Box Signed-off-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_c

[PATCH 8/9] platform/x86: intel_pmc_core: Add LTR registers for Tiger Lake

2021-03-31 Thread David E. Box
-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 2 ++ drivers/platform/x86/intel_pmc_core.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index

[PATCH 7/9] platform/x86: intel_pmc_core: Add option to set/clear LPM mode

2021-03-31 Thread David E. Box
. Clearing the status registers before testing removes ambiguity around when the current values were set. The new file, latch_lpm_mode, looks like this: [c10] S0i2.0 S0i3.0 S0i2.1 S0i3.1 S0i3.2 clear Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 94

[PATCH 9/9] platform/x86: intel_pmc_core: Add support for Alder Lake PCH-P

2021-03-31 Thread David E. Box
Alder PCH-P is based on Tiger Lake PCH. Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index 9168062c927e..88d582df829f 100644 --- a/drivers

[PATCH 1/9] platform/x86: intel_pmc_core: Don't use global pmcdev in quirks

2021-03-31 Thread David E. Box
condition is met. This allows removing the global pmc_dev later. Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c

[PATCH 2/9] platform/x86: intel_pmc_core: Remove global struct pmc_dev

2021-03-31 Thread David E. Box
the global pmc_dev in favor of one that is allocated during probe. Modify users of the global to obtain the object by argument instead. Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 41 ++- 1 file changed, 21 insertions(+), 20 deletions(-) diff

[PATCH 6/9] platform/x86: intel_pmc_core: Add requirements file to debugfs

2021-03-31 Thread David E. Box
| | Required | | Required | Required | | Signed-off-by: Gayatri Kammela Co-developed-by: David E. Box Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 86 +++ 1 file changed, 86 insertions(+) diff --git a/drivers/platform

Re: [PATCH 1/2] platform/x86: intel_pmt_class: Initial resource to 0

2021-03-23 Thread David E. Box
On Tue, 2021-03-16 at 19:44 -0700, David E. Box wrote: > Initialize the struct resource in intel_pmt_dev_register to zero to > avoid a > fault should the char *name field be non-zero. Hi Hans. Can these 2 patches be pulled as fixes for 5.12? Thanks. David > > Signed-off-b

[PATCH 2/2] platform_x86: intel_pmt_crashlog: Fix incorrect macros

2021-03-16 Thread David E. Box
Fixes off-by-one bugs in the macro assignments for the crashlog control bits. Was initially tested on emulation but bug revealed after testing on silicon. Fixes: 5ef9998c96b0 ("platform/x86: Intel PMT Crashlog capability driver") Signed-off-by: David E. Box --- drivers/pl

[PATCH 1/2] platform/x86: intel_pmt_class: Initial resource to 0

2021-03-16 Thread David E. Box
Initialize the struct resource in intel_pmt_dev_register to zero to avoid a fault should the char *name field be non-zero. Signed-off-by: David E. Box --- Base commit is v5.12-rc3. drivers/platform/x86/intel_pmt_class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH V3 1/2] MFD: intel_pmt: Fix nuisance messages and handling of disabled capabilities

2021-03-09 Thread David E. Box
capabilities are found. Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support") Signed-off-by: David E. Box Reviewed-by: Hans de Goede --- No change from V2 drivers/mfd/intel_pmt.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/d

[PATCH V3 2/2] MFD: intel_pmt: Add support for DG1

2021-03-09 Thread David E. Box
-by: David E. Box --- Changes from V2: - Use declared variable Changes from V1: - New patch drivers/mfd/intel_pmt.c| 101 +++-- drivers/platform/x86/intel_pmt_class.c | 46 ++ drivers/platform/x86/intel_pmt_class.h | 1 + drivers

Re: [PATCH 2/2 V2] MFD: intel_pmt: Add support for DG1

2021-03-09 Thread David E. Box
On Tue, 2021-03-09 at 16:45 +, Lee Jones wrote: > On Wed, 24 Feb 2021, David E. Box wrote: > > > Adds PMT Telemetry aggregator support for the DG1 graphics PCIe > > card. The > > device does not have the DVSEC region in its PCI config space so > > hard >

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread David E. Box
On Mon, 2021-03-08 at 18:02 +, Limonciello, Mario wrote: > > > > -Original Message- > > From: Rajneesh Bhardwaj > > Sent: Monday, March 8, 2021 11:32 > > To: Limonciello, Mario > > Cc: David E. Box; hdego...@redhat.com; mgr...@linux.intel.com;

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread David E. Box
Hi Rajneesh, On Mon, 2021-03-08 at 09:04 -0500, Rajneesh Bhardwaj wrote: > Hi David > > Overall, it looks like the right thing to do but i have a few > comments. See below. > > On Fri, Mar 5, 2021 at 2:07 PM David E. Box < > david.e@linux.intel.com> wrote: >

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-07 Thread David E. Box
Hi Sasha, On Sun, 2021-03-07 at 10:39 +0200, Neftin, Sasha wrote: > On 3/5/2021 21:06, David E. Box wrote: > > Due to a HW limitation, the Latency Tolerance Reporting (LTR) value > > programmed in the Tiger Lake GBE controller is not large enough to > > allow > > the pl

[PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-05 Thread David E. Box
on Tiger Lake. LTR ignore functionality is currently performed solely by a debugfs write call. Split out the LTR code into its own function that can be called by both the debugfs writer and by this work around. Signed-off-by: David E. Box Reviewed-by: Sasha Neftin Cc: intel-wired

Re: [PATCH V2 1/2] MFD: intel_pmt: Fix nuisance messages and handling of disabled capabilities

2021-02-24 Thread David E. Box
On Wed, 2021-02-24 at 21:22 +0100, Hans de Goede wrote: > Hi, > > On 2/24/21 9:10 PM, David E. Box wrote: > > Some products will be available that have PMT capabilities that are > > not > > supported. Remove the warnings in this instance to avoid nuisance >

[PATCH V2 1/2] MFD: intel_pmt: Fix nuisance messages and handling of disabled capabilities

2021-02-24 Thread David E. Box
capabilities are found. Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support") Signed-off-by: David E. Box Reviewed-by: Hans de Goede --- For merge in platform-drivers-x86 Based on 5.11-rc1 review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx8

[PATCH 2/2 V2] MFD: intel_pmt: Add support for DG1

2021-02-24 Thread David E. Box
-by: David E. Box --- Based on 5.11-rc1 review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Changes from V1: - New patch drivers/mfd/intel_pmt.c| 101 +++-- drivers/platform/x86

[PATCH] MFD: intel_pmt: Fix nuisance messages and handling of disabled capabilities

2021-01-28 Thread David E. Box
capabilities are found. Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support") Signed-off-by: David E. Box --- drivers/mfd/intel_pmt.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd/intel_p

[PATCH 3/3] platform/x86: intel_pmt_crashlog: Add dependency on MFD_INTEL_PMT

2021-01-26 Thread David E. Box
All devices that expose Intel Platform Monitoring Technology (PMT) crashlog are currently owned by the intel_pmt MFD driver. Therefore make the crashlog driver depend on the MFD driver for build. Fixes: 5ef9998c96b0 ("platform/x86: Intel PMT Crashlog capability driver") Signed-off-b

[PATCH 2/3] platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT

2021-01-26 Thread David E. Box
All devices that expose Intel Platform Monitoring Technology (PMT) telemetry are currently owned by the intel_pmt MFD driver. Therefore make the telemetry driver depend on the MFD driver for build. Fixes: 68fe8e6e2c4b ("platform/x86: Intel PMT Telemetry capability driver") Signed-off-b

[PATCH 1/3] platform/x86: intel_pmt: Make INTEL_PMT_CLASS non-user-selectable

2021-01-26 Thread David E. Box
Fix error in Kconfig that exposed INTEL_PMT_CLASS as a user selectable option. It is already selected by INTEL_PMT_TELEMETRY and INTEL_PMT_CRASHLOG which are user selectable. Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver") Signed-off-by: David E. Box --- drivers/pl

Re: [PATCH] PCI: Save/restore L1 PM Substate extended capability registers

2020-12-09 Thread David E. Box
ar > > On 12/9/2020 3:36 AM, David E. Box wrote: > > External email: Use caution opening links or attachments > > > > > > On Intel systems that support ACPI Low Power Idle it has been > > observed > > that the L1 Substate capability can return disabled afte

[PATCH] PCI: Save/restore L1 PM Substate extended capability registers

2020-12-08 Thread David E. Box
-off-by: David E. Box --- drivers/pci/pci.c | 49 +++ 1 file changed, 49 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index e578d34095e9..beee3d9952a6 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1539,6 +1539,48 @@ static

[PATCH v2 2/2] PCI: Disable PTM during suspend to save power

2020-12-07 Thread David E. Box
-by: Len Brown Suggested-by: Rafael J. Wysocki Signed-off-by: David E. Box --- Changes from V1: - Add pci_disable_ptm() to ptm.c - Move ptm disabling from pci_save_ptm_state() to pci_prepare_to_sleep() and pci_finish_runtime_suspend() as suggested by Rafael

[PATCH v2 1/2] Add save/restore of Precision Time Measurement capability

2020-12-07 Thread David E. Box
of the PTM control register. This saves the PTM Enable, Root Select, and Effective Granularity bits. Suggested-by: Rafael J. Wysocki Signed-off-by: David E. Box --- Changes from V1: - Move save/restore functions to ptm.c - Move pci_add_ext_cap_sve_buffer() to pci_ptm_init in ptm.c

Re: [PATCH 2/2] PCI: Disable Precision Time Measurement during suspend

2020-11-19 Thread David E. Box
On Thu, 2020-11-19 at 19:13 +0100, Rafael J. Wysocki wrote: > On Thu, Nov 19, 2020 at 6:45 PM David E. Box > wrote: > > On Thu, 2020-11-19 at 13:01 +0100, Rafael J. Wysocki wrote: > > > On Thu, Nov 19, 2020 at 1:17 AM Davi

Re: [PATCH 2/2] PCI: Disable Precision Time Measurement during suspend

2020-11-19 Thread David E. Box
On Thu, 2020-11-19 at 13:01 +0100, Rafael J. Wysocki wrote: > On Thu, Nov 19, 2020 at 1:17 AM David E. Box > wrote: > > On Intel client platforms that support suspend-to-idle, like Ice > > Lake, > > root ports that have Precision Time Management (PTM) enabled can >

[PATCH 1/2] PCI: Add save/restore of Precision Time Measurement capability

2020-11-18 Thread David E. Box
. This saves the PTM Enable, Root Select, and Effective Granularity bits. Suggested-by: Rafael J. Wysocki Signed-off-by: David E. Box --- drivers/pci/pci.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c

[PATCH 2/2] PCI: Disable Precision Time Measurement during suspend

2020-11-18 Thread David E. Box
the feature. The feature will be returned to its previous state during restore. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209361 Reported-by: Len Brown Suggested-by: Rafael J. Wysocki Signed-off-by: David E. Box --- drivers/pci/pci.c | 14 +- 1 file changed, 13

Re: [PATCH] PCI: Disable PTM during suspend on Intel PCI bridges

2020-11-16 Thread David E. Box
> > > > On Wed, Oct 7, 2020 at 6:49 PM David E. Box < > > > > david.e@linux.intel.com> wrote: > > > > > On Intel Platform Controller Hubs (PCH) since Cannon Lake, > > > > > the Precision > > > > > Time Measurement (PTM)

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

2020-11-10 Thread David E. Box
Hi Geert, On Tue, 2020-11-10 at 11:39 +0100, Geert Uytterhoeven wrote: > Hi David, > > On Sat, Oct 3, 2020 at 3:32 AM David E. Box < > david.e@linux.intel.com> wrote: > > Intel Platform Monitoring Technology (PMT) is an architecture for > > enumerating and

Re: [PATCH V9 0/5] Intel Platform Monitoring Technology

2020-10-29 Thread David E. Box
Hi Lee, On Thu, 2020-10-29 at 15:16 +, Lee Jones wrote: ... > > Changes from V8: > > - Rebase on 5.10-rc1 > > - Add missing changes in MFD patch from V7 that were > > accidentally > > dropped in V8 > > Which changes are those? > > Do I need to re-review? Should have

Re: [PATCH V8 0/5] Intel Platform Monitoring Technology

2020-10-28 Thread David E. Box
On Tue, 2020-10-27 at 12:28 +0100, Hans de Goede wrote: > Hi, > > On 10/3/20 3:31 AM, David E. Box wrote: > > Intel Platform Monitoring Technology (PMT) is an architecture for > > enumerating and accessing hardware monitoring capabilities on a > > device. > > W

[PATCH V9 0/5] Intel Platform Monitoring Technology

2020-10-28 Thread David E. Box
ring fixes Alexander Duyck (3): platform/x86: Intel PMT class driver platform/x86: Intel PMT Telemetry capability driver platform/x86: Intel PMT Crashlog capability driver David E. Box (2): PCI: Add defines for Designated Vendor-Specific Extended Capability mfd: Intel Platform

[PATCH V9 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-10-28 Thread David E. Box
Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6. Signed-off-by: David E. Box Acked-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko --- Changes from V8: - None include/uapi/linux/pci_regs.h | 5

[PATCH] PCI: Disable PTM during suspend on Intel PCI bridges

2020-10-07 Thread David E. Box
: https://www.uefi.org/sites/default/files/resources/Intel_ACPI_Low_Power_S0_Idle.pdf Bug: https://bugzilla.kernel.org/show_bug.cgi?id=209361 Tested-by: Len Brown Signed-off-by: David E. Box --- drivers/pci/quirks.c | 57 1 file changed, 57 insertions

Re: [PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

2020-10-07 Thread David E. Box
On Wed, 2020-10-07 at 07:57 +0100, Lee Jones wrote: > On Fri, 02 Oct 2020, David E. Box wrote: > > > Intel Platform Monitoring Technology (PMT) is an architecture for > > enumerating and accessing hardware monitoring facilities. PMT > > supports > > multiple ty

[PATCH 3/4] platform/x86: intel_pmc_core: fix: Replace dev_dbg macro with dev_info()

2020-10-06 Thread David E. Box
m/x86: intel_pmc_core: Add an additional parameter to pmc_core_lpm_display()") Cc: Srinivas Pandruvada Cc: Andy Shevchenko Cc: David E. Box Signed-off-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/4] platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support

2020-10-06 Thread David E. Box
From: Gayatri Kammela Add RocketLake to the list of the platforms that intel_pmc_core driver supports for pmc_core device. RocketLake reuses all the TigerLake PCH IPs. Cc: Srinivas Pandruvada Cc: Andy Shevchenko Cc: David E. Box Cc: Tony Luck Cc: Rui Zhang Signed-off-by: Gayatri Kammela

[PATCH 1/4] platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments and reorganize

2020-10-06 Thread David E. Box
(cnp_pfear_map). Hence, remove the duplicate comments and reorganize them. Cc: Srinivas Pandruvada Cc: Andy Shevchenko Cc: David E. Box Cc: Tony Luck Cc: Rui Zhang Suggested-by: Dave Hansen Signed-off-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c

[PATCH 0/4] pmc_core: Add RocketLake and other changes

2020-10-06 Thread David E. Box
Add RocketLake platform support and other driver maintainance. Gayatri Kammela (4): platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments and reorganize platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support platform/x86: intel_pmc_core: fix: Replace dev_dbg

[PATCH 4/4] MAINTAINERS: Update maintainers for pmc_core driver

2020-10-06 Thread David E. Box
From: Gayatri Kammela Update MAINTAINERS file for pmc_core driver to reflect the current maintainers. Cc: Vishwanath Somayaji Cc: Andy Shevchenko Cc: Srinivas Pandruvada Cc: David E. Box Acked-by: David E. Box Acked-by: Vishwanath Somayaji Signed-off-by: Gayatri Kammela Signed-off

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-10-06 Thread David E. Box
On Tue, 2020-10-06 at 19:51 -0500, Bjorn Helgaas wrote: > On Tue, Oct 06, 2020 at 03:45:54PM -0700, David E. Box wrote: > > Hi Bjorn, > > > > This patch has been acked and unchanged for weeks. Is it possible > > to > > get this pulled into next?

[PATCH 1/3] platform/x86: pmc_core: Use descriptive names for LPM registers

2020-10-06 Thread David E. Box
TigerLake Lower Power Mode (LPM) registers are grouped by functionality but were given simple enumerated names in the code (lpm0, lpm1, ...). Instead, give the register blocks names that describe their usage. Suggested-by: Andy Shevchenko Signed-off-by: David E. Box --- drivers/platform/x86

[PATCH 3/3] platform/x86: intel_pmc_core: Fix the slp_s0 counter displayed value

2020-10-06 Thread David E. Box
. Hence, specify granularity of the tick for each platform, so that the value of the slp_s0 counter is accurate. Signed-off-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 10 +++--- drivers/platform/x86/intel_pmc_core.h | 5 - 2 files changed

[PATCH 2/3] platform/x86: intel_pmc_core: Fix TigerLake power gating status map

2020-10-06 Thread David E. Box
. Cc: Srinivas Pandruvada Cc: Andy Shevchenko Cc: David E. Box Signed-off-by: Gayatri Kammela Signed-off-by: David E. Box --- drivers/platform/x86/intel_pmc_core.c | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/platform/x86

[PATCH 0/3] Tiger Lake PMC core driver fixes

2020-10-06 Thread David E. Box
gating status register for TigerLake. Patch 3: Fixes the slps0 residency multiplier to use the correct, platform specific values. David E. Box (1): platform/x86: pmc_core: Use descriptive names for LPM registers Gayatri Kammela (2): platform/x86: intel_pmc_core: Fix TigerLake

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-10-06 Thread David E. Box
Hi Bjorn, This patch has been acked and unchanged for weeks. Is it possible to get this pulled into next? We have SIOV and CXL related work that is using these definitions. Thanks. David On Fri, 2020-10-02 at 18:31 -0700, David E. Box wrote: > Add PCIe Designated Vendor-Specific Exten

[PATCH V8 5/5] platform/x86: Intel PMT Crashlog capability driver

2020-10-02 Thread David E. Box
From: Alexander Duyck Add support for the Intel Platform Monitoring Technology crashlog interface. This interface provides a few sysfs values to allow for controlling the crashlog telemetry interface as well as a character driver to allow for mapping the crashlog memory region so that it can be

[PATCH V8 4/5] platform/x86: Intel PMT Telemetry capability driver

2020-10-02 Thread David E. Box
ssues. Co-developed-by: David E. Box Signed-off-by: David E. Box Signed-off-by: Alexander Duyck --- drivers/platform/x86/Kconfig | 11 ++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/intel_pmt_telemetry.c | 160 + 3 files changed, 172

[PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-10-02 Thread David E. Box
Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6. Signed-off-by: David E. Box Acked-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko --- include/uapi/linux/pci_regs.h | 5 + 1 file changed, 5 insertions

[PATCH V8 3/5] platform/x86: Intel PMT class driver

2020-10-02 Thread David E. Box
region in bytes that corresponds to + the mapping for the telem file. diff --git a/MAINTAINERS b/MAINTAINERS index 0f2663b1d376..47fdb8a6e151 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8950,6 +8950,7 @@ INTEL PMT DRIVER M: "David E. Box" S: Maintained F: d

[PATCH V8 0/5] Intel Platform Monitoring Technology

2020-10-02 Thread David E. Box
, spelling, and Makefile/MAINTAINERS ordering fixes Alexander Duyck (3): platform/x86: Intel PMT class driver platform/x86: Intel PMT Telemetry capability driver platform/x86: Intel PMT Crashlog capability driver David E. Box (2): PCI: Add defines for Designated Vendor-Specific Extended Capabi

[PATCH V8 2/5] mfd: Intel Platform Monitoring Technology support

2020-10-02 Thread David E. Box
a quirk to fix the discovery table offset. Co-developed-by: Alexander Duyck Signed-off-by: Alexander Duyck Signed-off-by: David E. Box Reviewed-by: Andy Shevchenko --- MAINTAINERS | 5 + drivers/mfd/Kconfig | 10 ++ drivers/mfd/Makefile| 1 + drivers/mfd/intel_pmt.c

[PATCH V7 3/5] platform/x86: Intel PMT class driver

2020-09-30 Thread David E. Box
region in bytes that corresponds to + the mapping for the telem file. diff --git a/MAINTAINERS b/MAINTAINERS index 0f2663b1d376..47fdb8a6e151 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8950,6 +8950,7 @@ INTEL PMT DRIVER M: "David E. Box" S: Maintained F: d

[PATCH V7 4/5] platform/x86: Intel PMT Telemetry capability driver

2020-09-30 Thread David E. Box
can be populated with telem devices. These devices will contain the standard intel_pmt sysfs data and a "telem" binary sysfs attribute which can be used to access the telemetry data. Co-developed-by: David E. Box Signed-off-by: David E. Box Signed-off-by: Alexander Duyck --- driver

[PATCH V7 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-09-30 Thread David E. Box
Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6. Signed-off-by: David E. Box Acked-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko --- include/uapi/linux/pci_regs.h | 5 + 1 file changed, 5 insertions

[PATCH V7 0/5] Intel Platform Monitoring Technology

2020-09-30 Thread David E. Box
ring fixes Alexander Duyck (3): platform/x86: Intel PMT class driver platform/x86: Intel PMT Telemetry capability driver platform/x86: Intel PMT Crashlog capability driver David E. Box (2): PCI: Add defines for Designated Vendor-Specific Extended Capability mfd: Intel Platform Monitoring

[PATCH V7 5/5] platform/x86: Intel PMT Crashlog capability driver

2020-09-30 Thread David E. Box
From: Alexander Duyck Add support for the Intel Platform Monitoring Technology crashlog interface. This interface provides a few sysfs values to allow for controlling the crashlog telemetry interface as well as a character driver to allow for mapping the crashlog memory region so that it can be

[PATCH V7 2/5] mfd: Intel Platform Monitoring Technology support

2020-09-30 Thread David E. Box
the discovery table offset. Co-developed-by: Alexander Duyck Signed-off-by: Alexander Duyck Signed-off-by: David E. Box Reviewed-by: Andy Shevchenko --- MAINTAINERS | 5 + drivers/mfd/Kconfig | 10 ++ drivers/mfd/Makefile| 1 + drivers/mfd/intel_pmt.c | 225

Re: [PATCH 1/3] mfd: intel_pmt: Add OOBMSM device ID

2020-09-30 Thread David E. Box
On Wed, 2020-09-30 at 08:12 +0100, Lee Jones wrote: > On Tue, 29 Sep 2020, David E. Box wrote: > > > On Tue, 2020-09-29 at 10:51 +0100, Lee Jones wrote: > > > On Fri, 11 Sep 2020, David E. Box wrote: > > > > > > > Add Out of Band Management Serv

Re: [PATCH 1/3] mfd: intel_pmt: Add OOBMSM device ID

2020-09-29 Thread David E. Box
On Tue, 2020-09-29 at 10:51 +0100, Lee Jones wrote: > On Fri, 11 Sep 2020, David E. Box wrote: > > > Add Out of Band Management Services Module device ID to Intel PMT > > driver. > > > > Signed-off-by: Alexander Duyck > > Signed-off-by: David E. Box >

[PATCH V6 2/5] mfd: Intel Platform Monitoring Technology support

2020-09-28 Thread David E. Box
the discovery table offset. Co-developed-by: Alexander Duyck Signed-off-by: Alexander Duyck Signed-off-by: David E. Box Reviewed-by: Andy Shevchenko --- MAINTAINERS | 5 + drivers/mfd/Kconfig | 10 ++ drivers/mfd/Makefile| 1 + drivers/mfd/intel_pmt.c | 226

[PATCH V6 3/5] platform/x86: Intel PMT class driver

2020-09-28 Thread David E. Box
region in bytes that corresponds to + the mapping for the telem file. diff --git a/MAINTAINERS b/MAINTAINERS index 0f2663b1d376..47fdb8a6e151 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8950,6 +8950,7 @@ INTEL PMT DRIVER M: "David E. Box" S: Maintained F: d

[PATCH V6 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-09-28 Thread David E. Box
Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6. Signed-off-by: David E. Box Acked-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko --- include/uapi/linux/pci_regs.h | 5 + 1 file changed, 5 insertions

[PATCH V6 4/5] platform/x86: Intel PMT Telemetry capability driver

2020-09-28 Thread David E. Box
can be populated with telem devices. These devices will contain the standard intel_pmt sysfs data and a "telem" binary sysfs attribute which can be used to access the telemetry data. Co-developed-by: David E. Box Signed-off-by: David E. Box Signed-off-by: Alexander Duyck --- driver

[PATCH V6 5/5] platform/x86: Intel PMT Crashlog capability driver

2020-09-28 Thread David E. Box
From: Alexander Duyck Add support for the Intel Platform Monitoring Technology crashlog interface. This interface provides a few sysfs values to allow for controlling the crashlog telemetry interface as well as a character driver to allow for mapping the crashlog memory region so that it can be

[PATCH V6 0/5] Intel Platform Monitoring Technology

2020-09-28 Thread David E. Box
x86: Intel PMT class driver platform/x86: Intel PMT Telemetry capability driver platform/x86: Intel PMT Crashlog capability driver David E. Box (2): PCI: Add defines for Designated Vendor-Specific Extended Capability mfd: Intel Platform Monitoring Technology support .../ABI/testing/s

[PATCH 3/3] platform/x86: Intel PMT Crashlog capability driver

2020-09-11 Thread David E. Box
be accessed after a crashlog has been recorded. This driver is meant to only support the server version of the crashlog which is identified as crash_type 1 with a version of zero. Currently no other types are supported. Signed-off-by: Alexander Duyck Signed-off-by: David E. Box --- .../ABI

[PATCH 1/3] mfd: intel_pmt: Add OOBMSM device ID

2020-09-11 Thread David E. Box
Add Out of Band Management Services Module device ID to Intel PMT driver. Signed-off-by: Alexander Duyck Signed-off-by: David E. Box --- drivers/mfd/intel_pmt.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd/intel_pmt.c index 0e572b105101

[PATCH 0/3] intel_pmt: Add Alder Lake and OOB-MSM support

2020-09-11 Thread David E. Box
://lore.kernel.org/lkml/20200819180255.11770-1-david.e@linux.intel.com/ Alexander Duyck (1): platform/x86: Intel PMT Crashlog capability driver David E. Box (2): mfd: intel_pmt: Add OOBMSM device ID mfd: intel_pmt: Add Alder Lake (ADL) support .../ABI/testing/sysfs-class-pmt_crashlog | 66

[PATCH 2/3] mfd: intel_pmt: Add Alder Lake (ADL) support

2020-09-11 Thread David E. Box
Add PMT support for Alder Lake (ADL). Use same quirks as Tiger Lake since the design is the same, meaning no support for Watcher or Crashlog. Signed-off-by: David E. Box --- drivers/mfd/intel_pmt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd

[RESEND PATCH V5 0/3] Intel Platform Monitoring Technology

2020-08-19 Thread David E. Box
name - Move monitor device name defines to common header - Coding style, spelling, and Makefile/MAINTAINERS ordering fixes David E. Box (3): PCI: Add defines for Designated Vendor-Specific Extended Capability mfd: Intel Platform Monitoring Technology support platform/x86: Intel

[PATCH V5 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-08-19 Thread David E. Box
Add PCIe Designated Vendor-Specific Extended Capability (DVSEC) and defines for the header offsets. Defined in PCIe r5.0, sec 7.9.6. Signed-off-by: David E. Box Acked-by: Bjorn Helgaas Reviewed-by: Andy Shevchenko --- include/uapi/linux/pci_regs.h | 5 + 1 file changed, 5 insertions

[PATCH V5 2/3] mfd: Intel Platform Monitoring Technology support

2020-08-19 Thread David E. Box
--git a/MAINTAINERS b/MAINTAINERS index f0569cf304ca..b69429c70330 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8845,6 +8845,11 @@ F: drivers/mfd/intel_soc_pmic* F: include/linux/mfd/intel_msic.h F: include/linux/mfd/intel_soc_pmic* +INTEL PMT DRIVER +M: "David E. Box

[PATCH V5 3/3] platform/x86: Intel PMT Telemetry capability driver

2020-08-19 Thread David E. Box
issues. Co-developed-by: Alexander Duyck Signed-off-by: Alexander Duyck Signed-off-by: David E. Box Reviewed-by: Andy Shevchenko --- .../ABI/testing/sysfs-class-pmt_telemetry | 46 ++ MAINTAINERS | 1 + drivers/platform/x86/Kconfig | 10

Re: [PATCH V5 0/3] Intel Platform Monitoring Technology

2020-08-11 Thread David E. Box
On Tue, 2020-08-11 at 09:04 +0100, Lee Jones wrote: > On Mon, 10 Aug 2020, David E. Box wrote: > > > Friendly ping. > > Don't do that. Sending contentless pings is seldom helpful. > > If you think your set has been dropped please just send a [RESEND]. > > This

  1   2   3   4   >