On Fri, 20 Sept 2024 at 00:01, Shuah Khan wrote:
>
> On 9/16/24 18:51, Artur Alves wrote:
> > Hi all,
> >
> > This is part of a hackathon organized by LKCAMP[1], focused on writing
> > tests using KUnit. We reached out a while ago asking for advice on what
> > would be a useful contribution[2] and
On Tue, 10 Sept 2024 at 12:35, I Hsin Cheng wrote:
>
> Mending test for list_cut_position*() for the missing check of integer
> "i" after the second loop. The variable should be checked for second
> time to make sure both lists after the cut operation are formed as
> expected.
>
> Signed-off-by: I
linux-kernel-vscode
>
> Signed-off-by: Brendan Jackman
> ---
Sorry for missing this earlier.
I'm happy with this. Having the compile_commands.json be in the .kunit
directory is annoying, but it actually ends up being less annoying for
the case where you have lots of out-of-tree
d list.
> 5. The old list is empty.
>
> Signed-off-by: Zhen Lei
> ---
Thanks very much for the detailed test. It's great to see these kept up-to-date!
Reviewed-by: David Gow
Cheers,
-- David
> lib/list-test.c | 51 +
> 1 file
: https://lore.kernel.org/lkml/20240827160631.67e12...@canb.auug.org.au/
Fixes: f2c6dbd22017 ("kunit: Device wrappers should also manage driver name")
Signed-off-by: David Gow
---
include/kunit/test.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/kunit/test.h b/include/kunit/test.h
Hi Matt,
> Like patch 1/6, I can apply it in MPTCP tree and send it later to
> net-next with other patches.
> Except if you guys prefer to apply it in KUnit tree and send it to
> linux-next?
Given 1/6 is going to net-next, it makes sense to send this out that
way too, then, IMHO.
The only slight
cover edge cases should be easy
> * looking at code coverage, we hit all the branches in the .c files
>
> Signed-off-by: Daniel Latypov
> Reviewed-by: David Gow
> ---
Thanks: I've tested this version, and am happy with it. A part of me
still kind-of would like there to be na
problem having both: this page is supposed to be a
bit more of a reference, rather than a list of useful tips, so the fact
that they both describe the same features isn't a problem.
Signed-off-by: David Gow
Reviewed-by: Daniel Latypov
---
Adopted the changes from Daniel.
Changes since v1
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
It's been a while, but this hopefully is a final version of the FAT KUnit
patchset. It has a number of changes to keep it up-to-date with current
KUnit standards, notably the use of paramete
problem having both: this page is supposed to be a
bit more of a reference, rather than a list of useful tips, so the fact
that they both describe the same features isn't a problem.
Signed-off-by: David Gow
---
Documentation/dev-tools/kunit/kunit-tool.rst | 132 ++-
1 file chan
;S' on the end isn't a huge problem if you
have a good reason to particularly want to keep it, though: as long as
you don't have something like _K_UNIT_VERIFICATION or something
equally silly that'd break grepping for '_KUNIT_TEST', it's fine be
me.
So, since it matches my prejudices, this patch is:
Reviewed-by: David Gow
Thanks,
-- David
entation later.
Signed-off-by: David Gow
Reviewed-by: Marco Elver
Reviewed-by: Daniel Latypov
---
Thanks again. Assuming no-one has any objections, I think this is good
to go.
-- David
Changes since v2:
https://lore.kernel.org/linux-kselftest/20210414081428.337494-1-david...@google.com/
- A
On Thu, Apr 15, 2021 at 12:30 AM Daniel Latypov wrote:
>
> On Wed, Apr 14, 2021 at 1:15 AM David Gow wrote:
> >
> > The kernel now has a number of testing and debugging tools, and we've
> > seen a bit of confusion about what the differences between them are.
>
entation later.
Signed-off-by: David Gow
---
Thanks, everyone, for the comments on the doc. I've made a few of the
suggested changes. Please let me know what you think!
-- David
Changes since v1:
https://lore.kernel.org/linux-kselftest/20210410070529.4113432-1-david...@google.com/
- Note KUnit&
ons
are addressed. I'm particularly excited to have code coverage
documented somewhere.
Assuming Brendan's happy with the TODOs being there, I think this is
ready to go.
I also built this with Sphinx and gave it a quick look, and it all
looks good there as well.
Therefore, this is:
Reviewed-by: David Gow
Cheers,
-- David
cover edge cases should be easy
> * looking at code coverage, we hit all the branches in the .c files
>
> Signed-off-by: Daniel Latypov
This looks good to me. A few comments/observations below, but nothing
that I think should actually block this.
Reviewed-by: David Gow
-- David
esting/kunit/kunit.py run '*exec*'
>
> Signed-off-by: Daniel Latypov
I really like this test, thanks.
A few small notes below, including what I think is a missing
kfree_at_end() call.
Assuming that one issue is fixed (or I'm mistaken):
Reviewed-by: David Gow
-- David
>
entation later.
Signed-off-by: David Gow
---
Documentation/dev-tools/index.rst| 3 +
Documentation/dev-tools/testing-overview.rst | 102 +++
2 files changed, 105 insertions(+)
create mode 100644 Documentation/dev-tools/testing-overview.rst
diff --git a/Docume
Thanks for writing this: it's good to have these things documented at last!
There are definitely a few things this document points out which still
need deciding, which does make this document lean a bit into "design
discussion" territory in a few of the notes. This doesn't bother me --
it's an acc
The first argument to namedtuple() should match the name of the type,
which wasn't the case for KconfigEntryBase.
Fixing this is enough to make mypy show no python typing errors again.
Fixes 97752c39bd ("kunit: kunit_tool: Allow .kunitconfig to disable config
items")
Signed-of
out with all the different combinations I could think of,
and it works well.
Reviewed-by: David Gow
Cheers,
-- David
> lib/kunit/.kunitconfig | 3 +++
> tools/testing/kunit/kunit.py | 4 +++-
> tools/testing/kunit/kunit_kernel.py| 2 ++
> tools/testing/k
On Wed, Feb 10, 2021 at 6:14 AM Daniel Latypov wrote:
>
> From: Uriel Guajardo
>
> Add a kunit_fail_current_test() function to fail the currently running
> test, if any, with an error message.
>
> This is largely intended for dynamic analysis tools like UBSAN and for
> fakes.
> E.g. say I had a f
cking down the real root cause,
but since this is breaking KUnit's --alltests feature, it's worth
disabling there in the meantime so the kernel can boot to the point
where tests can actually run.
Fixes: f289041ed4 ("mm, page_poison: remove CONFIG_PAGE_POISONING_ZERO")
Signed-of
On Sat, Jan 23, 2021 at 8:17 AM Daniel Latypov wrote:
>
> Currently running tests via KUnit tool means tweaking a .kunitconfig
> file, which you'd keep around locally and never commit.
> This changes makes it so users can pass in a path to a kunitconfig.
>
> One of the imagined use cases is having
with literals look like:
# example_simple_test: EXPECTATION FAILED at lib/kunit/kunit-example-test.c:31
Expected "abc" == "abd", but
"abc" == abc
"abd" == abd
# example_simple_test: EXPECTATION FAILED at lib/kunit/kunit-example-test.c:33
Expected 0x124 == 0x1234, but
0x124 == 0124
0x1234 == 1234
Either way, though, this is:
Tested-by: David Gow
Cheers,
-- David
On Wed, Jan 27, 2021 at 8:27 PM Stafford Horne wrote:
>
> On Tue, Jan 26, 2021 at 07:36:04PM -0800, David Gow wrote:
> > The LiteX SOC controller driver makes use of IOMEM functions like
> > devm_platform_ioremap_resource(), which are only available if
> > CON
> workaround (hack).
>
> At the same time, we can increase the maximum number of threads used,
> because on systems with too few CPUs, KUnit allows us to now stop at the
> maximum useful threads and not unnecessarily execute redundant test
> cases with (the same) limited threads a
, the driver will not be enabled on
architectures which don't support it.
Fixes: 09ef18bcd5ac ("rtc: use devm_platform_ioremap_resource() to simplify
code")
Signed-off-by: David Gow
---
drivers/rtc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
river will not be enabled on
architectures which don't support it.
Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
Signed-off-by: David Gow
---
drivers/i3c/master/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i3c/master/Kconfig b/driver
IOMEM, the driver will not be enabled on
architectures which don't support it.
Fixes: 22447a99c97e ("drivers/soc/litex: add LiteX SoC Controller driver")
Signed-off-by: David Gow
---
drivers/soc/litex/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/litex/K
gt; 2. Rename suite name 'kcsan-test' to 'kcsan'.
>
> 3. Rename CONFIG_KCSAN_TEST to CONFIG_KCSAN_KUNIT_TEST and
>default to KUNIT_ALL_TESTS.
>
> Cc: David Gow
> Signed-off-by: Marco Elver
Thanks very much -- it's great t
> >>>> On 12/22/20 4:11 AM, Andy Shevchenko wrote:
> >>>>> On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote:
> >>>>>> kunit_tool relies on the UML console outputting printk() output to the
> >>>>>> tty in or
ned-off-by: David Gow
Fixes: 757055ae8ded ("init/console: Use ttynull as a fallback when there is no
console")
---
tools/testing/kunit/kunit_kernel.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_kernel.py
b/tools/testing/kunit/k
On Wed, Dec 16, 2020 at 10:53 PM Quentin Monnet wrote:
>
> 2020-11-21 17:48 UTC+0800 ~ David Gow
> > On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko
> > wrote:
> >>
> >> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote:
> >>>
> >>
de
> guidance for testing many inputs") to show a minimal example of the new
> feature.
>
> Signed-off-by: Daniel Latypov
> ---
This looks good to me. Thanks!
Reviewed-by: David Gow
-- David
smime.p7s
Description: S/MIME Cryptographic Signature
Various helper functions were misspelling "diagnostic" in their names.
It finally got annoying, so fix it.
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/tes
iagnostic lines, so that
these statistics do not prevent the result from parsing.
Signed-off-by: David Gow
---
This is largely a follow-up to the discussion here:
https://lore.kernel.org/linux-kselftest/CABVgOSmy4n_LGwDS7yWfoLftcQzxv6S+iXx9Y=opcgg2gu0...@mail.gmail.com/T/#t
Does this seem lik
from the
> list for _every_ outer iteration.
>
> Signed-off-by: Daniel Latypov
> ---
Thanks! This works great here: I didn't time it to see how much faster
it is, but it's clearly an improvement.
Reviewed-by: David Gow
Cheers,
-- David
On Sat, Dec 5, 2020 at 2:18 AM Daniel Latypov wrote:
>
> On Thu, Dec 3, 2020 at 7:57 PM David Gow wrote:
> >
> > On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote:
> > >
> > > LinuxSourceTree will unceremoniously crash if the user doesn't call
>
ov
> ---
This looks good to me: I gave it some quick testing, and reading
through it, all of the changes seem sensible.
I wasn't able to get pytype running here, but mypy worked fine.
Reviewed-by: David Gow
-- David
s the precedent in commit 3fc48259d525 ("kunit: Don't
> fail test suites if one of them is empty").
>
> Also slightly simplify the code and add type annotations.
>
> Signed-off-by: Daniel Latypov
> ---
Otherwise, the actual code changes all seem sensible, and it worked
fine when I tested it, so:
Reviewed-by: David Gow
-- David
On Fri, Dec 4, 2020 at 3:41 AM Daniel Latypov wrote:
>
> LinuxSourceTree will unceremoniously crash if the user doesn't call
> read_kunitconfig() first in a number of functions.
This patch seems to partly be reverting the changes here, right:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/
cabvgosnh0gz7z5jhrcgyg1wg0zddbtlosucob-gwmexlgvt...@mail.gmail.com/
>
> Fixes: 5578d008d9e0 ("kunit: tool: fix running kunit_tool from outside kernel
> tree")
> Signed-off-by: Daniel Latypov
> ---
Thanks: I much prefer this to v1. Having it work the same way as
test_tmpdir is a bonus.
Reviewed-by: David Gow
Cheers,
-- David
utside.
>
> Do so to make the code more Pythonic.
>
> Signed-off-by: Daniel Latypov
> ---
Reviewed-by: David Gow
Cheers,
-- David
ov
> ---
This patch hasn't changed since v1, right?
It's still:
Reviewed-by: David Gow
Cheers,
-- David
t check of exception types. self.assertRaises does this.
> * s/kall/call. There's no reason to name it this way.
> * This is probably a misunderstanding from the docs which uses it
> since `mock.call` is in scope as `call`.
>
> Signed-off-by: Daniel Latypov
> ---
Looks good, thanks!
Reviewed-by: David Gow
-- David
On Wed, Dec 2, 2020 at 8:21 PM Andy Shevchenko
wrote:
>
> On Wed, Dec 2, 2020 at 1:57 PM David Gow wrote:
> > On Wed, Dec 2, 2020 at 6:06 PM Andy Shevchenko
> > wrote:
> > > On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote:
>
> ...
>
> &
On Wed, Dec 2, 2020 at 6:06 PM Andy Shevchenko
wrote:
>
> On Wed, Dec 02, 2020 at 09:51:19AM +0530, Arpitha Raghunandan wrote:
> > On 01/12/20 4:36 pm, Andy Shevchenko wrote:
> > > On Tue, Dec 1, 2020 at 9:21 AM Arpitha Raghunandan <98.a...@gmail.com>
> > > wrote:
>
> ...
>
> > >> I ran both the
On Wed, Dec 2, 2020 at 3:00 AM Daniel Latypov wrote:
>
> On Mon, Nov 30, 2020 at 11:33 PM David Gow wrote:
> >
> > On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
> > >
> > > get_absolute_path() makes an attempt to allow for this.
> > > But
On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
>
> 1. the name is a lie. It gives relative paths, e.g. if I run from the
> same dir as the test file, it gives './test_data/'
>
> 2. it's only used for generating paths to tools/testing/kunit/test_data/
> So we can tersen things by making it le
brain does understand the older code a
touch more easily.
In any case,
Reviewed-by: David Gow
-- David
On Tue, Dec 1, 2020 at 7:33 AM Daniel Latypov wrote:
>
> get_absolute_path() makes an attempt to allow for this.
> But that doesn't work as soon as os.chdir() gets called.
Can we explain why this doesn't work? It's because the test_data/
files are accessed with relative paths, so chdir breaks acc
seems pretty sensible from my rudimentary
python knowledge.
Reviewed-by: David Gow
Cheers,
-- David
typov
> ---
I won't pretend to be an expert on Python, but this seems good to me.
I tested it on my machine and it works fine.
So,
Reviewed-by: David Gow
-- Davkd
> tools/testing/kunit/kunit_tool_test.py | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
&
On Mon, Nov 23, 2020 at 9:08 PM Marco Elver wrote:
>
> On Tue, 17 Nov 2020 at 08:21, David Gow wrote:
> > On Mon, Nov 16, 2020 at 1:41 PM Arpitha Raghunandan <98.a...@gmail.com>
> > wrote:
> > >
> > > Implementation of support for parameterized testing
On Sat, Nov 21, 2020 at 3:38 PM Andrii Nakryiko
wrote:
>
> On Thu, Nov 19, 2020 at 12:51 AM David Gow wrote:
> >
> > If BPF_PRELOAD is enabled, and an out-of-tree build is requested with
> > make O=, compilation seems to fail with:
> >
> > tools/scripts/Makef
s: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own
feature drivers")
Signed-off-by: David Gow
---
Changes since v1:
(
https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-david...@google.com/
)
- Add Fixes tag
drivers/fpga/Kconfig | 1 +
1 file changed, 1 inserti
On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote:
>
> Hi David,
>
> On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > 'devm_ioremap_resource', and 'devm_pl
UTPUT= in tools/scripts/Makefile.include.
Signed-off-by: David Gow
---
Hi all,
I'm not 100% sure this is the correct fix here -- it seems to work for
me, and makes some sense, but let me know if there's a better way.
One other thing worth noting is that I've been hitting this with
]:
- MFD_HI6421_SPMI [=y] && STAGING [=y] && OF [=y] && SPMI [=y]
By specifying HAS_IOMEM as a dependency for MFD_HI6421_SPMI (as
SPMI_HISI3670 already dows), this issue is resolved, and no such warning
appears when building on architectures without HAS_IOMEM.
Signed-off-by: David G
Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.
This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.
Signed
m the debugfs results file. But
that's clearly not an issue with this patch, and the actual combined
result is still present (and the complete results should show up in
dmesg anyway).
Tested-by: David Gow
Reviewed-by: David Gow
Thanks!
-- David
e turned into subsubtest outputs.
>
> Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com>
> Co-developed-by: Marco Elver
> Signed-off-by: Marco Elver
> ---
[Resending this because my email client re-defaulted to HTML! Aarrgh!]
This looks good to me! I tested it in UML an
On Sat, Nov 14, 2020 at 9:38 AM Arpitha Raghunandan <98.a...@gmail.com> wrote:
>
> On 14/11/20 5:44 am, Marco Elver wrote:
> >
> > Arpitha: Do you want to send v7, but with the following modifications
> > from what I proposed? Assuming nobody objects.
> >
> > 1. Remove the num_params counter and do
On Fri, Nov 13, 2020 at 6:31 PM Marco Elver wrote:
>
> On Fri, Nov 13, 2020 at 01:17PM +0800, David Gow wrote:
> > On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote:
> [...]
> > > > (It also might be a little tricky with the current implementation to
> >
On Thu, Nov 12, 2020 at 8:37 PM Marco Elver wrote:
>
> On Thu, Nov 12, 2020 at 04:18PM +0800, David Gow wrote:
> > On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote:
> [...]
> > > > kunit_tool has a bug when parsing the comments / diagnostic lines,
> > > &
On Thu, Nov 12, 2020 at 12:55 AM Bird, Tim wrote:
>
>
>
> > -Original Message-
> > From: David Gow
> >
> > On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote:
> > >
> > > > -Original Message-
> > > > From:
On Wed, Nov 11, 2020 at 1:02 AM Bird, Tim wrote:
>
>
>
> > -Original Message-
> > From: David Gow
> >
> > On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com>
> > wrote:
> > >
> > > On 07/11/20 3:36 pm, Ma
] and the draft KTAP spec[2] are
expecting.
[1]: http://testanything.org/tap-specification.html
[2]:
https://lore.kernel.org/linux-kselftest/cy4pr13mb1175b804e31e502221bc8163fd...@cy4pr13mb1175.namprd13.prod.outlook.com/T/
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 7 --
On Mon, Nov 9, 2020 at 2:49 PM Arpitha Raghunandan <98.a...@gmail.com> wrote:
>
> On 07/11/20 3:36 pm, Marco Elver wrote:
> > On Sat, 7 Nov 2020 at 05:58, David Gow wrote:
> >> On Sat, Nov 7, 2020 at 3:22 AM Arpitha Raghunandan <98.a...@gmail.com>
> >
On Sat, Nov 7, 2020 at 3:23 AM Arpitha Raghunandan <98.a...@gmail.com> wrote:
>
> Modify fs/ext4/inode-test.c to use the parameterized testing
> feature of KUnit.
>
> Signed-off-by: Arpitha Raghunandan <98.a...@gmail.com>
> ---
This looks good to me. Thanks!
Reviewed-by: David Gow
-- David
d-off-by: Marco Elver
> ---
This looks good to me! A couple of minor thoughts about the output
format below, but I'm quite happy to have this as-is regardless.
Reviewed-by: David Gow
Cheers,
-- David
> Changes v5->v6:
> - Fix alignment to maintain consistency
> Change
On Tue, Nov 3, 2020 at 5:37 AM Daniel Latypov wrote:
>
> usage.rst goes into a detailed about faking out classes, but currently
Nit: a detailed what?
> lacks wording about how one might idiomatically test a range of inputs.
>
> Give an example of how one might test a hash function via macros/hel
nit_parser: make parser more robust")
> Signed-off-by: Brendan Higgins
> ---
Reviewed-by: David Gow
Thanks. I wasn't able to find any issues which required those files to
be binary.
For the record, a link to the original issue, which appeared to be
with whitespace (spaces before ta
ux-kselftest/20201020233219.4146059-1-dlaty...@google.com/
>
> Signed-off-by: Daniel Latypov
> ---
Thanks!
I tried this out against everything I could (including the nastier
--alltests option), and didn't hit any problems, so it looks good to
go to me!
Reviewed-by: David Gow
Tested-by: David Gow
Cheers,
-- David
On Fri, Oct 30, 2020 at 1:41 PM Daniel Latypov wrote:
>
> On Thu, Oct 29, 2020 at 7:34 PM David Gow wrote:
> >
> > On Wed, Oct 21, 2020 at 7:32 AM Daniel Latypov wrote:
> > >
> > > For simplcity, strip all trailing whitespace from parsed output.
> > >
On Fri, Oct 30, 2020 at 2:17 PM Daniel Latypov wrote:
>
> Currently --raw_output means nothing gets shown.
> Why?
> Because `raw_output()` has a `yield` and therefore is a generator, which
> means it only executes when you ask it for a value.
>
> Given no one actually is using it as a generator (c
e when the script runs, rather than have to
use mypy as a tool to verify it separately? Otherwise, maybe we can
run it automatically from the kunit_tool_test.py unit tests or
something similar?
Regardless, this is
Reviewed-by: David Gow
Cheers,
-- David
unction ‘kunit_test_successful_try’:
> ../lib/kunit/kunit-test.c:19:2: error: unknown type name ‘invalid_type’
>19 | invalid_type *test = data;
> | ^~~~
> ...
>
> Signed-off-by: Daniel Latypov
> ---
Thanks a lot -- this was really bugging me, and works great.
Reviewed-by: David Gow
ple_test: EXPECTATION FAILED at
> lib/kunit/kunit-example-test.c:29
> [16:16:46] Expected 1 + 1 == 3, but
> [16:16:46] 1 + 1 == 2
> [16:16:46] 3 == 3
> [16:16:46] not ok 1 - example_simple_test
> [16:16:46]
>
> Signed-off-by: Daniel Latypov
> ---
Thanks!
gned-off-by: Randy Dunlap
> Cc: David Gow
> Cc: linux-kselft...@vger.kernel.org
> Cc: kunit-...@googlegroups.com
> Cc: Shuah Khan
> Cc: Shuah Khan
> Cc: Brendan Higgins
> Reviewed-by: David Gow
> ---
> v2: covert spaces indentation to tabs in Kconfig example
>
On Thu, Oct 29, 2020 at 1:43 AM Randy Dunlap wrote:
>
> Fix minor grammar and punctutation glitches.
> Hyphenate "architecture-specific" instances.
>
> Signed-off-by: Randy Dunlap
> Cc: David Gow
> Cc: linux-kselft...@vger.kernel.org
> Cc: kunit-...@googl
On Wed, Oct 28, 2020 at 1:32 PM Randy Dunlap wrote:
>
> On 10/27/20 8:00 PM, David Gow wrote:
> > On Wed, Oct 28, 2020 at 2:49 AM Randy Dunlap wrote:
> >>
> >> Fix the Kconfig example to be closer to Kconfig coding style.
> >> (Except that it still uses
On Wed, Oct 28, 2020 at 2:49 AM Randy Dunlap wrote:
>
> Fix a wording typo (keyboard glitch).
>
> Signed-off-by: Randy Dunlap
> Cc: David Gow
> Cc: linux-kselft...@vger.kernel.org
> Cc: kunit-...@googlegroups.com
> Cc: Shuah Khan
> Cc: Shuah Khan
> Cc: Brendan
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Changes since v6:
https://lore.kernel.org/linux-kselftest/20201024060558.2556249-1-david...@google.com/
- Make CONFIG_FAT_DEFAULT_CODEPAGE depend on FAT_FS, rather than either
VFAT_FS o
ash ('/') to a sub-directory
> name -- this is how the text mostly appears in other Kconfig files.
>
> Signed-off-by: Randy Dunlap
> Cc: David Gow
> Cc: linux-kselft...@vger.kernel.org
> Cc: kunit-...@googlegroups.com
> Cc: Shuah Khan
> Cc: Shuah Khan
> Cc: Brendan
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
I am _so_ sorry: I sent out the wrong version again! It's clearly not my
day! This version actually has the fix!
-- David
Changes since v4/v5:
https://lore.kernel.org/
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Whoops! Sent out a broken early version of this as v4 instead.
Sorry about that!
-- David
Changes since v4:
https://lore.kernel.org/linux-kselftest/20201024052047.2526780-1-david...@google.co
On Fri, Oct 23, 2020 at 10:07 PM Theodore Y. Ts'o wrote:
>
> On Thu, Oct 22, 2020 at 04:52:52PM -0700, Brendan Higgins wrote:
> > So you, me, Luis, David, and a whole bunch of other people have been
> > thinking about this problem for a while. What if we just put
> > kunitconfig fragments in direc
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Changes since v3:
https://lore.kernel.org/linux-kselftest/20201021061713.1545931-1-david...@google.com/
- Update the Kconfig entry to use "depends on" rather than "select", a
Fixes: 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate
out config/build/exec/parse")
Signed-off-by: David Gow
---
tools/testing/kunit/kunit_parser.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/kunit/kunit_parser.py
b/tools/testing/kunit/kunit_parser.py
index 8019e3dd4c32..744e
> Signed-off-by: Brendan Higgins
Excellent: this fixes all of the failing tests in kunit_tool_test.py for me.
Reviewed-by: David Gow
-- David
> ---
> tools/testing/kunit/kunit_tool_test.py| 32 ++
> .../test_data/test_config_printk_time.log | Bi
On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins
wrote:
>
> On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven
> wrote:
> >
> > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
> > user may not want to enable. Fix this by making the test depend on
> > EXT4_FS instead.
> >
ca6233502fcbf86 ("kunit: tool: allow generating
test results in JSON")
Signed-off-by: David Gow
---
This is a quick fix because kunit.py parse is completely broken: it
appears it was introduced in the rebase of the JSON parser after the
separation of concerns patch.
tools/testing/kunit/
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Changes since v2:
https://lore.kernel.org/linux-kselftest/20201020055856.1270482-1-david...@google.com/
- Comment that the export for fat_time_fat2unix() function is for KUnit
tests.
Change
compile
> errors. This commit updates the document for this.
>
> Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> Signed-off-by: SeongJae Park
Sorry for the delay in looking at this. Apart from another minuscule
typo below, this looks good to me.
On Tue, Oct 20, 2020 at 2:51 PM OGAWA Hirofumi
wrote:
>
> David Gow writes:
>
> > diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> > index f1b2a1fc2a6a..445ad3542e74 100644
> > --- a/fs/fat/misc.c
> > +++ b/fs/fat/misc.c
> > @@ -229,6 +229,7 @@ void fat_
On Tue, Oct 20, 2020 at 6:46 AM Daniel Latypov wrote:
>
> Add basic test coverage for files that don't require any config options:
> * gcd.c
> * lcm.c
> * int_sqrt.c
> * reciprocal_div.c
> (Ignored int_pow.c since it's a simple textbook algorithm.)
>
I don't see a particular reason why int_pow.c b
t/torvalds/linux.git/tree/fs/ext4/inode-test.c
Signed-off-by: David Gow
Acked-by: OGAWA Hirofumi
---
Changes since v1:
https://lore.kernel.org/linux-kselftest/20201017064107.375174-1-david...@google.com/
- Now export fat_time_fat2unix() so that the test can access it when
built as a module
ENERIC mode. That'll take a
little while to get upstream though, so I wouldn't want to hold this
up for it.
Otherwise, from the KUnit side, this looks great.
I also tested it against the GENERIC mode on x86_64 (which is all I
have set up here at the moment), and nothing obviously had broken.
So:
Tested-by: David Gow
Cheers,
-- David
1 - 100 of 206 matches
Mail list logo
