[PATCH 0/1] tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe()

2021-02-05 Thread Dirk Gouders
s would then hit the WARN_ONCE(), as well. Dirk [1] https://lore.kernel.org/linux-integrity/20201001180925.13808-5-james.bottom...@hansenpartnership.com/ [2] https://lore.kernel.org/linux-integrity/3936843b-c0da-dd8c-8aa9-90aa3b49d...@linux.ibm.com/T/#t Dirk Gouders (1): tpm_tis: han

[PATCH 1/1] tpm_tis: handle -EPROBE_DEFER in tpm_tis_plat_probe()

2021-02-05 Thread Dirk Gouders
latter case platform_get_irq_optional() often if not always returns a valid IRQ number on the first attempt. Harmonize builtin and module behavior by returning -EPROBE_DEFER, effectively putting the device on the deferred probe list for later probe attempts. Signed-off-by: Dirk Gouders --- drivers

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-03 Thread Dirk Gouders
Dirk Gouders writes: > Lukasz Majczak writes: > >> There are missing calls to tpm_request_locality before the calls to >> the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions >> internally send commands to the tpm. As the current >> approach mig

Re: [PATCH v3] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-02-02 Thread Dirk Gouders
Lukasz Majczak writes: > There are missing calls to tpm_request_locality before the calls to > the tpm_get_timeouts() and tpm_tis_probe_irq_single() - both functions > internally send commands to the tpm. As the current > approach might work for tpm2, it fails for tpm1.x - in that case > call to

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Dirk Gouders
on these Intel machines as well. > > Fixes: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs") > Reported-by: Serge Belyshev > Reported-by: Dirk Gouders > Signed-off-by: Thomas Gleixner > --- > V2: Provide the actual delta patch. Should have stayed away f

Re: [PATCH V2] rtc: mc146818: Detect and handle broken RTCs

2021-01-31 Thread Dirk Gouders
Thomas Gleixner writes: > The recent fix for handling the UIP bit unearthed another issue in the RTC > code. If the RTC is advertised but the readout is straight 0xFF because > it's not available, the old code just proceeded with crappy values, but the > new code hangs because it waits for the UI

Re: [PATCH 1/1] iommu/vt-d: Add qi_submit trace event

2021-01-31 Thread Dirk Gouders
Lu Baolu writes: > This adds a new trace event to track the submissions of requests to the > invalidation queue. This event will provide the information like: > - IOMMU name > - Invalidation type > - Descriptor raw data > > A sample output like: > | qi_submit: iotlb_inv dmar1: 0x100e2 0x0 0x0 0x0

Re: [PATCH v2] tpm_tis: Add missing tpm_request/relinquish_locality calls

2021-01-31 Thread Dirk Gouders
Jarkko Sakkinen writes: > On Thu, 2021-01-28 at 14:07 +0100, Lukasz Majczak wrote: >> There is a missing call to tpm_request_locality before the call to >> the tpm_get_timeouts() and tpm_tis_probe_irq_single(). As the current >> approach might work for tpm2, it fails for tpm1.x - in that case >>

Re: WARN_ONCE triggered: tpm_tis: Add a check for invalid status

2020-10-14 Thread Dirk Gouders
James Bottomley writes: > On Wed, 2020-10-14 at 19:57 +0200, Dirk Gouders wrote: >> On my laptop the check introduced with 55707d531af62b (tpm_tis: Add a >> check for invalid status) triggered the warning (output below). >> >> So, my laptop seems to be a candidate

WARN_ONCE triggered: tpm_tis: Add a check for invalid status

2020-10-14 Thread Dirk Gouders
On my laptop the check introduced with 55707d531af62b (tpm_tis: Add a check for invalid status) triggered the warning (output below). So, my laptop seems to be a candidate for testing. Dirk [7.255467] [ cut here ] [7.255468] TPM returned invalid status [7.2554

Re: [PATCH 1/1] drm/amdgpu: fix NULL pointer dereference for Renoir

2020-10-01 Thread Dirk Gouders
Dirk Gouders writes: > Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) > introduced a NULL pointer dereference when booting with > amdgpu.discovery=0, because it removed the call of vega10_reg_base_init() > for that case. > > Fix this by calli

[PATCH 1/1] drm/amdgpu: fix NULL pointer dereference for Renoir

2020-10-01 Thread Dirk Gouders
that amdgpu_discovery_reg_base_init() failed. Fixes: c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) Signed-off-by: Dirk Gouders Cc: Hawking Zhang Cc: Evan Quan --- drivers/gpu/drm/amd/amdgpu/soc15.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH 0/1] drm/amdgpu: fix NULL pointer dereference for Renoir

2020-10-01 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 30, 2020 at 4:46 PM Dirk Gouders wrote: >> >> Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) >> introduced a NULL pointer dereference when booting with >> amdgpu.discovery=0. >> >> For amdgpu.disc

BUG: amdgpu: NULL pointer dereference introduced in 5.9-rc1

2020-09-30 Thread Dirk Gouders
Commit c1cf79ca5ced46 (drm/amdgpu: use IP discovery table for renoir) introduced a NULL pointer dereference when booting with amdgpu.discovery=0. For amdgpu.discovery=0 that commit effectively removed the call of vega10_reg_base_init(adev), so I tested the correctness of the bisect session by rest

[PATCH] ./Makefile: consider PAGER for `make help'

2020-09-29 Thread Dirk Gouders
`make help' outputs more than a screenfull of lines. In case a user has PAGER defined in his environment, she most likely wants it to be used in such situations. Signed-off-by: Dirk Gouders --- Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile b/Makefile

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-27 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 23, 2020 at 3:45 PM Dirk Gouders wrote: >> >> Dirk Gouders writes: >> >> > Alex Deucher writes: >> > >> >> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >> >>> >> >>> D

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Dirk Gouders writes: > Alex Deucher writes: > >> On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >>> >>> Dirk Gouders writes: >>> >>> > Hi, >>> > >>> > I noticed a call trace (attached) when starting my machin

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Alex Deucher writes: > On Wed, Sep 23, 2020 at 8:54 AM Dirk Gouders wrote: >> >> Dirk Gouders writes: >> >> > Hi, >> > >> > I noticed a call trace (attached) when starting my machine (ThinkPad >> > L14). This machine is new and I

Re: amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-23 Thread Dirk Gouders
Dirk Gouders writes: > Hi, > > I noticed a call trace (attached) when starting my machine (ThinkPad > L14). This machine is new and I am still working on it's > configuration but visually noticeable is that scrolling in xterms with > SHIFT-PgUp/PgDn is broken. Usin

amdgpu: call trace introduced in 5.9-rc1 for Lenovo L14 Renoir

2020-09-22 Thread Dirk Gouders
Hi, I noticed a call trace (attached) when starting my machine (ThinkPad L14). This machine is new and I am still working on it's configuration but visually noticeable is that scrolling in xterms with SHIFT-PgUp/PgDn is broken. Using the mouse wheel works. It seems the call trace has been intro

Re: [PATCH v2 1/3] kconfig: error out when seeing recursive dependency

2018-08-15 Thread Dirk Gouders
ng, which I guess was not intentional. > > Get it back to an error again. > > Also, rename the unit test directory "warn_recursive_dep" to > "err_recursive_dep" so that it matches to the behavior. > > Signed-off-by: Masahiro Yamada I tested v2 of this

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-15 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-08-14 19:38 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> Currently, Kconfig does not report anything about the recursive >>> dependency where 'imply' keywords are involved. >>> >

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-14 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> Currently, Kconfig does not report anything about the recursive >> dependency where 'imply' keywords are involved. >> >> [Test Code] >> >> config A >> bool "

Re: [PATCH 1/2] kconfig: report recursive dependency involving 'imply'

2018-08-14 Thread Dirk Gouders
Masahiro Yamada writes: > Currently, Kconfig does not report anything about the recursive > dependency where 'imply' keywords are involved. > > [Test Code] > > config A > bool "a" > > config B > bool "b" > imply A > depends on A Hello Masahiro, obviou

[PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory

2018-08-02 Thread Dirk Gouders
The files auto.conf and tristate.conf are mandatory for building modules.builtin files, therefore include them as such. Usually, the top-level Makefile ensures that those files exist but we want to make sure we get noticed if they are missing for whatever reason. Signed-off-by: Dirk Gouders

Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig

2018-07-20 Thread Dirk Gouders
Christoph Hellwig writes: > On Wed, Jul 18, 2018 at 12:06:26AM -0700, Randy Dunlap wrote: >> All $ARCH look equivalent except for microblaze and nios2. >> For those, the config SWAP in init/Kconfig (line 221) comes before (and >> hence takes precedence) over arch/$(SRCARCH)/Kconfig settings, whic

[PATCH v2] checkpatch: kbuild: if_changed: check for multiple calls in targets

2018-07-20 Thread Dirk Gouders
U-BOOT image format) 684151a75bf25f5ae (sparc32: added U-Boot build target: uImage) Reviewed-by: Joe Perches Suggested-by: Masahiro Yamada Signed-off-by: Dirk Gouders --- v2: rework commit message and regular expression --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions

Re: [PATCH] kconfig: handle format string before calling conf_message_callback()

2018-07-17 Thread Dirk Gouders
Masahiro Yamada writes: > As you see in mconf.c and nconf.c, conf_message_callback() hooks are > likely to end up with the boilerplate of vsnprintf(). Process the > string format before calling conf_message_callback() so that it > receives a simple string. I looked at and tested this patch and

Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-17 Thread Dirk Gouders
Joe Perches writes: > On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: >> Because the kbuild function if_changed writes the command line to a >> .cmd file for later tests, multiple calls of that function within a >> target would result in overwrites of previous v

[PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Dirk Gouders
: Masahiro Yamada Signed-off-by: Dirk Gouders --- scripts/checkpatch.pl | 8 1 file changed, 8 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 447857ffaf6b..b0aadf23148e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2911,6 +2911,14 @@ sub

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-14 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-12 20:32 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>>> Dirk Gouders writes: >>>> >>>> I think, I solved the puzzle and perhaps, that saves

Re: [PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-13 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-10 20:34 GMT+09:00 Dirk Gouders : >> Masahiro Yamada writes: >> >>> The main motivation of this patch series is to suppress the syncconfig >>> during running installation targets. >>> >>> V1 consisted of o

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-12 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >>> Dirk Gouders writes: >>> >>>> Dirk Gouders writes: >>>> >>>>> Masahiro Yamada writes: >>>>> >>>>&g

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-12 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-07-09 20:39 GMT+09:00 Dirk Gouders : >> Dirk Gouders writes: >> >>> Dirk Gouders writes: >>> >>>> Masahiro Yamada writes: >>>> >>>>> syncconfig updates the .config only when sym_cha

Re: [PATCH v3 00/12] kbuild/kconfig: do not update config during installation

2018-07-10 Thread Dirk Gouders
Masahiro Yamada writes: > The main motivation of this patch series is to suppress the syncconfig > during running installation targets. > > V1 consisted of only two patches: > https://patchwork.kernel.org/patch/10468105/ > https://patchwork.kernel.org/patch/10468103/ > > I noticed that instal

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-09 Thread Dirk Gouders
Dirk Gouders writes: > Dirk Gouders writes: > >> Masahiro Yamada writes: >> >>> syncconfig updates the .config only when sym_change_count > 0, i.e. >>> any change in config symbols has been detected. >>> >>> Not only symbols but als

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-06 Thread Dirk Gouders
Dirk Gouders writes: > Masahiro Yamada writes: > >> syncconfig updates the .config only when sym_change_count > 0, i.e. >> any change in config symbols has been detected. >> >> Not only symbols but also comments are contained in the .config file. >> If

Re: [PATCH v3 05/12] kconfig: make syncconfig update .config regardless of sym_change_count

2018-07-06 Thread Dirk Gouders
Masahiro Yamada writes: > syncconfig updates the .config only when sym_change_count > 0, i.e. > any change in config symbols has been detected. > > Not only symbols but also comments are contained in the .config file. > If only comments are updated, they are not fed back to the .config, > then th

[RFC v9 1/1] mconf: global i-search in menu prompts

2018-06-23 Thread Dirk Gouders
existing text. It was extended by a parameter "height" and in combination with the parameter "width" it now makes sure that the whole region (width x height) is overwritten. * The function conf() now returns the key the user pressed so that calling functions can operate de

[RFC v9 0/1] mconf: global i-search in menu prompts

2018-06-23 Thread Dirk Gouders
ce terminates isearch and -- except ESC ESC -- is further processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu prompts scripts/

Re: [RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-21 Thread Dirk Gouders
Randy Dunlap writes: > On 06/20/2018 11:55 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi, >>> >>> On 06/20/2018 01:42 AM, Dirk Gouders wrote: >>>> >>>> Operation >>>> - >>>> The TAB

Re: [RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
Randy Dunlap writes: > Hi, > > On 06/20/2018 01:42 AM, Dirk Gouders wrote: >> >> Operation >> - >> The TAB key is reserved to toggle the focus between menu and bottons. >> Focus is on the buttons if one of the buttens (the active one) is >&

[RFC v8 0/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu prompts scripts/kconfig/lkc.h| 1 + scripts/kconfig/lxdialog/checklist.c |

[RFC v8 1/1] mconf: global i-search in menu prompts

2018-06-20 Thread Dirk Gouders
existing text. It was extended by a parameter "height" and in combination with the parameter "width" it now makes sure that the whole region (width x height) is overwritten. * The function conf() now returns the key the user pressed so that calling functions can operate de

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > On 06/19/2018 11:47 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi Dirk, >>> >>> On 06/17/2018 05:15 AM, Dirk Gouders wrote: >>>> >>>> At any time, at most one i-search is active and the nav

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > Hi Dirk, > > On 06/17/2018 05:15 AM, Dirk Gouders wrote: >> >> At any time, at most one i-search is active and the navigation path to >> the current menu is displayed in the subtitle, the second line in the >> menu window. > > Nic

[RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-17 Thread Dirk Gouders
tion conf() now returns the key the user pressed so that calling functions can operate depending on that key. Signed-off-by: Dirk Gouders --- scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdialog/dialog.h| 3 +- scripts/kconfig/lxdialog/inputbox.c | 2 +- scripts/

[RFC v7 0/1] mconf: global i-search in menu prompts

2018-06-17 Thread Dirk Gouders
phanumeric characters and space terminates isearch and -- except ESC ESC -- is further processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-sear

[RFC v6 1/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
simply type 'n', 'f' and 's'. Hint: use the 'z' key with focus on buttons to search for invisible prompts. Signed-off-by: Dirk Gouders Suggested-by: Sam Ravnborg --- scripts/kconfig/lxdialog/checklist.c | 2 +- scripts/kconfig/lxdialog/dialog.h

[RFC v6 0/1] mconf: global i-search in menu structure

2018-06-15 Thread Dirk Gouders
terminates isearch and -- except ESC ESC -- is further processed, e.g. ENTER terminates isearch and is then used to navigate into a submenu. * Problems with mismatches and matches above the current position were fixed. Dirk Gouders (1): mconf: global i-search in menu structure scripts/kconfig

[RFC v5 0/1] i-search navigation for mconf

2018-06-11 Thread Dirk Gouders
with mismatches and matches above the current position were fixed. Dirk Gouders (1): i-search navigation for mconf scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menubox.c | 489 +++-- scripts/kconfig/lxdialog/util.c| 106 +++- sc

[RFC v5 1/1] i-search navigation for mconf

2018-06-11 Thread Dirk Gouders
# Enter the submenu Suggested-by: Sam Ravnborg Signed-off-by: Dirk Gouders --- scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menubox.c | 489 +++-- scripts/kconfig/lxdialog/util.c| 106 +++- scripts/kconfig/mconf.c

Re: [RFC v4 0/1] i-search functionality for mconf

2018-06-09 Thread Dirk Gouders
Sam Ravnborg writes: > Hi Dirk. > > On Fri, Jun 08, 2018 at 08:46:05PM +0200, Dirk Gouders wrote: >> Hello, >> >> this version is a prototype of the idea, Sam suggested -- I hope I >> undestood it correctly. >> >> This is a remarkable ch

[RFC v4 0/1] i-search functionality for mconf

2018-06-08 Thread Dirk Gouders
earch mode, for a detailed description see 1/1. As stated earlier, this is just a prototype, documentation is missing and the code is not ready for a real commit. Dirk Dirk Gouders (1): Isearch functionality for mconf scripts/kconfig/lxdialog/dialog.h | 3 + scripts/kconfig/lxdialog/menu

[RFC v4 1/1] i-search functionality for mconf

2018-06-08 Thread Dirk Gouders
This patch prototypes isearch functionality for mconf based on an idea of Sam Ravnborg: * mconf now distinguishes if the focus is on the menu items or the buttons below it. * At startup focus is on the menu items and alphanumeric characters or space entered are used to form a string that is

[RFC v3 1/1] Emacs-like isearch for mconf.

2018-06-08 Thread Dirk Gouders
# navigate to Device Drivers 3) ENTER# terminate isearch and enter submenu 4) \# start isearch 5) USB # navigate to USB support 6) ENTER# terminate isearch and enter submenu Signed-off-by: Dirk Gouders --- Documentation/kbuild

[RFC v3 0/1] Emacs-like isearch for mconf.

2018-06-08 Thread Dirk Gouders
blems with mismatches and matches above the current position were fixed. Dirk Gouders (1): Emacs-like isearch for mconf. Documentation/kbuild/kconfig.txt | 18 +++- scripts/kconfig/lxdialog/dialog.h | 6 ++ scripts/kconfig/lxdialog/menubox.c | 171

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-08 Thread Dirk Gouders
Sam Ravnborg writes: >> >> I'd say it's not important to start isearch with CTRL-s, I am just so >> used to it. So, I am open for suggestions. > > Today we have first or one of the first letters as shortcut to menus. > How about considering everything typed as search inputs. > Search is then st

[RFC v2 0/1] Emacs-like isearch for mconf.

2018-06-07 Thread Dirk Gouders
*** BLURB HERE *** Hello, this is v2 of the isearch implementation, I also added Documentation changes which probably have to be split, because the older symbol-search also was undokumented in mconf (I basically copied the relevant documentation from Documentation/kbuild/kconfig.txt. I could

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Masahiro Yamada writes: > 2018-06-07 8:54 GMT+09:00 Dirk Gouders : >> Randy Dunlap writes: >> >>> On 06/06/2018 03:32 PM, Dirk Gouders wrote: >>>> Randy Dunlap writes: >>>> >>>>> On 06/06/2018 02:56 PM, Dirk Gouders wrote: >

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Randy Dunlap writes: > On 06/06/2018 03:32 PM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> On 06/06/2018 02:56 PM, Dirk Gouders wrote: >>>> Hello, >>>> >>>> being an Emacs user, I frequently find myself pressing CTRL-s in m

Re: [RFC 1/1] Emacs-like isearch for mconf.

2018-06-06 Thread Dirk Gouders
Segher Boessenkool writes: > On Wed, Jun 06, 2018 at 11:58:55PM +0200, Dirk Gouders wrote: >> @@ -332,6 +332,7 @@ int init_dialog(const char *backtitle) >> >> keypad(stdscr, TRUE); >> cbreak(); >> +raw(); /* Enable CTRL-sequence

Re: [RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
Randy Dunlap writes: > On 06/06/2018 02:56 PM, Dirk Gouders wrote: >> Hello, >> >> being an Emacs user, I frequently find myself pressing CTRL-s in mconf >> to search for some menu entry, especially in large menus. >> >> I decided to implement a basic

[RFC 1/1] Emacs-like isearch for mconf.

2018-06-06 Thread Dirk Gouders
--- scripts/kconfig/lxdialog/dialog.h | 5 ++ scripts/kconfig/lxdialog/menubox.c | 140 - scripts/kconfig/lxdialog/util.c| 1 + 3 files changed, 145 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog

[RFC 0/1] mconf: Emacs-like isearch

2018-06-06 Thread Dirk Gouders
anyone find this functionality useful. Thanks, Dirk Dirk Gouders (1): Emacs-like isearch for mconf. scripts/kconfig/lxdialog/dialog.h | 5 ++ scripts/kconfig/lxdialog/menubox.c | 140 - scripts/kconfig/lxdialog/util.c| 1 + 3 files changed, 145

[RFC PATCH] mconf: expand show_all_options to choices' checklist menus

2016-04-30 Thread Dirk Gouders
Boolean choices' checklist menus are currently immune against the 'z' key that toggles visibility of all options. Expansion of the 'z' toggle could be of use when debugging problems with comlex choice menus. A new tag 'z' for dialog_items was introduced for

Re: [PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-21 Thread Dirk Gouders
Bobby Powers writes: > Hi, > > Dirk Gouders wrote: >> Yes, I was suggesting something similar (but without founded reasoning), >> some time ago [1]. > > I submitted a patch for this a few days ago, but I didn't realize I > should CC linux-kbuild@ (my bad): &

Re: [PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-20 Thread Dirk Gouders
Ingo Molnar writes: > * Dirk Gouders wrote: > >> For example on Gentoo systems where _FORTIFY_SOURCE is set by default, >> `make -C tools/perf' fails, because of the macro being redefined. >> >> Fix that by a feature-check analogous to tools/perf/config/M

[PATCH] tools/lib/api/Makefile: Add feature check for _FORTIFY_SOURCE

2015-04-20 Thread Dirk Gouders
For example on Gentoo systems where _FORTIFY_SOURCE is set by default, `make -C tools/perf' fails, because of the macro being redefined. Fix that by a feature-check analogous to tools/perf/config/Makefile. Signed-off-by: Dirk Gouders --- tools/lib/api/Makefile | 9 - 1 file chang

Re: [PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c

2014-10-07 Thread Dirk Gouders
CC: Michal added Paul Bolle writes: > On Mon, 2014-09-22 at 19:13 +0200, Martin Walch wrote: >> expr_eliminate_dups2() in scripts/kconfig/expr.c applies two bad >> inference rules: >> >> (FOO || BAR) && (!FOO && !BAR) -> n >> (FOO && BAR) || (!FOO || !BAR) -> y >> >> They would be correct in p

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-20 Thread Dirk Gouders
Bjorn Helgaas writes: > On Sat, Sep 13, 2014 at 09:41:34PM +0200, Dirk Gouders wrote: >> So, I did some tests on the VX50 which probably wasn't the worst idea, >> because it behaves different than the test machine. >> >> Summary: >> >> 1)

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-19 Thread Dirk Gouders
Dirk Gouders writes: > Yinghai Lu writes: > >> On Fri, Sep 12, 2014 at 5:11 PM, Dirk Gouders wrote: >>> Yinghai Lu writes: >>> >>> Yes, I skip them in pci_scan_device() to get the unused bus number space >>> that 0a.0 and 0b.0 then can use when

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-19 Thread Dirk Gouders
Yinghai Lu writes: > On Fri, Sep 12, 2014 at 5:11 PM, Dirk Gouders wrote: >> Yinghai Lu writes: >> >> Yes, I skip them in pci_scan_device() to get the unused bus number space >> that 0a.0 and 0b.0 then can use when reconfiguration is triggered. > > That is n

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-14 Thread Dirk Gouders
Andreas Noever writes: > Updated version with dmi strings. Dirk can you test this (without pci=nocrs) > and look for > PCI: Ignoring host bridge windows from ACPI > If it does not show up then I have messed up the DMI_MATCH macros. In that > case > please try to boot with pci=nocrs. Reboot wit

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-14 Thread Dirk Gouders
Andreas Noever writes: > This is an implementation of fix 1 (Add a quirk to fix the _CRS information > based on what amd_bus.c read from the hardware) which makes pci=nocrs ignore > bus numbers from crs. > > If this works then we can add the board to the crs blacklist (Dirk can you > attach the

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-13 Thread Dirk Gouders
Dirk Gouders writes: > Bjorn Helgaas writes: > >> I want to fix this regression before v3.17. Dirk, can you test the >> following patch on top of v3.17-rc2? I'm hoping you can try this on your >> test machine in conjunction with your acpi_pci_root_add() and >&g

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-13 Thread Dirk Gouders
> > For that reason, I like fix 2, but we don't know whether it actually > works, > and we don't have a patch for it yet. > > This revert is fix 3, which also sweeps the LSI FC issue under the rug. > > Link: https://bugzilla.kernel.org/s

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Yinghai Lu writes: > On Fri, Sep 12, 2014 at 3:05 PM, Dirk Gouders wrote: >> Yinghai Lu writes: >> >>> On Fri, Sep 12, 2014 at 1:54 PM, Dirk Gouders wrote: >>>> Yinghai Lu writes: >>>> >>>>> On Fri, Sep 12, 2014 at 1:05 PM, D

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Yinghai Lu writes: > On Fri, Sep 12, 2014 at 1:54 PM, Dirk Gouders wrote: >> Yinghai Lu writes: >> >>> On Fri, Sep 12, 2014 at 1:05 PM, Dirk Gouders wrote: >>>> Dirk Gouders writes: >> -[:00]-+-01.0-[01-02]--+-0d.0-[02]-- >>

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Yinghai Lu writes: > On Fri, Sep 12, 2014 at 1:05 PM, Dirk Gouders wrote: >> Dirk Gouders writes: >> >> I now applied your patches and tested them: >> >> echo 1 > /sys/bus/pci/devices/\:00\:0a.0/pcie_link_disable >> echo 0 > /sys/bus/pci/devic

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Dirk Gouders writes: > Dirk Gouders writes: > >> Bjorn Helgaas writes: >> >>> On Thu, Sep 11, 2014 at 3:24 PM, Dirk Gouders wrote: >>>> Bjorn Helgaas writes: >>>> >>>>> On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-12 Thread Dirk Gouders
Dirk Gouders writes: > Bjorn Helgaas writes: > >> On Thu, Sep 11, 2014 at 3:24 PM, Dirk Gouders wrote: >>> Bjorn Helgaas writes: >>> >>>> On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders wrote: >>>>> What I was currently trying was to co

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Bjorn Helgaas writes: > On Thu, Sep 11, 2014 at 3:24 PM, Dirk Gouders wrote: >> Bjorn Helgaas writes: >> >>> On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders wrote: >>>> What I was currently trying was to construct a test-environment so that >>>> I

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Bjorn Helgaas writes: > On Thu, Sep 11, 2014 at 2:33 PM, Dirk Gouders wrote: >> What I was currently trying was to construct a test-environment so that >> I do not need to do tests and diagnosis on a busy machine. >> >> I noticed that this problem seems to start wit

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Yinghai Lu writes: > On Thu, Sep 11, 2014 at 10:30 AM, Bjorn Helgaas wrote: >> [+cc linux-pci] >> >> >> On Thu, Sep 11, 2014 at 7:43 AM, Dirk Gouders wrote: >>> Andreas Noever writes: >>> >>>> On Wed, Sep 3, 2014 at 2:47 PM, Dirk Goud

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-11 Thread Dirk Gouders
Yinghai Lu writes: > On Thu, Sep 11, 2014 at 10:30 AM, Bjorn Helgaas wrote: >> [+cc linux-pci] >> >> >> On Thu, Sep 11, 2014 at 7:43 AM, Dirk Gouders wrote: >>> Andreas Noever writes: >>> >>>> On Wed, Sep 3, 2014 at 2:47 PM, Dirk Goud

Re: [BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-03 Thread Dirk Gouders
Andreas Noever writes: > On Wed, Sep 3, 2014 at 2:47 PM, Dirk Gouders wrote: >> Andreas Noever writes: >> >>> On Wed, Sep 3, 2014 at 12:57 PM, Dirk Gouders wrote: >>>> On a Tyan VX50 (B4985) I ran into problems when updating the kernel: the >>

[BUG] Bisected Problem with LSI PCI FC Adapter

2014-09-03 Thread Dirk Gouders
On a Tyan VX50 (B4985) I ran into problems when updating the kernel: the PCI FC Adapter is no longer recognized. Actually, this machine caused more problems, because I was not able to get it run with fedora, debian or ubuntu but I am somewhat sure that has to do with grub2 and now I am (again) run

Re: [PATCH 1/2] kbuild: Support split debug info v3

2014-07-24 Thread Dirk Gouders
Andi Kleen writes: >> echo time make -j4 -s KCFLAGS=-gsplit-dwarf >> time make -j4 -s KCFLAGS=-gsplit-dwarf >> echo time make -j4 -s KCFLAGS=-g >> time make -j4 -s KCFLAGS=-g >> echo time make -j4 -s KCFLAGS=-gsplit-dwarf >> time make -j4 -s KCFLAGS=-gsplit-dwarf >> echo time make -j4 -s KCFLAGS=

Re: [PATCH] kbuild: Support split debug info

2014-02-09 Thread Dirk Gouders
Andi Kleen writes: > This is an alternative approach to lower the overhead of debug info > (as we discussed a few days ago) > > gcc 4.7+ and newer binutils have a new "split debug info" debug info > model where the debug info is only written once into central ".dwo" files. > > This avoids having

Re: [RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

2013-11-06 Thread Dirk Gouders
Joe Perches writes: > On Tue, 2013-10-22 at 14:15 +0200, Dirk Gouders wrote: >> Hello Joe, >> >> when having a look at printk.c, I noticed that two comments refer >> to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore. >> >> While at i

Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

2013-10-28 Thread Dirk Gouders
Johannes Berg writes: > On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote: >> The wext internal chandefs for ibss should be created using the >> cfg80211_chandef_create() functions. Otherwise the center_freq1 field >> will not be set and cfg80211_chandef_valid() will spit a warning and >>

Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

2013-10-28 Thread Dirk Gouders
Johannes Berg writes: > On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote: >> The wext internal chandefs for ibss should be created using the >> cfg80211_chandef_create() functions. Otherwise the center_freq1 field >> will not be set and cfg80211_chandef_valid() will spit a warning and >>

Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation

2013-10-22 Thread Dirk Gouders
ould be used. Thanks a lot, Simon, I don't see anymore traces here. Tested-by: Dirk Gouders > Reported-by: Dirk Gouders > Signed-off-by: Simon Wunderlich > Cc: Johannes Berg > --- > net/wireless/ibss.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) &

Re: [BUG bisected] WARNING: CPU: 0 PID: 1550 at net/wireless/chan.c:373 cfg80211_chandef_usable+0x30/0x15f()

2013-10-22 Thread Dirk Gouders
Hi Simon, Simon Wunderlich writes: > Hey Dirk, > >> No need for censorship, I did some quick tests and stripped down my >> wpa_supplicant.conf to a single entry. With this configuration I get a >> lot of traces: >> >> ctrl_interface=/var/run/wpa_supplicant >> eapol_version=1 >> ap_scan=1 >> fa

Re: [BUG bisected] WARNING: CPU: 0 PID: 1550 at net/wireless/chan.c:373 cfg80211_chandef_usable+0x30/0x15f()

2013-10-22 Thread Dirk Gouders
[ 363.739997] brcmsmac bcma0:0: brcms_ops_bss_info_changed: Beacon enabled: false [ 363.740008] brcmsmac bcma0:0: brcms_ops_bss_info_changed: IBSS joined: false (implement) > Thanks, > Simon > > On Mon, Oct 21, 2013 at 02:09:40PM +0200, Dirk Gouders wrote: >> Hello Simon, al

[RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?

2013-10-22 Thread Dirk Gouders
00:00:00 2001 From: Dirk Gouders Date: Tue, 22 Oct 2013 13:51:15 +0200 Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of /proc/vmcoreinfo In one of those comments a typo was fixed, too. Signed-off-by: Dirk Gouders --- kernel/printk/printk.c | 4 ++-- 1 file changed

[BUG bisected] WARNING: CPU: 0 PID: 1550 at net/wireless/chan.c:373 cfg80211_chandef_usable+0x30/0x15f()

2013-10-21 Thread Dirk Gouders
Hello Simon, all, Recently, I noticed many traces (find a sample attached) in situations when wpa_supplicant is running but no appropriate access-point available. I started a bisect and ended at commit 3aede78aad2a7e (mac80211: change IBSS channel state to chandef). Please let me know if you nee

Re: [PATCH 4/4] kconfig: remove unused definition from scanner

2013-10-03 Thread Dirk Gouders
Martin Walch writes: > On Wednesday 02 October 2013 08:57:54 Yann E. MORIN wrote: >> On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote: >> > I think you should also regenerate the scanner and add >> > the new zconf.lex.c_shipped to this patch. >> &g

Re: [PATCH 4/4] kconfig: remove unused definition from scanner

2013-10-02 Thread Dirk Gouders
Martin Walch writes: > From: Martin Walch > Date: Wed, 2 Oct 2013 06:58:46 +0200 > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner > > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion. Hi Martin, I think you should also regenerate the scanner and a

  1   2   >