Re: [PATCH v6 5/5] input: mt: cleanup open-coded __set_bit()

2020-07-15 Thread Dmitry Torokhov
On Mon, Jul 13, 2020 at 02:24:55AM +0200, Michał Mirosław wrote: > Replace open-coded __set_bit() with the function. > > Signed-off-by: Michał Mirosław Applied, thank you. -- Dmitry

[git pull] Input updates for v5.8-rc5

2020-07-13 Thread Dmitry Torokhov
wakeup count on touch Dmitry Torokhov (1): Revert "Input: elants_i2c - report resolution information for touch major" Ilya Katsnelson (1): Input: synaptics - enable InterTouch for ThinkPad X1E 1st gen Merlijn Wajer (2): Input: add `SW_MACHINE_COVER` ARM: dts: n9

Re: [PATCH 2/2] Input: elan_i2c - High resolution report for new pattern 2.

2020-07-12 Thread Dmitry Torokhov
Hi Jingle, On Fri, Jul 10, 2020 at 01:41:16AM -0400, Jingle Wu wrote: > Due to the higer resolution touchpads would be produced, > The mainly modifications were as below: > 1. the former resolution bits were not enough. Extend the > resolution bits from 12 to 16 bits. > 2. Increase the report ID

Re: [PATCH 1/2] Input: elan_i2c - Add ic type 0x11 0x13 0x14.

2020-07-12 Thread Dmitry Torokhov
Hi Jingle, On Fri, Jul 10, 2020 at 01:40:47AM -0400, Jingle Wu wrote: > Modify the iap method for all IC. > Get the correct value of ic_type for old and new pattern of > firmware. Could you please tell me what devices this patch was tested with? I want to be sure we are not only adding support

Re: [PATCH] Input: elan_i2c - Add more hardware ID for Lenovo laptop

2020-07-08 Thread 'Dmitry Torokhov'
On Mon, Dec 02, 2019 at 11:07:26AM +0800, Dave.Wang wrote: > Hi Dmitry, > > List device with its corresponding hardware ID as below patch, > Please check , thanks! > > Add more hardware ID for Lenovo laptop. > > Signed-off-by: Dave Wang Applied, thank you. -- Dmitry

Re: [PATCH] tty/sysrq: Add alternative SysRq key

2020-07-08 Thread Dmitry Torokhov
Hi Andrzej, On Fri, Jun 19, 2020 at 06:28:19PM +0200, Andrzej Pietrasiewicz wrote: > There exist machines which don't have SysRq key at all, e.g. chromebooks. > > This patch allows configuring an alternative key to act as SysRq. Devices > which declare KEY_SYSRQ in their 'keybit' bitmap continue

Re: [PATCH][next] Input: Use fallthrough pseudo-keyword

2020-07-07 Thread Dmitry Torokhov
On Tue, Jul 07, 2020 at 01:08:57PM -0500, Gustavo A. R. Silva wrote: > Replace the existing /* fall through */ comments and its variants with > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > fall-through markings when it is the case. > > [1] >

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-06 Thread Dmitry Torokhov
On Thu, Jul 02, 2020 at 08:57:55AM +0200, Andrzej Hajda wrote: > > On 30.06.2020 20:00, Dmitry Torokhov wrote: > > On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: > >> > >> On 30.06.2020 10:59, Grygorii Strashko wrote: > >>> Hi > >>> >

Re: [PATCH] input: misc: remove needless check before usb_free_coherent()

2020-07-06 Thread Dmitry Torokhov
Hi, On Tue, Jun 30, 2020 at 06:36:16AM +, Chen Ni wrote: > From: Xu Wang > > usb_free_coherent() is safe with NULL addr and this check is > not required. > > Signed-off-by: Xu Wang Even if you are passing on a patch created by someone else you still need to add your "signed-off-by" to

Re: [PATCH] input/synaptics: enable InterTouch for ThinkPad X1E 1st gen

2020-07-06 Thread Dmitry Torokhov
On Fri, Jul 03, 2020 at 05:34:55PM +0300, K900 wrote: > From: Ilya Katsnelson > > Tested on my own laptop, touchpad feels slightly more responsive with > this on, though it might just be placebo. > > Signed-off-by: Ilya Katsnelson Applied, thank you. -- Dmitry

Re: [PATCH v2] Input: elan_i2c - only increment wakeup count on touch

2020-07-06 Thread Dmitry Torokhov
On Mon, Jul 06, 2020 at 04:50:46PM -0700, Derek Basehore wrote: > This moves the wakeup increment for elan devices to the touch report. > This prevents the drivers from incorrectly reporting a wakeup when the > resume callback resets then device, which causes an interrupt to > occur. > >

Re: [PATCH] input: elantech: remove redundant assignments to variable error

2020-07-06 Thread Dmitry Torokhov
On Wed, Jun 03, 2020 at 03:04:31PM +0100, Colin King wrote: > From: Colin Ian King > > The variable error is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused

Re: [PATCH 0/2] Add SW_MACHINE_COVER key

2020-06-30 Thread Dmitry Torokhov
On Fri, Jun 12, 2020 at 02:53:57PM +0200, Merlijn Wajer wrote: Applied, thank you. -- Dmitry

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-30 Thread Dmitry Torokhov
On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: > > > On 30.06.2020 10:59, Grygorii Strashko wrote: > > Hi > > > > On 29/06/2020 14:28, Andrzej Hajda wrote: > >> Hi Grygorii, > >> > >> (...) > >> > /* > * deferred_devs_show() - Show the devices in the deferred probe >

Re: input maintainer -- are you there? was Re: [PATCH 1/2] Input: add `SW_MACHINE_COVER`

2020-06-29 Thread Dmitry Torokhov
On Mon, Jun 29, 2020 at 03:36:44PM +0200, Pavel Machek wrote: > Hi! > > > Looks like we're blocking on this input patch. > > > > On 16/06/2020 12:50, Pavel Machek wrote: > > > On Fri 2020-06-12 14:53:58, Merlijn Wajer wrote: > > >> This event code represents the state of a removable cover of a

Re: [PATCH] Input: elan_i2c - only increment wakeup count on touch

2020-06-29 Thread Dmitry Torokhov
On Mon, Jun 29, 2020 at 05:57:07PM -0700, Derek Basehore wrote: > This moves the wakeup increment for elan devices to the touch report. > This prevents the drivers from incorrectly reporting a wakeup when the > resume callback resets then device, which causes an interrupt to > occur. This also

Re: [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper

2020-06-24 Thread Dmitry Torokhov
On Mon, Jun 08, 2020 at 01:22:08PM +0200, Andrzej Pietrasiewicz wrote: > A new helper is available, so use it. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/acpi/button.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/button.c

Re: [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-24 Thread Dmitry Torokhov
On Wed, Jun 24, 2020 at 05:00:09PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz > wrote: > > > > Inspecting input device's 'users' member should be done under device's > > mutex, so add appropriate invocations. > > > > Signed-off-by: Andrzej Pietrasiewicz

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Dmitry Torokhov
On Wed, Jun 10, 2020 at 09:52:12PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Dmitry Torokhov > > Sent: Wednesday, June 10, 2020 4:41 PM > > To: Limonciello, Mario > > Cc: enric.balle...@collabora.com; r...@rjwysocki.net; raf..

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-10 Thread Dmitry Torokhov
On Wed, Jun 10, 2020 at 09:28:36PM +, mario.limoncie...@dell.com wrote: > > > > To give you some references, if I'm not wrong, this prefix is used in all > > or > > almost all Intel Chromebook devices (auron, cyan, eve, fizz, hatch, > > octopus, > > poppy, strago ...) The ACPI source for this

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-10 Thread Dmitry Torokhov
On Wed, Jun 10, 2020 at 12:38:30PM +0200, Rafael J. Wysocki wrote: > On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: > > > > Hi All, > > > > On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: > > > This is a quick respin of v3, with just two small changes, please see > > > the changelog below.

[git pull] Input updates for v5.8-rc0

2020-06-09 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. You will get: - a new driver for Azoteq IQS269A capacitive touch controller - a new driver for Cypress CY8CTMA140 touchscreen - updates to Elan

[PATCH v2] HID: usbhid: do not sleep when opening device

2020-06-09 Thread Dmitry Torokhov
in the future when we should start processing the events. Reported-by: Nicolas Boichat Signed-off-by: Dmitry Torokhov --- v2: switched from using jiffies to ktime_t to make sure we won't have issues with jiffies overflowing. drivers/hid/usbhid/hid-core.c | 53

Re: [PATCH v3 0/7] Support inhibiting input devices

2020-06-07 Thread Dmitry Torokhov
On Sun, Jun 07, 2020 at 10:24:14PM +0200, Pavel Machek wrote: > On Fri 2020-06-05 19:33:28, Andrzej Pietrasiewicz wrote: > > Userspace might want to implement a policy to temporarily disregard input > > from certain devices. > > Wow, you certainly cc a lot of lists. > > > An example use case is

Re: [PATCH v4] platform: x86: Add ACPI driver for ChromeOS

2020-06-06 Thread Dmitry Torokhov
Hi Rafael, On Fri, Jun 05, 2020 at 01:17:15PM +0200, Rafael J. Wysocki wrote: > > First off, GGL0001 is not a valid ACPI device ID, because the GGL prefix is > not > present in the list at https://uefi.org/acpi_id_list > > There are two ways to address that. One would be to take the GOOG

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2020 at 06:22:49PM -0700, Guenter Roeck wrote: > On Fri, May 29, 2020 at 6:09 PM Dmitry Torokhov > wrote: > > > > On Fri, May 29, 2020 at 05:48:26PM -0700, Guenter Roeck wrote: > > > On Fri, May 29, 2020 at 4:50 PM Nicolas Boichat > > > w

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2020 at 05:48:26PM -0700, Guenter Roeck wrote: > On Fri, May 29, 2020 at 4:50 PM Nicolas Boichat wrote: > > > > On Sat, May 30, 2020 at 3:59 AM Dmitry Torokhov > > wrote: > > > > > > usbhid tries to give the device 50 milliseconds to drain i

Re: [PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2020 at 01:14:24PM -0700, Guenter Roeck wrote: > On Fri, May 29, 2020 at 12:59:51PM -0700, Dmitry Torokhov wrote: > > usbhid tries to give the device 50 milliseconds to drain its queues > > when opening the device, but does it naively by simply sleeping in open >

[PATCH] HID: usbhid: do not sleep when opening device

2020-05-29 Thread Dmitry Torokhov
in the future when we should start processing the events. Reported-by: Nicolas Boichat Signed-off-by: Dmitry Torokhov --- drivers/hid/usbhid/hid-core.c | 27 +++ drivers/hid/usbhid/usbhid.h | 1 + 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/hid

[git pull] Input updates for v5.7-rc7

2020-05-27 Thread Dmitry Torokhov
(), not flush() Christophe JAILLET (1): Input: dlink-dir685-touchkeys - fix a typo in driver name Dennis Kadioglu (1): Input: synaptics - add a second working PNP_ID for Lenovo T470s Dmitry Torokhov (1): Revert "Input: i8042 - add ThinkPad S230u to i8042 nomux list" Enric Ballet

Re: [PATCH v11 00/56] atmel_mxt_ts misc

2020-05-27 Thread Dmitry Torokhov
Hi Jiada, On Thu, May 07, 2020 at 10:56:00PM -0700, Jiada Wang wrote: > This patch-set forward ports Nick Dyer's work in ndyer/linux github > repository as long as some other features and fixes Sorry for ignoring the series for quite a while. I guess my biggest issue with the series is that

Re: [PATCH] Input: elantech - Remove read/write registers in attr.

2020-05-25 Thread Dmitry Torokhov
Hi Jingle, On Tue, May 26, 2020 at 10:22:46AM +0800, Jingle.Wu wrote: > New Elan IC would not be accessed with the specific regiters. What about older Elaan parts? We can't simply drop compatibility with older chips in newer kernels. Thanks. -- Dmitry

Re: [PATCH v3] vt: keyboard: avoid signed integer overflow in k_ascii

2020-05-25 Thread Dmitry Torokhov
[ Sorry, forgot to CC Kyungtae ] On Mon, May 25, 2020 at 04:27:40PM -0700, Dmitry Torokhov wrote: > When k_ascii is invoked several times in a row there is a potential for > signed integer overflow: > > UBSAN: Undefined behaviour in drivers/tty/vt/keyboard.c:888:19 signed integer

[PATCH v3] vt: keyboard: avoid signed integer overflow in k_ascii

2020-05-25 Thread Dmitry Torokhov
to signal that number pad is being used to compose a symbol, and change type of the accumulator from signed to unsigned, thus avoiding undefined behavior when it overflows. Reported-by: Kyungtae Kim Signed-off-by: Dmitry Torokhov --- - marking the patch as v3 as it is a successor of Kyungtae's patches

Re: [PATCH v2] vt: keyboard: avoid integer overflow in k_ascii

2020-05-25 Thread Dmitry Torokhov
On Mon, May 25, 2020 at 09:15:07AM +0200, Greg KH wrote: > On Sun, May 24, 2020 at 05:08:23PM -0700, Dmitry Torokhov wrote: > > On Sat, May 23, 2020 at 11:09:35PM +, Kyungtae Kim wrote: > > > @@ -884,8 +884,11 @@ static void k_ascii(struct vc_data *vc, unsigned > > &g

Re: [PATCH 2/2] kobject: send KOBJ_REMOVE uevent when the object is removed from sysfs

2020-05-25 Thread Dmitry Torokhov
On Sun, May 24, 2020 at 8:34 AM Greg Kroah-Hartman wrote: > > It is possible for a KOBJ_REMOVE uevent to be sent to userspace way > after the files are actually gone from sysfs, due to how reference > counting for kobjects work. This should not be a problem, but it would > be good to properly

Re: [PATCH v2] vt: keyboard: avoid integer overflow in k_ascii

2020-05-24 Thread Dmitry Torokhov
On Sat, May 23, 2020 at 11:09:35PM +, Kyungtae Kim wrote: > @@ -884,8 +884,11 @@ static void k_ascii(struct vc_data *vc, unsigned char > value, char up_flag) > > if (npadch == -1) > npadch = value; > + else if (!check_mul_overflow(npadch, base, _npadch) && > +

[PATCH] HID: magicmouse: do not set up autorepeat

2020-05-24 Thread Dmitry Torokhov
Neither the trackpad, nor the mouse want input core to generate autorepeat events for their buttons, so let's reset the bit (as hid-input sets it for these devices based on the usage vendor code). Reported-by: Yariv Tested-by: Yariv Signed-off-by: Dmitry Torokhov --- Jiri, Benjamin

Re: [PATCH] kobject: Make sure the parent does not get released before its children

2020-05-23 Thread Dmitry Torokhov
On Sat, May 23, 2020 at 8:48 AM Randy Dunlap wrote: > > On 5/23/20 8:36 AM, Greg Kroah-Hartman wrote: > > On Wed, May 13, 2020 at 06:18:40PM +0300, Heikki Krogerus wrote: > >> In the function kobject_cleanup(), kobject_del(kobj) is > >> called before the kobj->release(). That makes it possible to

Re: linux-next: Tree for May 18 (input/misc/iqs269a.c & regmap)

2020-05-22 Thread Dmitry Torokhov
On Fri, May 22, 2020 at 11:22:39AM -0700, Randy Dunlap wrote: > On 5/18/20 9:20 AM, Jeff LaBundy wrote: > > Hi Randy et al, > > > > On Mon, May 18, 2020 at 08:42:43AM -0700, Randy Dunlap wrote: > >> On 5/18/20 3:57 AM, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Changes since 20200515: >

Re: [PATCH] vt: keyboard: avoid integer overflow in k_ascii

2020-05-21 Thread Dmitry Torokhov
On Thu, May 21, 2020 at 11:31:39PM +, Kyungtae Kim wrote: > On Wed, May 20, 2020 at 11:36:02PM -0700, Dmitry Torokhov wrote: > > Hi, > > > > On Thu, May 21, 2020 at 01:34:08AM +, Kyungtae Kim wrote: > > > FuzzUSB (a variant of syzkaller) found an integer ov

Re: [PATCH] vt: keyboard: avoid integer overflow in k_ascii

2020-05-21 Thread Dmitry Torokhov
Hi, On Thu, May 21, 2020 at 01:34:08AM +, Kyungtae Kim wrote: > FuzzUSB (a variant of syzkaller) found an integer overflow > while processing keycode value. > > Reference: https://lkml.org/lkml/2020/3/22/482 > > This bug occurs because of no validity check when operating keycode values. >

Re: [PATCHv3 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support

2020-05-21 Thread Dmitry Torokhov
On Wed, May 20, 2020 at 11:20:03PM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, May 20, 2020 at 10:45:19AM -0700, Dmitry Torokhov wrote: > > Hi Sebastian, > > > > On Wed, May 20, 2020 at 05:39:34PM +0200, Sebastian Reichel wrote: > > > > > >

Re: [PATCHv3 4/5] Input: EXC3000: Add support to query model and fw_version

2020-05-20 Thread Dmitry Torokhov
On Wed, May 20, 2020 at 11:25:40PM +0200, Sebastian Reichel wrote: > Hi, > > On Wed, May 20, 2020 at 10:49:52AM -0700, Dmitry Torokhov wrote: > > Hi Sebastian, > > > > On Wed, May 20, 2020 at 05:39:35PM +0200, Sebastian Reichel wrote: > > > Expose model

Re: [PATCHv3 4/5] Input: EXC3000: Add support to query model and fw_version

2020-05-20 Thread Dmitry Torokhov
Hi Sebastian, On Wed, May 20, 2020 at 05:39:35PM +0200, Sebastian Reichel wrote: > Expose model and fw_version via sysfs. Also query the model > in probe to make sure, that the I2C communication with the > device works before successfully probing the driver. > > This is a bit complicated, since

Re: [PATCHv3 3/5] Input: EXC3000: add EXC80H60 and EXC80H84 support

2020-05-20 Thread Dmitry Torokhov
Hi Sebastian, On Wed, May 20, 2020 at 05:39:34PM +0200, Sebastian Reichel wrote: > > data->client = client; > + data->info = device_get_match_data(>dev); > + if (!data->info) { > + enum eeti_dev_id eeti_dev_id = > + i2c_match_id(exc3000_id,

Re: [PATCHv3 2/5] Input: EXC3000: switch to i2c's probe_new API

2020-05-20 Thread Dmitry Torokhov
On Wed, May 20, 2020 at 05:39:33PM +0200, Sebastian Reichel wrote: > Switch to the "new" I2C probe API. > > Signed-off-by: Sebastian Reichel Applied, thank you. -- Dmitry

Re: [PATCH] input: i8042: Remove special PowerPC handling

2020-05-20 Thread Dmitry Torokhov
inux-next. So perhaps this should go via > the input tree. > > Dmitry do you want to take this, or should I take it via powerpc? > > Original patch is here: > > https://lore.kernel.org/lkml/20200518181043.3363953-1-natechancel...@gmail.com I'm fine with you taking it through powerpc. Acked-by: Dmitry Torokhov Also, while I have your attention ;), could you please ack or take https://lore.kernel.org/lkml/20191002214854.GA114387@dtor-ws/ as I believe this is the last user or input_polled_dev API and I would like to drop it from the tree. Thanks! -- Dmitry

Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property

2020-05-20 Thread Dmitry Torokhov
Hi Johan, On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > touchscreen@3e: reg:0:0: 56 was expected > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > was

Re: [PATCH] Input: omap-keypad - fix runtime pm imbalance on error

2020-05-20 Thread Dmitry Torokhov
Hi Dinghao, On Wed, May 20, 2020 at 6:35 AM Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. This is a very surprising

Re: [PATCH v5 01/10] input: elants: document some registers and values

2020-05-17 Thread Dmitry Torokhov
On Sun, Apr 26, 2020 at 07:47:49PM +0200, Michał Mirosław wrote: > Add information found in downstream kernels, to make the code less > magic. > > Signed-off-by: Michał Mirosław > Reviewed-by: Dmitry Osipenko > Tested-by: Dmitry Osipenko > --- > drivers/input/touchscreen/elants_i2c.c | 29

Re: [PATCH v5 07/10] input: elants: support 0x66 reply opcode for reporting touches

2020-05-17 Thread Dmitry Torokhov
On Sun, Apr 26, 2020 at 07:47:52PM +0200, Michał Mirosław wrote: > From: Dmitry Osipenko > > eKTF3624 touchscreen firmware uses two variants of the reply opcodes for > reporting touch events: one is 0x63 (used by older firmware) and other is > 0x66 (used by newer firmware). The 0x66 variant is

Re: [PATCH v5 05/10] input: elants: refactor elants_i2c_execute_command()

2020-05-17 Thread Dmitry Torokhov
On Sun, Apr 26, 2020 at 07:47:51PM +0200, Michał Mirosław wrote: > Apply some DRY-ing to elants_i2c_execute_command() callers. This pulls > polling and error printk()s into a single function. > > Signed-off-by: Michał Mirosław Applied, thank you. -- Dmitry

Re: [PATCH v5 04/10] input: elants: override touchscreen info with DT properties

2020-05-17 Thread Dmitry Torokhov
On Sun, Apr 26, 2020 at 07:47:51PM +0200, Michał Mirosław wrote: > Allow overriding of information from hardware and support additional > common DT properties like axis inversion. This is required for eg. > Nexus 7 and TF300T where the programmed values in firmware differ > from reality. > >

Re: [PATCH v5 03/10] input: elants: remove unused axes

2020-05-17 Thread Dmitry Torokhov
On Sun, Apr 26, 2020 at 07:47:50PM +0200, Michał Mirosław wrote: > Driver only ever reports MT events and input_mt_init_slots() sets up > emulated axes already. Clear the capabilities not generated directly > and move MT axes setup, so they are visible by input_mt_init_slots(). > >

Re: [PATCH] input: keyboard: imx_sc_key: Use devm_add_action_or_reset() to handle all cleanups

2020-05-13 Thread Dmitry Torokhov
On Fri, Mar 13, 2020 at 02:59:11PM +0800, Anson Huang wrote: > Use devm_add_action_or_reset() to handle all cleanups of failure in > .probe and .remove, then .remove callback can be dropped. > > Signed-off-by: Anson Huang Applied, thank you. -- Dmitry

Re: [PATCH v2 RESEND 1/2] dt-bindings: Input: remove msm-vibrator

2020-05-12 Thread Dmitry Torokhov
On Tue, May 12, 2020 at 09:31:39PM -0400, Brian Masney wrote: > The address referenced in this binding is within the Qualcomm Clock > namespace so let's drop the msm-vibrator bindings so that a more > generic solution can be used instead. No one is currently using these > bindings so this won't

Re: [PATCH v2 RESEND 2/2] Input: remove msm-vibrator driver

2020-05-12 Thread Dmitry Torokhov
On Tue, May 12, 2020 at 09:31:40PM -0400, Brian Masney wrote: > The address referenced by this driver is within the Qualcomm Clock > namespace so let's drop the msm-vibrator bindings so that a more generic > solution can be used instead. No one is currently using driver so this > won't affect any

Re: [PATCH v2 1/4] dt-bindings: input: gpio-vibrator: Don't require enable-gpios

2020-05-12 Thread Dmitry Torokhov
On Wed, May 13, 2020 at 01:05:57AM +0200, Ondřej Jirman wrote: > On Tue, May 12, 2020 at 03:52:12PM -0700, Dmitry Torokhov wrote: > > On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote: > > > It is possible to turn the motor on/off just by enabling/disabling &g

Re: [PATCH v2 1/4] dt-bindings: input: gpio-vibrator: Don't require enable-gpios

2020-05-12 Thread Dmitry Torokhov
On Wed, May 13, 2020 at 12:22:02AM +0200, Ondrej Jirman wrote: > It is possible to turn the motor on/off just by enabling/disabling > the vcc-supply. > > Signed-off-by: Ondrej Jirman > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/input/gpio-vibrator.yaml | 1 - > 1 file

Re: [PATCH] Input: elants_i2c: Provide an attribute to show calibration count

2020-05-12 Thread Dmitry Torokhov
On Wed, May 06, 2020 at 04:48:52PM +0800, Johnny Chuang wrote: > From: Johnny Chuang > > There is an non-touch case by non-calibration after update firmware. > Elan could know calibrate or not by calibration count. > The value of '0x' means we didn't calibrate after update firmware. > If

Re: [PATCH 2/3] input: serio: allow more than one byte to be sent at once

2020-05-12 Thread Dmitry Torokhov
On Tue, May 12, 2020 at 10:07:24AM +0100, Sean Young wrote: > On Mon, May 11, 2020 at 08:51:18AM +0200, Greg KH wrote: > > On Thu, May 07, 2020 at 09:59:18PM +0100, Sean Young wrote: > > > On Thu, May 07, 2020 at 01:25:46PM -0700, Dmitry Torokhov wrote: > > > > On T

Re: [PATCH v11 08/56] Input: atmel_mxt_ts - implement T15 Key Array support

2020-05-11 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 10:56:08PM -0700, Jiada Wang wrote: > From: Nick Dyer > > There is a key array object in many maXTouch chips which allows some X/Y > lines to be used as a key array. This patch maps them to a series of keys > which may be configured in a platform data array. > >

Re: [PATCH v11 07/56] Input: atmel_mxt_ts - implement T9 vector/orientation support

2020-05-11 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 10:56:07PM -0700, Jiada Wang wrote: > From: Nick Dyer > > The atmel touch messages contain orientation information as a byte in a > packed format which can be passed straight on to Android if the input > device configuration is correct. No, unfortunately I can not accept

Re: [PATCH v11 05/56] Input: atmel_mxt_ts - output status from T48 Noise Supression

2020-05-11 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 10:56:05PM -0700, Jiada Wang wrote: > From: Nick Dyer > > This patch outputs status from T48 Noise Supression > > Signed-off-by: Nick Dyer > Acked-by: Benson Leung > Acked-by: Yufeng Shen > (cherry picked from ndyer/linux/for-upstream commit >

Re: [PATCH v11 04/56] Input: atmel_mxt_ts - split large i2c transfers into blocks

2020-05-11 Thread Dmitry Torokhov
Hi Jiada, Nick, On Thu, May 07, 2020 at 10:56:04PM -0700, Jiada Wang wrote: > From: Nick Dyer > > On some firmware variants, the size of the info block exceeds what can > be read in a single transfer. Is this limitation of the mXT controller or maybe it is issue with implementation of the

Re: [PATCH 1/1] dt-bindings: input: touchscreen: elants_i2c: convert to YAML

2020-05-11 Thread Dmitry Torokhov
On Mon, May 11, 2020 at 03:37:09PM -0500, Rob Herring wrote: > On Thu, 23 Apr 2020 19:32:53 +0200, David Heidelberg wrote: > > Convert elants_i2c.txt DT binding to YAML and put into correct directory. > > > > Reviewed-by: Dmitry Osipenko > > Signed-off-by: David Heidelberg > > --- > >

Re: [PATCH] Input: Replace zero-length array with flexible-array

2020-05-07 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 01:53:47PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

Re: [PATCH] input/misc/drv260x: Remove a useless comparison

2020-05-07 Thread Dmitry Torokhov
Hi, On Thu, May 07, 2020 at 01:16:17PM +0800, ChenTao wrote: > Fix the following warning: > > 'mode' and 'library' are u32, they are never be negative, > DRV260X_LRA_MODE and DRV260X_LIB_EMPTY are 0x00, the comparison > is always false. The fact that the symbolic names resolve to 0 is just a

Re: [PATCH 2/2] Input: add driver for power button on Dell Wyse 3020

2020-05-07 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 07:46:44PM +0200, Pavel Machek wrote: > Hi! > > > +struct ec_input_response { > > + u8 reserved; > > + u8 msg_counter:2; > > + u8 count:2; > > + u8 type:4; > > + u8 data[3]; > > +} __packed; > > Bitfields, and relying on them being in the right place for >

Re: [PATCH] Input: wm831x-ts - add missed input_unregister_device

2020-05-07 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 11:12:59PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in remove. > Add the missed function call to fix it. The input device in question is devm-managed and therefore does not need explicit

Re: [PATCH] Input: stmpe-ts - add missed input_unregister_device

2020-05-07 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 11:12:13PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in remove. > Add the missed function call to fix it. The input device in question is devm-managed and therefore does not need explicit

Re: [PATCH] Input: stmfts - add missed input_unregister_device

2020-05-07 Thread Dmitry Torokhov
On Thu, May 07, 2020 at 11:11:47PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in probe failure and remove. > Add the missed function calls to fix it. The input device in question is devm-managed and therefore does not

Re: [PATCH] Input: s6sy761 - add missed input_unregister_device

2020-05-07 Thread Dmitry Torokhov
Hi Chuhong, On Thu, May 07, 2020 at 11:11:15PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in probe failure and remove. > Add the missed function calls to fix it. The input device in question is devm-managed and

Re: [PATCH] Input: applespi - add missed input_unregister_device

2020-05-07 Thread Dmitry Torokhov
Hi Chuhong, On Thu, May 07, 2020 at 11:10:41PM +0800, Chuhong Yuan wrote: > This driver calls input_register_device() in probe, but misses > input_unregister_device() in probe failure and remove. > Add the missed function calls to fix it. The input device in question is devm-managed and

Re: [PATCH 2/5] input: misc: bma150: Conditionally disable bma023 support

2020-05-06 Thread Dmitry Torokhov
On Wed, May 06, 2020 at 08:46:12PM -0700, Jonathan Bakker wrote: > Hi Linus, > > On 2020-05-06 5:46 a.m., Linus Walleij wrote: > > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker wrote: > > > >> The bma180 IIO driver has been extended for support for bma023. > >> However, this could cause

Re: [PATCH] input: lm8333: update contact email

2020-05-05 Thread Dmitry Torokhov
On Sat, May 02, 2020 at 04:26:39PM +0200, Wolfram Sang wrote: > The 'pengutronix' address is defunct for years. Use the proper contact > address. > > Signed-off-by: Wolfram Sang Applied, thank you. > --- > include/linux/input/lm8333.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH 1/2] dt-bindings: input: Add Dell Wyse 3020 Power Button binding

2020-05-05 Thread Dmitry Torokhov
Hi Lubomir, On Sun, May 03, 2020 at 10:12:36PM +0200, Lubomir Rintel wrote: > Add binding document for the Dell Wyse 3020 a.k.a. "Ariel" Power Button. > > Signed-off-by: Lubomir Rintel Are there any changes compared to the version Rob has acked? Thanks. -- Dmitry

Re: linux-next: Signed-off-by missing for commit in the input-current tree

2020-04-28 Thread Dmitry Torokhov
Hi Stephen, On Tue, Apr 28, 2020 at 06:24:41PM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > f4dec2d61609 ("Revert "Input: i8042 - add ThinkPad S230u to i8042 nomux > list"") > > is missing a Signed-off-by from its author and committer. > > Reverts are commits as well ... Yes,

Re: [PATCH v2 2/2] HID: google: Add of_match table to Whiskers switch device.

2019-10-22 Thread Dmitry Torokhov
On Mon, Oct 21, 2019 at 11:02:33AM +0800, Ikjoon Jang wrote: > Add a device tree match table. > > Signed-off-by: Ikjoon Jang Reviewed-by: Dmitry Torokhov > --- > drivers/hid/hid-google-hammer.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH v2 1/2] dt-bindings: input: Add DT bindings for Whiskers switch

2019-10-22 Thread Dmitry Torokhov
+title: ChromeOS Hammer's Base Attached Switch > + > +maintainers: > + - Dmitry Torokhov > + > +description: > + On some ChromeOS devices with a foldable variant of Hammer base, > SW_TABLET_MODE > + event should be generated with proper consideration of current de

[PATCH 0/8] Face lift for st1232 touchscreen driver

2019-10-22 Thread Dmitry Torokhov
This series cleans up the driver and switches it over to the slotted multi-touch protocol (MT-B) that should reduce the traffic between kernel and userspace. Note that I do not have hardware, so I would appreciate if you could try running it and tell me if it is broken or not. Thanks! Dmitry

[PATCH 4/8] Input: st1232 - do not reset the chip too early

2019-10-22 Thread Dmitry Torokhov
We should not be putting the chip into reset while interrupts are enabled and ISR may be running. Fix this by installing a custom devm action and powering off the device/resetting GPIO line from there. This ensures proper ordering. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen

[PATCH 3/8] Input: st1232 - rely on I2C core to configure wakeup interrupt

2019-10-22 Thread Dmitry Torokhov
When I2C client is created with I2C_CLIENT_WAKE flag (which happens either because we have "wakeup-source" device property or the flag was passed in when creating an I2C client manually), I2C core will take care of configuring interrupt as wakeup source on suspend. Signed-off-by: Dmitr

[PATCH 2/8] Input: st1232 - do not unconditionally configure as wakeup source

2019-10-22 Thread Dmitry Torokhov
Do not unconditionally configure the touchscreen as wakeup source but rather rely on I2C core to do that when requested (either via "wakeup-source" device property, or when creating a client with I2C_CLIENT_WAKE flag). Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/st

[PATCH 1/8] Input: st1232 - simplify parsing of read buffer

2019-10-22 Thread Dmitry Torokhov
Avoid complex 2-variable loop when parsing touchscreen data to make the code clearer. Acked-by: Martin Kepplinger Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/st1232.c | 50 +++--- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH 7/8] Input: st1232 - note that the receive buffer is DMA-safe

2019-10-22 Thread Dmitry Torokhov
The receiving buffer is allocated separately from the main driver data structure, and is naturally DMA-safe, so mark it as such when building I2C transfer message. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/st1232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 6/8] Input: st1232 - do not set parent device explicitly

2019-10-22 Thread Dmitry Torokhov
devm_input_allocate_device() already sets parent device for us. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/st1232.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c index dfc0c6cb0213..0aee330731c9

[PATCH 8/8] Input: st1232 - switch to using MT-B protocol

2019-10-22 Thread Dmitry Torokhov
Switch the driver to the slotted variant of multitouch protocol (MT-B) with in-kernel tracking of the contacts. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/st1232.c | 110 +++-- 1 file changed, 56 insertions(+), 54 deletions(-) diff --git a/drivers

[PATCH 5/8] Input: st1232 - do not allocate fingers data separately

2019-10-22 Thread Dmitry Torokhov
The finger structure size is quite small and allocating it together with the main driver structure will not increase likelihood of allocation failing, but reduces number of objects needing to be tracked by the allocator and devm. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen

Re: [PATCH 09/22] Input: apanel - switch to using polled mode of input devices

2019-10-21 Thread Dmitry Torokhov
Hi Sven, On Mon, Oct 21, 2019 at 04:05:40PM -0400, Sven Van Asbroeck wrote: > Hi Dmitry, a few minor nags below, inline. Thanks for taking a look. > > On Thu, Oct 17, 2019 at 4:42 PM Dmitry Torokhov > wrote: > > > > We have added polled mode to the normal input

Re: [PATCH] driver:st1633: fixed multitouch incorrect coordinates

2019-10-21 Thread Dmitry Torokhov
. Missed it earlier, sorry. I am applying it, but I wonder if we shoudl not do the patch below as I find the version with 2 loop variables quite confusing. Thanks. -- Dmitry Input: st1232 - simplify parsing of read buffer From: Dmitry Torokhov Signed-off-by: Dmitry Torokhov --- drivers/

[PATCH 1/2] Input: wm97xx - switch to using threaded IRQ

2019-10-18 Thread Dmitry Torokhov
Instead of manually disabling and enabling interrupts and scheduling work to access the device, let's use threaded oneshot interrupt handler. It simplifies things. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/wm97xx-core.c | 42 + include/linux/wm97xx.h

[PATCH 2/2] Input: wm97xx - get rid of irq_enable method in wm97xx_mach_ops

2019-10-18 Thread Dmitry Torokhov
Now that we are using oneshot threaded IRQ this method is not used anymore. Signed-off-by: Dmitry Torokhov --- drivers/input/touchscreen/mainstone-wm97xx.c | 9 - drivers/input/touchscreen/zylonite-wm97xx.c | 9 - include/linux/wm97xx.h | 3 --- 3 files

Re: [PATCH 25/46] ARM: pxa: mainstone-wm97xx: use gpio lookup table

2019-10-18 Thread Dmitry Torokhov
On Fri, Oct 18, 2019 at 09:37:28PM +0200, Arnd Bergmann wrote: > On Fri, Oct 18, 2019 at 8:39 PM Dmitry Torokhov > wrote: > > > > On Fri, Oct 18, 2019 at 05:41:40PM +0200, Arnd Bergmann wrote: > > > This driver hardcodes gpio numbers without a header file. >

Re: Fwd: [PATCH 29/46] Input: touchscreen: use wrapper for pxa2xx ac97 registers

2019-10-18 Thread Dmitry Torokhov
On Fri, Oct 18, 2019 at 09:39:31PM +0200, Arnd Bergmann wrote: > On Fri, Oct 18, 2019 at 8:48 PM Dmitry Torokhov > wrote: > > > > On Fri, Oct 18, 2019 at 05:41:44PM +0200, Arnd Bergmann wrote: > > > To avoid a dependency on the pxa platform header files with > &

Re: [PATCH 29/46] Input: touchscreen: use wrapper for pxa2xx ac97 registers

2019-10-18 Thread Dmitry Torokhov
On Fri, Oct 18, 2019 at 05:41:44PM +0200, Arnd Bergmann wrote: > To avoid a dependency on the pxa platform header files with > hardcoded registers, change the driver to call a wrapper > in the pxa2xx-ac97-lib that encapsulates all the other > ac97 stuff. Not supper happy about adding module

Re: [PATCH 28/46] input: touchscreen: mainstone: sync with zylonite driver

2019-10-18 Thread Dmitry Torokhov
e two by adding the zylonite changes into the mainstone > one, and checking for the zylonite board to order to keep the > default behavior (interrupt enabled) there. > > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Arnd Bergmann Acked-by: Dmitry Torokhov -- Dmitry

Re: [PATCH 27/46] input: touchscreen: mainstone: fix pxa2xx+pxa3xx configuration

2019-10-18 Thread Dmitry Torokhov
On Fri, Oct 18, 2019 at 05:41:42PM +0200, Arnd Bergmann wrote: > There are two different ways of flushing the ac97 queue > in this driver, selected by a compile time option. > > Change this to a runtime selection to make it work when both > are enabled. > > Cc: Dmitry

Re: [PATCH 25/46] ARM: pxa: mainstone-wm97xx: use gpio lookup table

2019-10-18 Thread Dmitry Torokhov
On Fri, Oct 18, 2019 at 05:41:40PM +0200, Arnd Bergmann wrote: > This driver hardcodes gpio numbers without a header file. > Use lookup tables instead. > > Cc: Marek Vasut > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Arnd Bergmann Acked-by: D

<    1   2   3   4   5   6   7   8   9   10   >