Hello Peter,
Thanks a lot for your review and kind advice !
> I don't see a > 80-col line here?
In fact, it was not even a 80-col issue but a mis-aligned parenthesis
one. Realign the rows in this state would make them exceed the 80th
column.
I tend to agree with the fact that the way it currentl
> Does this really look better to you?
>
> Long identifiers like "wait_event_interruptible_timeout"
> (32 chars) make
> using 80 columns a bit silly.
>
> Please remember checkpatch is a stupid script and that
> not every warning it emits is dicta.
Actually, not much and as a matter of fact, I hes
Coding-style-only modifications to remove every warning saying:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Compiled against revision "next-20160327".
(checkpatch.pl was updated to treat "UNSPECIFIED_INT" warnings
as of commit a1ce18e4f94
Removing two "!= NULL" from fwserial.c as suggested by checkpatch.pl.
Note that the associated expression "port->port.console" is a 1-bit-field
that is already assumed as an implicit boolean (that is: without comparison)
Signed-off-by: Dominique van den Broeck
---
d
Fixing a lone row exceeding 80 columns so the only remaining warnings
emitted by checkpatch.pl are missing comments on spinlocks and memory
barriers.
Signed-off-by: Dominique van den Broeck
---
drivers/staging/fwserial/fwserial.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions
Hello Willy,
> I don't want to be nit-picking, but since we're talking about style...
> for me these "} else {" statements are harder to parse than having them
> on two lines this way :
> <...>
>
> It's just a matter of taste I know, but for me they read easier, probably
> because the braces do n
Style-only modifications to comply with checkpatch.pl --strict --file.
. Breaks down compound assignments.
Signed-off-by: Dominique van den Broeck
---
Resent to lay each variable on its single row.
Other patches have been accepted.
Apply on linux-next tree, above:
commit
Style-only modifications to comply with checkpatch.pl --strict --file.
. Correctly realigns the lines that needed to be ;
. Suppress useless blank rows ;
. Fix sizeof() issues in various -malloc() functions.
Signed-off-by: Dominique van den Broeck
---
Apply on linux-next tree, above:
commit
Style-only modifications to comply with checkpatch.pl --strict --file.
. Breaks down compound assignments.
Signed-off-by: Dominique van den Broeck
---
Apply on linux-next tree, above:
commit 4151fa6adc65da14673ece623bbb2acc6936f8be
"Add linux-next specific files for 20140516"
di
Style-only modifications to comply with checkpatch.pl --strict --file.
. Adds every missing brace in condition statements.
Signed-off-by: Dominique van den Broeck
---
Apply on linux-next tree, above:
commit 4151fa6adc65da14673ece623bbb2acc6936f8be
"Add linux-next specific files for 201
Good evening,
Forgive my mistakes, I sent only a few patches yet and I'm still learning.
Nevertheless:
> What is that period in the commit message? And the semicolon?
Semicolons is what one use to ponctuate an enumerated list (at least
in french). In fact, it was their primary use before comput
. userspace pointer dereference ;
These issues have been fixed by a concurrent patch:
. missing inclusions of needed header files (fixed by concurrent patch);
. unrequired static function declaration (confusing another *.c file).
Signed-off-by: Dominique van den Broeck
---
v1 : I submit this
Hello,
Thanks for your comments and reviewing.
> I guess it would be better to have defines for those instead of
> hard-coding the offsets. Also the size of the info_buf array
> might change depending on the size of wrqu->data.pointer, right?
> Maybe create a new define for that as well?
> Let's j
ative codes instead. This patch fixes this.
Signed-off-by: Dominique van den Broeck
---
I submit this patch as a result for Task #16 of the Eudyptula Challenge.
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index c01abc2..a6f2b2b 100644
. userspace pointer dereference ;
. missing inclusions of needed header files ;
. unrequired static function declaration (confusing another *.c file).
Signed-off-by: Dominique van den Broeck
---
I submit this patch as a result for Task #16 of the Eudyptula Challenge.
diff --git a/drivers
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Removed useless "extern" in dma_fifo.h ;
Removed one supernumerary space.
Signed-off-by: Dominique van den Broeck
---
diff -upr a/drivers/staging/fwserial/dma_fifo.h
b/drivers/staging/fwserial/dma_fifo.h
---
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Open parenthesis alignments.
Signed-off-by: Dominique van den Broeck
---
diff -upr a/drivers/staging/fwserial/dma_fifo.c
b/drivers/staging/fwserial/dma_fifo.c
--- a/drivers/staging/fwserial/dma_fifo.c 2014-04-11
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
Removing FSF postal address from file top comment since it has changed in the
past, as stated by checkpatch.pl.
Signed-off-by: Dominique van den Broeck
---
diff -upr a/drivers/staging/fwserial/dma_fifo.c
b/drivers
Style-only modifications to make checkpatch.pl --file --strict a bit happier.
if/else bracket matching (either none or both options should be bracketed).
Signed-off-by: Dominique van den Broeck
---
diff -upr a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
--- a
From: Dominique van den Broeck
fwserial: (unexhaustive) coding style review
linux-next commit 88a8e0969581869c742a9957ddcfe43063dff687
Style-only modifications to make checkpatch.pl --file --strict a bit
happier.
I fixed only what was trivial, such as parenthesis alignments (one of
them,
at
20 matches
Mail list logo
