Re: [Gta04-owner] [PATCH 0/4] UART slave device support - version 4

2015-08-28 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 28.08.2015 um 09:02 schrieb Pavel Machek : > Hi! > >> we (the developers of the hardware) have proposed an alternative >> approach to Neil’s implementation - for the same device and solving >> the same problem (notifying tty open/close and uart activity to the >> slave device driver

Re: [Gta04-owner] [PATCH 0/4] UART slave device support - version 4

2015-08-27 Thread Dr. H. Nikolaus Schaller
Hi Linus, Am 12.08.2015 um 01:20 schrieb NeilBrown : > On Fri, 7 Aug 2015 15:01:47 +0200 Linus Walleij > wrote: > >> Hi Neil, >> >> first, this is a *VERY* interesting and much needed patch series, >> I intend to look closer at it, and if possible test it with some >> (heh) board file device.

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-29 Thread Dr. H. Nikolaus Schaller
Am 29.07.2015 um 19:26 schrieb Dmitry Torokhov : > On Tue, Jul 28, 2015 at 10:13:54PM -0500, Rob Herring wrote: >> On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek >> wrote: >>> Hi Dmitry, >>> >>> On Thu, Jul 23, 2015 at 10:53 PM, Dmitry Torokhov >>> wrote: On Thu, Jul 23, 2015 at 10:38:34

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-29 Thread Dr. H. Nikolaus Schaller
Hi Tomi, Am 29.07.2015 um 07:47 schrieb Dr. H. Nikolaus Schaller : > Hi all, > > Am 29.07.2015 um 05:13 schrieb Rob Herring : > >> On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek >> wrote: >>> Hi Dmitry, >>> >>> On Thu, Jul 23, 2015 at 10:

Re: [PATCH] input: twl4030-vibra: Fix ERROR: Bad of_node_put() warning

2015-07-28 Thread Dr. H. Nikolaus Schaller
Hi all, Am 29.07.2015 um 05:13 schrieb Rob Herring : > On Tue, Jul 28, 2015 at 3:23 PM, Belisko Marek > wrote: >> Hi Dmitry, >> >> On Thu, Jul 23, 2015 at 10:53 PM, Dmitry Torokhov >> wrote: >>> On Thu, Jul 23, 2015 at 10:38:34PM +0200, Marek Belisko wrote: Fix following: [8.862

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.07.2015 um 20:16 schrieb Rob Herring : > On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> 1. add registered uart_ports to a search list >> 2. provide a function to search an uart_port by phandle. This copies the >> mechanism how devm_usb_g

Re: [PATCH RFC v2 3/3] misc: Add w2g0004 gps receiver driver

2015-06-30 Thread Dr. H. Nikolaus Schaller
Hi, thanks for the valid and very valuable comments! We will integrate them into RFC v3. BR, Nikolaus Am 30.06.2015 um 10:23 schrieb Sergei Zviagintsev : > Hi, > > I left some comments below. > > On Sun, Jun 28, 2015 at 09:46:26PM +0200, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >>

Re: [PATCH RFC v2 2/3] tty: serial_core: Add hooks for uart slave drivers

2015-06-29 Thread Dr. H. Nikolaus Schaller
Hi, thanks again. Am 28.06.2015 um 23:51 schrieb Sergei Zviagintsev : > Hi, > > Some minor comments below. > > On Sun, Jun 28, 2015 at 09:46:25PM +0200, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> 1. allow drivers to get notified in mctrl changes >> 2. allow drivers to get noti

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-29 Thread Dr. H. Nikolaus Schaller
Hi, thanks for the comments. Am 28.06.2015 um 23:34 schrieb Sergei Zviagintsev : > Hi, > > Some comments below. > > On Sun, Jun 28, 2015 at 09:46:24PM +0200, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> 1. add registered uart_ports to a search list >> 2. provide a function to se

Re: [Gta04-owner] [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

2015-06-23 Thread Dr. H. Nikolaus Schaller
Hi Neil, Am 01.06.2015 um 23:37 schrieb NeilBrown : > On Mon, 1 Jun 2015 19:06:52 +0530 Kishon Vijay Abraham I > wrote: > >> Hi, >> >> On Thursday 16 April 2015 01:33 PM, NeilBrown wrote: >>> From: NeilBrown >>> >>> The twl4030 phy can measure, with low precision, the >>> resistance-to-groun

Re: [PATCH 1/2] iio: adc: twl4030_madc: Fix calculation of the temperature sense current

2015-06-07 Thread Dr. H. Nikolaus Schaller
Am 07.06.2015 um 18:25 schrieb Jonathan Cameron : > On 28/05/15 20:50, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> The bit mask to read the setting of the constant current source >> for measuring the NTC voltage was the wrong one. Since default >> value is initialized to the lowe

[PATCH RFC 0/3] UART slave device support

2015-06-03 Thread Dr. H. Nikolaus Schaller
Hi all, this patch series is our proposal to add hooks so that the driver for a device connected to an UART can monitor modem control lines and data activity of the connected chip. It contains an example for such a device driver which needs such sophisticated power control: wi2wi,w2sg0004 A rem

Re: [Gta04-owner] [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

2015-06-02 Thread Dr. H. Nikolaus Schaller
Hi, Am 02.06.2015 um 22:11 schrieb Pavel Machek : > On Tue 2015-06-02 16:06:47, Dr. H. Nikolaus Schaller wrote: >> Hi, >> >> Am 02.06.2015 um 15:49 schrieb Kishon Vijay Abraham I : >> >>> Hi, >>> >>> On Tuesday 02 June 2015 03:07 AM, N

Re: [Gta04-owner] [PATCH 5/6] phy: twl4030-usb: add support for reading resistor on ID pin.

2015-06-02 Thread Dr. H. Nikolaus Schaller
Hi, Am 02.06.2015 um 15:49 schrieb Kishon Vijay Abraham I : > Hi, > > On Tuesday 02 June 2015 03:07 AM, NeilBrown wrote: >> On Mon, 1 Jun 2015 19:06:52 +0530 Kishon Vijay Abraham I >> wrote: >> >>> Hi, >>> >>> On Thursday 16 April 2015 01:33 PM, NeilBrown wrote: From: NeilBrown >>

Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent

2015-05-20 Thread Dr. H. Nikolaus Schaller
Am 21.05.2015 um 00:20 schrieb Sebastian Reichel : > Hi, > > On Tue, May 19, 2015 at 10:28:39AM +0200, Dr. H. Nikolaus Schaller wrote: >> Am 19.05.2015 um 09:13 schrieb Krzysztof Kozlowski : >>> Changes since v1: >>> = >>> 1. Patch 2

Re: [RFC/RFT v2 0/2] power_supply: Fix NULL pointer dereference from uevent

2015-05-19 Thread Dr. H. Nikolaus Schaller
Hi, Am 19.05.2015 um 09:13 schrieb Krzysztof Kozlowski : > Hi, > > > Changes since v1: > = > 1. Patch 2: fix invalid member used for container_of(). > 2. Patch 2: Replace WARN with pr_warn() in __power_supply_register() > if parent is missing. > > > Description: > ==

Re: Bug: power supply - NULL pointer dereference in bq27x00 driver

2015-05-18 Thread Dr. H. Nikolaus Schaller
Am 18.05.2015 um 16:09 schrieb Krzysztof Kozlowski : > 2015-05-18 22:30 GMT+09:00 Dr. H. Nikolaus Schaller : >> Hi Krzysztof, >> >> Am 18.05.2015 um 14:32 schrieb Krzysztof Kozlowski : >> >>> 2015-05-18 18:40 GMT+09:00 Dr. H. Nikolaus Schaller : >>&

Re: Bug: power supply - NULL pointer dereference in bq27x00 driver

2015-05-18 Thread Dr. H. Nikolaus Schaller
Hi Krzysztof, Am 18.05.2015 um 14:32 schrieb Krzysztof Kozlowski : > 2015-05-18 18:40 GMT+09:00 Dr. H. Nikolaus Schaller : >> Hi, >> we tried to upgrade from 4.0 to 4.1-rc3 kernel and ran into a NULL pointer >> problem within the bq27x00 driver. >> >> It appea

Bug: power supply - NULL pointer dereference in bq27x00 driver

2015-05-18 Thread Dr. H. Nikolaus Schaller
Hi, we tried to upgrade from 4.0 to 4.1-rc3 kernel and ran into a NULL pointer problem within the bq27x00 driver. It appears to be introduced by your patch 297d716f6260cc9421d971b124ca196b957ee458 The problem appears to be that bq27x00_powersupply_init() calls power_supply_register_no_ws() and

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-13 Thread Dr. H. Nikolaus Schaller
Hi Peter, Am 07.05.2015 um 18:46 schrieb Dr. H. Nikolaus Schaller : > Hi Peter, > > Am 07.05.2015 um 17:51 schrieb Peter Hurley : > >> On 05/07/2015 11:34 AM, Dr. H. Nikolaus Schaller wrote: >>> Am 07.05.2015 um 16:56 schrieb Peter Hurley : >>>> On 05/07/

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-07 Thread Dr. H. Nikolaus Schaller
Hi, Am 07.05.2015 um 18:18 schrieb Peter Hurley : > On 05/07/2015 11:11 AM, Dr. H. Nikolaus Schaller wrote: >> >> Am 07.05.2015 um 16:30 schrieb Peter Hurley : >> >>> On 05/07/2015 08:46 AM, Dr. H. Nikolaus Schaller wrote: >>>> Am 06.05.2015 um 19:18 s

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-07 Thread Dr. H. Nikolaus Schaller
Hi Peter, Am 07.05.2015 um 17:51 schrieb Peter Hurley : > On 05/07/2015 11:34 AM, Dr. H. Nikolaus Schaller wrote: >> Am 07.05.2015 um 16:56 schrieb Peter Hurley : >>> On 05/07/2015 08:46 AM, Dr. H. Nikolaus Schaller wrote: > >>> Both devicetree and tty/serial can

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-07 Thread Dr. H. Nikolaus Schaller
Am 07.05.2015 um 16:56 schrieb Peter Hurley : > On 05/07/2015 08:46 AM, Dr. H. Nikolaus Schaller wrote: > >> So I don’t think that being able to control the slave is a common property >> of all UART-slave connections. >> >> BTW: the GPS chip we use is doing some

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-07 Thread Dr. H. Nikolaus Schaller
Am 07.05.2015 um 16:30 schrieb Peter Hurley : > On 05/07/2015 08:46 AM, Dr. H. Nikolaus Schaller wrote: >> Am 06.05.2015 um 19:18 schrieb Mark Rutland : >>> On Wed, May 06, 2015 at 05:09:20PM +0100, Dr. H. Nikolaus Schaller wrote: >>>> Am 06.05.2015

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-07 Thread Dr. H. Nikolaus Schaller
Hi Mark, Am 06.05.2015 um 19:18 schrieb Mark Rutland : > On Wed, May 06, 2015 at 05:09:20PM +0100, Dr. H. Nikolaus Schaller wrote: >> Hi Mark, >> >> Am 06.05.2015 um 16:15 schrieb Mark Rutland : >> >>>>>>>> No, I am not playing devil’s advocat

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-06 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 06.05.2015 um 16:28 schrieb Pavel Machek : > On Wed 2015-05-06 13:50:29, Dr. H. Nikolaus Schaller wrote: >> Hi Pavel, >> >> Am 06.05.2015 um 11:27 schrieb Pavel Machek : >> >>> On Wed 2015-05-06 07:19:31, Dr. H. Nikolaus Schaller wrote: >&g

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-06 Thread Dr. H. Nikolaus Schaller
Hi Mark, Am 06.05.2015 um 16:15 schrieb Mark Rutland : >> No, I am not playing devil’s advocate (which would imply that I am doing >> this >> for fun to tease the dog), but I feel I have to be the advocate of >> future board >> designers who want to easily import an existing

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-06 Thread Dr. H. Nikolaus Schaller
Hi Mark, Am 06.05.2015 um 14:36 schrieb Mark Rutland : > On Wed, May 06, 2015 at 01:27:03PM +0100, Dr. H. Nikolaus Schaller wrote: >> Hi Peter, >> >> Am 06.05.2015 um 14:05 schrieb Peter Hurley : >> >>> On 05/06/2015 07:50 AM, Dr. H. Nikolaus Schaller wrot

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-06 Thread Dr. H. Nikolaus Schaller
Hi Peter, Am 06.05.2015 um 14:05 schrieb Peter Hurley : > On 05/06/2015 07:50 AM, Dr. H. Nikolaus Schaller wrote: >> No, I am not playing devil’s advocate (which would imply that I am doing this >> for fun to tease the dog), but I feel I have to be the advocate of future >&g

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-06 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 06.05.2015 um 11:27 schrieb Pavel Machek : > On Wed 2015-05-06 07:19:31, Dr. H. Nikolaus Schaller wrote: >> Hi Peter, >> >> Am 05.05.2015 um 21:54 schrieb Peter Hurley : >> >>> Hi Neil, >>> >>> On 03/18/2015 01:58 AM, Neil

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-05 Thread Dr. H. Nikolaus Schaller
Hi Peter, Am 05.05.2015 um 21:54 schrieb Peter Hurley : > Hi Neil, > > On 03/18/2015 01:58 AM, NeilBrown wrote: >> here is version 3 of support for tty-slaves. > > Is there a v4 of this that I missed? We did have a lengthy discussion about [PATCH 3/3] how to best (1) represent the slave device

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-04-28 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 27.04.2015 um 22:35 schrieb Pavel Machek : > Hi! > >>> In my opinion making something a node in / is always the >>> last resort and in my perspective it has been handled in such a way >>> so far. >> >> But that contradicts some documents I have found and linked. Please >> show me a

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-04 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 04.04.2015 um 10:16 schrieb Pavel Machek : > Hi! > Please propose your own code doing that so that we can test if it is better. >>> >>> So, how does this look? >>> >>> It looks to me like you have cca 0.1 Ohm resistance in your system, >> >> This is completely unknown.

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-04-02 Thread Dr. H. Nikolaus Schaller
Hi, Am 30.03.2015 um 12:08 schrieb Johan Hovold : > On Mon, Mar 30, 2015 at 11:32:39AM +0200, Dr. H. Nikolaus Schaller wrote: >> Hi Johan, >> >> Am 30.03.2015 um 09:45 schrieb Johan Hovold : >> >>> On Sat, Mar 28, 2015 at 02:37:57PM +0100, Marek Belisko wro

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-04-02 Thread Dr. H. Nikolaus Schaller
Am 02.04.2015 um 12:35 schrieb Johan Hovold : > On Thu, Apr 02, 2015 at 12:12:37PM +0200, Jonathan Corbet wrote: >> On Sat, 28 Mar 2015 14:37:57 +0100 >> Marek Belisko wrote: >> >>> This patch changes the documentation file as needed. >> >> Applied to the docs tree (with the changelog typo fix

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.04.2015 um 22:16 schrieb Pavel Machek : > Hi! > >>> As I explained in some other mail, those tables should not be >>> neccessary at all. They can be computed from li-ion characteristics >>> and internal resistance, and assumed current during charge and >>> discharge. >> >> I already e

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.04.2015 um 18:30 schrieb Rob Herring : > On Tue, Mar 10, 2015 at 4:27 PM, Marek Belisko wrote: >> Signed-off-by: Marek Belisko >> --- >> .../bindings/power_supply/twl4030_madc_battery.txt | 43 >> ++ >> 1 file changed, 43 insertions(+) >> create mode 100644 >> Doc

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 31.03.2015 um 09:26 schrieb Pavel Machek : > Hi! > > + io-channels = <&twl_madc 1>, > + <&twl_madc 10>, > + <&twl_madc 12>; > + io-channel-names = "temp", > +"ichg", > +

Re: [Gta04-owner] [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-30 Thread Dr. H. Nikolaus Schaller
Am 30.03.2015 um 11:32 schrieb Dr. H. Nikolaus Schaller : > Hi Johan, > > Am 30.03.2015 um 09:45 schrieb Johan Hovold : > >> On Sat, Mar 28, 2015 at 02:37:57PM +0100, Marek Belisko wrote: >>> From: "H. Nikolaus Schaller" >>> >>>

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-30 Thread Dr. H. Nikolaus Schaller
Hi Johan, Am 30.03.2015 um 09:45 schrieb Johan Hovold : > On Sat, Mar 28, 2015 at 02:37:57PM +0100, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> While trying to test the Pyra GSM/GPS/3G module I had reconfigured >> the USB interface by mistake and therefore needed to run a differe

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-27 Thread Dr. H. Nikolaus Schaller
Am 27.03.2015 um 17:31 schrieb Sebastian Reichel : > Hi, > > On Fri, Mar 27, 2015 at 10:22:11AM +0100, Dr. H. Nikolaus Schaller wrote: >>> Coming back at my sentence: I asked about a non-trivial, non-bus >>> connected HW, which has a DT binding. >> >>

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-27 Thread Dr. H. Nikolaus Schaller
Hi, Am 26.03.2015 um 19:08 schrieb Sebastian Reichel : > Hi, > > On Wed, Mar 25, 2015 at 05:44:42PM +0100, Dr. H. Nikolaus Schaller wrote: >> Am 25.03.2015 um 16:21 schrieb Sebastian Reichel : >>> On Wed, Mar 25, 2015 at 08:59:14AM +0100, Dr. H. Nikolaus Schaller wrote:

Re: [PATCH] Documentation: usb: serial: fixed how to provide vendor and product id

2015-03-26 Thread Dr. H. Nikolaus Schaller
Am 26.03.2015 um 11:41 schrieb Belisko Marek : > On Thu, Mar 26, 2015 at 10:53 AM, Greg KH wrote: >> On Wed, Mar 25, 2015 at 09:53:34PM +0100, Marek Belisko wrote: >>> From: "H. Nikolaus Schaller" >>> >>> While trying to test the Pyra GSM/GPS/3G module I had reconfigured >>> the USB interface

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Dr. H. Nikolaus Schaller
Hi, Am 26.03.2015 um 06:56 schrieb Pavel Machek : > Hi! > > Main reason is, that I would need to go > through the UART to “communicate" with the w2sg0004. You can always "communicate” through the UART. Even without DT. As long as the connected chip is powered up by any me

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Dr. H. Nikolaus Schaller
Am 25.03.2015 um 21:53 schrieb Pavel Machek : > Hi! > AFAIK the chip simply starts to emit NMEA records if powered on. There is no command going over the serial interface to address it or control it. >>> >>> Right, since GPS basically doesn't need any configuration/control. >>> T

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Dr. H. Nikolaus Schaller
Hi, Am 25.03.2015 um 21:42 schrieb Pavel Machek : > Hi! > >>> In the case of our GPS, it receives control over the serial connection from >>> the UART, >> >> Ahem - does it? >> >> AFAIK the chip simply starts to emit NMEA records if powered on. There is no >> command going over the serial inte

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Dr. H. Nikolaus Schaller
Hi, Am 25.03.2015 um 16:21 schrieb Sebastian Reichel : > Hi, > > On Wed, Mar 25, 2015 at 08:59:14AM +0100, Dr. H. Nikolaus Schaller wrote: >> Am 25.03.2015 um 02:45 schrieb Sebastian Reichel : >>> On Tue, Mar 24, 2015 at 06:58:15PM +0100, Dr. H. Nikolaus Schaller wrote:

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-25 Thread Dr. H. Nikolaus Schaller
Hi, Am 25.03.2015 um 02:45 schrieb Sebastian Reichel : > Hi, > > On Tue, Mar 24, 2015 at 06:58:15PM +0100, Dr. H. Nikolaus Schaller wrote: >> So you propose that the parent->child relationship is “control”? I.e. some >> channel which allows to address some bus client (

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-24 Thread Dr. H. Nikolaus Schaller
Hi, Am 21.03.2015 um 00:31 schrieb NeilBrown : > On Fri, 20 Mar 2015 10:34:18 +0100 "Dr. H. Nikolaus Schaller" > wrote: > >> >> Am 20.03.2015 um 09:54 schrieb NeilBrown : > >>> There needs to be one device-node for each device, and that device-node

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Dr. H. Nikolaus Schaller
Hi, Am 20.03.2015 um 14:08 schrieb Sebastian Reichel : > Hi, > > On Fri, Mar 20, 2015 at 09:54:21AM +0100, Dr. H. Nikolaus Schaller wrote: >> [...] >> And we do not write a driver for the w2sg0004 but the regulator inside that >> chip. > > DT describes the har

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-20 Thread Dr. H. Nikolaus Schaller
Am 20.03.2015 um 09:54 schrieb NeilBrown : > On Fri, 20 Mar 2015 08:54:38 +0100 "Dr. H. Nikolaus Schaller" > wrote: > >> >> Am 18.03.2015 um 06:58 schrieb NeilBrown : >> >>> If a platform has a particular device permanently attached to a UART, &g

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Dr. H. Nikolaus Schaller
Hi, Am 20.03.2015 um 09:43 schrieb NeilBrown : > On Fri, 20 Mar 2015 08:54:35 +0100 "Dr. H. Nikolaus Schaller" > wrote: > >> Hi Neil, >> >> Am 18.03.2015 um 06:58 schrieb NeilBrown : >> >>> Hi again, >>> here is version 3 of suppo

Re: [Gta04-owner] [PATCH 3/3] tty/slaves: add a driver to power on/off UART attached devices.

2015-03-20 Thread Dr. H. Nikolaus Schaller
Am 18.03.2015 um 06:58 schrieb NeilBrown : > If a platform has a particular device permanently attached to a UART, > there may be out-of-band signaling necessary to power the device > on and off. > > This driver controls that signalling for a number of different devices. > It can > - enable/disa

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-03-20 Thread Dr. H. Nikolaus Schaller
Hi Neil, Am 18.03.2015 um 06:58 schrieb NeilBrown : > Hi again, > here is version 3 of support for tty-slaves. > > This version introduces a new bus-type for tty-slaves, Hm. I am still not convinced that a tty is a „bus“ and that this is a solution for a wide-spread problem. > and causes > a

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-17 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 17.03.2015 um 14:59 schrieb Pavel Machek : > Hi! > >>> to introduce coefficients for temperature and discharge rate? >> What do you mean? Nothing like that is used in current driver why do >> we need to add it? > > Well, conversion between Li-ion's voltage and s

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-17 Thread Dr. H. Nikolaus Schaller
Hi Pavel, Am 17.03.2015 um 11:37 schrieb Pavel Machek : > Hi! > > to introduce coefficients for temperature and discharge rate? What do you mean? Nothing like that is used in current driver why do we need to add it? >>> >>> Well, conversion between Li-ion's voltage and state of ch

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-17 Thread Dr. H. Nikolaus Schaller
Am 17.03.2015 um 09:47 schrieb Pavel Machek : > Hi! > diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt new file mode 100644 index 000..bb3580c --- /de

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-17 Thread Dr. H. Nikolaus Schaller
Am 17.03.2015 um 09:48 schrieb Pavel Machek : >> >> Temperature calibration should have already been done in the underlaying >> twl4030 iio driver. >> >> Discharge rate is the real current flow reported in uA. Also >> reported by iio. > > Ack, but there's rather severe temperature dependency

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-17 Thread Dr. H. Nikolaus Schaller
Hi, Am 17.03.2015 um 09:47 schrieb Pavel Machek : > Hi! > diff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt new file mode 100644 index 000..bb3580c ---

Re: [PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-16 Thread Dr. H. Nikolaus Schaller
Am 16.03.2015 um 22:20 schrieb Belisko Marek : > On Mon, Mar 16, 2015 at 10:05 PM, Pavel Machek wrote: >> On Wed 2015-02-04 23:14:32, Marek Belisko wrote: >>> Signed-off-by: Marek Belisko >>> --- >>> .../bindings/power_supply/twl4030_madc_battery.txt | 43 >>> ++ >>> 1 file

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Dr. H. Nikolaus Schaller
Am 11.03.2015 um 17:44 schrieb Tony Lindgren : > * Dr. H. Nikolaus Schaller [150311 09:17]: >> Hi, >> >> Am 11.03.2015 um 16:24 schrieb Tony Lindgren : >> >>> Hi, >>> >>> * Marek Belisko [150310 14:28]: >>>> Sig

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-03-11 Thread Dr. H. Nikolaus Schaller
Hi, Am 11.03.2015 um 16:24 schrieb Tony Lindgren : > Hi, > > * Marek Belisko [150310 14:28]: >> Signed-off-by: Marek Belisko >> --- >> .../bindings/power_supply/twl4030_madc_battery.txt | 43 >> ++ >> 1 file changed, 43 insertions(+) >> create mode 100644 >> Documentation/

Re: [Gta04-owner] [PATCH 3/4] usb: phy: twl4030: add support for reading restore on ID pin.

2015-03-03 Thread Dr. H. Nikolaus Schaller
Am 04.03.2015 um 07:35 schrieb NeilBrown : > On Mon, 2 Mar 2015 22:04:31 +0100 Pavel Machek wrote: > >> Hi! >> >>> The twl4030 phy can measure, with low precision, the >>> resistance-to-ground of the ID pin. >>> >>> Add a function to read the value, and export the result >>> via sysfs. >>> >

Re: [PATCH] OMAPDSS: restore "name" sysfs entry.

2015-02-24 Thread Dr. H. Nikolaus Schaller
I have tested it with X.Org X Server 1.12.4 Release Date: 2012-08-27 X Protocol Version 11, Revision 0 Build Operating System: Linux 3.2.0-4-mx5 armv7l Debian (coming from Debian Wheezy) on: * gta04 (SPI panel) * openpandora (SPI panel) * BeagleBoard XM (with RGB panel) * PandaBoard ES (w/o pane

Re: [PATCH 1/4] ARM: dts: omap3-pandora: add common device tree

2015-02-12 Thread Dr. H. Nikolaus Schaller
Am 12.02.2015 um 18:47 schrieb Grazvydas Ignotas : > On Thu, Feb 12, 2015 at 3:03 PM, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> This device tree allows to boot, supports the panel, >> framebuffer, touch screen, as well as some more peripherals. >> Since there is a OMAP3530 bas

Re: [PATCH 1/4] ARM: dts: omap3-pandora: add common device tree

2015-02-12 Thread Dr. H. Nikolaus Schaller
Am 12.02.2015 um 17:03 schrieb Tony Lindgren : > Hi, > > Few comments below. > > * Marek Belisko [150212 05:07]: >> + >> +&omap3_pmx_core { >> + >> +mmc1_pins: pinmux_mmc1_pins { >> +pinctrl-single,pins = < >> +OMAP3_CORE1_IOPAD(0x2144, PIN_INPUT_PULLUP | MU

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dr. H. Nikolaus Schaller
Am 15.01.2015 um 19:16 schrieb Dmitry Torokhov : > On Thu, Jan 15, 2015 at 05:14:38PM +0100, Dr. H. Nikolaus Schaller wrote: >> >> Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : >> >>> Hi, >>> >>> On Thu, Jan 15, 2015 at 08:36:44AM +0100,

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dr. H. Nikolaus Schaller
Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : > Hi, > > On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: >>> 1. Perform conversion in input core rather than individual drivers. I >>> think we should allocate a new bitmaps for some trans

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-15 Thread Dr. H. Nikolaus Schaller
Hi, Am 15.01.2015 um 15:38 schrieb Sebastian Reichel : > Hi, > > On Thu, Jan 15, 2015 at 08:36:44AM +0100, Dr. H. Nikolaus Schaller wrote: >>> 1. Perform conversion in input core rather than individual drivers. I >>> think we should allocate a new bitmaps for so

Re: [PATCH 1/3] input: tsc2007: Add pre-calibration, flipping and rotation

2015-01-14 Thread Dr. H. Nikolaus Schaller
Hi, Am 15.01.2015 um 01:59 schrieb Dmitry Torokhov : > On Sat, Jan 10, 2015 at 03:15:39PM +0100, Belisko Marek wrote: >> Ping for input maintainer. DT changes was acked. Thanks. >> >> On Tue, Sep 30, 2014 at 10:17 PM, Marek Belisko wrote: >>> This patch adds new parameters that allow to address

Re: [Gta04-owner] [PATCH 1/2] mmc: core: allow a reset gpio to be configured.

2014-12-01 Thread Dr. H. Nikolaus Schaller
Hi Neil, Am 02.12.2014 um 02:55 schrieb NeilBrown : > On Fri, 28 Nov 2014 12:56:33 +0100 Ulf Hansson wrote: > >> On 8 November 2014 at 01:14, NeilBrown wrote: >>> If the regulator supplying an SDIO device is shared >>> with another device, the turning the regulator 'on' and 'off' >>> will not

Re: [PATCH v2 1/5] video: omapdss: Add opa362 driver

2014-11-19 Thread Dr. H. Nikolaus Schaller
Am 13.11.2014 um 17:41 schrieb Tomi Valkeinen : > On 13/11/14 18:25, Dr. H. Nikolaus Schaller wrote: >> Hi, >> >> Am 13.11.2014 um 12:51 schrieb Tomi Valkeinen : >> >>> On 13/11/14 00:10, Marek Belisko wrote: >>>> opa362 is amplifier for video an

Re: [PATCH v2 1/5] video: omapdss: Add opa362 driver

2014-11-13 Thread Dr. H. Nikolaus Schaller
Hi, Am 13.11.2014 um 12:51 schrieb Tomi Valkeinen : > On 13/11/14 00:10, Marek Belisko wrote: >> opa362 is amplifier for video and can be connected to the tvout pads >> of the OMAP3. It has one gpio control for enable/disable of the output >> (high impedance). >> >> Signed-off-by: H. Nikolaus Sc

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-12 Thread Dr. H. Nikolaus Schaller
Am 12.11.2014 um 16:45 schrieb Grazvydas Ignotas : > On Tue, Nov 4, 2014 at 5:42 PM, Tony Lindgren wrote: >> * Igor Grinberg [141104 05:22]: >>> Hi Tony, >>> >>> On 11/02/14 20:07, Tony Lindgren wrote: Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration") enable

Re: [Gta04-owner] [PATCH 2/3] ASoC: twl4030: allow voice port to be connected externally.

2014-11-09 Thread Dr. H. Nikolaus Schaller
Am 10.11.2014 um 00:25 schrieb NeilBrown : > On Sat, 8 Nov 2014 09:26:22 + Mark Brown wrote: > >> On Sat, Nov 08, 2014 at 11:38:03AM +1100, NeilBrown wrote: >> >>> If voice port on twl4030 is not connected to a McBSP (or similar) >>> then we cannot configure the format the way we normally

Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.

2014-11-07 Thread Dr. H. Nikolaus Schaller
Am 08.11.2014 um 01:22 schrieb NeilBrown : > > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6 >mfd: twl4030-power: Add generic reset configuration > > claims: >Let's add device tree support and configure things for warm reset >as the default when compatible = "ti,twl4030-power". >

Re: [PATCH 2/2] Documentation: devicetree: Add bindings for Wi2Wi w2sg0004 gps

2014-11-02 Thread Dr. H. Nikolaus Schaller
ping (questions for directions at the end of the mail). Am 24.10.2014 um 11:32 schrieb Dr. H. Nikolaus Schaller : > > Am 20.10.2014 um 19:26 schrieb Dr. H. Nikolaus Schaller : > >> Hi, >> >> Am 20.10.2014 um 11:35 schrieb Mark Rutland : >> >>> Hi, &

Re: [PATCH 2/2] Documentation: devicetree: Add bindings for Wi2Wi w2sg0004 gps

2014-10-24 Thread Dr. H. Nikolaus Schaller
Am 20.10.2014 um 19:26 schrieb Dr. H. Nikolaus Schaller : > Hi, > > Am 20.10.2014 um 11:35 schrieb Mark Rutland : > >> Hi, >> >> On Fri, Oct 17, 2014 at 08:55:50PM +0100, Dr. H. Nikolaus Schaller wrote: >>> >>> Am 17.10.2014 um 13:00 schrieb

Re: [PATCH 1/2] misc: Add Wi2Wi w2sc0004 gps driver

2014-10-22 Thread Dr. H. Nikolaus Schaller
Hi, Am 21.10.2014 um 12:49 schrieb Pavel Machek : > Hi! > >> --- a/drivers/misc/Kconfig >> +++ b/drivers/misc/Kconfig >> @@ -515,6 +515,16 @@ config VEXPRESS_SYSCFG >>bus. System Configuration interface is one of the possible means >>of generating transactions on this bus. >> >>

Re: [PATCH 2/2] Documentation: devicetree: Add bindings for Wi2Wi w2sg0004 gps

2014-10-20 Thread Dr. H. Nikolaus Schaller
Hi, Am 20.10.2014 um 11:35 schrieb Mark Rutland : > Hi, > > On Fri, Oct 17, 2014 at 08:55:50PM +0100, Dr. H. Nikolaus Schaller wrote: >> >> Am 17.10.2014 um 13:00 schrieb Mark Rutland : >> >>> On Fri, Oct 17, 2014 at 11:16:42AM +0100, Dr. H. Nikolaus Scha

Re: [PATCH 1/2] misc: Add Wi2Wi w2sc0004 gps driver

2014-10-19 Thread Dr. H. Nikolaus Schaller
Hi, Am 19.10.2014 um 21:51 schrieb Arnd Bergmann : > On Thursday 16 October 2014 22:26:22 Marek Belisko wrote: >> This is a driver for the Wi2Wi GPS modules connected through an UART. >> The tricky part is that the module is turned on or off by an impulse >> on the control line - but it is only p

Re: [PATCH 2/2] Documentation: devicetree: Add bindings for Wi2Wi w2sg0004 gps

2014-10-17 Thread Dr. H. Nikolaus Schaller
Am 17.10.2014 um 13:00 schrieb Mark Rutland : > On Fri, Oct 17, 2014 at 11:16:42AM +0100, Dr. H. Nikolaus Schaller wrote: >> >> Am 17.10.2014 um 11:37 schrieb Mark Rutland : >> >>> On Thu, Oct 16, 2014 at 09:26:23PM +0100, Marek Belisko wrote: >>&g

Re: [PATCH 2/2] Documentation: devicetree: Add bindings for Wi2Wi w2sg0004 gps

2014-10-17 Thread Dr. H. Nikolaus Schaller
Am 17.10.2014 um 11:37 schrieb Mark Rutland : > On Thu, Oct 16, 2014 at 09:26:23PM +0100, Marek Belisko wrote: >> Signed-off-by: H. Nikolaus Schaller >> Signed-off-by: Marek Belisko >> --- >> .../devicetree/bindings/misc/wi2wi,w2sg0004.txt| 44 >> ++ >> 1 file changed, 4

Re: PROBLEM: bindings for drivers/mfd/twl4030-power.c

2014-09-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 25.08.2014 um 23:26 schrieb Tony Lindgren: > * Dr. H. Nikolaus Schaller [140817 08:46]: >> I am trying to make ti,use_poweroff work on 3.17-rc1 for the GTA04 board. >> Poweroff was broken for a while and I found that the driver isn't loaded at >> all. >>

PROBLEM: bindings for drivers/mfd/twl4030-power.c

2014-08-17 Thread Dr. H. Nikolaus Schaller
I am trying to make ti,use_poweroff work on 3.17-rc1 for the GTA04 board. Poweroff was broken for a while and I found that the driver isn't loaded at all. It appears to me that commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6 did rename the compatible entry from "ti,twl4030-power" to "ti,twl4030-p

Re: [PATCH 3/3] arm: dts: Add gta04a5 model

2014-07-29 Thread Dr. H. Nikolaus Schaller
Hi, Am 29.07.2014 um 14:41 schrieb Tony Lindgren: > * Dr. H. Nikolaus Schaller [140728 13:45]: >> >> Yes, >> the boot loader either loads gta04a3.dtb gta04.dtb or gta05.dtb >> depending on board revision. >> >> Therefore we have multiple devic

Re: [PATCH 3/3] arm: dts: Add gta04a5 model

2014-07-28 Thread Dr. H. Nikolaus Schaller
Hi, Am 28.07.2014 um 22:12 schrieb Michael Trimarchi: > Hi > > Il 28/lug/2014 22:06 "Belisko Marek" ha scritto: > > > > On Mon, Jul 28, 2014 at 10:04 PM, Michael Trimarchi > > wrote: > > > Hi > > > > > > Il 28/lug/2014 22:02 "Belisko Marek" ha scritto: > > > > > > > > >> > > >> Hi Michael, >

Re: [PATCH 1/5] arm: dts: omap3-gta04: Add missing nodes to fully describe gta04 board

2014-07-19 Thread Dr. H. Nikolaus Schaller
Hi all, Am 18.07.2014 um 11:21 schrieb Javier Martinez Canillas: > Hello Marek and Dr. H. Nikolaus, > > On Fri, Jul 18, 2014 at 8:55 AM, Joachim Eastwood wrote: >> On 16 July 2014 09:17, Dr. H. Nikolaus Schaller wrote: >>> Am 15.07.2014 um 14:45 schrieb Joachim East

Re: [PATCH 1/5] arm: dts: omap3-gta04: Add missing nodes to fully describe gta04 board

2014-07-16 Thread Dr. H. Nikolaus Schaller
Hi Joachim, is there some policy for only having nodes for existing drivers in DT files? If I understand the device tree concept correctly, it should not describe drivers (and hence nothing about the state of them being mainlined), but it should statically describe the given hardware in a way th

Re: [PATCH] gpio_keys, twl4030-pwrbutton: stay awake for 1sec on resume

2014-06-28 Thread Dr. H. Nikolaus Schaller
Hi, Am 28.06.2014 um 19:08 schrieb Pavel Machek: > Hi! > >> This gives the userspace (Replicant) a chance to fully handle the >> pm_wakeup_event, before autosleep suspends the system alltogether >> again. >> >> This fixes suspend/resume on the OpenPhoenux GTA04, in combination with >> the Replic

Re: [PATCH] w1: avoid recursive device_add

2014-04-16 Thread Dr. H. Nikolaus Schaller
system never saw the > deadlock. > > Reported-by: Belisko Marek > Signed-off-by: David Fries > --- > Evgeniy any comments? The patch looks good to me. > Dr. H. Nikolaus Schaller, Can you give this patch another test? I > don't expect any problems, but it is now o

Re: w1: 3.14-rc7 - possible recursive locking detected

2014-04-14 Thread Dr. H. Nikolaus Schaller
Hi David, I have tested and it appears to suppress the locking issue on our GTA04 board. BR, Nikolaus Am 14.04.2014 um 00:24 schrieb David Fries: > Belisko Marek, > Here is a possible solution, could you give it a try and report back? > > Greg Kroah-Hartman, > Evgeniy asked me to look into this

[PATCH] bma150: extend chip detection for bma180

2014-04-10 Thread Dr. H. Nikolaus Schaller
This driver has been used while on the OpenPhoenux GTA04 with a BMA180. Signed-off-by: H. Nikolaus Schaller --- drivers/input/misc/bma150.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c index 52d3a9b..b36831c 100

[PATCH] tca8418: fix loading this driver as a module from a device tree

2014-04-10 Thread Dr. H. Nikolaus Schaller
Loading the tca8418 driver as a module on a device tree based system needs a MODULE_ALIAS because the driver name does not match the automatic name generation rules of a 'compatible' entry on i2c bus. Signed-off-by: H. Nikolaus Schaller --- drivers/input/keyboard/tca8418_keypad.c | 5 + 1 fi

[PATCH] gpio_keys, twl4030-pwrbutton: stay awake for 1sec on resume

2014-04-10 Thread Dr. H. Nikolaus Schaller
This gives the userspace (e.g. Replicant) a chance to fully handle the pm_wakeup_event, before autosleep suspends the system alltogether again. This fixes suspend/resume on the OpenPhoenux GTA04, in combination with the Replicant 4.2.2 userspace, which needs to execute this to stay awake: 'echo on

[PATCH] bq270x0: minor improvements for daily operation

2014-04-10 Thread Dr. H. Nikolaus Schaller
Improve operation on OpenPhoenux GTA04 board: * treat receiving 0xff from the 1-wire layer as a missing battery * print calibration warning only in debug mode to keep dmesg clean Signed-off-by: NeilBrown Signed-off-by: H. Nikolaus Schaller --- drivers/power/bq27x00_battery.c | 5 - 1 file c

Re: w1: 3.14-rc7 - possible recursive locking detected

2014-03-23 Thread Dr. H. Nikolaus Schaller
Hi, Am 23.03.2014 um 22:50 schrieb David Fries: > On Mon, Mar 17, 2014 at 10:38:13PM +0100, Belisko Marek wrote: >> Hi, >> >> booting latest 3.14-rc7 on gta04 board gives following warning: >> >> [3.101409] Driver for 1-wire Dallas network protocol. >> [3.109649] omap_hdq omap_hdq: OMAP

Re: [PATCH 1 of 1]: musb: fixed a potential NULL pointer dereference.

2014-02-13 Thread Dr. H. Nikolaus Schaller
Am 12.02.2014 um 17:20 schrieb Greg Kroah-Hartman: > On Wed, Feb 12, 2014 at 04:35:12PM +0100, Dr. H. Nikolaus Schaller wrote: >> >> Am 12.02.2014 um 15:29 schrieb Greg Kroah-Hartman: >> >>> On Wed, Feb 12, 2014 at 11:08:22AM +0100, Dr. H. Nikolaus Schaller wrot

Re: [PATCH 1 of 1]: musb: fixed a potential NULL pointer dereference.

2014-02-12 Thread Dr. H. Nikolaus Schaller
Am 12.02.2014 um 15:29 schrieb Greg Kroah-Hartman: > On Wed, Feb 12, 2014 at 11:08:22AM +0100, Dr. H. Nikolaus Schaller wrote: >> fixed a potential NULL pointer dereference. >> >>Rationale: >>this is the only location in the musb driver where the &

[PATCH 1 of 1]: musb: fixed a potential NULL pointer dereference.

2014-02-12 Thread Dr. H. Nikolaus Schaller
fixed a potential NULL pointer dereference. Rationale: this is the only location in the musb driver where the otg->gadget pointer is dereferenced. Assuming that it is never NULL is not only potentially unsafe but was observed in the wild on a GTA04 (OMAP3/TPS65950 based

  1   2   >