Re: [PATCH] Fix fnic driver to remove bogus ratelimit messages.

2021-03-29 Thread Lee Duncan
On 3/24/21 3:41 PM, Joe Perches wrote: > On Tue, 2021-03-23 at 10:27 -0700, ldun...@suse.com wrote: >> From: Lee Duncan >> >> Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid >> looding when vlan is not set by the switch.i") added >> print

Re: [PATCH] Fix fnic driver to remove bogus ratelimit messages.

2021-03-25 Thread Lee Duncan
On 3/24/21 3:41 PM, Joe Perches wrote: > On Tue, 2021-03-23 at 10:27 -0700, ldun...@suse.com wrote: >> From: Lee Duncan >> >> Commit b43abcbbd5b1 ("scsi: fnic: Ratelimit printks to avoid >> looding when vlan is not set by the switch.i") added >> print

Re: [PATCH 5.10 083/102] scsi: iscsi: Restrict sessions and handles to admin capabilities

2021-03-05 Thread Lee Duncan
On 3/5/21 2:42 PM, Pavel Machek wrote: > Hi! > >> From: Lee Duncan >> >> commit 688e8128b7a92df982709a4137ea4588d16f24aa upstream. >> >> Protect the iSCSI transport handle, available in sysfs, by requiring >> CAP_SYS_ADMIN to read it. Also protect the

Re: [PATCH] fnic: fixup patch to resolve stack frame issues

2021-01-27 Thread Lee Duncan
On 1/26/21 11:46 PM, Greg KH wrote: > On Tue, Jan 26, 2021 at 05:21:24PM -0800, Lee Duncan wrote: >> From: Hannes Reinecke >> >> Commit 42ec15ceaea7 fixed a gcc issue with unused variables, but >> introduced errors since it allocated an array of two u64-s but >>

Re: [PATCH] fnic: fixup patch to resolve stack frame issues

2021-01-26 Thread Lee Duncan
On 1/26/21 5:21 PM, Lee Duncan wrote: > From: Hannes Reinecke > > Commit 42ec15ceaea7 fixed a gcc issue with unused variables, but > introduced errors since it allocated an array of two u64-s but > then used more than that. Set the arrays to the proper s

[PATCH] fnic: fixup patch to resolve stack frame issues

2021-01-26 Thread Lee Duncan
-off-by: Hannes Reinecke Signed-off-by: Lee Duncan --- drivers/scsi/fnic/vnic_dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c index 5988c300cc82..d2064b89 100644 --- a/drivers/scsi/fnic/vnic_dev.c +++ b

Re: [PATCH 3/3] drivers: usb: atm: use pr_err() and pr_warn() instead of raw printk()

2020-12-08 Thread Duncan Sands
On 12/8/20 10:32 AM, Enrico Weigelt, metux IT consult wrote: Since we have the nice helpers pr_err() and pr_warn(), use them instead of raw printk(). Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Duncan Sands --- drivers/usb/atm/usbatm.c | 2 +- drivers/usb/atm/xusbatm.c

Re: [PATCH v2 1/1] scsi: libiscsi: fix NOP race condition

2020-10-20 Thread Lee Duncan
On 10/8/20 1:54 PM, Mike Christie wrote: > On 10/8/20 12:11 PM, Mike Christie wrote: >> On 9/25/20 1:41 PM, ldun...@suse.com wrote: >>> From: Lee Duncan >>> >>> iSCSI NOPs are sometimes "lost", mistakenly sent to the >>> user-land iscsid daem

Re: [patch V2 13/13] usb: atm: Replace in_interrupt() usage in comment

2020-10-19 Thread Duncan Sands
. Darwish Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Duncan Sands Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org --- drivers/usb/atm/usbatm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/atm/usbatm.c +++ b/drivers/usb/atm

Re: [PATCH v6 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-10-11 Thread Duncan Laurie
That said it is true that the rest of the cros_ec drivers use distinct ACPI IDs. Bhanu I allocated GOOG0019 for the cros_ec UART interface so you can switch to using that instead. You'll need to update the coreboot interface as well and might want to keep both devices in firmware to ease

Re: [PATCH v2 1/1] scsi: libiscsi: fix NOP race condition

2020-10-02 Thread Lee Duncan
On 9/25/20 11:41 AM, ldun...@suse.com wrote: > From: Lee Duncan > > iSCSI NOPs are sometimes "lost", mistakenly sent to the > user-land iscsid daemon instead of handled in the kernel, > as they should be, resulting in a message from the daemon like: > >> iscsi

Re: [PATCH v9 6/7] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()

2020-10-01 Thread Lee Duncan
iginal open coded checks. > > Signed-off-by: Coly Li > Acked-by: Martin K. Petersen > Cc: Vasily Averin > Cc: Cong Wang > Cc: Mike Christie > Cc: Lee Duncan > Cc: Chris Leech > Cc: Christoph Hellwig > Cc: Hannes Reinecke > --- > drivers/scsi/libiscs

Re: [PATCH] drm/amd/display: Clear dm_state for fast updates

2020-07-27 Thread Duncan
sted for a while now, but only > >> caused a noticeable issue starting from 5.7-rc1 due to 3202fa62f > >> ("slub: relocate freelist pointer to middle of object") moving the > >> freelist pointer from dm_state->base (which was unused) to > >> dm_state-&

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-24 Thread Duncan
e, be "async disabling"? That's what I /thought/ he was referencing. OTOH your base/context swap idea sounds like a possibly "less disturbance" workaround, if it works, and given the point in the commit cycle... (But if it's out Sunday it's likely too late to test and

Re: [PATCH] scsi: Fix reference count leak in iscsi_boot_create_kobj.

2020-05-29 Thread Lee Duncan
p;boot_kobj->kobj); > return NULL; > } > boot_kobj->data = data; > Reviewed-by: Lee Duncan

Re: [PATCH] scsi: qedi: remove unused variable udev & uctrl

2020-05-05 Thread Lee Duncan
= qedi->udev; > - uctrl = udev->uctrl; > - > work = kzalloc(sizeof(*work), GFP_ATOMIC); > if (!work) { > QEDI_WARN(&qedi->dbg_ctx, > Reviewed-by: Lee Duncan -- Lee

Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs

2019-10-04 Thread Duncan Roe
On Thu, Oct 03, 2019 at 10:41:06PM +0800, Haishuang Yan wrote: > > > > On 2019??10??2??, at 9:27, Duncan Roe > > wrote: > > > > On Tue, Oct 01, 2019 at 09:34:13PM +0300, Julian Anastasov wrote: > >> > >>Hello, > >> > >&g

Re: [PATCH v3 0/3] selftests: netfilter: introduce test cases for ipvs

2019-10-01 Thread Duncan Roe
2 +- > > tools/testing/selftests/netfilter/ipvs.sh | 234 > > + > > 2 files changed, 235 insertions(+), 1 deletion(-) > > create mode 100755 tools/testing/selftests/netfilter/ipvs.sh > > Regards > > -- > Julian Anastasov I still prefer #!/bin/sh in 1/3. You never know what's in someone's environment Cheers ... Duncan.

Re: [PATCH v2 1/3] selftests: netfilter: add ipvs test script

2019-10-01 Thread Duncan Roe
netns exec ns2 ip link set veth21 up > > +ip netns exec ns2 ip addr add ${rip_v4}/24 dev veth21 > > +ip netns exec ns2 ip link set veth20 up > > +ip netns exec ns2 ip addr add ${sip_v4}/24 dev veth20 > > +} > > + > > +cleanup() { > > +

[PATCH v2] net/ncsi: Ensure 32-bit boundary for data cksum

2019-08-19 Thread Terry S. Duncan
The NCSI spec indicates that if the data does not end on a 32 bit boundary, one to three padding bytes equal to 0x00 shall be present to align the checksum field to a 32-bit boundary. Signed-off-by: Terry S. Duncan --- net/ncsi/ncsi-cmd.c | 2 +- net/ncsi/ncsi-rsp.c | 9 ++--- 2 files

[PATCH] net/ncsi: Ensure 32-bit boundary for data cksum

2019-08-13 Thread Terry S. Duncan
The NCSI spec indicates that if the data does not end on a 32 bit boundary, one to three padding bytes equal to 0x00 shall be present to align the checksum field to a 32-bit boundary. Signed-off-by: Terry S. Duncan --- net/ncsi/internal.h | 1 + net/ncsi/ncsi-cmd.c | 2 +- net/ncsi/ncsi-rsp.c

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
On 8/13/19 1:54 PM, Terry Duncan wrote: On 8/13/19 11:28 AM, Tao Ren wrote: On 8/13/19 9:31 AM, Terry Duncan wrote: Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
On 8/13/19 12:52 PM, Ben Wei wrote: On 8/13/19 9:31 AM, Terry Duncan wrote: Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system address without it affecting the BMC

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
On 8/13/19 11:28 AM, Tao Ren wrote: On 8/13/19 9:31 AM, Terry Duncan wrote: Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system address without it affecting the BMC

Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-13 Thread Terry Duncan
Tao, in your new patch will it be possible to disable the setting of the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC perhaps with netlink (TBD) to get the system address without it affecting the BMC address. I was about to send patches to add support for the Intel adapters when

Re: [PATCH] platform/chrome: wilco_ec: Add telemetry data char device interface

2019-04-18 Thread Duncan Laurie
r the hardware diagnostic data that they gather here, and the analytics that they run on it, to be critical IP for their enterprise device replacement program. It is clear from feedback that this telemetry command is still too opaque, and we will continue to work with the vendor to try and come up with a more flexible command set that still allows us to implement the interface in the kernel without resorting to the usual tricks to hide it from the user. -duncan

Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-03-07 Thread Lee Duncan
On 3/6/19 10:23 AM, Chris Leech wrote: > On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote: >> From: Lee Duncan >> >> If there is an error queueing an iscsi command in >> iscsi_queuecommand(), for example if the transport fails >> to take the command

[PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

2019-02-25 Thread Lee Duncan
From: Lee Duncan If there is an error queueing an iscsi command in iscsi_queuecommand(), for example if the transport fails to take the command in sessuin->tt->xmit_task(), then the error path can call iscsi_complete_task() without first aquiring the back_lock as required. This can l

Re: [RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task

2019-02-25 Thread Lee Duncan
On 2/25/19 2:02 AM, Johannes Thumshirn wrote: > On 22/02/2019 17:29, Lee Duncan wrote: >> From: Lee Duncan >> >> If there is an error queueing an iscsi command in >> iscsi_queuecommand(), for example if the transport fails >> to take the command in sessuin->tt-

[RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task

2019-02-22 Thread Lee Duncan
From: Lee Duncan If there is an error queueing an iscsi command in iscsi_queuecommand(), for example if the transport fails to take the command in sessuin->tt->xmit_task(), then the error path can call iscsi_complete_task() without first aquiring the back_lock as required. This can l

[PATCH] Hold back_lock when calling iscsi_complete_task

2019-02-19 Thread Lee Duncan
From: Lee Duncan If there is an error queueing an iscsi command in iscsi_queuecommand(), for example if the transport fails to take the command in sessuin->tt->xmit_task(), then the error path can call iscsi_complete_task() without first aquiring the back_lock as required. This can l

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

2018-03-15 Thread Lee Duncan
I reviewed this several days before but mistakenly replied only to the open-iscsi list. Signed-off-by: Lee Duncan -- Lee-Man Duncan Sent from my iPhone, dude > On Mar 14, 2018, at 10:11 PM, Martin K. Petersen > wrote: > > >> iscsi tcp will first send out data, then

Re: [GIT PULL] Btrfs changes for 4.15

2017-11-15 Thread Duncan
g known issues, why is this being merged without the known fix (at least to the wild memory access) folded in, potentially breaking bisects even if people are more careful than to start testing pre-rc1. -o compress=lzo continues to work as expected, I hope? -- Duncan - List replies preferr

Re: [PATCH] scsi: libiscsi: fix shifting of DID_REQUEUE host byte

2017-10-09 Thread Lee Duncan
bnx2i: make bound ep check common") > Cc: Lee Duncan > Cc: Hannes Reinecke > Cc: Bart Van Assche > Cc: Chris Leech > --- > drivers/scsi/libiscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/

Re: [PATCH 2/2] uapi: add a compatibility layer between linux/uio.h and glibc

2017-09-27 Thread Lee Duncan
e _UAPI__LINUX_UIO_H > > +#include > #include > #include > > > +#if __UAPI_DEF_IOVEC > struct iovec > { > void __user *iov_base; /* BSD uses caddr_t (1003.1g requires void *) */ > __kernel_size_t iov_len; /* Must be size_t (1003.1g) */ > }; > +#endif /* __UAPI_DEF_IOVEC */ > > /* > * UIO_MAXIOV shall be at least 16 1003.1g (5.4.1.1) > -- > ldv -- Lee Duncan SUSE Labs

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

2017-09-13 Thread Lee Duncan
*session); > -extern int iscsi_destroy_session(struct iscsi_cls_session *session); > extern struct iscsi_cls_conn *iscsi_create_conn(struct iscsi_cls_session > *sess, > int dd_size, uint32_t cid); > extern int iscsi_destroy_conn(struct iscsi_cls_conn *conn); > -- Lee Duncan SUSE Labs

Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-06-16 Thread Lee Duncan
On 06/16/2017 05:41 PM, Jason A. Donenfeld wrote: > Hi Lee, > > On Fri, Jun 16, 2017 at 11:58 PM, Lee Duncan wrote: >> It seems like what you are doing is basically "good", i.e. if there is >> not enough random data, don't use it. But what happens in that ca

Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-06-16 Thread Lee Duncan
ll have a look (patch > reattached). > > Jason > It seems like what you are doing is basically "good", i.e. if there is not enough random data, don't use it. But what happens in that case? The authentication fails? How does the user know to wait and try again? -- Lee Duncan SUSE Labs

RE: HR department.

2017-04-14 Thread Mona Duncan
From: Mona Duncan Sent: 14 April 2017 10:08 Subject: HR department. To keep you abreast of ICT developments of the Organization and to keep your technical skills up to date, the latest IT Newsletter issue is now available at, http

Re: PROBLEM: Belkin Thunderbolt 2 Express Dock HD display port hot plug not supported.

2017-01-12 Thread Duncan Law
oc/ioports, /proc/iomem) duncan@relapse:~$ cat /proc/ioports - : PCI Bus :00 - : dma1 - : pic1 - : timer0 - : timer1 - : keyboard - : PNP0C09:00 - : EC data - : keyboard - : PNP0C09:00 -000

PROBLEM: Belkin Thunderbolt 2 Express Dock HD display port hot plug not supported.

2017-01-12 Thread Duncan Law
MI or DisplayPort) [3.] Keywords [4.] Kernel version (from /proc/version): duncan@relapse:~$ cat /proc/version Linux version 4.10.0-041000rc3-generic (kernel@tangerine) (gcc version 6.2.0 20161005 (Ubuntu 6.2.0-5ubuntu12) ) #201701081831 SMP Sun Jan 8 23:33:02 UTC 2017 [5.] Output of Oops.. me

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-15 Thread Lee Duncan
signed __bitwise__ ieee80211_tx_result; > +typedef unsigned __bitwise ieee80211_tx_result; > #define TX_CONTINUE ((__force ieee80211_tx_result) 0u) > #define TX_DROP ((__force ieee80211_tx_result) 1u) > #define TX_QUEUED((__force ieee80211_tx_result) 2u) > @@ -180,7 +180,7 @@ struct ieee80211_tx_data { > }; > > > -typedef unsigned __bitwise__ ieee80211_rx_result; > +typedef unsigned __bitwise ieee80211_rx_result; > #define RX_CONTINUE ((__force ieee80211_rx_result) 0u) > #define RX_DROP_UNUSABLE ((__force ieee80211_rx_result) 1u) > #define RX_DROP_MONITOR ((__force ieee80211_rx_result) 2u) > For iscsi initiator, looks good. Akced-by: Lee Duncan -- Lee Duncan

Re: page allocation stall in kernel 4.9 when copying files from one btrfs hdd to another

2016-12-13 Thread Duncan
stro. [3] Approaches: The memory figure used for calculating this percentage excludes some things so it won't actually reach 10% of total memory. But the exclusions are small enough that they can be hand-waved away for purposes of this discussion. -- Duncan - List replies preferred. No

Re: [PATCHv2] MAINTAINERS: Update open-iscsi maintainers

2016-09-27 Thread Lee Duncan
Hello Martin: On 09/26/2016 06:26 PM, Martin K. Petersen wrote: >>>>>> "Lee" == Lee Duncan writes: > > Lee, > > Lee> Chris Leech and I are taking over as open-iscsi maintainers. > > Do you want me to queue the MAINTAINER update? Yes, that wou

[PATCHv2] MAINTAINERS: Update open-iscsi maintainers

2016-09-26 Thread Lee Duncan
..81384a2562e7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6448,10 +6448,10 @@ S: Maintained F: drivers/firmware/iscsi_ibft* ISCSI -M: Mike Christie +M: Lee Duncan +M: Chris Leech L: open-is...@googlegroups.com -W: www.open-iscsi.org -T: git git

Re: [PATCH] MAINTAINERS: Update open-iscsi maintainers

2016-09-24 Thread Lee Duncan
[Added linux-scsi to the cc list.] I will resubmit an updated version of this patch. On 09/23/2016 02:34 PM, Lee Duncan wrote: > Chris Leech and I are taking over open-iscsi > maintenance from Mike Christie. > > Signed-off-by: Lee Duncan > --- > MAINTAINERS | 3 ++- &g

[PATCH] MAINTAINERS: Update open-iscsi maintainers

2016-09-23 Thread Lee Duncan
Chris Leech and I are taking over open-iscsi maintenance from Mike Christie. Signed-off-by: Lee Duncan --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01bff8ea28d8..0afaf42d5416 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCHv3 0/2] target: make location of /var/targets configurable

2016-06-09 Thread Lee Duncan
Ping? We really need to move the target database out of /var/target On 04/14/2016 06:18 PM, Lee Duncan wrote: > These patches make the location of "/var/target" configurable, > though it still defauls to "/var/target". > > This "target database direc

Re: [PATCHv3 0/2] target: make location of /var/targets configurable

2016-05-08 Thread Lee Duncan
On 04/14/2016 06:18 PM, Lee Duncan wrote: > These patches make the location of "/var/target" configurable, > though it still defauls to "/var/target". > > This "target database directory" can only be changed > after the target_core_mod loads but before

[PATCHv3 0/2] target: make location of /var/targets configurable

2016-04-14 Thread Lee Duncan
t before it can be used by others * Validate that new DB root is a valid directory Lee Duncan (2): target: make target db location configurable target: use new "dbroot" target attribute drivers/target/target_core_alua.c | 6 ++-- drivers/target/target_core_configfs.c | 62

[PATCHv3 1/2] target: make target db location configurable

2016-04-14 Thread Lee Duncan
lowed when no fabric drivers are loaded and the supplied value specifies an existing directory. Target modules that care about the target database root directory will be modified to use this attribute in a future commit. Signed-off-by: Lee Duncan --- drivers/target/target_

[PATCHv3 2/2] target: use new "dbroot" target attribute

2016-04-14 Thread Lee Duncan
This commit updates the target core ALUA and PR modules to use the new "dbroot" attribute instead of assuming the target database is in "/var/target". Signed-off-by: Lee Duncan Reviewed-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 6 +++--- drivers/target/ta

Re: [PATCHv2 1/2] target: make target db location configurable

2016-04-14 Thread Lee Duncan
On 04/13/2016 11:10 PM, Hannes Reinecke wrote: > On 04/13/2016 10:25 PM, Lee Duncan wrote: >> This commit adds the read-write attribute "dbroot", >> in the top-level CONFIGFS (core) target directory, >> normally /sys/kernel/config/target. This attribute >>

[PATCHv2 1/2] target: make target db location configurable

2016-04-13 Thread Lee Duncan
lowed when no fabric drivers are loaded and the supplied value specifies an existing directory. Target modules that care about the target database root directory will be modified to use this attribute in a future commit. Signed-off-by: Lee Duncan --- drivers/target/target_

[PATCHv2 0/2] target: make location of /var/targets configurable

2016-04-13 Thread Lee Duncan
target database. The first patch creates this configurable value for the "dbroot", and the second patch modifies users of this directory to use this new attribute. Changes from v1: * Only allow changing target DB root before it can be used by others * Validate that new DB root i

[PATCH 2/2] target: use new "dbroot" target attribute

2016-04-13 Thread Lee Duncan
This commit updates the target core ALUA and PR modules to use the new "dbroot" attribute instead of assuming the target database is in "/var/target". Signed-off-by: Lee Duncan --- drivers/target/target_core_alua.c | 6 +++--- drivers/target/target_core_pr.c | 2 +-

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-03-07 Thread Lee Duncan
On 02/12/2016 09:54 AM, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: >> The scsi_transport_iscsi module already uses the ida_simple >> routines for managing the target ID, if requested to do >> so. This change replaces an ever-increasing a

[PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-02-12 Thread Lee Duncan
and can be reused when the session is freed. Note that no maximum is placed on this value, though user-space currently only seems to use the lower 24-bits. It seems better to handle this in user space, though, than to limit the value range for the session ID here. Signed-off-by: Lee Duncan

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2016-01-20 Thread Lee Duncan
On 01/05/2016 03:53 PM, Martin K. Petersen wrote: "Lee" == Lee Duncan writes: Lee> Do you need me to resubmit this patch now that it's accepted? Please resend. Thanks! Done, submitted against scsi tree, misc branch. -- Lee Duncan

[PATCHv2] SCSI: usd ida for host number management

2016-01-20 Thread Lee Duncan
ecause the hosts module already has its own instance and locking mechanisms that aren't easily changed. Changes from v1: * First version used regular ida routines Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn Signed-off-by: Lee Duncan --- drivers/sc

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2016-01-04 Thread Lee Duncan
On 12/17/2015 11:24 AM, Lee Duncan wrote: > On 12/14/2015 05:55 PM, Martin K. Petersen wrote: >>>>>>> "Hannes" == Hannes Reinecke writes: >> >>>> I'm not opposed to having the module option if others (Martin?) feel >>>> they nee

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-12-17 Thread Lee Duncan
l not a big ida fan but since the most people seem to be in favor of > this I guess I'll have to bite the bullet. > > I don't see much value in the module parameter since it will require > customers to tweak their configs and reproduce. Not worth the hassle. > Thank you Martin

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-12-13 Thread Lee Duncan
On 12/11/2015 07:31 AM, Ewan Milne wrote: > On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: >> On 11/17/2015 03:20 PM, Martin K. Petersen wrote: >>>>>>>> "Lee" == Lee Duncan writes: >>> >>> Lee> Martin: I will be glad to updat

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-12-10 Thread Lee Duncan
On 11/17/2015 03:20 PM, Martin K. Petersen wrote: >>>>>> "Lee" == Lee Duncan writes: > > Lee> Martin: I will be glad to update the patch, creating a modprobe > Lee> parameter as suggested, if you find this acceptable. > > For development use a m

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-11-16 Thread Lee Duncan
On 11/16/2015 04:10 AM, Hannes Reinecke wrote: > On 11/13/2015 10:54 PM, Martin K. Petersen wrote: >>>>>>> "Lee" == Lee Duncan writes: >> >>>> Well, I'm a bit worried about the loss of a monotonically increasing >>>> host numbe

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-11-12 Thread Lee Duncan
On 10/14/2015 08:53 PM, James Bottomley wrote: > On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote: >> On 10/14/2015 06:55 AM, James Bottomley wrote: >>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: >>>> Update the SCSI hosts module to use the ida_simple*

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-16 Thread Lee Duncan
:34 -0700, Lee Duncan wrote: >> On 10/14/2015 06:55 AM, James Bottomley wrote: >>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: >>>> Update the SCSI hosts module to use the ida_simple*() routines >>>> to manage its host_no index instead of an ATOMIC i

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-14 Thread Lee Duncan
On 10/14/2015 11:53 AM, James Bottomley wrote: > On Wed, 2015-10-14 at 11:34 -0700, Lee Duncan wrote: >> On 10/14/2015 06:55 AM, James Bottomley wrote: >>> On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: >>>> Update the SCSI hosts module to use the ida_simple*

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-14 Thread Lee Duncan
On 10/14/2015 06:55 AM, James Bottomley wrote: > On Wed, 2015-10-07 at 16:51 -0700, Lee Duncan wrote: >> Update the SCSI hosts module to use the ida_simple*() routines >> to manage its host_no index instead of an ATOMIC integer. This >> means that the SCSI host number wi

Re: [PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt

2015-10-07 Thread Lee Duncan
Duplicate email, please ignore On 10/07/2015 04:47 PM, Lee Duncan wrote: > This patch updates the SCSI hosts module to use the idr > index-management routines to manage its host_no index instead > of using an ATOMIC integer. This means that host numbers > can now be reclaimed and re-u

[PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-07 Thread Lee Duncan
Update the SCSI hosts module to use the ida_simple*() routines to manage its host_no index instead of an ATOMIC integer. This means that the SCSI host number will now be reclaimable. Signed-off-by: Lee Duncan --- drivers/scsi/hosts.c | 22 ++ 1 file changed, 14 insertions

[PATCHv4 0/1] Update SCSI hosts to use ida for host number mgmt

2015-10-07 Thread Lee Duncan
Changes from v2 and v1: - First two version used idr instead of ida Lee Duncan (1): SCSI: hosts: update to use ida_simple for host_no management drivers/scsi/hosts.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send

Re: [PATCHv3 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
On 10/06/2015 12:19 PM, James Bottomley wrote: > On Tue, 2015-10-06 at 12:08 -0700, Lee Duncan wrote: >> Update the SCSI hosts module to use idr to manage >> its host_no index instead of an ATOMIC integer. This >> also allows using idr_find() to look up the SCSI >> ho

[PATCHv3 0/1] Update SCSI hosts to use idr for host number mgmt

2015-10-06 Thread Lee Duncan
gave up on this approach (as suggested by Tejon -- thank you). Changes from v1: - no longer using helper routines Changes from v2: - added back missing scsi_host_get() in scsi_host_lookup() Lee Duncan (1): SCSI: update hosts module to use idr index management drivers/scsi/hosts.c | 61

[PATCHv3 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable. Signed-off-by: Lee Duncan Reviewed-by

Re: [PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-06 Thread Lee Duncan
_lock); >> +shost = idr_find(&host_index_idr, hostnum); >> +spin_unlock(&host_index_lock); >> + >> return shost; > > How does this actually grab a reference to the host? Good catch -- I should have noticed that. I will resubmit th

[PATCHv2 0/1] Update SCSI hosts to use idr for host number mgmt

2015-10-05 Thread Lee Duncan
gave up on this approach (as suggested by Tejon -- thank you). Lee Duncan (1): SCSI: update hosts module to use idr index management drivers/scsi/hosts.c | 60 +--- 1 file changed, 29 insertions(+), 31 deletions(-) -- 2.1.4 -- To unsubscribe from

[PATCHv2 1/1] SCSI: update hosts module to use idr index management

2015-10-05 Thread Lee Duncan
Update the SCSI hosts module to use idr to manage its host_no index instead of an ATOMIC integer. This also allows using idr_find() to look up the SCSI host structure given the host number. This means that the SCSI host number will now be reclaimable. Signed-off-by: Lee Duncan --- drivers/scsi

[PATCH 1/5] SCSI: sd: simplify ida usage

2015-10-01 Thread Lee Duncan
Simplify ida index allocation and removal by using the ida_simple_* helper functions. Signed-off-by: Lee Duncan --- drivers/scsi/sd.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3b2fcb4fada0

[PATCH 5/5] base: soc: siplify ida usage

2015-10-01 Thread Lee Duncan
Simplify ida index allocation and removal by using the ida_simple_* helper functions Signed-off-by: Lee Duncan --- drivers/base/soc.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/base/soc.c b/drivers/base/soc.c index 39fca01c8fa1

[PATCH 2/5] block: rsxx: core: simplify ida usage

2015-10-01 Thread Lee Duncan
Simplify ida index allocation and removal by using the ida_simple_* helper functions. Signed-off-by: Lee Duncan --- drivers/block/rsxx/core.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index

[PATCH 4/5] block: mtip32xx: simplify ida usage

2015-10-01 Thread Lee Duncan
Simplify ida index allocation and removal by using the ida_simple_* helper functions Signed-off-by: Lee Duncan --- drivers/block/mtip32xx/mtip32xx.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block

[PATCH 0/5] Modify ida_* users to use ida_simple_*

2015-10-01 Thread Lee Duncan
idr helper routines" Another set will soon be sent out soon to (1) add idr helper functions, (2) modify clients to use them, and (3) update SCSI host_no to use them. Lee Duncan (5): SCSI: sd: simplify ida usage block: rsxx: core: simplify ida usage block: nvme-core: simplify id

[PATCH 3/5] block: nvme-core: simplify ida usage

2015-10-01 Thread Lee Duncan
Simplify ida index allocation and removal by using the ida_simple_* helper functions. Signed-off-by: Lee Duncan --- drivers/block/nvme-core.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index

Re: [PATCH 01/17] Add ida and idr helper routines.

2015-09-18 Thread Lee Duncan
er routines I was adding in idr.h would not be needed. If this is correct, I will supply a version 2 patch series that addresses this issue as well as the two patch-naming issues that were raised. -- Lee Duncan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

Re: [PATCH 05/17] Update the md driver to use idr helper functions.

2015-09-17 Thread Lee Duncan
On 09/15/2015 11:05 AM, Mike Snitzer wrote: > Subject should really be: > "dm: update to use idr helper functions" Yes, I grabbed the wrong part of the driver pathname. Would it be better to resubmit just this patch, or to resubmit the series? -- To unsubscribe from this list: send the line "unsu

[PATCH 02/17] Update scsi hosts to use idr for host number mgmt

2015-09-16 Thread Lee Duncan
_Host instances to use idr to manage their instance numbers and to simplify instance number to pointer lookups. This also means that host instance numbers will be reused, when available. Signed-off-by: Lee Duncan --- drivers/scsi/hosts.c | 59 1

[PATCH 04/17] Update the ch driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
could have resulted in duplicate index allocation. Signed-off-by: Lee Duncan --- drivers/scsi/ch.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/ch.c b/drivers/scsi/ch.c index dad959fcf6d8..2edf1f8883f9 100644 --- a/drivers/scsi/ch.c +++ b/drivers

[PATCH 06/17] Update the infiniband uverbs driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/infiniband/core/uverbs_cmd.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index bbb02ffe87df..1e5b2a66a501 100644 --- a/drivers/infiniband/core

[PATCH 01/17] Add ida and idr helper routines.

2015-09-16 Thread Lee Duncan
: idr_get_index_in_range idr_get_index (in range 0,0) idr_put_index And for ida: ida_get_index ida_put_index Signed-off-by: Lee Duncan --- include/linux/idr.h | 102 1 file changed, 102 insertions(+) diff --git a/include/linux/idr.h b/include/linux/idr.h

[PATCH 07/17] Update the memstick driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/memstick/core/memstick.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c index a0547dbf9806..8f40a3d5108b 100644 --- a/drivers/memstick/core

[PATCH 11/17] Update the rtsx multifunction driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/mfd/rtsx_pcr.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c index a66540a49079..8ddefb8c5e64 100644 --- a/drivers/mfd/rtsx_pcr.c +++ b/drivers/mfd/rtsx_pcr.c @@ -1191,15

[PATCH 10/17] Update the DCA DMA driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/dca/dca-sysfs.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/dca/dca-sysfs.c b/drivers/dca/dca-sysfs.c index 126cf295b198..8930707df295 100644 --- a/drivers/dca/dca-sysfs.c +++ b/drivers/dca/dca-sysfs.c

[PATCH 12/17] Update the TI Flash Media driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/misc/tifm_core.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/misc/tifm_core.c b/drivers/misc/tifm_core.c index a511b2a713b3..46385f828a8f 100644 --- a/drivers/misc/tifm_core.c +++ b/drivers/misc/tifm_core.c

[PATCH 08/17] Update the mmc driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/mmc/core/host.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 99a9c9011c50..5aa2330f074c 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -40,9

[PATCH 14/17] Update the rsxx flash adapter driver to use ida helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/block/rsxx/core.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index d8b2488aaade..dd23a0e85040 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx

[PATCH 15/17] Update the NVMe SSD driver to use ida helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/block/nvme-core.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c index d1d6141920d3..ab13833d4fde 100644 --- a/drivers/block/nvme-core.c +++ b/drivers/block/nvme

[PATCH 13/17] Update the SCSI disk driver to use ida helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/scsi/sd.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3b2fcb4fada0..60b2ad918208 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2948,15 +2948,7 @@ static

[PATCH 09/17] Update the virtgpu driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/gpu/drm/virtio/virtgpu_vq.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c index 1698669f4185..380947dad306 100644 --- a/drivers/gpu/drm/virtio

[PATCH 03/17] Update the st driver to use idr helper functions.

2015-09-16 Thread Lee Duncan
Signed-off-by: Lee Duncan --- drivers/scsi/st.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index b37b9b00c4b4..51e1ce721d9f 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -4265,11 +4265,8 @@ static int

  1   2   3   >