Re: [PATCH] thermal: enable broadcom menu for arm64 bcm2835

On Thu, Oct 12, 2017 at 07:32:27PM +0200, Stefan Wahren wrote: > > Stefan Wahren hat am 26. September 2017 um 19:37 > > geschrieben: > > > > > > From: Allen Wild > > > > Moving the bcm2835 thermal driver to the broadcom directory prevented it > > from getting enabled for arm64 builds, since

Re: [PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for RV1108 in dts

arm: dts: rockchip: add tsadc node for RV1108 SoC > arm: dts: rockchip: add thermal nodes for RV1108 SoC > arm: dts: rockchip: enable tsadc module on RV1108 evaluation board > Acked-by: Eduardo Valentin <edubez...@gmail.com> for the DT changes. > .../bindings/thermal/roc

Re: [PATCH 0/5] thermal: rockchip: add tsadc support in thermal driver and IPA thermal control for RV1108 in dts

arm: dts: rockchip: add tsadc node for RV1108 SoC > arm: dts: rockchip: add thermal nodes for RV1108 SoC > arm: dts: rockchip: enable tsadc module on RV1108 evaluation board > Acked-by: Eduardo Valentin for the DT changes. > .../bindings/thermal/rockchip-thermal.txt

Re: [PATCH 01/25] thermal/drivers/hisi: Fix missing interrupt enablement

On Tue, Oct 10, 2017 at 08:02:26PM +0200, Daniel Lezcano wrote: > The interrupt for the temperature threshold is not enabled at the end of the > probe function, enable it after the setup is complete. > > On the other side, the irq_enabled is not correctly set as we are checking if > the interrupt

Re: [PATCH 01/25] thermal/drivers/hisi: Fix missing interrupt enablement

On Tue, Oct 10, 2017 at 08:02:26PM +0200, Daniel Lezcano wrote: > The interrupt for the temperature threshold is not enabled at the end of the > probe function, enable it after the setup is complete. > > On the other side, the irq_enabled is not correctly set as we are checking if > the interrupt

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

gree. I would prefer to understand here what is the technical reason not to accept these patches other than "use other system calls". -- All the best, Eduardo Valentin

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

rstand here what is the technical reason not to accept these patches other than "use other system calls". -- All the best, Eduardo Valentin

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

ocumentation or deprecation path, to me, looks like breaking userspace, isn't it? If the correct recommendation is to use different system calls this should have been mentioned in system call documentation before changing its behavior, not expect the user to figure out after kernel release/upgrade, right? -- All the best, Eduardo Valentin

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

tion path, to me, looks like breaking userspace, isn't it? If the correct recommendation is to use different system calls this should have been mentioned in system call documentation before changing its behavior, not expect the user to figure out after kernel release/upgrade, right? -- All the best, Eduardo Valentin

Re: [PATCH V2 13/13] thermal/drivers/hisi: Remove mutex_lock in the code

On Mon, Sep 04, 2017 at 09:56:12PM +0200, Daniel Lezcano wrote: > The mutex is used to protect against writes in the configuration register. > > That happens at probe time, with no possible race yet. > > Then when the module is unloaded and at suspend/resume. > > When the module is unloaded, it

Re: [PATCH V2 13/13] thermal/drivers/hisi: Remove mutex_lock in the code

On Mon, Sep 04, 2017 at 09:56:12PM +0200, Daniel Lezcano wrote: > The mutex is used to protect against writes in the configuration register. > > That happens at probe time, with no possible race yet. > > Then when the module is unloaded and at suspend/resume. > > When the module is unloaded, it

Re: [PATCH V2 09/13] thermal/drivers/hisi: Remove costly sensor inspection

On Mon, Sep 04, 2017 at 09:56:08PM +0200, Daniel Lezcano wrote: > The sensor is all setup, bind, resetted, acked, etc... every single second. > > That was the way to workaround a problem with the interrupt bouncing again and > again. > > With the following changes, we fix all in one: > > - Do

Re: [PATCH V2 09/13] thermal/drivers/hisi: Remove costly sensor inspection

On Mon, Sep 04, 2017 at 09:56:08PM +0200, Daniel Lezcano wrote: > The sensor is all setup, bind, resetted, acked, etc... every single second. > > That was the way to workaround a problem with the interrupt bouncing again and > again. > > With the following changes, we fix all in one: > > - Do

Re: [PATCH V2 06/13] thermal/drivers/hisi: Remove pointless lock

On Mon, Sep 04, 2017 at 09:56:05PM +0200, Daniel Lezcano wrote: > The threaded interrupt inspect the sensors structure to look in the temp > threshold field, but this field is read-only in all the code, except in the > probe function before the threaded interrupt is set. In other words there > is

Re: [PATCH V2 06/13] thermal/drivers/hisi: Remove pointless lock

On Mon, Sep 04, 2017 at 09:56:05PM +0200, Daniel Lezcano wrote: > The threaded interrupt inspect the sensors structure to look in the temp > threshold field, but this field is read-only in all the code, except in the > probe function before the threaded interrupt is set. In other words there > is

Re: [PATCH] thermal/drivers/step_wise: Fix temperature regulation misbehavior

On Wed, Sep 06, 2017 at 08:58:46AM +0200, Daniel Lezcano wrote: > There is a particular situation when the cooling device is cpufreq and the > heat > dissipation is not efficient enough where the temperature increases little by > little until reaching the critical threshold and leading to a SoC

Re: [PATCH] thermal/drivers/step_wise: Fix temperature regulation misbehavior

On Wed, Sep 06, 2017 at 08:58:46AM +0200, Daniel Lezcano wrote: > There is a particular situation when the cooling device is cpufreq and the > heat > dissipation is not efficient enough where the temperature increases little by > little until reaching the critical threshold and leading to a SoC

Re: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks

Hello, On Wed, Sep 06, 2017 at 11:40:46AM -0700, Brian Norris wrote: > Hi, > > On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The comparisons for integer low on low > INT_MAX and also > > integer high > INT_MAX are never

Re: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks

Hello, On Wed, Sep 06, 2017 at 11:40:46AM -0700, Brian Norris wrote: > Hi, > > On Sun, Sep 03, 2017 at 02:16:19PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The comparisons for integer low on low > INT_MAX and also > > integer high > INT_MAX are never going to be true since an >

Re: [PATCH] thermal/drivers/generic-iio-adc: Switch tz request to devm version

Hey Daniel, On Thu, Sep 07, 2017 at 08:17:10PM +0200, Daniel Lezcano wrote: > Everything mentionned here: > https://lkml.org/lkml/2016/4/20/850 > > This driver was added before the devm_iio_channel_get() function version was > merged. The sensor should be released before the iio channel, thus

Re: [PATCH] thermal/drivers/generic-iio-adc: Switch tz request to devm version

Hey Daniel, On Thu, Sep 07, 2017 at 08:17:10PM +0200, Daniel Lezcano wrote: > Everything mentionned here: > https://lkml.org/lkml/2016/4/20/850 > > This driver was added before the devm_iio_channel_get() function version was > merged. The sensor should be released before the iio channel, thus

Re: [PATCH 1/1] bridge: mdb: fix leak on complete_info ptr on fail path

On Tue, Jul 11, 2017 at 08:02:33PM -0700, David Miller wrote: > From: Eduardo Valentin <edu...@amazon.com> > Date: Tue, 11 Jul 2017 14:55:12 -0700 > > > We currently get the following kmemleak report: > > unreferenced object 0x8800039d9820 (size 32): > >

Re: [PATCH 1/1] bridge: mdb: fix leak on complete_info ptr on fail path

On Tue, Jul 11, 2017 at 08:02:33PM -0700, David Miller wrote: > From: Eduardo Valentin > Date: Tue, 11 Jul 2017 14:55:12 -0700 > > > We currently get the following kmemleak report: > > unreferenced object 0x8800039d9820 (size 32): > > comm "softirq", pi

[PATCH 1/1] bridge: mdb: fix leak on complete_info ptr on fail path

Cc: stable <sta...@vger.kernel.org> # v4.9+ Reviewed-by: Vallish Vaidyeshwara <vall...@amazon.com> Signed-off-by: Eduardo Valentin <edu...@amazon.com> --- net/bridge/br_mdb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_

[PATCH 1/1] bridge: mdb: fix leak on complete_info ptr on fail path

Cc: stable # v4.9+ Reviewed-by: Vallish Vaidyeshwara Signed-off-by: Eduardo Valentin --- net/bridge/br_mdb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index b084548..c1030f8 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridg

Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

On Wed, Jul 05, 2017 at 09:05:14AM -0700, Eduardo Valentin wrote: > On Tue, Jul 04, 2017 at 01:48:42AM -0700, David Miller wrote: > > From: Eduardo Valentin <edu...@amazon.com> > > Date: Mon, 3 Jul 2017 10:06:34 -0700 > > > > > We current

Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

On Wed, Jul 05, 2017 at 09:05:14AM -0700, Eduardo Valentin wrote: > On Tue, Jul 04, 2017 at 01:48:42AM -0700, David Miller wrote: > > From: Eduardo Valentin > > Date: Mon, 3 Jul 2017 10:06:34 -0700 > > > > > We currently get the following kmemleak report: &

Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

On Tue, Jul 04, 2017 at 01:48:42AM -0700, David Miller wrote: > From: Eduardo Valentin <edu...@amazon.com> > Date: Mon, 3 Jul 2017 10:06:34 -0700 > > > We currently get the following kmemleak report: > ... > > This patch flags the complete_info ptr object as not a

Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

On Tue, Jul 04, 2017 at 01:48:42AM -0700, David Miller wrote: > From: Eduardo Valentin > Date: Mon, 3 Jul 2017 10:06:34 -0700 > > > We currently get the following kmemleak report: > ... > > This patch flags the complete_info ptr object as not a leak as it will > >

Re: [PATCH] thermal: imx: interpret fsl,tempmon-data through nvmem

On Mon, Jun 19, 2017 at 04:40:43PM +0300, Leonard Crestez wrote: > On imx6sx accessing the ocotp memory area directly is wrong because the > ocotp clock needs to be enabled first. Fix this by reinterpreting the > fsl,tempmon-data phandle as a reference to a nvmem_device and doing all > the read

Re: [PATCH] thermal: imx: interpret fsl,tempmon-data through nvmem

On Mon, Jun 19, 2017 at 04:40:43PM +0300, Leonard Crestez wrote: > On imx6sx accessing the ocotp memory area directly is wrong because the > ocotp clock needs to be enabled first. Fix this by reinterpreting the > fsl,tempmon-data phandle as a reference to a nvmem_device and doing all > the read

[GIT PULL] Thermal SoC management updates for v4.13-rc1 #1

Hello Rui, Please pull the following changes to get the Thermal SoC updates for 4.13-rc1. Here we have: - Refactoring of cpucooling device driver to improve cpufreq data handling - Small fixes on different drivers: IMX, hisilicon, and BCM. The following changes since commit

[GIT PULL] Thermal SoC management updates for v4.13-rc1 #1

Hello Rui, Please pull the following changes to get the Thermal SoC updates for 4.13-rc1. Here we have: - Refactoring of cpucooling device driver to improve cpufreq data handling - Small fixes on different drivers: IMX, hisilicon, and BCM. The following changes since commit

[PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

is called, for the br mdb case, it will be freed at br_mdb_complete(). Cc: stable <sta...@vger.kernel.org> # v4.9+ Reviewed-by: Vallish Vaidyeshwara <vall...@amazon.com> Signed-off-by: Eduardo Valentin <edu...@amazon.com> --- net/bridge/br_mdb.c | 3 +++ 1 file changed, 3 insertions

[PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

is called, for the br mdb case, it will be freed at br_mdb_complete(). Cc: stable # v4.9+ Reviewed-by: Vallish Vaidyeshwara Signed-off-by: Eduardo Valentin --- net/bridge/br_mdb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index b084548..1c81

Re: [PATCH v2 2/2] thermal: uniphier: add UniPhier thermal driver

Hey, On Wed, Jun 28, 2017 at 07:11:59PM +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko Hayashi

Re: [PATCH v2 2/2] thermal: uniphier: add UniPhier thermal driver

Hey, On Wed, Jun 28, 2017 at 07:11:59PM +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko Hayashi

Re: [Patch v2 3/3] arm64: dts: register Hi3660's thermal sensor

On Thu, Jun 22, 2017 at 11:42:03AM +0800, Tao Wang wrote: > Bind thermal sensor driver for Hi3660. > > Signed-off-by: Tao Wang > Signed-off-by: Leo Yan > --- > Changes in v2: > - rebase changes on linux next > >

Re: [Patch v2 3/3] arm64: dts: register Hi3660's thermal sensor

On Thu, Jun 22, 2017 at 11:42:03AM +0800, Tao Wang wrote: > Bind thermal sensor driver for Hi3660. > > Signed-off-by: Tao Wang > Signed-off-by: Leo Yan > --- > Changes in v2: > - rebase changes on linux next > > arch/arm64/boot/dts/hisilicon/hi3660.dtsi |6 ++ > 1 file changed, 6

Re: [Patch v2 1/3] dt-bindings: Document the hi3660 thermal sensor bindings

On Thu, Jun 22, 2017 at 11:42:01AM +0800, Tao Wang wrote: > This adds documentation of device tree bindings for the > thermal sensor controller of hi3660 SoC. > > Signed-off-by: Tao Wang > --- > Changes in v2: > - remove redundant property > >

Re: [Patch v2 1/3] dt-bindings: Document the hi3660 thermal sensor bindings

On Thu, Jun 22, 2017 at 11:42:01AM +0800, Tao Wang wrote: > This adds documentation of device tree bindings for the > thermal sensor controller of hi3660 SoC. > > Signed-off-by: Tao Wang > --- > Changes in v2: > - remove redundant property > > .../devicetree/bindings/thermal/hi3660-thermal.txt

Re: [Patch v2 2/3] thermal: hisilicon: add thermal sensor driver for Hi3660

Hey Tao, On Thu, Jun 22, 2017 at 11:42:02AM +0800, Tao Wang wrote: > This patch adds the support for thermal sensor of Hi3660 SoC. > this will register sensors for thermal framework and use device > tree to bind cooling device. > > Signed-off-by: Tao Wang >

Re: [Patch v2 2/3] thermal: hisilicon: add thermal sensor driver for Hi3660

Hey Tao, On Thu, Jun 22, 2017 at 11:42:02AM +0800, Tao Wang wrote: > This patch adds the support for thermal sensor of Hi3660 SoC. > this will register sensors for thermal framework and use device > tree to bind cooling device. > > Signed-off-by: Tao Wang > Signed-off-by: Leo Yan > --- >

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

On Fri, Jun 23, 2017 at 10:25:45PM +0200, Stefan Wahren wrote: > > > Christophe JAILLET hat am 23. Juni 2017 um > > 21:44 geschrieben: > > > > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > > pointless. > > This 'err = PTR_ERR(tz)'

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

On Fri, Jun 23, 2017 at 10:25:45PM +0200, Stefan Wahren wrote: > > > Christophe JAILLET hat am 23. Juni 2017 um > > 21:44 geschrieben: > > > > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > > pointless. > > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few

Re: [PATCH 4/4] thermal: Add Tegra BPMP thermal sensor driver

Hey Mikko, Sorry for the late answer, On Fri, Jun 16, 2017 at 02:28:25PM +0300, Mikko Perttunen wrote: > On Tegra186, the BPMP (Boot and Power Management Processor) exposes an > interface to thermal sensors on the system-on-chip. This driver > implements access to the interface. It supports

Re: [PATCH 4/4] thermal: Add Tegra BPMP thermal sensor driver

Hey Mikko, Sorry for the late answer, On Fri, Jun 16, 2017 at 02:28:25PM +0300, Mikko Perttunen wrote: > On Tegra186, the BPMP (Boot and Power Management Processor) exposes an > interface to thermal sensors on the system-on-chip. This driver > implements access to the interface. It supports

Re: [PATCH 1/4] arm64: tegra: Add BPMP thermal sensor to Tegra186

On Fri, Jun 16, 2017 at 02:28:22PM +0300, Mikko Perttunen wrote: > This adds the thermal sensor device provided by the BPMP, and the > relevant thermal sensors to the Tegra186 device tree. > > Signed-off-by: Mikko Perttunen > --- > arch/arm64/boot/dts/nvidia/tegra186.dtsi

Re: [PATCH 1/4] arm64: tegra: Add BPMP thermal sensor to Tegra186

On Fri, Jun 16, 2017 at 02:28:22PM +0300, Mikko Perttunen wrote: > This adds the thermal sensor device provided by the BPMP, and the > relevant thermal sensors to the Tegra186 device tree. > > Signed-off-by: Mikko Perttunen > --- > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 48 >

Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number

nfs/mount.c > index d5b149a..343dfeb 100644 > --- a/fs/kernfs/mount.c > +++ b/fs/kernfs/mount.c > @@ -332,5 +332,7 @@ void __init kernfs_init(void) > { > kernfs_node_cache = kmem_cache_create("kernfs_node_cache", > sizeof(struct kernfs_node), > - 0, SLAB_PANIC, NULL); > + 0, > + SLAB_PANIC | SLAB_TYPESAFE_BY_RCU, > + NULL); > } > -- > 2.9.3 > > -- All the best, Eduardo Valentin

Re: [PATCH 03/11] kernfs: add an API to get kernfs node from inode number

> index d5b149a..343dfeb 100644 > --- a/fs/kernfs/mount.c > +++ b/fs/kernfs/mount.c > @@ -332,5 +332,7 @@ void __init kernfs_init(void) > { > kernfs_node_cache = kmem_cache_create("kernfs_node_cache", > sizeof(struct kernfs_node), > - 0, SLAB_PANIC, NULL); > + 0, > + SLAB_PANIC | SLAB_TYPESAFE_BY_RCU, > + NULL); > } > -- > 2.9.3 > > -- All the best, Eduardo Valentin

Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote: > ARCH_BCM_IPROC includes support for many SoCs, not all of which have the > same thermal hardware interface as the Northstar/Northstar Plus SoCs. > This is not a major issue, as this driver will only be probed if the > relevant device

Re: [PATCH] thermal: broadcom: ns-thermal: depends/default only for NS/NSP

On Wed, May 31, 2017 at 03:55:44PM -0400, Jon Mason wrote: > ARCH_BCM_IPROC includes support for many SoCs, not all of which have the > same thermal hardware interface as the Northstar/Northstar Plus SoCs. > This is not a major issue, as this driver will only be probed if the > relevant device

Re: [xfstests PATCH v3 1/5] generic: add a writeback error handling test

4 @@ > 435 auto encrypt > 436 auto quick rw > 437 auto quick > +999 auto quick > diff --git a/tools/dmerror b/tools/dmerror > new file mode 100755 > index ..4aaf682ee5f9 > --- /dev/null > +++ b/tools/dmerror > @@ -0,0 +1,44 @@ > +#!/bin/bash > +#--- > +# Copyright (c) 2017, Jeff Layton <jlay...@redhat.com> > +# > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU General Public License as > +# published by the Free Software Foundation. > +# > +# This program is distributed in the hope that it would be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program; if not, write the Free Software Foundation, > +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > +#--- > + > +. ./common/config > +. ./common/dmerror > + > +_dmerror_setup > + > +case $1 in > +cleanup) > + _dmerror_cleanup > + ;; > +init) > + _dmerror_init > + ;; > +load_error_table) > + _dmerror_load_error_table > + ;; > +load_working_table) > + _dmerror_load_working_table > + ;; > +*) > + echo "Usage: $0 {init|cleanup|load_error_table|load_working_table}" > + exit 1 > + ;; > +esac > + > +status=0 > +exit > -- > 2.9.4 > > -- All the best, Eduardo Valentin

Re: [xfstests PATCH v3 1/5] generic: add a writeback error handling test

nd mount > +Test passed! > diff --git a/tests/generic/group b/tests/generic/group > index 438c299030f2..39f7b14657f1 100644 > --- a/tests/generic/group > +++ b/tests/generic/group > @@ -440,3 +440,4 @@ > 435 auto encrypt > 436 auto quick rw > 437 auto quick > +999 auto

Re: [PATCH 7/7] thermal: max77620: fix pinmux conflict on reprobe

t;*/ > - of_node_put(pdev->dev.of_node); > - pdev->dev.of_node = of_node_get(pdev->dev.parent->of_node); > + device_set_of_node_from_dev(>dev, pdev->dev.parent); Should this one be squashed with patch 6/7? > > mtherm->tz_device = devm_thermal_zone_of_sensor_register(>dev, 0, > mtherm, _thermal_ops); > -- > 2.13.0 > > -- All the best, Eduardo Valentin

Re: [PATCH 7/7] thermal: max77620: fix pinmux conflict on reprobe

e); > - pdev->dev.of_node = of_node_get(pdev->dev.parent->of_node); > + device_set_of_node_from_dev(>dev, pdev->dev.parent); Should this one be squashed with patch 6/7? > > mtherm->tz_device = devm_thermal_zone_of_sensor_register(>dev, 0, > mtherm, _thermal_ops); > -- > 2.13.0 > > -- All the best, Eduardo Valentin

Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver

Knihiko, On Mon, May 29, 2017 at 06:15:42PM +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko

Re: [PATCH 1/4] thermal: uniphier: add UniPhier thermal driver

Knihiko, On Mon, May 29, 2017 at 06:15:42PM +0900, Kunihiko Hayashi wrote: > Add a thermal driver for on-chip PVT (Process, Voltage and Temperature) > monitoring unit implemented on UniPhier SoCs. This driver supports > temperature monitoring and alert function. > > Signed-off-by: Kunihiko

Re: [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2

On Mon, May 29, 2017 at 06:15:44PM +0900, Kunihiko Hayashi wrote: > Add nodes of thermal monitor and thermal zone for UniPhier PXs2 SoC. > The thermal monitor is included in sysctrl. > > Signed-off-by: Kunihiko Hayashi > --- >

Re: [PATCH 3/4] ARM: dts: uniphier: add nodes of thermal monitor and thermal zone for PXs2

On Mon, May 29, 2017 at 06:15:44PM +0900, Kunihiko Hayashi wrote: > Add nodes of thermal monitor and thermal zone for UniPhier PXs2 SoC. > The thermal monitor is included in sysctrl. > > Signed-off-by: Kunihiko Hayashi > --- > arch/arm/boot/dts/uniphier-pxs2-gentil.dts | 21

[GIT PULL][RESEND] Thermal SoC management fixes for v4.12-rc3

Hello Linus, I know this is (very) late, but please consider these six fixes for next rc3. I tried sending these via Rui, but I think I missed the window to get him still in office, so I am sending directly to you. Changelog in this pull: - Fixes on TI SoC driver, Broadcom, qoriq. - Small sparse

[GIT PULL][RESEND] Thermal SoC management fixes for v4.12-rc3

Hello Linus, I know this is (very) late, but please consider these six fixes for next rc3. I tried sending these via Rui, but I think I missed the window to get him still in office, so I am sending directly to you. Changelog in this pull: - Fixes on TI SoC driver, Broadcom, qoriq. - Small sparse

[GIT PULL] Thermal SoC management fixes for v4.12-rc3

Hello Rui, I know this is late, but please send these six fixes for next rc3. The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) are available in the git repository at:

[GIT PULL] Thermal SoC management fixes for v4.12-rc3

Hello Rui, I know this is late, but please send these six fixes for next rc3. The following changes since commit 08332893e37af6ae779367e78e444f8f9571511d: Linux 4.12-rc2 (2017-05-21 19:30:23 -0700) are available in the git repository at:

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

On Fri, May 26, 2017 at 10:27:18AM +0530, Viresh Kumar wrote: > On 26-04-17, 11:41, Lukasz Luba wrote: > > Hi Viresh, > > > > I went through the v4 code and it looks good to me. > > Feel free to add for the v4 series > > Reviewed-by: Lukasz Luba > > @Eduardo: You missed

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

On Fri, May 26, 2017 at 10:27:18AM +0530, Viresh Kumar wrote: > On 26-04-17, 11:41, Lukasz Luba wrote: > > Hi Viresh, > > > > I went through the v4 code and it looks good to me. > > Feel free to add for the v4 series > > Reviewed-by: Lukasz Luba > > @Eduardo: You missed adding this to the

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Viresh, On Wed, May 24, 2017 at 09:23:52AM +0530, Viresh Kumar wrote: > On 23-05-17, 19:41, Eduardo Valentin wrote: > > Hey, > > > > On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote: > > > Hi Guys, > > > > > > The cpu_cooling driver i

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Viresh, On Wed, May 24, 2017 at 09:23:52AM +0530, Viresh Kumar wrote: > On 23-05-17, 19:41, Eduardo Valentin wrote: > > Hey, > > > > On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote: > > > Hi Guys, > > > > > > The cpu_cooling driver i

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Hey, On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote: > Hi Guys, > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid > high thermal states for a platform. But it wasn't glued really well with > cpufreq core. For example clipped-cpus is copied from the policy

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Hey, On Tue, Apr 25, 2017 at 03:57:07PM +0530, Viresh Kumar wrote: > Hi Guys, > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid > high thermal states for a platform. But it wasn't glued really well with > cpufreq core. For example clipped-cpus is copied from the policy

Re: [PATCH] thermal: cpu_cooling: Replace kmalloc with kmalloc_array

Hello, On Tue, May 23, 2017 at 12:33:06PM +0530, Viresh Kumar wrote: > Checkpatch reports following: > > WARNING: Prefer kmalloc_array over kmalloc with multiply > + cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * > i, > > Fix that. That is how the patch would

Re: [PATCH] thermal: cpu_cooling: Replace kmalloc with kmalloc_array

Hello, On Tue, May 23, 2017 at 12:33:06PM +0530, Viresh Kumar wrote: > Checkpatch reports following: > > WARNING: Prefer kmalloc_array over kmalloc with multiply > + cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * > i, > > Fix that. That is how the patch would

[GIT PULL] Thermal SoC management updates for v4.12-rc1 #1

Hello Rui, Please pull the following changes to get the Thermal SoC updates for 4.12-rc1. Here we have: - Removal of non-DT booting on TI-SoC driver. Also, support to fetching coefficients from DT. - Refactoring of RCAR Gen3. - New driver: support for BCM 2835. - New driver: support for Broadcom

[GIT PULL] Thermal SoC management updates for v4.12-rc1 #1

Hello Rui, Please pull the following changes to get the Thermal SoC updates for 4.12-rc1. Here we have: - Removal of non-DT booting on TI-SoC driver. Also, support to fetching coefficients from DT. - Refactoring of RCAR Gen3. - New driver: support for BCM 2835. - New driver: support for Broadcom

Re: [PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

On Thu, Apr 27, 2017 at 01:42:25PM -0400, Jon Mason wrote: > On Thu, Apr 27, 2017 at 12:37 PM, Eduardo Valentin <edubez...@gmail.com> > wrote: > > Hey Jason, > > It's Jon :) Apologies. I think I either read too fast, or my fingers were faster than my brain. Sorry. &

Re: [PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

On Thu, Apr 27, 2017 at 01:42:25PM -0400, Jon Mason wrote: > On Thu, Apr 27, 2017 at 12:37 PM, Eduardo Valentin > wrote: > > Hey Jason, > > It's Jon :) Apologies. I think I either read too fast, or my fingers were faster than my brain. Sorry. > > > > > O

Re: [PATCH 2/2] ARM: dts: NSP: Add Thermal Support

On Tue, Apr 25, 2017 at 04:49:11PM -0400, Jon Mason wrote: > Add thermal support via the ns-thermal driver and create a single > thermal zone for the entire SoC. > > Signed-off-by: Jon Mason <jon.ma...@broadcom.com> Acked-by: Eduardo Valentin <edubez...@gmail.com> > -

Re: [PATCH 2/2] ARM: dts: NSP: Add Thermal Support

On Tue, Apr 25, 2017 at 04:49:11PM -0400, Jon Mason wrote: > Add thermal support via the ns-thermal driver and create a single > thermal zone for the entire SoC. > > Signed-off-by: Jon Mason Acked-by: Eduardo Valentin > --- > arch/arm/boot/dts

Re: [PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

Hey Jason, On Tue, Apr 25, 2017 at 04:49:10PM -0400, Jon Mason wrote: > Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows > the ns-thermal driver to be selected via menuconfig. Also, change the > ns-thermal driver to work on any iProc based SoC. Finally, tweak the >

Re: [PATCH 1/2] thermal: broadcom: Allow for NSP to use ns-thermal driver

Hey Jason, On Tue, Apr 25, 2017 at 04:49:10PM -0400, Jon Mason wrote: > Change the iProc Kconfig to select THERMAL and THERMAL_OF, which allows > the ns-thermal driver to be selected via menuconfig. Also, change the > ns-thermal driver to work on any iProc based SoC. Finally, tweak the >

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

On Wed, Apr 26, 2017 at 04:17:52PM +0530, Viresh Kumar wrote: > On 26-04-17, 11:41, Lukasz Luba wrote: > > Hi Viresh, > > > > I went through the v4 code and it looks good to me. > > Feel free to add for the v4 series > > Reviewed-by: Lukasz Luba > > Thanks a lot for testing

Re: [PATCH V4 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

On Wed, Apr 26, 2017 at 04:17:52PM +0530, Viresh Kumar wrote: > On 26-04-17, 11:41, Lukasz Luba wrote: > > Hi Viresh, > > > > I went through the v4 code and it looks good to me. > > Feel free to add for the v4 series > > Reviewed-by: Lukasz Luba > > Thanks a lot for testing and reviewing the

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 17:24:56 +0200 > > Three update suggestions were taken into account > from static source code analysis. > > Markus Elfring (3): > Use

Re: [PATCH 0/3] TI-SoC-thermal: Fine-tuning for two functions

On Wed, Apr 26, 2017 at 05:33:10PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 17:24:56 +0200 > > Three update suggestions were taken into account > from static source code analysis. > > Markus Elfring (3): > Use devm_kcalloc() in ti_bandgap_build() >

Re: [PATCH] drm/etnaviv: add thermal dependency

dg On Mon, Apr 24, 2017 at 07:39:27PM +0200, Arnd Bergmann wrote: > On Mon, Apr 24, 2017 at 12:44 PM, Lucas Stach wrote: > > Am Mittwoch, den 19.04.2017, 20:11 +0200 schrieb Arnd Bergmann: > >> When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is > >>

Re: [PATCH] drm/etnaviv: add thermal dependency

dg On Mon, Apr 24, 2017 at 07:39:27PM +0200, Arnd Bergmann wrote: > On Mon, Apr 24, 2017 at 12:44 PM, Lucas Stach wrote: > > Am Mittwoch, den 19.04.2017, 20:11 +0200 schrieb Arnd Bergmann: > >> When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is > >> built-in, we get a link error:

Re: [PATCH] drm/etnaviv: add thermal dependency

t; from INTEL_MENLOW, so no other driver uses that statement. > > Fixes: bcdfb5e56dc5 ("drm/etnaviv: add etnaviv cooling device") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Eduardo Valentin <edubez...@gmail.com> > --- > drivers/acpi/Kconfig

Re: [PATCH] drm/etnaviv: add thermal dependency

t; from INTEL_MENLOW, so no other driver uses that statement. > > Fixes: bcdfb5e56dc5 ("drm/etnaviv: add etnaviv cooling device") > Signed-off-by: Arnd Bergmann Acked-by: Eduardo Valentin > --- > drivers/acpi/Kconfig| 2 +- > drivers/gpu/drm/etnaviv

Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Hey, On Mon, Apr 17, 2017 at 10:34:34AM -0700, Eduardo Valentin wrote: > Hey, > > On Mon, Apr 17, 2017 at 11:31:45AM +0530, Viresh Kumar wrote: > > Hi Guys, > > > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid > > high thermal sta

Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Hey, On Mon, Apr 17, 2017 at 10:34:34AM -0700, Eduardo Valentin wrote: > Hey, > > On Mon, Apr 17, 2017 at 11:31:45AM +0530, Viresh Kumar wrote: > > Hi Guys, > > > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid > > high thermal sta

Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Hey, On Mon, Apr 17, 2017 at 11:31:45AM +0530, Viresh Kumar wrote: > Hi Guys, > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid > high thermal states for a platform. But it wasn't glued really well with > cpufreq core. > > This series tries to improve interactions

Re: [PATCH V2 00/17] thermal: cpu_cooling: improve interaction with cpufreq core

Hey, On Mon, Apr 17, 2017 at 11:31:45AM +0530, Viresh Kumar wrote: > Hi Guys, > > The cpu_cooling driver is designed to use CPU frequency scaling to avoid > high thermal states for a platform. But it wasn't glued really well with > cpufreq core. > > This series tries to improve interactions

Re: [PATCH v5 2/2] thermal: core: Add a back up thermal shutdown mechanism

tical situation to trigger a system > shutdown > + * after a known period of time. By default the delay is 0 millisecond > + */ > +void thermal_emergency_poweroff(void) > +{ > + int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS; > + /* > + * poweroff_delay_ms must be a carefully profiled non-zero value. > + * Its a must for thermal_emergency_poweroff_work to be scheduled > + */ > + if (!poweroff_delay_ms) This cannot be negative. I think it better suits here: + if (poweroff_delay_ms <= 0) Let's avoid hidden unsigned round up issues here. Despite the above, you can add my Acked-by: Eduardo Valentin <edubez...@gmail.com> BR, Eduardo Valentin signature.asc Description: Digital signature

Re: [PATCH v5 2/2] thermal: core: Add a back up thermal shutdown mechanism

em > shutdown > + * after a known period of time. By default the delay is 0 millisecond > + */ > +void thermal_emergency_poweroff(void) > +{ > + int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS; > + /* > + * poweroff_delay_ms must be a carefully profiled non-zero value. > + * Its a must for thermal_emergency_poweroff_work to be scheduled > + */ > + if (!poweroff_delay_ms) This cannot be negative. I think it better suits here: + if (poweroff_delay_ms <= 0) Let's avoid hidden unsigned round up issues here. Despite the above, you can add my Acked-by: Eduardo Valentin BR, Eduardo Valentin signature.asc Description: Digital signature

Re: [PATCH v4 2/2] thermal: core: Add a back up thermal shutdown mechanism

Hey, On Fri, Apr 14, 2017 at 08:42:20AM -0700, Eduardo Valentin wrote: > Hello again, > > On Fri, Apr 14, 2017 at 08:38:40AM -0700, Eduardo Valentin wrote: > > Hey, > > > > On Fri, Apr 14, 2017 at 02:22:13PM +0530, Keerthy wrote: > > > orderly_poweroff i

Re: [PATCH v4 2/2] thermal: core: Add a back up thermal shutdown mechanism

Hey, On Fri, Apr 14, 2017 at 08:42:20AM -0700, Eduardo Valentin wrote: > Hello again, > > On Fri, Apr 14, 2017 at 08:38:40AM -0700, Eduardo Valentin wrote: > > Hey, > > > > On Fri, Apr 14, 2017 at 02:22:13PM +0530, Keerthy wrote: > > > orderly_poweroff i

Re: [PATCH v4 2/2] thermal: core: Add a back up thermal shutdown mechanism

Hello again, On Fri, Apr 14, 2017 at 08:38:40AM -0700, Eduardo Valentin wrote: > Hey, > > On Fri, Apr 14, 2017 at 02:22:13PM +0530, Keerthy wrote: > > orderly_poweroff is triggered when a graceful shutdown > > of system is desired. This may be used in many critical sta

Re: [PATCH v4 2/2] thermal: core: Add a back up thermal shutdown mechanism

Hello again, On Fri, Apr 14, 2017 at 08:38:40AM -0700, Eduardo Valentin wrote: > Hey, > > On Fri, Apr 14, 2017 at 02:22:13PM +0530, Keerthy wrote: > > orderly_poweroff is triggered when a graceful shutdown > > of system is desired. This may be used in many critical sta

Re: [PATCH v4 1/2] thermal: core: Allow orderly_poweroff to be called only once

seen the above tagging before. Anyways, Rui, please pick this one, or let me know if you prefer me to queue it for you. Acked-by: Eduardo Valentin <edubez...@gmail.com> > --- > > Changes in v4: > > * power_off_triggered declaration together with mutex definition. >

<    1   2   3   4   5   6   7   8   9   10   >